[Koha-bugs] [Bug 9454] NewBasket does not use placeholders in sql

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9454

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to comment #4)
> > The original code says: if a variable ($basketcontractnumber, $deliveryplace
> > or $billingplace) is equal to 0 or an empty string, we call ModBasketHeader
> > with an undefined value.
> > 
> > If someone calls the routine with "", we want to insert undef, not ""
> 
> The only call of the routine in basketheader.pl already forces
> basketcontractnumber to undef in these conditions and this would seem the
> appropriate place to validate inputs.

There are 2 places: 
- C4::Acq::NewBasket, where the validation is done.
- In the basketheader.pl script, the validation is only done for the
contractnumber value.

I don't know if it is a big deal, but in the doubt, without modification of
this patch I would prefer that someone else of the QA team gives his opinion on
it.

-- 
You are receiving this mail because:
You are watching all bug changes.