[Koha-bugs] [Bug 9506] Values are false in the generated pdf for basketgroups

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9506

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #2 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Good work Jonathan ;-)
I sign off.
I like the replacement of the array by a hash too. It will be easier to edit
basketgroup pdf templates!

Maybe "Discount amount" would be better than "Discount price"? But I am not
fluent in english... and it could be fixed latter.

Details of my tests ; 

BEFORE applying the patch :

I create a bookseller NOYES with :
- List item price includes tax: No
- Invoice item price includes tax: Yes
- tax rate : 5.5
- discount : 9%

I create a basket with :
- a book costing 100 euros (vendor price)
- a book costing 50 euros (vendor price), in 2 items

I check basket.pl : all is correct :
for the book costing 100 euros :
- RP tax exc. : 100
- ecost tax exc : 91
- RP tax inc : 105.5
- ecost tax incl : 96
and half these values for the book costing 50 euros

total correct (on discounted prices)
- Total tax exc. (EUR) 182.00
- Total tax inc. (EUR) 192.00
- GST (EUR) 10.00    

I close the basket, create a basketgroup, and print the basketgroup with
layout3pages
=> WRONG prices

1st page :
RRT GST Inc.  : 200
Discount Price : 182
Total GST exc  : 172,51
GST  : 9,49
Total GST Inc. : 182

2d page, for the book costing 100 euros :
RRT GST Inc  : 100
Discount price GST Exc.  : 86,26
Total GST Inc. : 91

AFTER applying the patch :

I print again the same basketgroup with layout3pages
=> RIGHT prices
1st page :
Total RRP tax exc : 200
Total RRP tax incl: 211
GST : 10
Total discount : 18
Total Tax exc  : 182
Total Tax incl : 192

2d page, for the book costing 100 euros tax exc :
RRP tax exc : 100
RRP tax inc : 105.5
Discount price : 9
Total tax exc.  : 91
Total tax incl : 96

For the 2 items of the book costing 50 euros, everything is correct too.
(Total tax exc.  : 91 ; Total tax incl : 96)

Same test with a 2d bookseller YESYES with :
- List item price includes tax: Yes
- Invoice item price includes tax: Yes

=> everything is OK after patch is applied :
2 items of a book with vendor price = 105,50 EUR tax inc :
I print the basketgroup with layout3pages
1st page :
Total RRP tax exc : 200
Total RRP tax incl: 211
GST : 10
Total discount : 18
Total Tax exc  : 182
Total Tax incl : 192

2d page, for the book costing 105,5 euros tax inc :
Qty : 2
RRP tax exc : 100
RRP tax inc : 105.5
Discount price : 9
Total tax exc.  : 182
Total tax incl : 192




M. Saby
Rennes 2 university

-- 
You are receiving this mail because:
You are watching all bug changes.