[Koha-bugs] [Bug 9383] Bad logic, missing params, and irregular labeling for Members scripts

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9383

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
(In reply to comment #2)
> (In reply to comment #1)
> 
> > Personally, I don't see why Professionals should be separated from the rest
> > of patrons (other than Organizations). In fact, I don't know if there is
> > even a point separating Organizations! I think Primary/Secondary/Mobile are
> > fine clear across the board.
> 
> Professional type patrons can be created with links to specific
> Organizations. I don't know much about how this works in practice but it's
> obviously a feature which was created with specific intent.

I agree, Owen, but I was referring to the separation of phone/email labels
rather than the actual patron types. I don't know why an organisation would
need "organisation phone" rather than "primary phone" or why a professional
would have different labels for the same fields as any other individual patron. 

I think there might be some disagreement about which labels I've chosen to
apply in this patch (like using Mobile Phone for mobilephone, as I think some
people prefer to use Other phone as mobilephone might actually be the Primary
Phone). However, the current templates don't actually work to differentiate
them anyways at the moment, because the categorycode param isn't passed to the
template from the perl. 

Besides that, the labels appear to be inconsistent between the patron entry
page and the patron detail page. I imagine it would be disconcerting to put
your work phone as your primary phone and then have your home phone show up as
your primary phone on your page. (Mind you, that's awfully detail-oriented, so
maybe most people wouldn't notice.)

-- 
You are receiving this mail because:
You are watching all bug changes.