[Koha-bugs] [Bug 9421] tools/picture-upload.pl not Plack-compatible

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9421

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15079|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 15103
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15103&action=edit
Bug 9421: tools/picture-upload.pl not Plack-compatible

This patch avoids using file-level private variables in subroutines
by passing the needed variables as parameters to the subroutines.

To test (under Plack):
1) Try uploading a patron image without applying the patch. Notice
   it fails.
2) Apply patch.
3) Try uploading a patron image again, noticing this time it succeeds.

To test (under Apache):
1) Apply patch.
2) Try uploading a patron image, confirm that it works.

Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Fixes Plack, does not break Apache. Works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.