[Koha-bugs] [Bug 9045] Adding some parameters to export_borrowers.pl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9045

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #6 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
Nice addition! Two points of attention: 

Looking for a cardnumber that does not exist produces: DBD::mysql::st
fetchrow_array failed: fetch() without execute() at ./export_borrowers.pl line
112.
Please check if your query still has result records. Note that you should
already do that on line 91 (first fetchrow). This may already give no results
and a uninit warning in the log.

Documentational note: Using a condition on a character field requires using
quotes like:  ./export_borrowers.pl -s @ -where "surname='De Rooy'"
I would suggest explaining this in the usage statement with a simple example
(not using the previous one :)

Just for the record: The where clause coming from the command line is not
checked, so could be misused (sql injection). Note that does not block this
patch; 
more command-line scripts in misc contain similar constructs. 

Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.