[Koha-bugs] [Bug 9392] confirmation does not appear for negative notforloan items issues

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9392

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14615|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 15189
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15189&action=edit
[SIGNED-OFF] Bug 9392: confirmation does not appear for negative notforloan
items issues

When checking-out an item marked "not for loan" with a positive value,
you get a message to forbid or confirm issue (depending on
AllowNotForLoanOverride syspref).  For an item with a negative value
(usually during acquisition process), the issue is made without forbid
or confirm message.

This patch simply changes the test notforloan > 0 into notforloan != 0.

Test plan :
- Checkout an item with items.notforloan = 0
=> The item is issued without message
- Checkout an item with items.notforloan > 0
=> A message forbids or asks confirmation to override
- Checkout an item with items.notforloan < 0 (e.g., on order)
=> A message forbids or asks confirmation to override

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Checked with AllowNotForLoanOverride on and off.
All tests and QA script pass.

-- 
You are receiving this mail because:
You are watching all bug changes.