[Koha-bugs] [Bug 9424] Move JavaScript out of header include

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Feb 8 19:14:52 CET 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9424

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15101|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 15191
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15191&action=edit
Bug 9424 - Move JavaScript out of header include

This patch removes JavaScript "onlick" attributes from header.inc and
moves the functionality to staff-global.js. This is in keeping with the
idea of progressive enhancement.

This patch also makes a couple of minor changes to staff-global.js to
fix jsHint warnings.

To test, be sure to clear your browser cache after applying the patch.
Test the logout link under several conditions:

- intranetbookbag enabled, virtualshelves enabled
- intranetbookbag enabled, virtualshelves disabled
- intranetbookbag disabled, virtualshelves enabled
- intranetbookbag disabled, virtualshelves disabled

Logout should be successful with no JavaScript errors. This array of
tests is required because of the Cart-clearing action of logging out and
the changes made in this patch to the way Car/Lists JavaScript is
included.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list