[Koha-bugs] [Bug 9571] Fix width for textareas in Edit Item screen

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9571

--- Comment #7 from David Cook <dcook at prosentient.com.au> ---
(In reply to comment #3)
> Created attachment 15173 [details] [review]
> Bug 9571 [Alternate] Fix width for textareas in Edit Item screen
> 
> This alternative patch modifies the script where the input markup is
> built and adds an alternative configuration for textareas. This gives
> the textareas explicit "cols" and "rows" attributes. I think this
> solution is preferable to a style fix because it solves the bug while
> eliminating some invalid markup (no "size" or "maxlength" attributes on
> textareas, which are invalid without explicit dimensions).
> 
> To test, add a nice big chunk of text to an existing item's item field
> like "Public note" (952$z), save, and edit again. The field should now
> be displayed in a more comfortably-sized textarea.

I like the idea of using explicit "cols" and "rows". I wasn't sure whether it
would be preferable to do that or use CSS, so I went with the latter.

I think it might be an idea to increase the number of "cols" to 69 or so, so
that it is closer to the length of the other input fields, but I might just be
in favour of that number, because it looks better on my monitor. The same might
not be true for others.

-- 
You are receiving this mail because:
You are watching all bug changes.