[Koha-bugs] [Bug 9603] Fix layout of Patron Card Creator Layout screen for display in IE

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15287|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 15305
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15305&action=edit
[SIGNED-OFF] Bug 9603 - Fix layout of Patron Card Creator Layout screen for
display in IE

Currently, the layout for the Edit/Add Layout screen of the Patron Card
Creator is in complete disarray, when viewed in Internet Explorer (of
any version).

This patch removes empty and extraneous fieldset and li elements. It
also adds ol elements to all of the nested li elements, which were
creating layout problems in IE, especially when they were interwoven
with div elements. IE had problems opening and closing tags, which
created some major chaos.

This patch also adds stylistic spacing/nesting to the HTML, so that it
is easier to visually separate elements when debugging. 99.9% of the
mods in this patch are actually just whitespace alterations.

Test Plan:

Before applying the patch:

    1) Open Koha using any version of Internet Explorer
    2) Go to the Patron Card Creator in the Tools module
    3) Go to Manage Layouts
    4) Add or Edit a layout
    5) Note that all the elements on the page are presented in haphazard
       fashion with the navbar pushed to the bottom of the page.

Apply the patch.

    6) Refresh the page
    7) Note that the elements are now laid out on the page in the same
       way that they would appear in a modern browser like Firefox or
       Chrome (look at the same page in one of those browsers to
       confirm).

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

I don't like all the whitespace changes in this patch. Making whitespace
changes as well as code/markup changes is generally speaking a violation
of coding guidelines. However, this is not a frequently-modified
template and a diff which ignores whitespace changes shows that the real
changes are minor and effective.

I'm signing off and correcting the commit message to include a
description of the fix and the test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.