[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #18 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
I like the feature! But IMO it needs some more attention before pushing it: 

Issue while resolving merge conflict in circ/waitingreserves.pl: 
The dateformat template var has been removed in master (was in the patch) but
is still used in one line of template (waitingreserves.pl). Please check. 

IMO it is confusing that the old pref exists besides the new column in issuing
rules. I would suggest simplification by obsoleting pref
ReservesMaxPickUpDelay.
At this time behavior is not so clear anymore. Note that there is no comment
either on the preferences form that this syspref could be overruled by issuing
rules.
And the other way around: If no rule is found, the pref still holds. Does the
user still understand that from the rules form? 

GetMaxPickupDate: It may be worth to consider if it would be easier to add a
maxpickupdate to the reserves table instead of recalculating it "everywhere".
GetMaxPickupDelay: Only called by GetMaxPickupDate. 
A serious issue IMO is the FIXME in CancelExpiredReserves. Instead of calling
GetMaxPickupDelay, you just use the pref value!
I understand that from performance point of view, but this is "killing" the
feature.
When using the cron job to remove holds, the new pickup delay should be used
not the old one.
Note that you could easily resolve this by looking at a maxpickupdate when
adding this to the reserve table and calculating it at confirm hold time. 

Minor representation issue: In the opac user form I see the max pickup date.
Would it be consistent to show it on staff catalogue detail too (Holds tab)? 

Setting to Failed QA, mainly for the cancelling holds issue.

-- 
You are receiving this mail because:
You are watching all bug changes.