[Koha-bugs] [Bug 9293] action_logs not tracking payments

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9293

--- Comment #11 from Chris Cormack <chris at bigballofwax.co.nz> ---
Comment on attachment 15136
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15136
Bug 9293 - action_logs not tracking payments

Review of attachment 15136:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9293&attachment=15136)
-----------------------------------------------------------------

::: C4/Accounts.pm
@@ +25,5 @@
>  use C4::Members;
>  use C4::Circulation qw(ReturnLostItem);
> +use C4::Log qw(logaction);
> +
> +use Data::Dumper qw(Dumper);

This works, but since we already make use of Module::Load::Conditional in Koha,
we could use it, and can_load to load Data::Dumper only if we need it ie

if (C4::Context->preference("FinesLog") ) {
can_load(Data::Dumper);
}

Probably not needed here, but every module we don't use that we load is a small
performance hit

-- 
You are receiving this mail because:
You are watching all bug changes.