[Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688

--- Comment #66 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Well, as far as I can test, all is working. 

I tried what was described in the original test plan, also did follow the
comments and successive tests and fixes.

I do not have in my DB many subscriptions but those where transformed
correctly. 
I could generate custom number patterns, rename, reuse, mark and verify
irregularities, etc. 

For me it's very very good. I suppose that someone with more experience or data
in subscriptions could test more extensively.

Only note for my part are this simple errors:
a) C4/Serial.pm, line 1327, missing space in "=over 4", I could do that.
b) C4/Serials/Frequency.pm and C4/Serials/Numberpattern.pm 
these files do not obey coding guidelines over POD comments
http://wiki.koha-community.org/wiki/Coding_Guidelines#PERL13:_POD
what is missing is general description, etc 
(koha-qa complains about =head3 without 2 and 1)
I couldn't do that.

Without these corrections is guaranteed to go "Failed QA", and it would be a
shame.

-- 
You are receiving this mail because:
You are watching all bug changes.