[Koha-bugs] [Bug 7804] Add Koha Plugin System

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804

--- Comment #87 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
(In reply to comment #86)
> (In reply to comment #85)
> > I still get that same error message from the unit test. I am not using CAS.
> > 
> > Also, I have two questions about the unit test:
> > 1) What are you doing with the can_load test?
> 
> It's just testing the Module::Load::Conditional::can_load. Not necessary,
> but it doesn't hurt to test.

Okay. I was trying to figure out wizardry you were trying to test by re-loading
the module.

> > 2) Doesn't the Koha::Plugins::Handler module handle running plugins?
> 
> Yes, it does. We can't actually run a plugin from the unit test though.

Why not (other than the fact that the test is failing with the bizarre
Auth_with_cas error)?

> > Finally, I am a little bit concerned about your use of "die." If someone
> > navigates to a plugins page when plugins are disabled, they will get a nasty
> > Perl error rather than a styled page that informs them plugins are disabled.
> 
> I thought you wanted it to be that way. I can add a followup to change that.

Thanks. The plugin code should refuse to run, but using die is not necessary
(you could, for example, simply return, and check that the plugin object exists
before using it).

-- 
You are receiving this mail because:
You are watching all bug changes.