[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #34 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to comment #32)
> Preliminary comments:
> Report Holds awaiting pickup:
> A DateTime object can only be compared to another DateTime object
> (DateTime=HASH(0x53d7020), 2013-02-22). at
> /usr/share/koha/testclone/circ/waitingreserves.pl line 110
> 
> Another serious issue: During upgrade all reserves need a maxpickupdate. Now
> they are null.

Fixed.


> Before I would signoff and pass qa, it would be very useful to have another
> signoff on this one. After testing your changes thorougly, another external
> signoff (maybe from Kyle?) is welcome too. The nature of these patches asks
> for more extensive testing.

Yes! I tested some cases but there are so many specific cases, it is difficult
to test everything alone. 

> Please note that a more detailed test plan could help.

Since the patch affects all the pages related to holds, I don't know how to
write a complete test plan.

(In reply to comment #33)
> Please have a look too at bug 5786.

I did. I think my patch is closer to be pushed to master than bug 5786.
I didn't find where the new column issuingrules.reservesmaxpickupdelay is used
elsewhere than in the issuingrules management (add/remove in DB + in tt files).

-- 
You are receiving this mail because:
You are watching all bug changes.