[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
That was my first instinct as well, but the way the scripts work, it didn't
'fit' in that function. In fact, that function doesn't deal with items statuses
at all! IsAvailableForItemLevelRequest actually deals with the status so that
was where the changes needed to be made.

I have implemented your optimization for the return value.

Kyle

(In reply to comment #4)
> QA Comments:
> 
> I am not sure at all but the check on the notforloan value should not be
> made in the CanItemBeReserved routine ? Is not it more relevant ?
> 
> If not, your patch has to be resubmitted for a little modification.
> 
> The test in IsAvailableForItemLevelRequest is:
> 
>   return ($available_per_item and ($item->{onloan} or
> GetReserveStatus($itemnumber) eq "W" or $item->{notforloan} < 0));
> 
> it will be optimized if you change the order, as:
> 
>   return ($available_per_item and ($item->{onloan} or $item->{notforloan} <
> 0 or GetReserveStatus($itemnumber) eq "W" ));
> 
> Marked as Failed QA.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.