[Koha-bugs] [Bug 9211] days_between wrong behaviour

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9211

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |paul.poulain at biblibre.com

--- Comment #5 from Paul Poulain <paul.poulain at biblibre.com> ---
QA Comment:
  * checking usage of days_between =
    - in C4/Circulation, it's used in _debar_user_on_return. The relevant lines
are:
    my $deltadays = $calendar->days_between( $dt_due, $dt_today );
        if ( $deltadays->subtract($grace)->is_positive() ) {
  => seems logical that $deltadays is positive

    - in C4/Overdues.pm, it's used in _get_chargeable_units
            $charge_duration = $calendar->days_between( $dt1, $dt2 );
  => seems OK as well

  * patch passes koha-qa.pl
  * prove t/Calendar.t is working well after a tiny followup i'll attach

TO RM = I don't see anything wrong with this patch, but it's a sensible one, so
it's worth looking deeply !!!

-- 
You are receiving this mail because:
You are watching all bug changes.