[Koha-bugs] [Bug 9383] Bad logic, missing params, and irregular labeling for Members scripts

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9383

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au
                   |ity.org                     |

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Created attachment 14552
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14552&action=edit
Bug 9383 - Bad logic, missing params, and irregular labeling for Members
scripts

To test:

Before patch:

1) Add new patrons with "organization", "adult", and "professional" category
types/codes.
2) Observe that they all have input boxes for Primary phone, Secondary phone,
and Other phone.
3) Also, observe that they all have input boxes for Primary email, and
Secondary email
4) Save the patron and look at the Details page that should come up
automatically
5) Note that your "Secondary Phone" now shows up as "Other Phone" and your
"Other phone" shows up as "Secondary Phone". 

---

After Patch:

1) Organization will have input boxes for "Organization phone" and
"Organization" email, which correspond to the (Primary) phone/email fields.

2) Professionals will have input boxes for Primary/Secondary phones (but not
Mobile phones) which correspond to phone/phonepro DB fields.

3) Other patrons will have input boxes for Primary/Secondary/Mobile, which
correspond to phone, phonepro, mobile DB fields.

---

Personally, I don't see why Professionals should be separated from the rest of
patrons (other than Organizations). In fact, I don't know if there is even a
point separating Organizations! I think Primary/Secondary/Mobile are fine clear
across the board.

So maybe a follow-up to this would actually eliminate the conditions for "I"
(organization) and "P" (professional) while retaining the consistent labelling
between the memberentrygen.pl and moremember.pl files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.