[Koha-bugs] [Bug 7830] return policy error in hold policy by item type after upgrade

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7830

MJ Ray (software.coop) <mjr at software.coop> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mjr at software.coop

--- Comment #2 from MJ Ray (software.coop) <mjr at software.coop> ---
Just seen this on a 3.10 but might have been introduced when that catalogue
upgraded to 3.8 - I think they used holds very rarely.

The patch to bug #7144 set default NULL but the code doesn't seem to handle a
NULL value for that column and it's not mentioned in the perldoc
C4/Circulation.pm.

Also, there appears to be a typo in the patch
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7533&action=diff on
bug #7144 - prefernce where it should be preference.

Also, the patch seemed to add to installer/data/mysql/atomicupdate but not
updatedatabase.pl too, which might be a problem but doesn't seem to be harming
my catalogue.

Is the best fix for a database update branch_item_rules set returnbranch=
(C4::Context->preference('HomeOrHoldingBranchReturn') || 'homebranch') where
returnbranch is NULL, or to handle NULL better in C4/Circulation, or to handle
it in callers of C4::Circulation?

-- 
You are receiving this mail because:
You are watching all bug changes.