[Koha-bugs] [Bug 7804] Add Koha Plugin System

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #74 from Kyle M Hall <kyle at bywatersolutions.com> ---
> 1) Koha::Plugins cannot be used without a koha-conf.xml file that is
> configured to enable plugins. That's a problem! The check needs to be done
> at run-time rather than compile time.

Fixed!

> 2) The unit test in t/Plugins.t is data dependent. It would be much better
> to mock the configuration data. Barring that, the test should be moved to
> t/db_dependent.

Moved to db_dependent

> 3) The test adds '.' to @INC. Unfortunately, tests are not usually run from
> t/, so it always fails when I run prove t/. The solution is to get the
> directory component from __FILE__

Fixed!

> 4) The test fails spectacularly for me:

Assuming you have all the required perl dependencies install, I'm stumped on
this one. All the tests pass just fine for me. Do you have CAS enabled? It
seems to be related to that.

-- 
You are receiving this mail because:
You are watching all bug changes.