[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
>  - template_name   => "members/purchase-suggestions.tmpl" could be .tt

Fixed!

>  - in suggestion.pl, %hashlists is passed twice.

Fixed!

>  - in suggestion.pl, $redirect could be eq to "purcharse-suggestion" with a
> new param borrowernumber=[%borrowernumber%] in order to open the possibility
> for an other script to use this redirection.

Fixed!

>  - in purchase-suggestion.tt, some includes are useless: calendar.inc,
> tablesorter.js

Fixed!

>  - The new tab is sometimes displayed on 2 lines and sometimes on 1 lines
> depending on which tab is enabled. I don't know how to fix that...

This is because the tabs are not the same width on every page. Sometimes they
are wide enough to get both words on one line, sometimes they are not. I've
fixed this by forcing each word to always be on a separate line.

>  - on the way, could you fix 4 withespaces:
>    * suggestion/suggestion.pl                                               
> FAIL
>     forbidden patterns          FAIL
>       The patch introduces a forbidden pattern: withespace character  (77)
>       The patch introduces a forbidden pattern: withespace character  (138)
>    * koha-tmpl/intranet-tmpl/prog/en/modules/members/purchase-suggestions.tt
> FAIL
>     forbidden patterns          FAIL
>       The patch introduces a forbidden pattern: withespace character  (71)
>       The patch introduces a forbidden pattern: withespace character  (62)
> 

Fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.