[Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #35 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Tested the cronjob with various settings of email parameter.

QA Comment:
This patch unfortunately took some time to reach this point. But hopefully we
do now. Just some minor comments. (Thanks for paying attention to various
details along the way!)

The (double) use of $email in prepare_letter_for_printing is still little bit
confusing. But could be taken care of in a followup. (In both cases there is no
e-mail.) Could the email parameter be removed or just be empty in those two
lines? 

Not an error, but just a thought:
If I run perl misc/cronjobs/overdue_notices.pl -email email,emailpro
I get:
Use of uninitialized value in string ne at misc/cronjobs/overdue_notices.pl
line 491.
I know that I should do -email email -email emailpro and that works fine. But
is it an idea to make it work too? Or should you better check the contents of
this parameter and warn? (This may be somewhat hypothetical for a cronjob, I
realize..) 

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.