[Koha-bugs] [Bug 8292] clicking ignore on hold cancels transfer

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14474|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 14841
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14841&action=edit
[SIGNED-OFF] Bug 8292 - Clicking ignore on hold cancels transfer

Clicking 'ignore' in the hold confirmation box does nothing
but make the confirmation box disappear. No further actions are
taken. The code to do the transfer is never executed, and the item sits
at the holdingbranch library.

If you're ignoring the hold, you want the checkin to proceed as if the
hold had never popped up in the first place, and that means doing a
return home if appropriate.

To test, place a hold on an item for delivery to Library A. Check that
item in at Library B. Click "Ignore" in the hold confirmation message.
Before the patch, doing so would simply trigger JavaScript to hide the
dialog. After the patch the form will be sumitted and the item will be
transfered without fulfilling the hold.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Added description and test plan to the best of my understanding of what
this patch is trying to accomplish based on the bug report. The patch
works if I'm correct in my test plan.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
All tests and QA script pass.

Tests done:
1) Add an item hold on an item from library B for a patron from library A,
   pickup location is library A
2) Check in item at library A
3) Click 'ignore'
a) AutomaticItemReturn is ON = Koha provides a link to print the transfer
   slip.
b) AutomaticItemReturn is OFF = Koha provides 3 options: Confirm transfer
   and print slip, confirm transfer, don't confirm transfer.

Without the patch the item was returned, but the transfer wasn't triggered.

-- 
You are receiving this mail because:
You are watching all bug changes.