[Koha-bugs] [Bug 9493] confirmations for user holds in opac are not translatable

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Jan 28 15:38:12 CET 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9493

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14862|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 14890
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14890&action=edit
[SIGNED-OFF] Bug 9493: confirmations for user holds in opac are not
translatable

In opac-user.tt, javascript for user holds confirmations (cancel, suspend,
resume) are not translatable.
This is because text is in onclick attribute, withtout javascript method for
translatable strings : _().

This patch moves those strings as variables into script tag and sets them
translatable.

Test plan :
- set a hold for a user
- Go to OPAC user page "my summary"
- click on "Cancel"
=> you get a confirmation message
- click on "Suspend all holds"
=> you get a confirmation message
- click on "Resume all suspended holds"
=> you get a confirmation message
Test this is 'en' and another language.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list