[Koha-bugs] [Bug 9505] acqui/invoices.pl contains an unnecessary loop
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Wed Jan 30 20:15:19 CET 2013
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9505
Galen Charlton <gmcharlt at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #14943|0 |1
is obsolete| |
--- Comment #3 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 14963
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14963&action=edit
bug 9505 refactor loops in invoices.pl
- Remove an unnecessary loop where output just
recreated input.
- Remove unnecessary temp variables that obscure code purpose.
- Call the variable containing invoices, invoices
rather than anonymous and ambiguous results
reflect namechange in template.
- Lists are passed to template as array refs;
declare them as scalars as that is how we use them.
- No need to introduce the whole namespace of some C4
modules for 1 routine.
Test plan:
Note that this patch should not change any visible behavior.
[1] Open the invoice search page.
[2] Verify that the list of suppliers in the drop-down
on the search form is complete.
[3] Verify that the list of libraries in the drop-down
on the saerch form is complete.
[4] Perform a search. Verify that the list of invoices
is correct.
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list