From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 00:05:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Jun 2013 22:05:45 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #36 from Katrin Fischer --- Starting with some tests and a code review for these patches: 1) There are some problems with those patches pointed out by the QA script: FAIL acqui/addorder.pl OK pod FAIL forbidden patterns forbidden pattern: tab char (line 126) OK valid OK critic FAIL acqui/cancelorder.pl OK pod OK forbidden patterns FAIL valid Use of qw(...) as parentheses is deprecated OK critic 2) cancelorder.pl notes this: +# FIXME: C4::Search is needed by C4::Items::GetAnalyticsCount, which is called +# by C4::Acquisition::DelOrder. But C4::Search is not imported by C4::Items. +# Once this problem is resolved, the following line can be removed. +# See Bug 7847. +use C4::Search; 7847 is now marked resolved, can this line be removed? 3) From looking at the code it seems like you no longer have the choice to delete the bibliographic record or to keep it. 4) Some little typos: canceled -> cancelled occured -> occurred 5) Just a pet peeve of mine: a linked 'here' is not friendly if you are quickly scanning a page for the right link. It's always better to link the words that actually describe what the link will do:

Click here to return to previous page

Could just be a linked: Return to previous page Or maybe just a 'OK'? 6) A bad one: Please please, don't add untranslatable strings to the database: + if($reason) { + $query .= " + , notes = IF(notes IS NULL, + CONCAT('Cancellation reason: ', ?), + CONCAT(notes, ' - Cancellation reason: ', ?) + ) + "; + } We really need to take care of that in a nicer way or at least not have any hardcoded string in there or have it in the template. It might be worth having an authorized value and a separate field to store cancellation reasons as you might want to look up the reasons in reports in a nice way later on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 00:58:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Jun 2013 22:58:17 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | --- Comment #52 from Katrin Fischer --- Hi Jonathan, I really like the idea of this. Starting with a code review and running the automated tests on the codes I found a few things: 1) The updatedatabase states: + print "Upgrade to $DBversion done (Add category ORDRSTATUS values in authorised_values table)\n"; But it does not actually add an authorised value? And it looks like we don't need one and can have the values in the template, so it might just be enough to correct the line. Please also add the bug number :) 2) Hm not sure about this line, does it maybe belong to 5394? order.internalnotes ) %][% order.internalnotes %]
[% END %][% order.isbn %] 3) Capitalization: Search Orders + 4) Patches fail the QA script: FAIL t/db_dependent/Acquisition/close_reopen_basket.t OK pod OK forbidden patterns FAIL valid Use of qw(...) as parentheses is deprecated OK critic 5) Checking my database and comparing it to kohacstructure in your patch, the order of subscriptionid and parent_ordernumber are reversed. Not really sure how to explain that right now, so just noting. Will continue to test as nothing is severe so far, but can you please provide a follow-up? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 02:09:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 00:09:10 +0000 Subject: [Koha-bugs] [Bug 5390] library choice not remaining when searching opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5390 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3388|0 |1 is patch| | Attachment #3388|application/octet-stream |text/plain mime type| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 02:31:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 00:31:31 +0000 Subject: [Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019 Derryn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |derrynj at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 03:45:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 01:45:53 +0000 Subject: [Koha-bugs] [Bug 10494] KohaBranchName sends useless warnings to log if supplied library code is null or not present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10494 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 03:56:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 01:56:24 +0000 Subject: [Koha-bugs] [Bug 10442] Remove references to non-standard "error" class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 --- Comment #7 from Galen Charlton --- Comment on attachment 19296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19296 [PASSED QA] Bug 10442 - Remove references to non-standard "error" class Review of attachment 19296: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10442&attachment=19296) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt @@ -171,5 @@ > [% END %] > > > - > - I'm not sure whether simply removing this is OK. There is code in additem.js that looks for the existence of a div whose CSS class is "error"; if such a div is not present, an error message (e.g., when trying to add a duplicate item) would have no place to be displayed. Setting bug back to "Signed-off" for QA to look into this. If I'm right, additem.js will need to be modified, e.g., to use a div ID rather than a div class to locate the placeholder for an error message. It may be necessary to apply the patch for bug 10483 to be able to test a situation where attempting to add an item during the process of creating a new order results in an error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 03:56:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 01:56:35 +0000 Subject: [Koha-bugs] [Bug 10442] Remove references to non-standard "error" class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 04:03:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 02:03:11 +0000 Subject: [Koha-bugs] [Bug 10484] serials-edit.pl not checking for barcode field before checking for barcode subfield In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10484 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 04:06:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 02:06:39 +0000 Subject: [Koha-bugs] [Bug 6553] Parentheses in corporate author break tracings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #18 from Galen Charlton --- Pushed to master. Thanks, Liz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 04:09:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 02:09:55 +0000 Subject: [Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- (In reply to Owen Leonard from comment #0) > The course reserves entry form shows an error message instead of a form > field for the department if no departments are defined: "No DEPARTMENT > authorised values found! Please create one or more authorised values with > the category DEPARTMENT." A question about the premise of this patch, possibly for Kyle: is there a functional reason why setting a department is absolutely required? If so, why is courses.department a nullable column? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 04:14:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 02:14:51 +0000 Subject: [Koha-bugs] [Bug 10497] star ratings not showing right in ccsr detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 04:22:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 02:22:21 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #92 from Galen Charlton --- (In reply to Magnus Enger from comment #91) > (In reply to Paul Poulain from comment #89) > > We spoke of it already, at KohaCon12 In Edinburgh, and on koha-devel. See > > http://wiki.koha-community.org/wiki/Koha_Namespace_RFC > > > > However, I agree it's worth taking time to discuss it, because a lot of > > things will depend on the decision we take here. > > How do we move this forward? Are there competing proposals? Should it be a > topic for an IRC meeting? The namespace question is not a blocker for DBIx::Class support -- the main blocker at the moment is addressing the concern of the DBIC maintainer about the current patch's use of DBIC_DONT_VALIDATE_RELS. I will be looking at this over the next couple weeks. As far as the namespace questions are concerned, because of the potential complexity, in my view an IRC meeting is not well-suited to discussing it; as I previously stated, bug 8309 and/or koha-devel are more suitable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 08:30:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 06:30:07 +0000 Subject: [Koha-bugs] [Bug 10393] To add some shortcuts to acquisitions main screen e.g. RECEIVE SHIPMENT and the FILTER BOX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10393 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Amit, I am not sure how this link is a shortcut to the current behaviour? Searching for the vendor for example by sending an empty search and then clicking the receive shipment link there? To me it seems to just reverse the order of things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 09:39:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 07:39:53 +0000 Subject: [Koha-bugs] [Bug 10237] Enforce authorized value character limitations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10237 --- Comment #12 from Katrin Fischer --- I think having spaces in the LOC code can lead to unexpected search results. I know there is a bug reporting problems for very similar codes, like EBOOK and EBOOKX. I tend to have the restrictions being put on LOC, because in general it seems more safe to use good codes there. For SUGG it probably doesn't give you trouble, but I think the codes are not displayed anywhere, so maybe the codes could be cleaned up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 09:52:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 07:52:00 +0000 Subject: [Koha-bugs] [Bug 10498] Place Hold on Order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10498 --- Comment #4 from Colin Campbell --- Not having any problem applying this to a clean master branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 10:05:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 08:05:00 +0000 Subject: [Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 10:05:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 08:05:04 +0000 Subject: [Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19220|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 19305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19305&action=edit Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Test plan: - git grep ModOrderItem should return no result. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 10:05:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 08:05:18 +0000 Subject: [Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 10:11:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 08:11:28 +0000 Subject: [Koha-bugs] [Bug 10275] UT: OrderFromSubscription.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10275 --- Comment #5 from Jonathan Druart --- Created attachment 19306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19306&action=edit Bug 10275: Use a transaction for OrderFromSubscription.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 10:44:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 08:44:14 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 10:44:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 08:44:18 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #19 from Jonathan Druart --- Created attachment 19307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19307&action=edit Bug 9811: QA followup removes 2 tabs removes mysqlisms -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 10:45:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 08:45:27 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #20 from Jonathan Druart --- (In reply to Katrin Fischer from comment #18) > * koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc > FAIL > forbidden patterns FAIL Fixed. > * C4/Utils/DataTables/Members.pm > FAIL > pod OK > forbidden patterns OK > valid FAIL > Use of qw(...) as parentheses is deprecated Strange, I don't have this failure. And perl -wc returns OK: perl -wc C4/Utils/DataTables/Members.pm C4/Utils/DataTables/Members.pm syntax OK > 2) The new C4/Utils/DataTables/Members.pm adds mysqlisms: Fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 10:49:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 08:49:05 +0000 Subject: [Koha-bugs] [Bug 10499] UT: VirtualShelves.t needs a database transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10499 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 10:51:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 08:51:02 +0000 Subject: [Koha-bugs] [Bug 10499] UT: VirtualShelves.t needs a database transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10499 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19221|0 |1 is obsolete| | --- Comment #6 from kenza --- Created attachment 19308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19308&action=edit Bug 10499: VirtualShelves.t - wrap tests in a database connection Before this patch, the queries in VirtualShelves.t were committed in the database and have to be removed at the end. This patch wraps tests in a database connection. Test plan: prove t/db_dependent/VirtualShelves.t VirtualShelves.t .. ok All tests successful. Files=1, Tests=72, 1 wallclock secs ( 0.06 usr 0.00 sys + 0.72 cusr 0.06 csys = 0.84 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 10:52:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 08:52:13 +0000 Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition module could order by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.6 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:04:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 09:04:28 +0000 Subject: [Koha-bugs] [Bug 10499] UT: VirtualShelves.t needs a database transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10499 --- Comment #7 from kenza --- This patch needs signoff again.In fact, the patch 10386 is pushed to master so i rebase this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:50:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 09:50:44 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #21 from Jonathan Druart --- Created attachment 19309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19309&action=edit Bug 10124: QA followup - Remame the t/.../GetPendingOrders.pm to t/.../SearchOrders.pm according to the package name. - Rename IndependantBranches with IndependentBranches - FIX levels in pod Note that 1 qa issue still exists (not introduced by this development): FAIL t/db_dependent/lib/KohaTest/Acquisition/SearchOrders.pm OK pod OK forbidden patterns FAIL valid Invalid CODE attribute: Test( 1 ) OK critic These tests are never used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 11:50:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 09:50:40 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:04:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 10:04:46 +0000 Subject: [Koha-bugs] [Bug 10249] Untranslatable strings in Javascript on OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:29:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 10:29:37 +0000 Subject: [Koha-bugs] [Bug 10509] Using updates instead of inserts in translated mysql files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19242|0 |1 is obsolete| | Attachment #19243|0 |1 is obsolete| | --- Comment #13 from M. de Rooy --- Created attachment 19310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19310&action=edit Bug 10509: Using i18n function for translation of MySQL web installer files This patch makes the changes needed to progressively use a i18n function to translate strings in the web installer's MySQL files. The English scripts may contain fields like i18n(columnvalue); for English i18n(a) is a, but for the other languages i18n(a) is the translation of a. The corresponding script in the language folder contains the i18n definition. The work is done in such a way that current installations are not affected. Subsequent patches will make the changes in the .sql files themselves. This can be done per folder, per language. Using the extension .i18n in the last subfolder name triggers the new translation mechanism. (See also test plan.) In Installer.pm the all_languages parameter is removed from load_sql_in_order. This code was not used. This change also affects the call in install.pl. The most important change is the use of a new subroutine _run_mysql_file in load_sql. This new routine contains the above logic. Although I also tested changing marc_framework_sql_list and sample_data_sql_list, it proved imo to be easier (and more maintainable) to do this via load_sql. Test plan: Since no .sql files are changed in this patch, please test if you can install English and e.g. German (or another one) in the web installer without any changes. Bonus points for the following additional tests :) They serve to illustrate the i18n concept more clearly. 1) Place in en/mandatory/userflags.sql around a few strings i18n('...'). Run English install again and check the userflags table. No changes expected. 2) Place in de-DE/mandatory/userflags.sql i18n around a few strings too. Also precede the insert statements with this definition: DROP FUNCTION IF EXISTS i18n; CREATE FUNCTION i18n (d text) RETURNS text DETERMINISTIC RETURN concat(d,'xx'); Now run German install again; some of the userflag strings (with i18n) should now end with xx. 3) Before retesting German install, make some changes: Edit en/optional/sample_holidays.sql. Add i18n calls around strings. Create an additional folder optional.i18n in de-DE. Copy sample_holidays.sql and sample_holidays.txt from de-DE/optional. Edit de-DE/optional.i18n/sample_holidays.sql. Remove all text! Add: DROP FUNCTION IF EXISTS i18n; CREATE FUNCTION i18n (d text) RETURNS text DETERMINISTIC RETURN CASE d WHEN 'Sundays' THEN 'Sonntag' ELSE d END; Now run German install again; in the optional part of the install mark sample holidays (in the last section standing separately; do not confuse with the other one). Check the repeatable_holidays table afterwards. The string above should have been translated only, the others are still English. Undo the changes in .sql files; remove optional.i18n folder. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:30:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 10:30:07 +0000 Subject: [Koha-bugs] [Bug 10509] Using updates instead of inserts in translated mysql files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 --- Comment #14 from M. de Rooy --- Created attachment 19311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19311&action=edit Bug 10509: Followup for load_sql_in_order in unit tests Although I assume that the unit tests in t/db_dependent/lib are actually obsolete and should probably be removed, the two calls of load_sql_in_order are updated to reflect the current parameter list. (The all_languages parameter has been dropped.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:30:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 10:30:22 +0000 Subject: [Koha-bugs] [Bug 10509] Using updates instead of inserts in translated mysql files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:30:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 10:30:45 +0000 Subject: [Koha-bugs] [Bug 10509] Using updates instead of inserts in translated mysql files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:31:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 10:31:41 +0000 Subject: [Koha-bugs] [Bug 10509] Using i18n function for translation in webinstaller mysql files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Using updates instead of |Using i18n function for |inserts in translated mysql |translation in webinstaller |files |mysql files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:36:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 10:36:43 +0000 Subject: [Koha-bugs] [Bug 10509] Using i18n function for translation in webinstaller mysql files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #15 from M. de Rooy --- As we discussed this bug, the solution went in another direction than initially foreseen. I have renamed the bug therefore. This patch provides the foundation for converting the language folders one-by-one to a new style. I will open new reports for the language patches. Plan to first send English and German within some days. You are more than welcome to test this patch and sign it off :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:37:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 10:37:10 +0000 Subject: [Koha-bugs] [Bug 10509] Using i18n function for translation in webinstaller mysql files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7368 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:37:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 10:37:10 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10509 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:38:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 10:38:16 +0000 Subject: [Koha-bugs] [Bug 10509] Using i18n function for translation in webinstaller mysql files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:47:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 10:47:59 +0000 Subject: [Koha-bugs] [Bug 10520] New: Add i18n function to English mysql files for webinstaller Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 Bug ID: 10520 Summary: Add i18n function to English mysql files for webinstaller Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: m.de.rooy at rijksmuseum.nl Reporter: m.de.rooy at rijksmuseum.nl CC: gmcharlt at gmail.com See bug 10590. This bug is a followup to convert the English files to the new style using the i18n function. This function translates the strings for the non-English languages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:48:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 10:48:18 +0000 Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10509 Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:48:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 10:48:18 +0000 Subject: [Koha-bugs] [Bug 10509] Using i18n function for translation in webinstaller mysql files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10520 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:52:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 10:52:02 +0000 Subject: [Koha-bugs] [Bug 10521] New: Add i18n function to German mysql files for webinstaller (de-DE) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521 Bug ID: 10521 Summary: Add i18n function to German mysql files for webinstaller (de-DE) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: m.de.rooy at rijksmuseum.nl Reporter: m.de.rooy at rijksmuseum.nl CC: gmcharlt at gmail.com See bug 10509 and bug 10520. Followup for German. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:52:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 10:52:26 +0000 Subject: [Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10509, 10520 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:52:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 10:52:26 +0000 Subject: [Koha-bugs] [Bug 10509] Using i18n function for translation in webinstaller mysql files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10521 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 12:52:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 10:52:26 +0000 Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10521 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:06:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 12:06:27 +0000 Subject: [Koha-bugs] [Bug 10488] New MARC21 authority tags and subfields should be propagated to non-default frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10488 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19253|0 |1 is obsolete| | --- Comment #5 from M. de Rooy --- Created attachment 19312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19312&action=edit Bug 10488 - New MARC21 authority tags and subfields should be propagated to non-default frameworks As proposed by the report creator, this patch rewites authorities_normal_marc21.sql using default authority framework to build all current authtypes. Then proceed to delete not relevant tags. It also updates default authority framework to last update (April 2013) adding new or updated tags/subtags. All new tags/subtags from Bug 9826 and this one are included in all authtypes. Deleted tags reflect current situation except for 7XX tags that I was tell must be present on all authtypes. Only for new installs To test: 1) Apply patch 2) Delete all authtypes exec in database delete from auth_types; delete from auth_tag_structure; delete from auth_subfield_structure; 3) Insert new auth framework 4) Verify absent tags. This can be done running select tagfield as from auth_tag_structure where authtypecode ='' and tagfield not in (select tagfield from auth_tag_structure where authtypecode = 'AUTH_TYPE') for each authtype ( UNIF_TITLE, TOPIC_TERM, etc.) The attached PDF could be used as a reference, all that is white or green for each authtype must be in the list (except for white 7XX tags) 5) Sign :) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:06:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 12:06:36 +0000 Subject: [Koha-bugs] [Bug 10488] New MARC21 authority tags and subfields should be propagated to non-default frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10488 --- Comment #6 from M. de Rooy --- Created attachment 19313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19313&action=edit Bug 10488: Followup replacing DELETEs by more restricted INSERTs Instead of inserting followed by deleting, this patch combines the two where clauses of both sql statements, meanwhile leaving the separation intact. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:09:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 12:09:16 +0000 Subject: [Koha-bugs] [Bug 10488] New MARC21 authority tags and subfields should be propagated to non-default frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10488 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:09:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 12:09:35 +0000 Subject: [Koha-bugs] [Bug 10522] New: Javascript error on acquisition pages: YAHOO is not defined Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10522 Bug ID: 10522 Summary: Javascript error on acquisition pages: YAHOO is not defined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: jonathan.druart at biblibre.com git bisect tells me that bug 9779 introduces a javascript issue in some acquisition pages. To reproduce: - open Firebug - go to acqui/addorderiso2709.pl I don't know if the guilty code in js/acq.js can be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:09:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 12:09:44 +0000 Subject: [Koha-bugs] [Bug 10522] Javascript error on acquisition pages: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9779 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:09:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 12:09:44 +0000 Subject: [Koha-bugs] [Bug 9779] Remove global include of YUI assets from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10522 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:19:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 12:19:04 +0000 Subject: [Koha-bugs] [Bug 10488] New MARC21 authority tags and subfields should be propagated to non-default frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10488 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from M. de Rooy --- QA Comment: This patch makes a great contribution in removing redundancy from this file! Looks good to me. I did a fresh install and [quickly] compared the list of tags that you do not insert for the other auth types with the list on loc.gov. Note: These changes should also be propagated to the other language folders. But note that I am working on bug 10509 and its followup reports. These reports go through all folders too and will remove more redundancy. In the light of that, it may be wise to postpone this activity a little bit and communicate with each other on the progress of the other report. Thanks. BTW My followup combines your insert and delete into one more restricted insert. Just a matter of combining the two clauses. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:20:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 12:20:24 +0000 Subject: [Koha-bugs] [Bug 10488] New MARC21 authority tags and subfields should be propagated to non-default frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10488 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:23:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 12:23:15 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #25 from M. de Rooy --- Looking at this now.. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:34:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 12:34:30 +0000 Subject: [Koha-bugs] [Bug 10522] Javascript error on acquisition pages: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10522 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Owen Leonard --- I have a patch in progress for this already. I'll try to get it submitted today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:34:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 12:34:39 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #26 from M. de Rooy --- Mason: Something is wrong with your followup. Look here: ('383', 'NUMERIC DESIGNATION OF MUSICAL WORK', 'NUMERIC DESIGNATION OF MUSICAL WORK', 0, 1, NULL, ''), 0, 1, NULL, ''), UDIENCE CHARACTERISTICS', 'AUDIENCE CHARACTERISTICS', 1, 0, NULL, ''), Bernardo or Mason: please correct! Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 14:40:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 12:40:32 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 15:03:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 13:03:01 +0000 Subject: [Koha-bugs] [Bug 10517] kohe-restore fails to create mysqluser@mysql_hostname so zebra update fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 --- Comment #2 from Robin Sheat --- I don't think removing the instruction to remove the user if it exists is a good idea, as it might be there. And it it is there, then we want to remove it. As it stands, the error coming from that failing should be ignored and the script should proceed. If that's not happening, that's a bug in and of itself (though looking at it, it should be OK.) As for adding the permission for @$mysql_hostname, I wonder if that should be fixed to 'localhost' like it is in koha-create. This is to account for connecting via either a UNIX socket or a loopback TCP connection within a machine. For situations where the mysql server is on a remote host, we're probably reaching the point of complexity where koha-restore isn't suitable in it's current form. So anyway, I think it should probably be modified such that mysql_hostname is always 'localhost', and that'll solve the zebra mysql issue. Any thoughts on this, John? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 15:22:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 13:22:06 +0000 Subject: [Koha-bugs] [Bug 10523] New: Remove two obsolete routines from Installer.pm Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523 Bug ID: 10523 Summary: Remove two obsolete routines from Installer.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: m.de.rooy at rijksmuseum.nl Reporter: m.de.rooy at rijksmuseum.nl CC: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 15:28:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 13:28:57 +0000 Subject: [Koha-bugs] [Bug 10523] Remove two obsolete routines from Installer.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 15:29:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 13:29:00 +0000 Subject: [Koha-bugs] [Bug 10523] Remove two obsolete routines from Installer.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523 --- Comment #1 from M. de Rooy --- Created attachment 19314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19314&action=edit Bug 10523: Remove two obsolete routines from Installer.pm The routines sql_file_list and marcflavour_list in Installer.pm are not used. There are some references to them in probably obsolete '/lib' test units. I changed these test units for the record too. Also: removed the not-existing marcflavour parameter of sample_data_sql_list in its call in install.pl. Test plan: Run a new install. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 15:33:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 13:33:07 +0000 Subject: [Koha-bugs] [Bug 10523] Remove two obsolete routines from Installer.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523 --- Comment #2 from M. de Rooy --- There could be a small clash with bug 10509 in a POD section. Easy conflict to resolve. Does not really matter which bug goes first. (This is the easy one) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 15:50:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 13:50:52 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #37 from Julian Maurice --- Hi Katrin, Thanks for the review. Before I sumbit the follow-up, a few remarks: 1) I didn't found any "qw" in the patches. 3) What makes you thinking this? This is still possible, there are two links in basket.pl and parcel.pl: "Delete order" and "Delete order and bibliographic record" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 15:53:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 13:53:37 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #38 from Julian Maurice --- Created attachment 19315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19315&action=edit Bug 7162; Factorize code for order cancellation (QA fixes) * Remove tab characters in acqui/addorder.pl * Remove FIXME in acqui/cancelorder.pl * Fix typos: "canceled" -> "cancelled", "occured" -> "occurred" * Replace "Click here" link by "OK" * Add a column to aqorders to store cancellation reason instead of having it in aqorders.notes, to avoid having untranslatable strings in database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 15:53:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 13:53:51 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:00:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 14:00:41 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #39 from Katrin Fischer --- Hi Julian, I will check if my QA script still gives me that error - I realized a bit later while testing that I didn't have the newest version of it. 3) Sorry, misread the code, all good then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:02:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 14:02:44 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:02:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 14:02:48 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #37 from Jonathan Druart --- Created attachment 19316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19316&action=edit Bug 7180: QA followup Ergonomic improvements: - Remove the green color the selected record. - Use fieldset.rows (and legend). - Use the required css class for quantity inputs. - Replace "budget" with "fund". - fix the "undefined" string - Add a "show MARC" link - replace "no_match" with a text. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:03:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 14:03:54 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10522 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:03:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 14:03:54 +0000 Subject: [Koha-bugs] [Bug 10522] Javascript error on acquisition pages: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7180 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:07:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 14:07:52 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #38 from Jonathan Druart --- (In reply to Katrin Fischer from comment #36) Thanks Katrin for this helpful feedback! > 1) The green color for selected lines seems debatable given the overall look > and feel of the Koha GUI. Can you please reconsider? I removed the green color. > 2) The form has a few design issues - the labels and fields are not properly > aligned in a smaller window, making it hard to figure out what goes where. > It might fit a bit better into 2 columns and smaller fields for quantity, > price and discount. Done, now I use the fieldset with the "rows" css class. > Also required fields should be highlighted and the > input should be validated. Like there is no complaint if you don't input the > quantity. The quantity label now use the "required" css class. I added a javascript check too. > 3) The label budget is wrong and should be fund instead. Fixed. > Also the list shows funds from inactive budgets. Yes but since the record select a value in the dropdown list, the fix is not quite easy. I prefer to do it later. > 4) In comparison to the normal form we are missing the option to set the > currency in the form. I think it might be safe to assume that all records in > that list will be one and the same currency, but it's not clear how to > indicate the currency to be used. The currency used, for all records, is the default currency. Which is the one selected in the "Accounting details" block. I don't know how to make that much clearer. > 5) When you select a fund that is connected to an authorised value list and > then undo the selection, you end up with the string "undefined" in the input > field. Fixed. > Some ideas: > > - I think instead of having the full form on each entry it would save a lot > of space if we could only display it for selected records and keep the > smaller layout for when now records are selected. Hum, I tried something, but I am not a great ergonomist... > - There is no option to see more about the record and we are only displaying > 245$a it seems, which is not really helpful if you have lots of similar > records. Showing a link to the ISBD/MARC preview might help that. Done. > - Instead of no_match we should be displaying a nicer text for the librarian. Done. > - It might be worth adding an option to pick the right tax rate. Mathieu Saby already asked for that (comment 10), but it is not planned for now. Note: This patch is impacted by the bug 10522, it introduces side-effects with this feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:16:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 14:16:12 +0000 Subject: [Koha-bugs] [Bug 10510] OPAC's renew selected link has glitchy icon In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 --- Comment #4 from Owen Leonard --- This works for me in several different browsers, so I'm not sure what is going on. If you don't mind, please try pulling up the image itself in the browser and refreshing that: /opac-tmpl/prog/images/sprite.png And if it still isn't working please post a screenshot with browser info. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:18:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 14:18:25 +0000 Subject: [Koha-bugs] [Bug 10510] OPAC's renew selected link has glitchy icon In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 --- Comment #5 from Katrin Fischer --- Will retest - thx for providing the URL :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:18:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 14:18:44 +0000 Subject: [Koha-bugs] [Bug 10510] OPAC's renew selected link has glitchy icon In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:20:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 14:20:21 +0000 Subject: [Koha-bugs] [Bug 10442] Remove references to non-standard "error" class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:36:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 14:36:09 +0000 Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se --- Comment #6 from Viktor Sarge --- This could be quite useful as many libraries in Sweden have this type of service. I'd be happy to see it as a part of community Koha. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:41:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 14:41:03 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18497|0 |1 is obsolete| | Attachment #18498|0 |1 is obsolete| | Attachment #18499|0 |1 is obsolete| | Attachment #18500|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart --- Created attachment 19317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19317&action=edit Bug 5336:Order search (search and UI enhancements) You can now search orders by - order status - fund New field aqorders.orderstatus, it can contains following values: 0 => New 1 => Ordered 2 => Partial 3 => Complete 4 => Deleted To test: Search and check if results are consistent in histsearch.pl Signed-off-by: Cedric Vita -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:42:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 14:42:05 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #54 from Jonathan Druart --- Created attachment 19318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19318&action=edit Bug 5336: Late orders search: don't display deleted order. Test plan: Check that deleted orders are not listed in the late orders search results. Signed-off-by: Cedric Vita -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:42:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 14:42:12 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #55 from Jonathan Druart --- Created attachment 19319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19319&action=edit Bug 5336: Merge parent ordernumber and ordernumber columns Signed-off-by: Cedric Vita -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:42:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 14:42:17 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #56 from Jonathan Druart --- Created attachment 19320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19320&action=edit Bug 5336: Add unit tests for 3 acq routines Unit tests In C4::Acquisition for: - CloseBasket - ReopenBasket - GetBiblioCountByBasketno Signed-off-by: Cedric Vita -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:42:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 14:42:23 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #57 from Jonathan Druart --- Created attachment 19321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19321&action=edit Bug 5336: QA followup - fix capitalization - fix update database message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:47:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 14:47:23 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #58 from Jonathan Druart --- Thanks Katrin! 1/ Done in the followup. 2) I amended the first patch for that. I am afraid to change that in the followup (It it is pushed after bug 5394 we will loose the line). 3) Capitalization : done. 4) I never got this failure, really strange. 5) 3.09.00.043 and 3.11.00.116 did not use the "after column_name" in the alter table query. So it certainly comes from here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 16:53:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 14:53:51 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #59 from Katrin Fischer --- Hi Jonathan, I think we both got the wrong bug number for 2)? :) Julian removed the internalnotes column now, so I think removing it now and readding the correct code later would be good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:01:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 15:01:21 +0000 Subject: [Koha-bugs] [Bug 10524] New: Dependency updates to account for liblibrary-callnumber-lc-perl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10524 Bug ID: 10524 Summary: Dependency updates to account for liblibrary-callnumber-lc-perl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: robin at catalyst.net.nz CC: robin at catalyst.net.nz Need to update the control file for master and 3.12 to make this work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:01:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 15:01:29 +0000 Subject: [Koha-bugs] [Bug 10524] Dependency updates to account for liblibrary-callnumber-lc-perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10524 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:03:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 15:03:29 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #60 from Julian Maurice --- (In reply to Katrin Fischer from comment #59) > Julian removed the internalnotes column now, so I think removing it now and > readding the correct code later would be good. Not sure of what you are talking about, but aqorders.internalnotes is added by Bug 5349, and I didn't remove anything from this patch yet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:07:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 15:07:46 +0000 Subject: [Koha-bugs] [Bug 10524] Dependency updates to account for liblibrary-callnumber-lc-perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10524 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:07:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 15:07:49 +0000 Subject: [Koha-bugs] [Bug 10524] Dependency updates to account for liblibrary-callnumber-lc-perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10524 --- Comment #1 from Robin Sheat --- Created attachment 19322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19322&action=edit Bug 10524 - dependency updates Include liblibrary-callnumber-lc-perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:09:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 15:09:39 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #61 from Katrin Fischer --- Right, was confusing it with the other acq related patch with cancellationreason. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:11:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 15:11:04 +0000 Subject: [Koha-bugs] [Bug 10524] Dependency updates to account for liblibrary-callnumber-lc-perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10524 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Robin Sheat --- This applies to both 3.12.x and master, and is required for them both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:11:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 15:11:13 +0000 Subject: [Koha-bugs] [Bug 10524] Dependency updates to account for liblibrary-callnumber-lc-perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10524 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:48:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 15:48:07 +0000 Subject: [Koha-bugs] [Bug 10523] Remove two obsolete routines from Installer.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19314|0 |1 is obsolete| | --- Comment #3 from M. de Rooy --- Created attachment 19323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19323&action=edit Bug 10523: Remove two obsolete routines from Installer.pm The routines sql_file_list and marcflavour_list in Installer.pm are not used. There are some references to them in probably obsolete '/lib' test units. I changed these test units for the record too. Also: removed the not-existing marcflavour parameter of sample_data_sql_list in its call in install.pl. Test plan: Run a new install. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 17:48:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 15:48:43 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 acowell at daviscollege.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acowell at daviscollege.edu --- Comment #25 from acowell at daviscollege.edu --- (In reply to Dobrica Pavlinusic from comment #24) > David, can you please post your ldap config from koha-conf.xml? From looking > at a code I agree with Rolando that setting auth_by_bind to 1 should fix > your problem (hopefully). I receive the same issue running the latest koha-common received via APT-GET and trying to set up active directory. It doesn't seem to matter what I use for hostname... LDAP:// LDAPS:// or just straight qualified name of AD LDAP server. I always receive the below error messages. I also should state that we are on Windows 2008 Domain and I believe that anonymous is turned off. [Mon Jul 01 11:19:34 2013] [error] [client 127.0.0.1] [Mon Jul 1 11:19:34 2013] opac-user.pl: Use of uninitialized value in string ne at /usr/share/koha/lib/C4/Auth.pm line 670, line 522., referer: http://127.0.1.1/cgi-bin/koha/opac-user.pl [Mon Jul 01 11:19:34 2013] [error] [client 127.0.0.1] [Mon Jul 1 11:19:34 2013] opac-user.pl: Use of uninitialized value $pki_field in string eq at /usr/share/koha/lib/C4/Auth.pm line 780, line 522., referer: http://127.0.1.1/cgi-bin/koha/opac-user.pl [Mon Jul 01 11:19:34 2013] [error] [client 127.0.0.1] [Mon Jul 1 11:19:34 2013] opac-user.pl: Use of uninitialized value $pki_field in string eq at /usr/share/koha/lib/C4/Auth.pm line 780, line 522., referer: http://127.0.1.1/cgi-bin/koha/opac-user.pl [Mon Jul 01 11:19:34 2013] [error] [client 127.0.0.1] [Mon Jul 1 11:19:34 2013] opac-user.pl: LDAP Auth rejected : (sAMAccountName=duser2) gets 0 hits, referer: http://127.0.1.1/cgi-bin/koha/opac-user.pl [Mon Jul 01 11:19:34 2013] [error] [client 127.0.0.1] [Mon Jul 1 11:19:34 2013] opac-user.pl: LDAP error #1: LDAP_OPERATIONS_ERROR, referer: http://127.0.1.1/cgi-bin/koha/opac-user.pl [Mon Jul 01 11:19:34 2013] [error] [client 127.0.0.1] [Mon Jul 1 11:19:34 2013] opac-user.pl: # Server encountered an internal error, referer: http://127.0.1.1/cgi-bin/koha/opac-user.pl [Mon Jul 01 11:19:34 2013] [error] [client 127.0.0.1] [Mon Jul 1 11:19:34 2013] opac-user.pl: , referer: http://127.0.1.1/cgi-bin/koha/opac-user.pl [Mon Jul 01 11:19:34 2013] [error] [client 127.0.0.1] [Mon Jul 1 11:19:34 2013] opac-user.pl: Use of uninitialized value $retuserid in string ne at /usr/share/koha/lib/C4/Auth.pm line 817, line 551., referer: http://127.0.1.1/cgi-bin/koha/opac-user.pl This is my koha-conf.xml file which as far as I can tell matches all of the requirements...? Can you verify for me? 1 ldaps://[server qualified name] dc=[domain],dc=[extension] [CN OU DN Information] [PASSWORD] 1 1 1 %s at daviscollege.edu
[Branch Code] [category code] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 18:05:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 16:05:22 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #26 from Rolando Isidoro --- Have you tried setting ?auth_by_bind? to 0 in your koha-conf.xml? Let me know if it works for your that way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 19:14:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 17:14:19 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #27 from acowell at daviscollege.edu --- Yes, I tried 0 and 1... You know I just noticed that there are diffs attached and when I compare those files with koha-common files the changes are not there... I assume I need to download the two attached diffs and patch the files. Then test again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 19:42:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 17:42:56 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #28 from acowell at daviscollege.edu --- (In reply to acowell from comment #27) > Yes, I tried 0 and 1... You know I just noticed that there are diffs > attached and when I compare those files with koha-common files the changes > are not there... I assume I need to download the two attached diffs and > patch the files. Then test again? Sorry, never mind, I was reading the DIFF backwards and the changes are applied in latest 3.12 common that I'm running. After making changes to koha-conf.xml do you need to restart the apache or koha-common service or should things happen in live time? Sorry, new to Koha and this is the one show stopper from us being able to deploy koha at our college. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 20:12:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 18:12:40 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #29 from acowell at daviscollege.edu --- Just to update... I changed to 0 and to 0 and now I get this in my OPAC Error log. [Mon Jul 01 13:59:31 2013] [error] [client 10.0.1.88] [Mon Jul 1 13:59:31 2013] opac-user.pl: Use of uninitialized value in string ne at /usr/share/koha/lib/C4/Auth.pm line 670, line 522., referer: http://10.0.1.99/cgi-bin/koha/opac-user.pl [Mon Jul 01 13:59:31 2013] [error] [client 10.0.1.88] [Mon Jul 1 13:59:31 2013] opac-user.pl: Use of uninitialized value $pki_field in string eq at /usr/share/koha/lib/C4/Auth.pm line 780, line 522., referer: http://10.0.1.99/cgi-bin/koha/opac-user.pl [Mon Jul 01 13:59:31 2013] [error] [client 10.0.1.88] [Mon Jul 1 13:59:31 2013] opac-user.pl: Use of uninitialized value $pki_field in string eq at /usr/share/koha/lib/C4/Auth.pm line 780, line 522., referer: http://10.0.1.99/cgi-bin/koha/opac-user.pl [Mon Jul 01 13:59:31 2013] [error] [client 10.0.1.88] [Mon Jul 1 13:59:31 2013] opac-user.pl: LDAP Auth rejected : invalid password for user '<>'. LDAP error #16: LDAP_NO_SUCH_ATTRIBUTE, referer: http://10.0.1.99/cgi-bin/koha/opac-user.pl [Mon Jul 01 13:59:31 2013] [error] [client 10.0.1.88] [Mon Jul 1 13:59:31 2013] opac-user.pl: # The request referenced an attribute that does not exist, referer: http://10.0.1.99/cgi-bin/koha/opac-user.pl [Mon Jul 01 13:59:31 2013] [error] [client 10.0.1.88] [Mon Jul 1 13:59:31 2013] opac-user.pl: , referer: http://10.0.1.99/cgi-bin/koha/opac-user.pl [Mon Jul 01 13:59:31 2013] [error] [client 10.0.1.88] [Mon Jul 1 13:59:31 2013] opac-user.pl: Use of uninitialized value $retuserid in string ne at /usr/share/koha/lib/C4/Auth.pm line 817, line 581., referer: http://10.0.1.99/cgi-bin/koha/opac-user.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 20:44:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 18:44:58 +0000 Subject: [Koha-bugs] [Bug 10510] OPAC's renew selected link has glitchy icon In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 20:45:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 18:45:04 +0000 Subject: [Koha-bugs] [Bug 10510] OPAC's renew selected link has glitchy icon In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19290|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 19324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19324&action=edit [PASSED QA] Bug 10510 - OPAC's renew selected link has glitchy icon The "renew selected" link on the list of a user's checkouts looks bad because the next icon in the sprite shows through. This patch modifies the sprite to give it proper spacing and corrects the CSS to accommodate the change. To test, apply the patch, clear your browser cache, and view the following pages to confirm that the change works: - With TagsEnabled and TagsInputOnList enabled, view a search results page when logged in and when not logged in. Tag links should be styled correctly. - With OpacBrowseResults enabled, open the detail page for any record and click the "browse shelf" link. The "forward" and "back" arrows should be styled correctly. - With OpacRenewalAllowed enabled, log in to the OPAC and view your checked out items. The "renew selected" and "renew all" links should look correct. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Note: this will fix only the prog theme, but not the ccsr theme. And it works perfectly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 21:06:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 19:06:43 +0000 Subject: [Koha-bugs] [Bug 10245] OPAC items table CSS classes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10245 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Chris! Note: it seems to me that as of master/3.12.x there are still 2 columns without class and id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 21:07:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 19:07:24 +0000 Subject: [Koha-bugs] [Bug 10425] Help page missing for Local Use preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10425 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 21:08:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 19:08:01 +0000 Subject: [Koha-bugs] [Bug 10315] Use easier readable font for generated passwords In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10315 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:12:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 20:12:49 +0000 Subject: [Koha-bugs] [Bug 10490] Overdue fines cap (amount) in circulation rules is saved incorrectly (rounded) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10490 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:12:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 20:12:53 +0000 Subject: [Koha-bugs] [Bug 10490] Overdue fines cap (amount) in circulation rules is saved incorrectly (rounded) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10490 --- Comment #2 from Katrin Fischer --- Created attachment 19325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19325&action=edit Bug 10490: Overdue fines cap can't store decimal values When overduefinescap was added to the issuingrules the datatype given was decimal. This translates in MySQL to decimal(10,0). This doesn't allow you to store decimal values and therefore values like 4.5 are saved as 5 in the database. To test: On a current installation: 1) Try to enter 4.5 as Overdue fines cap. Verify that the value is not correctly saved. 2) Apply patch and run database update. 3) Try adding/changing an issuing rule setting Overdue fines cap to 4.5 again. 4) Verify the value is saved correctly. Create a new Koha installation from scratch: 1) Verify that the issuingrules table has been created correctly and that you can add/mofidy issuingrules correctly. Because this bug can create data loss, the old database update has also been changed to avoid this problem for people updating at a later point in time. Checkout an older version of Koha pre 3.09.00.027. 1) Run the database updates. 2) Verify again, that adding/modifying issuingrules works correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:15:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 20:15:43 +0000 Subject: [Koha-bugs] [Bug 10490] Overdue fines cap (amount) in circulation rules is saved incorrectly (rounded) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10490 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:41:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 20:41:15 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 --- Comment #12 from Katrin Fischer --- Hi Kyle, I noticed a problem in the rotating collections templates while working on the po files: "[ editColDescription %]" in editCollections.tt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 22:49:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 20:49:45 +0000 Subject: [Koha-bugs] [Bug 10492] Translation problems with TT directives in po files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10492 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |minor --- Comment #1 from Katrin Fischer --- I have done some more tests on this and leaving the strings untouched will get you valid po files that also translate correctly in the templates. '[%%' will be correctly translated to '[%'. But I am still wondering why the translation scripts pick up a lot of those strings now. Also there is a difference - some TT code has the escaped % some does not. I am downgrading the bug, because if you are careful in your translations, you can create correct po files by just copying the strings without making any changes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:05:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 21:05:38 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 --- Comment #2 from Jesse Weaver --- Created attachment 19326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19326&action=edit Bug 8133 - hourly loans doesn't know when library closed This adds support for storing library hours in the calendar, and using those hours to compute hourly loan duetimes. A large amount of cleanup was also performed to expunge duplication of code between C4::Calendar and Koha::Calendar. Test plan: 1) Apply patch. 2) Update database. 3) Verify that the calendar administration interface still exists and works as expected. 4) Run t/Calendar.t and t/db_dependent/Calendar.t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:06:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 21:06:39 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:06:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 21:06:53 +0000 Subject: [Koha-bugs] [Bug 9307] Allow libraries to add/edit status for suggestion management. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9307 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10519 --- Comment #23 from Katrin Fischer --- Hi Kyle, bug 10519 seems to be a regression from this patch, although there is admittedly more wrong with the suggestion filters than just what I captured on the screenshot. I checked out the commit before this was pushed and the display for the ordered tab was correct. I think it might be this line: + unless ( grep { /$criteriumvalue/ } qw(ASKED ACCEPTED REJECTED CHECKED) ) { It's missing ORDERED and AVAILABLE? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:06:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 21:06:53 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Ordered' shows up in tab 'Unknown' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9307 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:15:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 21:15:12 +0000 Subject: [Koha-bugs] [Bug 10525] New: Can't add/edit notes to order lines on receive Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10525 Bug ID: 10525 Summary: Can't add/edit notes to order lines on receive Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/parcel.pl?invoiceid=12 OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de The invoicenumber is not passed correctly in the URL: http://localhost:8080/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=1692&referrer=/cgi-bin/koha/acqui/parcel.pl%3Fbooksellerid=2&datereceived=&invoice=HASH(0x53f40d8) To test: - Receive a new shipment - Try to edit the note by using the [Add note] link in each oder line. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:21:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 21:21:27 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Ordered' shows up in tab 'Unknown' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:21:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 21:21:30 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Ordered' shows up in tab 'Unknown' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 --- Comment #2 from Katrin Fischer --- Created attachment 19327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19327&action=edit Bug 10519: Fix display of tab for ordered suggestions Adds 2 more valid status to a check to make the description on the tab for 'Ordered' and 'Available' suggestions show up correctly. To test: - Make 2 suggestions. - Accept both and order them in acquisitions. - Receive one of them. - Use the 'Organize by' filter with 'Status' - Verify status descriptions in the tabs show up correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:24:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 21:24:08 +0000 Subject: [Koha-bugs] [Bug 4907] Suggestions "organize by" menu doesn't reflect current choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4907 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #3 from Katrin Fischer --- *** Bug 9318 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:24:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 21:24:08 +0000 Subject: [Koha-bugs] [Bug 9318] organize by doesn't hold value on suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9318 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 4907 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:24:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 21:24:47 +0000 Subject: [Koha-bugs] [Bug 4907] Suggestions "organize by" menu doesn't reflect current choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4907 --- Comment #4 from Katrin Fischer --- Another year... and the bug is still there. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:25:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 21:25:48 +0000 Subject: [Koha-bugs] [Bug 4907] Suggestions "organize by" menu doesn't reflect current choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4907 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|henridamien at koha-fr.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:43:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 21:43:57 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Ordered' shows up in tab 'Unknown' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #3 from Katrin Fischer --- While my patch fixes the display of the status tabs, I just realized the problem is a lot bigger. We can not only organize by status, but also by library, item type, suggested byand accepted by. I think this needs more work: Maybe an additional check on the selected 'organize by' filter? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:47:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 21:47:34 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:47:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 21:47:37 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 --- Comment #17 from Jared Camins-Esakov --- Created attachment 19328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19328&action=edit Bug 10240 QA follow-up Address the following issues: 1/ Address minor qa issues with the templates: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline-mf.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 24) [etc.] OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 509) [etc.] FAIL tt_valid lines 5, 5 2/ Run perltidy on new scripts 3/ download.pl returns data.finished = 1 if number of returned data < 5000 (avoids 1 ajax call) 4/ Replace qq{} around sql queries with q{} Also, a race condition existed that resulted in pending transactions only getting deleted from the local database in certain circumstances (fast connections under Chrome, mostly). This patch fixes that so that successfully-uploaded transactions are always deleted. This patch also addresses Jonathan's suggestion: 3/ add a message on check in (currently the input becomes empty but the user is not informed). ... and Magnus's suggestion about moving the Synchronize link to the right on the homepage. Finally, this patch adds a link to the Pending offline operations page on the synchronize page for easier navigation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:50:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 21:50:31 +0000 Subject: [Koha-bugs] [Bug 4907] Suggestions "organize by" menu doesn't reflect current choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4907 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:50:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 21:50:35 +0000 Subject: [Koha-bugs] [Bug 4907] Suggestions "organize by" menu doesn't reflect current choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4907 --- Comment #5 from Katrin Fischer --- Created attachment 19329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19329&action=edit Bug 4907: 'Organize by' filter in suggestions doesn't reflect selected option When using the 'Organize by' option to change the display of the suggestions, the option is applied, but the pull down always jumps back to the first entry 'Status'. This patch fixes that. To test: - Try out all settings and verify that after the page reloads the selected option is applied to your suggestions and the pull down shows the option you selected. Note: Until bug 10519 is properly fixed the tabs will not show the correct descriptions, but the URL will show you the selected option as parameter: displayby=acceptedby -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 1 23:53:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 21:53:23 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 --- Comment #18 from Jared Camins-Esakov --- I addressed the five QA issues Jonathan described in comment 13, and implemented suggested improvement 3. The other three: > 1/ it seems it is not possible to show local actions. That's a good point, and something I think I would like to add, but I will need to think about how to do it. > 2/ add datatable on the tables. I thought about doing this, but was concerned about the size of the app cache. I think the total size is still under 5MB, but I am not 100% certain, so I decided to leave this for the future. > 4/ maybe a menu on the left with all links could help users (this would avoid to go back on the offline home page). I wasn't happy with the result when I tried this. I added a link to the pending circulation actions from the synchronize page, which I presume is what you had in mind, particularly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 00:02:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 22:02:28 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Ordered' shows up in tab 'Unknown' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 --- Comment #4 from Katrin Fischer --- Finding more problems: return GetAuthorisedValueByCode('SUGGEST_STATUS', $criteriumvalue ) || "Unknown"; As the template doesn't check for this value, it's untranslatable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 01:51:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jul 2013 23:51:57 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #13 from David Cook --- Hi Kyle: Any recent work on this one? I recently got a question about rotating collections, so it would be great to see this feature make its way back into Koha. Kyle: Do you have a test plan for this patch? Others: What are the current reservations about this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 02:53:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 00:53:49 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #27 from Bernardo Gonzalez Kriegel --- Created attachment 19330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19330&action=edit [FOLLOWUP 2] Bug 5858 - Update default MARC21 framework This is another followup. It updates some missing tags/subtags, also corrects and verify repeatable value for tags/subtags Also rearrange some out of order entries(referenced on comment #26) I think that now the update is correct and complete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 02:54:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 00:54:05 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 08:48:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 06:48:21 +0000 Subject: [Koha-bugs] [Bug 10078] show location facet for all In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10078 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |dcook at prosentient.com.au Assignee|gmcharlt at gmail.com |dcook at prosentient.com.au --- Comment #1 from David Cook --- Created attachment 19331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19331&action=edit Bug 10078 - show location facet for all Test Plan: BEFORE APPLYING: 0) Disable singlebranch mode if it is on 1) Do an OPAC or Staff Client search for a record that has items with shelving locations. 2) Note that you can see the library branch facet under Libraries but no shelving locations. 3) Enable singlebranch mode 4) Repeat your search 5) Note that you can no longer see the library branch facet under Libraries. However, you can see the shelving location under Location N.B. If you don't have more than one branch or the search results are all from one branch, you might not get a library branch facet. If this is the case, create additional branches and/or change the branch for items in your search results so that you have multiple branches to prompt the appearance of a library branch facet. AFTER APPLYING 1) Do an OPAC or Staff Client search for a record that has items with shelving locations. 2) Note that you see a facet under Location on the left sidebar, regardless of there being a singlebranch mode or the number of branches there are being represented in the search results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 09:04:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 07:04:39 +0000 Subject: [Koha-bugs] [Bug 6122] Catalogue reports exclude biblio without item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6122 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #1 from Liz Rea --- Hi Sophie, I'm not sure I understand which report or where you are referring to here, can you be more specific? This bug is rather old - does it still exist? :LR -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 09:07:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 07:07:26 +0000 Subject: [Koha-bugs] [Bug 5535] users tags not appearing until approved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5535 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |wizzyrea at gmail.com Resolution|--- |WONTFIX --- Comment #3 from Liz Rea --- I agree - not a bug, working as intended. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 09:09:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 07:09:18 +0000 Subject: [Koha-bugs] [Bug 2389] overdue_notices.pl needs a test mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2389 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #2 from Liz Rea --- Agreed - this is still needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 09:18:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 07:18:24 +0000 Subject: [Koha-bugs] [Bug 5986] Inconsistent handling of patron deletion permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5986 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #1 from Liz Rea --- This bug still exists in master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 09:29:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 07:29:33 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de Summary|Suggestions: 'Ordered' |Suggestions: 'Organize by' |shows up in tab 'Unknown' |and correct display of tab | |descriptions broken --- Comment #5 from Katrin Fischer --- Changing the bug title to reflect that this has grown into a bigger problem, I am working on a patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 09:47:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 07:47:18 +0000 Subject: [Koha-bugs] [Bug 10509] Using i18n function for translation in webinstaller mysql files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10526 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 09:47:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 07:47:18 +0000 Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10526 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 09:47:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 07:47:18 +0000 Subject: [Koha-bugs] [Bug 10526] New: Add i18n function to Norwegian mysql files for webinstaller (nb-NO) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10526 Bug ID: 10526 Summary: Add i18n function to Norwegian mysql files for webinstaller (nb-NO) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: magnus at enger.priv.no Reporter: magnus at enger.priv.no CC: gmcharlt at gmail.com Depends on: 10509, 10520 See bug 10509 and bug 10520. Followup for Norwegian. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 10:35:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 08:35:18 +0000 Subject: [Koha-bugs] [Bug 7706] AuthorisedValueImages not displaying all images on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m Assignee|adrien.saurat at biblibre.com |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 10:43:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 08:43:37 +0000 Subject: [Koha-bugs] [Bug 10425] Help page missing for Local Use preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10425 --- Comment #11 from Fridolyn SOMERS --- Thanks everybody. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 11:09:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 09:09:22 +0000 Subject: [Koha-bugs] [Bug 10526] Add i18n function to Norwegian mysql files for webinstaller (nb-NO) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10526 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #1 from M. de Rooy --- Cool ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 11:20:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 09:20:19 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #100 from Paul Poulain --- This patch had already been QAed by me a long time ago. It also has been validated by Jared, then reverted because of a jenkins failure. The new follow-up is about test, and Bernardo has validated it once again. I think it's fair to switch to passed QA, so switching (Galen, this patch is a pain to rebase, please don't let it wait) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 11:29:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 09:29:04 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #30 from Rolando Isidoro --- >From reading the entries you posted from your error log, it seems the main one, LDAP Auth rejected : invalid password for user '<>'. LDAP error #16: LDAP_NO_SUCH_ATTRIBUTE, refers to a piece of code from Auth_with_ldap.pm that remained unchanged. Looking at the source code it seems like your LDAP entries don't have an 'userpassword' attribute, which results in the failed authentication process. Again, the patch aimed to solve LDAP auth with anonymous bind. If that's your LDAP server scenario, then you should be able to login with the 'auth_by_bind' set to 1. Otherwise, 'auth_by_bind' should be set to 0. To try to help you further, can you ask your LDAP server admins a step-by-step description of the authentication process of you setup? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 11:48:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 09:48:13 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #244 from Paul Poulain --- Galen, did you forget this patch ? Any other comment ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 11:51:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 09:51:03 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 --- Comment #101 from Katrin Fischer --- This is a huge patch. I am a bit worried of incorporating this without feedback from a library using serials and subscriptions - especially worried about the database update. Is it possible that we could get an anonymizsed database from a library with lots of subscriptions to test with? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 12:11:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 10:11:43 +0000 Subject: [Koha-bugs] [Bug 7684] inventory : datatable fix actions etc. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|matthias.meusburger at biblibr |jonathan.druart at biblibre.co |e.com |m --- Comment #53 from Jonathan Druart --- A wiki page has been created: http://wiki.koha-community.org/wiki/Inventory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 12:12:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 10:12:04 +0000 Subject: [Koha-bugs] [Bug 4907] Suggestions "organize by" menu doesn't reflect current choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4907 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 12:16:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 10:16:28 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 --- Comment #102 from Paul Poulain --- (In reply to Katrin Fischer from comment #101) > This is a huge patch. I am a bit worried of incorporating this without > feedback from a library using serials and subscriptions - especially worried > about the database update. Is it possible that we could get an anonymizsed > database from a library with lots of subscriptions to test with? Katrin, this improvement is used by 5 of our customers since more than one year. The feature has been signed off by frederic Demians, Kyle, and Bernardo. Not counting my (as QAer) tests, and Jared ones (as he pushed the patch before reverting it) So I think we should go forward, and push this patch (otherwise it will never be pushed). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 12:37:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 10:37:38 +0000 Subject: [Koha-bugs] [Bug 7308] new column in admin/aqbudgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #19 from Jonathan Druart --- I confirm I don't get any error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 12:50:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 10:50:16 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #67 from Julian Maurice --- Created attachment 19332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19332&action=edit Bug 5349: Use DB transaction/rollback in unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 12:50:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 10:50:22 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #68 from Julian Maurice --- Created attachment 19333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19333&action=edit Bug 5349: Create a table for order line transfers This allow to keep transfers informations without having untranslatable strings in database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 12:52:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 10:52:06 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #69 from Julian Maurice --- Hi Katrin, I chose another solution: a separate table for order transfers. I hope this will make everyone happy :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 12:55:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 10:55:04 +0000 Subject: [Koha-bugs] [Bug 10527] New: C4::Branch::get_branch_code_from_name is useless Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10527 Bug ID: 10527 Summary: C4::Branch::get_branch_code_from_name is useless Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com Since branches.branchname is not unique, this routine does not make sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 12:55:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 10:55:14 +0000 Subject: [Koha-bugs] [Bug 10527] C4::Branch::get_branch_code_from_name is useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10527 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 12:57:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 10:57:58 +0000 Subject: [Koha-bugs] [Bug 10527] C4::Branch::get_branch_code_from_name is useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10527 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 12:58:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 10:58:01 +0000 Subject: [Koha-bugs] [Bug 10527] C4::Branch::get_branch_code_from_name is useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10527 --- Comment #1 from Jonathan Druart --- Created attachment 19334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19334&action=edit Bug 10527: C4::Branch::get_branch_code_from_name is useless This routine is not in used and does not make sense. It should not be used later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 13:34:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 11:34:25 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 13:34:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 11:34:28 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19247|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 19335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19335&action=edit Bug 10215 - Increase the size of opacnote and librariannote for table subscriptionhistory We have librarians that are regularly hitting the maximum number of characters for the note fields in subscription history. They would like to be able to store at least 1000 characters here. Converting the varchar(150) to text should do it. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add public and private notes to a subscription history entry where each note is greater than 150 characters. 4) Save and view the notes, the notes should not be truncated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 13:35:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 11:35:43 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19333|0 |1 is obsolete| | --- Comment #70 from Julian Maurice --- Created attachment 19336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19336&action=edit Bug 5349: Create a table for order line transfers This allow to keep transfers informations without having untranslatable strings in database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 13:36:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 11:36:39 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #71 from Julian Maurice --- Fix some typos and useless use of date plugin in last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 13:38:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 11:38:25 +0000 Subject: [Koha-bugs] [Bug 7308] new column in admin/aqbudgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #20 from Julian Maurice --- Reset to Signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 13:45:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 11:45:39 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 --- Comment #14 from Kyle M Hall --- Created attachment 19337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19337&action=edit Bug 8836 - Resurrect Rotating Collections - Followup 3 - Fix bad TT tag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 14:26:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 12:26:54 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 14:26:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 12:26:57 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #1 from kenza --- Created attachment 19338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19338&action=edit Bug 10508 : C4::Branch.pm needs unit tests. Unit tests are wrap in a transaction. NOTE: the field "issuing" isn't used in the database To test: prove t/db_dependent/Branches.t t/db_dependent/Branch.t .. ok All tests successful. Files=1, Tests=31, 0 wallclock secs ( 0.03 usr 0.00 sys + 0.13 cusr 0.00 csys = 0.16 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 14:44:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 12:44:40 +0000 Subject: [Koha-bugs] [Bug 5535] Show the logged-in user's unapproved tags on search results and detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5535 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WONTFIX |--- Summary|users tags not appearing |Show the logged-in user's |until approved |unapproved tags on search | |results and detail pages Severity|normal |enhancement --- Comment #4 from Owen Leonard --- Since I like the feature as described by Nicole I'd like to change this to an enhancement request (for what it's worth). I think it would make sense to have it work this way. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 14:44:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 12:44:48 +0000 Subject: [Koha-bugs] [Bug 5535] Show the logged-in user's unapproved tags on search results and detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5535 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 14:54:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 12:54:28 +0000 Subject: [Koha-bugs] [Bug 10528] New: C4::Bookseller.pm needs unit tests Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 Bug ID: 10528 Summary: C4::Bookseller.pm needs unit tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 14:54:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 12:54:59 +0000 Subject: [Koha-bugs] [Bug 10528] C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 14:55:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 12:55:46 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|C4::Bookseller.pm needs |UT: C4::Bookseller.pm needs |unit tests |unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 14:57:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 12:57:39 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:04:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 13:04:25 +0000 Subject: [Koha-bugs] [Bug 7232] clicking title on receive should open in new window/tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7232 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|henridamien at koha-fr.org |koha-bugs at lists.koha-commun | |ity.org --- Comment #1 from Jonathan Druart --- right clic > open in a new tab/window? I think we don't want to force the user to open a new window/tab. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:09:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 13:09:03 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19337|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 19339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19339&action=edit Bug 8836 - Resurrect Rotating Collections - Followup 3 * Fix bad TT Tag * Fix bad sql query * Fix capitalization ( HTML4 ) * Allow a rotating collection's location to keep AutomaticItemReturn from sending it back to the branch of origin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:10:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 13:10:04 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19339|Bug 8836 - Resurrect |Bug 8836 - Resurrect description|Rotating Collections - |Rotating Collections - QA |Followup 3 |Followup 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:16:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 13:16:40 +0000 Subject: [Koha-bugs] [Bug 10529] New: Dollar sign hardcoded in patron message Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10529 Bug ID: 10529 Summary: Dollar sign hardcoded in patron message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The routine patronflags in C4::Members sets messages if patron owes or is credited with an amount of money. Unfortunately for those of us not using dollars as our currency. The amounts appearing in these messages is hardcoded to be preceded by $ it should be more sensitive to the configuration. One of the places this message is displayed is on self issue machines, which being public facing cause libraries some embarrasment -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:21:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 13:21:40 +0000 Subject: [Koha-bugs] [Bug 10524] Dependency updates to account for liblibrary-callnumber-lc-perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10524 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #3 from Galen Charlton --- Pushed to master. Thanks, Robin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:26:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 13:26:45 +0000 Subject: [Koha-bugs] [Bug 10510] OPAC's renew selected link has glitchy icon In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:28:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 13:28:59 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:29:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 13:29:02 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19327|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 19340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19340&action=edit Bug 10519: Fix display of tab for ordered suggestions Adds 2 more valid status to a check to make the description on the tab for 'Ordered' and 'Available' suggestions show up correctly. To test: - Make 2 suggestions. - Accept both and order them in acquisitions. - Receive one of them. - Use the 'Organize by' filter with 'Status' - Verify status descriptions in the tabs show up correctly. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:30:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 13:30:28 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #19 from Jonathan Druart --- Jared, I get a blank page on the check out page (circ/offline.pl#offline-circulation). The "Checked in item." message text never disappear (even if I go on the offline home page (circ/offline.pl#offline-home)). Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:33:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 13:33:25 +0000 Subject: [Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #5 from Galen Charlton --- Setting to "In discussion" pending the patch submitter answering the question I posed in comment 4. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:33:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 13:33:48 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 --- Comment #7 from Kyle M Hall --- > Finding more problems: > return GetAuthorisedValueByCode('SUGGEST_STATUS', $criteriumvalue ) || "Unknown"; > As the template doesn't check for this value, it's untranslatable. This isn't necessarily as bad as it may seem. The string "Unknown" will only display during an error condition. The one and only error condition I can think of where this would display would be if a suggestion was set to an authorised value, and the authorised value was then deleted. However, it may be better to display the authorised value instead of "Unkown". I will submit a followup for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:34:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 13:34:29 +0000 Subject: [Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #8 from Galen Charlton --- Setting to "In discussion" pending a response to the question posed in comment 7. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:34:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 13:34:45 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 --- Comment #8 from Kyle M Hall --- Created attachment 19341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19341&action=edit Bug 10519 - Suggestions: 'Organize by' and correct display of tab descriptions broken - Change "Unknown" to authorised value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:37:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 13:37:10 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 --- Comment #20 from Jared Camins-Esakov --- Jonathan, I forgot to post one part of the test plan, sorry. It turns out that in Firefox you have to *empty* the app cache and system cache when the code is updated frequently in a short period of time because shift-refresh does not reload pages that have an HTML5 manifest, and Firefox does not seem to follow the Application Cache specification's instruction that the web browser is supposed to check for new versions of pages whenever the manifest changes. Could you try again after clearing the cache and then shift-refreshing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:39:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 13:39:10 +0000 Subject: [Koha-bugs] [Bug 10522] Javascript error on acquisition pages: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10522 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:39:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 13:39:12 +0000 Subject: [Koha-bugs] [Bug 10522] Javascript error on acquisition pages: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10522 --- Comment #2 from Owen Leonard --- Created attachment 19342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19342&action=edit Bug 10522 - Javascript error on acquisition pages: YAHOO is not defined acq.js includes an immediately invoked function expression, which means that it runs whether or not it is called. Because this function tries to reference the YAHOO object, it triggers an error on pages which don't include the main YAHOO assets. Only the basketgroups page uses this function and YAHOO assets. It's probably possible to make this a regular function, but I propose simply wrapping it in a check for the YAHOO object so that it only executes on pages where YAHOO exists--the basketgroups page. To test, apply the patch, clear your browser cache, and test on both the basketgroups page and at least one page which also includes acq.js (addorderiso2709.pl, neworderempty.pl, aqbudgets.pl, suggestion.pl, etc.) and confirm that the browser reports no JavaScript errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:45:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 13:45:13 +0000 Subject: [Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 --- Comment #6 from Jonathan Druart --- (In reply to Galen Charlton from comment #5) > Setting to "In discussion" pending the patch submitter answering the > question I posed in comment 4. Oops sorry Galen, I did not see it! dt is an abbreviation for datetime, not date. So I don't think "date" is an appropriate name. However we could choose "datetime" instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:54:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 13:54:05 +0000 Subject: [Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409 --- Comment #9 from Kyle M Hall --- (In reply to Galen Charlton from comment #7) > (In reply to Owen Leonard from comment #0) > > The course reserves entry form shows an error message instead of a form > > field for the department if no departments are defined: "No DEPARTMENT > > authorised values found! Please create one or more authorised values with > > the category DEPARTMENT." > > A question about the premise of this patch, possibly for Kyle: is there a > functional reason why setting a department is absolutely required? If so, > why is courses.department a nullable column? There is no functional reason to require the setting of a department. It was merely a requirement of the specification I was following ( where the functionality was based on another implementation of course reserves which made Department a required field ). Making department an optional value would do no harm. Of course, the same could be said for the "Name" field, so it's more of a philosophical question than anything. I guess the question is "In practice, will anyone want to create courses *without* course departments?". So, we can either leave department as a required field, or make it optionally require via a system preference. What are your feelings on those options? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:55:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 13:55:29 +0000 Subject: [Koha-bugs] [Bug 10488] New MARC21 authority tags and subfields should be propagated to non-default frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10488 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #8 from Galen Charlton --- After applying the revised SQL, I noticed that the 162 tag (medium of performance) appears in all of the specific auth types: | CHRON_TERM | 148 | | CHRON_TERM | 162 | | CHRON_TERM | 182 | | CORPO_NAME | 110 | | CORPO_NAME | 162 | | GENRE/FORM | 155 | | GENRE/FORM | 162 | | GENRE/FORM | 185 | | GEOGR_NAME | 151 | | GEOGR_NAME | 162 | | GEOGR_NAME | 181 | | MEETI_NAME | 111 | | MEETI_NAME | 162 | | PERSO_NAME | 100 | | PERSO_NAME | 162 | | TOPIC_TERM | 150 | | TOPIC_TERM | 162 | | TOPIC_TERM | 180 | | UNIF_TITLE | 130 | | UNIF_TITLE | 162 | +--------------+----------+ The 162 certainly doesn't belong in them all, and I'm not sure if it belongs in GENRE/FORM or if a new authority type code should be defined. Setting to "In Discussion". This patch is very close to being ready, but the 162 should be dealt with, either by simply excluding it from all but the default authority type or by defining a new authority type. I'm hoping Jared can advise regarding the latter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:56:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 13:56:08 +0000 Subject: [Koha-bugs] [Bug 10522] Javascript error on acquisition pages: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10522 --- Comment #3 from Jonathan Druart --- Don't you think it is worth to create, for instance a basketgroup.js, and to put this code in? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 15:58:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 13:58:58 +0000 Subject: [Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409 --- Comment #10 from Katrin Fischer --- When we alrady discuss required fields... I wondered why the course number is required. I think the way course reserves work here, normally they just give the name of the professor or course without a number. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:00:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 14:00:17 +0000 Subject: [Koha-bugs] [Bug 10499] UT: VirtualShelves.t needs a database transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10499 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:00:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 14:00:19 +0000 Subject: [Koha-bugs] [Bug 10499] UT: VirtualShelves.t needs a database transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10499 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19308|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 19343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19343&action=edit Bug 10499: VirtualShelves.t - wrap tests in a database connection Before this patch, the queries in VirtualShelves.t were committed in the database and have to be removed at the end. This patch wraps tests in a database connection. Test plan: prove t/db_dependent/VirtualShelves.t VirtualShelves.t .. ok All tests successful. Files=1, Tests=72, 1 wallclock secs ( 0.06 usr 0.00 sys + 0.72 cusr 0.06 csys = 0.84 CPU) Result: PASS Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:03:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 14:03:45 +0000 Subject: [Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409 --- Comment #11 from Kyle M Hall --- (In reply to Katrin Fischer from comment #10) > When we alrady discuss required fields... I wondered why the course number > is required. I think the way course reserves work here, normally they just > give the name of the professor or course without a number. Katrin, basically the same answer as before. It was in the spec, it doesn't *really* have to be requiired, and we could make it being a requirement optional via a system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:06:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 14:06:04 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #21 from Julian Maurice --- Created attachment 19344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19344&action=edit Bug 9044: Change dropdown list into links list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:06:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 14:06:11 +0000 Subject: [Koha-bugs] [Bug 10422] Remove references to unused and non-existent wizard.css In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10422 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:06:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 14:06:13 +0000 Subject: [Koha-bugs] [Bug 10422] Remove references to unused and non-existent wizard.css In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10422 --- Comment #1 from Owen Leonard --- Created attachment 19345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19345&action=edit Bug 10422 - Remove references to unused and non-existent wizard.css doc-head-close.inc contains a reference to "wizard.css" which doesn't exist. The option to include it never evaluates as true, and that section can be removed from the template. To test, apply the patch and view any page in the staff client. Everything should be styled as before. A search of the Koha source should return no references to "wizard.css" or a "wizard" variable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:09:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 14:09:54 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #22 from Julian Maurice --- Note that links are rebuild each time a checkbox is changed, so actions links point to valid URL and can be opened in a new window if your browser permit it (right click -> open in a new window) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:11:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 14:11:05 +0000 Subject: [Koha-bugs] [Bug 9998] Import/export and compare system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9998 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Galen Charlton --- Pushed to master. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:11:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 14:11:14 +0000 Subject: [Koha-bugs] [Bug 10499] UT: VirtualShelves.t needs a database transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10499 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:11:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 14:11:37 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 --- Comment #21 from Jonathan Druart --- I removed all my browsing data (clear cache and clear data from hosted apps), shift-refresh, used another browser, etc. But I still get a "blank" page (with "blank" I mean there is no content into the id="doc3" div element). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:13:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 14:13:47 +0000 Subject: [Koha-bugs] [Bug 10029] CAS authentication fails in OPAC reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10029 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:21:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 14:21:44 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19328|0 |1 is obsolete| | --- Comment #22 from Jared Camins-Esakov --- Created attachment 19346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19346&action=edit Bug 10240 QA follow-up Address the following issues: 1/ Address minor qa issues with the templates: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline-mf.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 24) [etc.] OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 509) [etc.] FAIL tt_valid lines 5, 5 2/ Run perltidy on new scripts 3/ download.pl returns data.finished = 1 if number of returned data < 5000 (avoids 1 ajax call) 4/ Replace qq{} around sql queries with q{} Also, a race condition existed that resulted in pending transactions only getting deleted from the local database in certain circumstances (fast connections under Chrome, mostly). This patch fixes that so that successfully-uploaded transactions are always deleted. This patch also addresses Jonathan's suggestion: 3/ add a message on check in (currently the input becomes empty but the user is not informed). ... and Magnus's suggestion about moving the Synchronize link to the right on the homepage. Finally, this patch adds a link to the Pending offline operations page on the synchronize page for easier navigation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:26:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 14:26:35 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #103 from Galen Charlton --- (In reply to Katrin Fischer from comment #101) > This is a huge patch. I am a bit worried of incorporating this without > feedback from a library using serials and subscriptions - especially worried > about the database update. Is it possible that we could get an anonymizsed > database from a library with lots of subscriptions to test with? I have a Koha database available to me with a large number of subscriptions that will be suitable for verifying that no regressions occur during upgrade, and I will be using that during testing. By the way, at the point in time that I am reading to push this patch, I intend to include a follow-up that makes the SQL for frequencies and numbering patterns mandatory during installation. If a user doesn't plan to use serials, populating the table doesn't hurt; if they do plan to use serials, making them start from scratch if they didn't run those scripts during installation only increases the height of the bar for a module that is inherently already difficult. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:32:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 14:32:33 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19346|0 |1 is obsolete| | --- Comment #23 from Jared Camins-Esakov --- Created attachment 19347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19347&action=edit Bug 10240 QA follow-up Address the following issues: 1/ Address minor qa issues with the templates: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline-mf.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 24) [etc.] OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 509) [etc.] FAIL tt_valid lines 5, 5 2/ Run perltidy on new scripts 3/ download.pl returns data.finished = 1 if number of returned data < 5000 (avoids 1 ajax call) 4/ Replace qq{} around sql queries with q{} Also, a race condition existed that resulted in pending transactions only getting deleted from the local database in certain circumstances (fast connections under Chrome, mostly). This patch fixes that so that successfully-uploaded transactions are always deleted. This patch also addresses Jonathan's suggestion: 3/ add a message on check in (currently the input becomes empty but the user is not informed). ... and Magnus's suggestion about moving the Synchronize link to the right on the homepage. Finally, this patch adds a link to the Pending offline operations page on the synchronize page for easier navigation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:35:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 14:35:22 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 --- Comment #104 from Galen Charlton --- (In reply to Paul Poulain from comment #102) > (In reply to Katrin Fischer from comment #101) > > This is a huge patch. I am a bit worried of incorporating this without > > feedback from a library using serials and subscriptions - especially worried > > about the database update. Is it possible that we could get an anonymizsed > > database from a library with lots of subscriptions to test with? > > Katrin, this improvement is used by 5 of our customers since more than one > year. The feature has been signed off by frederic Demians, Kyle, and > Bernardo. > Not counting my (as QAer) tests, and Jared ones (as he pushed the patch > before reverting it) > So I think we should go forward, and push this patch (otherwise it will > never be pushed). Let me be clear: I will always exercise my own technical judgment. The fact that others have reviewed a patch is necessary but not sufficient for me to push it. That said, upon looking at this, I am seeing a lot that I like about this approach, but given that the main patch revamps the core of serials prediction without adding any new test cases, I will have to write some myself as part of validating the patch. This won't be instantaneous, but it won't take forever, either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:40:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 14:40:08 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #245 from Galen Charlton --- (In reply to Paul Poulain from comment #244) > Galen, did you forget this patch ? Any other comment ? I'll be direct: this patch will remain low on my priority list as compared to other patches (like DBIx::Class support and functionality improvements) that offer greater benefit for less risk. The linear application of schema updates has made Koha's upgrade process one of the smoothest that I know of for the users, and I am very wary about making it more complicated for them. While I realize that merge conflicts can be annoying for the developers, I can at least promise as RM that I'll deal with that myself when I apply patches that update the schema. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:44:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 14:44:09 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 --- Comment #9 from Galen Charlton --- Comment on attachment 19335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19335 Bug 10215 - Increase the size of opacnote and librariannote for table subscriptionhistory Review of attachment 19335: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10215&attachment=19335) ----------------------------------------------------------------- ::: C4/Serials.pm @@ +483,4 @@ > $subs->{startdate} = format_date( $subs->{startdate} ); > $subs->{histstartdate} = format_date( $subs->{histstartdate} ); > $subs->{histenddate} = format_date( $subs->{histenddate} ); > + $subs->{opacnote} ||= q{}; Consider what happens if the opacnote happens to "0". The note entered by the user would not be displayed. Since 5.10 is the minimum version of Perl required by Koha, we can freely using the //= operator, and I recommend that you do that when you want to conditionally convert an undefined value to the empty string. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:44:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 14:44:20 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:46:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 14:46:31 +0000 Subject: [Koha-bugs] [Bug 10522] Javascript error on acquisition pages: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10522 --- Comment #4 from Owen Leonard --- (In reply to Jonathan Druart from comment #3) > Don't you think it is worth to create, for instance a basketgroup.js, and to > put this code in? That would certainly work. It would also work to replace the YUI-dependent JS with something that doesn't require YUI. I'm offering a minimal patch because I'm not familiar with how the basketgroups drag-and-drop JS works and would prefer that someone more familiar with acquisitions take it up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:47:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 14:47:53 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- CC|cnighswonger at foundations.ed | |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:50:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 14:50:26 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #31 from acowell at daviscollege.edu --- You would be correct, in a windows active directory domain the userPassword attribute is a write-only field. When viewed, it says . If I set auth_by_bind to 1 I receive this following error, no matter what user account I attempt to login as. I also do not see a failed login attempt in the LDAP server security event logs, so it?s like it?s failing before even attempting to connect to the LDAP server. [Tue Jul 02 08:11:39 2013] [error] [client 127.0.0.1] [Tue Jul 2 08:11:39 2013] opac-user.pl: LDAP Auth rejected : (sAMAccountName=duser1) gets 0 hits, referer: http://127.0.1.1/cgi-bin/koha/opac-user.pl [Tue Jul 02 08:11:39 2013] [error] [client 127.0.0.1] [Tue Jul 2 08:11:39 2013] opac-user.pl: LDAP error #1: LDAP_OPERATIONS_ERROR, referer: http://127.0.1.1/cgi-bin/koha/opac-user.pl What is strange, is if I set auth_by_bind to 0. I see in my domain controller this log that is scored by the auth_by_bind user, but won?t authenticate or create the users account in koha. An operation was performed on an object. Subject : Security ID: \ Account Name: Account Domain: Logon ID: 0x29a39618 Object: Object Server: DS Object Type: user Object Name: CN=Dummy User,OU=,OU=,OU=,OU=,DC=,DC= Handle ID: 0x0 Operation: Operation Type: Object Access Accesses: Control Access Access Mask: 0x100 Properties: Control Access {91e647de-d96f-4b70-9557-d63ff4f3ccd8} {6617e4ac-a2f1-43ab-b60c-11fbd1facf05} {b3f93023-9239-4f7c-b99c-6745d87adbc2} {b8dfa744-31dc-4ef1-ac7c-84baf7ef9da7} {771727b1-31b8-4cdf-ae62-4fe39fadf89e} {612cb747-c0e8-4f92-9221-fdd5f15b550d} {bf967aba-0de6-11d0-a285-00aa003049e2} Additional Information: Parameter 1: - Parameter 2: As for a step by step processing, we?re pretty much a pure Windows 2008 Domain Model right out of the box. So I?m not sure exactly what type of step by step I could provide, besides Microsoft documentation on authentication processes. http://technet.microsoft.com/en-us/library/cc755284(v=ws.10).aspx I can say that we have a Moodle server that is doing LDAPS authentication right to both of our domain controllers. A couple of notes from that server that I don?t see the ability to set in Koha is these options. LDAP Version = 3 LDAP Encoding = cp1252 I also see in Koha you can set a BASE, but in Moodle you set a context which is the first container to begin searching for users in. ou=,dc=,dc= I switched the in koha to CN=Users, DC=, DC= and moved the Dummy User to the Users container. But that didn?t work either, still receive the above LDAP_OPERATIONS_ERROR. I did a little more testing and actually fired up wireshark on the domain controller I'm trying to authenticate against. If I use Ubuntu's ldapsearch with the same information I'm using in the Koha-conf files. I get an LDAP bindRequest(1) "duser1 at daviscollege.edu" simple. When I attempt to authenticate through Koha. I get 'bindRequest(1) "" simple'. It's like Koha is not actually passing the authenticating users userPrincipleName through correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 16:52:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 14:52:01 +0000 Subject: [Koha-bugs] [Bug 10482] add items limit and sort to rebuild zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10482 Koha Team AMU changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 17:17:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 15:17:32 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 --- Comment #24 from Jonathan Druart --- > I get a blank page on the check out page > (circ/offline.pl#offline-circulation). The last patch fixes that, switch back to Needs Signoff I found some others small problems: - The tab of checkouts always shows "*0* Checkouts" - If I try to check in a nonexistent barcode, I get a warning message but the line is added to the table (maybe not a bug but a feature?) - If I am not well-educated, I click on the "Check out" link on the offline home page, I enter a barcode, click on "Check out" and I get a js error (without user message): "TypeError: curpatron is undefined" (with chromium I get: Numeric transaction modes are deprecated in IDBDatabase.transaction. Use "readonly" or "readwrite"). - There is a "border-right" css rule on the h5.patron-title. It is display when there is no patron selected) [really minor!]. - tables are displayed even if there is no data - The "Clear screen" link (X) points to an old script: circ/offline-circulation.pl - There is a warning when clicking on the "Synchronize" link when the user is offline, but not for the "Pending offline circulation actions" link. - Still exists: > The "Checked in item." message text never disappear (even if I go on the > offline home page (circ/offline.pl#offline-home)). No blocker for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 17:17:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 15:17:41 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 17:18:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 15:18:52 +0000 Subject: [Koha-bugs] [Bug 9231] Batch revert staged MARC records fails if one or more records in a batch have been deleted. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9231 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 17:18:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 15:18:56 +0000 Subject: [Koha-bugs] [Bug 9231] Batch revert staged MARC records fails if one or more records in a batch have been deleted. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9231 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17910|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 19348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19348&action=edit Bug 9231 - Batch revert staged MARC records fails if one or more records in a batch have been deleted. If a record in an imported batch is dleted, any attempt to revert the batch will result in the progress bar never reaching 100%. The background job dies when it hits the already deleted record, with the error occurring in C4::Items::DelItem for the line: $copy2deleted->execute( $record->as_usmarc(), $itemnumber ); which fails because $record is undefined. To keep the failure from causing the script to die, we just need to eval it. Then, even if it fails, the batch revert will keep going. Test Plan: 1) Stage a batch of marc records 2) Import those records 3) Delete one of those records 4) Attempt to revert the batch, it will hang. 5) Apply this patch 6) Repeat steps 1-4, the revert should succeed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 17:21:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 15:21:20 +0000 Subject: [Koha-bugs] [Bug 9231] Batch revert staged MARC records fails if one or more records in a batch have been deleted. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9231 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19348|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 19349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19349&action=edit Bug 9231 - Batch revert staged MARC records fails if one or more records in a batch have been deleted. If a record in an imported batch is dleted, any attempt to revert the batch will result in the progress bar never reaching 100%. The background job dies when it hits the already deleted record, with the error occurring in C4::Items::DelItem for the line: $copy2deleted->execute( $record->as_usmarc(), $itemnumber ); which fails because $record is undefined. To keep the failure from causing the script to die, we just need to eval it. Then, even if it fails, the batch revert will keep going. Test Plan: 1) Stage a batch of marc records 2) Import those records 3) Delete one of those records 4) Attempt to revert the batch, it will hang. 5) Apply this patch 6) Repeat steps 1-4, the revert should succeed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 17:25:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 15:25:29 +0000 Subject: [Koha-bugs] [Bug 9231] Batch revert staged MARC records fails if one or more records in a batch have been deleted. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9231 --- Comment #8 from Kyle M Hall --- (In reply to Chris Cormack from comment #5) Good idea! I've updated the patch to do so. It still seems odd to delete the item, and *then* look up the record, but I get the feeling this order is required, and it seems inefficient to call GetMarcBiblio both before and after calling _koha_delete_item, or to call something like GetBiblio. Any opinions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 17:29:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 15:29:13 +0000 Subject: [Koha-bugs] [Bug 9231] Batch revert staged MARC records fails if one or more records in a batch have been deleted. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9231 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19349|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 19350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19350&action=edit Bug 9231 - Batch revert staged MARC records fails if one or more records in a batch have been deleted. If a record in an imported batch is dleted, any attempt to revert the batch will result in the progress bar never reaching 100%. The background job dies when it hits the already deleted record, with the error occurring in C4::Items::DelItem for the line: $copy2deleted->execute( $record->as_usmarc(), $itemnumber ); which fails because $record is undefined. To keep the failure from causing the script to die, we just need to eval it. Then, even if it fails, the batch revert will keep going. Test Plan: 1) Stage a batch of marc records 2) Import those records 3) Delete one of those records 4) Attempt to revert the batch, it will hang. 5) Apply this patch 6) Repeat steps 1-4, the revert should succeed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 17:29:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 15:29:45 +0000 Subject: [Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 17:29:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 15:29:49 +0000 Subject: [Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 --- Comment #20 from Owen Leonard --- Created attachment 19351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19351&action=edit Bug 2774 - Path to theme is hard-coded in many places This patch corrects more places in Koha where the path to the "prog" theme is hard-coded in templates, CSS, and scripts. Staff client home page: Paths to the Koha logo background image and the module image sprite have been corrected. Inactive and hover states of the module links (circulation, patrons, etc) should look correct. addbiblio.pl: An tag is replaced with a text link and an additional CSS class. CSS uses an image-replacement technique to display the image as before. To test, open a blank or existing bibliographic record for editing. Confirm that the "tag editor" icon displays correctly in two cases: 1) tags linked to plugin editors and 2) tags linked to authorities. Both should look correct and work correctly. System preferences: The system preferences editor appends a "loading" image to system preference submit buttons when they are clicked. This patch changes ajax.js to insert a styled with a background-image instead. To test, open system preferences and modify any preference. Submit the change and confirm that the "loading" image appears correctly. Background jobs: Any place in Koha where a background job is used displays a progress bar. This patch corrects the path in CSS to the progress bar image. To test, perform an action which triggers the display of a progress bar. For instance, batch modification of items. Confirm that the progress bar image displays correctly. blue.css: I don't know if this is still used by anyone, but a couple of image paths in this CSS file have been corrected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 17:34:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 15:34:40 +0000 Subject: [Koha-bugs] [Bug 9845] SIP tests : fix in 08checkin.t ("alert" field) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9845 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 17:34:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 15:34:42 +0000 Subject: [Koha-bugs] [Bug 9845] SIP tests : fix in 08checkin.t ("alert" field) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9845 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19269|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 19352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19352&action=edit Bug 9845: SIP tests : fixes in 08checkin.t The tests were too restrictive. It should be possible to pass a checkin/checkout test with different values defined for magnetic medias. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 18:18:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 16:18:39 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Kyle M Hall --- I'm afraid I was able to apply this patch cleanly to current master. I'm not sure why you are unable to apply it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 18:42:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 16:42:26 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #59 from Kyle M Hall --- You're right, I think the test plan should be: Test plan: 1) Note your ReservesMaxPickUpDelay setting. 2) Create and trap a hold 3) View waitingreserves.pl, note the last pickup date, and the pickup location 4) Cancel this hold 5) Edit the calendar for the given location, and make the pickup date a holiday 6) Repeat step 2 7) View waitingreserves.pl, the last pickup date for this new hold should now be the increased by one day -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 19:04:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 17:04:12 +0000 Subject: [Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #5 from Kyle M Hall --- Looks like this patch needs re-signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 20:00:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 18:00:17 +0000 Subject: [Koha-bugs] [Bug 10439] Cannot modify the notice's library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10439 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 20:00:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 18:00:57 +0000 Subject: [Koha-bugs] [Bug 10464] Patron search on placing a hold doesn't use jqueryui.autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 20:03:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 18:03:09 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- The patch for request.pl and request.tt has been pushed to 3.12.x as a dependency for bug 10464, will be in 3.12.2. Thanks Colin! -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 20:03:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 18:03:42 +0000 Subject: [Koha-bugs] [Bug 10141] Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Bernardo, great job! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 20:04:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 18:04:37 +0000 Subject: [Koha-bugs] [Bug 10466] Lists: Use "size" as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10466 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 20:10:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 18:10:33 +0000 Subject: [Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mirko at abunchofthings.net Assignee|oleonard at myacpl.org |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 21:08:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 19:08:12 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19347|0 |1 is obsolete| | --- Comment #25 from Jared Camins-Esakov --- Created attachment 19353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19353&action=edit Bug 10240 QA follow-up Address the following issues: 1/ Address minor qa issues with the templates: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline-mf.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 24) [etc.] OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 509) [etc.] FAIL tt_valid lines 5, 5 2/ Run perltidy on new scripts 3/ download.pl returns data.finished = 1 if number of returned data < 5000 (avoids 1 ajax call) 4/ Replace qq{} around sql queries with q{} Also, a race condition existed that resulted in pending transactions only getting deleted from the local database in certain circumstances (fast connections under Chrome, mostly). This patch fixes that so that successfully-uploaded transactions are always deleted. This patch also addresses Jonathan's suggestion: 3/ add a message on check in (currently the input becomes empty but the user is not informed). ... and Magnus's suggestion about moving the Synchronize link to the right on the homepage. Also, this addresses the further issues Jonathan noted: - The tab of checkouts always shows "*0* Checkouts" - If I am not well-educated, I click on the "Check out" link on the offline home page, I enter a barcode, click on "Check out" and I get a js error (without user message): "TypeError: curpatron is undefined" (with chromium I get: Numeric transaction modes are deprecated in IDBDatabase.transaction. Use "readonly" or "readwrite"). - There is a "border-right" css rule on the h5.patron-title. It is display when there is no patron selected) [really minor!]. - tables are displayed even if there is no data - The "Clear screen" link (X) points to an old script: circ/offline-circulation.pl - There is a warning when clicking on the "Synchronize" link when the user is offline, but not for the "Pending offline circulation actions" link. - Still exists: > The "Checked in item." message text never disappear (even if I go on the > offline home page (circ/offline.pl#offline-home)). Finally, this patch adds a link to the Pending offline operations page on the synchronize page for easier navigation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 2 23:46:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 21:46:00 +0000 Subject: [Koha-bugs] [Bug 8911] docs/history.txt file missing for about.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8911 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 19354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19354&action=edit Bug 8911 - history.txt file missing for about.pl This patch makes Makefile.PL put the history.txt file in the right places depending on the chosen setup layout, adds a reference to that place in koha-conf.xml (and debian template version), and finally tweaks about.pl to use it. To test, apply the patch and verify that perl Makefile.PL runs fine, and installing in - dev - single - standard layouts works as expected. Then go to the about.pl page and see if Koha's history shows there. Then, build your packages and test on your newly created instances. Regards To+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 00:14:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 22:14:09 +0000 Subject: [Koha-bugs] [Bug 8911] docs/history.txt file missing for about.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8911 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |tomascohen at gmail.com Patch complexity|--- |Trivial patch Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 00:29:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jul 2013 22:29:23 +0000 Subject: [Koha-bugs] [Bug 9987] biblioitemnumber is useless for orders. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9987 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #20 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 04:37:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 02:37:45 +0000 Subject: [Koha-bugs] [Bug 10488] New MARC21 authority tags and subfields should be propagated to non-default frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10488 --- Comment #9 from Bernardo Gonzalez Kriegel --- (In reply to Galen Charlton from comment #8) > The 162 certainly doesn't belong in them all, and I'm not sure if it belongs > in GENRE/FORM or if a new authority type code should be defined. > > Setting to "In Discussion". This patch is very close to being ready, but > the 162 should be dealt with, either by simply excluding it from all but the > default authority type or by defining a new authority type. I'm hoping > Jared can advise regarding the latter. I think the fastest solution is to exclude 162 from all non default frameworks. Any new authtype could be created later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 05:29:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 03:29:39 +0000 Subject: [Koha-bugs] [Bug 7232] clicking title on receive should open in new window/tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7232 --- Comment #2 from Nicole C. Engard --- I don't know that it's a bad thing to force - or maybe have a pop up that shows the title info. Losing your basket is annoying to many librarians using this feature. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 07:15:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 05:15:43 +0000 Subject: [Koha-bugs] [Bug 10530] New: PO number search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10530 Bug ID: 10530 Summary: PO number search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: amitddng135 at gmail.com Ability to search by Purchase order number this feature is related to bug 4456 bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4456 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 07:15:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 05:15:58 +0000 Subject: [Koha-bugs] [Bug 10530] PO number search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10530 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com QA Contact| |amitddng135 at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 07:35:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 05:35:30 +0000 Subject: [Koha-bugs] [Bug 10531] New: Basket name and PO number on receipt screen Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 Bug ID: 10531 Summary: Basket name and PO number on receipt screen Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: amitddng135 at gmail.com To list the basket name or PO number on the receipt screen to identify the lot that you are receiving -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 07:35:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 05:35:44 +0000 Subject: [Koha-bugs] [Bug 10531] Basket name and PO number on receipt screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com QA Contact| |amitddng135 at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 08:36:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 06:36:39 +0000 Subject: [Koha-bugs] [Bug 10532] New: koha-run-backups option --output doesn't work Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10532 Bug ID: 10532 Summary: koha-run-backups option --output doesn't work Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: pongtawat.c at gmail.com CC: robin at catalyst.net.nz Although koha-run-backups has an option --output for specifying location of the backup, the option doesn't work. Simply because koha-run-backups call koha-dump which always dump to backupdir in Koha config file. So either koha-run-backups should move the backup set to the specified output or we should also made koha-dump support --output option. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 08:44:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 06:44:24 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 08:44:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 06:44:27 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19341|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 19355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19355&action=edit [SIGNED OFF] Bug 10519 - Suggestions: 'Organize by' and correct display of tab descriptions broken - Change "Unknown" to authorised value Signed-off-by: Katrin Fischer Small patch, dealing with the display when no description for the authorized value is found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 08:44:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 06:44:48 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 --- Comment #10 from Katrin Fischer --- Created attachment 19356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19356&action=edit Bug 10519: Suggestions: 'Organize by' and correct display of tab descriptions broken The tabbed display in suggestions offers different options to organize the tabs. The descriptions on the tabs and some of the search options were not working correctly. To test: - Add several suggestions to your installation, make sure you have: - suggestions from various libraries and at least one for 'Any library' that has been created from the intranet - suggestions from different users - suggestions with different status - suggestions with different selected itypes Test all the 'organize by' options, make sure that the tabs have correct descriptions. - Add 1 or 2 custom status to SUGGEST_STATUS authorized value. - Verify display is still correct and your new status are displayed. Test setting the library option in the acquisition section of the filters keeps "Any" when you select it, so you can make use of the 'organize by libraries'. Before this patch the pull down would always jump back to your own branch. Note: Patch best tested in combination with bug 4907. Conflicts: suggestion/suggestion.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 08:46:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 06:46:27 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 --- Comment #11 from Katrin Fischer --- The last patch in combination with bug 4907 seems to make things work better, but please test thoroughly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 09:27:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 07:27:48 +0000 Subject: [Koha-bugs] [Bug 10488] New MARC21 authority tags and subfields should be propagated to non-default frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10488 --- Comment #10 from M. de Rooy --- In this new Bugzilla version, it happens sometimes that I cannot reply to a comment (the former comment is not pasted in to the new comment).. > The 162 certainly doesn't belong in them all, and I'm not sure if it belongs > in GENRE/FORM or if a new authority type code should be defined. Good catch, Galen. Scrutiny++ :) It looks to me that this actually is a new type of authority. See for instance: http://www.loc.gov/marc/marbi/2012/2012-dp02.html > ...but the 162 should be dealt with, either by simply excluding it from all > but the default authority type or by defining a new authority type. I agree with Bernardo's last suggestion to exclude the 162 now. And maybe we can let Jared(..) add the new type on a separate report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 09:48:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 07:48:45 +0000 Subject: [Koha-bugs] [Bug 10488] New MARC21 authority tags and subfields should be propagated to non-default frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10488 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19313|0 |1 is obsolete| | --- Comment #11 from M. de Rooy --- Created attachment 19357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19357&action=edit Bug 10488: Followup replacing DELETEs by more restricted INSERTs Instead of inserting followed by deleting, this patch combines the two where clauses of both sql statements, meanwhile leaving the separation intact. As suggested by Galen, removed all 162's from the non-default types. The 162 calls for a new authority type. We can add that later on. Signed-off-by: Marcel de Rooy Ran this .sql script after deleting all auth records. The former version had 9 types, 1148 tags and 11621 subfields. This one has 9 types, 1140 tags and 11597 subfields. That is expected: 8 tags 162 less and 8x3 subfields less. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 09:50:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 07:50:39 +0000 Subject: [Koha-bugs] [Bug 10488] New MARC21 authority tags and subfields should be propagated to non-default frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10488 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #12 from M. de Rooy --- I have updated the followup for removal of 162, and park this report into Passed QA status again to the attention of Galen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 10:51:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 08:51:33 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #32 from Rolando Isidoro --- I too manage some Moodle installations with LDAP auth and it works the same way as in our Koha installation. Nevertheless I'm already looking at Moodle's LDAP settings and source code to try to understand how they implement the AD case. All that technical info from MS' site is too much and not conclusive, I was looking for something in the likes of what I wrote on comment #6 of this thread. If you can provide such a description that would be a plus. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 10:56:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 08:56:00 +0000 Subject: [Koha-bugs] [Bug 10522] Javascript error on acquisition pages: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 10:56:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 08:56:04 +0000 Subject: [Koha-bugs] [Bug 10522] Javascript error on acquisition pages: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19342|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 19358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19358&action=edit Bug 10522 - Javascript error on acquisition pages: YAHOO is not defined acq.js includes an immediately invoked function expression, which means that it runs whether or not it is called. Because this function tries to reference the YAHOO object, it triggers an error on pages which don't include the main YAHOO assets. Only the basketgroups page uses this function and YAHOO assets. It's probably possible to make this a regular function, but I propose simply wrapping it in a check for the YAHOO object so that it only executes on pages where YAHOO exists--the basketgroups page. To test, apply the patch, clear your browser cache, and test on both the basketgroups page and at least one page which also includes acq.js (addorderiso2709.pl, neworderempty.pl, aqbudgets.pl, suggestion.pl, etc.) and confirm that the browser reports no JavaScript errors. Signed-off-by: Jonathan Druart $ git show HEAD -w [...] - +if( typeof(YAHOO) === "object"){ (function() { var Dom = YAHOO.util.Dom; @@ -234,7 +234,7 @@ YAHOO.extend(DDList, YAHOO.util.DDProxy, { } }); })(); - +} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 10:58:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 08:58:45 +0000 Subject: [Koha-bugs] [Bug 10533] New: basketgroup js functions should in a separated js file Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Bug ID: 10533 Summary: basketgroup js functions should in a separated js file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com acqui/basketgroup.tt loads acq.js and a lot of acqui/*.tt loads js functions only used for basketgroup management. These functions should be in a separated js file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 10:58:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 08:58:57 +0000 Subject: [Koha-bugs] [Bug 10522] Javascript error on acquisition pages: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10533 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 10:58:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 08:58:57 +0000 Subject: [Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |10522 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 11:05:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 09:05:33 +0000 Subject: [Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 11:05:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 09:05:35 +0000 Subject: [Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 --- Comment #1 from Jonathan Druart --- Created attachment 19359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19359&action=edit Bug 10533: basketgroup js functions should in a separated js file This patch moves js functions used for managing basketgroup into a separated js file. Test plan: - Try all actions for basketgroup ( drag/drop, add, delete, close, print, reopen, edit, export as csv). - Check that there is no regression on others acquisition pages: * acqui/neworderempty.tt * acqui/uncertainprice.tt * acqui/addorderiso2709.tt * acqui/basketheader.tt * admin/aqbudgets.tt * admin/aqcontract.tt * admin/aqbudgetperiods.tt * admin/aqplan.tt * suggestion/suggestion.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 11:55:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 09:55:23 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #60 from Jonathan Druart --- Kyle, I agree with your test plan. I am signing off your patch. But I think I found a bug, could you take a look at this new patch please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 11:55:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 09:55:48 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19181|0 |1 is obsolete| | --- Comment #61 from Jonathan Druart --- Created attachment 19360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19360&action=edit Bug 8367: Skip to next open day if max pickup date is a holiday Test plan: 1) Note your ReservesMaxPickUpDelay setting. 2) Create and trap a hold 3) View waitingreserves.pl, note the last pickup date, and the pickup location 4) Cancel this hold 5) Edit the calendar for the given location, and make the pickup date a holiday 6) Repeat step 2 7) View waitingreserves.pl, the last pickup date for this new hold should now be the increased by one day Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 11:55:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 09:55:58 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #62 from Jonathan Druart --- Created attachment 19361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19361&action=edit Bug 8367: Fix the maxpickupdate when we set waitingdate to NOW() ModReserveAffect get the maxpickupdate before changing the waitingdate to NOW. We should update the waitingdate and next calculate the maxpickupdate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 12:10:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 10:10:15 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #63 from Katrin Fischer --- Hmm, I think NOW() is a mysqlism. I know we probably have lots of those in the codebase already, but maybe worth trying not to add more and find best practices for replacing them? Mtj suggested using CURRENT_TIMESTAMP() instead on IRC: http://dev.mysql.com/doc/refman/5.1/en/date-and-time-functions.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 12:16:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 10:16:45 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #64 from Jonathan Druart --- (In reply to Katrin Fischer from comment #63) > Hmm, I think NOW() is a mysqlism. I know we probably have lots of those in > the codebase already, but maybe worth trying not to add more and find best > practices for replacing them? > > Mtj suggested using CURRENT_TIMESTAMP() instead on IRC: > http://dev.mysql.com/doc/refman/5.1/en/date-and-time-functions.html I don't add it, it already exists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 12:17:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 10:17:06 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Silvia Simonetti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |s.simonetti at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 12:21:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 10:21:17 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 12:21:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 10:21:19 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19361|0 |1 is obsolete| | --- Comment #65 from Kyle M Hall --- Created attachment 19362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19362&action=edit Bug 8367: Fix the maxpickupdate when we set waitingdate to NOW() ModReserveAffect get the maxpickupdate before changing the waitingdate to NOW. We should update the waitingdate and next calculate the maxpickupdate. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 12:22:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 10:22:30 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #66 from Katrin Fischer --- Ok, maybe we could take a look at the NOW()s another time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 12:22:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 10:22:33 +0000 Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition module could order by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Silvia Simonetti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |s.simonetti at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 12:26:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 10:26:00 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Silvia Simonetti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |s.simonetti at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 12:26:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 10:26:42 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #67 from Kyle M Hall --- (In reply to Katrin Fischer from comment #66) > Ok, maybe we could take a look at the NOW()s another time. Yes, I would suggest filing a bug report to take care of any NOW()'s in the codebase. It seems likely however, that the upcoming DBIx::Class switchover will take care of those anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 12:50:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 10:50:19 +0000 Subject: [Koha-bugs] [Bug 4907] Suggestions "organize by" menu doesn't reflect current choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4907 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 12:50:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 10:50:21 +0000 Subject: [Koha-bugs] [Bug 4907] Suggestions "organize by" menu doesn't reflect current choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4907 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19329|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 19363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19363&action=edit Bug 4907: 'Organize by' filter in suggestions doesn't reflect selected option When using the 'Organize by' option to change the display of the suggestions, the option is applied, but the pull down always jumps back to the first entry 'Status'. This patch fixes that. To test: - Try out all settings and verify that after the page reloads the selected option is applied to your suggestions and the pull down shows the option you selected. Note: Until bug 10519 is properly fixed the tabs will not show the correct descriptions, but the URL will show you the selected option as parameter: displayby=acceptedby Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 12:54:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 10:54:54 +0000 Subject: [Koha-bugs] [Bug 10534] New: Update of italian SQL files [3.12 only] Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10534 Bug ID: 10534 Summary: Update of italian SQL files [3.12 only] Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: s.simonetti at cineca.it CC: frederic at tamil.fr This patch is done for update SQL files for new installations. We operate only for 3.12 because master will use a new system, see bug 10509. This patch not covers MARC21 and Unimarc sql definitions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 12:55:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 10:55:30 +0000 Subject: [Koha-bugs] [Bug 10534] Update of italian SQL files [3.12 only] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10534 Silvia Simonetti changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 12:56:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 10:56:17 +0000 Subject: [Koha-bugs] [Bug 10534] Update of italian SQL files [3.12 only] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10534 Silvia Simonetti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 12:57:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 10:57:36 +0000 Subject: [Koha-bugs] [Bug 10534] Update of italian SQL files [3.12 only] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10534 Silvia Simonetti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 13:15:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 11:15:15 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 13:15:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 11:15:17 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19356|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 19364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19364&action=edit Bug 10519: Suggestions: 'Organize by' and correct display of tab descriptions broken The tabbed display in suggestions offers different options to organize the tabs. The descriptions on the tabs and some of the search options were not working correctly. To test: - Add several suggestions to your installation, make sure you have: - suggestions from various libraries and at least one for 'Any library' that has been created from the intranet - suggestions from different users - suggestions with different status - suggestions with different selected itypes Test all the 'organize by' options, make sure that the tabs have correct descriptions. - Add 1 or 2 custom status to SUGGEST_STATUS authorized value. - Verify display is still correct and your new status are displayed. Test setting the library option in the acquisition section of the filters keeps "Any" when you select it, so you can make use of the 'organize by libraries'. Before this patch the pull down would always jump back to your own branch. Note: Patch best tested in combination with bug 4907. Conflicts: suggestion/suggestion.pl Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 13:28:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 11:28:34 +0000 Subject: [Koha-bugs] [Bug 10488] New MARC21 authority tags and subfields should be propagated to non-default frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10488 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Galen Charlton --- Pushed to master. Thanks, Bernardo and Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 13:32:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 11:32:01 +0000 Subject: [Koha-bugs] [Bug 10428] undefined check in add additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10428 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 14:00:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 12:00:05 +0000 Subject: [Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 --- Comment #5 from M. de Rooy --- Looking at this now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 14:23:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 12:23:50 +0000 Subject: [Koha-bugs] [Bug 10535] New: by default sort funds by name Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Bug ID: 10535 Summary: by default sort funds by name Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: fridolyn.somers at biblibre.com In parcels.pl, and other acquisition pages, the funds are not sorted by name in combo-box. With a great number of founds, it is difficult to find one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 14:29:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 12:29:49 +0000 Subject: [Koha-bugs] [Bug 10535] by default sort funds by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |fridolyn.somers at biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 19365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19365&action=edit Proposed patch See commit message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 14:29:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 12:29:55 +0000 Subject: [Koha-bugs] [Bug 10535] by default sort funds by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 14:54:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 12:54:27 +0000 Subject: [Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 --- Comment #6 from M. de Rooy --- Created attachment 19366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19366&action=edit Bug 10462: Followup for showing multiple ISBNs in Z3950 response As Jonathan correctly noted, the new Z3950 response only showed one isbn although more isbn numbers could be in the record and would be imported. To resolve this display problem, I traverse them all now in the updated routine _isbn_show. There is no change in the imported records. Note that before this patch TransformMarcToKoha did put all isbn numbers in one field, separated by pipes (for display only). This behavior is restored now. The three regexes on the individual isbn numbers now seem to be overkill, but I left them there for completeness. Signed-off-by: Marcel de Rooy Tested this on a fresh French install under UNIMARC with BNF server. Tested it too for MARC21. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 14:58:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 12:58:39 +0000 Subject: [Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 --- Comment #7 from M. de Rooy --- Jonathan, Thanks for testing. Good catch for the isbn numbers. Note that it only was a display problem. As explained on the followup commit message, this has been resolved now. You are more than welcome to check again :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 15:18:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 13:18:37 +0000 Subject: [Koha-bugs] [Bug 10536] New: Error when editing an order note when receiving Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10536 Bug ID: 10536 Summary: Error when editing an order note when receiving Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: fridolyn.somers at biblibre.com When receiving ordrers "acqui/parcel.pl?invoiceid=1", you can add or modify an order note directly from table. After setting note "acqui/modordernotes.pl", you get an error : Can't use an undefined value as an ARRAY reference at /acqui/parcel.pl line 156. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 15:28:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 13:28:32 +0000 Subject: [Koha-bugs] [Bug 10536] Error when editing an order note when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10536 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |fridolyn.somers at biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 19367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19367&action=edit Proposed patch See commit message. Trivial template bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 15:28:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 13:28:38 +0000 Subject: [Koha-bugs] [Bug 10536] Error when editing an order note when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10536 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 15:28:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 13:28:39 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #28 from M. de Rooy --- fatal: sha1 information is lacking or useless (installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 5858 - Update default MARC21 framework to Update No. 16 (April 2013) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 15:48:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 13:48:47 +0000 Subject: [Koha-bugs] [Bug 10536] Error when editing an order note when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10536 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- *** Bug 9187 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 15:48:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 13:48:47 +0000 Subject: [Koha-bugs] [Bug 9187] Wrong parameter in 'Edit note' link on order receive page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9187 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 10536 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:01:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:01:05 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 --- Comment #105 from Julian Maurice --- Created attachment 19368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19368&action=edit Bug 7688: Add unit tests for C4::Serials::Frequency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:01:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:01:11 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 --- Comment #106 from Julian Maurice --- Created attachment 19369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19369&action=edit Bug 7688: Add unit tests for C4::Serials::Numberpattern -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:01:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:01:18 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 --- Comment #107 from Julian Maurice --- Created attachment 19370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19370&action=edit Bug 7688: Add unit tests for C4::Serials::GetNextDate() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:03:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:03:58 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 --- Comment #108 from Julian Maurice --- Here are some unit tests for the two added Perl modules, plus unit tests for GetNextDate(). I'm currently working on unit tests for GetNextSeq(). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:06:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:06:31 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #29 from Bernardo Gonzalez Kriegel --- (In reply to M. de Rooy from comment #28) > fatal: sha1 information is lacking or useless > (installer/data/mysql/en/marcflavour/marc21/mandatory/ > marc21_framework_DEFAULT.sql). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. > Patch failed at 0001 Bug 5858 - Update default MARC21 framework to Update > No. 16 (April 2013) Strange ~/kohaclone$ git pull Already up-to-date. ~/kohaclone$ git checkout bug_5858-B Switched to branch 'bug_5858-B' Your branch is behind 'origin/master' by 11 commits, and can be fast-forwarded. ~/kohaclone$ git rebase master First, rewinding head to replay your work on top of it... Fast-forwarded bug_5858-B to master. ~/kohaclone$ git bz apply 5858 Bug 5858 - Update default MARC21 framework to Update No. 16 (April 2013) Bug 5858 - Default frameworks missing many MARC21 tags Apply? [yn] y Applying: Bug 5858 - Default frameworks missing many MARC21 tags [FOLLOWUP] Bug 5858 - Default frameworks missing many MARC21 tags Apply? [yn] y Applying: Bug 5858 - Default frameworks missing many MARC21 tags [FOLLOWUP 2] Bug 5858 - Update default MARC21 framework Apply? [yn] y Applying: Bug 5858 - Update default MARC21 framework to Update No. 16 (April 2013) ~/kohaclone$ For me it's applying without problem, should I switch to Needs Singoff? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:07:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:07:48 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #30 from M. de Rooy --- Bernardo: Try to apply them on top of current master (with git-bz) ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:18:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:18:07 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #33 from acowell at daviscollege.edu --- Those steps are exactly how I believe it should be handled. However, I notice this line. - The setting in koha-conf.xml isn't used anymore; That appears to be the problem with AD LDAP. I wish I could upload a picture of my Wireshark results. On the bindRequest(1) "" packet coming from Koha login attempt it says that the authentication is simple, but the authentication name is missing. I'm wondering if it's missing because the principal_name is not passed to AD/LDAP now? On the ldapsearch in Ubuntu, when I capture those packets. The authentication is simple, but it has the binding account username & password filled in, in the bindRequest. I'm not sure if this site might help you at all, but I just stumbled a crossed it and thought I'd share. http://www.netid.washington.edu/documentation/ldapAuth.aspx Basically, password are passed to LDAP to verify that an account can connect. If it can, then success and then grab Attributes. Now AD LDAP Doesn't store passwords in readable formats in attributes, instead I believe it utilizes some type of tokens. Koha should not store the password for the user that authenticated or tokens. I don't know how Koha actually looks at authentication, like if it always attempts ldap before local auth lookups if use ldap is set to 1 or not. But LDAP auth should be prioritized over local auth and the locally stored record of the users account should be created with a field or tagged some how indicating that it's an LDAP user, so whenever the system tries to verify the account it always checks against LDAP. Maybe I'm just babbling and Koha already does this in some sort. Aaron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:29:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:29:21 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #31 from M. de Rooy --- Bernardo: I am getting further with Mason's patch when I use --ignore-whitespace on the patch file. Shall I continue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:32:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:32:04 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #32 from M. de Rooy --- Created attachment 19371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19371&action=edit Bug 5858 - Default frameworks missing many MARC21 tags This patch replaces previous ones. Only adds missing tags/subtags or update descriptions. Only to new installs. To test: 1) Delete MARC21 default framework 2) Apply patch 3) Test that new default framework loads without problem Rebased to master. Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:32:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:32:08 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18584|0 |1 is obsolete| | --- Comment #33 from M. de Rooy --- Created attachment 19372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19372&action=edit Bug 5858 - Default frameworks missing many MARC21 tags This patch is a *followup* to the previous patch Update MARC21 fields/subfields to version 16 http://www.loc.gov/marc/bibliographic/bdapndxg.html Only to new installs. To test: 1) Delete MARC21 default framework 2) Apply patch 3) Test that new default framework loads without problem Rebased to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:32:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:32:13 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #34 from M. de Rooy --- Created attachment 19373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19373&action=edit Bug 5858 - Update default MARC21 framework to Update No. 16 (April 2013) This is another followup. It updates some missing tags/subtags, also corrects and verify repeatable value for tags/subtags -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:33:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:33:23 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #35 from M. de Rooy --- Sorry, couldn't wait. Yes, we are back in the air. Three patches applied. Will have a look again :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:34:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:34:07 +0000 Subject: [Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #8 from Jonathan Druart --- QA comment: Looking at the code, nothing to say. It is not perfect, but it has the merit of being better than before (using refactoring). I did not find any regression with the last patch. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:34:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:34:19 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18585|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:34:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:34:21 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19330|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:34:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:34:26 +0000 Subject: [Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18983|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 19374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19374&action=edit Bug 10462: Some optimizations in Z3950 search paving the way for enhancements Refactors Z3950Search. Disable batch record counts for z3950 records. Test plan: Do various Z3950 searches on multiple targets from Cataloging and Acquisition. Behavior should not have changed. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:34:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:34:32 +0000 Subject: [Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19366|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 19375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19375&action=edit Bug 10462: Followup for showing multiple ISBNs in Z3950 response As Jonathan correctly noted, the new Z3950 response only showed one isbn although more isbn numbers could be in the record and would be imported. To resolve this display problem, I traverse them all now in the updated routine _isbn_show. There is no change in the imported records. Note that before this patch TransformMarcToKoha did put all isbn numbers in one field, separated by pipes (for display only). This behavior is restored now. The three regexes on the individual isbn numbers now seem to be overkill, but I left them there for completeness. Signed-off-by: Marcel de Rooy Tested this on a fresh French install under UNIMARC with BNF server. Tested it too for MARC21. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:36:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:36:00 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:37:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:37:13 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to selelct multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:37:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:37:16 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to selelct multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 --- Comment #3 from Owen Leonard --- Created attachment 19376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19376&action=edit Bug 3134 - Ability to selelct multiple reports to delete at once This patch adds the option to select multiple saved reports for deletion. To test you must have two or more saved reports to delete. Deletion should work properly when: - Selecting one report for deletion by checking the box. - Selecting more than one report for deletion by checking boxes. - Clicking the old "Delete" link Clicking the delete button should prompt you to confirm. Clicking cancel should cancel. Clicking the delete button when no boxes are checked should trigger an alert asking you to select reports for deletion. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:39:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:39:27 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to selelct multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19376|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Comment on attachment 19376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19376 Bug 3134 - Ability to selelct multiple reports to delete at once Grrr... Another prematurely-sent version of this patch. This one breaks the report group tabs. Back to the drawing board. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:39:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:39:35 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to selelct multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 16:54:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 14:54:32 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #34 from acowell at daviscollege.edu --- Ok, I just had a major break through and realized, hey... why don't I just reverse this patch and see what happens... SUCCESS! I can now authenticate to Active Directory LDAP with no problems! I believe that it's the dropping out of using the principal_name that broke AD LDAP Auth. Aaron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 17:16:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 15:16:19 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #36 from M. de Rooy --- I still need some time for these patches. Will hopefully finish this tomorrow. When squashing these patches, I again had the whitespace trouble. So we need some care with this set of patches. This is an impressive amount of work, Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 17:52:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 15:52:46 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18546|0 |1 is obsolete| | --- Comment #17 from Owen Leonard --- Created attachment 19377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19377&action=edit [SIGNED-OFF] Bug 9032: Share a list (dbrev for SHARE_INVITE notice) Adds notice in updatedatabase and sample_notices. Test plan: Do install or upgrade and verify that you have the new notice under Tools. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 17:55:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 15:55:21 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18619|0 |1 is obsolete| | --- Comment #18 from Owen Leonard --- Created attachment 19378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19378&action=edit [SIGNED-OFF] Bug 9032: Followup for new dependency Email::Valid Just adds this dependency to PerlDependencies module. Note from Robin: libemail-valid-perl is in squeeze already. Test plan: You should see Email::Valid now under About/Perl modules. If Email::Valid is not yet installed on your system, please do so. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 17:59:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 15:59:47 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18619|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 18:00:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 16:00:04 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18547|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 18:02:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 16:02:20 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 18:02:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 16:02:23 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18619|0 |1 is obsolete| | --- Comment #19 from Owen Leonard --- Created attachment 19379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19379&action=edit [SIGNED-OFF] Bug 9032: Share a list (part 1: send the invitation) Adds a Share button for OPAC private lists. Allows you to send an invitation to share a list. Checks on validity of email addresses (with Email::Valid). NOTE: This patch adds a routine to VirtualShelves.pm but does not add a test in VirtualShelves.t. This is intentional: I will still add a test, but saw report 10290 and came across a few other problems in this unit test. Will add a patch under report 10386. Test plan: 1) Sharing depends on syspref and login. Toggle the pref OpacAllowSharingPrivateList. If enabled, you should see the Share button in OPAC/Private lists. Click on the Share button. You should get Share a list. Logout and try to go back to opac/opac-shareshelf.pl It should now present you the login form. 2) Try to share a public list or a list you do not own. Find a security hole in the interface. Or hack the shareshelf URL and replace the shelfnumber with a public list number. 3) Enter no email address or invalid ones (no domain, forbidden chars). If you enter no address, submit should not work. If you enter only wrong addresses (separated by: ,:; ), you get a message. 4) Test if sending the invitation works. Share one of your private lists. Enter your own email address. After your proc_message_queue cronjob ran, you should have an email. Check also if you see a new record in the virtualshelfshares table. Note that the followup patch handles the second part of accepting this share. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 18:03:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 16:03:42 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #20 from Owen Leonard --- Note to QA: Because of the order in which the patches were signed off the first one, "[Template follow-up] Share a list (part 1: send the invitation)" should be applied last. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 18:15:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 16:15:20 +0000 Subject: [Koha-bugs] [Bug 10537] New: Super Librarian Access Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10537 Bug ID: 10537 Summary: Super Librarian Access Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: jesse at bywatersolutions.com CC: gmcharlt at gmail.com Staff members or people granted permission to give permission should be able only give permissions that they have on their own account. Does that make sense? So if someone is not a superlibrarian they cannot give someone else permission to be a superlibrarian. Right now if you have the permission "(permissions) Allow staff members to modify permissions for other staff members" someone without superlibrarian permissions can give another person superlibrarian permissions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 18:41:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 16:41:31 +0000 Subject: [Koha-bugs] [Bug 5766] Add configuration for excluding articles from jQuery table sorter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5766 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 18:41:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 16:41:34 +0000 Subject: [Koha-bugs] [Bug 5766] Add configuration for excluding articles from jQuery table sorter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5766 --- Comment #2 from Owen Leonard --- Created attachment 19380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19380&action=edit Bug 5766 - Add configuration for excluding articles from DataTables sorting Client-side table sorting should exclude articles like "a," "an," and "the" when sorting by title. This patch adds a custom sorting plugin for use by DataTables and a configuration line to the DataTables string configuration file which can be translated for any language. As an example, this patch modifies the patron checkout history template to use the new sort on the title column. To test, apply the patch and clear your browser cache to ensure the revised JavaScript file is loaded. Sort the table by title. Titles should be sorted regardless of the presences of "a," "an", or "the" at the beginning of the title. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 19:22:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 17:22:53 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #35 from Rolando Isidoro --- Can you paste the LDAP section of your current working koha-conf.xml? I'll try to come up with an update to the patch to allow your AD LDAP auth scenario without messing with the existing ones. Guess I didn't succeed in my previous effort :s -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 20:42:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 18:42:09 +0000 Subject: [Koha-bugs] [Bug 10125] Babeltheque star image must use sprite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10125 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 20:42:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 18:42:13 +0000 Subject: [Koha-bugs] [Bug 10125] Babeltheque star image must use sprite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10125 --- Comment #1 from Owen Leonard --- Created attachment 19381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19381&action=edit Bug 10125 - Babeltheque star image must use sprite When I removed images from the OPAC in favor of sprites I didn't take into account the display of star ratings from Babeltheque. This patch copies the star ratings display from Koha's own ratings display, though it is not dependent on JavaScript. I'm sure testing would be easy for someone with access to the Babeltheque service, but I do not. I temporarily modified the template to set some variables for testing purposes: [% SET SEARCH_RESULT.score_int = 3 %] [% SET SEARCH_RESULT.score_avg = 3 % [% SET SEARCH_RESULT.num_scores = 87 %] This enabled the display of the ratings, allowing me to confirm that stars display correctly. Ratings should work with and without OpacStarRatings enabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 21:49:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 19:49:38 +0000 Subject: [Koha-bugs] [Bug 10346] "Add multiple copies" should be labelled "Add multiple items" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10346 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:12:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 20:12:24 +0000 Subject: [Koha-bugs] [Bug 6129] ISSN url param for serialssolutions.com In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #18 from Galen Charlton --- (In reply to Jared Camins-Esakov from comment #17) > Actually, never mind. This is because serialssolutions apparently provides > records with URLs that are missing the ISSN, not for adding serialssolutions > URLs to records that don't have that 856 yet. Question for the audience ... is Serials Solutions still distributing records with (apparently) incomplete URLs? If so, I think a better implementation of the fixup nowadays would be as a TT plugin. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:13:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 20:13:05 +0000 Subject: [Koha-bugs] [Bug 7232] clicking title on receive should open in new window/tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7232 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- But isn't that the standard behaviour for all lists? Receive would then be the only one behaving differently. When you click on a title, it opens, but always in the same window. I try to train the libraries to use tabs, not sure how successful :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:16:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 20:16:09 +0000 Subject: [Koha-bugs] [Bug 10525] Can't add/edit notes to order lines on receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10525 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 10536 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:16:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 20:16:09 +0000 Subject: [Koha-bugs] [Bug 10536] Error when editing an order note when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10536 --- Comment #3 from Katrin Fischer --- *** Bug 10525 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:16:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 20:16:26 +0000 Subject: [Koha-bugs] [Bug 10536] Error when editing an order note when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10536 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10301 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:16:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 20:16:26 +0000 Subject: [Koha-bugs] [Bug 10301] notes not showing on receive page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10301 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10536 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:19:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 20:19:35 +0000 Subject: [Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY of message_queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- (In reply to Jared Camins-Esakov from comment #3) > I'm concerned about this patch because there is nothing to prevent two rows > having duplicate message_ids. The existing index is KEY and not UNIQUE. Since the column is AUTO_INCREMENT, I question to what extent this would be a problem in practice unless folks have been in the habit of munging message_id. Regardless, a follow-up to the schema update should be straightforward: check to see if there are duplicates, and if so, renumber the affected rows. I don't think that there is any code that cares about any particular values in that column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:25:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 20:25:52 +0000 Subject: [Koha-bugs] [Bug 7409] Missing dependencies for Debian package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #18 from Galen Charlton --- Does this bug need to remain open? libdbd-mock-perl was added a while back, and I'm not sure that we need a standing bug for adding new package dependencies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:35:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 20:35:39 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #11 from Galen Charlton --- (In reply to Robin Sheat from comment #9) > This is interesting and I like it. Question: is there any evidence that there actually exist patron communities that care enough to have actively requested encryption of outgoing library emails? I understand the reasons for adding this feature, particularly in light of recent political events, but I must confess to some doubt as to whether this would be used by anybody other than other Koha hackers. My question shouldn't be construed as a blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:42:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 20:42:26 +0000 Subject: [Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 --- Comment #13 from Katrin Fischer --- Hi Kyle, I still feel like something is not quite right with the way we handle the library pull down on the form in combination with different search options. Did it work correctly for you? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:46:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 20:46:26 +0000 Subject: [Koha-bugs] [Bug 10536] Error when editing an order note when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10536 --- Comment #4 from Katrin Fischer --- Hi Fridolyn, could you maybe take a look at 10301 too? The note is not shown in the receive page for the order line, but if you add a note there it will overwrite the existing one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:48:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 20:48:09 +0000 Subject: [Koha-bugs] [Bug 10536] Error when editing an order note when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10536 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:48:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 20:48:12 +0000 Subject: [Koha-bugs] [Bug 10536] Error when editing an order note when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10536 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19367|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 19382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19382&action=edit [SIGNED OFF] Bug 10536 - Error when editing an order note when receiving When receiving ordrers "acqui/parcel.pl?invoiceid=1", you can add or modify an order note directly from table. After setting note "acqui/modordernotes.pl", you get an error : Can't use an undefined value as an ARRAY reference at /acqui/parcel.pl line 156. This patch corrects this, there was an error in referrer build into link to acqui/modordernotes.pl. Test plan : - Go to a vendor and click on "Receive shipments" - Click on an invoice - On an order without note, click on "Add note" - Enter a note and click "Save" => You come back to invoice and note is added - On an order with note, click on "Change note" - Enter a note and click "Save" => You come back to invoice and note is added Signed-off-by: Katrin Fischer Works as described, template change only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:50:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 20:50:33 +0000 Subject: [Koha-bugs] [Bug 9902] item subfields not populating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:57:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 20:57:31 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #69 from Katrin Fischer --- I have given this feature some more thought and I worry a bit about the consequences of storing acquisition related information in the MARC record. Libraries might easily overwrite the information in the record using z39.50 or importing and matching records. This would make this feature probably not usable for our libraries, as the records are updated automatically with updated records from the union catalog. Also there might be information you don't want the patron to see, so the fields would have to be excluded from the MARC views and MARC export options. Overall I'd like this to be strictly optional and not tied to important functionality. I think the new patch from Jonathan for 5336 is no longer dependenton this feature? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:57:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 20:57:40 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:58:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 20:58:09 +0000 Subject: [Koha-bugs] [Bug 8292] clicking ignore on hold cancels transfer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 22:58:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 20:58:23 +0000 Subject: [Koha-bugs] [Bug 8661] break out additional authors in opac like in staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 23:11:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 21:11:10 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #12 from Mirko Tietgen --- Hi Galen, thanks for having a look at this bug. I do not know of communities requesting this so far. But - as a library user, I would like to have the option - as a Koha developer, I would like to be able to offer people the option What I would like to look into once I have the time (will take a little while unfortunately) is - possibly change to openpgpjs (http://openpgpjs.org/) - see if outgoing encryption without a library key (as discussed above) is feasible That would make it possible for the individual user to decide if s/he prefers to receive encrypted emails without any interaction with or setup needs of the library (no key generation etc.). -- Just upload your public key to opt in. I do have libraries in mind that I assume would like to offer this feature to their users, but since this is still in an early stage I have not approached them regarding testing yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 23:31:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 21:31:02 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #94 from Liz Rea --- Don't close this bug, it's very useful for testing git BZ please and thank you -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 23:31:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 21:31:28 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 3 23:32:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 21:32:35 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 00:10:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 22:10:43 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #62 from Katrin Fischer --- Started QA on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 01:21:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 23:21:30 +0000 Subject: [Koha-bugs] [Bug 10538] New: Improve importation of .CSV framework files Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 Bug ID: 10538 Summary: Improve importation of .CSV framework files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com CC: gmcharlt at gmail.com Koha often fails when importing CSV framework files, because Koha can currently only import 'perfectly quoted' CSV files this patch uses the amazing Text::CSV module to improve the robustness of the importation process -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 01:31:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 23:31:18 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 --- Comment #7 from Galen Charlton --- (In reply to David Cook from comment #3) > That said, a new table might be overkill, because ISBN might be the only > field in biblioitems that contains multiple values. I'm not 100% sure on > this one, as I just took a quick look glance through some sample data. Well, there are a *lot* of fields that are repeatable and where you might well want to display and search on all repeats for a record. Off the top of my head: - EAN/UPCs, as mentioned by Mathieu - arbitrary record identifiers (e.g., from the MARC21 035 field) - chapter and part titles - languages of the work -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 01:36:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jul 2013 23:36:47 +0000 Subject: [Koha-bugs] [Bug 9927] tweak list-deps script to build a better ./debian/control file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #16 from Galen Charlton --- (In reply to Robin Sheat from comment #15) > I'm still not sold on the need for this, in an "if it ain't broke" kinda way. Indeed. Can you supply examples of specific packages where you believe that a non-optimal version is being installed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 02:25:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 00:25:48 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 --- Comment #8 from David Cook --- (In reply to Galen Charlton from comment #7) > (In reply to David Cook from comment #3) > > That said, a new table might be overkill, because ISBN might be the only > > field in biblioitems that contains multiple values. I'm not 100% sure on > > this one, as I just took a quick look glance through some sample data. > > Well, there are a *lot* of fields that are repeatable and where you might > well want to display and search on all repeats for a record. Off the top of > my head: > > - EAN/UPCs, as mentioned by Mathieu > - arbitrary record identifiers (e.g., from the MARC21 035 field) > - chapter and part titles > - languages of the work Good point, Galen. When I first wrote my comment, I wasn't aware that there were other cases of repeatable MARC fields being put in a single database field with a pipe separator. However, after reading the other comments and taking a more thorough look, I see that more and more. Perhaps a new table, following the model you suggested in 2010, would be the best idea. However, if we were to have a "biblio_attributes" table, might it make sense to drop the biblioitems table and reduce the scope of the biblio table? That is to say, all bibliographic attributes (not only 'isbn' and 'issn' but also 'title', 'author', 'notes', and other attributes from both the biblio and biblioitems tables) would be stored in "biblio_attributes", while the "biblio" table would still exist with system specific attributes/data such as the 'biblionumber', 'frameworkcode', 'timestamp', and 'datecreated' fields. Conceptually, I like that separation of data. In terms of killing MARC, it might be an idea to make yet another table called "biblio_records" where the record is stored in a field (i.e. blob) and a metadata descriptor is recorded in another field. However, it would take a massive re-write to the Koha code to make that a reality, no? Also, by putting all that data in to one table, might we suffer some large performance hits for databases with huge amounts of bib records? -- These are just musings on my part. I haven't designed enough databases to know what the best practice is in terms of performance. I wonder sometimes about how much we gain from using the relational database to store bibliographic data. Currently, are we not storing bibliographic data in 4+ places? The biblio table, the biblioitems table, the MARC blob in the biblioitems table, the MARCXML blob in the biblioitems table, and finally the Zebra database? Both in terms of killing MARC and improving data integrity (and perhaps performance), might it not make sense to reduce the number of places we're storing data? Is the idea of storing data in the relational database to improve the speed of retrieval? Do we actually gain speed? No pattern has emerged to me in terms of deciding when to use the MARC record and when to use the database as the source of data in a given script. I know we have the "mod" scripts which ensure data integrity, but I can't help but think that there must be a better way of storing and retrieving bibliographic data... Sorry for the long comment! I would almost tl;dr it, but I think they're valid questions. "biblio", "biblio_attributes", and "biblio_records"? "biblio", "biblioitems", "biblio_attributes"? "biblio","biblio_records"? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 02:51:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 00:51:42 +0000 Subject: [Koha-bugs] [Bug 9770] C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9770 --- Comment #4 from Galen Charlton --- Created attachment 19383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19383&action=edit Bug 9770: fix sorting of Dewey call numbers that contain prefixes C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally. The subroutine get_class_sort_key tokenizes a call number string (splitting on periods and whitespace) and counts the number of tokens that solely contain digits. If there is only one such digit group, a comment in the code states that it will pad said digit group. However, the bug is that the code assumes said digit group is the first token, when this may not be the case. In practice, this can cause poor sorting when used a call number is in the form of PREFIX _space_ 3DIGITS. To test: [1] Create two item records whose class scheme is set to 'ddc' (Dewey) and whose call numbers contain prefixes, e.g., J DVD 700.1 ABC and J DVD 850 DEF. [2] Use the inventory tool to produce a list of item items that include the two created in step 1. Obsere that that items are sorted in the incorrect order, with "J DVD 850 DEF" coming before "J DVD 700.1 ABC". Alternatively, run the following SQL to see the incorrect sort order: SELECT cn_sort, itemcallnumber FROM items WHERE itemcallnumber LIKE 'J DVD%' ORDER BY cn_sort; [4] Apply this patch. [5] Run misc/maintenance/touch_all_items.pl to force cn_sort to be recalculated. [6] Repeat step 2 and verify that the call numbers are now sorted corrected. Signed-off-by: Jason Etheridge Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 02:52:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 00:52:03 +0000 Subject: [Koha-bugs] [Bug 9770] C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9770 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 02:52:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 00:52:05 +0000 Subject: [Koha-bugs] [Bug 9770] C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9770 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15977|0 |1 is obsolete| | Attachment #19195|0 |1 is obsolete| | Attachment #19383|0 |1 is obsolete| | --- Comment #5 from Galen Charlton --- Created attachment 19384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19384&action=edit Bug 9770: test case for sorting of Dewey call numbers that contain prefixes This adds a test for C4::ClassSortRoutine::Dewey to check that the call number "JR DVD 800.1" sorts before "JR DVD 900" To test: [1] Apply just this patch. [1] Run prove -v t/ClassSortRoutine_Dewey.t [2] Test #7 should fail. Signed-off-by: Jason Etheridge Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 02:52:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 00:52:18 +0000 Subject: [Koha-bugs] [Bug 9770] C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9770 --- Comment #6 from Galen Charlton --- Created attachment 19385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19385&action=edit Bug 9770: fix sorting of Dewey call numbers that contain prefixes C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally. The subroutine get_class_sort_key tokenizes a call number string (splitting on periods and whitespace) and counts the number of tokens that solely contain digits. If there is only one such digit group, a comment in the code states that it will pad said digit group. However, the bug is that the code assumes said digit group is the first token, when this may not be the case. In practice, this can cause poor sorting when used a call number is in the form of PREFIX _space_ 3DIGITS. To test: [1] Create two item records whose class scheme is set to 'ddc' (Dewey) and whose call numbers contain prefixes, e.g., J DVD 700.1 ABC and J DVD 850 DEF. [2] Use the inventory tool to produce a list of item items that include the two created in step 1. Obsere that that items are sorted in the incorrect order, with "J DVD 850 DEF" coming before "J DVD 700.1 ABC". Alternatively, run the following SQL to see the incorrect sort order: SELECT cn_sort, itemcallnumber FROM items WHERE itemcallnumber LIKE 'J DVD%' ORDER BY cn_sort; [4] Apply this patch. [5] Run misc/maintenance/touch_all_items.pl to force cn_sort to be recalculated. [6] Repeat step 2 and verify that the call numbers are now sorted corrected. Signed-off-by: Jason Etheridge Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 02:53:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 00:53:57 +0000 Subject: [Koha-bugs] [Bug 9770] C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9770 --- Comment #7 from Galen Charlton --- I've tested the patches and attached my signoff. I've modified the commit messages to include test plans. Setting this bug to Needs Signoff (Jason, the next step is for a non-ESI person to review the patch). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 03:52:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 01:52:47 +0000 Subject: [Koha-bugs] [Bug 7232] clicking title on receive should open in new window/tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7232 --- Comment #4 from Nicole C. Engard --- We have a pref that asks if links in the opac should open in new tabs/windows maybe something for the staff. And while I specially say this is an issue on receive, you're right, it's an issue all throughout acq when you click a title you loose your basket.' I do have this listed as an enhancement - not a bug, so ideas (other than training people to open in a new tab - cause we all know that's not always an option since we don't train everyone who uses Koha) welcome. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 04:14:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 02:14:47 +0000 Subject: [Koha-bugs] [Bug 9770] C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9770 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 04:14:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 02:14:50 +0000 Subject: [Koha-bugs] [Bug 9770] C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9770 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19384|0 |1 is obsolete| | --- Comment #8 from Chris Cormack --- Created attachment 19386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19386&action=edit Bug 9770: test case for sorting of Dewey call numbers that contain prefixes This adds a test for C4::ClassSortRoutine::Dewey to check that the call number "JR DVD 800.1" sorts before "JR DVD 900" To test: [1] Apply just this patch. [1] Run prove -v t/ClassSortRoutine_Dewey.t [2] Test #7 should fail. Signed-off-by: Jason Etheridge Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 04:15:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 02:15:03 +0000 Subject: [Koha-bugs] [Bug 9770] C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9770 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19385|0 |1 is obsolete| | --- Comment #9 from Chris Cormack --- Created attachment 19387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19387&action=edit Bug 9770: fix sorting of Dewey call numbers that contain prefixes C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally. The subroutine get_class_sort_key tokenizes a call number string (splitting on periods and whitespace) and counts the number of tokens that solely contain digits. If there is only one such digit group, a comment in the code states that it will pad said digit group. However, the bug is that the code assumes said digit group is the first token, when this may not be the case. In practice, this can cause poor sorting when used a call number is in the form of PREFIX _space_ 3DIGITS. To test: [1] Create two item records whose class scheme is set to 'ddc' (Dewey) and whose call numbers contain prefixes, e.g., J DVD 700.1 ABC and J DVD 850 DEF. [2] Use the inventory tool to produce a list of item items that include the two created in step 1. Obsere that that items are sorted in the incorrect order, with "J DVD 850 DEF" coming before "J DVD 700.1 ABC". Alternatively, run the following SQL to see the incorrect sort order: SELECT cn_sort, itemcallnumber FROM items WHERE itemcallnumber LIKE 'J DVD%' ORDER BY cn_sort; [4] Apply this patch. [5] Run misc/maintenance/touch_all_items.pl to force cn_sort to be recalculated. [6] Repeat step 2 and verify that the call numbers are now sorted corrected. Signed-off-by: Jason Etheridge Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 05:15:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 03:15:46 +0000 Subject: [Koha-bugs] [Bug 9902] item subfields not populating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 05:17:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 03:17:52 +0000 Subject: [Koha-bugs] [Bug 9902] item subfields not populating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18454|0 |1 is obsolete| | --- Comment #21 from Liz Rea --- Created attachment 19388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19388&action=edit Bug 9902 - item subfields not populating Test Plan: 1) Create a new serial with a default location, call number, and library ( the library will need to be any but the one you are logged in as ) 2) Click the "Recieve" button for this serial 3) Click "Click to add item" 4) Note those values are not populated 5) Apply the patch 6) Reload the page 7) Click "Click to add item" 8) Note those values are now populated Signed-off-by: Nicole C. Engard All tests pass! Signed-off-by: Chris Cormack This seems to restore the former behaviour. Signed-off-by: Liz Rea signing for 3.10.x - restores former behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 05:41:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 03:41:53 +0000 Subject: [Koha-bugs] [Bug 10517] kohe-restore fails to create mysqluser@mysql_hostname so zebra update fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 --- Comment #3 from John.Seymour at nal.gov.au --- I think that as the koha-remove script drops the user and if you are restoring to a new install the user should not exist, the existence of an existing user is an error that should be flagged. As for the @$mysql_hostname I originaly had is as a static 'localhost' but as the hostname is available for the koha-conf.xml file I thought the use of this value would future proof the script. Feel free to change it back to a static if you think this is more appropriate. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 08:26:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 06:26:01 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #63 from Katrin Fischer --- Comment on attachment 19317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19317 Bug 5336:Order search (search and UI enhancements) Review of attachment 19317: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5336&attachment=19317) ----------------------------------------------------------------- ::: C4/Acquisition.pm @@ +2134,2 @@ > > + $query .= " AND (datecancellationprinted is NULL or datecancellationprinted='0000-00-00') " if $orderstatus ne '4'; Checking for status 4 here... @@ +2697,5 @@ > + my $query = " > + SELECT COUNT( DISTINCT( biblionumber ) ) > + FROM aqorders > + WHERE basketno = ? > + AND (datecancellationprinted IS NULL OR datecancellationprinted='0000-00-00') ... but not checking for status 4 here? ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt @@ +57,5 @@ > + > + > + > + > + Maybe instead of Deleted we should be using Cancelled. For easier and better translation we could also go a bit further and say: New orders/? Open orders/Pending orders Partially received orders Received orders Cancelled orders Only an idea, native speakers should check before implementing any change :) New/ordered could lead to misunderstandings. I think new are not send to the vendor (basket still open) and ordered are supposed to have been sent out. But I am not sure how to reflect that better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 08:33:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 06:33:09 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #64 from Katrin Fischer --- I have gone through the code again and I am going to start testing in the interface soon, Especially partial orders. I wonder if the update condition in the updatedatabase can work, as we split the orders for partial receives. I also have been thinking about the status field, I see some advantages and disadvantages of doing it this way. The arguments I can think of right now are: contra: we have another field to maintan where we have to make sure the value is set correctly at all times depending on actions and changing values in other fields. It also adds a bit more complexity to migrations as the status have to be mapped correctly. pro: It will be easy to do SQL reports on aqorders based on the new status fields because you won't have to join tables and figure out the exact conditions. I am a bit torn here, so leaving this as notes while I continue testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 08:47:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 06:47:24 +0000 Subject: [Koha-bugs] [Bug 10539] New: Remove unused unit tests in lib/KohaTest Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539 Bug ID: 10539 Summary: Remove unused unit tests in lib/KohaTest Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: m.de.rooy at rijksmuseum.nl Reporter: m.de.rooy at rijksmuseum.nl As discussed on the dev list, we can remove the unit tests in lib/KohaTest. Galen suggested: [I have no objection to a patch that removes them, but it would be a niceness to look over the individual tests and see which ones can be easily ported to the current DB-dependent test framework.] Since these unit tests are not used now, they only generate unnecessary maintenance; they are regularly updated for nothing. I propose to remove them rightaway. But with Galen's suggestion in mind, I will walk through them (placed outside the Koha codebase) in the next couple of months to see if we can still retrieve some additional tests and inject them in the active db_dependent unit tests. Anyone else who wants to join that activity is welcome; you can easily retrieve these files from git. Please let me know if you do. I will open a separate report for that purpose. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 08:50:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 06:50:51 +0000 Subject: [Koha-bugs] [Bug 10540] New: Saving interesting code (unit tests) from the deleted KohaTest suite Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10540 Bug ID: 10540 Summary: Saving interesting code (unit tests) from the deleted KohaTest suite Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: m.de.rooy at rijksmuseum.nl Reporter: m.de.rooy at rijksmuseum.nl See bug 10539. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 08:51:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 06:51:03 +0000 Subject: [Koha-bugs] [Bug 10540] Saving interesting code (unit tests) from the deleted KohaTest suite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10540 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 09:26:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 07:26:35 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #70 from Jonathan Druart --- (In reply to Katrin Fischer from comment #69) > I have given this feature some more thought and I worry a bit about the > consequences of storing acquisition related information in the MARC record. > > Libraries might easily overwrite the information in the record using z39.50 > or importing and matching records. This would make this feature probably not > usable for our libraries, as the records are updated automatically with > updated records from the union catalog. > > Also there might be information you don't want the patron to see, so the > fields would have to be excluded from the MARC views and MARC export options. We will certainly drop this feature. > Overall I'd like this to be strictly optional and not tied to important > functionality. I think the new patch from Jonathan for 5336 is no longer > dependenton this feature? No, it is the opposite, this one is dependent on bug 5336. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 09:52:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 07:52:07 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #71 from Katrin Fischer --- If the feature will be dropped, should this be closed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 09:58:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 07:58:42 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #72 from Jonathan Druart --- (In reply to Katrin Fischer from comment #71) > If the feature will be dropped, should this be closed? Not sure... :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 10:21:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 08:21:18 +0000 Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 10:21:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 08:21:22 +0000 Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539 --- Comment #1 from M. de Rooy --- Created attachment 19389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19389&action=edit Bug 10539: Remove unused unit tests in lib/KohaTest This patch removes all files in lib/KohaTest and the associated script t/db_dependent/database_dependent.pl. The second patch deals with a few consequences. Note that bug 10540 has been opened to save some interesting code from these unit tests and inject them in the currently used t/db_dependent suite. Test plan: See second patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 10:21:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 08:21:27 +0000 Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539 --- Comment #2 from M. de Rooy --- Created attachment 19390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19390&action=edit Bug 10539: Followup for removing KohaTest unit tests Adds a line to skip testing Koha::Plugins::Base in t/00-load.t. This needs some attention. Makefile.PL: Adds always-false condition to skip section of creating file t/test-config.txt. This file is no longer used. (Next step should be to remove that code.) Removes t/Makefile and t/rewrite-config-test for the same reason. Modifies XISBN.t to remove two commented lines. Test plan: Grep for KohaTest, database_dependent, config-test, t/Makefile. Run perl Makefile.PL and include running the test suite. This may fail on t/00-valid-xml.t and t/QueryParser.t, but that is not the result of this patch. I had this result: Test Summary Report: t/00-valid-xml.t (Wstat: 1792 Tests: 381 Failed: 7) Failed tests: 10, 30-31, 169, 181, 201-202 Non-zero exit status: 7 t/QueryParser.t (Wstat: 512 Tests: 0 Failed: 0) Non-zero exit status: 2 Parse errors: No plan found in TAP output Files=92, Tests=12385, 45 wallclock secs ( 1.74 usr 0.15 sys + 26.61 cusr 1.92 csys = 30.42 CPU) Result: FAIL Failed 2/92 test programs. 7/12385 subtests failed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 10:21:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 08:21:45 +0000 Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10540 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 10:21:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 08:21:45 +0000 Subject: [Koha-bugs] [Bug 10540] Saving interesting code (unit tests) from the deleted KohaTest suite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10540 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10539 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 10:32:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 08:32:51 +0000 Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539 --- Comment #3 from M. de Rooy --- Note: I can use some feedback on at least following two points: Can we just remove the section that we now skip with if (0 ) in Makefile.PL? Is skipping Koha::Plugins::Base necessary in 00-load.t? Could be just my problem; it seems that Jenkins does not fail here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 10:37:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 08:37:23 +0000 Subject: [Koha-bugs] [Bug 10534] Update of italian SQL files [3.12 only] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10534 Silvia Simonetti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |s.simonetti at cineca.it |ity.org | --- Comment #1 from Silvia Simonetti --- Created attachment 19391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19391&action=edit Update of SQL italian files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 10:39:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 08:39:43 +0000 Subject: [Koha-bugs] [Bug 10534] Update of italian SQL files [3.12 only] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10534 --- Comment #2 from Silvia Simonetti --- to test the patch you need to do the web installation whit previously installed the italian language ( "perl translate install it-IT" in dir misc/translator/ ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 10:42:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 08:42:15 +0000 Subject: [Koha-bugs] [Bug 10534] Update of italian SQL files [3.12 only] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10534 --- Comment #3 from Silvia Simonetti --- Attention, this patch is only for 3.12.x version, so you need to test on this version and not on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 10:53:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 08:53:46 +0000 Subject: [Koha-bugs] [Bug 9519] Wrong language code for Italian in the advanced search language limitations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9519 --- Comment #1 from Sonia Lemaire --- Created attachment 19392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19392&action=edit Bug 9519 Wrong language code for Italian The code for Italian in advanced search limitations should be "ita"and not "ind". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 10:54:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 08:54:50 +0000 Subject: [Koha-bugs] [Bug 9519] Wrong language code for Italian in the advanced search language limitations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9519 Sonia Lemaire changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |sonia.lemaire at biblibre.com Assignee|oleonard at myacpl.org |sonia.lemaire at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 11:16:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 09:16:11 +0000 Subject: [Koha-bugs] [Bug 10535] by default sort funds by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain at biblibre.com --- Comment #2 from Paul Poulain --- Patch tested with a sandbox, by Silvia Simonetti -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 11:16:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 09:16:23 +0000 Subject: [Koha-bugs] [Bug 10535] by default sort funds by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19365|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 12:09:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 10:09:01 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #14 from Mirko Tietgen --- I was thinking to have the JS server-side, like we have jquery in Koha. Would that be a problem? I think it does not break the "OPAC needs to work without JS" rule as it is not a core functionality. We allow local JS in the OPAC too. About using a library key/passphrase, I'm not sure if you would have situations where you need to decrypt messages, add stuff and encrypt them again before sending the email. I vaguely remember that is done, have not looked at the code in a while. You should be able to circumvent that with encryption at the very last moment of course if it does not matter the messages are stored unencrypted in the DB until then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 12:13:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 10:13:17 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #15 from Robin Sheat --- (In reply to Mirko Tietgen from comment #14) > I was thinking to have the JS server-side, like we have jquery in Koha. But jquery runs client side. It doesn't make sense to run this client side, as email generation happens without the interaction of a browser. > Would that be a problem? I think it does not break the "OPAC needs to work > without JS" rule as it is not a core functionality. We allow local JS in the > OPAC too. I just can't see a place where encryption from the OPAC is something that's generally useful. We don't send emails from there. > About using a library key/passphrase, I'm not sure if you would have > situations where you need to decrypt messages, add stuff and encrypt them > again before sending the email. No, once they're added to the message queue, I don't think anything more happens to them. They wouldn't be encrypted while working their way through the running process, they'd presumably get encrypted just before putting them in the queue (but I haven't looked at your code in forever.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 11:57:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 09:57:04 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19394|Bug 9032 [Template |[SIGNED_OFF] Bug 9032 description|follow-up] Share a list |[Template follow-up] Share |(part 1: send the |a list (part 1: send the |invitation) |invitation) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 11:57:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 09:57:22 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19394|[SIGNED_OFF] Bug 9032 |[SIGNED-OFF] Bug 9032 description|[Template follow-up] Share |[Template follow-up] Share |a list (part 1: send the |a list (part 1: send the |invitation) |invitation) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 11:56:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 09:56:20 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18692|0 |1 is obsolete| | --- Comment #21 from M. de Rooy --- Created attachment 19394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19394&action=edit Bug 9032 [Template follow-up] Share a list (part 1: send the invitation) This patch makes a few changes to the "share a list" template: - We don't use tables for layout of forms. This patch corrects the display of the share form to use Koha standard form markup. - Revise the confirmation message displayed after a list is shared to be more readable. - Add a link back to private lists to the confirmation message. - Add T:T markup to make this page display the left-hand navigation which is shown on other patron-related pages when a user is logged in. To test, apply this patch on top of other patches pending for Bug 9032 and confirm that the list share form looks correct and works correctly. Confirm that share confirmation page reads well. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 11:37:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 09:37:33 +0000 Subject: [Koha-bugs] [Bug 7409] Missing dependencies for Debian package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |FIXED --- Comment #19 from Robin Sheat --- Nah, it should be closed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 11:36:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 09:36:01 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 --- Comment #109 from Julian Maurice --- Created attachment 19393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19393&action=edit Bug 7688: Add unit tests for C4::Serials::GetNextSeq() These tests are splitted in two parts: "db dependent" and "db independent". GetNextSeq requires DB only when checking for irregularities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 12:02:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 10:02:06 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #22 from M. de Rooy --- (In reply to Owen Leonard from comment #20) > Note to QA: Because of the order in which the patches were signed off the > first one, "[Template follow-up] Share a list (part 1: send the invitation)" > should be applied last. I have rearranged the order. Thanks Owen for testing. QA: These patches are ready for QA, separate from the followup reports. They can stay in the QA queue, if they pass, until at least part2 comes along (bug 10389). Will submit patches for that soon. Part 3 will handle the orphaned lists and permissions for taking ownership, moderating public/shared list names. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 12:00:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 10:00:45 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 --- Comment #110 from Julian Maurice --- Created attachment 19395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19395&action=edit Bug 7688: Rewrite 'for' loop in unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 12:21:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 10:21:42 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #16 from Mirko Tietgen --- (In reply to Robin Sheat from comment #15) > (In reply to Mirko Tietgen from comment #14) > > I was thinking to have the JS server-side, like we have jquery in Koha. > > But jquery runs client side. It doesn't make sense to run this client side, > as email generation happens without the interaction of a browser. True. I will look into that when i have more time to see if it is possible. I have only used the JS an afternoon so far. > > > Would that be a problem? I think it does not break the "OPAC needs to work > > without JS" rule as it is not a core functionality. We allow local JS in the > > OPAC too. > > I just can't see a place where encryption from the OPAC is something that's > generally useful. We don't send emails from there. Oh you are right of course, the only thing that needs to be done from the OPAC is to offer patrons a field to enter the public key. My bad. > > > About using a library key/passphrase, I'm not sure if you would have > > situations where you need to decrypt messages, add stuff and encrypt them > > again before sending the email. > > No, once they're added to the message queue, I don't think anything more > happens to them. They wouldn't be encrypted while working their way through > the running process, they'd presumably get encrypted just before putting > them in the queue (but I haven't looked at your code in forever.) I think there is an update sometimes when the same action is repeated, to only send one email about it covering all instances of that actions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 11:50:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 09:50:30 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #13 from Robin Sheat --- I don't think you could use a JS library for this unless you ran the JS server-side. You can't send an email to their browser, have it encrypt it, and send it back. As for the passphrase stuff, you definitely can encrypt without a passphrase: $ gpg -a --encrypt --trust-model always -r 4BE030B3 This is a message. -----BEGIN PGP MESSAGE----- Version: GnuPG v1.4.12 (GNU/Linux) hQIOA07aRfuO76ueEAgAnjpAVlVtyfOpEUSest9ESwNDkwANu6DGNBEygkClBmDj ACCU22Yx8IIgV6zPfnT0W4rfndR3oUpel9mBnmGOFLKHPEY+FlZbCXtzHj6jqMGA ... You could have the server having its own passphrase if you wanted to sign things, but I'd consider that a less important thing, at least initially. I think as libraries tend to be fairly privacy-minded, this is something that they probably don't know they want. It's also a good argument against other software, "unlike that one, Koha really cares about user's privacy!" :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 11:49:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 09:49:39 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #37 from M. de Rooy --- QA Comment: Good work! The first patch contains a lot of mixups with repeatable and mandatory flag for the MARC tags. (I see that you resolve them in the third patch.) The second patch contains a subfield 046 $3. It is not in the list of LOC. So I think that it should be removed until we are sure about it. The second (and third?) patch also has some problem with whitespace. I tried several things, but it keeps coming back in the lines around tag 082 - 086. Tag 260: You remove (IMPRINT), I think it should stay. See LOC. I checked all tags with LOC, but focused on mandatory/repeatable for the subfields. Rest looks good to me. Please make final corrections for: a) 046 $3 and 260 [You can probably amend Mason's patch, plz mention in commit] b) whitespace trouble Changing status to reflect need for minor adjustments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 12:55:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 10:55:04 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #38 from Bernardo Gonzalez Kriegel --- (In reply to M. de Rooy from comment #37) > > Rest looks good to me. Please make final corrections for: > > a) 046 $3 and 260 [You can probably amend Mason's patch, plz mention in > commit] > b) whitespace trouble > > Changing status to reflect need for minor adjustments. Thanks for testing!! I'll ammend and fix spaces and tags. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 13:10:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 11:10:04 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #17 from Robin Sheat --- (In reply to Mirko Tietgen from comment #16) > I think there is an update sometimes when the same action is repeated, to > only send one email about it covering all instances of that actions. Ah right, I assume that it doesn't go and read the email back though, because that'd be weird. Really, it'd be best if it put events in to a queue and when the newest was 15 minutes old or more, it batched them into a digest and sent them. That might be what it does, I don't know. A conversation for a different bug, anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 13:21:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 11:21:16 +0000 Subject: [Koha-bugs] [Bug 10034] "kw,rld:" in Z39.50 research In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10034 Silvia Simonetti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |s.simonetti at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 13:43:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 11:43:57 +0000 Subject: [Koha-bugs] [Bug 10529] Dollar sign hardcoded in patron message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10529 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell --- Created attachment 19396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19396&action=edit Proposed Patch My original patch, which has been tested in production used the currency symbol. However looking for a non-SIP usage of the message field to put in testplan, I realized that in the patron screens we consistently omit the currency symbol from money amounts, so this version is consistent with that practice. To test using a sip device issue a patron information request (63) for a patron owing fines. Without this patch the response will include in the screen message 'Patron owes $6.00' with this patch applied it returns 'Patron owes 6.00' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 14:50:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 12:50:49 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 --- Comment #1 from Magnus Enger --- Created attachment 19397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19397&action=edit Bug 10513 - Light up a warning/message when returning a chosen item type This patch adds a new column to item types. Text in this column is displayed as a warning when an item of the given type is checked in. Use case: Items that are on inter-library loan can have a separate item type, and when items of this type are checked in a message saying something like "ILL! Remember to return it to the owning library!" can be displayed. To test: - Apply the patch - Go to Home > Administration > Item types administration - Check that there is a new column, called "Check in message" - Edit an item type and add a check in message - Check that the check in message you added is displayed in the table - Check in an item with an item type that has a check in message - Check that the message is displayed - Check in an item with an item type that does *not* have a check in message, and make sure no false messages are displayed - Run the tests in t/ItemType.t, which are updated by this patch This patch also removes backticks around column names in the itemtypes table in installer/data/mysql/kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 15:00:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 13:00:24 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19397|0 |1 is obsolete| | --- Comment #2 from Magnus Enger --- Created attachment 19398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19398&action=edit Bug 10513 - Light up a warning/message when returning a chosen item type This patch adds a new column to item types. Text in this column is displayed as a warning when an item of the given type is checked in. Use case: Items that are on inter-library loan can have a separate item type, and when items of this type are checked in a message saying something like "ILL! Remember to return it to the owning library!" can be displayed. To test: - Apply the patch - Go to Home > Administration > Item types administration - Check that there is a new column, called "Check in message" - Edit an item type and add a check in message - Check that the check in message you added is displayed in the table - Check in an item with an item type that has a check in message - Check that the message is displayed - Check in an item with an item type that does *not* have a check in message, and make sure no false messages are displayed - Run the tests in t/ItemType.t, which are updated by this patch This patch also removes backticks around column names in the itemtypes table in installer/data/mysql/kohastructure.sql Sponsored-by: Kultur i Halland - Regionbibliotek -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 15:33:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 13:33:22 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 15:37:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 13:37:50 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 15:38:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 13:38:03 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 4 16:03:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jul 2013 14:03:08 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 --- Comment #3 from Viktor Sarge --- Looks great! I do not however (yet) have a dev install to test it on, but I hope someone who does can give it spin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 02:33:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 00:33:06 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |wizzyrea at gmail.com --- Comment #3 from Liz Rea --- Hi Jesse, I couldn't seem to see the regular calendar interface after applying this patch. This is what I saw: http://img542.imageshack.us/img542/6643/4xij.png This is how it usually looks: http://img812.imageshack.us/img812/5074/8n85.png Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 04:11:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 02:11:48 +0000 Subject: [Koha-bugs] [Bug 10541] New: Enable cross-browser AJAX in additem.js Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10541 Bug ID: 10541 Summary: Enable cross-browser AJAX in additem.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au Currently, the additem.js is using "indexOf" to search for a value in an array. While this works in Chrome, Firefox, and IE > 9, it fails miserably in IE 8 and 7 (which don't have the indexOf method). This means that users aren't able to add items using the acquisitions module! Instead of using "indexOf", we should be using the jQuery function $.inArray. It was added in jQuery v1.2 (3.8.0 uses v1.3.2 so even our oldest supported release can use this method). It's perfectly cross-browser compatible...works in Chrome, Firefox, and every version of IE that I've tried (i.e. 7, 8, 9). Patch and test plan to follow... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 04:30:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 02:30:58 +0000 Subject: [Koha-bugs] [Bug 10541] Enable cross-browser AJAX in additem.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10541 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |dcook at prosentient.com.au Assignee|oleonard at myacpl.org |dcook at prosentient.com.au --- Comment #1 from David Cook --- Created attachment 19399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19399&action=edit Bug 10541 - Enable cross-browser AJAX in additem.js Test Plan: Before applying patch: 0) Switch to Internet Explorer 7, or 8, or 9. If you're using IE 9, you'll need to change the Document Mode to IE7 standards or IE8 standards. You can do this by opening Internet Explorer 9, pressing F12 (or clicking on the gear in the top right corner and choosing F12 Developer Tools), and then clicking on "Document Mode" on the top toolbar. There, you can change to IE7 or IE8 standards. N.B. This is not always a perfect emulation in every case, but this time it does show you the bug. 1) Set the system preference AcqCreateItem to "receiving an order" 2) Go to Acquisitions 3) Either: a) Receive a shipment for a basket with items b) Create a new basket, create an order, close the basket, and then do 3a) 4) In the "Item" fieldset, fill out some fields such as barcode, Date acquiried, Public note, etc. 5) Click "Add" at the bottom of the fieldset 6) Note that while the item may have been added, the "Item" fieldset is not being shown again. You may also notice a Javascript error appearing in a pop-up window or you might see a yellow warning flag on the bottom status bar. APPLY THE PATCH 7) Do a full refresh of the page (hold down shift and press the refresh button on the browser next to the address bar), and try adding items again. 8) Note that you receive no warnings and that items are added correctly as they would be in Firefox or Chrome. OPTIONALLY 9) To be sure that I haven't broken anything, go through the same steps in IE9 (with IE9 standards) or Chrome or Firefox. Everything should be working. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 06:14:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 04:14:26 +0000 Subject: [Koha-bugs] [Bug 10538] Improve importation of .CSV framework files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 06:32:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 04:32:12 +0000 Subject: [Koha-bugs] [Bug 10538] Improve importation of .CSV framework files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 --- Comment #1 from Mason James --- Created attachment 19400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19400&action=edit Bug 10538 - Improve importation of .CSV framework files this patch is basically a rewrite of the _import_table_csv() sub, using Text::CSV to test this patch... 1/ dump a framework as a .csv file, to your disk 2/ open that .csv file in LibreOffice (or OpenOffice) and save that file as a new.csv note: LO/OO has just created a 'broken' new.csv file 3/ import new.csv file into Koha, (the import should FAIL) 4/ apply patch and repeat step 3, (the import should SUCCEED) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 06:51:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 04:51:12 +0000 Subject: [Koha-bugs] [Bug 10538] Improve importation of .CSV framework files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 08:54:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 06:54:36 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #18 from Liz Rea --- Yes, the issue and return emails function on a delay - they could not be encrypted until they were leaving the server, as they wouldn't be complete yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 09:52:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 07:52:11 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to selelct multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #5 from Liz Rea --- I actually think the number serves a purpose - rather than the name, which is not unique, the number gives librarians a way to identify a specific report - I often find myself asking "which number report are you running? There are three labeled "Circ stats - TEST"" or somesuch. Showing the number saves a lot of back and forth on that. Librarians often refer to the reports by number as well, just naturally. So please don't remove them. :) Liz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 10:11:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 08:11:18 +0000 Subject: [Koha-bugs] [Bug 10542] New: QueryParser + OpacSuppression doesn't allow search in 'all libraries' Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542 Bug ID: 10542 Summary: QueryParser + OpacSuppression doesn't allow search in 'all libraries' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de CC: jcamins at cpbibliography.com When QueryParser is activated and OpacSuppression is used, you don't find any results for "All libraries" (pull down next to simple search in OPAC). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 10:48:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 08:48:03 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #93 from Paul Poulain --- (In reply to Galen Charlton from comment #92) > As far as the namespace questions are concerned, because of the potential > complexity, in my view an IRC meeting is not well-suited to discussing it; agreed > as I previously stated, bug 8309 and/or koha-devel are more suitable. as there's also a wiki page, it can also be used for discussion: http://wiki.koha-community.org/wiki/Talk:Koha_Namespace_RFC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 11:08:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 09:08:28 +0000 Subject: [Koha-bugs] [Bug 9298] default patron privacy option not in use? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9298 --- Comment #6 from Magnus Enger --- Melia: can this be closed, or is some further action needed? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 13:33:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 11:33:44 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18213|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall --- Created attachment 19401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19401&action=edit Bug 2720 - Overdues which debar automatically should undebar automatically when returned This patch adds a more extensible and flexible debarments system to Koha. The fields borrowers.debarred and borrowers.debarredcomment are retained for compatibility and speed. This system supports having debarments for multiple reasons. There are currently three types of debarments: OVERDUES - Generated by overdue_notices.pl if the notice should debar a patron SUSPENSION - A punative debarment generated on checkin via an issuing rule MANUAL - A debarment created manually by a librarian OVERDUE debarments are cleared automatically when all overdue items have been returned, if the new system preference AutoRemoveOverduesRestrictions is enabled. It is disabled by default to retain current default functionality. Whenever a borrowers debarments are modified, the system updates the borrowers debarment fields with the highest expiration from all the borrowers debarments, and concatenates the comments from the debarments together. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify the borrower_debarments table has been created and populated with the pre-existing debarments 4) Run t/db_dependent/Borrower_Debarments.t 5) Manually debar a patron, with an expiration date 6) Verify the patron cannot be issued to 7) Add another manual debarment with a different expiration date 8) Verify the 'restricted' message lists the date farthest into the future 9) Add another manual debarment with no expiration date 10) Verify the borrower is now debarred indefinitely 11) Delete the indefinite debarment 12) Verify the debarment message lists an expiration date dagain 13) Enable the new system preference AutoRemoveOverduesRestrictions 14) Set an overdue notice to debar after 1 day of being overdue 15) Check out an item to a patron and backdate the due date to yesterday 16) Run overdue_notices.pl 17) Verify the OVERDUES debarment was created 18) Return the item 19) Verify the OVERDUES debarment was removed 20) Disable AutoRemoveOverduesRestrictions 21) Repeat steps 15 though 18, verify the OVERDUES debarment was *not* removed 22) Add issuing rules so that an overdue item causes a temporary debarment 23) Check out an item to a patron and backdate the due date by a year 24) Return the item 25) Verify the SUSPENSION debarment was added to the patron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 13:40:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 11:40:47 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 --- Comment #24 from Kyle M Hall --- (In reply to Owen Leonard from comment #15) > - There is a typo in updatedatabase, a reversed end parenthesis. Fixed! > - There is at least once instance of "debar" being used instead of > "restrict" Fixed! > - I think the "X" icon isn't appropriate here. It would be simpler and more > clear to use text ("Remove"). Fixed! > - The table of restrictions doesn't look correct if there are no > restrictions--probably because there is nothing in ? Anyway > I think it would be more consistent to separate the entry from from > the table. Wrapping
around is invalid. > - onclick="return confirm(_('Remove debarment?'))" at line 24 of > borrower_debarments.inc is not translatable. The action should be moved > to a function. Fixed! > - borrower_debarments.inc has a couple of unescaped ampersands in line 24. Fixed! > I don't think the "Restrictions" tab should be present on circulation.pl at > all times. Being able to add a restriction to an account is certainly not > something which happens so frequently that it needs to be only one click > away. That is correct, it's there for removing restrictions primarily. However, I see no strong reason *not* to allow the ability to restrict a patron from here. > It's useful to be able to see information about all restrictions, but the > full information could just as easily be displayed in the main block of > "Cannot check out!" messages at the top. There's no reason to conserve space > there if the patron is restricted anyway. If we mimicked the current method > for displaying restrictions we could simply make it possible to display more > than one line of restrictions, each with the same "lift restriction" button > or link. As you write, it's useful, and this area appears to be more a matter of aesthetic preference. If you really dislike it, please submit a followup! > If we did this then we could move the form for adding a manual restriction > either back into the patron edit form (where people still expect to find it) > or onto its own page (not as good an option IMO). This latest edition of the patch adds the restrictions back to the patron editor to address this. > One idea for an improvement: Perhaps the overdue notices job could set a > restricted comment with the datetime of the job? "Restriction added by > overdues process 2013-03-05 00:20:00" Done! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 14:08:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 12:08:25 +0000 Subject: [Koha-bugs] [Bug 10536] Error when editing an order note when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10536 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |DUPLICATE --- Comment #6 from Jonathan Druart --- This issue is fixed by bug 10317 (already passed QA). *** This bug has been marked as a duplicate of bug 10317 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 14:08:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 12:08:25 +0000 Subject: [Koha-bugs] [Bug 10317] Parcel should display a message when called with an nonexistent invoiceid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10317 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #5 from Jonathan Druart --- *** Bug 10536 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 14:33:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 12:33:05 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #14 from Kyle M Hall --- This does not appear to be working correctly. The field merging seems to be the problem. Video: http://screencast.com/t/9T9SMPut7wjT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 14:35:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 12:35:32 +0000 Subject: [Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 14:39:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 12:39:56 +0000 Subject: [Koha-bugs] [Bug 10535] by default sort funds by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #3 from Fridolyn SOMERS --- Created attachment 19402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19402&action=edit [SIGNED-OFF] Bug 10535 - by default sort funds by name Something went wrong with sandbox, I created signed patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 14:42:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 12:42:51 +0000 Subject: [Koha-bugs] [Bug 10384] Software error when LDAP connexion fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10384 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 14:42:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 12:42:53 +0000 Subject: [Koha-bugs] [Bug 10384] Software error when LDAP connexion fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10384 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19197|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 19403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19403&action=edit Bug 10384 - Software error when LDAP connexion fails When using LDAP authentication, the authentication falls back to normal authentication if user does not exist in LDAP. Actually, if the LDAP server is down, you get a software error (even with mysql user) : Can't call method "bind" on an undefined value at C4/Auth_with_ldap.pm line 134, line 558. This patch catches this error to allow normal authentication when LDAP connexion fails. Test plan : - Configure LDAP connexion with a host not having LDAP. ie : 1 localhost dc=test,dc=com cn=Manager,dc=test,dc=com passwd 0 0 0 MAIN PT - Try to connect with mysql user (defined in koha-conf.xml) - Try to connect with a user defined in borrowers You may try to connect with working LDAP connexion Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 14:45:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 12:45:15 +0000 Subject: [Koha-bugs] [Bug 10474] Translate some missed English strings in German sample notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10474 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19202|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 19404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19404&action=edit Bug 10474: Translate some English strings in German sample notices This translates 2 strings missed doing the initial translation in ISSUESLIP. To test: - Run the web installer in German. Altnernatively: - Truncate your letters table and run the SQL against the database. Check that the notices were added correctly, especially ISSUESLIP. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 14:45:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 12:45:12 +0000 Subject: [Koha-bugs] [Bug 10474] Translate some missed English strings in German sample notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10474 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 14:50:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 12:50:42 +0000 Subject: [Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18976|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 19405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19405&action=edit Bug 10274: UT: Acquisition.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition.t And after, it should produce: t/db_dependent/Acquisition.t .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.03 usr 0.00 sys + 0.42 cusr 0.02 csys = 0.47 CPU) Result: PASS Signed-off-by: Jared Camins-Esakov Tests pass and the bookseller is deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 14:50:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 12:50:46 +0000 Subject: [Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 --- Comment #10 from Jonathan Druart --- Created attachment 19406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19406&action=edit Bug 10274: Execute sql queries into a transaction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 14:50:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 12:50:54 +0000 Subject: [Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 15:04:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 13:04:09 +0000 Subject: [Koha-bugs] [Bug 9113] batch modification removes + In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9113 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 15:04:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 13:04:12 +0000 Subject: [Koha-bugs] [Bug 9113] batch modification removes + In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9113 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19288|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 19407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19407&action=edit Bug 9113 - batch modification removes + If you're using the batch modification tool and entering a call number like "E+ 123 ABC", the tool removes the + and puts a space in it's place "E 123 ABC" This is because form is posted via Ajax by background-job-progressbar.js. Values are URI-encoded using escape() javascript but this method does not escape some caracters : * @ - _ + . / And a + is considered as a space in a URI. This patch replaces escape() by encodeURIComponent() which encodes every character. Test plan : Perform an items batch modification by setting '* @ - _ + . /' in a field (notes for example) and see that all caracters are well saved. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 15:06:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 13:06:57 +0000 Subject: [Koha-bugs] [Bug 5894] Adding multiple items from a cart to a list shows only the first title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5894 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 15:07:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 13:07:00 +0000 Subject: [Koha-bugs] [Bug 5894] Adding multiple items from a cart to a list shows only the first title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5894 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19289|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 19408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19408&action=edit Bug 5894 - Adding multiple items from a cart to a list shows only the first title Adds missing code that splits biblios before calling template. To test: Add some items to cart Open cart, select some or all items Add to list With patch, following window shold show something like "Add 3 items to a list:", followed by list of items Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 15:17:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 13:17:05 +0000 Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #2 from Liz Rea --- Hi Owen, As we talked about on IRC - The cart button would work better if it were either more like the list button, or a modal window. The current implementation is wacky on mobile. The margin is a little wide for mobile, it's wibbly-wobbly when you are scrolling (the example was: rub back and forth with your finger, instead of up and down) the order in the search form differs between the start screen and the login screen. on start i have the search field on top, on the login screen i have the catalog dropdown on top. also the login form is visible on the start page already so technically it would make sense to use an anchor instead of loading a new page to log in but that would probably destroy the functionality in regular view? -- drojf MJ declares that the colors could use more contrast. Accessibility is important. ...and that's all I noted for now :) Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 15:19:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 13:19:24 +0000 Subject: [Koha-bugs] [Bug 10543] New: false mandatory warning in additem Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 Bug ID: 10543 Summary: false mandatory warning in additem Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com CC: m.de.rooy at rijksmuseum.nl When editing a item, we get a popup warning : "1 mandatory fields empty (highlighted)". But all mandatory fields are filled. This is because there is a field with a huge content (more than 100 characters), it it displayed in a textarea instead of input. This braked javascript form check. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 15:20:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 13:20:32 +0000 Subject: [Koha-bugs] [Bug 10431] Spanish Zebra language definition file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19222|0 |1 is obsolete| | CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- Created attachment 19409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19409&action=edit Bug 10431 - Spanish Zebra character sorting file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 15:21:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 13:21:03 +0000 Subject: [Koha-bugs] [Bug 10431] Spanish Zebra language definition file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19223|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 19410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19410&action=edit Bug 10431 - Redundant mappings removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 15:21:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 13:21:12 +0000 Subject: [Koha-bugs] [Bug 10431] Spanish Zebra language definition file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 15:36:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 13:36:58 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 --- Comment #15 from Julian Maurice --- Created attachment 19411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19411&action=edit Screenshot of merge form Hi Kyle, I think you did not apply the patch correctly. On the merge page you can normally see "(ref)" in one tab and a text box at the bottom of the page (see attached screenshot). Could you confirm, please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 15:50:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 13:50:16 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 15:58:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 13:58:42 +0000 Subject: [Koha-bugs] [Bug 10431] Spanish Zebra language definition file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Galen Charlton --- Pushed to master. Thanks, Tom?s! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 16:00:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 14:00:50 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 19412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19412&action=edit Proposed patch See commit message. Very tricky bug :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 16:00:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 14:00:59 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 16:01:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 14:01:49 +0000 Subject: [Koha-bugs] [Bug 10474] Translate some missed English strings in German sample notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10474 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 16:03:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 14:03:24 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 --- Comment #16 from Julian Maurice --- Created attachment 19413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19413&action=edit Bug 8064: Merge several biblios This patch improves the existing merging tool by adding possibility to merge more than 2 biblios. There is no functional changes: - Add some biblios to a list - In the list check some biblios and click on 'Merge selected records' - Choose the biblio which will be kept, all others will be deleted - On the next page you have all biblios you chose in tabs (left side of the screen) and the preview of result (right side) - Pick some fields or subfields from records that will be deleted or delete some fields from reference record. - Click on 'Merge', if there is no errors you are redirected to the biblio view. Added checks for non-repeatable subfields Added checks for mandatory fields and subfields before submitting the form. Added a final report which display deleted records (see syspref MergeReportFields) This patch is built on top of Bug 9755 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 16:04:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 14:04:13 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #17 from Julian Maurice --- Patch rebased on Bug 9755 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 16:05:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 14:05:33 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19401|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall --- Created attachment 19414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19414&action=edit Bug 2720 - Overdues which debar automatically should undebar automatically when returned This patch adds a more extensible and flexible debarments system to Koha. The fields borrowers.debarred and borrowers.debarredcomment are retained for compatibility and speed. This system supports having debarments for multiple reasons. There are currently three types of debarments: OVERDUES - Generated by overdue_notices.pl if the notice should debar a patron SUSPENSION - A punative debarment generated on checkin via an issuing rule MANUAL - A debarment created manually by a librarian OVERDUE debarments are cleared automatically when all overdue items have been returned, if the new system preference AutoRemoveOverduesRestrictions is enabled. It is disabled by default to retain current default functionality. Whenever a borrowers debarments are modified, the system updates the borrowers debarment fields with the highest expiration from all the borrowers debarments, and concatenates the comments from the debarments together. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify the borrower_debarments table has been created and populated with the pre-existing debarments 4) Run t/db_dependent/Borrower_Debarments.t 5) Manually debar a patron, with an expiration date 6) Verify the patron cannot be issued to 7) Add another manual debarment with a different expiration date 8) Verify the 'restricted' message lists the date farthest into the future 9) Add another manual debarment with no expiration date 10) Verify the borrower is now debarred indefinitely 11) Delete the indefinite debarment 12) Verify the debarment message lists an expiration date dagain 13) Enable the new system preference AutoRemoveOverduesRestrictions 14) Set an overdue notice to debar after 1 day of being overdue 15) Check out an item to a patron and backdate the due date to yesterday 16) Run overdue_notices.pl 17) Verify the OVERDUES debarment was created 18) Return the item 19) Verify the OVERDUES debarment was removed 20) Disable AutoRemoveOverduesRestrictions 21) Repeat steps 15 though 18, verify the OVERDUES debarment was *not* removed 22) Add issuing rules so that an overdue item causes a temporary debarment 23) Check out an item to a patron and backdate the due date by a year 24) Return the item 25) Verify the SUSPENSION debarment was added to the patron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 16:07:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 14:07:33 +0000 Subject: [Koha-bugs] [Bug 5894] Adding multiple items from a cart to a list shows only the first title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5894 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Marc! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 16:17:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 14:17:58 +0000 Subject: [Koha-bugs] [Bug 9412] add optional_params to C4::Service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9412 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Kyle M Hall --- Failed QA for the following reasons: 1) No test plan 2) Adds a subroutine that is not used Can you please justify the addition of this new subroutine when it isn't used by any new code? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 16:33:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 14:33:58 +0000 Subject: [Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17600|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 19415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19415&action=edit Bug 8587 - Add a serial lifespan field to serial subscriptions http://bugs.koha-community.org/show_bug.cgi?id=8587 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 16:34:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 14:34:43 +0000 Subject: [Koha-bugs] [Bug 10544] New: stocknumber index is an alias of Number-local-acquisition Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 Bug ID: 10544 Summary: stocknumber index is an alias of Number-local-acquisition Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com Bug 6256 replaced in bib1.att stocknumber by Number-local-acquisition for number 1062. In this case, Number-local-acquisition must be used in record.abs and stocknumber can be an alias of it in ccl.properties. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 16:35:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 14:35:02 +0000 Subject: [Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 16:36:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 14:36:36 +0000 Subject: [Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 16:36:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 14:36:39 +0000 Subject: [Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 --- Comment #15 from Kyle M Hall --- Created attachment 19416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19416&action=edit Bug 8587 - Add a serial lifespan to serial subscriptions - Followup - Change seriallifespan to serial_lifespan for readability -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 16:40:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 14:40:54 +0000 Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 19417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19417&action=edit Proposed patch See commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 16:41:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 14:41:03 +0000 Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 17:10:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 15:10:54 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #2 from Kyle M Hall --- Could you please provide a test plan for this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 17:19:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 15:19:59 +0000 Subject: [Koha-bugs] [Bug 10538] Improve importation of .CSV framework files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #2 from Kyle M Hall --- My saved LibreOffice csv failed to import both pre and post patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 17:43:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 15:43:18 +0000 Subject: [Koha-bugs] [Bug 9113] batch modification removes + In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9113 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 17:57:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 15:57:39 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #22 from Galen Charlton --- Pushed to master. Thanks, Kyle! I do, however, agree with Katrin that the ability to control which default values are presented really belongs on the item field form, not the upload form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 18:16:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 16:16:02 +0000 Subject: [Koha-bugs] [Bug 10384] Software error when LDAP connexion fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10384 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 18:32:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 16:32:36 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19414|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall --- Created attachment 19418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19418&action=edit Bug 2720 - Overdues which debar automatically should undebar automatically when returned This patch adds a more extensible and flexible debarments system to Koha. The fields borrowers.debarred and borrowers.debarredcomment are retained for compatibility and speed. This system supports having debarments for multiple reasons. There are currently three types of debarments: OVERDUES - Generated by overdue_notices.pl if the notice should debar a patron SUSPENSION - A punative debarment generated on checkin via an issuing rule MANUAL - A debarment created manually by a librarian OVERDUE debarments are cleared automatically when all overdue items have been returned, if the new system preference AutoRemoveOverduesRestrictions is enabled. It is disabled by default to retain current default functionality. Whenever a borrowers debarments are modified, the system updates the borrowers debarment fields with the highest expiration from all the borrowers debarments, and concatenates the comments from the debarments together. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify the borrower_debarments table has been created and populated with the pre-existing debarments 4) Run t/db_dependent/Borrower_Debarments.t 5) Manually debar a patron, with an expiration date 6) Verify the patron cannot be issued to 7) Add another manual debarment with a different expiration date 8) Verify the 'restricted' message lists the date farthest into the future 9) Add another manual debarment with no expiration date 10) Verify the borrower is now debarred indefinitely 11) Delete the indefinite debarment 12) Verify the debarment message lists an expiration date dagain 13) Enable the new system preference AutoRemoveOverduesRestrictions 14) Set an overdue notice to debar after 1 day of being overdue 15) Check out an item to a patron and backdate the due date to yesterday 16) Run overdue_notices.pl 17) Verify the OVERDUES debarment was created 18) Return the item 19) Verify the OVERDUES debarment was removed 20) Disable AutoRemoveOverduesRestrictions 21) Repeat steps 15 though 18, verify the OVERDUES debarment was *not* removed 22) Add issuing rules so that an overdue item causes a temporary debarment 23) Check out an item to a patron and backdate the due date by a year 24) Return the item 25) Verify the SUSPENSION debarment was added to the patron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 18:44:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 16:44:59 +0000 Subject: [Koha-bugs] [Bug 10317] Parcel should display a message when called with an nonexistent invoiceid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10317 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 18:59:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 16:59:16 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 18:59:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 16:59:19 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19418|0 |1 is obsolete| | --- Comment #27 from Owen Leonard --- Created attachment 19419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19419&action=edit [SIGNED-OFF] Bug 2720 - Overdues which debar automatically should undebar automatically when returned This patch adds a more extensible and flexible debarments system to Koha. The fields borrowers.debarred and borrowers.debarredcomment are retained for compatibility and speed. This system supports having debarments for multiple reasons. There are currently three types of debarments: OVERDUES - Generated by overdue_notices.pl if the notice should debar a patron SUSPENSION - A punative debarment generated on checkin via an issuing rule MANUAL - A debarment created manually by a librarian OVERDUE debarments are cleared automatically when all overdue items have been returned, if the new system preference AutoRemoveOverduesRestrictions is enabled. It is disabled by default to retain current default functionality. Whenever a borrowers debarments are modified, the system updates the borrowers debarment fields with the highest expiration from all the borrowers debarments, and concatenates the comments from the debarments together. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify the borrower_debarments table has been created and populated with the pre-existing debarments 4) Run t/db_dependent/Borrower_Debarments.t 5) Manually debar a patron, with an expiration date 6) Verify the patron cannot be issued to 7) Add another manual debarment with a different expiration date 8) Verify the 'restricted' message lists the date farthest into the future 9) Add another manual debarment with no expiration date 10) Verify the borrower is now debarred indefinitely 11) Delete the indefinite debarment 12) Verify the debarment message lists an expiration date dagain 13) Enable the new system preference AutoRemoveOverduesRestrictions 14) Set an overdue notice to debar after 1 day of being overdue 15) Check out an item to a patron and backdate the due date to yesterday 16) Run overdue_notices.pl 17) Verify the OVERDUES debarment was created 18) Return the item 19) Verify the OVERDUES debarment was removed 20) Disable AutoRemoveOverduesRestrictions 21) Repeat steps 15 though 18, verify the OVERDUES debarment was *not* removed 22) Add issuing rules so that an overdue item causes a temporary debarment 23) Check out an item to a patron and backdate the due date by a year 24) Return the item 25) Verify the SUSPENSION debarment was added to the patron Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 19:03:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 17:03:27 +0000 Subject: [Koha-bugs] [Bug 10390] Add ability to delete unused invoices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10390 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Jared! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 19:03:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 17:03:52 +0000 Subject: [Koha-bugs] [Bug 10390] Add ability to delete unused invoices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10390 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 19:12:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 17:12:01 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 --- Comment #28 from Owen Leonard --- Created attachment 19420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19420&action=edit Bug 2720 [FOLLOW-UP] Overdues which debar automatically should undebar automatically This follow-up to Bug 2720 makes some template changes which I think make the interface a little more consistent and streamlined. Instead of incorporating the manual entry form into the table it is broken out and follows standard form structure. This lets the table be hidden altogether if there are no existing restrictions. The manual entry form is hidden by default and shown when you click a link to add a manual restriction. These changes have been applied to both the include file used for circulation and patron detail and to the patron entry form template. To test, add and remove manual restrictions from the circulation page, the patron detail page, and the patron edit page. All operations should work correctly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 19:50:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 17:50:47 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19420|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall --- Created attachment 19421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19421&action=edit Bug 2720 [FOLLOW-UP] Overdues which debar automatically should undebar automatically This follow-up to Bug 2720 makes some template changes which I think make the interface a little more consistent and streamlined. Instead of incorporating the manual entry form into the table it is broken out and follows standard form structure. This lets the table be hidden altogether if there are no existing restrictions. The manual entry form is hidden by default and shown when you click a link to add a manual restriction. These changes have been applied to both the include file used for circulation and patron detail and to the patron entry form template. To test, add and remove manual restrictions from the circulation page, the patron detail page, and the patron edit page. All operations should work correctly. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 23:02:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 21:02:50 +0000 Subject: [Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9412 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 23:02:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 21:02:50 +0000 Subject: [Koha-bugs] [Bug 9412] add optional_params to C4::Service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9412 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4439 Depends on| |4437 --- Comment #5 from Hugh Davenport --- Hi Kyle, Sorry, when I git bz'd the patch up here, it didn't take into account dependencies which I guess I kinda assumed it would. This bug is actually building blocks for bug 4439 which then use this method. I've updated this bug to show this dependency. Cheers, Hugh -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 23:02:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 21:02:50 +0000 Subject: [Koha-bugs] [Bug 4439] two acq webservices should use C4::Service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4439 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9412 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 23:12:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 21:12:14 +0000 Subject: [Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 --- Comment #7 from Hugh Davenport --- Hey Owen, What would the format of a test plan be? Cheers, Hugh -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 23:13:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 21:13:00 +0000 Subject: [Koha-bugs] [Bug 4439] two acq webservices should use C4::Service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4439 --- Comment #3 from Hugh Davenport --- Hey Owen, What would the format of a test plan be? Cheers, Hugh -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 23:13:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 21:13:30 +0000 Subject: [Koha-bugs] [Bug 9411] Multiple uses of javascript eval on ajax responses in acq.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9411 --- Comment #10 from Hugh Davenport --- Hey Kyle/Owen, What would the format of a test plan be? Cheers, Hugh -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 23:17:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 21:17:58 +0000 Subject: [Koha-bugs] [Bug 9410] Formatting of the discount field when doing a new order from new empty record is not correct In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 --- Comment #5 from Hugh Davenport --- Hi Jonathan, I would agree, prehaps we should make another bug for changing the patch made in bug 9062 to use 2dp as well, and push this one through as is, as long as everyone is happy with that. Cheers, Hugh -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 23:53:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 21:53:36 +0000 Subject: [Koha-bugs] [Bug 10545] New: additional test for git bz Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10545 Bug ID: 10545 Summary: additional test for git bz Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: hugh at davenport.net.nz working on dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 5 23:54:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 21:54:20 +0000 Subject: [Koha-bugs] [Bug 10546] New: additional test for git bz Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10546 Bug ID: 10546 Summary: additional test for git bz Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: hugh at davenport.net.nz working on depends -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 01:03:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 23:03:28 +0000 Subject: [Koha-bugs] [Bug 10545] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10545 --- Comment #1 from Hugh Davenport --- Created attachment 19422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19422&action=edit bug 10545 add blah Depends: bug 10546 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 01:04:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 23:04:22 +0000 Subject: [Koha-bugs] [Bug 10546] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10546 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10545 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 01:04:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 23:04:22 +0000 Subject: [Koha-bugs] [Bug 10545] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10545 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10546 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 01:08:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 23:08:35 +0000 Subject: [Koha-bugs] [Bug 10545] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10545 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19422|0 |1 is obsolete| | --- Comment #2 from Hugh Davenport --- Created attachment 19423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19423&action=edit bug 10545 add blah -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 01:11:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 23:11:15 +0000 Subject: [Koha-bugs] [Bug 10547] New: additional test for git bz Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10547 Bug ID: 10547 Summary: additional test for git bz Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: hugh at davenport.net.nz another one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 01:12:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 23:12:10 +0000 Subject: [Koha-bugs] [Bug 10546] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10546 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10547 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 01:12:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 23:12:10 +0000 Subject: [Koha-bugs] [Bug 10547] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10547 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10546 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 01:12:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 23:12:12 +0000 Subject: [Koha-bugs] [Bug 10546] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10546 --- Comment #1 from Hugh Davenport --- Created attachment 19424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19424&action=edit bug 10546 add blah -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 01:12:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 23:12:51 +0000 Subject: [Koha-bugs] [Bug 10545] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10545 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19423|0 |1 is obsolete| | --- Comment #3 from Hugh Davenport --- Created attachment 19425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19425&action=edit bug 10545 add blah -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 01:13:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 23:13:30 +0000 Subject: [Koha-bugs] [Bug 10545] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10545 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10547 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 01:13:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 23:13:30 +0000 Subject: [Koha-bugs] [Bug 10547] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10547 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10545 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 01:17:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 23:17:35 +0000 Subject: [Koha-bugs] [Bug 10545] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10545 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10547 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 01:17:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 23:17:35 +0000 Subject: [Koha-bugs] [Bug 10547] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10547 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10545 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 01:17:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 23:17:38 +0000 Subject: [Koha-bugs] [Bug 10545] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10545 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19425|0 |1 is obsolete| | --- Comment #4 from Hugh Davenport --- Created attachment 19426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19426&action=edit bug 10545 add blah -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 01:17:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 23:17:53 +0000 Subject: [Koha-bugs] [Bug 10545] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10545 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19426|0 |1 is obsolete| | --- Comment #5 from Hugh Davenport --- Created attachment 19427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19427&action=edit bug 10545 add blah -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 01:18:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 23:18:45 +0000 Subject: [Koha-bugs] [Bug 10547] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10547 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10545 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 01:18:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 23:18:45 +0000 Subject: [Koha-bugs] [Bug 10545] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10545 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10547 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 01:18:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 23:18:47 +0000 Subject: [Koha-bugs] [Bug 10545] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10545 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19427|0 |1 is obsolete| | --- Comment #6 from Hugh Davenport --- Created attachment 19428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19428&action=edit bug 10545 add blah -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 01:19:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 23:19:18 +0000 Subject: [Koha-bugs] [Bug 10545] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10545 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19428|0 |1 is obsolete| | --- Comment #7 from Hugh Davenport --- Created attachment 19429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19429&action=edit bug 10545 add blah -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 01:25:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 23:25:39 +0000 Subject: [Koha-bugs] [Bug 10545] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10545 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19429|0 |1 is obsolete| | --- Comment #8 from Hugh Davenport --- Created attachment 19430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19430&action=edit bug 10545 add blah -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 01:26:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jul 2013 23:26:06 +0000 Subject: [Koha-bugs] [Bug 10547] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10547 --- Comment #1 from Hugh Davenport --- Created attachment 19431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19431&action=edit bug 10545 add blah Depends: bug 10546 Depends: bug 10547 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 02:34:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 00:34:13 +0000 Subject: [Koha-bugs] [Bug 10545] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10545 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19430|0 |1 is obsolete| | --- Comment #9 from Hugh Davenport --- Created attachment 19432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19432&action=edit bug 10545 add blah -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 02:38:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 00:38:11 +0000 Subject: [Koha-bugs] [Bug 10547] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10547 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED Blocks|10545, 10546 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 02:38:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 00:38:11 +0000 Subject: [Koha-bugs] [Bug 10545] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10545 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10547 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 02:38:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 00:38:11 +0000 Subject: [Koha-bugs] [Bug 10546] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10546 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10547 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 02:38:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 00:38:28 +0000 Subject: [Koha-bugs] [Bug 10545] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10545 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED Depends on| |10547 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 02:38:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 00:38:28 +0000 Subject: [Koha-bugs] [Bug 10547] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10547 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10545 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 02:38:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 00:38:43 +0000 Subject: [Koha-bugs] [Bug 10546] additional test for git bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10546 Hugh Davenport changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 08:27:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 06:27:23 +0000 Subject: [Koha-bugs] [Bug 10534] Update of italian SQL files [3.12 only] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10534 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com Component|I18N/L10N |Installation and upgrade | |(web-based installer) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 10:29:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 08:29:44 +0000 Subject: [Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 10:29:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 08:29:48 +0000 Subject: [Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19351|0 |1 is obsolete| | --- Comment #21 from Chris Cormack --- Created attachment 19433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19433&action=edit Bug 2774 - Path to theme is hard-coded in many places This patch corrects more places in Koha where the path to the "prog" theme is hard-coded in templates, CSS, and scripts. Staff client home page: Paths to the Koha logo background image and the module image sprite have been corrected. Inactive and hover states of the module links (circulation, patrons, etc) should look correct. addbiblio.pl: An tag is replaced with a text link and an additional CSS class. CSS uses an image-replacement technique to display the image as before. To test, open a blank or existing bibliographic record for editing. Confirm that the "tag editor" icon displays correctly in two cases: 1) tags linked to plugin editors and 2) tags linked to authorities. Both should look correct and work correctly. System preferences: The system preferences editor appends a "loading" image to system preference submit buttons when they are clicked. This patch changes ajax.js to insert a styled with a background-image instead. To test, open system preferences and modify any preference. Submit the change and confirm that the "loading" image appears correctly. Background jobs: Any place in Koha where a background job is used displays a progress bar. This patch corrects the path in CSS to the progress bar image. To test, perform an action which triggers the display of a progress bar. For instance, batch modification of items. Confirm that the progress bar image displays correctly. blue.css: I don't know if this is still used by anyone, but a couple of image paths in this CSS file have been corrected. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 10:36:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 08:36:53 +0000 Subject: [Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 10:36:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 08:36:57 +0000 Subject: [Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16034|0 |1 is obsolete| | Attachment #16035|0 |1 is obsolete| | Attachment #18670|0 |1 is obsolete| | --- Comment #49 from Chris Cormack --- Created attachment 19434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19434&action=edit Bug 6898 - updatedatabase second query not executed Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 10:46:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 08:46:36 +0000 Subject: [Koha-bugs] [Bug 10272] CheckReserves returns not respecting ReservesControlBranch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 10:46:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 08:46:39 +0000 Subject: [Koha-bugs] [Bug 10272] CheckReserves returns not respecting ReservesControlBranch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19081|0 |1 is obsolete| | --- Comment #16 from Chris Cormack --- Created attachment 19435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19435&action=edit Bug 10272 - CheckReserves returns not respecting ReservesControlBranch CheckReserves is using the CircControl system preference to determine what patrons an item can fill a hold for. It should be using ReservesControlBranch instead. Test Plan: 1) Set ReservesControlBranch to "item's home library". 2) Create an item at Library A, place holds for it for patrons at Library B, Library C, and Library A in that order, for pickup at the patrons home library. 3) Make sure the holds policy for Library A is set to Hold Policy = "From home library" and Return Policy = "Item returns home". Make sure the holds policies for the other libraries are set to Hold Policy = "From any library". 4) Check the item in at Library C, the hold for the patron at Library B should pop up, even though it's in violation of the circulation rules. Don't click the confirm button! 5) Apply this patch, and reload the page, now the hold listed should be for the last hold, the hold for the patron at Library A, which is correct. This patch adds the subroutine C4::Reserves::GetReservesControlBranch as an equivilent to C4::Circulation::_GetCircControlBranch. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 10:55:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 08:55:52 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18532|0 |1 is obsolete| | --- Comment #8 from Chris Cormack --- Created attachment 19436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19436&action=edit Bug 5202: merge authorities from the authority file and reservoir This patch gives Koha the ability to merge authority records using the same interface used by bibliographic records, though slightly different methods for selecting which records to merge. The two ways to select records are as follows: 1) Records can be selected from authority search results by clicking the "Merge" link for two records. 2) Authority records can be merged from the reservoir by clicking the merge-related links in the Manage staged MARC batch screen. To test: 1) Apply patch. 2) Do a search for an authority record that will turn up multiple identical records (or at least two records that you don't mind merging). 3) Click the "Merge" link for the first record. 4) Click the "Merge" link for the second record. 5) Choose which fields from which record you want to appear in the resulting record. 6) Confirm that those are the fields that exist in the resulting record. 7) Stage an authority record (for example, an authority record you saved from your catalog. 8) Search for a record to merge with it using the "Search for a record to merge in a new window" link. 9) Merge these records, confirming that the resulting record (after going through the entire merging process) matches your expectations. 10) Set up a matching rule for authorities, and export an authority from your catalog that will match based on that rule. For MARC21, the following is a good choice for a rule: Matching rule code: AUTHPER Description: Personal name main entry Match threshold: 999 Record type: Authority record [Match point 1:] Search index: mainmainentry Score: 1000 Tag: 100 Subfields: a 11) Stage the record you just exported, choosing the matching rule you just created. 12) Merge the record using the "Merge" link, confirming that the resulting record (after going through the entire merging process) matches your expectations. 13) Sign off. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 11:05:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 09:05:19 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 11:16:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 09:16:22 +0000 Subject: [Koha-bugs] [Bug 5544] All Notices from Branch Email Address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #12 from Chris Cormack --- This works as advertised, however, it may introduce a warning in the case where $member is not defined. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 11:17:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 09:17:38 +0000 Subject: [Koha-bugs] [Bug 5544] All Notices from Branch Email Address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 11:17:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 09:17:41 +0000 Subject: [Koha-bugs] [Bug 5544] All Notices from Branch Email Address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18036|0 |1 is obsolete| | --- Comment #13 from Chris Cormack --- Created attachment 19437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19437&action=edit Bug 5544 - All Notices from Branch Email Address Right now overdues come from the branch, but the others come from the admin email address - this is a problem in multi-branch systems because they have to come up with one email address that all branches have access to. C4::Letters::_send_message_by_email currently sets the from address in the following order: 1) Address specified in message 2) Koha admin email address The order will now be: 1) Address specified in message 2) Borrowers home library email address 3) Koha admin email address Test Plan: 1) Set your branch email addresses, and the KohaAdminEmailAddress Make sure each of them are unqiue 2) Choose a borrower, enable the enhanced messaging and enable the checkout and checkin email notices. Use your email address for the borrower's email so you can recieve the emails. 3) Check out an item, check the from address of the email, it should be the email addres set in KohaAdminEmailAddress 4) Apply the patch 5) Return the item, check the from address of the email, it should match the email address set for the borrowers home library. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 11:48:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 09:48:52 +0000 Subject: [Koha-bugs] [Bug 5766] Add configuration for excluding articles from jQuery table sorter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5766 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 11:48:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 09:48:56 +0000 Subject: [Koha-bugs] [Bug 5766] Add configuration for excluding articles from jQuery table sorter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5766 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19380|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 19438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19438&action=edit Bug 5766 - Add configuration for excluding articles from DataTables sorting Client-side table sorting should exclude articles like "a," "an," and "the" when sorting by title. This patch adds a custom sorting plugin for use by DataTables and a configuration line to the DataTables string configuration file which can be translated for any language. As an example, this patch modifies the patron checkout history template to use the new sort on the title column. To test, apply the patch and clear your browser cache to ensure the revised JavaScript file is loaded. Sort the table by title. Titles should be sorted regardless of the presences of "a," "an", or "the" at the beginning of the title. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 12:00:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 10:00:18 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 14:00:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 12:00:43 +0000 Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 --- Comment #1 from M. de Rooy --- Created attachment 19439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19439&action=edit Bug 10520: Add i18n function to en/mandatory mysql files Main goal: Adds i18n calls around translatable columns. Additionally: Removes backtics. Adds column names in inserts (where missing). Uses consistent style (based on my interpretation of coding guidelines). Test plan: Make sure that you apply this patch on top of the 10509 patches! Run English mysql install. Verify that you include all mandatory files. Check if webinstaller does not report errors. Inspect table contents via interface or mysql. Search for a column not using i18n where you would expect translation. Note: If you prefer to run the mysql files from command line, please make sure now that you define a 'fake' i18n, doing nothing (see Installer.pm code). Signed-off-by: Marcel de Rooy Tested both ways myself. Noticed that I missed one message_transport_type (phone) and one language description (180 vs. 181). If needed, will handle these on a separate report. They do not directly relate to this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 14:57:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 12:57:26 +0000 Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 --- Comment #2 from M. de Rooy --- Created attachment 19440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19440&action=edit Bug 10520: Add i18n function to en/optional mysql files Main goal: Adds i18n calls around translatable columns. Additionally: Removes backtics. Adds column names in inserts (where missing). Uses consistent style (based on my interpretation of coding guidelines). Removed some locking statements in sample_creator_data. NOTE: Some scripts insert numbers in auto-increment columns. Although this works, I would not prefer to do so. This patch however is not meant to change that, so leaves them for now. Test plan: Make sure that you apply this patch on top of the 10509 patches! Run English mysql install. Verify that you include all OPTIONAL files (in the OTHER DATA section). Check if webinstaller does not report errors. Inspect table contents via interface or mysql. Search for a column not using i18n where you would expect translation. Note: If you prefer to run the mysql files from command line, please make sure now that you define a 'fake' i18n, doing nothing (see Installer.pm code). Signed-off-by: Marcel de Rooy Tested all optional data via webinstaller. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 15:02:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 13:02:33 +0000 Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |bgkriegel at gmail.com --- Comment #3 from M. de Rooy --- The first two patches are ready for signoff. The last patch should cover all files in marcflavour section. I still wait a few days in the hope to catch all MARC21 changes too from Bernardo in bug 5858. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 15:05:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 13:05:38 +0000 Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 --- Comment #4 from M. de Rooy --- Just to be clear: last patch refers to the third patch not yet attached :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 19:14:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 17:14:43 +0000 Subject: [Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Jared! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 21:00:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 19:00:13 +0000 Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Marcel should I wait for all 3 before signing off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 21:12:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 19:12:32 +0000 Subject: [Koha-bugs] [Bug 10534] Update of italian SQL files [3.12 only] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10534 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 21:12:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 19:12:36 +0000 Subject: [Koha-bugs] [Bug 10534] Update of italian SQL files [3.12 only] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10534 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19391|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 19441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19441&action=edit Bug 10534 : Update of italian SQL files [Only for 3.12] This update for italian SQL files doesn't cover Marc21 and Unimarc setup. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 21:48:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 19:48:23 +0000 Subject: [Koha-bugs] [Bug 10548] New: koha_perl_deps.pl miscounts dependencies displayed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10548 Bug ID: 10548 Summary: koha_perl_deps.pl miscounts dependencies displayed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: mtompset at hotmail.com $ cd kohaclone $ ./koha-perl-deps.pl -m -u Installed Required Module is Module Name Version Version Required -------------------------------------------------------------------------------------------- Data::Pagination 0 * 0.44 No Archive::Extract 0.48 * 0.60 No Test::WWW::Mechanize 1.36 * 1.44 No -------------------------------------------------------------------------------------------- Total modules reported: 3 * Module is missing or requires an upgrade. $ ./koha-perl-deps.pl -m -u -r Installed Required Module is Module Name Version Version Required -------------------------------------------------------------------------------------------- -------------------------------------------------------------------------------------------- Total modules reported: 3 * Module is missing or requires an upgrade. The second number should be 0. This tiny patch fixes it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 21:56:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 19:56:14 +0000 Subject: [Koha-bugs] [Bug 10548] koha_perl_deps.pl miscounts dependencies displayed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10548 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |mtompset at hotmail.com --- Comment #1 from M. Tompsett --- Created attachment 19442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19442&action=edit Moved $count++ into if statements to fix miscount. TEST ----- $ cd kohaclone $ ./koha_perl_deps.pl -m -u if you have nothing missing, uninstall an optional component. $ ./koha_perl_deps.pl -m -u you should get a number missing of at least 1. $ ./koha_perl_deps.pl -m -u -r you should get the same number, even though the output is less. apply patch $ ./koha_perl_deps.pl -m -u same results $ ./koha_perl_deps.pl -m -u -r the number should differ. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 23:33:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 21:33:37 +0000 Subject: [Koha-bugs] [Bug 10549] New: ILS-DI should not use ISO-8851-9 encoding Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10549 Bug ID: 10549 Summary: ILS-DI should not use ISO-8851-9 encoding Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: mirko at abunchofthings.net Reporter: mirko at abunchofthings.net ILS-DI outputs XML in ISO-8859-1 encoding. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 23:36:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 21:36:08 +0000 Subject: [Koha-bugs] [Bug 10549] ILS-DI should not use ISO-8851-9 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10549 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 6 23:56:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jul 2013 21:56:33 +0000 Subject: [Koha-bugs] [Bug 10549] ILS-DI should not use ISO-8851-9 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10549 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 02:07:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 00:07:22 +0000 Subject: [Koha-bugs] [Bug 10488] New MARC21 authority tags and subfields should be propagated to non-default frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10488 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Bernardo and Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 02:08:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 00:08:34 +0000 Subject: [Koha-bugs] [Bug 10396] Catalog stats shows calendar in callnumber field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10396 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #13 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Sophie! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 02:09:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 00:09:04 +0000 Subject: [Koha-bugs] [Bug 9665] Staff client bibliographic record export missing some options available in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9665 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 02:09:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 00:09:49 +0000 Subject: [Koha-bugs] [Bug 9541] Opac-user doesn't load correct CSS for multiple branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9541 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 02:10:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 00:10:38 +0000 Subject: [Koha-bugs] [Bug 9826] Missing fields in MARC21 authority framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9826 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Great work Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 02:11:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 00:11:58 +0000 Subject: [Koha-bugs] [Bug 9890] Fix the new plugin system for package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #24 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 02:13:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 00:13:42 +0000 Subject: [Koha-bugs] [Bug 10379] koha-rebuild-zebra gets noisy if no instances are defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10379 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Robin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 02:14:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 00:14:35 +0000 Subject: [Koha-bugs] [Bug 10431] Spanish Zebra language definition file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Pablo for reporting! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 02:15:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 00:15:10 +0000 Subject: [Koha-bugs] [Bug 10474] Translate some missed English strings in German sample notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10474 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 02:15:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 00:15:46 +0000 Subject: [Koha-bugs] [Bug 10317] Parcel should display a message when called with an nonexistent invoiceid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10317 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thansk Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 02:56:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 00:56:12 +0000 Subject: [Koha-bugs] [Bug 10524] Dependency updates to account for liblibrary-callnumber-lc-perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10524 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks again Robin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 04:10:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 02:10:16 +0000 Subject: [Koha-bugs] [Bug 10534] Update of italian SQL files [3.12 only] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10534 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Silvia: is "Barcode" fine Silvia? Shouldn't it be translated too? This could be pushed as-is anyway, It's a good and safe improvement for italian users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 05:32:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 03:32:49 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #3 from Chris Cormack --- Kyle the test plan is on the patch (in the commit message as it should be) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 05:35:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 03:35:22 +0000 Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 05:35:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 03:35:25 +0000 Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19417|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 19443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19443&action=edit Bug 10544 - stocknumber index is an alias of Number-local-acquisition Bug 6256 replaced in bib1.att stocknumber by Number-local-acquisition for number 1062. In this case, Number-local-acquisition must be used in record.abs and stocknumber can be an alias of it in ccl.properties. Test plan : - drop zebra database (rebuild_zebra.pl -r ...) - reindex - test in simple search : ccl=Number-local-acquisition,alwaysmatches='' => you get all records with a stocknumber - test in simple search : ccl=stocknumber,alwaysmatches='' => you get the same results Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 06:07:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 04:07:40 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 06:07:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 04:07:44 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19398|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 19444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19444&action=edit Bug 10513 - Light up a warning/message when returning a chosen item type This patch adds a new column to item types. Text in this column is displayed as a warning when an item of the given type is checked in. Use case: Items that are on inter-library loan can have a separate item type, and when items of this type are checked in a message saying something like "ILL! Remember to return it to the owning library!" can be displayed. To test: - Apply the patch - Go to Home > Administration > Item types administration - Check that there is a new column, called "Check in message" - Edit an item type and add a check in message - Check that the check in message you added is displayed in the table - Check in an item with an item type that has a check in message - Check that the message is displayed - Check in an item with an item type that does *not* have a check in message, and make sure no false messages are displayed - Run the tests in t/ItemType.t, which are updated by this patch This patch also removes backticks around column names in the itemtypes table in installer/data/mysql/kohastructure.sql Sponsored-by: Kultur i Halland - Regionbibliotek Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 06:11:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 04:11:13 +0000 Subject: [Koha-bugs] [Bug 10529] Dollar sign hardcoded in patron message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10529 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 06:11:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 04:11:17 +0000 Subject: [Koha-bugs] [Bug 10529] Dollar sign hardcoded in patron message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10529 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19396|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 19445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19445&action=edit Bug 10529: Remove hardcoded dollar from patron message The message fields which are returned in the SIP Screen message field in a Patron Information response had dollar hardcoded. It would be possible to get the symbol from currency but omitting any symbol would be consistent with the UI and avoid problems with devices using weird encodings for local currency symbols (e.g. the many variations of UK Pound sign) Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 06:15:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 04:15:31 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #57 from Chris Cormack --- Patch doesn't apply there is a conflict in koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl That I don't know how to fix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 06:50:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 04:50:54 +0000 Subject: [Koha-bugs] [Bug 9519] Wrong language code for Italian in the advanced search language limitations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9519 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 06:50:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 04:50:57 +0000 Subject: [Koha-bugs] [Bug 9519] Wrong language code for Italian in the advanced search language limitations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9519 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19392|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 19446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19446&action=edit Bug 9519 Wrong language code for Italian The code for Italian in advanced search limitations should be "ita"and not "ind". Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 06:59:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 04:59:46 +0000 Subject: [Koha-bugs] [Bug 9252] Add option to send patron's home branch in AF field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 --- Comment #17 from Chris Cormack --- Comment on attachment 19084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19084 Bug 9252 - Add option to send patron's home branch in AF field Review of attachment 19084: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9252&attachment=19084) ----------------------------------------------------------------- ::: C4/SIP/Sip/MsgType.pm @@ +453,5 @@ > } > > + $resp .= maybe_add( FID_SCREEN_MSG, $patron->screen_msg ); > + $resp .= maybe_add( FID_SCREEN_MSG, $patron->{branchcode} ) > + if ( $server->{account}->{send_patron_home_library_in_af} ); I see at line 492 $resp = build_patron_status($patron, $lang, $fields, $server ); but line 742 has $resp = build_patron_status($patron, $patron->language, $fields); In the handle_block_patron subroutine. This means that $server will be undefined and throw a warn. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 07:00:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 05:00:08 +0000 Subject: [Koha-bugs] [Bug 9252] Add option to send patron's home branch in AF field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 08:33:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 06:33:49 +0000 Subject: [Koha-bugs] [Bug 4456] Enable addition of PO Number to order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4456 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Access to order by PO |Enable addition of PO |Number |Number to order -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 09:44:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 07:44:29 +0000 Subject: [Koha-bugs] [Bug 10448] Changing framework when cataloguing clears all fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10448 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 09:44:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 07:44:33 +0000 Subject: [Koha-bugs] [Bug 10448] Changing framework when cataloguing clears all fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10448 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18987|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 19447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19447&action=edit Bug 10448 - Changing framework when cataloguing clears all fields This patch changes the Changefwk Javascript function so that it passes the "op" value and the "biblionumberdata" (as the biblionumber) from addbiblio.pl back to itself, when submitting the form in order to change the framework. The reason we need to do this is because the form in addbiblio.tt is hard-coded to always submit an "op" value of "addbiblio". Currently, we need to have it hard-coded to "addbiblio", because all the magic happens in addbiblio.pl when there is an "op" of "addbiblio". If we always passed the "actual" "op" value, such as "duplicate", nothing would ever happen when we clicked "save". It seems to me that this is a flaw in the design of addbiblio.pl. If we pass the "op" and "biblionumber" when changing frameworks, we're able to tell addbiblio.pl that we're still wanting to "duplicate" this "X" biblionumber. However, by having the form still hard-coded to "addbiblio", when we hit save, the form will do the magic, check if it's a duplicate, and save the record (or prompt for action if it is a duplicate). -- I also noticed that if you make changes to a record, then change the framework before saving, your changes get cleared (since the original record from the database is loaded when the page reloads). It seems to me that this is a bug. Changing the framework should change the layout while preserving the content. I think most users would assume that when changing the framework. This patch also introduces another hidden input into addbiblio.tt and the Changefwk Javascript called "changed_framework". Basically, if the Changefwk Javascript is run, it tells addbiblio.pl that the framework is changed, and it uses the posted data from the form (which we have been modifying) instead of reloading the record from the database. -- Test Plan: A) Before Applying Patch: To Show That Changing the Framework Erases All Fields When Duplicating a Record: 1) Go to any bib record 2) Go to Edit > Edit as new (duplicate). You should see filled in fields. 3) Change the framework to any other framework than the one that is currently specified. 4) Note that every single field is now blank To Show That Changing the Record then Changing the Framework Ignores Changes, When Editing a Record 5) Go to any bib record 6) Go to Edit. 7) Change the title of the record to "I've changed the title". 8) Change the framework to any other framework than the one that is currently specified. 9) Look at the title. You'll notice it is the original title, and NOT "I've changed the title". B) Apply the Patch Also, clear your memcache and shift+refresh your screen. You don't want to use cached templates/javascript. C) After Applying the Patch Repeat Steps 1-3 and 5-8. You should now notice that changing the framework when duplicating the item does not clear all the fields. You should also notice that any changes you make prior to changing the framework will still exist after changing it. Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 09:46:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 07:46:35 +0000 Subject: [Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 09:46:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 07:46:39 +0000 Subject: [Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19185|0 |1 is obsolete| | --- Comment #12 from Chris Cormack --- Created attachment 19448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19448&action=edit Bug 10289: UT: Reserves.t needs to create its own data Try before the patch: prove t/db_dependent/Reserves.t And after, it should produce: t/db_dependent/Reserves.t .. 1/4 # # Creating biblio instance for testing. # Creating item instance for testing. # Deleting item testing instance. # Deleting biblio testing instance. # Deleting borrower. t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=4, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 09:55:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 07:55:21 +0000 Subject: [Koha-bugs] [Bug 10522] Javascript error on acquisition pages: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10522 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 09:55:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 07:55:25 +0000 Subject: [Koha-bugs] [Bug 10522] Javascript error on acquisition pages: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10522 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19358|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 19449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19449&action=edit Bug 10522 - Javascript error on acquisition pages: YAHOO is not defined acq.js includes an immediately invoked function expression, which means that it runs whether or not it is called. Because this function tries to reference the YAHOO object, it triggers an error on pages which don't include the main YAHOO assets. Only the basketgroups page uses this function and YAHOO assets. It's probably possible to make this a regular function, but I propose simply wrapping it in a check for the YAHOO object so that it only executes on pages where YAHOO exists--the basketgroups page. To test, apply the patch, clear your browser cache, and test on both the basketgroups page and at least one page which also includes acq.js (addorderiso2709.pl, neworderempty.pl, aqbudgets.pl, suggestion.pl, etc.) and confirm that the browser reports no JavaScript errors. Signed-off-by: Jonathan Druart $ git show HEAD -w [...] - +if( typeof(YAHOO) === "object"){ (function() { var Dom = YAHOO.util.Dom; @@ -234,7 +234,7 @@ YAHOO.extend(DDList, YAHOO.util.DDProxy, { } }); })(); - +} Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 10:00:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 08:00:00 +0000 Subject: [Koha-bugs] [Bug 4907] Suggestions "organize by" menu doesn't reflect current choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4907 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 10:00:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 08:00:09 +0000 Subject: [Koha-bugs] [Bug 4907] Suggestions "organize by" menu doesn't reflect current choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4907 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19363|0 |1 is obsolete| | --- Comment #7 from Chris Cormack --- Created attachment 19450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19450&action=edit Bug 4907: 'Organize by' filter in suggestions doesn't reflect selected option When using the 'Organize by' option to change the display of the suggestions, the option is applied, but the pull down always jumps back to the first entry 'Status'. This patch fixes that. To test: - Try out all settings and verify that after the page reloads the selected option is applied to your suggestions and the pull down shows the option you selected. Note: Until bug 10519 is properly fixed the tabs will not show the correct descriptions, but the URL will show you the selected option as parameter: displayby=acceptedby Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 10:02:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 08:02:19 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to selelct multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- I'd like to keep the report numbers too - apart from what Liz said it's an easy way to find the newest reports. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 10:21:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 08:21:36 +0000 Subject: [Koha-bugs] [Bug 10125] Babeltheque star image must use sprite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10125 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 10:21:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 08:21:39 +0000 Subject: [Koha-bugs] [Bug 10125] Babeltheque star image must use sprite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10125 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19381|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 19451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19451&action=edit Bug 10125 - Babeltheque star image must use sprite When I removed images from the OPAC in favor of sprites I didn't take into account the display of star ratings from Babeltheque. This patch copies the star ratings display from Koha's own ratings display, though it is not dependent on JavaScript. I'm sure testing would be easy for someone with access to the Babeltheque service, but I do not. I temporarily modified the template to set some variables for testing purposes: [% SET SEARCH_RESULT.score_int = 3 %] [% SET SEARCH_RESULT.score_avg = 3 % [% SET SEARCH_RESULT.num_scores = 87 %] This enabled the display of the ratings, allowing me to confirm that stars display correctly. Ratings should work with and without OpacStarRatings enabled. Signed-off-by: Chris Cormack I also fudged the template to test, so QA would need to be done with someone with Babeltheque access -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 10:23:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 08:23:30 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 10:25:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 08:25:35 +0000 Subject: [Koha-bugs] [Bug 8911] docs/history.txt file missing for about.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8911 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 10:25:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 08:25:38 +0000 Subject: [Koha-bugs] [Bug 8911] docs/history.txt file missing for about.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8911 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19354|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 19452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19452&action=edit Bug 8911 - history.txt file missing for about.pl This patch makes Makefile.PL put the history.txt file in the right places depending on the chosen setup layout, adds a reference to that place in koha-conf.xml (and debian template version), and finally tweaks about.pl to use it. To test, apply the patch and verify that perl Makefile.PL runs fine, and installing in - dev - single - standard layouts works as expected. Then go to the about.pl page and see if Koha's history shows there. Then, build your packages and test on your newly created instances. Regards To+ Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 10:40:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 08:40:13 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #96 from Chris Cormack --- Created attachment 19453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19453&action=edit Bug 7143: Updating history and about page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 10:40:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 08:40:34 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 10:40:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 08:40:46 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 11:32:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 09:32:39 +0000 Subject: [Koha-bugs] [Bug 10125] Babeltheque star image must use sprite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10125 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #3 from Katrin Fischer --- Hi Jonathan, could you take a look at this please? I hope that you are able to test with a Babeltheque account maybe. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 11:36:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 09:36:36 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 11:38:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 09:38:22 +0000 Subject: [Koha-bugs] [Bug 10021] Remove dead(?) code related to notifys In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master --- Comment #2 from Katrin Fischer --- Now that bug 10256 has been pushed to master, we should also remove the database parts of it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 11:47:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 09:47:56 +0000 Subject: [Koha-bugs] [Bug 10232] Permission check for editing help files is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10232 --- Comment #1 from Katrin Fischer --- I think this is kind of a bigger problem - only superlibrarians can currently edit help files. Of course, editing help files comes with its own set of problems, as any changes made will be overwritten when updating. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 11:48:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 09:48:03 +0000 Subject: [Koha-bugs] [Bug 10232] Permission check for editing help files is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10232 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 11:48:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 09:48:25 +0000 Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto email address for some notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 11:53:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 09:53:59 +0000 Subject: [Koha-bugs] [Bug 10550] New: Fix database typo wthdrawn Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Bug ID: 10550 Summary: Fix database typo wthdrawn Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de Citing Galen's mail from May 22nd: However, now that we're at the very beginning of the 3.14 cycle, the window is now open for the sort of patch that offers cosmetic or textual improvement but which also happens to touch a lot of code. If there are longstanding typos you want to fix (my "favorite" is the wthdrawn column in the items table), now is your chance. I'm not setting a definite end to the window at this point, but suffice it to say that I will be much more likely to merge such patches now as opposed to three months from now. Time is running ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 12:11:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 10:11:14 +0000 Subject: [Koha-bugs] [Bug 9299] for loop in Auth_with_ldap.pm requires an extended patron attribute to be set or LDAP logins fail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9299 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 12:17:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 10:17:07 +0000 Subject: [Koha-bugs] [Bug 9165] Allow preventing passwords from being stored locally when using LDAP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9165 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 12:26:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 10:26:33 +0000 Subject: [Koha-bugs] [Bug 5544] All Notices from Branch Email Address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 --- Comment #14 from Katrin Fischer --- (In reply to Chris Cormack from comment #12) > This works as advertised, however, it may introduce a warning in the case > where $member is not defined. Bit worried about this comment - we tend to forget that we have a message that goes to the library and therefore has no borrowernumber in message_queue - overdues digest for patrons without email address. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 12:31:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 10:31:36 +0000 Subject: [Koha-bugs] [Bug 10384] Software error when LDAP connexion fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10384 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 12:32:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 10:32:50 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 12:52:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 10:52:31 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 12:57:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 10:57:38 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #59 from Katrin Fischer --- I think this change might be in conflict with the big serials pattern patch that has reached 'Passed QA' already (bug 7688). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 13:03:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 11:03:24 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 13:06:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 11:06:26 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 --- Comment #34 from Katrin Fischer --- Should we carry the existing typo to another column? wthdrawn -> wthdrawn_on? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 13:06:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 11:06:48 +0000 Subject: [Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 13:11:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 11:11:04 +0000 Subject: [Koha-bugs] [Bug 10485] Alphabetize REPORT_GROUP and REPORT_SUBGROUP Menus based on description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10485 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master --- Comment #1 from Katrin Fischer --- Tested on master - we don't have filters any more, but the pull downs in the 'new report' from are unsorted too. Probably needs different patch sets for master and 3.10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 13:11:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 11:11:15 +0000 Subject: [Koha-bugs] [Bug 10485] Alphabetize REPORT_GROUP and REPORT_SUBGROUP Menus based on description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10485 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|master |3.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 13:13:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 11:13:39 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 13:16:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 11:16:33 +0000 Subject: [Koha-bugs] [Bug 10503] incorrect initialization parameters passed to Memoize::Memcached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10503 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 13:20:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 11:20:53 +0000 Subject: [Koha-bugs] [Bug 10430] status filter not working in serial claims when translated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 13:22:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 11:22:19 +0000 Subject: [Koha-bugs] [Bug 10445] SIP Server doesn't respect maxoutstanding system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Who on the QA team (except for Chris and Kyle) knows how to test SIP or can teach me? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 13:22:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 11:22:46 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 13:23:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 11:23:52 +0000 Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 --- Comment #6 from M. de Rooy --- Chris: Thanks for testing. You are welcome to sign off what is available.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 13:28:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 11:28:35 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- I am sorry, but I think there are various problems with this: - It missed unit tests for the new module. - It introduces untranslatable strings in the Javascript. - It should probably be using the sprite for displaying the stars (Owen has done work on having Babeltheque and the opacstarratings using it, so there are already star images available I think) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 13:34:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 11:34:32 +0000 Subject: [Koha-bugs] [Bug 10521] Add i18n function to German mysql files for webinstaller (de-DE) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 13:35:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 11:35:34 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 13:36:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 11:36:49 +0000 Subject: [Koha-bugs] [Bug 10044] Doubled up paging on order receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10044 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 13:36:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 11:36:49 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Bug 10124 depends on bug 10044, which changed state. Bug 10044 Summary: Doubled up paging on order receive http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10044 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 13:54:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 11:54:20 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #39 from M. de Rooy --- Bernardo, I received your new file. And will recreate your patch now. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 13:57:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 11:57:10 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19371|0 |1 is obsolete| | Attachment #19372|0 |1 is obsolete| | Attachment #19373|0 |1 is obsolete| | --- Comment #40 from M. de Rooy --- Created attachment 19454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19454&action=edit Bug 5858 - Default frameworks missing many MARC21 tags This patch combines original patch and two followups (with thanks to Mason). Patch has been recreated to recover from the whitespace errors coming back in the followups. The patch adds missing tags/subtags, or updates descriptions. Does only apply to new installs. We will still find a way to have current installs also/easier benefit from these changes too. To test: 1) Delete MARC21 default framework 2) Apply patch 3) Test that new default framework loads without problem Signed-off-by: Mason James Signed-off-by: Marcel de Rooy Run this file with and without this patch. This patch adds 24 tags (338 vs 314) and 323 subfields (3951 vs 3628). Verified that last QA comments were incorporated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 13:57:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 11:57:31 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 13:57:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 11:57:39 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 14:04:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 12:04:49 +0000 Subject: [Koha-bugs] [Bug 9282] authorities auto-completion in mainmainentry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9282 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #11 from Jared Camins-Esakov --- (In reply to M. de Rooy from comment #10) > Looks quite good to me, but I am wondering about this now: > > } elsif ($tag eq '180') { > $subfields_to_report = 'vxyz'; > [etc. etc. etc.] > if ($subfields_to_report) { > push @authorized, { > heading => $field->as_string($subfields_to_report), > hemain => $field->subfield( > substr($subfields_to_report, 0, 1) ), > > If you use the first char here, you will take $v into hemain. But I think > that you should take $x for the 18X fields. > I would like to see a response from Jared here, as I assume that he was > responsible for quite some changes in this module. Could you please attract > his attention? Thanks. As hemain is used for mainmainentry, the search does not make sense for 18x authorities anyway, as there is no Main Entry for 18x authorities. However, since 18x authorities are not supported in any useful way by Koha, and probably never will be, I see no problem with pushing the code as-is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 14:26:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 12:26:42 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #41 from M. de Rooy --- Final(?:) QA comment: Looks good to me now, Bernardo. Good work again. Refer to my former comment. Points have been incorporated. Passed QA The following points still need attention: 1. How do we translate? My proposal is here: do this via bug 10509; the i18n proposal there will make life easier for the non-English installs. BTW I waited for this patch to include the marc21 changes of this report. 2. How will current installs benefit? Thinking out loud: Would it be an idea if we could Upgrade on the MARC structure administration form? Upgrade would just run this file and try to insert the new ones. (That could include translation with the i18n approach. Run the file via load_sql.) Will add a followup to replace INSERT by INSERT IGNORE. This allows you to run the file on an existing install. RM: With respect to the second question, it might be good to include a dbrev that prints a message about the possibility to add new tags when upgrading by running the script manually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 14:48:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 12:48:32 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #42 from M. de Rooy --- Created attachment 19455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19455&action=edit Bug 5858: Followup for INSERT IGNOREs in marc21_framework_DEFAULT.sql Changes 8 INSERTs into INSERT IGNOREs. This allows current installs to benefit easier from the new tags/subfields. Note that running with --force will not achieve the same! The multi-value inserts will still be aborted, though execution continues. Test plan: Run the file or do a new install. Signed-off-by: Marcel de Rooy Ran the file on a current install manually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 14:49:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 12:49:52 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #43 from M. de Rooy --- Last thought on the Upgrade idea: Would be nice to do something like that. Since we still have the non-default frameworks here too (with their redundancy..) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 14:50:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 12:50:45 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 15:06:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 13:06:48 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #44 from Bernardo Gonzalez Kriegel --- My idea is rewrite marc21_simple_bib_frameworks.sql to create bib frameworks like authtypes in Bug 10488. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 17:43:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 15:43:49 +0000 Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Created attachment 19456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19456&action=edit authority search form after changing the screen size, labels wrongly located As promised adding my comments from IRC here too, together with screenshots: 1) The authority search form does not cope well with different screen sizes. Wide screens are a problem and also small screens. After changing the screen size a few times back and forth, the labels are not positioned correctly (see screenshot) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 17:46:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 15:46:25 +0000 Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 --- Comment #4 from Katrin Fischer --- Created attachment 19457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19457&action=edit Wide pull downs for boolean operators on advanced search form 2) Pull downs for boolean operators on advanced search with 'more options' are very wide for the small words within them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 17:51:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 15:51:36 +0000 Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 --- Comment #5 from Katrin Fischer --- Created attachment 19458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19458&action=edit itemtypes in advanced search not using available space well 3) Also on the advanced search page the itemtype selection moves into 1 column very soon, while there is still a lot of space available. Maybe it could change into a 2 column display first or have more steps in between. For very small screens and lots of itemtypes there will be a loooong list to scroll through. I wonder what we could do about that. Maybe something like collapse the search option by default on smaller screens with an option to make it visible again? Not sure what can be done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 18:02:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 16:02:07 +0000 Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 --- Comment #6 from Katrin Fischer --- Created attachment 19459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19459&action=edit Search input field on login page too short on wide screens 4) When you click on 'Login to your account' the search form suddenly is a lot shorter on the login page. Screen size wasn't changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 18:50:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 16:50:44 +0000 Subject: [Koha-bugs] [Bug 10534] Update of italian SQL files [3.12 only] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10534 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- I notice 2 itemtypes are not translated: computer files and reference. Maybe something for a follow up :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 18:53:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 16:53:32 +0000 Subject: [Koha-bugs] [Bug 10534] Update of italian SQL files [3.12 only] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10534 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 18:53:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 16:53:36 +0000 Subject: [Koha-bugs] [Bug 10534] Update of italian SQL files [3.12 only] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10534 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19441|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 19460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19460&action=edit [PASSED QA] Bug 10534 : Update of italian SQL files [Only for 3.12] This update for italian SQL files doesn't cover Marc21 and Unimarc setup. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer I tested the web installer in Italian. No errors reported. I also checked some of the created values and all looked fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 19:06:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 17:06:27 +0000 Subject: [Koha-bugs] [Bug 10534] Update of italian SQL files [3.12 only] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10534 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Silvia! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 19:11:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 17:11:02 +0000 Subject: [Koha-bugs] [Bug 9519] Wrong language code for Italian in the advanced search language limitations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 19:11:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 17:11:06 +0000 Subject: [Koha-bugs] [Bug 9519] Wrong language code for Italian in the advanced search language limitations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19446|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 19461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19461&action=edit [PASSED QA] Bug 9519 Wrong language code for Italian The code for Italian in advanced search limitations should be "ita"and not "ind". Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer I checked nb-NO and de-DE - language code there had already been corrected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 19:27:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 17:27:24 +0000 Subject: [Koha-bugs] [Bug 9801] location facet shows even if no locations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9801 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 19:27:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 17:27:27 +0000 Subject: [Koha-bugs] [Bug 9801] location facet shows even if no locations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9801 --- Comment #4 from Katrin Fischer --- Created attachment 19462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19462&action=edit [SIGNED OFF] Bug 9801 - location facet shows even if no locations Currently, the headings for facets (such as location) are showing even if there are no actual values/links for that facet type. This patch simply checks if the facet array contains any facets before printing the heading and HTML for each facet value/link. Test Plan: Before applying: 0) If you want to check the location facet (which is easiest), enable singlebranch mode in the globals system preferences. 1) Do a search for records/items that you have no shelving location specified (or simply remove the shelving location for a small range of records that you can find in a search query). 2) Note that "Location" appears amongst the facets even though there are no values/links present. (If you look at the HTML source, you'll see some empty HTML tags have been printed out.) Apply patch. 3) Flush your cache and refresh your page. 4) You should no longer see a "Location" facet (or those empty HTML tags) on the facet sidebar. Signed-off-by: Katrin Fischer Template changes only. Checked according to test plan, made sure location facet still shows up when values exist, otherwise it's hidden. It might make sense to add ids to the facets so libraries can decide to hide some of them easily. Or alternatively add a system preference to make that possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 19:35:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 17:35:20 +0000 Subject: [Koha-bugs] [Bug 5652] Patron checkout and holds summary should show subtitles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5652 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 7 20:19:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jul 2013 18:19:49 +0000 Subject: [Koha-bugs] [Bug 10534] Update of italian SQL files [3.12 only] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10534 --- Comment #9 from Katrin Fischer --- Welcome Silvia as a new contributor too! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 03:10:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 01:10:06 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #7 from Liz Rea --- I'm having trouble applying these patches, I get Repository lacks necessary blobs to fall back on 3-way merge. and I did all of the fetches and other gymnastics that often fix this, with no luck. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 05:19:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 03:19:33 +0000 Subject: [Koha-bugs] [Bug 10358] add a syspref to allow BLOCKED patrons to return items, via the SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10358 --- Comment #5 from Bob Birchall --- I tested this against 3.10.4, using a borrower with overdues and one with no overdues, and with all three settings of the sys pref. - When sys pref is set to 'All' both borrowers can return, as expected; - when sys pref is set to 'Non-Blocked' the borrower with no overdues can return but the borrower with fines cannot return, again as expected. - When the sys pref is set to 'Don't Allow', neither borrower can return (as expected) however there is an unexpected difference in the screen dialogue: Case 1, borrower who is blocked receives the message 'Item cannot be checked out' with option only of returning to the Account Summury; Case 2, borrower who is not blocked receives the same message but has the 'Return Item' button displayed as well as the 'Return' button. When 'Return Item' is clicked the item in fact is not returned (respecting the sys pref). However the display error is likely to confuse users and should be fixed in my opinion. Unable to sign off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 07:59:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 05:59:48 +0000 Subject: [Koha-bugs] [Bug 5766] Add configuration for excluding articles from jQuery table sorter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5766 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 07:59:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 05:59:51 +0000 Subject: [Koha-bugs] [Bug 5766] Add configuration for excluding articles from jQuery table sorter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5766 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19438|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 19463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19463&action=edit [PASSED QA] Bug 5766 - Add configuration for excluding articles from DataTables sorting Client-side table sorting should exclude articles like "a," "an," and "the" when sorting by title. This patch adds a custom sorting plugin for use by DataTables and a configuration line to the DataTables string configuration file which can be translated for any language. As an example, this patch modifies the patron checkout history template to use the new sort on the title column. To test, apply the patch and clear your browser cache to ensure the revised JavaScript file is loaded. Sort the table by title. Titles should be sorted regardless of the presences of "a," "an", or "the" at the beginning of the title. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes all tests and is a good improvement. I have added German articles to the list for testing purposes and it worked nicely. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 08:00:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 06:00:09 +0000 Subject: [Koha-bugs] [Bug 5766] Add configuration for excluding articles from jQuery table sorter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5766 --- Comment #5 from Katrin Fischer --- After giving this some more thought it would be nice if this could be in the configuration. Being able to translate the string and influence sorting this way is a good start, but maybe not flexible enough. For libraries with records in multiple languages they will want to have a longer list they can adjust and not only a translation for one language. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 08:17:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 06:17:46 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #36 from Katrin Fischer --- I found a little something: For non-repeatable subfields, no warning is triggered. I tested with 245$a and was able to create a record with 2 245$a subfields without problems or warnings. Warnings for control fields and non repeatable fields fields work nicely. Also if a field is not existant in the new record and you want to add one of the subfields you are warned. I made sure I was using the default framework and 245$a was configured correctly. This is also on master but should be fixed - either here as a follow-up or on a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 08:21:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 06:21:00 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 08:21:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 06:21:05 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18446|0 |1 is obsolete| | Attachment #18910|0 |1 is obsolete| | Attachment #19038|0 |1 is obsolete| | --- Comment #37 from Katrin Fischer --- Created attachment 19464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19464&action=edit [PASSED QA] Bug 9755: Refactor record merge functionality This patch refactors the merge record interface and code a little bit in preparation for making it possible to merge authority records. To test: 1) Apply patch. 2) Try merging two records: a) Create a list. b) Add two records you would like to (or be willing to) merge to said list. c) View said list. d) Check the checkboxes next to the two records you added. e) Click "Merge selected records." f) Choose a merge reference. g) Choose fields from each record that you want to keep. h) Click "Merge." 3) Confirm that your merged record has the fields and subfields you wanted. 4) Run the unit tests for the two files that were changed: prove t/Koha_Record.t t/db_dependent/Koha_Authority.t 5) Sign off. Signed-off-by: Mathieu Saby Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 08:21:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 06:21:17 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #38 from Katrin Fischer --- Created attachment 19465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19465&action=edit [PASSED QA] Bug 9755 QA follow-up: move MARC-specific functionality to utility class This follow-up moves all the MARC-specific functionality of Koha::Record (now renamed to Koha::MetadataRecord) to a Koha::Util::MARC utility class. To test, run relevant unit tests: > prove t/Koha_MetadataRecord.t t/Koha_Util_MARC.t t/db_dependent/Koha_Authority.t and optionally try to merge a record. Signed-off-by: Mathieu Saby Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 08:21:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 06:21:25 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #39 from Katrin Fischer --- Created attachment 19466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19466&action=edit [PASSED QA] Bug 9755 QA follow-up: fix template compliance Fix the following test failure: * koha-tmpl/intranet-tmpl/prog/en/includes/merge-record.inc FAIL forbidden patterns OK tt_valid FAIL lines 10, 24 valid_template OK Signed-off-by: Katrin Fischer Passes all tests and QA script. Found a pre-existing problem with non-repeating subfields that i noted on the bug report. All other tests were ok and merging records worked nicely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 08:24:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 06:24:19 +0000 Subject: [Koha-bugs] [Bug 6588] Choose to delete some items on merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6588 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|merging records loses item |Choose to delete some items |records! |on merge --- Comment #3 from Katrin Fischer --- I am changing the bug report's title to make it less scary :) I just tested on master and items moved over nicely. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 08:27:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 06:27:35 +0000 Subject: [Koha-bugs] [Bug 10551] New: Merging records allows duplicaton of non-repeatable subfields Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10551 Bug ID: 10551 Summary: Merging records allows duplicaton of non-repeatable subfields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de CC: jcamins at cpbibliography.com, m.de.rooy at rijksmuseum.nl To test: - Add 2 records to a list - Go to the list, select those 2 and merge them using the button on top - Select either record as the destination record - Select 245$a from the second tab to be also added to the record - Verify no warning is given. - Finish merge process. - Verify that the new record shows 2 245$a subfields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 08:27:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 06:27:45 +0000 Subject: [Koha-bugs] [Bug 10551] Merging records allows duplicaton of non-repeatable subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10551 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9755 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 08:27:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 06:27:45 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10551 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 08:36:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 06:36:24 +0000 Subject: [Koha-bugs] [Bug 10551] Merging records allows duplicaton of non-repeatable subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10551 --- Comment #1 from Katrin Fischer --- Hm and related to this... you can also save records with no 245$a at all, so no checks on mandatory subfields are performed. This is only related to 9755 as it appears on current master and after applying the patches, there is no regression, but problemes should be fixed after the refactoring patch has gone in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 10:24:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 08:24:31 +0000 Subject: [Koha-bugs] [Bug 10125] Babeltheque star image must use sprite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10125 --- Comment #4 from Jonathan Druart --- QA Comment: This patch supposes that the Babeltheque ratings depends on OpacStarRatings. It is false. I will provide a followup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 10:26:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 08:26:10 +0000 Subject: [Koha-bugs] [Bug 10125] Babeltheque star image must use sprite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10125 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19451|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 19467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19467&action=edit Bug 10125 - Babeltheque star image must use sprite When I removed images from the OPAC in favor of sprites I didn't take into account the display of star ratings from Babeltheque. This patch copies the star ratings display from Koha's own ratings display, though it is not dependent on JavaScript. I'm sure testing would be easy for someone with access to the Babeltheque service, but I do not. I temporarily modified the template to set some variables for testing purposes: [% SET SEARCH_RESULT.score_int = 3 %] [% SET SEARCH_RESULT.score_avg = 3 % [% SET SEARCH_RESULT.num_scores = 87 %] This enabled the display of the ratings, allowing me to confirm that stars display correctly. Ratings should work with and without OpacStarRatings enabled. Signed-off-by: Chris Cormack I also fudged the template to test, so QA would need to be done with someone with Babeltheque access Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 10:26:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 08:26:21 +0000 Subject: [Koha-bugs] [Bug 10125] Babeltheque star image must use sprite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10125 --- Comment #6 from Jonathan Druart --- Created attachment 19468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19468&action=edit Bug 10125: Babeltheque does not depend on OpacStarRatings. We have to load star ratings js and css file if Babeltheque is enabled and OpacStarRatings is disabled. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 10:27:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 08:27:38 +0000 Subject: [Koha-bugs] [Bug 10125] Babeltheque star image must use sprite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10125 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Jonathan Druart --- These patchs can be test on http://catalogue.master33-dev.biblibre.com/cgi-bin/koha/opac-search.pl?q=lila Babeltheque is on and OpacStarRatings is off. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 10:37:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 08:37:22 +0000 Subject: [Koha-bugs] [Bug 9410] Formatting of the discount field when doing a new order from new empty record is not correct In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #6 from Jonathan Druart --- Ok, switch back to Signed Off and let someone else qa this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 11:00:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 09:00:12 +0000 Subject: [Koha-bugs] [Bug 8360] Author facet not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8360 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #6 from Fridolyn SOMERS --- I think this patch is not a solution. We know the search with "phrase" structure (witch in implicit for Zebra) sometimes does not work. But using "word list" is wrong because it performs a search of words without order. There can be problems with some facets, for example authors "Pierre JUSTE" and "Juste PIERRE". A click on a facet "au,wrld=Pierre JUSTE" will return results with both authors. Problems must be fixed in search engine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 13:47:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 11:47:18 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 --- Comment #35 from Kyle M Hall --- (In reply to Katrin Fischer from comment #34) > Should we carry the existing typo to another column? wthdrawn -> wthdrawn_on? Yes, absolutely! I think it would be far more confusing to have one field named correctly and one not. At least this way we have consistency. And, when I or someone else get around to renaming the wthdrawn column, we can rename both at once. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 14:03:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 12:03:30 +0000 Subject: [Koha-bugs] [Bug 9252] Add option to send patron's home branch in AF field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 --- Comment #18 from Kyle M Hall --- Created attachment 19469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19469&action=edit Bug 9252 - Add option to send patron's home branch in AF field - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 14:03:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 12:03:43 +0000 Subject: [Koha-bugs] [Bug 9252] Add option to send patron's home branch in AF field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 14:15:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 12:15:38 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 14:15:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 12:15:43 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18942|0 |1 is obsolete| | Attachment #19089|0 |1 is obsolete| | Attachment #19090|0 |1 is obsolete| | Attachment #19091|0 |1 is obsolete| | --- Comment #58 from Kyle M Hall --- Created attachment 19470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19470&action=edit Bug 7441 - search results showing wrong branch When you search in the OPAC it shows you the HOME branch on the location in XSLT, but if you click through to the detail page it shows you the HOLDING branch in the holdings table which is very confusing to patrons. Fixed by adding a system preference to choose whether to display the holding branch or the home branch on the XSLT OPAC search results page. Signed-off-by: Bernardo Gonzalez Kriegel Rebased on current master (2013-01-31). Signed-off-by: Chris Rohde -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 14:15:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 12:15:59 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #59 from Kyle M Hall --- Created attachment 19471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19471&action=edit Bug 7441: Followup search results showing wrong branch [UNIMARC] Unimarc modifications Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Chris Rohde -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 14:17:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 12:17:40 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19470|0 |1 is obsolete| | Attachment #19471|0 |1 is obsolete| | --- Comment #60 from Kyle M Hall --- Created attachment 19472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19472&action=edit Bug 7441 - Part 1 - search results showing wrong branch When you search in the OPAC it shows you the HOME branch on the location in XSLT, but if you click through to the detail page it shows you the HOLDING branch in the holdings table which is very confusing to patrons. Fixed by adding a system preference to choose whether to display the holding branch or the home branch on the XSLT OPAC search results page. Signed-off-by: Bernardo Gonzalez Kriegel Rebased on current master (2013-01-31). Signed-off-by: Chris Rohde -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 14:17:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 12:17:52 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #61 from Kyle M Hall --- Created attachment 19473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19473&action=edit Bug 7441 - Part 2 - Followup search results showing wrong branch [UNIMARC] Unimarc modifications Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Chris Rohde -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 14:18:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 12:18:04 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #62 from Kyle M Hall --- Created attachment 19474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19474&action=edit Bug 7441 - Part 3 - search results showing wrong branch? - Followup - Use syspref for XSLT and non-XSLT Signed-off-by: Bernardo Gonzalez Kriegel Comment: Applied all patches. Tested with and without XLST display. Works as described. No errors. Not tested with UNIMARC Signed-off-by: Chris Rohde -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 14:18:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 12:18:14 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #63 from Kyle M Hall --- Created attachment 19475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19475&action=edit Bug 7441 - Part 4 - search results showing wrong branch? - Followup - Fix XSLT for option "homebranch" + syspref description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 14:19:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 12:19:00 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #64 from Kyle M Hall --- At some point the patches got out of order. I've reuploaded them in the corrected order and added numbering to the patch titles. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 14:20:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 12:20:05 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 --- Comment #4 from Kyle M Hall --- Test plan from patch: Test plan : - In a framework, make sure you have in item field : An optionnal subfield (without authorised value) then a mandatory subfield then an optional subfield next to mandatory subfield For example : $i (optional), $r (mandatory) and $s (optional) - Open a biblio record and create a new item - Enter more than 100 characters in $i, fill $r and $s - Click "Add item" - Edit this item => You get a textarea for $i - Empty $s and Save => Without patch, you get a warning and form is not saved and you see that $s is yellow while it should be $r => With patch, form is saved - Re-edit this item - Empty $r and save => You get a warning and form is not saved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 14:27:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 12:27:47 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #36 from acowell at daviscollege.edu --- Sorry for the delay, extended holiday break and just getting back into the swing of things. Here's my koha-conf.xml that is working after reverting this patch. 1 ldap://<> DC=<>,DC=<> CN=<>,OU=<>,OU=<>,OU=<>,OU=<>,dc=<>,dc=<> <> 1 1 1 %s
<> <> ------------------------------- To note, we authenticate by using email addresses, so for the userid, I used the userPrincipalName and changed the to %s instead of what most talk about doing %s@<>. I did try the common way of using the sAMAccountName for the userid attribute and using %s at domain.ext for principal_name and that way worked as well. I also started testing under LDAP:// to be able to sniff out the problem, but will be testing under LDAPS://, but don't expect a problem, will update if it doesn't work after testing. Thanks for your attention to this matter! Aaron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 14:37:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 12:37:15 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 acowell at daviscollege.edu changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 15:21:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 13:21:41 +0000 Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 --- Comment #14 from Kyle M Hall --- Created attachment 19476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19476&action=edit Bug 9288 - Add a script to test SIP from the command line - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 15:23:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 13:23:44 +0000 Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #15 from Kyle M Hall --- Galen, is this what you are looking for? I have no idea why strictures weren't enabled, my bad! I've also made the message terminator configurable from the command line, defaulting to CRLF. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 15:26:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 13:26:41 +0000 Subject: [Koha-bugs] [Bug 9411] Multiple uses of javascript eval on ajax responses in acq.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9411 --- Comment #11 from Kyle M Hall --- Since the patch in question doesn't change the behavior of Koha ( at least in theory ) it would be as simple as 1) Perform some action that tests the code to be modified 2) Apply this patch 3) Perform the same action, ensure everything still works the same. What that the action or actions are, is up to you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 15:31:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 13:31:17 +0000 Subject: [Koha-bugs] [Bug 10311] Holds queue ignores item-level holds where only one items exists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10311 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 15:55:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 13:55:11 +0000 Subject: [Koha-bugs] [Bug 10125] Babeltheque star image must use sprite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10125 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- Pushed to master. Thanks Owen and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 16:05:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 14:05:58 +0000 Subject: [Koha-bugs] [Bug 9519] Wrong language code for Italian in the advanced search language limitations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9519 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Sonia! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 16:18:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 14:18:39 +0000 Subject: [Koha-bugs] [Bug 6281] Bug in LCC sort routine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6281 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #20 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 16:20:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 14:20:32 +0000 Subject: [Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #13 from Galen Charlton --- (In reply to Jonathan Druart from comment #10) > (In reply to comment #9) > > (In reply to comment #8) > > > (In reply to comment #6) > > > > I'm still getting failures: > > > > > > Are these tests pass with the master's ut file? > > > > No. Isn't that the point of the patch, that the unit tests should pass even > > if there isn't any data for them? > > Yes of course, but in fact the only data I create is the borrower. So if the > DB contains at least 1 borrower, this patch is useless. That's a little too strong of a requirement, IMO, as I, for one, and I suspect most developers, would like to be able to run the DB-dependent tests in our normal testing databases. I rather suspect what Jared is running into is that his test database already has a patron whose cardnumber is CARDNUMBER42. I think that the requirement that tests should "create their own data" has a more general expression: "tests should make as few assumptions about the state of the database as possible". What this means in this specific case is that the cardnumber for the patron created for this test should be set in such a way as to be guaranteed unique for that test run. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 16:32:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 14:32:11 +0000 Subject: [Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Galen Charlton --- Pushed to master. Thanks, Jonathan! I've also pushed two follow-ups, one to wrap the tests in a transaction and another to remove the hard-coded patron cardnumber, which doesn't need to be set to any specific value for the tests to work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 16:36:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 14:36:25 +0000 Subject: [Koha-bugs] [Bug 10552] New: OpacAddMastheadLibraryPulldown preference missing from OPAC login page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10552 Bug ID: 10552 Summary: OpacAddMastheadLibraryPulldown preference missing from OPAC login page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org If you have the OpacAddMastheadLibraryPulldown system preference enabled the library pulldown does not show on the OPAC login page. The preference is made available by Auth.pm to all other pages in the OPAC but not login. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 16:44:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 14:44:00 +0000 Subject: [Koha-bugs] [Bug 10552] OpacAddMastheadLibraryPulldown preference missing from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10552 --- Comment #1 from Owen Leonard --- Also missing: UseCourseReserves, reviewson, LibraryNameTitle, and OpacShowRecentComments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 16:51:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 14:51:56 +0000 Subject: [Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 --- Comment #15 from Jonathan Druart --- (In reply to Galen Charlton from comment #13) > > Yes of course, but in fact the only data I create is the borrower. So if the > > DB contains at least 1 borrower, this patch is useless. > That's a little too strong of a requirement, IMO, as I, for one, and I > suspect most developers, would like to be able to run the DB-dependent tests > in our normal testing databases. Currently nobody is able to launch them, and the goal is to launch tests with sample data. They don't insert patron, so I think we have to have some prerequisites. > I rather suspect what Jared is running into is that his test database > already has a patron whose cardnumber is CARDNUMBER42. Yes, it was maybe to "generic" :) (In reply to Galen Charlton from comment #14) > Pushed to master. Thanks, Jonathan! > > I've also pushed two follow-ups, one to wrap the tests in a transaction and > another to remove the hard-coded patron cardnumber, which doesn't need to be > set to any specific value for the tests to work. Thanks for the followups! But now tests fail if a borrower exists with a cardnumber == NULL (and I don't have any idea how it's happen, but I got 1 in my DB :)) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 16:52:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 14:52:28 +0000 Subject: [Koha-bugs] [Bug 10552] Several preferences missing from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10552 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OpacAddMastheadLibraryPulld |Several preferences missing |own preference missing from |from OPAC login page |OPAC login page | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 16:55:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 14:55:06 +0000 Subject: [Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 --- Comment #16 from Jonathan Druart --- (In reply to Jonathan Druart from comment #15) > But now tests fail if a borrower exists with a cardnumber == NULL (and I > don't have any idea how it's happen, but I got 1 in my DB :)) Forget that, they pass! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 17:01:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 15:01:48 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #45 from Galen Charlton --- Pushed to master. Thanks, Bernardo and Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 17:10:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 15:10:27 +0000 Subject: [Koha-bugs] [Bug 10522] Javascript error on acquisition pages: YAHOO is not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10522 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 17:17:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 15:17:00 +0000 Subject: [Koha-bugs] [Bug 4907] Suggestions "organize by" menu doesn't reflect current choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4907 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Katrin! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 17:20:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 15:20:14 +0000 Subject: [Koha-bugs] [Bug 10549] ILS-DI should not use ISO-8851-9 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10549 --- Comment #1 from Mirko Tietgen --- Created attachment 19477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19477&action=edit Bug 10549 ILS-DI should not use ISO-8851-9 encoding This patch changes a few occurences of ISO-8859-1 to UTF-8 within the XML generation of the ILS-DI module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 17:25:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 15:25:44 +0000 Subject: [Koha-bugs] [Bug 10448] Changing framework when cataloguing clears all fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10448 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 17:33:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 15:33:57 +0000 Subject: [Koha-bugs] [Bug 10549] ILS-DI should not use ISO-8851-9 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10549 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19477|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Created attachment 19478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19478&action=edit This patch changes a few occurences of ISO-8859-1 to UTF-8 within the XML generation of the ILS-DI module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 17:43:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 15:43:47 +0000 Subject: [Koha-bugs] [Bug 5766] Add configuration for excluding articles from jQuery table sorter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5766 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Owen! However, I agree with Katrin that the translation subsystem isn't necessarily the best place to configure this, for a couple reasons. First, the language of the catalog interface does not necessarily reflect all of the languages that may be present in the bib data, and I can see a translator not getting the point of translating a list of articles in Pootle. I would lean towards either a system preference or even a separate table that contains a list of articles (which would be useful in other contexts, e.g., a bib editor plugin that sets the non-filing indicator automatically). However, since such configuration hooks can readily be put in later, I've decided to push the patch as is. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 17:46:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 15:46:11 +0000 Subject: [Koha-bugs] [Bug 10552] Several preferences missing from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10552 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 17:46:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 15:46:13 +0000 Subject: [Koha-bugs] [Bug 10552] Several preferences missing from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10552 --- Comment #2 from Owen Leonard --- Created attachment 19479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19479&action=edit Bug 10552 - Several preferences missing from OPAC login page Several system preference variables are unavailable to the OPAC login template because they are not explicitly enabled for that page. Instead of adding them to Auth.pm using the old method this patch uses the new system preference check syntax using the Koha TT plugin. The following preferences are now checked using this syntax in masthead.inc: OpacAddMastheadLibraryPulldown UseCourseReserves reviewson OpacShowRecentComments In order for the call in masthead.inc to the new plugin to work on all OPAC pages "[% USE Koha %]" must be added to any template which includes it (most of them). Also in this patch: A change to Auth.pm to enable correct display of the LibraryName in the title of the OPAC login page. To test, turn on the above system preferences and confirm that the relevant links appear under the OPAC's main search bar on all pages including the login page. Confirm that the text specified in the LibraryName system preference is shown as the title of the login page. Confirm that course reserves and comments are displayed correctly on the biblio detail page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 17:48:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 15:48:22 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #36 from Galen Charlton --- (In reply to Kyle M Hall from comment #35) > (In reply to Katrin Fischer from comment #34) > > Should we carry the existing typo to another column? wthdrawn -> wthdrawn_on? > > Yes, absolutely! I think it would be far more confusing to have one field > named correctly and one not. At least this way we have consistency. And, > when I or someone else get around to renaming the wthdrawn column, we can > rename both at once. I can't say I'm keen on a patch that intentionally adds a typo, even for the sake of consistency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 17:50:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 15:50:31 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 --- Comment #37 from Kyle M Hall --- Ok, I'll file a bug to rename wthdrawn, update this patch, and make it depend on the new bug. That should resolve all the issues at once. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 17:51:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 15:51:52 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 17:56:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 15:56:08 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19453|0 |1 is obsolete| | --- Comment #97 from Galen Charlton --- Comment on attachment 19453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19453 Bug 7143: Updating history and about page Pushed latest update to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 17:56:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 15:56:17 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 18:01:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 16:01:23 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 --- Comment #1 from Kyle M Hall --- Created attachment 19480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19480&action=edit Bug 10550 - Fix database typo wthdrawn This patch updates the wthdrawn field in items and deleteditems to be withdrawn instead. No functional changes are made. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 18:01:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 16:01:34 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 18:06:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 16:06:13 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19480|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 19481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19481&action=edit Bug 10550 - Fix database typo wthdrawn This patch updates the wthdrawn field in items and deleteditems to be withdrawn instead. No functional changes are made. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 18:07:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 16:07:26 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10550 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 18:07:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 16:07:26 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9673 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 18:16:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 16:16:28 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #98 from Tom?s Cohen Arazi --- Created attachment 19482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19482&action=edit Bug 7143 - Updating history and about page First commit from Silvia Simonetti, went into the 3.12.x branch. Regards To+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 19:24:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 17:24:33 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19120|0 |1 is obsolete| | --- Comment #38 from Kyle M Hall --- Created attachment 19483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19483&action=edit Bug 9673 - Track when items are marked as lost or withdrawn Add date fields to track when an item was marked as lost or withdrawn. Display those fields on catalogue/moredetail.pl Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a record with items, browse to the 'items' tab ( moredetail.pl ) 4) Mark an item as lost, verify the field "Lost on:" displays below the "Lost status" field with todays date. 5) Mark the item as not lost, verify the field no longer displays 6) Repeat steps 4 and 5 with the Withdrawn field. Signed-off-by: Mathieu Saby Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 19:24:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 17:24:44 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19121|0 |1 is obsolete| | --- Comment #39 from Kyle M Hall --- Created attachment 19484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19484&action=edit Bug 9673 - Track when items are marked as lost or withdrawn - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 19:25:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 17:25:23 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9673 | Depends on| |9673 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 19:25:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 17:25:23 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10550 Depends on|10550 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 19:26:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 17:26:34 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 --- Comment #40 from Kyle M Hall --- Created attachment 19485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19485&action=edit Bug 9673 - Track when items are marked as lost or withdrawn - QA Followup 2 - Change wthdrawn_on to withdrawn_on -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 19:27:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 17:27:29 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10550 | Depends on| |10550 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 19:27:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 17:27:29 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9673 Depends on|9673 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 19:32:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 17:32:30 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19483|0 |1 is obsolete| | --- Comment #41 from Kyle M Hall --- Created attachment 19486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19486&action=edit Bug 9673 - Track when items are marked as lost or withdrawn Add date fields to track when an item was marked as lost or withdrawn. Display those fields on catalogue/moredetail.pl Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a record with items, browse to the 'items' tab ( moredetail.pl ) 4) Mark an item as lost, verify the field "Lost on:" displays below the "Lost status" field with todays date. 5) Mark the item as not lost, verify the field no longer displays 6) Repeat steps 4 and 5 with the Withdrawn field. Signed-off-by: Mathieu Saby Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 19:32:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 17:32:38 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19484|0 |1 is obsolete| | --- Comment #42 from Kyle M Hall --- Created attachment 19487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19487&action=edit Bug 9673 - Track when items are marked as lost or withdrawn - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 19:32:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 17:32:47 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19485|0 |1 is obsolete| | --- Comment #43 from Kyle M Hall --- Created attachment 19488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19488&action=edit Bug 9673 - Track when items are marked as lost or withdrawn - QA Followup 2 - Change wthdrawn_on to withdrawn_on -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 19:38:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 17:38:25 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19486|0 |1 is obsolete| | --- Comment #44 from Kyle M Hall --- Created attachment 19489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19489&action=edit Bug 9673 - Track when items are marked as lost or withdrawn Add date fields to track when an item was marked as lost or withdrawn. Display those fields on catalogue/moredetail.pl Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a record with items, browse to the 'items' tab ( moredetail.pl ) 4) Mark an item as lost, verify the field "Lost on:" displays below the "Lost status" field with todays date. 5) Mark the item as not lost, verify the field no longer displays 6) Repeat steps 4 and 5 with the Withdrawn field. Signed-off-by: Mathieu Saby Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 19:38:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 17:38:37 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19487|0 |1 is obsolete| | Attachment #19488|0 |1 is obsolete| | --- Comment #45 from Kyle M Hall --- Created attachment 19490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19490&action=edit Bug 9673 - Track when items are marked as lost or withdrawn - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 19:41:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 17:41:00 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19489|Bug 9673 - Track when items |[SIGNED-OFF] Bug 9673 - description|are marked as lost or |Track when items are marked |withdrawn |as lost or withdrawn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 20:32:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 18:32:10 +0000 Subject: [Koha-bugs] [Bug 10553] New: Public lists not available from OPAC login page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 Bug ID: 10553 Summary: Public lists not available from OPAC login page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org If as a non-logged-in user you try to access public lists from the lists button on the OPAC login page it will say there are no public lists. In fact the list of public lists is not made available to the login page by Auth.pm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 20:52:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 18:52:45 +0000 Subject: [Koha-bugs] [Bug 10553] Public lists not available from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 20:52:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 18:52:48 +0000 Subject: [Koha-bugs] [Bug 10553] Public lists not available from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 --- Comment #1 from Owen Leonard --- Created attachment 19491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19491&action=edit Bug 10553 - Public lists not available from OPAC login page If you are not logged in to the OPAC, looking at the login page, and you click the Lists button to see public lists it says there are none. This patch corrects Auth.pm so that it loads the list of public lists in this situation. To test you must have at least one public list. Make sure you are logged out of the OPAC and visit the login page (/cgi-bin/koha/opac-user.pl). Clicking the "Lists" button should show you a list of public shelves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 21:31:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 19:31:17 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19490|0 |1 is obsolete| | --- Comment #46 from Kyle M Hall --- Created attachment 19492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19492&action=edit Bug 9673 - Track when items are marked as lost or withdrawn - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 21:34:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 19:34:22 +0000 Subject: [Koha-bugs] [Bug 8186] Form structure problem in serials claims filter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8186 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 5342 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 21:34:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 19:34:22 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #49 from Owen Leonard --- *** Bug 8186 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 23:34:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 21:34:38 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #12 from Jesse Weaver --- Created attachment 19493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19493&action=edit Bug 10320 followup - Fix translation/CSS issues This switches to the alternate method of displaying stars, and makes the strings in the OverDrive JS translatable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 8 23:52:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 21:52:45 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 --- Comment #4 from Jesse Weaver --- Created attachment 19494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19494&action=edit Followup to bug 8133 - fix JS escaping in data literals There was some unescaped data being put into JS literals, which could cause the calendar interface to fail to load. Note for testing: Template::Plugin::JavaScript must be installed, either from CPAN or libtemplate-plugin-javascript-perl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 01:08:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 23:08:02 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 --- Comment #47 from Katrin Fischer --- Should we also be nice and update saved reports using wthdrawn? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 01:09:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jul 2013 23:09:10 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 --- Comment #3 from Katrin Fischer --- Should we also be nice and update saved reports using wthdrawn? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 03:37:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 01:37:36 +0000 Subject: [Koha-bugs] [Bug 10554] New: Add more options to 'AllowSelfCheckReturns' syspref Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554 Bug ID: 10554 Summary: Add more options to 'AllowSelfCheckReturns' syspref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com This patch modifies the options of AllowSelfCheckReturns syspref from a 2 option selection - 'allow patrons', dont allow patrons' to a 3 option selection - 'allow all patrons', 'allow non-blocked patrons' , allow no patrons' currently, a problem with the syspref behavior in Koha is that enabling the 'AllowSelfCheckReturns' syspref does *not* allow patrons with a 'block' to return items via the SCO. (this is apparently by design, and not a bug) however, some libraries do want to allow patrons to return items via the SCO even if they have a 'block' this patch adds this additional behavior, by adding a new option to the syspref, but also retaining the existing syspref behavior after the patch, there are 2 allow options - 'Allow all' allows all patrons to return items (including blocked patrons) - 'Allow non-blocked' allows only non-blocked patrons to return items (note: this is the current 'allow' behavior) the patch correctly 'upgrades' existing 'allow' selection to the new 'Allow non-blocked' value. so, any existing 'allow' selection works as before -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 03:58:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 01:58:07 +0000 Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns' syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554 --- Comment #1 from Mason James --- to test these 3 syspref options... 1/ - set syspref to 'dont allow' - issue an item to a patron - attempt to return item via SCO, return should FAIL 2/ - set syspref to 'allow all' - issue an item to a patron - attempt to return item via SCO, return should SUCCEED 3/ - set syspref to 'allow nonblocked' - issue an item to a patron - attempt to return item via SCO, return should SUCCEED - issue an item to a patron, with a returndate of '2001-01-01' (important: this will create an overdue item, that will put a 'block' on this patron's account) - attempt to return item via SCO, return should FAIL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 04:19:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 02:19:32 +0000 Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns' syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 04:19:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 02:19:35 +0000 Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns' syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554 --- Comment #2 from Mason James --- Created attachment 19495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19495&action=edit Bug 10554 - Add more options to 'AllowSelfCheckReturns' syspref This patch modifies the options of AllowSelfCheckReturns syspref from a 2 option selection - 'allow patrons', dont allow patrons' to a 3 option selection - 'allow all patrons', 'allow non-blocked patrons' , allow no patrons' currently, a problem with the syspref behavior in Koha is that enabling the 'AllowSelfCheckReturns' syspref does *not* allow patrons with a 'block' to return items via the SCO. (this is apparently by design, and not a bug) however, some libraries do want to allow patrons to return items via the SCO even if they have a 'block' this patch adds this additional behavior, by adding a new option to the syspref, but also retaining the existing syspref behavior after the patch, there are 2 allow options - 'Allow all' allows all patrons to return items (including blocked patrons) - 'Allow non-blocked' allows only non-blocked patrons to return items (note: this is the current 'allow' behavior) the patch correctly 'upgrades' existing 'allow' selection to the new 'Allow non-blocked' value. so, any existing 'allow' selection works as before ---------- to test these 3 syspref options... 1/ - set syspref to 'dont allow' - issue an item to a patron - attempt to return item via SCO, return should FAIL 2/ - set syspref to 'allow all' - issue an item to a patron - attempt to return item via SCO, return should SUCCEED 3/ - set syspref to 'allow nonblocked' - issue an item to a patron - attempt to return item via SCO, return should SUCCEED - issue an item to a patron, with a returndate of '2001-01-01' (important: this will create an overdue item, that will put a 'block' on this patron's account) - attempt to return item via SCO, return should FAIL http://bugs.koha-community.org/show_bug.cgi?id=10544 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 04:23:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 02:23:03 +0000 Subject: [Koha-bugs] [Bug 10358] add a syspref to allow BLOCKED patrons to return items, via the SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10358 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Depends on| |10554 Resolution|--- |MOVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 04:23:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 02:23:03 +0000 Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns' syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10358 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 08:23:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 06:23:27 +0000 Subject: [Koha-bugs] [Bug 10553] Public lists not available from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Owen, I haven't tested this, but I think there might be one case where we don't want to show any lists on the login page: when the opac is not public, but requires login for searching. Do you think this could be taken into account? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 10:04:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 08:04:26 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 10:04:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 08:04:29 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18257|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 19496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19496&action=edit bug 10170: expose more managed staged MARC strings to translation This commit makes it possible to translated the 'staged' and 'error' record statuses as well as the 'auto_match' overlay status. Also takes out a bit of HTML cruft in one string that is not needed for translation. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 10:06:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 08:06:06 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #39 from Jonathan Druart --- bug 10522 is pushed to master. This feature can be QAed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 10:22:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 08:22:17 +0000 Subject: [Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |WORKSFORME --- Comment #3 from Jonathan Druart --- Current code looks good to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 11:07:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 09:07:06 +0000 Subject: [Koha-bugs] [Bug 10555] New: overdue_notices -h does not list all options Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10555 Bug ID: 10555 Summary: overdue_notices -h does not list all options Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: mathieu.saby at univ-rennes2.fr perl overdue_notices -h does not list all options. The following options are not listed : -v -list-all -t -date M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 11:51:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 09:51:55 +0000 Subject: [Koha-bugs] [Bug 10556] New: deliverytime is not inserted on adding a supplier Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Bug ID: 10556 Summary: deliverytime is not inserted on adding a supplier Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com To reproduce: On the acquisition home page, add a new vendor, fill some information and the delivery time. Save and edit the same vendor => the delivery time is not kept. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 11:52:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 09:52:03 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 11:52:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 09:52:14 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10528 Depends on| |7291 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 11:52:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 09:52:14 +0000 Subject: [Koha-bugs] [Bug 7291] claims management improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7291 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10556 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 11:52:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 09:52:14 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10556 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 11:55:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 09:55:21 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 11:55:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 09:55:24 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 --- Comment #1 from Jonathan Druart --- Created attachment 19497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19497&action=edit Bug 10556: The delivery time is not inserted on adding a supplier. Test plan: Add/edit a supplier and check that the delivery time is set in DB. Note: This patch cleans the code (sql query) in order to see easily if a problem occurred. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 11:57:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 09:57:55 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 --- Comment #4 from Julian Maurice --- Created attachment 19498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19498&action=edit Bug 2394: Use syspref canreservefromotherbranches in CanItemBeReserved -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 11:58:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 09:58:05 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 12:01:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 10:01:32 +0000 Subject: [Koha-bugs] [Bug 10557] New: GetBooksellersWithLateOrders has an unused branch parameter Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10557 Bug ID: 10557 Summary: GetBooksellersWithLateOrders has an unused branch parameter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 12:01:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 10:01:40 +0000 Subject: [Koha-bugs] [Bug 10557] GetBooksellersWithLateOrders has an unused branch parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10557 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 12:03:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 10:03:38 +0000 Subject: [Koha-bugs] [Bug 10557] GetBooksellersWithLateOrders has an unused branch parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10557 --- Comment #1 from Jonathan Druart --- Created attachment 19499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19499&action=edit Bug 10557: GetBooksellersWithLateOrders has an unused branch parameter C4::Booksellers::GetBooksellersWithLateOrders has an unused parameter. The $branch variable is never used in the routine. Test plan: Check that no behavior changes on the late orders page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 12:04:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 10:04:09 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10557 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 12:04:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 10:04:09 +0000 Subject: [Koha-bugs] [Bug 10557] GetBooksellersWithLateOrders has an unused branch parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10557 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Blocks| |10528 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 12:28:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 10:28:19 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 --- Comment #4 from Kyle M Hall --- I think that's a good and sensible idea! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 12:28:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 10:28:54 +0000 Subject: [Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WORKSFORME |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 12:29:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 10:29:22 +0000 Subject: [Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED --- Comment #4 from Jonathan Druart --- Current code is buggy but the proposed patch does not fix correctly the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 12:29:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 10:29:32 +0000 Subject: [Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|adrien.saurat at biblibre.com |jonathan.druart at biblibre.co | |m Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 12:39:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 10:39:42 +0000 Subject: [Koha-bugs] [Bug 10507] Typo when warning about creating duplicate patron attribute In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10507 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |colin.campbell at ptfs-europe. | |com Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell --- Created attachment 19500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19500&action=edit Proposed patch Fairly trivial patch To Test on a system which includes a unique extended patron attribute Copy or create a patron duplicating the value of the unique attribute without this patch The error message appears as recorded in the bug With this patch the attribute and its value appears instead of 1 e.g. The attribute value MAGICCODE/BOB2 is already is use by another patron record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 12:46:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 10:46:49 +0000 Subject: [Koha-bugs] [Bug 10538] Improve importation of .CSV framework files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Mason, Could you describe the issue? I cannot reproduce, the csv file seems good for the default framework and the acquisition framework. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 12:48:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 10:48:29 +0000 Subject: [Koha-bugs] [Bug 10422] Remove references to unused and non-existent wizard.css In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10422 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19345|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 19501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19501&action=edit Bug 10422 - Remove references to unused and non-existent wizard.css doc-head-close.inc contains a reference to "wizard.css" which doesn't exist. The option to include it never evaluates as true, and that section can be removed from the template. To test, apply the patch and view any page in the staff client. Everything should be styled as before. A search of the Koha source should return no references to "wizard.css" or a "wizard" variable. Signed-off-by: Jonathan Druart No occurrence of "wizard" in pl/pm files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 12:49:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 10:49:19 +0000 Subject: [Koha-bugs] [Bug 10550] Fix database typo wthdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19481|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 19502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19502&action=edit Bug 10550 - Fix database typo wthdrawn This patch updates the wthdrawn field in items and deleteditems to be withdrawn instead. No functional changes are made. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 12:56:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 10:56:37 +0000 Subject: [Koha-bugs] [Bug 10538] Improve importation of .CSV framework files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 --- Comment #4 from Kyle M Hall --- I don't get any error log output, just an import failed message from the browser. Perhaps if you uploaded a pair of framework files for testing, it would help. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 14:01:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 12:01:59 +0000 Subject: [Koha-bugs] [Bug 10553] Public lists not available from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 --- Comment #3 from Owen Leonard --- If OpacPublic is set to make the OPAC not public the lists button does not appear at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 14:18:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 12:18:05 +0000 Subject: [Koha-bugs] [Bug 10507] Typo when warning about creating duplicate patron attribute In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10507 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 14:18:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 12:18:08 +0000 Subject: [Koha-bugs] [Bug 10507] Typo when warning about creating duplicate patron attribute In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10507 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19500|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 19503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19503&action=edit [SIGNED-OFF] Bug 10507 Fix namespace collision in patron entry If a warning about a duplicated patron attribute is returned the value was being passed back for display in the warning message with the same name as the variable in errors as the message is displayed in the context of errors the error value 1 was being displayed not the value duplicated as intended. Pass the value to the template with a unique name Signed-off-by: Owen Leonard I fixed another tiny typo while signing off: "is already in use" instead of "is already is use." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 14:36:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 12:36:45 +0000 Subject: [Koha-bugs] [Bug 10553] Public lists not available from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 --- Comment #4 from Katrin Fischer --- Cool, thx Owen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 15:58:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 13:58:01 +0000 Subject: [Koha-bugs] [Bug 10514] Add item link on acquisitions add item is too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 15:58:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 13:58:04 +0000 Subject: [Koha-bugs] [Bug 10514] Add item link on acquisitions add item is too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19274|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 19504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19504&action=edit Bug 10514 - make the add item link more noticeable when adding items to orders it was so small. People were missing it all the time! To test: create a basket add a record to it scroll down - the link to add item and cancel should both be more prominent now. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 16:00:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 14:00:39 +0000 Subject: [Koha-bugs] [Bug 9539] Make visible "Add" and "Clear" buttons when receiving an document In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9539 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |DUPLICATE --- Comment #4 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 10514 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 16:00:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 14:00:39 +0000 Subject: [Koha-bugs] [Bug 10514] Add item link on acquisitions add item is too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #3 from Jonathan Druart --- *** Bug 9539 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 16:04:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 14:04:14 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 --- Comment #50 from mathieu saby --- I still cannot test it properly, because my VM don't send email, and I don't know how to fix it (and I also have other things to do...) Anybody wants to sign off? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 16:05:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 14:05:55 +0000 Subject: [Koha-bugs] [Bug 7785] MySQL-specific syntax in C4::Members columns() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7785 --- Comment #10 from Jonathan Druart --- Hi Mark, I don't understand the following: + my $sql; + if ( 'mysql,' =~ /$db/ ) { + $sql = 'SELECT * FROM borrowers LIMIT 1;'; + } + else { + $sql = 'SELECT * FROM borrowers;'; + } Why don't you use the LIMIT 1 clause in all cases? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 16:11:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 14:11:10 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 --- Comment #51 from Jonathan Druart --- Mathieu, Unfortunately it seems that acquisition and serial features don't interest many people. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 16:15:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 14:15:05 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 --- Comment #52 from mathieu saby --- Does the sandboxes send mail ? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 16:24:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 14:24:04 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 --- Comment #53 from Jonathan Druart --- (In reply to mathieu saby from comment #52) > Does the sandboxes send mail ? > > Mathieu I don't think so, but you can easily install exim, postfix, mutt, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 16:29:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 14:29:28 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 --- Comment #54 from mathieu saby --- I will try again to install postfix. The pbm was to set it up with my google account, but maybe I did it the wrong way... Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 16:36:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 14:36:00 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 --- Comment #55 from Jonathan Druart --- Sandbox 1 is now configured to send emails. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 16:36:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 14:36:42 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 --- Comment #56 from mathieu saby --- Oh, great! So I try to tet 5342 today -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 16:41:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 14:41:35 +0000 Subject: [Koha-bugs] [Bug 10538] Improve importation of .CSV framework files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 --- Comment #5 from Jonathan Druart --- I confirm I cannot reproduce. Tested with several frameworks. Maybe it would be useful to attach a csv framework file to this report? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 16:45:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 14:45:31 +0000 Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart at biblibre.co | |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 16:49:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 14:49:19 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 --- Comment #57 from mathieu saby --- There is a "+$DBversion = "3.11.00.XXX";" line in your patch. So I suspect it won't apply properly in the sandbox. Could you update it to 3.13 ? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 16:56:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 14:56:38 +0000 Subject: [Koha-bugs] [Bug 10553] Public lists not available from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 17:39:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 15:39:00 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 --- Comment #39 from Galen Charlton --- Update during testing; I discover that the ability to cancel holds from the patron summary (i.e., members/moremember.pl) was broken. A follow-up along the lines of Jonathan's update to circulation.tt fixes it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 17:45:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 15:45:22 +0000 Subject: [Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m Assignee|jonathan.druart at biblibre.co |fridolyn.somers at biblibre.co |m |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 17:46:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 15:46:19 +0000 Subject: [Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14467|0 |1 is obsolete| | --- Comment #5 from Fridolyn SOMERS --- Created attachment 19505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19505&action=edit Proposed new patch Test plan in commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 17:46:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 15:46:28 +0000 Subject: [Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 17:53:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 15:53:23 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #58 from mathieu saby --- I used "test" vendor, with my email adress in contact mail for this vendor. Then I defined a template, I define 3 late issues, and I tried the claiming feature. => I received no mail at all (tried 2 times, with 2 different email adress). Are you sure the sandbox is sending mails? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 17:55:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 15:55:25 +0000 Subject: [Koha-bugs] [Bug 9691] Acquisition's "Statistic" fields not being populated by Asort authorised_value categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9691 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #1 from Colin Campbell --- Are the the fields specified as being linked to ASort1 and ASort2 in the fund (go to administration/budgets/add fund)... If they are it should populate the dropdowns I'd argue this is not very clear to the end user -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 17:56:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 15:56:53 +0000 Subject: [Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 18:02:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 16:02:13 +0000 Subject: [Koha-bugs] [Bug 10496] CCSR theme OPAC tabs to not show correct active state In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10496 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 18:11:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 16:11:25 +0000 Subject: [Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362 --- Comment #6 from mathieu saby --- I did the following test : - 1 book to check in 2 days - 2 books to check in in the past before applying the patch : $perl ../misc/cronjobs/advance_notices.pl -c -n -v -m=2 getting upcoming due issues at ../misc/cronjobs/advance_notices.pl line 203. found 1 issues at ../misc/cronjobs/advance_notices.pl line 205. I changed the value of "-m" : 0, 1, 2, 3, 4 => always 1 issue found (the book to check in in 2 days) after applying the patch $perl ../misc/cronjobs/advance_notices.pl -c -n -v -m=2 found 0 issues for m = 0, 1, 2 => 0 issues $perl ../misc/cronjobs/advance_notices.pl -c -n -v -m=3 found 1 issues for m = 3,4,5 => 1 issues (the book to check in in 2 days) Do you consider it is the expected behavior? If it is so, I can sign off. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 18:30:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 16:30:22 +0000 Subject: [Koha-bugs] [Bug 10558] New: Convert records table in manage-marc-import.pl to ajax DataTable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Bug ID: 10558 Summary: Convert records table in manage-marc-import.pl to ajax DataTable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com Some libraries would like to sort by columns for the records of an import batch. This seems like a good use of ajax DataTables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 18:30:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 16:30:29 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 18:31:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 16:31:23 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #1 from Kyle M Hall --- Created attachment 19506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19506&action=edit WIP - Bug 10558 - Convert records table in manage-marc-import.pl to ajax DataTable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 19:52:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 17:52:14 +0000 Subject: [Koha-bugs] [Bug 10559] New: noisy statement handle still active warnings when generating notices Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10559 Bug ID: 10559 Summary: noisy statement handle still active warnings when generating notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: gmcharlt at gmail.com Running a cronjob that produces notices can generate warning messages like this: $ ./misc/cronjobs/overdue_notices.pl -t -library CPL prepare_cached(SELECT * FROM issues WHERE itemnumber = ?) statement handle DBI::st=HASH(0x54a7828) still Active at C4/Letters.pm line 589 These warnings don't appear to reflect any functionality breakage, but there's no reason to have the noise cluttering up cronjob logs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 19:57:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 17:57:40 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19506|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 19507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19507&action=edit WIP - Bug 10558 - Convert records table in manage-marc-import.pl to ajax DataTable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 20:07:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 18:07:26 +0000 Subject: [Koha-bugs] [Bug 10559] noisy statement handle still active warnings when generating notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10559 --- Comment #1 from Galen Charlton --- Created attachment 19508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19508&action=edit bug 10559: remove spurious "statement handle still active" warnings Generating (e.g.) overdue notices can result in spurious warnings in the cronjob logs: $ ./misc/cronjobs/overdue_notices.pl -t -library CPL prepare_cached(SELECT * FROM issues WHERE itemnumber = ?) statement handle DBI::st=HASH(0x54a7828) still Active at C4/Letters.pm line 589 This patch removes the warning by making sure that the relevant statement handle is finished after fetching its first row of results. To test: [1] Set up an overdue loan such that running overdue_notices.pl will trigger the generation of a notice. [2] Run overdue_notices.pl -t and note the warning message. [3] Apply the patch. [4] Run overdue_notices.pl -t again and note that the warning message is no longer displayed. [5] Check the message_queue table and verify that the overdue notices generated in steps 2 and 4 have the same text. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 20:07:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 18:07:44 +0000 Subject: [Koha-bugs] [Bug 10559] noisy statement handle still active warnings when generating notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10559 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 21:58:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 19:58:39 +0000 Subject: [Koha-bugs] [Bug 10560] New: No way to disable english Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10560 Bug ID: 10560 Summary: No way to disable english Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: chris at bigballofwax.co.nz CC: frederic at tamil.fr If you enable another translation, and disable english, then if you dont have a cookie set, or your browser is not set to that language, you will get english. So you can not disable english in either the staff client or the OPAC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 23:12:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 21:12:13 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 23:41:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 21:41:10 +0000 Subject: [Koha-bugs] [Bug 10560] No way to disable english In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10560 --- Comment #1 from Chris Cormack --- Created attachment 19509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19509&action=edit Bug 10560 - fix the language selection to do the right thing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 9 23:41:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jul 2013 21:41:25 +0000 Subject: [Koha-bugs] [Bug 10560] No way to disable english In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10560 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 02:13:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 00:13:16 +0000 Subject: [Koha-bugs] [Bug 7785] MySQL-specific syntax in C4::Members columns() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7785 --- Comment #11 from M. Tompsett --- "LIMIT 1" is not ANSI SQL, though it does work for other SQL DBs, much more than the SHOW COLUMNS that was there before. I only list "mysql," in my if clause, because I figure those who wish to use a different back-end would also seek to optimize things, and thus patch the if statement. A specific non-"LIMIT 1" example is SQL Server, which uses TOP. Also, Oracle seems to use some sort of rownum() logic. So, there isn't a completely generic way of doing this in a quick fashion, but by generalizing this further and using the db_scheme2dbi in C4::Context, I believe this is a vast improvement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 03:03:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 01:03:16 +0000 Subject: [Koha-bugs] [Bug 10442] Remove references to non-standard "error" class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 --- Comment #8 from Srdjan Jankovic --- > While not strictly within the scope of the bug, unescaped ampersands are a > violation of coding guidelines (invalid HTML) and should be corrected. Even in href? I'm not sure about that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 05:26:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 03:26:41 +0000 Subject: [Koha-bugs] [Bug 10209] The ability to order multiple copies of the same item, from different fund classes, on the same order number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 --- Comment #14 from Srdjan Jankovic --- Amit, it looks to me that you are creating multiple orders, with different ordernumber. Is that what you intended? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 05:44:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 03:44:03 +0000 Subject: [Koha-bugs] [Bug 10490] Overdue fines cap (amount) in circulation rules is saved incorrectly (rounded) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10490 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 05:52:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 03:52:11 +0000 Subject: [Koha-bugs] [Bug 10490] Overdue fines cap (amount) in circulation rules is saved incorrectly (rounded) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10490 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19325|0 |1 is obsolete| | --- Comment #3 from Srdjan Jankovic --- Created attachment 19510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19510&action=edit [SIGNED-OFF] Bug 10490: Overdue fines cap can't store decimal values When overduefinescap was added to the issuingrules the datatype given was decimal. This translates in MySQL to decimal(10,0). This doesn't allow you to store decimal values and therefore values like 4.5 are saved as 5 in the database. To test: On a current installation: 1) Try to enter 4.5 as Overdue fines cap. Verify that the value is not correctly saved. 2) Apply patch and run database update. 3) Try adding/changing an issuing rule setting Overdue fines cap to 4.5 again. 4) Verify the value is saved correctly. Create a new Koha installation from scratch: 1) Verify that the issuingrules table has been created correctly and that you can add/mofidy issuingrules correctly. Because this bug can create data loss, the old database update has also been changed to avoid this problem for people updating at a later point in time. Checkout an older version of Koha pre 3.09.00.027. 1) Run the database updates. 2) Verify again, that adding/modifying issuingrules works correctly. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 05:56:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 03:56:49 +0000 Subject: [Koha-bugs] [Bug 10209] The ability to order multiple copies of the same item, from different fund classes, on the same order number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 --- Comment #15 from Amit --- Yes creating multiple order with different ordernumber. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 06:14:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 04:14:11 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #5 from Srdjan Jankovic --- I don't think // is in order here. Besides, maybe it should check both holdingbranch and homebranch? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 06:18:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 04:18:57 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #2 from Srdjan Jankovic --- I don't think we should put , before values. If the concern is generating additional diff line, adding a , after the last value will fix that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 06:31:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 04:31:24 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #5 from Srdjan Jankovic --- Maybe we should consider putting that function in a separate js while we are at it? Having it tripled does not feel right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 06:38:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 04:38:46 +0000 Subject: [Koha-bugs] [Bug 10527] C4::Branch::get_branch_code_from_name is useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10527 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 06:38:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 04:38:49 +0000 Subject: [Koha-bugs] [Bug 10527] C4::Branch::get_branch_code_from_name is useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10527 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19334|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 19511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19511&action=edit [SIGNED-OFF] Bug 10527: C4::Branch::get_branch_code_from_name is useless This routine is not in used and does not make sense. It should not be used later. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 06:47:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 04:47:05 +0000 Subject: [Koha-bugs] [Bug 10209] The ability to order multiple copies of the same item, from different fund classes, with different order number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The ability to order |The ability to order |multiple copies of the same |multiple copies of the same |item, from different fund |item, from different fund |classes, on the same order |classes, with different |number |order number -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 06:49:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 04:49:43 +0000 Subject: [Koha-bugs] [Bug 10209] The ability to order multiple copies of the same item, from different fund classes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The ability to order |The ability to order |multiple copies of the same |multiple copies of the same |item, from different fund |item, from different fund |classes, with different |classes |order number | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 07:57:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 05:57:30 +0000 Subject: [Koha-bugs] [Bug 10561] New: DisplayOPACiconsXSLT shouldn't control more than icon display Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10561 Bug ID: 10561 Summary: DisplayOPACiconsXSLT shouldn't control more than icon display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au Currently, DisplayOPACiconsXSLT has a description of "On pages displayed with XSLT stylesheets on the OPAC, "show|don't show" icons for itemtype and authorized values." However, that is not its actual behaviour! Turning it on/off does show/hide OPAC icons in the XSLT... However, turning on/off "DisplayOPACiconsXSLT" also displays/hides information on the "Type", "Format", "Literary Form", etc. In other words, lots of valuable information from the fixed fields in the Leader, 006, 007, and/or 008. We should probably be checking $DisplayOPACiconsXSLT each time we go to print an IMG element, rather than encasing that whole block of text inside the $DisplayOPACiconsXSLT flag. We're losing valuable information if we turn off a system preference that is supposed to govern the display of icons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 08:04:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 06:04:58 +0000 Subject: [Koha-bugs] [Bug 10209] The ability to order multiple copies of the same item, from different fund classes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 --- Comment #16 from Srdjan Jankovic --- This won't work for AcqCreateItem 'ordering'. It will create all order items for the last order only. What needs to be done is store ordernumber and quantity from the loop (together with the first values), and use that when calling NewOrderItem(). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 08:05:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 06:05:00 +0000 Subject: [Koha-bugs] [Bug 10561] DisplayOPACiconsXSLT shouldn't control more than icon display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi David, I think that's by design but it has a bad system preference description. The reason to hide the icons was that people don't have the correct information in their data, so the information drawn from the control fields would not be correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 08:07:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 06:07:09 +0000 Subject: [Koha-bugs] [Bug 10562] New: Improve Leader06 Type Labels in MARC21slim2OPACResults.xsl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10562 Bug ID: 10562 Summary: Improve Leader06 Type Labels in MARC21slim2OPACResults.xsl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au Within the $DisplayOPACiconsXSLT block in MARC21slim2OPACResults.xsl, we're mapping fixed field data to non-standard human-readable labels. While I think the non-standard labels we use are far more useful for users than the standard labels supplied by the LoC, I think that ours, at least in the case of position 6 of the Leader, are not entirely accurate. Here are the actual mappings (from http://www.loc.gov/marc/bibliographic/bdleader.html): a - Language material c - Notated music d - Manuscript notated music e - Cartographic material f - Manuscript cartographic material g - Projected medium i - Nonmusical sound recording j - Musical sound recording k - Two-dimensional nonprojectable graphic m - Computer file o - Kit p - Mixed materials r - Three-dimensional artifact or naturally occurring object t - Manuscript language material Below, I show our basic mappings in Koha (plus add my suggestion in brackets behind it) a => Book [Text] c => Score d => Score e => Map f => Map g => Visual Material [Film] i => Sound j => Music k => Visual Material [Picture] m => Computer File o => Kit p => Mixed Materials r => Visual Material [Object] t => Book [Text] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 08:14:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 06:14:55 +0000 Subject: [Koha-bugs] [Bug 10561] DisplayOPACiconsXSLT shouldn't control more than icon display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10561 --- Comment #2 from David Cook --- (In reply to Katrin Fischer from comment #1) > Hi David, I think that's by design but it has a bad system preference > description. The reason to hide the icons was that people don't have the > correct information in their data, so the information drawn from the control > fields would not be correct. Ahhh, if that's the case, I don't mind humbly withdrawing this bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 08:22:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 06:22:23 +0000 Subject: [Koha-bugs] [Bug 9691] Acquisition's "Statistic" fields not being populated by Asort authorised_value categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9691 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi David and Colin, I can try and explain a bit more. In the past, it worked like David described and only Asort1 and Asort2 could be used, so we were limited to 2 categories for all funds. Now you tie the authorised value to the fund (as Colin said). That means that you can decide for each fund which list of authorized values to use for the statistic fields. So now you can still tie asort1 and asort2 to the fund, but you can also create your own and they will work as well or use the fields for free text input. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 08:25:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 06:25:20 +0000 Subject: [Koha-bugs] [Bug 9691] Acquisition's "Statistic" fields not being populated by Asort authorised_value categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9691 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from Katrin Fischer --- Talked to David on IRC - closing this :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 08:28:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 06:28:32 +0000 Subject: [Koha-bugs] [Bug 10561] DisplayOPACiconsXSLT shouldn't control more than icon display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10561 --- Comment #3 from David Cook --- (In reply to David Cook from comment #2) > (In reply to Katrin Fischer from comment #1) > > Hi David, I think that's by design but it has a bad system preference > > description. The reason to hide the icons was that people don't have the > > correct information in their data, so the information drawn from the control > > fields would not be correct. > > Ahhh, if that's the case, I don't mind humbly withdrawing this bug report. Or perhaps I'll fix up the syspref description at some point as per Katrin's suggestion on IRC ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 08:35:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 06:35:03 +0000 Subject: [Koha-bugs] [Bug 10563] New: Link to edit subscription from 'check expiraton' page is broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10563 Bug ID: 10563 Summary: Link to edit subscription from 'check expiraton' page is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de CC: colin.campbell at ptfs-europe.com To test: Find subscriptions using the 'Check expiration' search and try using the 'edit' links from there. "mod" in the link should be "modify" to make this work correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 08:45:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 06:45:48 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 --- Comment #6 from Julian Maurice --- (In reply to Srdjan Jankovic from comment #5) > I don't think // is in order here. Besides, maybe it should check both > holdingbranch and homebranch? And allow reserve if one of those is the user's branch ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 09:00:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 07:00:13 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 --- Comment #7 from Srdjan Jankovic --- Yes. But maybe we should consult whoever introduced canreservefromotherbranches. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 09:14:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 07:14:57 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 --- Comment #3 from Jonathan Druart --- I do it for readability. Like that, we are sure there is no missing comma at the end of lines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 09:19:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 07:19:55 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 --- Comment #6 from Fridolyn SOMERS --- > Maybe we should consider putting that function in a separate js while we are at it? Having it tripled does not feel right. It is only double and it is quite short. In acquisition there is a template condition : [% IF (AcqCreateItemReceiving) %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 09:26:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 07:26:18 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 --- Comment #8 from Julian Maurice --- (In reply to Srdjan Jankovic from comment #7) > Yes. But maybe we should consult whoever introduced > canreservefromotherbranches. This seems to be Chris Cormack commit e30fb761ec225a7797def0c3ab8d2d8bceea7e0c Author: Chris Cormack AuthorDate: Tue Nov 13 21:07:45 2007 -0600 Commit: Joshua Ferraro CommitDate: Tue Nov 13 21:24:23 2007 -0600 Adding a system pref so you can stop users from reserving items that dont belong at their branch Signed-off-by: Chris Cormack Signed-off-by: Joshua Ferraro -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 09:44:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 07:44:48 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 --- Comment #9 from Chris Cormack --- (In reply to Julian Maurice from comment #8) > (In reply to Srdjan Jankovic from comment #7) > > Yes. But maybe we should consult whoever introduced > > canreservefromotherbranches. > > This seems to be Chris Cormack > > commit e30fb761ec225a7797def0c3ab8d2d8bceea7e0c > Author: Chris Cormack > AuthorDate: Tue Nov 13 21:07:45 2007 -0600 > Commit: Joshua Ferraro > CommitDate: Tue Nov 13 21:24:23 2007 -0600 > > Adding a system pref so you can stop users from reserving items that > dont belong at their branch > > Signed-off-by: Chris Cormack > Signed-off-by: Joshua Ferraro Ouch, what a horrible chapter in my life :( The original spec was you couldn't reserve things that didn't have the homebranch (where an item belongs) of your borrowers branch. It didn't care what the holdingbranch (where the item is) was. It just only cared about the homebranch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 09:56:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 07:56:39 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 --- Comment #10 from Julian Maurice --- (In reply to Chris Cormack from comment #9) > > Ouch, what a horrible chapter in my life :( > > The original spec was you couldn't reserve things that didn't have the > homebranch (where an item belongs) of your borrowers branch. It didn't care > what the holdingbranch (where the item is) was. It just only cared about the > homebranch. Do you think we should only check against homebranch? Doesn't IndependantBranches syspref imply that homebranch = holdingbranch anyway? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 09:59:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 07:59:00 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 --- Comment #11 from Chris Cormack --- (In reply to Julian Maurice from comment #10) > (In reply to Chris Cormack from comment #9) > > > > Ouch, what a horrible chapter in my life :( > > > > The original spec was you couldn't reserve things that didn't have the > > homebranch (where an item belongs) of your borrowers branch. It didn't care > > what the holdingbranch (where the item is) was. It just only cared about the > > homebranch. > > Do you think we should only check against homebranch? > Doesn't IndependantBranches syspref imply that homebranch = holdingbranch > anyway? It should but it may not be, someone may have transferred one, or manually changed the holding branch. The important part is that this syspref is designed to only care about where the book belongs (homebranch) not where it is (holdingbranch) You can extend it to check the holdingbranch too if you like, but that is certainly a different use case for which it was designed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 10:05:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 08:05:31 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #59 from Jonathan Druart --- (In reply to mathieu saby from comment #58) > I used "test" vendor, with my email adress in contact mail for this vendor. > Then I defined a template, I define 3 late issues, and I tried the claiming > feature. > => I received no mail at all > > (tried 2 times, with 2 different email adress). > > Are you sure the sandbox is sending mails? Yes, it is. In fact sendmail raises an error if no address is defined for the logged in user. Maybe this error could be catch in order to display a warning message instead of a confirm message. I will submit a followup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 10:06:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 08:06:13 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 --- Comment #60 from Jonathan Druart --- Created attachment 19512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19512&action=edit Bug 5342: Catch errors raise by sendmail For example, Mail::Sendmail can raise an error if no 'From' address if defined. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 10:24:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 08:24:06 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 --- Comment #12 from Julian Maurice --- Created attachment 19513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19513&action=edit Bug 2394: Use syspref canreservefromotherbranches [Follow up] Check only against item's homebranch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 10:24:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 08:24:45 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 --- Comment #13 from Julian Maurice --- I don't want to introduce a new behaviour, just want to make it work ;) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 11:06:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 09:06:16 +0000 Subject: [Koha-bugs] [Bug 10564] New: use OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10564 Bug ID: 10564 Summary: use OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: fridolyn.somers at biblibre.com When using UNIMARC XSLT for OPAC detail page, if record has a 856$u its content is displayed as a link. The syspref OPACURLOpenInNewWindow adds the option of opening in a new window (attribute target="_blank"). 856$u is also used in UNIMARC results XSLT but the use of OPACURLOpenInNewWindow syspref is missing. It exists for MARC21. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 11:13:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 09:13:53 +0000 Subject: [Koha-bugs] [Bug 10564] use OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10564 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 19514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19514&action=edit Proposed patch Test plan in commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 11:13:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 09:13:58 +0000 Subject: [Koha-bugs] [Bug 10564] use OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10564 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 13:53:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 11:53:24 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 13:53:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 11:53:27 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19507|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 19515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19515&action=edit Bug 10558 - Convert records table in manage-marc-import.pl to ajax DataTable Some libraries would like to sort by columns for the records of an import batch. This seems like a good use of ajax DataTables. Test plan: 1) Apply this patch 2) Import a record batch into Koha a) Use some form of matching b) Have some records that will match and some that won't c) Have at least 30 records so you can test the pager 3) Verify the new table is functionally equivilent to the old static one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 14:13:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 12:13:16 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19515|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 19516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19516&action=edit Bug 10558 - Convert records table in manage-marc-import.pl to ajax DataTable Some libraries would like to sort by columns for the records of an import batch. This seems like a good use of ajax DataTables. Test plan: 1) Apply this patch 2) Import a record batch into Koha a) Use some form of matching b) Have some records that will match and some that won't c) Have at least 30 records so you can test the pager 3) Verify the new table is functionally equivilent to the old static one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 14:23:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 12:23:21 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 14:23:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 12:23:41 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 jonathan.druart at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #95 from jonathan.druart at biblibre.com --- Patch tested with a sandbox, by sandbox8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 14:24:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 12:24:05 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 jonathan.druart at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18971|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 14:24:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 12:24:12 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 jonathan.druart at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18972|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 14:35:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 12:35:17 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19516|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 19517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19517&action=edit Bug 10558 - Convert records table in manage-marc-import.pl to ajax DataTable Some libraries would like to sort by columns for the records of an import batch. This seems like a good use of ajax DataTables. Test plan: 1) Apply this patch 2) Import a record batch into Koha a) Use some form of matching b) Have some records that will match and some that won't c) Have at least 30 records so you can test the pager 3) Verify the new table is functionally equivilent to the old static one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 14:35:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 12:35:34 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #96 from sandboxes at biblibre.com --- Patch tested with a sandbox, by sandbox8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 14:36:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 12:36:28 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18972|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 14:36:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 12:36:32 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18971|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 14:37:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 12:37:52 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #97 from sandboxes at biblibre.com --- Patch tested with a sandbox, by sandbox8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 14:38:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 12:38:14 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18971|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 14:38:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 12:38:20 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18972|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 14:38:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 12:38:28 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #98 from Paul Poulain --- Created attachment 19518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19518&action=edit Bug 7143: Updating history and about page Signed-off-by: Galen Charlton Signed-off-by: <> Signed-off-by: name Signed-off-by: sandbox8 Signed-off-by: sandbox8 Signed-off-by: sandbox8 http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: sandbox8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 14:38:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 12:38:32 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #99 from Paul Poulain --- Created attachment 19519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19519&action=edit Bug 10496 - CCSR theme OPAC tabs to not show correct active state When jQueryUI was updated in the CCSR theme the corresponding CSS changes were not copied over at the same time, causing style problems with jQueryUI widgets. This patch makes the necessary changes. To test, apply the patch, clear your browser cache, and view any page which uses jQueryUI tabs (advanced search, bibliographic detail page). Tabs should look correct and correctly show which tab is active. Signed-off-by: Nicole C. Engard Signed-off-by: Katrin Fischer CSS changes only. Confirmed problem in CCSR OPAC templates. Tested advanced search and detail pages in CCSR and prog. In order to fully test advanced search I added location and collection to AdvancedSearchTypes. Also tested the branch tooltip as I spotted some CSS added for that. Works beautifully, no problems found. Signed-off-by: Galen Charlton Signed-off-by: <> Signed-off-by: name Signed-off-by: sandbox8 Signed-off-by: sandbox8 Signed-off-by: sandbox8 Signed-off-by: sandbox8 http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: sandbox8 Signed-off-by: sandbox8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 14:39:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 12:39:03 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC|m.de.rooy at rijksmuseum.nl | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 14:51:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 12:51:29 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19517|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 19520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19520&action=edit Bug 10558 - Convert records table in manage-marc-import.pl to ajax DataTable Some libraries would like to sort by columns for the records of an import batch. This seems like a good use of ajax DataTables. Test plan: 1) Apply this patch 2) Import a record batch into Koha a) Use some form of matching b) Have some records that will match and some that won't c) Have at least 30 records so you can test the pager 3) Verify the new table is functionally equivilent to the old static one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 15:12:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 13:12:22 +0000 Subject: [Koha-bugs] [Bug 10565] New: Add a "Patron List" feature for storing and manipulating collections of patrons Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Bug ID: 10565 Summary: Add a "Patron List" feature for storing and manipulating collections of patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Some libraries would like to create lists of patrons for later manipulation. This will involve create a "Patron List" system similar in some ways to the existing Lists feature for records. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 15:12:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 13:12:31 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 15:13:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 13:13:13 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10565 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 15:13:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 13:13:13 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8798 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 15:30:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 13:30:48 +0000 Subject: [Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362 --- Comment #7 from Fridolyn SOMERS --- Reply to Comment 6 : Yes I think it is the expected behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 15:50:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 13:50:40 +0000 Subject: [Koha-bugs] [Bug 10566] New: Improve OPAC course reserves pages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10566 Bug ID: 10566 Summary: Improve OPAC course reserves pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org The new course reserves pages could use some improvements: More specific titles, improved labeling, other markup enhancements. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 15:54:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 13:54:48 +0000 Subject: [Koha-bugs] [Bug 10567] New: suppress a branch Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10567 Bug ID: 10567 Summary: suppress a branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com CC: gmcharlt at gmail.com It would be great if there were a way to set up a branch to be a 'private' branch or one that only the staff could see. This would mean suppressing items, facets, any option for that branch in the search or in the holds form or anywhere in the OPAC. A simple 'is this branch public' on the libraries & groups admin page could control this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 15:58:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 13:58:52 +0000 Subject: [Koha-bugs] [Bug 10566] Improve OPAC course reserves pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10566 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 15:58:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 13:58:54 +0000 Subject: [Koha-bugs] [Bug 10566] Improve OPAC course reserves pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10566 --- Comment #1 from Owen Leonard --- Created attachment 19521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19521&action=edit Bug 10566 - Improve OPAC course reserves pages This patch makes various improvements to the OPAC course reserve pages: - Descriptive page titles for both pages. - More compact display of course information on course detail page (a list instead of a table, consistent with other displays of similar information in Koha). - Correct capitalization. - Added label and fieldset to course reserve search form. - Added breadcrumb navigatio nto course reserve detail page as a path back to course reserves main page. To test, apply the patch and confirm that the changes haven't broken anything and are an improvement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 16:06:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 14:06:17 +0000 Subject: [Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from mathieu saby --- It seems logical, and can probably explain some problem we encountered in Rennes 2 :some patrons complain they receive unwanted predue notice. We thought they were wrong, but maybe they are not... I sign off. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 16:09:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 14:09:25 +0000 Subject: [Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19505|0 |1 is obsolete| | --- Comment #9 from mathieu saby --- Created attachment 19522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19522&action=edit [PATCH][SIGNED OFF] Bug 9362 - Wrong query in GetUpcomingDueIssues Test described in patch comment M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 16:22:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 14:22:58 +0000 Subject: [Koha-bugs] [Bug 7518] searches with quotation marks don't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7518 --- Comment #32 from Fridolyn SOMERS --- This is still a bug in current master : - with or without ICU - with or without UseQueryParser syspref - only with QueryWeightFields enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 16:38:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 14:38:20 +0000 Subject: [Koha-bugs] [Bug 7518] searches with quotation marks don't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7518 --- Comment #33 from mathieu saby --- That's puzzling... Some months ago I was sure it was fixed. So you think a patch is still needed ? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 16:40:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 14:40:08 +0000 Subject: [Koha-bugs] [Bug 10568] New: way to vote for purchase suggestions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10568 Bug ID: 10568 Summary: way to vote for purchase suggestions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com It would be cool if libraries that has public purchase suggestions could also enable a way for people to vote for suggestions. So if I suggest the library buy the Koha manual others can come in and say 'like' or something and let the library know that lots of people want the Koha manual. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 16:40:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 14:40:29 +0000 Subject: [Koha-bugs] [Bug 10401] Add ability to merge invoices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10401 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch Depends on| |10403 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 16:40:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 14:40:29 +0000 Subject: [Koha-bugs] [Bug 10403] Add ability to set fund/budget on receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10403 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10401 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 16:40:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 14:40:32 +0000 Subject: [Koha-bugs] [Bug 10401] Add ability to merge invoices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10401 --- Comment #1 from Jared Camins-Esakov --- Created attachment 19523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19523&action=edit Bug 10401: Add ability to merge invoices Given how easy it is to accidentally receive items from one invoice on multiple invoices, the ability to merge invoices can be quite handy. This patch adds that ability to Koha's Acquisitions module. To test: 1) Apply patch. 2) Run unit test: > prove t/db_dependent/Acquisition/Invoices.t 3) Create two invoices from the same vendor for merging, and receive at least one order on each. 4) Do a search on the Invoices page that brings up both the invoices you created. 5) Check the boxes next to the two invoices. 6) Click "Merge selected invoices." 7) Choose which invoice you want to keep (the default will be the first). 8) Click "Merge." 9) Confirm that the resulting invoice has all the orders you received listed on it. 10) Sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 16:40:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 14:40:44 +0000 Subject: [Koha-bugs] [Bug 10403] Add ability to set fund/budget on receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10403 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10401 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 16:40:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 14:40:44 +0000 Subject: [Koha-bugs] [Bug 10401] Add ability to merge invoices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10401 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10403 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 16:54:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 14:54:54 +0000 Subject: [Koha-bugs] [Bug 10356] adding date published to catalogue detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10356 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Chris! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 17:07:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 15:07:56 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- (In reply to Fridolyn SOMERS from comment #6) > > Maybe we should consider putting that function in a separate js while we are at it? Having it tripled does not feel right. > It is only double and it is quite short. In acquisition there is a template > condition : [% IF (AcqCreateItemReceiving) %] No, there are three: serials-edit.tt includes a version of that same check; the serials receiving form should be checked to see whether the same bug applies there as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 17:15:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 15:15:26 +0000 Subject: [Koha-bugs] [Bug 7785] MySQL-specific syntax in C4::Members columns() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7785 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #12 from Galen Charlton --- Another option to throw in the mix: http://search.cpan.org/~ribasushi/DBIx-Class-0.08250/lib/DBIx/Class/ResultSource.pm#columns Once DBIX::Class support is pushed, unless it performs horribly, this is likely preferable to rolling our own. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 17:40:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 15:40:06 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- (In reply to Jonathan Druart from comment #3) > I do it for readability. Like that, we are sure there is no missing comma at > the end of lines. I for one don't find that it improves readability, and running "egrep -r '^\s+,' ." indicates that it isn't commonly used in the codebase. Opinions may differ, of course, and you're free to propose stylistic changes. >From my POV, though, that sort of stylistic change really ought to be in a separate patch from the one that actually fixes the bug, for reasons similar to what is expressed in the PERL6 coding guideline. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 17:42:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 15:42:41 +0000 Subject: [Koha-bugs] [Bug 10422] Remove references to unused and non-existent wizard.css In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10422 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 17:50:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 15:50:52 +0000 Subject: [Koha-bugs] [Bug 10548] koha_perl_deps.pl miscounts dependencies displayed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10548 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19442|0 |1 is obsolete| | --- Comment #2 from Galen Charlton --- Created attachment 19524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19524&action=edit bug 10548: fix count of missing required dependencies by koha_perl_deps.pl To test: [1] ./koha_perl_deps.pl -m -u If you have nothing missing, uninstall an optional component. [2] ./koha_perl_deps.pl -m -u You should get a number missing of at least 1. [3] ./koha_perl_deps.pl -m -u -r You should get the same number, even though the output is less. [4] Apply patch [5] ./koha_perl_deps.pl -m -u Same results as in step 2. [6] ./koha_perl_deps.pl -m -u -r The number should differ from the results in step 3. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 17:50:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 15:50:48 +0000 Subject: [Koha-bugs] [Bug 10548] koha_perl_deps.pl miscounts dependencies displayed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10548 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 18:22:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 16:22:34 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #2 from Galen Charlton --- There are two other places in C4/Members.pm that calculate and add the enrollment fee. Time for a new function rather than copy-pasta. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 18:40:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 16:40:38 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #7 from Owen Leonard --- Created attachment 19525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19525&action=edit Bug 10558 [Follow-up] Convert records table in manage-marc-import.pl to ajax DataTable This patch makes improvements to the default DataTables CSS and corrects a couple of errors in the original patch. CSS for the "full numbers" type pagination, used by this and the quotes editor, has been cleaned up and made more visually consistent with the brief pagination style. Also changed: - removed some hard-coded paths containing "http://staff.kohadev..." - Added a column header to the column showing record match details. This provides both information and a clearer target for clicking to resort - Expanding the default table pager controls for this page and the quotes editor (for consistency) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 18:47:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 16:47:20 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19520|0 |1 is obsolete| | --- Comment #8 from Owen Leonard --- Created attachment 19526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19526&action=edit [SIGNED-OFF] Bug 10558 - Convert records table in manage-marc-import.pl to ajax DataTable Some libraries would like to sort by columns for the records of an import batch. This seems like a good use of ajax DataTables. Test plan: 1) Apply this patch 2) Import a record batch into Koha a) Use some form of matching b) Have some records that will match and some that won't c) Have at least 30 records so you can test the pager 3) Verify the new table is functionally equivilent to the old static one Signed-off-by: Owen Leonard Tests fine and looks good with the exception of the corrections I put in a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 19:06:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 17:06:05 +0000 Subject: [Koha-bugs] [Bug 9298] default patron privacy option not in use? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9298 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #7 from Melia Meggs --- Yep, let's close. I think the questions were answered and manual updated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 19:59:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 17:59:27 +0000 Subject: [Koha-bugs] [Bug 7785] MySQL-specific syntax in C4::Members columns() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7785 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19285|0 |1 is obsolete| | --- Comment #13 from M. Tompsett --- Created attachment 19527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19527&action=edit Pure ANSI SQL code to replace MySQLism I realized that a WHERE 1=0 still works for the STH method, and thus doesn't need any other checks. It will always work. :) I still have to consider the DBIx case, as gmcharlt pointed out, but this should be good in the mean time. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 21:14:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 19:14:51 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #65 from Katrin Fischer --- I'd like to suggest changing the 'magical numbers' into easier understandable codes. Also I would suggest renaming the status a bit: - New - On order - Partially received - Received - Cancelled - (Completed could later be used for closed and paid invoices maybe) Not sure about the codes to use best, so this is more for the descriptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 21:24:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 19:24:02 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #66 from Katrin Fischer --- Jonathan, could you take a look at the my comments before I proceed here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 21:39:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 19:39:25 +0000 Subject: [Koha-bugs] [Bug 10569] New: Course reserves do not show on OPAC detail page if OpacSeparateHoldings is in effect Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10569 Bug ID: 10569 Summary: Course reserves do not show on OPAC detail page if OpacSeparateHoldings is in effect Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org If OpacSeparateHoldings is enabled and affects the display of a title on a course reserves list, the course reserves column does not appear in the holdings table on opac-detail. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 21:39:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 19:39:41 +0000 Subject: [Koha-bugs] [Bug 10569] Course reserves do not show on OPAC detail page if OpacSeparateHoldings is in effect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10569 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 21:53:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 19:53:53 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 --- Comment #26 from Jared Camins-Esakov --- Created attachment 19528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19528&action=edit Bug 10240 follow-up: don't delete transactions if auth fails When uploading transactions, we were not checking that authentication had succeeded before deleting the transactions from the local database. That was bad. With this patch, we check. That is good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 22:46:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 20:46:29 +0000 Subject: [Koha-bugs] [Bug 10563] Link to edit subscription from 'check expiraton' page is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 22:46:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 20:46:31 +0000 Subject: [Koha-bugs] [Bug 10563] Link to edit subscription from 'check expiraton' page is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10563 --- Comment #1 from Katrin Fischer --- Created attachment 19529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19529&action=edit Bug 10563: Fix broken 'Edit' link on check expiration page This fixes the broken 'Edit' (subscription) link on the check expiration page in serials. To test: - Add a subscription - Go to the check expiration page - Search for your subscription, use an expiration date in the far future - Verify the edit link on the result list doesn't work right before applying the patch, but works after -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 22:48:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 20:48:58 +0000 Subject: [Koha-bugs] [Bug 10570] New: Show internal note from subscription in results on check expiration page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10570 Bug ID: 10570 Summary: Show internal note from subscription in results on check expiration page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de CC: colin.campbell at ptfs-europe.com We are showing the OPAC note from the subscription, but we should also show the internal note in the result list on the check expiration page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 22:49:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 20:49:21 +0000 Subject: [Koha-bugs] [Bug 10563] Link to edit subscription from 'check expiraton' page is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10563 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 23:07:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 21:07:37 +0000 Subject: [Koha-bugs] [Bug 10570] Show internal note from subscription in results on check expiration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10570 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 23:07:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 21:07:40 +0000 Subject: [Koha-bugs] [Bug 10570] Show internal note from subscription in results on check expiration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10570 --- Comment #1 from Katrin Fischer --- Created attachment 19530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19530&action=edit Bug 10570: Show nonpublic note on check expiration page The check expiration page in serials only showed the OPAC note, but it makes sense to also show the nonpublic note here. This patch adds it. To test: - Add a subscription, make sure to enter different notes in nonpublic note and OPAC note to check for display later on. - Go to the check expiration page and search for your subscription. - Check both notes show up correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 23:08:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 21:08:00 +0000 Subject: [Koha-bugs] [Bug 10570] Show internal note from subscription in results on check expiration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10570 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 23:30:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 21:30:28 +0000 Subject: [Koha-bugs] [Bug 10514] Add item link on acquisitions add item is too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Created attachment 19531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19531&action=edit screenshot Hi Liz, I totally agree that we need the links to stand out more, but I am not sold on the idea to make the font bigger. With the CSS in the top of the page it's also hard to change it back if you wanted to. Maybe we could use buttons? Another problem I spotted while looking at this bit of code: as it stands right now, those links are not translatable! It's a problem before and after your patch and can go onto another bug. But if you want to try - using a concatenated Javascript string with _() in the right place should fix it. But failing for wrong capitalization - sorry! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 23:36:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 21:36:23 +0000 Subject: [Koha-bugs] [Bug 10549] ILS-DI should not use ISO-8851-9 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10549 --- Comment #3 from Katrin Fischer --- Mirko, we are missing a test plan ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 23:42:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 21:42:36 +0000 Subject: [Koha-bugs] [Bug 10549] ILS-DI should not use ISO-8851-9 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10549 --- Comment #4 from Katrin Fischer --- Giving it a try anyway ... :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 10 23:55:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 21:55:36 +0000 Subject: [Koha-bugs] [Bug 10549] ILS-DI should not use ISO-8851-9 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10549 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 00:10:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 22:10:37 +0000 Subject: [Koha-bugs] [Bug 10549] ILS-DI should not use ISO-8851-9 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10549 --- Comment #5 from Katrin Fischer --- Created attachment 19532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19532&action=edit [SIGNED OFF] ILS-DI should not use ISO-8851-9 encoding This patch changes a few occurences of ISO-8859-1 to UTF-8 within the XML generation of the ILS-DI module. http://bugs.koha-community.org/show_bug.cgi?id=10549 Signed-off-by: Katrin Fischer To test: - Activate ILS-DI system preference - Go to [youropac]/cgi-bin/koha/ilsdi.pl - Check all examples in the documentation for the correct encoding - Check GetAvailability gives you the correct encoding and check the source for the correct encoding -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 00:11:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 22:11:49 +0000 Subject: [Koha-bugs] [Bug 10549] ILS-DI should not use ISO-8851-9 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10549 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 00:11:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 22:11:52 +0000 Subject: [Koha-bugs] [Bug 10549] ILS-DI should not use ISO-8851-9 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10549 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19478|0 |1 is obsolete| | Attachment #19532|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 19533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19533&action=edit [SIGNED OFF] ILS-DI should not use ISO-8851-9 encoding This patch changes a few occurences of ISO-8859-1 to UTF-8 within the XML generation of the ILS-DI module. http://bugs.koha-community.org/show_bug.cgi?id=10549 Signed-off-by: Katrin Fischer To test: - Activate ILS-DI system preference - Go to [youropac]/cgi-bin/koha/ilsdi.pl - Check all examples in the documentation for the correct encoding - Check GetAvailability gives you the correct encoding and check the source for the correct encoding -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 00:13:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 22:13:27 +0000 Subject: [Koha-bugs] [Bug 10567] suppress a branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10567 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I like this idea. I have been thinking on how to deal with the library accounts, record and items for ILL in installations with multiple branches - a hidden branch might be useful here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 00:54:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 22:54:37 +0000 Subject: [Koha-bugs] [Bug 7785] MySQL-specific syntax in C4::Members columns() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7785 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 00:54:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 22:54:43 +0000 Subject: [Koha-bugs] [Bug 7785] MySQL-specific syntax in C4::Members columns() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7785 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19527|0 |1 is obsolete| | --- Comment #14 from Tom?s Cohen Arazi --- Created attachment 19534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19534&action=edit Bug 7785 - MySQL-specific syntax in C4::Members columns() The initial thought was to remove this function. However, tools/import_borrowers.pl uses it. So rather than remove it to solve the problem, it was reworked to a more generic solution which runs faster. By accessing $sth->{NAME} directly, the driver becomes responsible for filling it correctly. This happens when a SELECT is done on the borrowers table. It does not even have to have data in the result set! The columns method could be more generic and used elsewhere too. Comparison between the old method and the STH method showed a difference of 35 seconds for 40k iterations versus 19 seconds for the same amount of iterations on regardless of the size of the borrowers table. Signed-off-by: Tomas Cohen Arazi The patch itself removes the mysql-ism and works as expected. I agree with Galen that we shouldn't be doing this ad-hoc and the introduction of DBIx would be the best solution (modulo performance issues). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 01:21:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 23:21:19 +0000 Subject: [Koha-bugs] [Bug 10567] suppress a branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10567 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #2 from Liz Rea --- I like this too - it would be a good feature. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 01:44:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jul 2013 23:44:20 +0000 Subject: [Koha-bugs] [Bug 9833] New virtual shelves/lists permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #8 from Liz Rea --- Marcel, I'm confused by the status of this patch - there's a signed off patch but it's failed QA? I came up against this today, it would be super cool to get this little nagger fixed. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 02:53:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 00:53:34 +0000 Subject: [Koha-bugs] [Bug 10571] New: IntranetBiblioDefaultView doesn't do anything with MARC21 XSLT Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10571 Bug ID: 10571 Summary: IntranetBiblioDefaultView doesn't do anything with MARC21 XSLT Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: jcamins at cpbibliography.com CC: gmcharlt at gmail.com IntranetBiblioDefaultView is not respected by the the MARC21 results XSLT stylesheet. It probably should be, considering that the syspref rather strongly implies that it should impact links in the results view. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 02:57:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 00:57:09 +0000 Subject: [Koha-bugs] [Bug 10571] IntranetBiblioDefaultView doesn't do anything with MARC21 XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10571 --- Comment #1 from Jared Camins-Esakov --- Actually, I can find no evidence that the syspref does anything at all. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 03:41:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 01:41:54 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 --- Comment #14 from Srdjan Jankovic --- I think it is 'IndependentBranches' -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 03:58:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 01:58:03 +0000 Subject: [Koha-bugs] [Bug 10515] The prototype for GetBranchCategory and GetBranchCategories is not consistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10515 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 03:58:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 01:58:06 +0000 Subject: [Koha-bugs] [Bug 10515] The prototype for GetBranchCategory and GetBranchCategories is not consistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10515 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19275|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 19535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19535&action=edit [SIGNED-OFF] Bug 10515: The prototype for GetBranchCategory and GetBranchCategories is not consistent The prototype is not consistent, GetBranchCategory should return only 1 result and GetBranchCategories should not have a categorycode argument. This patch fixes that. Test plan: 1/ Try to add/remove/modify a library. 2/ Add some groups 3/ Add these groups to a library Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 04:10:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 02:10:24 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #2 from Srdjan Jankovic --- t/db_dependent/Branch.t .. 1/31 # Failed test 'CAT1 details are right' # at t/db_dependent/Branch.t line 170. # Structures begin differing at: # $got = ARRAY(0x28b3028) # $expected = HASH(0x28b2c80) # Failed test 'CAT2 doesnt exist' # at t/db_dependent/Branch.t line 179. # got: 'ARRAY(0x28b3088)' # expected: undef # Looks like you failed 2 tests of 31. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 04:15:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 02:15:13 +0000 Subject: [Koha-bugs] [Bug 10514] Add item link on acquisitions add item is too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #5 from Liz Rea --- I don't like buttons there, that's not the end of the page and it just feels weird to me. The CSS is in the staff global css file, so not sure what you're getting at? As for it not being translatable - that predates this patch. Maybe I'll fix it though. For now, I'll probably just fix the capitalisation. ;) Liz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 04:27:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 02:27:26 +0000 Subject: [Koha-bugs] [Bug 10514] Add item link on acquisitions add item is too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 04:27:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 02:27:30 +0000 Subject: [Koha-bugs] [Bug 10514] Add item link on acquisitions add item is too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19504|0 |1 is obsolete| | --- Comment #6 from Liz Rea --- Created attachment 19536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19536&action=edit Bug 10514 - make the add item link more noticeable when adding items to orders it was so small. People were missing it all the time! To test: create a basket add a record to it scroll down - the link to add item and cancel should both be more prominent now. Click "Add item" - it should add an item. Signed-off-by: Jonathan Druart Follow up for translation and capitalisation. Probably deserves another sign off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 05:18:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 03:18:57 +0000 Subject: [Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 05:19:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 03:19:01 +0000 Subject: [Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19305|0 |1 is obsolete| | --- Comment #4 from Srdjan Jankovic --- Created attachment 19537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19537&action=edit [SIGNED-OFF] Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 07:37:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 05:37:41 +0000 Subject: [Koha-bugs] [Bug 10514] Add item link on acquisitions add item is too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 --- Comment #7 from Katrin Fischer --- You are right about the CSS - sorry! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 08:02:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 06:02:24 +0000 Subject: [Koha-bugs] [Bug 9487] Allow items fields to be used in the HOLDPLACED notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9487 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 08:02:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 06:02:28 +0000 Subject: [Koha-bugs] [Bug 9487] Allow items fields to be used in the HOLDPLACED notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9487 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18833|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 19538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19538&action=edit [PASSED QA] Bug 9487 - Allow items fields to be used in the HOLDPLACED notice Test Plan: 1) Enable the syspref emailLibrarianWhenHoldIsPlaced 2) Modify the HOLDPLACED notice, add some item level fields 3) Place an item level hold 4) Check the email you receive ( or just look at it from the db ) You should see the item level fields are new populated Signed-off-by: Srdjan Signed-off-by: Katrin Fischer Passes all tests and QA script. Amended test plan: 5) Place a title level hold 6) Check the email you receive - item fields are not populated, but notice still looks ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 08:10:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 06:10:25 +0000 Subject: [Koha-bugs] [Bug 10535] by default sort funds by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 08:10:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 06:10:28 +0000 Subject: [Koha-bugs] [Bug 10535] by default sort funds by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19402|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 19539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19539&action=edit [PASSED QA] Bug 10535 - by default sort funds by name In parcels.pl, and other acquisition pages, the funds are not sorted by name in combo-box. With a great number of funds, it is difficult to find one. This patch adds a default value to $orderby arg of C4::Budgets::GetBudgets. Test plan : - Create a new fund with a name beginning with 'z' and set you as owner. - Create a new fund with a name beginning with 'a' and set you as owner. - Go to a vendor and click "Receive shipments" - Look at fund combobox => Funds are sorted by name Signed-off-by: Silvia Simonetti Signed-off-by: Katrin Fischer Passes all tests and QA script. When testing make sure your funds would sort the other way around when sorting by code instead of description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 08:16:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 06:16:44 +0000 Subject: [Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 08:16:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 06:16:48 +0000 Subject: [Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19433|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer --- Created attachment 19540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19540&action=edit [PASSED QA] Bug 2774 - Path to theme is hard-coded in many places This patch corrects more places in Koha where the path to the "prog" theme is hard-coded in templates, CSS, and scripts. Staff client home page: Paths to the Koha logo background image and the module image sprite have been corrected. Inactive and hover states of the module links (circulation, patrons, etc) should look correct. addbiblio.pl: An tag is replaced with a text link and an additional CSS class. CSS uses an image-replacement technique to display the image as before. To test, open a blank or existing bibliographic record for editing. Confirm that the "tag editor" icon displays correctly in two cases: 1) tags linked to plugin editors and 2) tags linked to authorities. Both should look correct and work correctly. System preferences: The system preferences editor appends a "loading" image to system preference submit buttons when they are clicked. This patch changes ajax.js to insert a styled with a background-image instead. To test, open system preferences and modify any preference. Submit the change and confirm that the "loading" image appears correctly. Background jobs: Any place in Koha where a background job is used displays a progress bar. This patch corrects the path in CSS to the progress bar image. To test, perform an action which triggers the display of a progress bar. For instance, batch modification of items. Confirm that the progress bar image displays correctly. blue.css: I don't know if this is still used by anyone, but a couple of image paths in this CSS file have been corrected. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes all tests, QA script and test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 08:21:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 06:21:50 +0000 Subject: [Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 08:21:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 06:21:54 +0000 Subject: [Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19434|0 |1 is obsolete| | --- Comment #50 from Katrin Fischer --- Created attachment 19541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19541&action=edit [PASSED QA] Bug 6898 - updatedatabase second query not executed Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer This will only fix the permissions for updates done after the patch has been applied. But I agree with Fridolyn, that we can not safely update permissions for existing installations. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 08:25:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 06:25:31 +0000 Subject: [Koha-bugs] [Bug 9833] New virtual shelves/lists permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 --- Comment #9 from M. de Rooy --- (In reply to Liz Rea from comment #8) > Marcel, > > I'm confused by the status of this patch - there's a signed off patch but > it's failed QA? > > I came up against this today, it would be super cool to get this little > nagger fixed. > > Liz I hope that Matthias as author of the patch (or someone else from Biblibre?) adjusts this patch to make it pass qa. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 08:41:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 06:41:36 +0000 Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 --- Comment #7 from M. de Rooy --- Created attachment 19542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19542&action=edit Bug 10520: Add i18n function to en/marflavour mysql files IMPORTANT: Patch file is too big for git-bz. Please download this .gz and unzip the patch file to apply it manually. Thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 08:45:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 06:45:14 +0000 Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19542|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 08:47:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 06:47:44 +0000 Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19542|Bug 10520: Add i18n |[PATCH_IN_GZIP] Bug 10520: description|function to en/marflavour |Add i18n function to |mysql files |en/marflavour mysql files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 08:54:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 06:54:01 +0000 Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 --- Comment #8 from M. de Rooy --- The size of the simple_bib file and its 'redundant' contents would almost make me split it up in multiple files. It would be even nicer if we could do an insert..select for the marc structure and just update the status column on the tags/subfields to make them visible or hidden in the several frameworks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 09:14:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 07:14:31 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19497|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 19543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19543&action=edit Bug 10556: The delivery time is not inserted on adding a supplier. Test plan: Add/edit a supplier and check that the delivery time is set in DB. Note: This patch cleans the code (sql query) in order to see easily if a problem occurred. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 09:19:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 07:19:01 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19498|0 |1 is obsolete| | Attachment #19513|0 |1 is obsolete| | --- Comment #15 from Julian Maurice --- Created attachment 19544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19544&action=edit Bug 2394: Use syspref canreservefromotherbranches in CanItemBeReserved Squashed patch + fix syspref name -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 09:19:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 07:19:46 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 --- Comment #16 from Julian Maurice --- Created attachment 19545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19545&action=edit [3.12.x] Bug 2394: Use syspref canreservefromotherbranches in CanItemBeReserved Patch for 3.12 and before that uses IndependantBranches syspref -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 09:45:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 07:45:09 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #3 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #2) > t/db_dependent/Branch.t .. 1/31 ... > # Looks like you failed 2 tests of 31. I Srdjan, It seems you don't execute this UT file with a fresh DB. I confirm it works against master with a fresh DB. I think you executed it on your development DB where you applied your patch for bug 8034, which introduces the foreign key on branches.branchprinter. I will provide a followup to avoid a potential jenkins failure later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 09:45:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 07:45:28 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #4 from Jonathan Druart --- Created attachment 19546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19546&action=edit Bug 10508: branchprinter will be a foreign key Bug 8034 will introduces a foreign key on branches.branchprinter. This patch set branchprinter values to undef. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 09:47:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 07:47:21 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #5 from Jonathan Druart --- In fact I don't know if it is your problem, I got the following sql error after applying patch for bug 8034: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_coderun`.`branches`, CONSTRAINT `branches_ibfk_1` FOREIGN KEY (`branchprinter`) REFERENCES `printers` (`printqueue`) ON UPDATE CASCADE) Maybe you forgot to apply the patch of bug 10515? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 09:53:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 07:53:10 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #47 from Fridolyn SOMERS --- This enhancement is clearly in conflict with Bug 6739 which provides the same behavior + manages the reserves. Bug 6739 is already signed-off so we should work on it only. I set in discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 09:56:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 07:56:09 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 10:00:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 08:00:24 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #9 from Jonathan Druart --- Created attachment 19547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19547&action=edit Ergonomic issue on wide screen Hi Owen and Kyle, I got an ergonomic issue on my wide screen. Except that, sounds good :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 10:02:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 08:02:43 +0000 Subject: [Koha-bugs] [Bug 10572] New: Add phone to message_transport_types table for new installs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 Bug ID: 10572 Summary: Add phone to message_transport_types table for new installs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: m.de.rooy at rijksmuseum.nl Reporter: m.de.rooy at rijksmuseum.nl CC: gmcharlt at gmail.com In connection to bug 4246 commit 591bae324d77d285b27dfa6e10dc7001671f53cc added phone to the message_transport_types table in updatedatabase.pl This should be done also for new installs via the .sql files of the web installer. I am adding it only to English now, basing this change upon the work in reports 10509 and 10520. (I discovered this tiny omission there too.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 10:08:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 08:08:03 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #6 from Srdjan Jankovic --- I had that problem, but reverted the patch. I did not run off a fresh DB. In general, are tests supposed to run against a fresh DB only? I would expect not, should run against any data, the only requirement should be database version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 10:08:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 08:08:19 +0000 Subject: [Koha-bugs] [Bug 7785] MySQL-specific syntax in C4::Members columns() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7785 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Jonathan Druart --- QA Comment: Thanks Mark for this new patch. I found 2 (really) smalls things: 1/ please use Modern::Perl instead of warnings and strict. 2/ the sth->finish statement should be removed. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 10:08:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 08:08:51 +0000 Subject: [Koha-bugs] [Bug 10572] Add phone to message_transport_types table for new installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 --- Comment #1 from M. de Rooy --- Created attachment 19548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19548&action=edit Bug 10572: Add phone to message_transport_types table for new installs In connection to bug 4246 commit 591bae324d77d285b27dfa6e10dc7001671f53cc added phone to the message_transport_types table in updatedatabase.pl This should be done also for new installs via the .sql files of the web installer. I am adding it only to English now, basing this change upon the work in reports 10509 and 10520. (I discovered this tiny omission there too.) Test plan: Apply patches 10509/10520. Run new install or run this particular sql file from command line. Note: If you only run this particular file, you do not need patch 10509. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 10:09:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 08:09:13 +0000 Subject: [Koha-bugs] [Bug 10572] Add phone to message_transport_types table for new installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 10:09:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 08:09:32 +0000 Subject: [Koha-bugs] [Bug 10572] Add phone to message_transport_types table for new installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10520 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 10:09:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 08:09:32 +0000 Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files for webinstaller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10572 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 10:10:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 08:10:34 +0000 Subject: [Koha-bugs] [Bug 10572] Add phone to message_transport_types table for new installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4246 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 10:10:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 08:10:34 +0000 Subject: [Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10572 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 10:31:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 08:31:13 +0000 Subject: [Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15710|0 |1 is obsolete| | --- Comment #16 from Fridolyn SOMERS --- Created attachment 19549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19549&action=edit Proposed patch (revisited) Here is the patch with title argument. See commit message for more details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 10:31:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 08:31:26 +0000 Subject: [Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 10:35:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 08:35:22 +0000 Subject: [Koha-bugs] [Bug 10509] Using i18n function for translation in webinstaller mysql files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 10:45:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 08:45:50 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #67 from Jonathan Druart --- Created attachment 19550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19550&action=edit Bug 5336: Change numbers with understandable codes for orderstatus This patch uses understandable codes instead of magical numbers for the aqorders.orderstatus field. + execute sql queries in unit tests into a transaction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 10:47:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 08:47:42 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #68 from Jonathan Druart --- (In reply to Katrin Fischer from comment #66) > Jonathan, could you take a look at the my comments before I proceed here? Done in the last patch. You have to remove the columns (ALTER TABLE aqorders DROP COLUMN orderstatus;) and execute the updatedatabase entry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 10:54:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 08:54:31 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #7 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #6) > I had that problem, but reverted the patch. > I did not run off a fresh DB. In general, are tests supposed to run against > a fresh DB only? I would expect not, should run against any data, the only > requirement should be database version. Do you get the same error after applying patch for bug 10515 and these 2 patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 11:36:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 09:36:21 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 11:36:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 09:36:23 +0000 Subject: [Koha-bugs] [Bug 9282] authorities auto-completion in mainmainentry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9282 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14734|0 |1 is obsolete| | Attachment #14735|0 |1 is obsolete| | --- Comment #12 from M. de Rooy --- Created attachment 19551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19551&action=edit Bug 9282: authorities auto-completion in mainmainentry Signed-off-by: Mathieu Saby Signed-off-by: Marcel de Rooy Works as advertised. Tested with an authority where I added my search term in $b. The modified authority came up in main entry, not in mainmainentry. That was the desired result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 11:36:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 09:36:29 +0000 Subject: [Koha-bugs] [Bug 9282] authorities auto-completion in mainmainentry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9282 --- Comment #13 from M. de Rooy --- Created attachment 19552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19552&action=edit Bug 9282: Followup : authtypecode missing in auto-completion Signed-off by: Mathieu Saby Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 11:41:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 09:41:10 +0000 Subject: [Koha-bugs] [Bug 9282] authorities auto-completion in mainmainentry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9282 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #14 from M. de Rooy --- QA Comment: See also former comment and response from Jared. Further looks good to me. Note that hemain is not the most attractive/descriptive variable name, but it works :) Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 11:41:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 09:41:19 +0000 Subject: [Koha-bugs] [Bug 9282] authorities auto-completion in mainmainentry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9282 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 11:41:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 09:41:25 +0000 Subject: [Koha-bugs] [Bug 9282] authorities auto-completion in mainmainentry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9282 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 11:42:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 09:42:09 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18041|0 |1 is obsolete| | --- Comment #54 from Fridolyn SOMERS --- Created attachment 19553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19553&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 11:42:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 09:42:52 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18042|0 |1 is obsolete| | --- Comment #55 from Fridolyn SOMERS --- Created attachment 19554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19554&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 11:43:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 09:43:42 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18043|0 |1 is obsolete| | --- Comment #56 from Fridolyn SOMERS --- Created attachment 19555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19555&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 2 Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 11:46:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 09:46:48 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19071|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 19556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19556&action=edit Bug 10481: FIX No enrollment fee when changing patron category. When a patron changes to a category with enrollment fee, they are not generated. Test plan: - Choose a category without fee (e.g. Kid) - Add an enrollment fee for another category (e.g. Young adult) - Choose a kid and change his category to "Young adult". - Note the warning message "Fees & Charges: Patron has Outstanding fees & charges of XX" on the check out page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 11:46:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 09:46:53 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #4 from Jonathan Druart --- Created attachment 19557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19557&action=edit Bug 10481: Unit tests for C4::Members::AddEnrolmentFeeIfNeeded prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t .. ok All tests successful. Files=1, Tests=3, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.38 cusr 0.01 csys = 0.41 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 11:48:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 09:48:26 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #5 from Jonathan Druart --- (In reply to Galen Charlton from comment #2) > There are two other places in C4/Members.pm that calculate and add the > enrollment fee. Time for a new function rather than copy-pasta. Yes of course, you are right. Last 2 patches refactores code into 1 routine and add unit tests for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 12:11:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 10:11:34 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #57 from Fridolyn SOMERS --- Created attachment 19558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19558&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 3 Follow-up to correct files in installer. See commit message. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 12:12:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 10:12:23 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #58 from Fridolyn SOMERS --- Followup 3 needs signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 12:46:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 10:46:03 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #59 from Fridolyn SOMERS --- Created attachment 19559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19559&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 4 Some small corrections, see commit message. Needs sign off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 12:48:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 10:48:20 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19559|0 |1 is obsolete| | --- Comment #60 from Fridolyn SOMERS --- Created attachment 19560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19560&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 4 More infos in commit comment -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 13:04:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 11:04:32 +0000 Subject: [Koha-bugs] [Bug 10573] New: French translation for printing a basketgroup Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 Bug ID: 10573 Summary: French translation for printing a basketgroup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: christophe.croullebois at biblibre.com If you want to print a basketgroup with pdf format, it will be in english. The pdf is done with layout2pages.pm or layout3pages.pm which call layout2pages.pdf or layout3pages.pdf. This patch adds layout3pagesfr.pm in src/acqui/pdfformat/ which calls layout3pagesfr.pdf. And adds in basketgroup.pl the check for layout3pagesfr To use it you have to change the systempreferences to pdfformat::layout3pagesfr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 13:07:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 11:07:08 +0000 Subject: [Koha-bugs] [Bug 10573] French translation for printing a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |christophe.croullebois at bibl |ity.org |ibre.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 13:07:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 11:07:28 +0000 Subject: [Koha-bugs] [Bug 10573] French translation for printing a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 13:13:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 11:13:06 +0000 Subject: [Koha-bugs] [Bug 7518] searches with quotation marks don't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7518 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #34 from Fridolyn SOMERS --- > So you think a patch is still needed ? Yes. Looking at screenshot of configuration, I think the bug appears only with QueryStemming off. In fact, to test : disable all query sysprefs unless QueryWeightFields and set QueryAutoTruncate to "only if * is added". I set back to signed off. A second signoff is welcomed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 13:18:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 11:18:16 +0000 Subject: [Koha-bugs] [Bug 10574] New: Remove the message about upgrading to 3.4 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 Bug ID: 10574 Summary: Remove the message about upgrading to 3.4 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: robin at catalyst.net.nz CC: robin at catalyst.net.nz When doing a fresh installation, a warning note about a command that needs to be run when going up from 3.2 is displayed. This is useless in most cases. The script that manages this should be changed to only display the note if you are actually coming from 3.2. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 13:18:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 11:18:23 +0000 Subject: [Koha-bugs] [Bug 10574] Remove the message about upgrading to 3.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 13:39:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 11:39:22 +0000 Subject: [Koha-bugs] [Bug 9743] Mandatory opac hold notes under specified conditions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 13:39:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 11:39:25 +0000 Subject: [Koha-bugs] [Bug 9743] Mandatory opac hold notes under specified conditions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17720|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 13:39:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 11:39:28 +0000 Subject: [Koha-bugs] [Bug 9743] Mandatory opac hold notes under specified conditions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17721|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 13:39:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 11:39:31 +0000 Subject: [Koha-bugs] [Bug 9743] Mandatory opac hold notes under specified conditions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17722|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 13:40:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 11:40:13 +0000 Subject: [Koha-bugs] [Bug 9743] Mandatory opac hold notes under specified conditions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 --- Comment #9 from M. de Rooy --- Needs a rebase. Plus adaptation to renamed syspref :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 13:40:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 11:40:42 +0000 Subject: [Koha-bugs] [Bug 9743] Mandatory opac hold notes under specified conditions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|9722 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 13:40:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 11:40:42 +0000 Subject: [Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9743 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 14:06:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 12:06:38 +0000 Subject: [Koha-bugs] [Bug 9743] Mandatory opac hold notes under specified conditions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 --- Comment #10 from M. de Rooy --- Created attachment 19561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19561&action=edit Bug 9743: Mandatory opac hold notes under specified conditions Description: Adds a new preference OPACMandatoryHoldNotes controlling when hold notes are mandatory for opac users placing a hold. In this initial implementation four reasons for a mandatory hold are added: 1) MARC21 300$a contains a reference to multiple volumes/parts 2) Biblio has one item (used in combination with 1) 3) UNIMARC 200$a contains the word test (for testing purposes only) 4) MARC21 leader pos 7 is collection A new file is added to describe the use of this pref. The opac preferences form shows a link to that file. Test plan: 1) Enable OPACHoldNotes. 2) Enter 1&2,4 into OPACMandatoryHoldNotes (for MARC21 testing). For UNIMARC, you could use 3. 3) Change two biblios: one with leader 7==c and one with 1 item and 300a==2 v. For UNIMARC, you could add the word test to 200$a. 4) Place a hold in opac on these two books separately. Just verify if the hold notes display the reason for mandatory notes. Do not place the holds. Test if you can place a hold if the notes are empty. You should not be allowed to do so. 5) Enable DisplayMultiPlaceHold. Place hold on both books simultaneously. Verify if you see both reasons for mandatory notes. Place the holds. Check them in staff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 14:06:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 12:06:43 +0000 Subject: [Koha-bugs] [Bug 9743] Mandatory opac hold notes under specified conditions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 --- Comment #11 from M. de Rooy --- Created attachment 19562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19562&action=edit Bug 9743: dbrev for mandatory hold notes Adds pref OPACMandatoryHoldNotes. Test plan: Run [your server]/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure Optionally, run a new install to test sysprefs.sql. Or: Edit sysprefs.sql, leave at least the last few lines including the new one. And run from command line: mysql -p [yourdatabase] < [your-clone]/installer/data/mysql/sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 14:13:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 12:13:51 +0000 Subject: [Koha-bugs] [Bug 10571] IntranetBiblioDefaultView doesn't do anything with MARC21 XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10571 --- Comment #2 from Jared Camins-Esakov --- One last update. Apparently there is unsafe caching of that syspref specifically, because under Plack the change won't be reflected unless you restart the server, even when the syspref cache is disabled. So the bug is just for the XSLT view. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 14:18:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 12:18:43 +0000 Subject: [Koha-bugs] [Bug 9743] Mandatory opac hold notes under specified conditions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 --- Comment #12 from M. de Rooy --- Created attachment 19563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19563&action=edit Bug 9743: Unit test for mandatory hold notes Test plan: Export PERL5LIB and KOHA_CONF to your test database. Run t/db_dependent/Reserves.t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 14:31:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 12:31:43 +0000 Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539 --- Comment #4 from M. de Rooy --- (In reply to M. de Rooy from comment #3) > Note: I can use some feedback on at least following two points: > > Can we just remove the section that we now skip with if (0 ) in Makefile.PL? > > Is skipping Koha::Plugins::Base necessary in 00-load.t? Could be just my > problem; it seems that Jenkins does not fail here. Talking to myself :) I remove the if (0) section now. And will not skip the Koha::Plugins::Base. If you have trouble with it too, just do the same as I did in the obsoleted patch. It seems to be my own problem, perhaps with some perl dependency.. Adjusting/rebasing now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 14:32:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 12:32:49 +0000 Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19389|0 |1 is obsolete| | --- Comment #5 from M. de Rooy --- Created attachment 19564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19564&action=edit Bug 10539: Remove unused unit tests in lib/KohaTest This patch removes all files in lib/KohaTest and the associated script t/db_dependent/database_dependent.pl. The second patch deals with a few consequences. Note that bug 10540 has been opened to save some interesting code from these unit tests and inject them in the currently used t/db_dependent suite. Test plan: See second patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 14:39:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 12:39:13 +0000 Subject: [Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19390|0 |1 is obsolete| | --- Comment #6 from M. de Rooy --- Created attachment 19565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19565&action=edit Bug 10539: Followup for removing KohaTest unit tests Makefile.PL: Section for creating file t/test-config.txt removed. Removes t/Makefile and t/rewrite-config-test too. Modifies XISBN.t to remove two commented lines. Test plan: Grep for KohaTest, database_dependent, config-test, t/Makefile. Run perl Makefile.PL and include running the test suite. This may fail on t/00-valid-xml.t and t/QueryParser.t, but that is not the result of this patch. Same for t/00-load.t with potential error on Koha::Plugins::Base. I had this result: Test Summary Report: t/00-valid-xml.t (Wstat: 1792 Tests: 381 Failed: 7) Failed tests: 10, 30-31, 169, 181, 201-202 Non-zero exit status: 7 t/QueryParser.t (Wstat: 512 Tests: 0 Failed: 0) Non-zero exit status: 2 Parse errors: No plan found in TAP output Files=92, Tests=12385, 45 wallclock secs ( 1.74 usr 0.15 sys + 26.61 cusr 1.92 csys = 30.42 CPU) Result: FAIL Failed 2/92 test programs. 7/12385 subtests failed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 14:57:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 12:57:35 +0000 Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #39 from M. de Rooy --- Applying: Bug 8037 - Add holds and funds to items already received in parcel.pl - QA Followup 2 fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 15:08:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 13:08:26 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 15:08:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 13:08:30 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 --- Comment #1 from kenza --- Created attachment 19566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19566&action=edit Bug 10528: C4::Booksellers needs unit tests Unit tests are wrap in a database transaction. GetBooksellerWithLateOrders has been modify in order to pass the tests. Now it considers the field $estimateddeliverydateto and it replaces it by now() only if it is undef. More it doesn't test if $aqbookseller.deliverytime is not Null anymore but if $deliverytime = null or undef, it replaces it by 0. It also verifies if $delay is >= 0. ModBookseller has been modify in order to be more explicit: before it always returned undef. Now it returns : 1 -> If a modification has been done 0E0 -> If the given id doesn't exist undef -> If no id given DelBookSeller has been modify in order to be more explicit: Before it returned undef, now it returns $sth->execute($id), so we can verify how many bookSellers have been deleted. Test Plan : prove t/db_dependant/Booksellers.t t/db_dependent/Bookseller.t .. 2/67 [Some warnings about uninitialized values] WARNING: GetBooksellerWithLateOrders is called with a negative value at /home/kenza/workspace/kohaclone/C4/Bookseller.pm line 137. t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=67, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.43 cusr 0.03 csys = 0.49 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 15:13:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 13:13:41 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19543|0 |1 is obsolete| | CC| |paola.rossi at cineca.it --- Comment #6 from Paola Rossi --- Created attachment 19567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19567&action=edit my sign off of the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 15:14:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 13:14:17 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 15:34:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 13:34:52 +0000 Subject: [Koha-bugs] [Bug 10548] koha_perl_deps.pl miscounts dependencies displayed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10548 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19524|0 |1 is obsolete| | --- Comment #3 from M. de Rooy --- Created attachment 19568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19568&action=edit bug 10548: fix count of missing required dependencies by koha_perl_deps.pl To test: [1] ./koha_perl_deps.pl -m -u If you have nothing missing, uninstall an optional component. [2] ./koha_perl_deps.pl -m -u You should get a number missing of at least 1. [3] ./koha_perl_deps.pl -m -u -r You should get the same number, even though the output is less. [4] Apply patch [5] ./koha_perl_deps.pl -m -u Same results as in step 2. [6] ./koha_perl_deps.pl -m -u -r The number should differ from the results in step 3. Signed-off-by: Galen Charlton Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 15:35:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 13:35:55 +0000 Subject: [Koha-bugs] [Bug 10548] koha_perl_deps.pl miscounts dependencies displayed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10548 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from M. de Rooy --- QA Comment: Tiny patch. Looks good to me. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:03:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:03:49 +0000 Subject: [Koha-bugs] [Bug 10575] New: UT: GetOrdersByBiblionumber.t needs a database transaction Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10575 Bug ID: 10575 Summary: UT: GetOrdersByBiblionumber.t needs a database transaction Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:04:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:04:25 +0000 Subject: [Koha-bugs] [Bug 10575] UT: GetOrdersByBiblionumber.t needs a database transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10575 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kenza.zaki at biblibre.com Depends on| |10270 Assignee|gmcharlt at gmail.com |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:04:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:04:25 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10575 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:04:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:04:47 +0000 Subject: [Koha-bugs] [Bug 10548] koha_perl_deps.pl miscounts dependencies displayed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10548 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:05:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:05:38 +0000 Subject: [Koha-bugs] [Bug 10548] koha_perl_deps.pl miscounts dependencies displayed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10548 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:09:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:09:56 +0000 Subject: [Koha-bugs] [Bug 10574] Remove the message about upgrading to 3.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 --- Comment #1 from Robin Sheat --- Created attachment 19569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19569&action=edit Empty package that claims to be koha 3.2.2 for testing upgrades -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:10:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:10:03 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- I'm interested in testing either/both of these patches, and have grabbed a copy of Matthias's code for a start and rebased it onto 3.12 (I don't think it would be too difficult to rebase onto master, but 3.12 was what I had to hand). Could one of your put up a test plan please, including any apache steps you've undertaken? Cheers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:11:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:11:01 +0000 Subject: [Koha-bugs] [Bug 10574] Remove the message about upgrading to 3.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:11:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:11:10 +0000 Subject: [Koha-bugs] [Bug 10574] Remove the message about upgrading to 3.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 --- Comment #2 from Robin Sheat --- Created attachment 19570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19570&action=edit Bug 10574 - mute the "upgrading from 3.2" message New installs get the message about running a script if upgrading from 3.2. They shouldn't. This silences this message in all cases except when you actually are upgrading from 3.2. Test plan: There are three scenarios to test: 1) A fresh install should not cause the prompt. 2) An upgrade with or without the debconf entry set should not cause the prompt. 3) An upgrade from a 3.2 release to this should cause the prompt. To remove the debconf entry that says the prompt has been seen: echo 'unregister koha-common/3.2-3.4-upgrade-notice' | sudo debconf-communicate koha-common This should be run before every test to make debconf forget that it's shown the prompt. To get its current state: sudo debconf-show koha-common To test against the 3.2 version, an empty package that claims to be Koha 3.2.2 is attached to the bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:31:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:31:28 +0000 Subject: [Koha-bugs] [Bug 7785] MySQL-specific syntax in C4::Members columns() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7785 --- Comment #16 from M. Tompsett --- perlcritic -5 t/db_dependent/Members_columns.t fails when use strict; use warnings; are not used. Since all newer code that is submitted must pass perlcritic -5 testing, what should I do? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:34:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:34:32 +0000 Subject: [Koha-bugs] [Bug 10514] Add item link on acquisitions add item is too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 --- Comment #8 from Owen Leonard --- Created attachment 19571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19571&action=edit Bug 10514 [Alternate] Add item link on acquisitions add item is too small This alternate patch for Bug 10514 converts the "Add" and "Clear" links to the standard "submit/cancel" format inside a fieldset. This gives them a little more visual weight to solve the problem in a differnt way. Based on the changes made by Liz Rea and Jonathan Druart. Same test plan: create a basket add a record to it scroll down - the link to add item and cancel should both be more prominent now. Click "Add item" - it should add an item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:41:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:41:30 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19412|0 |1 is obsolete| | --- Comment #8 from Fridolyn SOMERS --- Created attachment 19572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19572&action=edit Bug 10543 - false mandatory warning in additem Revised patch using a JS method in cataloging.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:43:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:43:54 +0000 Subject: [Koha-bugs] [Bug 10575] UT: GetOrdersByBiblionumber.t needs a database transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10575 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:43:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:43:56 +0000 Subject: [Koha-bugs] [Bug 10575] UT: GetOrdersByBiblionumber.t needs a database transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10575 --- Comment #1 from kenza --- Created attachment 19573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19573&action=edit GetOrdersByBiblionumber.t needs a database transaction Before this patch, the queries in GetOrdersByBiblionumber.t were commited in the database and have to be removed at the end. This patch wraps tests in a database transaction. Test Plan : prove t/db_dependent/Acquisition/GetOrdersByBiblionumber.t t/db_dependent/Acquisition/GetOrdersByBiblionumber.t .. ok All tests successful. Files=1, Tests=3, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.37 cusr 0.05 csys = 0.45 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:44:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:44:11 +0000 Subject: [Koha-bugs] [Bug 10576] New: Untranslatable strings in additem.js Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10576 Bug ID: 10576 Summary: Untranslatable strings in additem.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org CC: frederic at tamil.fr There are some English strings embedded in additem.js which cannot be translated. Others are wrapped in the "_()" function but this doesn't help--JS files are not processed by the translation script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:51:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:51:25 +0000 Subject: [Koha-bugs] [Bug 10514] Add item link on acquisitions add item is too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10576 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:51:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:51:25 +0000 Subject: [Koha-bugs] [Bug 10576] Untranslatable strings in additem.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10576 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |10514 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:53:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:53:12 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 --- Comment #9 from Fridolyn SOMERS --- Created attachment 19574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19574&action=edit Bug 10543 - Unify item mandatory subfields check Followup 1 : Use of CheckMandatorySubfields method in other item forms than additem.tt : - acqui/neworderempty.tt : was an old-fashioned code - acqui/orderreceive.tt : was the same code as additem.tt - serials/serials-edit.tt : was a code similar to CheckMandatorySubfields but yet slower because each() function loops on every subfield, not only mandatories. Also did not add "missing" class. Note that check is only performed on visible item forms. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:53:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:53:15 +0000 Subject: [Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #51 from Galen Charlton --- Pushed follow-up to master. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:55:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:55:38 +0000 Subject: [Koha-bugs] [Bug 7785] MySQL-specific syntax in C4::Members columns() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7785 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19534|0 |1 is obsolete| | --- Comment #17 from M. Tompsett --- Created attachment 19575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19575&action=edit Pure ANSI SQL code to replace MySQLism Corrected my default perlcriticrc file with a: ln -s ~/qa-test-tools/perlcriticrc ~/.perlcritic Made the two changes as suggested by Jonathan Druart. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:55:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:55:41 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 --- Comment #10 from Fridolyn SOMERS --- Created attachment 19576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19576&action=edit Bug 10543 - add mandatory subfield check to addorderiso2709.pl addorderiso2709.tt was missing item form check. Adds it with a call to CheckMandatorySubfields of course. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:55:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:55:49 +0000 Subject: [Koha-bugs] [Bug 7785] MySQL-specific syntax in C4::Members columns() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7785 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 16:57:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 14:57:40 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 --- Comment #11 from Fridolyn SOMERS --- (In reply to Galen Charlton from comment #7) > No, there are three: serials-edit.tt includes a version of that same check; > the serials receiving form should be checked to see whether the same bug > applies there as well. Thanks for your help, you where totally right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 17:43:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 15:43:12 +0000 Subject: [Koha-bugs] [Bug 10573] French translation for printing a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 --- Comment #1 from Christophe Croullebois --- Created attachment 19577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19577&action=edit proposed patch thx for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 17:49:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 15:49:20 +0000 Subject: [Koha-bugs] [Bug 10573] French translation for printing a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 17:55:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 15:55:03 +0000 Subject: [Koha-bugs] [Bug 10573] French translation for printing a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.croullebois at bibl | |ibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 18:25:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 16:25:08 +0000 Subject: [Koha-bugs] [Bug 10577] New: C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Bug ID: 10577 Summary: C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: gmcharlt at gmail.com GetBudgetPeriod, when passed a fund ID (budget_period_id), returns a hashref of an individual budget, consistent with other functions of its sort. However, it also has a special mode -- if you pass 0 as its parameter, it returns a hashref of the first active budget. This is a problem for several reasons: [1] Nothing in Koha requires that there be only one active budget. Consequently, a function that returns "the" active one is working from an incorrect assumption (albeit, maybe one that used to be true when acquisitions support was originally added?). [2] Even the assumption were true that there can be only one active budget at a time, it is still bad practice for the one parameter of a function to either be an ID or a flag. [3] There is no code, other than a test case, that actually calls GetBudgetPeriod(0). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 18:47:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 16:47:08 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 18:47:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 16:47:12 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 --- Comment #1 from Galen Charlton --- Created attachment 19578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19578&action=edit bug 10577: improve semantics of GetBudgetPeriod() Remove the option to pass zero to this function in order to get "the" active budget. This was a problem in three ways: - Koha doesn't require that there be only one active budget at a time, so the concept of "the" active budget doesn't make sense. - Having the single parameter be either an ID or a flag based on its value is poor function design. - No callers of GetBudgetPeriod() were actually using this modality. This patch also improves the DB-dependent tests for budgets by - wrapping the test in a transaction - counting budgets correctly To test: [1] Apply the patch. [2] Verify that prove -v t/db_dependent/Budgets.t passes [3] Verify in the staff interface that: - the budget hierarchy displays correctly - you can add and modify a budget Signed-off-by: Galen Charlton -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 18:53:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 16:53:15 +0000 Subject: [Koha-bugs] [Bug 10535] by default sort funds by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Fridoyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 18:55:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 16:55:10 +0000 Subject: [Koha-bugs] [Bug 10535] by default sort funds by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19539|0 |1 is obsolete| | --- Comment #6 from Galen Charlton --- Created attachment 19579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19579&action=edit Bug 10535: (follow-up) add test case This adds a test case for the new default sort order for GetBudgets(). Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 18:55:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 16:55:21 +0000 Subject: [Koha-bugs] [Bug 10535] by default sort funds by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 18:55:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 16:55:28 +0000 Subject: [Koha-bugs] [Bug 10535] by default sort funds by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 18:57:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 16:57:20 +0000 Subject: [Koha-bugs] [Bug 10535] by default sort funds by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10577 --- Comment #7 from Galen Charlton --- I've attached a follow-up patch that adds a test case for the change to the default sort order. I very much prefer that *all* changes to routines in C4 and Koha be accompanied by test cases. Note that in order for this patch to apply cleanly, the patch for bug 10577 must be applied first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 18:57:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 16:57:20 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10535 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 19:06:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 17:06:00 +0000 Subject: [Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 19:08:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 17:08:20 +0000 Subject: [Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 19:08:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 17:08:23 +0000 Subject: [Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598 --- Comment #1 from Owen Leonard --- Created attachment 19580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19580&action=edit Bug 7598 - Acquisitions JavaScript contains untranslatable English strings English strings in acq.js cannot be processed by the translation script. This patch moves the strings to the templates to be set as JS variables for use by the script. To test: - On the uncertain prices page, enter an invalid price and click save. You should see a JavaScript alert pointing this out. - When adding a fund to an existing budget, enter an amount which exceeds the amount in the parent budget. You should see a JavaScript alert pointing this out. There is a similar function which has been corrected, checkBudgetParent(), but I don't know how to trigger it for testing. The closebasketgroup function has been updated but as far as I can tell it's not actually in use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 19:13:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 17:13:24 +0000 Subject: [Koha-bugs] [Bug 10578] New: Escaping CGI breaks results sort feature (librarian's interface) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10578 Bug ID: 10578 Summary: Escaping CGI breaks results sort feature (librarian's interface) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: januszop at gmail.com After introducing escaped $query_cgi in bugfix 9239 the results sort feature does not work correctly for the librarian. To reproduce the problem (in librarian's interface): 1. Have some biblio records to get a list when searching 2. Make an advanced search with 'as phrase' modifier (title -- ti,phr: or author -- au,phr: , etc.) 3. Having the result list try to change the sort order. 4. You should get no results with a message like: "No results match your search for 'au%2Cphr: " etc. A patch will follow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 19:17:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 17:17:13 +0000 Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x or 200$y In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m Assignee|adrien.saurat at biblibre.com |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 19:18:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 17:18:14 +0000 Subject: [Koha-bugs] [Bug 10578] Escaping CGI breaks results sort feature (librarian's interface) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10578 --- Comment #1 from Janusz Kaczmarek --- Created attachment 19581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19581&action=edit Proposed patch To test (in librarian's interface): 1. Have some biblio records to get a list when searching. 2. Make an advanced search with 'as phrase' modifier (title -- ti,phr: or author -- au,phr: , etc.) 3. Having the result list try to change the sort order. 4. You should get no results with a message like: "No results match your search for 'au%2Cphr: " etc. 5. Apply the patch 6. Repeat steps 2. & 3. 7. You should get the list sorted according to your choice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 19:18:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 17:18:30 +0000 Subject: [Koha-bugs] [Bug 10578] Escaping CGI breaks results sort feature (librarian's interface) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10578 Janusz Kaczmarek changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 19:18:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 17:18:49 +0000 Subject: [Koha-bugs] [Bug 10578] Escaping CGI breaks results sort feature (librarian's interface) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10578 Janusz Kaczmarek changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |januszop at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 19:20:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 17:20:27 +0000 Subject: [Koha-bugs] [Bug 7497] "kw, wrdl" and variants should be replaced by something more explicit in search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7497 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m Version|3.6 |master Assignee|adrien.saurat at biblibre.com |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 19:25:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 17:25:20 +0000 Subject: [Koha-bugs] [Bug 8074] Holds to pull In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m Version|3.8 |master Assignee|adrien.saurat at biblibre.com |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 19:50:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 17:50:27 +0000 Subject: [Koha-bugs] [Bug 8402] generate 'install_misc/debian.packages' file from debian/control file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 --- Comment #10 from M. Tompsett --- Given that there is the ability to: $ sudo apt-get install koha-deps koha-perldeps Are - install_misc/debian.packages - install_misc/ubuntu.packages - install_misc/ubuntu.12.04.packages - install_misc/ubuntu.10.04.packages - install_misc/ubuntu-packages.sh - this script suggestion even necessary? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 20:30:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 18:30:00 +0000 Subject: [Koha-bugs] [Bug 10560] No way to disable english In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10560 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 20:30:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 18:30:07 +0000 Subject: [Koha-bugs] [Bug 10560] No way to disable english In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10560 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19509|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 19582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19582&action=edit [SIGNED-OFF] Bug 10560 - No way to disable english If you enable another translation, and disable english, then if you dont have a cookie set, or your browser is not set to that language, you will get english. So you can not disable english in either the staff client or the OPAC. This patch fixes the language selection to do the right thing. To test you must have at least one other language installed besides English. Apply the patch and disable the en translation. Koha should fall back to one of the enabled translations. Signed-off-by: Owen Leonard I added a patch description and test plan, missing from the original patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 22:50:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 20:50:47 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Galen, I think I found a problem with this - you said it's never used, but from the description I thought about the funds page and spotted a problem there: - Apply the patch - Go to the funds page - The heading is missing the budget information now - it shows: Funds for '' I think this is a design issue of the funds page really. Maybe we just should add a budget column to the table and reword the heading so it can deal with funds from multiple budgets? But not sure how that would affect other functionality on that page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 23:06:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 21:06:46 +0000 Subject: [Koha-bugs] [Bug 10579] New: Days in Advance cannot be set for Advance Notice in messaging prefs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10579 Bug ID: 10579 Summary: Days in Advance cannot be set for Advance Notice in messaging prefs Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: fred.pierre at smfpl.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com All takes_days fields in the message_attributes table are set to zero, and there is no documented method to reset these. When set to one, the takes_days allows you to set the "Days in Advance" I cannot find a way to activate this for the "Advance Notice" message type without manually altering the table to reset takes_days from zero to one. A system preference would allow this to be set through the Koha interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 23:16:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 21:16:34 +0000 Subject: [Koha-bugs] [Bug 10514] Add item link on acquisitions add item is too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19536|0 |1 is obsolete| | Attachment #19571|0 |1 is obsolete| | --- Comment #9 from Liz Rea --- Created attachment 19583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19583&action=edit Bug 10514 [Alternate] Add item link on acquisitions add item is too small This alternate patch for Bug 10514 converts the "Add" and "Clear" links to the standard "submit/cancel" format inside a fieldset. This gives them a little more visual weight to solve the problem in a differnt way. Based on the changes made by Liz Rea and Jonathan Druart. Same test plan: create a basket add a record to it scroll down - the link to add item and cancel should both be more prominent now. Click "Add item" - it should add an item. Signed-off-by: Liz Rea I still feel weird about the button, but as two people have said they'd rather have the button, I'm alright with it I guess. Really what I want is people to notice it's there and click it at the appropriate time. I hope this will help that issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 23:34:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 21:34:52 +0000 Subject: [Koha-bugs] [Bug 10560] No way to disable english In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10560 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 23:34:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 21:34:57 +0000 Subject: [Koha-bugs] [Bug 10560] No way to disable english In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10560 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19582|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 19584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19584&action=edit [PASSED QA] Bug 10560 - No way to disable english If you enable another translation, and disable english, then if you dont have a cookie set, or your browser is not set to that language, you will get english. So you can not disable english in either the staff client or the OPAC. This patch fixes the language selection to do the right thing. To test you must have at least one other language installed besides English. Apply the patch and disable the en translation. Koha should fall back to one of the enabled translations. Signed-off-by: Owen Leonard I added a patch description and test plan, missing from the original patch. Signed-off-by: Katrin Fischer I have tested with various combinations of activated languages and have found no regression. If the cookie is set, the right language is shown accordingly. Else the first language in the list seems to be picked. It did never fall back to English in my tests, when English was explicitly deactivated. Passes all tests and QA script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 11 23:42:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 21:42:52 +0000 Subject: [Koha-bugs] [Bug 10579] Days in Advance cannot be set for Advance Notice in messaging prefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10579 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Fred, the value should always be set to 1 after installing Koha and should never be changed. Which version are you looking at? Did you install all the mandatory SQL files when running the web installer? We checked the English files and they are alright. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 00:09:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 22:09:16 +0000 Subject: [Koha-bugs] [Bug 10514] Add item link on acquisitions add item is too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 00:09:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 22:09:33 +0000 Subject: [Koha-bugs] [Bug 10514] Add item link on acquisitions add item is too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 00:09:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 22:09:37 +0000 Subject: [Koha-bugs] [Bug 10514] Add item link on acquisitions add item is too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19583|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 19585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19585&action=edit [PASSED QA] Bug 10514 [Alternate] Add item link on acquisitions add item is too small This alternate patch for Bug 10514 converts the "Add" and "Clear" links to the standard "submit/cancel" format inside a fieldset. This gives them a little more visual weight to solve the problem in a differnt way. Based on the changes made by Liz Rea and Jonathan Druart. Same test plan: create a basket add a record to it scroll down - the link to add item and cancel should both be more prominent now. Click "Add item" - it should add an item. Signed-off-by: Liz Rea I still feel weird about the button, but as two people have said they'd rather have the button, I'm alright with it I guess. Really what I want is people to notice it's there and click it at the appropriate time. I hope this will help that issue. Signed-off-by: Katrin Fischer Passes all tests and QA script. Leaves the translation problems, but that needs more work and is out of the scope of this bug. Tested Add and Update functionality works correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 00:11:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 22:11:14 +0000 Subject: [Koha-bugs] [Bug 10514] Add item link on acquisitions add item is too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 --- Comment #11 from Katrin Fischer --- Created attachment 19586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19586&action=edit screenshot - display using alternate patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 00:15:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 22:15:51 +0000 Subject: [Koha-bugs] [Bug 10514] Add item link on acquisitions add item is too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 --- Comment #12 from Katrin Fischer --- I have attached 2 screenshots to compare the results of both patches. I personally like the second a bit better, because it fits how we do things in other places. There was also a suggestion to add some additional text to the form on IRC: (23:28:47) rangi: id like some text (23:28:51) rangi: right below Item (23:29:15) rangi: (Fill in the following form and click add, to add 1 item to your order, do this as many times as needed) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 00:45:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jul 2013 22:45:20 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #8 from Srdjan Jankovic --- Not sure any more, I was signing off that patch and can't remember what I did. Will try again later. In general, shall I wait for dependencies to be pushed to master first? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 10:25:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 08:25:26 +0000 Subject: [Koha-bugs] [Bug 10580] New: Remove NoZebra reference from Makefile.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10580 Bug ID: 10580 Summary: Remove NoZebra reference from Makefile.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de When running Makefile.pl you are still asked if you want to install the zebra configuration files and it states: Koha will default to using its internal serach engine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 11:01:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 09:01:18 +0000 Subject: [Koha-bugs] [Bug 10581] New: Authority search: no results should not display as 404 error page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10581 Bug ID: 10581 Summary: Authority search: no results should not display as 404 error page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de CC: jcamins at cpbibliography.com When you have links in your authorities that point to a non-existing authority or where the search for the term gives no results a 404 error is shown. Instead it should show a nice 'no results page' telling the user that no result was found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 11:03:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 09:03:27 +0000 Subject: [Koha-bugs] [Bug 10582] New: Koha OPAC URL shows Perl error message before web installer was run Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10582 Bug ID: 10582 Summary: Koha OPAC URL shows Perl error message before web installer was run Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de CC: gmcharlt at gmail.com When installing Koha and you open the URL to the OPAC before you have run the web installer there is a perl error message shown instead of the maintenance mode warning: Cant's use an undefined value as an ARRAY reference at /usr/lib/perl5/DBI.pm line 2054. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 11:03:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 09:03:33 +0000 Subject: [Koha-bugs] [Bug 10582] Koha OPAC URL shows Perl error message before web installer was run In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10582 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 11:22:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 09:22:28 +0000 Subject: [Koha-bugs] [Bug 9833] New virtual shelves/lists permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #10 from M. de Rooy --- Picked some discussion from irc log: ========== wizzyrea: and even better, apparently there was a bug at some point that set the owners to NULL, so there are lists existent that cannot be edited by anyone?! dcook: That is a bit confusing...I can't tell if Marcel passed or failed it based on the comments.. Although it does look like he's asking for some changes? then he attached a patch... ============= [End of quote] Do no know exactly any more but I must have attached this patch just for a trivial rebase. Yes, I failed this patch for reasons mentioned in comment 6. Note also that there are privacy issues on viewing/editing all lists by superlibs. Furthermore, I am still working on development for sharing lists that should also cover the topic of lists without owner (i call them orphaned lists). It should be the third patch of the Sharing a lists- series.. Hope that helps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 12:32:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 10:32:12 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #40 from mathieu saby --- I wanted to test this patch to check if it solved the problem raised in BZ 7129, but it does not apply on sandbox CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref Failed to merge in the changes. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 12:37:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 10:37:21 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19066|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart --- Created attachment 19587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19587&action=edit Bug 7180: Order from staged file improvements This patch adds: - 1 syspref MarcFieldsToOrder - 1 ajax script acqui/ajax-getauthvaluedropbox.pl - 1 routine C4::Budgets::GetBudgetByCode Before this patch you were not able to order 1 or all the records from your staged file. You were allowed to specify some information ("Import All" and "Accounting details" areas) for the order. With this patch, the previous behaviours still exist. But now you can *select* which records you want to ordered. For these ones you can specify independently informations (Quantity, price, budget, sort1 and sort2). The cherry on the cake is that you can pre-fill these information with values Test plan: 1. Fill the new syspref MarcFieldsToOrder with something like: ==BEGIN== price: 947$c quantity: 969$h budget_code: 922$a rrp: 010$d discount: 969$d sort1: 923$a sort2: 924$a ==END== The empty line at the end is mandatory! The budget (corresponding to your budget_code) can be filled with authorized value categories (statistic 1 and 2). The sort1 and sort2 values can be filled with the an authorized value (of the category previously selected) 2. Choose randomly one or more biblio(s) and fill fields with what is relevant. 3. Export the biblio and import it (with the "Stage MARC records for import" tool). 4. Go on a basket and add an order from a staged file. Select your staged file. 5. Well. Now you can see your biblio (or biblios if your had exported more than one). For each one, informations should be pre-filled with the biblio values. The budget should be selected on the budget corresponding to the budget_code (in the field 922$a) and the "planning values" too (with fields 923$a and 924$a). You can modify these values (or not) and choose a default value for budget and planning values (in the "Accounting details" area). 6. Save and check the prices values. Modify the order and check that budget and sort* are good Prices are calculated following some parameters: if there is no price => listprice = 0 else => - the gstrate value for your order is the gstrate value of the bookseller - discount = if filled : the discount value / 100 else: the discount value of the bookseller - if the bookseller includes tax( List item price includes tax: Yes ) if a discount exists: ecost = price rrp = ecost / ( 1 - discount ) else: # a discount does not exist ecost = price * ( 1 - discount ) rrp = price else # the bookseller does not include tax if a discount exists: ecost = price / ( 1 + gstrate ) rrp = ecost / ( 1 - discount ) else: # a discount does not exist rrp = price / ( 1 + gstrate ) ecost = rrp * ( 1 - discount ) - in all cases: listprice = rrp / currency rate unitprice = ecost total = ecost * quantity 7. Retry with different parameters 8. Check the 'Import all' action still works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 12:37:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 10:37:27 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19067|0 |1 is obsolete| | --- Comment #42 from Jonathan Druart --- Created attachment 19588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19588&action=edit Bug 7180: FIX getAuthValueDropbox should display the selected value If the no AV match the name/category or if no category is defined, the input field should contain the value. Signed-off-by: Pierre Angot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 12:37:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 10:37:33 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19068|0 |1 is obsolete| | --- Comment #43 from Jonathan Druart --- Created attachment 19589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19589&action=edit Bug 7180: Add UT for C4::Budgets::GetBudgetByCode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 12:37:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 10:37:40 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19316|0 |1 is obsolete| | --- Comment #44 from Jonathan Druart --- Created attachment 19590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19590&action=edit Bug 7180: QA followup Ergonomic improvements: - Remove the green color the selected record. - Use fieldset.rows (and legend). - Use the required css class for quantity inputs. - Replace "budget" with "fund". - fix the "undefined" string - Add a "show MARC" link - replace "no_match" with a text. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 12:39:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 10:39:53 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #45 from Jonathan Druart --- Conflicts on koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref, koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css and installer/data/mysql/updatedatabase.pl Easy to fix, switch back to Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 12:50:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 10:50:03 +0000 Subject: [Koha-bugs] [Bug 3340] Enhancement for borrower loading command line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3340 Ian Bays changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.bays at ptfs-europe.com --- Comment #3 from Ian Bays --- We have a customer who would like to use this facility. They prepare a user/patron feed in a format that works in the staff interface and want to script it for regular use. We would be happy to help test it that will help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 13:32:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 11:32:46 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #46 from mathieu saby --- This patch has evolved since I tested it during Hackfest. I am a bit surprised, because when I selected all the records and tried to add them all in a batch ("Save button"), Koha asked me to define a quantity for each book of my imported MARC file. I think "1" should be the default quantity. Maybe I did something wrong? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 13:44:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 11:44:03 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #47 from mathieu saby --- An other remark : currently in master, when you choose to add each document individually, Koha can alert you if there is a duplicate. Apparently we loose this function. Do you think it is a problem ? M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 13:57:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 11:57:01 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #48 from Katrin Fischer --- Hi Mathieu, I think maybe we could have a default of 1 but display that in the quantity field? Having empty default to 1 might be unexpected behaviour and a bit confusing. About the other - yes, I think it's a problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 14:18:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 12:18:17 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #100 from sandboxes at biblibre.com --- Patch tested with a sandbox, by sandboxes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 14:18:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 12:18:42 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19518|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 14:18:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 12:18:50 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19519|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 14:18:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 12:18:52 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #49 from mathieu saby --- What I see is : - in master, I can import a file of 20 records in one click ("Save") - with this patch, I have to define the quantity of each line (20 times!) before clicking "Save" So the process is much longer than before. Currently, there is a default quantity of 1. And I think we should keep that. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 14:19:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 12:19:05 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #101 from sandboxes at biblibre.com --- Created attachment 19591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19591&action=edit Bug xxxxx: Modern::Perl should be used Signed-off-by: sandboxes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 14:19:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 12:19:11 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #102 from sandboxes at biblibre.com --- Created attachment 19592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19592&action=edit Bug xxxxx: replace tmpl with tt Signed-off-by: sandboxes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 15:18:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 13:18:35 +0000 Subject: [Koha-bugs] [Bug 10541] Enable cross-browser AJAX in additem.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10541 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 15:18:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 13:18:39 +0000 Subject: [Koha-bugs] [Bug 10541] Enable cross-browser AJAX in additem.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10541 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19399|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 19593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19593&action=edit [SIGNED-OFF] Bug 10541 - Enable cross-browser AJAX in additem.js Currently, the additem.js is using "indexOf" to search for a value in an array. While this works in Chrome, Firefox, and IE > 9, it fails miserably in IE 8 and 7 (which don't have the indexOf method). This means that users aren't able to add items using the acquisitions module! Instead of using "indexOf", we should be using the jQuery function $.inArray. It was added in jQuery v1.2 (3.8.0 uses v1.3.2 so even our oldest supported release can use this method). It's perfectly cross-browser compatible...works in Chrome, Firefox, and every version of IE that I've tried (i.e. 7, 8, 9). Test Plan: Before applying patch: 0) Switch to Internet Explorer 7, or 8, or 9. If you're using IE 9, you'll need to change the Document Mode to IE7 standards or IE8 standards. You can do this by opening Internet Explorer 9, pressing F12 (or clicking on the gear in the top right corner and choosing F12 Developer Tools), and then clicking on "Document Mode" on the top toolbar. There, you can change to IE7 or IE8 standards. N.B. This is not always a perfect emulation in every case, but this time it does show you the bug. 1) Set the system preference AcqCreateItem to "receiving an order" 2) Go to Acquisitions 3) Either: a) Receive a shipment for a basket with items b) Create a new basket, create an order, close the basket, and then do 3a) 4) In the "Item" fieldset, fill out some fields such as barcode, Date acquiried, Public note, etc. 5) Click "Add" at the bottom of the fieldset 6) Note that while the item may have been added, the "Item" fieldset is not being shown again. You may also notice a Javascript error appearing in a pop-up window or you might see a yellow warning flag on the bottom status bar. APPLY THE PATCH 7) Do a full refresh of the page (hold down shift and press the refresh button on the browser next to the address bar), and try adding items again. 8) Note that you receive no warnings and that items are added correctly as they would be in Firefox or Chrome. OPTIONALLY 9) To be sure that I haven't broken anything, go through the same steps in IE9 (with IE9 standards) or Chrome or Firefox. Everything should be working. Signed-off-by: Owen Leonard Tested in IE10 in IE7 mode and IE9 mode. Also tested in Firefox. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 15:39:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 13:39:38 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard --- This doesn't work for me either. Here's what I did: 1) Pick an item which isn't checked out, isn't lost, and set its ccode to NULL. 2) Add the item to an existing course, changing the ccode to one of my existing ones. 3) Looking at the entry on the course detail page, the ccode column shows "Unchanged ([my ccode])." 4) Click "remove" to take the item off the course. 5) View the detail page for that item: ccode is not null. It's still the ccode I set it to when I added it to the course. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 16:05:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 14:05:03 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi at cineca.it --- Comment #8 from Paola Rossi --- During step 3 of Web Installer, I received this message: Web installer ? Step 3 The following error occurred while importing the database structure: ERROR 1064 (42000) at line 2861: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'BOOLEAN not NULL default 0, booksellerid int(11) not NULL, PRIMARY KEY (id' at line 10 Please contact your system administrator -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 16:07:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 14:07:24 +0000 Subject: [Koha-bugs] [Bug 10541] Enable cross-browser AJAX in additem.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10541 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 16:07:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 14:07:27 +0000 Subject: [Koha-bugs] [Bug 10541] Enable cross-browser AJAX in additem.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10541 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19593|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 19594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19594&action=edit Bug 10541 - Enable cross-browser AJAX in additem.js Currently, the additem.js is using "indexOf" to search for a value in an array. While this works in Chrome, Firefox, and IE > 9, it fails miserably in IE 8 and 7 (which don't have the indexOf method). This means that users aren't able to add items using the acquisitions module! Instead of using "indexOf", we should be using the jQuery function $.inArray. It was added in jQuery v1.2 (3.8.0 uses v1.3.2 so even our oldest supported release can use this method). It's perfectly cross-browser compatible...works in Chrome, Firefox, and every version of IE that I've tried (i.e. 7, 8, 9). Test Plan: Before applying patch: 0) Switch to Internet Explorer 7, or 8, or 9. If you're using IE 9, you'll need to change the Document Mode to IE7 standards or IE8 standards. You can do this by opening Internet Explorer 9, pressing F12 (or clicking on the gear in the top right corner and choosing F12 Developer Tools), and then clicking on "Document Mode" on the top toolbar. There, you can change to IE7 or IE8 standards. N.B. This is not always a perfect emulation in every case, but this time it does show you the bug. 1) Set the system preference AcqCreateItem to "receiving an order" 2) Go to Acquisitions 3) Either: a) Receive a shipment for a basket with items b) Create a new basket, create an order, close the basket, and then do 3a) 4) In the "Item" fieldset, fill out some fields such as barcode, Date acquiried, Public note, etc. 5) Click "Add" at the bottom of the fieldset 6) Note that while the item may have been added, the "Item" fieldset is not being shown again. You may also notice a Javascript error appearing in a pop-up window or you might see a yellow warning flag on the bottom status bar. APPLY THE PATCH 7) Do a full refresh of the page (hold down shift and press the refresh button on the browser next to the address bar), and try adding items again. 8) Note that you receive no warnings and that items are added correctly as they would be in Firefox or Chrome. OPTIONALLY 9) To be sure that I haven't broken anything, go through the same steps in IE9 (with IE9 standards) or Chrome or Firefox. Everything should be working. Signed-off-by: Owen Leonard Tested in IE10 in IE7 mode and IE9 mode. Also tested in Firefox. Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 16:11:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 14:11:33 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 16:11:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 14:11:39 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19567|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 19595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19595&action=edit Bug 10556: The delivery time is not inserted on adding a supplier. Test plan: Add/edit a supplier and check that the delivery time is set in DB. Note: This patch cleans the code (sql query) in order to see easily if a problem occurred. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 16:16:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 14:16:07 +0000 Subject: [Koha-bugs] [Bug 7518] searches with quotation marks don't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7518 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 16:16:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 14:16:11 +0000 Subject: [Koha-bugs] [Bug 7518] searches with quotation marks don't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7518 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16238|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall --- Created attachment 19596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19596&action=edit Bug 7518: searches with quotation marks don't work A search term without quotation marks returns the expected results. The same search term with quotation marks returns no results. Koha should ignore the quotation marks and return results anyway. This appears when QueryWeightFields syspref is activated. This feature composes a complex CCL query using double quotes around search words. This patch simply replaces double quotes in search words by a space. Test plan : - Set QueryWeightFields off - Perform a serch on two words where you have results, like : centre "ville => you get results - Set QueryWeightFields on - Perform same serch => you get the same results Signed-off-by: Leila Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 16:22:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 14:22:47 +0000 Subject: [Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- koha-qa.pl gives this failure FAIL C4/Acquisition.pm FAIL pod *** WARNING: No items in =over / =back list in file C4/Acquisition.pm *** ERROR: Spurious text after =cut in file C4/Acquisition.pm I don't believe this is a result of your patch though. However, looking at the diff for your patch, I see file_not_specified_in_diff, which doesn't look like something we want to have in there! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 16:33:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 14:33:38 +0000 Subject: [Koha-bugs] [Bug 10515] The prototype for GetBranchCategory and GetBranchCategories is not consistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10515 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 16:33:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 14:33:44 +0000 Subject: [Koha-bugs] [Bug 10515] The prototype for GetBranchCategory and GetBranchCategories is not consistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10515 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19535|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 19597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19597&action=edit Bug 10515: The prototype for GetBranchCategory and GetBranchCategories is not consistent The prototype is not consistent, GetBranchCategory should return only 1 result and GetBranchCategories should not have a categorycode argument. This patch fixes that. Test plan: 1/ Try to add/remove/modify a library. 2/ Add some groups 3/ Add these groups to a library Signed-off-by: Srdjan Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 16:33:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 14:33:58 +0000 Subject: [Koha-bugs] [Bug 10579] Days in Advance cannot be set for Advance Notice in messaging prefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10579 Fred P changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Fred P --- Sounds like we might have a legacy data issue, rather than a bug. My apologies. Because other notices, like item due or checkout, cannot possibly be sent in advance, does that "Days in Advance" selector get discarded? I assume it is only useful for the pre-due notice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 16:38:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 14:38:17 +0000 Subject: [Koha-bugs] [Bug 10422] Remove references to unused and non-existent wizard.css In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10422 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19501|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 19598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19598&action=edit Bug 10422 - Remove references to unused and non-existent wizard.css doc-head-close.inc contains a reference to "wizard.css" which doesn't exist. The option to include it never evaluates as true, and that section can be removed from the template. To test, apply the patch and view any page in the staff client. Everything should be styled as before. A search of the Koha source should return no references to "wizard.css" or a "wizard" variable. Signed-off-by: Jonathan Druart No occurrence of "wizard" in pl/pm files. Signed-off-by: Kyle M Hall Passes koha-qa.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 16:38:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 14:38:14 +0000 Subject: [Koha-bugs] [Bug 10422] Remove references to unused and non-existent wizard.css In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10422 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 16:43:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 14:43:52 +0000 Subject: [Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 16:43:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 14:43:59 +0000 Subject: [Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19522|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 19599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19599&action=edit Bug 9362 - Wrong query in GetUpcomingDueIssues C4:Circulation:GetUpcomingDueIssues is used in the advance_notices.pl script. This script waits for a "maxdays" parameter, which is used in the following request. We have in GetUpcomingDueIssues the following query: SELECT issues.*, items.itype as itemtype, items.homebranch, TO_DAYS( date_due )-TO_DAYS( NOW() ) as days_until_due, branches.branchemail FROM issues LEFT JOIN items USING (itemnumber) LEFT OUTER JOIN branches USING (branchcode) WhERE returndate is NULL AND ( TO_DAYS( NOW() )-TO_DAYS( date_due ) ) < ? The last line should be with date_due before NOW. The date_due is supposed to be "bigger" (farther) than the NOW date. Also, this request gives the upcoming due issues, but also the overdues. This patch corrects this by using HAVING in query. Test plan : - Create an issue with a date due in the paste - Create an issue with a date due in two days - Launch advance notices with due date in max 2 days : perl misc/cronjobs/advance_notices.pl -c -n -v -m=2 => You get a warn "found 0 issues" - Launch advance notices with due date in max 3 days : perl misc/cronjobs/advance_notices.pl -c -n -v -m=3 => You get a warn "found 1 issues" Signed-off-by: Mathieu Saby I did the following test : - 1 book to check in 2 days - 2 books to check in in the past before applying the patch : $perl ../misc/cronjobs/advance_notices.pl -c -n -v -m=2 getting upcoming due issues at ../misc/cronjobs/advance_notices.pl line 203. found 1 issues at ../misc/cronjobs/advance_notices.pl line 205. I changed the value of "-m" : 0, 1, 2, 3, 4 => always 1 issue found (the book to check in in 2 days) after applying the patch : $perl ../misc/cronjobs/advance_notices.pl -c -n -v -m=2 found 0 issues for m = 0, 1, 2 => 0 issues $perl ../misc/cronjobs/advance_notices.pl -c -n -v -m=3 found 1 issues for m = 3,4,5 => 1 issues (the book to check in in 2 days) Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 16:47:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 14:47:26 +0000 Subject: [Koha-bugs] [Bug 10490] Overdue fines cap (amount) in circulation rules is saved incorrectly (rounded) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10490 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- I don't think the patch should be altering a past database update the way it is. I don't believe it would have any negative effects, but I've had patches fail qa for this reason in the past. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 16:53:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 14:53:04 +0000 Subject: [Koha-bugs] [Bug 10579] Days in Advance cannot be set for Advance Notice in messaging prefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10579 --- Comment #3 from Katrin Fischer --- It's currently only used for predue notices and Koha should set it correctly during installation. If you fix it in the database once now, it should be fine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 16:55:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 14:55:40 +0000 Subject: [Koha-bugs] [Bug 10490] Overdue fines cap (amount) in circulation rules is saved incorrectly (rounded) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10490 --- Comment #5 from Katrin Fischer --- Kyle, if we don't alter the old database update we will have people losing data. If your maxfine was 4.5 it will be 5 in the circulation matrix on update with the maxfine being lost. That's why I chose to also update the old updatedatabase. Running the alter database for already correct installations won't change a thing for them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 16:58:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 14:58:06 +0000 Subject: [Koha-bugs] [Bug 10560] No way to disable english In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10560 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master, along with a follow-up I wrote that adds a regression test. Thanks, Robin! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 17:04:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 15:04:35 +0000 Subject: [Koha-bugs] [Bug 10422] Remove references to unused and non-existent wizard.css In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10422 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 17:11:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 15:11:03 +0000 Subject: [Koha-bugs] [Bug 10527] C4::Branch::get_branch_code_from_name is useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10527 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 17:11:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 15:11:06 +0000 Subject: [Koha-bugs] [Bug 10527] C4::Branch::get_branch_code_from_name is useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10527 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19511|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 19600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19600&action=edit Bug 10527: C4::Branch::get_branch_code_from_name is useless This routine is not in used and does not make sense. It should not be used later. Signed-off-by: Srdjan Signed-off-by: Kyle M Hall Passes koha-qa.pl, not references to get_branch_code_from_name found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 17:12:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 15:12:33 +0000 Subject: [Koha-bugs] [Bug 10490] Overdue fines cap (amount) in circulation rules is saved incorrectly (rounded) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10490 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 17:12:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 15:12:36 +0000 Subject: [Koha-bugs] [Bug 10490] Overdue fines cap (amount) in circulation rules is saved incorrectly (rounded) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10490 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19510|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 19601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19601&action=edit Bug 10490: Overdue fines cap can't store decimal values When overduefinescap was added to the issuingrules the datatype given was decimal. This translates in MySQL to decimal(10,0). This doesn't allow you to store decimal values and therefore values like 4.5 are saved as 5 in the database. To test: On a current installation: 1) Try to enter 4.5 as Overdue fines cap. Verify that the value is not correctly saved. 2) Apply patch and run database update. 3) Try adding/changing an issuing rule setting Overdue fines cap to 4.5 again. 4) Verify the value is saved correctly. Create a new Koha installation from scratch: 1) Verify that the issuingrules table has been created correctly and that you can add/mofidy issuingrules correctly. Because this bug can create data loss, the old database update has also been changed to avoid this problem for people updating at a later point in time. Checkout an older version of Koha pre 3.09.00.027. 1) Run the database updates. 2) Verify again, that adding/modifying issuingrules works correctly. Signed-off-by: Srdjan Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 17:16:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 15:16:15 +0000 Subject: [Koha-bugs] [Bug 10389] Share a list (part 2: accept the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10389 --- Comment #2 from M. de Rooy --- Created attachment 19602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19602&action=edit Bug 10389: Share a list (part 2: accept the invitation) What it does: Test plan: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 17:18:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 15:18:32 +0000 Subject: [Koha-bugs] [Bug 10389] Share a list (part 2: accept the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10389 --- Comment #3 from M. de Rooy --- This patch only shows that there is still progress here.. Still needs some attention though. Not ready for signoff yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 17:22:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 15:22:59 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19234|0 |1 is obsolete| | --- Comment #9 from Jared Camins-Esakov --- Created attachment 19603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19603&action=edit Bug 10402: Move contacts to separate table This patch normalizes the data structures used for bookseller contacts. To test: 1) Repeat tests described on previous patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 17:23:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 15:23:13 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 17:23:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 15:23:16 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19235|0 |1 is obsolete| | --- Comment #10 from Jared Camins-Esakov --- Created attachment 19604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19604&action=edit Bug 10402: Add ability to enter multiple contacts Some vendors may have more than one contact. For example, a technical contact and a billing contact, or a contact for journals and a contact for monographs. Rather than require that each contact be either made into a separate vendor or recorded somewhere outside of Koha, it would be really useful of Koha had the ability to add multiple additional contacts to vendors in the Acquisitions module. To test: 1) Apply patch. 2) Edit a bookseller, making sure to add a contact. 3) View the bookseller's information, making sure the contact information is there. 4) Run the unit test: > prove t/db_dependent/Bookseller.t 5) Add multiple contacts to a vendor, see that they show up. 6) Delete one contact from a vendor with multiple contacts, see that the result is correct. 7) Sign off. Note: This test plan can supersede that on the previous two patches, as all functionality of the previous two patches is required by this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 18:28:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 16:28:59 +0000 Subject: [Koha-bugs] [Bug 10549] ILS-DI should not use ISO-8851-9 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10549 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 18:29:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 16:29:04 +0000 Subject: [Koha-bugs] [Bug 10549] ILS-DI should not use ISO-8851-9 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10549 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19533|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 19605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19605&action=edit ILS-DI should not use ISO-8851-9 encoding This patch changes a few occurences of ISO-8859-1 to UTF-8 within the XML generation of the ILS-DI module. http://bugs.koha-community.org/show_bug.cgi?id=10549 Signed-off-by: Katrin Fischer To test: - Activate ILS-DI system preference - Go to [youropac]/cgi-bin/koha/ilsdi.pl - Check all examples in the documentation for the correct encoding - Check GetAvailability gives you the correct encoding and check the source for the correct encoding Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 18:57:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 16:57:49 +0000 Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 18:57:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 16:57:53 +0000 Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16419|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 19606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19606&action=edit Bug 9532: reserve rules with itemtype on biblio When itemtype is defined on biblio (item-level_itypes syspref), the method C4::Reserves::CanItemBeReserved uses item->{itemtype}. But item comes from C4::Items::GetItem and it does not have a 'itemtype' key, in this method the item type value is always in 'itype' key. This patch corrects it. Test plan: You must have itemtype on biblio and 'item-level_itypes' syspref on biblio. This test plan is with ReservesControlBranch on ItemHomeLibrary. - Choose a branch, a borrower category and an item type, for example 'NYC', 'CHILD' and 'DVD' - Set an issuing rule for 'NYC', CHILD' and 'DVD' with 'Holds allowed' on 10 - Set an issuing rule for 'NYC', CHILD' and all item types with 'Holds allowed' on 0 - Choose an item of a biblio with itemtype 'DVD', that can be reserved, with 'NYC' as homebranch - Choose a borrower with category 'CHILD' - try to reverse the item for the borrower => without the patch, you can => with the patch, you can't You may check reserve is allowed with 'Holds allowed' > 0 on issuing rule for 'DVD'. Signed-off-by: Liz Rea Great test plan - thanks! Confirmed the bug, and the fix. Looks good to me. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 18:58:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 16:58:05 +0000 Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18487|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 19607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19607&action=edit Bug 9532: GetItem must use item-level_itypes syspref Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 19:07:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 17:07:04 +0000 Subject: [Koha-bugs] [Bug 10507] Typo when warning about creating duplicate patron attribute In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10507 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 19:07:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 17:07:09 +0000 Subject: [Koha-bugs] [Bug 10507] Typo when warning about creating duplicate patron attribute In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10507 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19503|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 19608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19608&action=edit Bug 10507 Fix namespace collision in patron entry If a warning about a duplicated patron attribute is returned the value was being passed back for display in the warning message with the same name as the variable in errors as the message is displayed in the context of errors the error value 1 was being displayed not the value duplicated as intended. Pass the value to the template with a unique name Signed-off-by: Owen Leonard I fixed another tiny typo while signing off: "is already in use" instead of "is already is use." Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 19:16:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 17:16:19 +0000 Subject: [Koha-bugs] [Bug 10529] Dollar sign hardcoded in patron message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10529 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 19:16:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 17:16:22 +0000 Subject: [Koha-bugs] [Bug 10529] Dollar sign hardcoded in patron message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10529 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19445|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 19609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19609&action=edit Bug 10529: Remove hardcoded dollar from patron message The message fields which are returned in the SIP Screen message field in a Patron Information response had dollar hardcoded. It would be possible to get the symbol from currency but omitting any symbol would be consistent with the UI and avoid problems with devices using weird encodings for local currency symbols (e.g. the many variations of UK Pound sign) Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 19:30:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 17:30:22 +0000 Subject: [Koha-bugs] [Bug 9801] location facet shows even if no locations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9801 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 19:30:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 17:30:26 +0000 Subject: [Koha-bugs] [Bug 9801] location facet shows even if no locations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9801 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19255|0 |1 is obsolete| | Attachment #19462|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 19610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19610&action=edit Bug 9801 - location facet shows even if no locations Currently, the headings for facets (such as location) are showing even if there are no actual values/links for that facet type. This patch simply checks if the facet array contains any facets before printing the heading and HTML for each facet value/link. Test Plan: Before applying: 0) If you want to check the location facet (which is easiest), enable singlebranch mode in the globals system preferences. 1) Do a search for records/items that you have no shelving location specified (or simply remove the shelving location for a small range of records that you can find in a search query). 2) Note that "Location" appears amongst the facets even though there are no values/links present. (If you look at the HTML source, you'll see some empty HTML tags have been printed out.) Apply patch. 3) Flush your cache and refresh your page. 4) You should no longer see a "Location" facet (or those empty HTML tags) on the facet sidebar. Signed-off-by: Katrin Fischer Template changes only. Checked according to test plan, made sure location facet still shows up when values exist, otherwise it's hidden. It might make sense to add ids to the facets so libraries can decide to hide some of them easily. Or alternatively add a system preference to make that possible. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 19:51:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 17:51:23 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 19:51:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 17:51:27 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18674|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 19611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19611&action=edit Bug 10382 - collection not returning to null when removed from course reserves Test Plan: 1) Create an item, do not set a collection code 2) Add the item to a course, and choose to set a collection code 3) Ensure the course is enabled, and the collection code is now visible 4) Disable the course, ensure the collection code is no longer visible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 20:22:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 18:22:23 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Owen Leonard --- The latest patch corrects this problem: > 3) Looking at the entry on the course detail page, the ccode > column shows "Unchanged ([my ccode])." ...but not this one: > 5) View the detail page for that item: ccode is not null. > It's still the ccode I set it to when I added it to > the course. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 22:16:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 20:16:22 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #50 from Katrin Fischer --- Hi, I think we are not disagreeing :) I meant as we have a quantity field now, maybe we should put the 1 in there by default, but so it can be changed before you create the orders. But we will need Jonathan to take a look to tell us what can be done - maybe I was wrong in my tests when I assumed that you have to fill in quantity, I don't remember if it created the order when I had left it empty, but I thought it had not. Hm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 22:16:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 20:16:26 +0000 Subject: [Koha-bugs] [Bug 10490] Overdue fines cap (amount) in circulation rules is saved incorrectly (rounded) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10490 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 22:24:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 20:24:10 +0000 Subject: [Koha-bugs] [Bug 10527] C4::Branch::get_branch_code_from_name is useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10527 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 22:28:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 20:28:36 +0000 Subject: [Koha-bugs] [Bug 10529] Dollar sign hardcoded in patron message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10529 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 22:31:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 20:31:33 +0000 Subject: [Koha-bugs] [Bug 10583] New: add pinterest to social networks Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10583 Bug ID: 10583 Summary: add pinterest to social networks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com would be nice to have pinterest in the social networks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 22:48:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 20:48:28 +0000 Subject: [Koha-bugs] [Bug 10475] Item form in acquisition not hiding subfields properly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10475 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 22:58:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 20:58:33 +0000 Subject: [Koha-bugs] [Bug 10507] Typo when warning about creating duplicate patron attribute In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10507 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 12 23:30:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 21:30:44 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply QA Contact|koha.sekjal at gmail.com | --- Comment #53 from Katrin Fischer --- Hi Kyle, could you take a look at the conflicts please and submit a new rebased patch? Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 7720 - Ambiguity in OPAC Details location. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Failed to merge in the changes. Patch failed at 0001 Bug 7720 - Ambiguity in OPAC Details location. When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 00:08:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 22:08:57 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- Hm, as there is some progress on DBIX integration now, I think it might be worth to put some more thought into this. Putting this "In Discussion" to get some more opinions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 00:19:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 22:19:13 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 00:28:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 22:28:35 +0000 Subject: [Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- I will test this as it's a consistent change and I think Galen is ok with it? But I agree that we should start to think about how to handle these on permission level. I think AllowRenewalLimitOverride works in combination with a permission, but I am not sure what takes precedence. - Should it be possible to overwrite the global setting with the permission? Should the permission only be offered, when the system preference allows the action in general? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 00:51:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 22:51:33 +0000 Subject: [Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 --- Comment #11 from Katrin Fischer --- Created attachment 19612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19612&action=edit [PASSED QA] Bug 9576 - Enable or disable issue limit confirmation Adds a new system preference AllowTooManyOverride to control whether a librarian can override the 'Too many checked out' message which is currently always overridable. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Attempt to check out 1 more item to a patron than the max issues 4) You should be allowed to override by default ( current behavior ) 5) Set AllowTooManyOverride to "Don't allow" 6) Repeat step 3 7) You should be blocked from being able to issue the item Signed-off-by: Srdjan Signed-off-by: Katrin Fischer The new system preference is activated by default, which mean there will be know change in behaviour on update. The system preference is correctly added to the database and .pref files. Test plan and QA script passes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 00:51:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 22:51:56 +0000 Subject: [Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 00:52:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 22:52:00 +0000 Subject: [Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18722|0 |1 is obsolete| | Attachment #19612|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 19613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19613&action=edit [PASSED QA] Bug 9576 - Enable or disable issue limit confirmation Adds a new system preference AllowTooManyOverride to control whether a librarian can override the 'Too many checked out' message which is currently always overridable. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Attempt to check out 1 more item to a patron than the max issues 4) You should be allowed to override by default ( current behavior ) 5) Set AllowTooManyOverride to "Don't allow" 6) Repeat step 3 7) You should be blocked from being able to issue the item Signed-off-by: Srdjan Signed-off-by: Katrin Fischer The new system preference is activated by default, which mean there will be know change in behaviour on update. The system preference is correctly added to the database and .pref files. Test plan and QA script passes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 00:55:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 22:55:11 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #15 from Katrin Fischer --- David, I am sorry, but the patch doesn't apply any longer, can you please provide a rebased patch? Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 10096 [FOLLOW-UP] - Add a z39.50 interface for authority searching fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 00:57:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 22:57:37 +0000 Subject: [Koha-bugs] [Bug 9328] File::Find::Rule should not be a mandatory dependency for installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- This patch does no longer apply: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 9328, 7167: Remove the File::Find::Rule dependency fatal: sha1 information is lacking or useless (C4/Update/Database.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9328, 7167: Remove the File::Find::Rule dependency When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 01:40:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jul 2013 23:40:17 +0000 Subject: [Koha-bugs] [Bug 10514] Add item link on acquisitions add item is too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #13 from Galen Charlton --- Pushed to master. Thanks, everybody! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 02:00:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 00:00:20 +0000 Subject: [Koha-bugs] [Bug 10584] New: Hide OPAC bibilo details if all items are hidden or there are no items. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 Bug ID: 10584 Summary: Hide OPAC bibilo details if all items are hidden or there are no items. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: mtompset at hotmail.com Using the OpacHiddenItems systempreference, items can be hidden. However, it looks strange to have a biblio entry in the OPAC if all the items are hidden or there are no items. In this case, hide the biblio too. Test ==== 1) Find a biblio with multiple item records across multiple branches. 2) View it in OPAC. 3) In the staff client hide one of the branches using OpacHiddenItems. 4) Refresh the OPAC details. There should be less, because of the hidden branch. 5) In the staff client hide all of the branches (e.g. homebranch: [BR01,BR02]) 6) Refresh the OPAC details. A biblio entry with no items will be displayed. 7) In the staff client enter a dummy biblio record, with no items. 8) View the OPAC details for that biblio. A biblio entry with no items will be displayed. NOTE: There is a tiny scope creep, in that a silent warning hazard for the biblionumber was also corrected. (forgive me) 9) Go to .../cgi-bin/koha/opac-detail.pl?biblionumber= with no number entered. There should be a 404 output page. 10) Check the opac error log file. There should be a warning related to the int(undef) 11) Apply the patch. 12) Go to .../cgi-bin/koha/opac-detail.pl?biblionumber= with no number entered. There should be a 404 output page. 13) There should be no new warning. 14) Go to the dummy biblio that you entered (.../cgi-bin/koha/opac-detail.pl?biblionumber=#####). There should be a 404 output page. 15) Go back to the initial biblionumber (.../cgi-bin/koha/opac-detail.pl?biblionumber=#####). There should be a 404 output page. Displaying 404.pl is not the best or correct solution (see bug 2318's comment discussion), but it is sufficient, until that gets corrected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 02:10:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 00:10:26 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |mtompset at hotmail.com Summary|Hide OPAC bibilo details if |Hide OPAC bibilo details if |all items are hidden or |all items are hidden. |there are no items. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 02:11:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 00:11:34 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 --- Comment #1 from M. Tompsett --- As per a discussion with jcamins, hiding biblios with no items is a bad thing (tm). Only going to touch hidden items case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 02:36:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 00:36:29 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 --- Comment #2 from M. Tompsett --- Created attachment 19614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19614&action=edit If there is at least one item and every item is hidden, hide the biblio entry. REVISED Test ============ 1) Find a biblio with multiple item records across multiple branches. 2) View it in OPAC. 3) In the staff client hide one of the branches using OpacHiddenItems. 4) Refresh the OPAC details. There should be less, because of the hidden branch. 5) In the staff client hide all of the branches (e.g. homebranch: [BR01,BR02]) 6) Refresh the OPAC details. A biblio entry with no items will be displayed. 7) In the staff client enter a dummy biblio record, with no items. 8) View the OPAC details for that biblio. A biblio entry with no items will be displayed. NOTE: There is a tiny scope creep, in that a silent warning hazard for the biblionumber was also corrected. (forgive me) 9) Go to .../cgi-bin/koha/opac-detail.pl?biblionumber= with no number entered. There should be a 404 output page. 10) Check the opac error log file. There should be a warning related to the int(undef) 11) Apply the patch. 12) Go to .../cgi-bin/koha/opac-detail.pl?biblionumber= with no number entered. There should be a 404 output page. 13) There should be no new warning. 14) Go to the dummy biblio that you entered (.../cgi-bin/koha/opac-detail.pl?biblionumber=#####). There should be an empty items section. 15) Go back to the initial biblionumber (.../cgi-bin/koha/opac-detail.pl?biblionumber=#####). There should be a 404 output page. Displaying 404.pl is not the best or correct solution (see bug 2318's comment discussion), but it is sufficient, until that gets corrected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 02:37:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 00:37:16 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 09:25:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 07:25:01 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #43 from Katrin Fischer --- I have started testing this yesterday and after sleeping over it, there is something that worries me: 1) After update, the new column publisheddatetext is empty in the database for all existing issues, but when you receive new issues, the field is always filled with the publisheddate if you don't change it manually. My feeling is, that we should not fill the field, when there is no new information in it. Also, is it helpful if you have to delete the date first before you can type in "April 2013"? In the templates that would work nicely as they already fall back to the publisheddate when the new field is empty: [% newserialloo.publisheddatetext || newserialloo.publisheddate %] 2) If you are going to touch the patches - could you also add the bug number to the updatedatabase? 3) The table in serials-edit.pl is a little broken, when you are adding items for each issue. The colspan needs to be increased to 6 there now in the last row. Click to add item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 09:39:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 07:39:16 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 --- Comment #41 from Katrin Fischer --- Comment on attachment 18964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18964 [Signed off] Bug 7639 - system preference to forgive fines on lost items Review of attachment 18964: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7639&attachment=18964) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +3281,3 @@ > > > sub LostItem{ LostItem seems a bit undertested. Could you throw in some regression tests? ::: cataloguing/additem.pl @@ +607,5 @@ > $itemnumber=""; > } > + my $item = GetItem( $itemnumber ); > + my $olditemlost = $item->{'itemlost'}; > + my $newitemlost = $itemtosave->subfield('952','1'); (Major) This won't work for UNIMARC, please check which field is linked to items.lost instead. ::: installer/data/mysql/updatedatabase.pl @@ +6993,5 @@ > +$DBversion = "3.13.00.XXX"; > +if (C4::Context->preference("Version") < TransformToNum($DBversion)) { > + $dbh->do("INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES('WhenLostForgiveFine','0',NULL,'If ON, Forgives the fines on an item when it is lost.','YesNo')"); > + $dbh->do("INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES('WhenLostChargeReplacementFee','1',NULL,'If ON, Charge the replacement price when a patron loses an item.','YesNo')"); > + print "Upgrade to $DBversion done (Added sysprefs WhenLostForgiveFine and WhenLostChargeReplacementFee)\n"; (Trivial) - Please add the bug number here for reference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 09:39:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 07:39:38 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 09:40:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 07:40:59 +0000 Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18969|0 |1 is patch| | Attachment #18969|application/octet-stream |text/plain mime type| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 10:14:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 08:14:56 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- This still needs testing, but I didn't spot problems while reviewing the code. Only wondering if we should offer the branchcode as another option in the script. GetBorrowersToExpunge would allow it already: 2025 =head2 GetBorrowersToExpunge 2026 2027 $borrowers = &GetBorrowersToExpunge( 2028 not_borrowered_since => $not_borrowered_since, 2029 expired_before => $expired_before, 2030 category_code => $category_code, 2031 branchcode => $branchcode 2032 ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 14:07:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 12:07:45 +0000 Subject: [Koha-bugs] [Bug 9370] use Library::CallNumber::LC when splitting LC call numbers for spine labels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #16 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 14:56:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 12:56:26 +0000 Subject: [Koha-bugs] [Bug 10297] categorycode and branchcode should be required when adding patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10297 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 16:08:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 14:08:40 +0000 Subject: [Koha-bugs] [Bug 10443] Table borrower_files does not exists in kohastructure.sql file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10443 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 16:44:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 14:44:49 +0000 Subject: [Koha-bugs] [Bug 10458] Remove obsolete Z3950 module and test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10458 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |bgkriegel at gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel --- This has been already pushed to 3.12.x Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 19:29:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 17:29:06 +0000 Subject: [Koha-bugs] [Bug 10425] Help page missing for Local Use preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10425 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #12 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 19:49:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 17:49:36 +0000 Subject: [Koha-bugs] [Bug 10466] Lists: Use "size" as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10466 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 19:53:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 17:53:59 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #10 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 20:03:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 18:03:09 +0000 Subject: [Koha-bugs] [Bug 10464] Patron search on placing a hold doesn't use jqueryui.autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 20:17:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 18:17:36 +0000 Subject: [Koha-bugs] [Bug 10439] Cannot modify the notice's library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10439 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #7 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 22:46:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 20:46:49 +0000 Subject: [Koha-bugs] [Bug 10189] French values in cataloging plugins for unimarc 128b and 128c fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10189 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 22:46:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 20:46:55 +0000 Subject: [Koha-bugs] [Bug 10189] French values in cataloging plugins for unimarc 128b and 128c fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10189 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17943|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 19615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19615&action=edit Bug 10189 : Translate values in unimarc 128b/c cataloguing plugins in english Cataloguing plugins for UNIMARC 128b and 128c fields are only in french. This patch translates them. Source : http://blue.lins.fju.edu.tw/mao/marc/unicon.htm Note : 128b and 128c are deprecated in last version of UNIMARC Manual (field 145 used instread). But they are still used in French Sudoc network. To test : in a UNIMARC english Koha, edit a record and use 128b and 128c cataloguing plugins. Check everything is in english. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 13 23:45:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 21:45:17 +0000 Subject: [Koha-bugs] [Bug 10272] CheckReserves returns not respecting ReservesControlBranch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #17 from Katrin Fischer --- Kyle, can you please rebase and switch back to signed off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 00:49:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 13 Jul 2013 22:49:23 +0000 Subject: [Koha-bugs] [Bug 10396] Catalog stats shows calendar in callnumber field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10396 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #14 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 08:08:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 06:08:39 +0000 Subject: [Koha-bugs] [Bug 2500] Standing enhancement request for adding/updating call number splitting algorithms in C4/Labels.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2500 Iming Chan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |imingchan at yahoo.com.au --- Comment #17 from Iming Chan --- Hello, 1. The DDC number: 629.283042 2. Class format: Dewey 3. I would like the call number to appear as: 629. 283 042 Automatically text wrap in groups of three after the decimal point. This is how spine labels from our previous system generated, and fits perfectly to our current stationery. Please also keep (found in the current splitting algorithm) as this is useful for call number like: DVD 629.283042 FRAS to appear as: DVD 629. 283 042 FRAS -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 09:00:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 07:00:45 +0000 Subject: [Koha-bugs] [Bug 10236] software error greek authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10236 --- Comment #2 from Chris Cormack --- Created attachment 19616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19616&action=edit Bug 10236 - software error greek authorities When displaying at OPAC an authority containing several languages forms, we get a software error. There is in authority template page a call to "language" function but this function does not exist. This patch copies behaviour from bug 8870 (pushed in 3.10) which introduces the "language function". Test plan (unimarc) : - create an authority with 2 fields 700 with : 700$7 ba0yga0y $8 fregrc $a ???????? 700$7 ba0yba0a $8 frefre $a Cinnamos - display this authority at OPAC => you should see : See also Greek term: ???????? See also French term: Cinnamos Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 09:01:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 07:01:23 +0000 Subject: [Koha-bugs] [Bug 10236] software error greek authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10236 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18116|0 |1 is obsolete| | CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 09:01:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 07:01:32 +0000 Subject: [Koha-bugs] [Bug 10236] software error greek authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10236 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 09:09:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 07:09:06 +0000 Subject: [Koha-bugs] [Bug 10575] UT: GetOrdersByBiblionumber.t needs a database transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10575 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 09:09:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 07:09:10 +0000 Subject: [Koha-bugs] [Bug 10575] UT: GetOrdersByBiblionumber.t needs a database transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10575 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19573|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 19617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19617&action=edit Bug 10575 : GetOrdersByBiblionumber.t needs a database transaction Before this patch, the queries in GetOrdersByBiblionumber.t were commited in the database and have to be removed at the end. This patch wraps tests in a database transaction. Test Plan : prove t/db_dependent/Acquisition/GetOrdersByBiblionumber.t t/db_dependent/Acquisition/GetOrdersByBiblionumber.t .. ok All tests successful. Files=1, Tests=3, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.37 cusr 0.05 csys = 0.45 CPU) Result: PASS Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 09:17:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 07:17:36 +0000 Subject: [Koha-bugs] [Bug 10575] UT: GetOrdersByBiblionumber.t needs a database transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10575 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 09:17:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 07:17:41 +0000 Subject: [Koha-bugs] [Bug 10575] UT: GetOrdersByBiblionumber.t needs a database transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10575 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19617|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 19618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19618&action=edit [PASSED QA] Bug 10575 : GetOrdersByBiblionumber.t needs a database transaction Before this patch, the queries in GetOrdersByBiblionumber.t were commited in the database and have to be removed at the end. This patch wraps tests in a database transaction. Test Plan : prove t/db_dependent/Acquisition/GetOrdersByBiblionumber.t t/db_dependent/Acquisition/GetOrdersByBiblionumber.t .. ok All tests successful. Files=1, Tests=3, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.37 cusr 0.05 csys = 0.45 CPU) Result: PASS Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 09:30:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 07:30:09 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Dunno how I managed to sign off on this, But I am now getting Software error: Undefined subroutine &C4::Reserves::GetBranchItemRule called at /home/chrisc/git/catalyst-koha/C4/Reserves.pm line 437. When trying to place a hold in the opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 09:30:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 07:30:33 +0000 Subject: [Koha-bugs] [Bug 10541] Enable cross-browser AJAX in additem.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10541 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I have run into this in training as well and glad to see a patch for it as this has been quite a blocker bug for the library. There are also IE problems in serials and other modules - maybe we shold fix all IndexOf appearances? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 09:37:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 07:37:19 +0000 Subject: [Koha-bugs] [Bug 10499] UT: VirtualShelves.t needs a database transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10499 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 09:37:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 07:37:24 +0000 Subject: [Koha-bugs] [Bug 10499] UT: VirtualShelves.t needs a database transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10499 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19343|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 19619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19619&action=edit [PASSED QA] Bug 10499: VirtualShelves.t - wrap tests in a database connection Before this patch, the queries in VirtualShelves.t were committed in the database and have to be removed at the end. This patch wraps tests in a database connection. Test plan: prove t/db_dependent/VirtualShelves.t VirtualShelves.t .. ok All tests successful. Files=1, Tests=72, 1 wallclock secs ( 0.06 usr 0.00 sys + 0.72 cusr 0.06 csys = 0.84 CPU) Result: PASS Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer All tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 09:39:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 07:39:45 +0000 Subject: [Koha-bugs] [Bug 10499] UT: VirtualShelves.t needs a database transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10499 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- And welcome Kenza - thx for your patches :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 09:52:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 07:52:33 +0000 Subject: [Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 09:52:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 07:52:38 +0000 Subject: [Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19405|0 |1 is obsolete| | Attachment #19406|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 19620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19620&action=edit [PASSED QA] Bug 10274: UT: Acquisition.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition.t And after, it should produce: t/db_dependent/Acquisition.t .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.03 usr 0.00 sys + 0.42 cusr 0.02 csys = 0.47 CPU) Result: PASS Signed-off-by: Jared Camins-Esakov Tests pass and the bookseller is deleted. Signed-off-by: Katrin Fischer All tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 09:53:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 07:53:23 +0000 Subject: [Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 --- Comment #12 from Katrin Fischer --- Created attachment 19621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19621&action=edit [PASSED QA] Bug 10274: Execute sql queries into a transaction Signed-off-by: Katrin Fischer All tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 10:07:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 08:07:56 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Katrin Fischer --- Hm, I know SIP is hard to test, but feeling a bit uncomfortable about the QA follow ups not having any sign off while they are adding a new sub to C4. I see there is one changed test, but I can't get it to work and there is also that: http://koha.1045719.n5.nabble.com/Test-suite-in-t-db-dependent-lib-KohaTest-td5760084.html Switching to "Failed QA" for missing unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 10:10:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 08:10:53 +0000 Subject: [Koha-bugs] [Bug 8911] docs/history.txt file missing for about.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Robin, could you take a look at this please? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 10:43:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 08:43:17 +0000 Subject: [Koha-bugs] [Bug 10275] UT: OrderFromSubscription.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10275 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 10:43:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 08:43:21 +0000 Subject: [Koha-bugs] [Bug 10275] UT: OrderFromSubscription.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10275 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19286|0 |1 is obsolete| | Attachment #19306|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 19622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19622&action=edit [PASSED QA] Bug 10275: UT: OrderFromSubscription.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition/OrderFromSubscription.t And after, it should produce: t/db_dependent/Acquisition/OrderFromSubscription.t .. ok All tests successful. Files=1, Tests=12, 2 wallclock secs ( 0.02 usr 0.00 sys + 0.46 cusr 0.02 csys = 0.50 CPU) Result: PASS And some warnings... Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes tests. Assumes Dateformat is set to US dates as in the sample data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 10:43:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 08:43:35 +0000 Subject: [Koha-bugs] [Bug 10275] UT: OrderFromSubscription.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10275 --- Comment #7 from Katrin Fischer --- Created attachment 19623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19623&action=edit [PASSED QA] Bug 10275: Use a transaction for OrderFromSubscription.t Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 11:02:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 09:02:03 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer --- Hi Magnus, I am sorry, but I found a bug: 1) (Major) You can no longer create new itemtypes, as we are missing a ?: [Sun Jul 14 10:58:14 2013] [error] [client 127.0.0.1] [Sun Jul 14 10:58:14 2013] itemtypes.pl: DBD::mysql::st execute failed: called with 7 bind variables when 6 are needed at /home/katrin/kohaclone/admin/itemtypes.pl line 174., referer: http://localhost:8080/cgi-bin/koha/admin/itemtypes.pl?op=add_form [Sun Jul 14 10:58:17 2013] [error] [client 127.0.0.1] File does not exist: /home/katrin/kohaclone/koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/sudoc, referer: http://localhost:8080/cgi-bin/koha/admin/itemtypes.pl 2) (Trivial) Can you please add an AFTER summary to your database update? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 11:53:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 09:53:25 +0000 Subject: [Koha-bugs] [Bug 10127] Printoverdues.sh should tar only pdf files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10127 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|fridolyn.somers at biblibre.co |sophie.meynieux at biblibre.co |m |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 11:53:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 09:53:42 +0000 Subject: [Koha-bugs] [Bug 10127] Printoverdues.sh should tar only pdf files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10127 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|sophie.meynieux at biblibre.co |fridolyn.somers at biblibre.co |m |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 12:40:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 10:40:41 +0000 Subject: [Koha-bugs] [Bug 10127] Printoverdues.sh should tar only pdf files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10127 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 12:40:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 10:40:45 +0000 Subject: [Koha-bugs] [Bug 10127] Printoverdues.sh should tar only pdf files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10127 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19287|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 19624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19624&action=edit [PASSED QA] Bug 10127 : Printoverdues.sh should tar only pdf files Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer >From the bug report: At the end of printoverdues.sh, an archive is generated containing all files present in directory given as parameter. As archives are generated in this given directory, they contain previously generated tar files, creating oversized files. Only .pdf files should be archived All tests and QA script pass. Worked ok in my tests, only packign PDF in the given directory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 12:48:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 10:48:58 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 12:49:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 10:49:16 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 12:49:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 10:49:45 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 12:50:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 10:50:18 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 13:17:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 11:17:11 +0000 Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- I have copied the files into the right places in my koha-dev directory and reindexed with -r. Also I cataloged a new item with a unique inventorynumber and reindexed with -z. I can find my inventorynumber using a simple keyword search and using inv=inventorynumber. The search examples given in the patch don't work for me. Also stocknumber= and Number-local-acquisition= don't work. I have turned off the QueryParser for testing this. Fridolyn, can you explain? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 13:24:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 11:24:21 +0000 Subject: [Koha-bugs] [Bug 10585] New: Adding multiple items to cart in OPAC broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10585 Bug ID: 10585 Summary: Adding multiple items to cart in OPAC broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de To test: - Search for any keyword - Select a couple of records from the result list - Use "Add to" select "cart" hit save - Verify message shown in cart is: No item was selected - Verify your records can be added one by one using the link in "Actions" section of your result list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 13:25:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 11:25:23 +0000 Subject: [Koha-bugs] [Bug 10585] Adding multiple items to cart in OPAC broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10585 --- Comment #1 from Katrin Fischer --- Tested in Firefox and Chromium. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 13:28:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 11:28:57 +0000 Subject: [Koha-bugs] [Bug 10376] Printing cart does not work under IE9 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10376 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 13:29:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 11:29:00 +0000 Subject: [Koha-bugs] [Bug 10376] Printing cart does not work under IE9 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10376 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18723|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 19625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19625&action=edit [PASSED QA] Bug 10376: Printing cart does not work under IE9 Test plan: 1) Test with Firefox (or any other browser except IE): Add biblio to cart Go to Cart and click Print Does the Cart window come back to its original state after confirm/cancel Print? 2) Test with Internet Explorer (I used IE9; testing another version is fine) Do the same as above. Is behavior now more or less the same? Signed-off-by: Marc Veron 1) Test without patch: IE 10: Does not show print dialog IE 9 (Developer Emulation in IE 10): Does not show print dialog (as expected) FF 21.0 OK Chrome 27.0.1453.110 m: OK 2) Test with patch: IE 10: OK IE 9 (Developer Emulation in IE 10): OK IE 8 (Developer Emulation in IE 10): OK IE 7 (Developer Emulation in IE 10): OK FF 21.0 OK Chrome 27.0.1453.110 m: OK Signed-off-by: Katrin Fischer Trusting Marc here, as I don't have IE available. Regression tests in Firefox and Chromium went well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 13:31:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 11:31:40 +0000 Subject: [Koha-bugs] [Bug 10586] New: Printing cart from Firefox seems to be missing CSS Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10586 Bug ID: 10586 Summary: Printing cart from Firefox seems to be missing CSS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de To test: - Print a cart from Firefox - Print a cart from Chromium In my tests Chromium printed the table borders nicely formated using a non-serif font for the text, while Firefox printed using a serif font and the table without border lines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 13:33:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 11:33:29 +0000 Subject: [Koha-bugs] [Bug 10585] Adding multiple items to cart in OPAC broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10585 --- Comment #2 from Katrin Fischer --- Hm, it works well in a 3.12.1 installation, so must be something pushed recently or a problem with my installation - can someone confirm the problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 13:36:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 11:36:37 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 13:44:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 11:44:33 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 13:44:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 11:44:36 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18020|0 |1 is obsolete| | Attachment #19496|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 19626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19626&action=edit [PASSED QA] Bug 10170: strings in MARC import made translatable Following bug 9215: non translatable strings are now present in the template and translatable Signed-off-by: Chris Cormack Not only does this make the strings translatable it makes the template a lot easier to read Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer All tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 13:44:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 11:44:57 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 --- Comment #10 from Katrin Fischer --- Created attachment 19627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19627&action=edit [PASSED QA] Bug 10170: expose more managed staged MARC strings to translation This commit makes it possible to translated the 'staged' and 'error' record statuses as well as the 'auto_match' overlay status. Also takes out a bit of HTML cruft in one string that is not needed for translation. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer All tests pass. New strings are parsed into the po files: "%s Always add items %s Add items only if matching bib was found %s Add items only if no matching bib was found %s Ignore items %s %s %s %s " "%s No match %s Match applied %s Match found %s %s %s " -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 13:52:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 11:52:24 +0000 Subject: [Koha-bugs] [Bug 10587] New: HTML errors on authority detail page in OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587 Bug ID: 10587 Summary: HTML errors on authority detail page in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de CC: jcamins at cpbibliography.com When checking the source code for some ids and classed I found that Firefox showed some red error marks in the source code. It seems 2 divs are closed, but not opened. The W3C HTML validator also points out those: Error Line 357, Column 10: End tag div seen, but there were open elements. Error Line 256, Column 24: Unclosed element ul.
    Error Line 381, Column 6: Stray end tag div. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 13:59:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 11:59:20 +0000 Subject: [Koha-bugs] [Bug 10189] French values in cataloging plugins for unimarc 128b and 128c fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10189 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3007 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 13:59:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 11:59:20 +0000 Subject: [Koha-bugs] [Bug 3007] four UNIMARC value_builder templates to translate to English In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3007 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10189 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 14:02:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 12:02:13 +0000 Subject: [Koha-bugs] [Bug 10189] French values in cataloging plugins for unimarc 128b and 128c fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10189 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 14:02:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 12:02:18 +0000 Subject: [Koha-bugs] [Bug 10189] French values in cataloging plugins for unimarc 128b and 128c fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10189 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19615|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 19628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19628&action=edit [PASSED QA] Bug 10189 : Translate values in unimarc 128b/c cataloguing plugins in english Cataloguing plugins for UNIMARC 128b and 128c fields are only in french. This patch translates them. Source : http://blue.lins.fju.edu.tw/mao/marc/unicon.htm Note : 128b and 128c are deprecated in last version of UNIMARC Manual (field 145 used instread). But they are still used in French Sudoc network. To test : in a UNIMARC english Koha, edit a record and use 128b and 128c cataloguing plugins. Check everything is in english. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Thx for translating those! Verified new strings get parsed into the po files. Templates still contain lots of tabs, those can be fixed separately. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 14:05:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 12:05:21 +0000 Subject: [Koha-bugs] [Bug 3007] four UNIMARC value_builder templates to translate to English In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3007 --- Comment #3 from Katrin Fischer --- Bug 10189 takes care of 2 untranslated plugins, that leaves: unimarc_field_700-4.tmpl macles.tmpl -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 14:12:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 12:12:54 +0000 Subject: [Koha-bugs] [Bug 9770] C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9770 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 14:12:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 12:12:58 +0000 Subject: [Koha-bugs] [Bug 9770] C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9770 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19386|0 |1 is obsolete| | Attachment #19387|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 19629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19629&action=edit [PASSED QA] Bug 9770: test case for sorting of Dewey call numbers that contain prefixes This adds a test for C4::ClassSortRoutine::Dewey to check that the call number "JR DVD 800.1" sorts before "JR DVD 900" To test: [1] Apply just this patch. [1] Run prove -v t/ClassSortRoutine_Dewey.t [2] Test #7 should fail. Signed-off-by: Jason Etheridge Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes test plan and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 14:13:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 12:13:14 +0000 Subject: [Koha-bugs] [Bug 9770] C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9770 --- Comment #11 from Katrin Fischer --- Created attachment 19630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19630&action=edit [PASSED QA] Bug 9770: fix sorting of Dewey call numbers that contain prefixes C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally. The subroutine get_class_sort_key tokenizes a call number string (splitting on periods and whitespace) and counts the number of tokens that solely contain digits. If there is only one such digit group, a comment in the code states that it will pad said digit group. However, the bug is that the code assumes said digit group is the first token, when this may not be the case. In practice, this can cause poor sorting when used a call number is in the form of PREFIX _space_ 3DIGITS. To test: [1] Create two item records whose class scheme is set to 'ddc' (Dewey) and whose call numbers contain prefixes, e.g., J DVD 700.1 ABC and J DVD 850 DEF. [2] Use the inventory tool to produce a list of item items that include the two created in step 1. Obsere that that items are sorted in the incorrect order, with "J DVD 850 DEF" coming before "J DVD 700.1 ABC". Alternatively, run the following SQL to see the incorrect sort order: SELECT cn_sort, itemcallnumber FROM items WHERE itemcallnumber LIKE 'J DVD%' ORDER BY cn_sort; [4] Apply this patch. [5] Run misc/maintenance/touch_all_items.pl to force cn_sort to be recalculated. [6] Repeat step 2 and verify that the call numbers are now sorted corrected. Signed-off-by: Jason Etheridge Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 14:38:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 12:38:48 +0000 Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 14:38:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 12:38:51 +0000 Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19272|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 19631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19631&action=edit [PASSED QA] Bug 6254 - can't set patron privacy by default There is currently no way to set the privacy setting for newly created patrons. This patch adds the system preference NewPatronPrivacySetting to define what privacy setting new patrons should have. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a new patron 4) Verify the patron's privacy is set to 1 5) Set NewPatronPrivacySetting to "never" 6) Create a new patron 7) Verify the patron's privacy is set to 2 8) Set NewPatronPrivacySetting to "forever" 9) Create a new patron 10) Verify the patron's privacy is set to 0 Signed-off-by: Liz Rea Tested per plan, all looks ok. Signed-off-by: Katrin Fischer Passes all tests and QA script. Additional tests done: - Verified syspref.sql insert works alright - Checked editing patrons left privacy untouched. - Checked importing patrons with overlay leaves privacy alone if not provided. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 14:39:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 12:39:12 +0000 Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- Functionality wise this works and passes QA, but I am not so happy about the system preference description: NewPatronPrivacySetting: New patrons should have a privacy setting of default|never|forever I don't thinks this explains what this setting will do to a librarian trying to configure Koha and without deeper knowledge about the features and terminology. Also "Privacy" is a pretty broad term and this only affects how long we keep the reading history. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 15:42:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 13:42:49 +0000 Subject: [Koha-bugs] [Bug 9541] Opac-user doesn't load correct CSS for multiple branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9541 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 15:46:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 13:46:38 +0000 Subject: [Koha-bugs] [Bug 9410] Formatting of the discount field when doing a new order from new empty record is not correct In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- Hm, there is some inconsistency in how we format tax and discount in various places in Koha: Tax: Available tax values are controlled by system preference gist. It's possible to enter values <1% there but the display shows max 2dp%. Example: gist: 0.066, display when selecting: 0.7%, display in order summary page: 2dp. tax any gist (input field, no validation) 1dp discount 1dp Vendor - summary 1dp Vendor - edit (display of saved value) any Vendor - edit (input field, no validation) 2dp Order - order line edit/add (with patch) - Order - summary, doesn't show discount - Receive, doesn't show discount -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 15:54:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 13:54:33 +0000 Subject: [Koha-bugs] [Bug 9410] Formatting of the discount field when doing a new order from new empty record is not correct In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #8 from Katrin Fischer --- Accidentally submitted the form earlier, let's try that again: There is some inconsistency in how we format tax and discount in various places in Koha: Tax: Available tax values are controlled by system preference gist. It's possible to enter values <1% there but the display shows max 2dp%. Example: gist: 0.066, display in pull down: 0.7%, display in order summary page 0.66. tax any gist (input field, no validation) 1dp pull down used for add/edit/modify in vendor and order lines 1dp Order - summary, rounded 2dp Receive - summary discount 1dp Vendor - summary 1dp Vendor - edit (display of saved value) any Vendor - edit (input field, no validation) 2dp Order - order line edit/add (with patch) - Order - summary, doesn't show discount - Receive - summary, doesn't show the discount So we have some mismatch here - I am not sure right now how to solve it. Can we get some opinions on this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 15:58:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 13:58:49 +0000 Subject: [Koha-bugs] [Bug 9826] Missing fields in MARC21 authority framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9826 --- Comment #11 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 16:11:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 14:11:14 +0000 Subject: [Koha-bugs] [Bug 10447] Language definitions for 'ru' and 'uk' are not available during install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10447 --- Comment #7 from Katrin Fischer --- Created attachment 19632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19632&action=edit [PASSED QA] Bug 10447 - Language definitions for 'ru' and 'uk' are not available during install This patch add the option to choose 'ru' and 'uk' during install for zebra. Should work for a tarball install, and make 'ru' and 'uk' available for using with koha-create too. Regards To+ Sponsored-by: Universidad Nacional de C?rdoba Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Reran Makefile.pl and made sure the language options show up now. Patch extends existing language code lists addings nb, ru and uk where missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 16:11:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 14:11:46 +0000 Subject: [Koha-bugs] [Bug 10447] Language definitions for 'ru' and 'uk' are not available during install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10447 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 16:11:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 14:11:48 +0000 Subject: [Koha-bugs] [Bug 10447] Language definitions for 'ru' and 'uk' are not available during install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10447 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19224|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 16:12:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 14:12:45 +0000 Subject: [Koha-bugs] [Bug 10379] koha-rebuild-zebra gets noisy if no instances are defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10379 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 16:17:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 14:17:42 +0000 Subject: [Koha-bugs] [Bug 10474] Translate some missed English strings in German sample notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10474 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 16:48:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 14:48:38 +0000 Subject: [Koha-bugs] [Bug 10317] Parcel should display a message when called with an nonexistent invoiceid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10317 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 17:21:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 15:21:37 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #21 from Katrin Fischer --- The tests are all passing now - I think my qa-tools were not up to date at that point :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 17:42:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 15:42:07 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #22 from Katrin Fischer --- Created attachment 19633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19633&action=edit Patron module start page Adding some notes about my findings here: 1) (Normal) Sorting: I think it would be nice if fines, circ notes and checkouts would be sortable too. I know checkouts is a bit difficult, but if it was sortable you could easily find those with checkouts at least. 2) (Trivial) There is some wrong capitalization, that was already there before and now appears in the filters too: Street Address > Street address 3) (Major) Filters: I tried to limit the search to a specific patron category and while it said "Processing" nothing happened and the page seemed broken. I had to reload the page. Same happens when I search for a name using the normal search. Not sure what's going wrong here. I checked the logs, pasting some of the errors here: [Sun Jul 14 17:28:35 2013] [error] [client 127.0.0.1] [Sun Jul 14 17:28:35 2013] search: DBD::mysql::st fetchrow_array failed: fetch() without execute() at /home/katrin/kohaclone/C4/Utils/DataTables/Members.pm line 110., referer: http://localhost:8080/cgi-bin/koha/members/member.pl [Sun Jul 14 17:28:43 2013] [error] [client 127.0.0.1] [Sun Jul 14 17:28:43 2013] search: DBD::mysql::st execute failed: FUNCTION categories.categorycodeWHERE does not exist at /home/katrin/kohaclone/C4/Utils/DataTables/Members.pm line 109., referer: http://localhost:8080/cgi-bin/koha/members/member.pl [Sun Jul 14 17:28:43 2013] [error] [client 127.0.0.1] [Sun Jul 14 17:28:43 2013] search: DBD::mysql::st fetchrow_array failed: fetch() without execute() at /home/katrin/kohaclone/C4/Utils/DataTables/Members.pm line 110., referer: http://localhost:8080/cgi-bin/koha/members/member.pl [Sun Jul 14 17:29:09 2013] [error] [client 127.0.0.1] [Sun Jul 14 17:29:09 2013] search: DBD::mysql::st execute failed: FUNCTION categories.categorycodeWHERE does not exist at /home/katrin/kohaclone/C4/Utils/DataTables/Members.pm line 109., referer: http://localhost:8080/cgi-bin/koha/members/member.pl [Sun Jul 14 17:29:09 2013] [error] [client 127.0.0.1] [Sun Jul 14 17:29:09 2013] search: DBD::mysql::st fetchrow_array failed: fetch() without execute() at /home/katrin/kohaclone/C4/Utils/DataTables/Members.pm line 110., referer: http://localhost:8080/cgi-bin/koha/members/member.pl 4) (Trivial) There is something a little odd about the datatables CSS - the first part of the controls is a darker grey than the second part starting with "First". 5) Wishlist: Could we rename the column Cat = Category? I remember all too well when someone (probably me) translated it to "Katze" :) But not sure if that takes up too much room or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 17:43:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 15:43:47 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Katrin Fischer --- On the screenshot are some more odd things, but they went away when I reloaded the page and JS. But you can see the little color difference in the datatables controls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 18:20:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 16:20:34 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #22 from Katrin Fischer --- Patches no longer apply cleanly for a conflict in Acquisitions.pm. Jonathan, could you double check those lines here, rebase and switch back to signed off? - &NewOrder &DelOrder &ModOrder &GetPendingOrders &GetOrder &GetOrders &GetOrdersByBiblionumber + &NewOrder &DelOrder &ModOrder &GetOrder &GetOrders &GetOrdersByBiblionumber + &NewOrder &DelOrder &ModOrder &GetOrder &GetOrders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 18:48:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 16:48:11 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #51 from Katrin Fischer --- Jonathan, I think Mathieu has some good points here for the duplicate check and the quantity - could you take a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 23:15:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 21:15:58 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 --- Comment #9 from Jared Camins-Esakov --- Created attachment 19634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19634&action=edit Bug 5202 QA follow-up: quiet warnings Due to massively incorrect data in the default authority frameworks, we were getting warnings about undefined values and spaces from checking which tab subfields/fields were displayed in. This patch eliminates those warnings. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 23:16:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 21:16:27 +0000 Subject: [Koha-bugs] [Bug 9458] Add sorting to lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9458 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #34 from Bernardo Gonzalez Kriegel --- On request, a slightly modified version of this is included in 3.10.x, it changes a little, only add sort capability to lists by Author/Title. Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 14 23:24:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 14 Jul 2013 21:24:16 +0000 Subject: [Koha-bugs] [Bug 9833] New virtual shelves/lists permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 --- Comment #11 from Liz Rea --- The lists owned by NULL happens when the borrower that created the list is deleted. That's probably a different bug than this. Matthias, any chance of getting this fixed up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 03:15:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 01:15:20 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 --- Comment #16 from David Cook --- (In reply to Katrin Fischer from comment #15) > David, I am sorry, but the patch doesn't apply any longer, can you please > provide a rebased patch? > > Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y > Applying: Bug 10096 [FOLLOW-UP] - Add a z39.50 interface for authority > searching > fatal: sha1 information is lacking or useless > (koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. Alas, I think that's Mason's follow-up, so he'll need to provide the rebased version. I can rebase my original, but it would be unfortunate to have to lose/redo his follow-ups. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 07:36:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 05:36:30 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 09:29:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 07:29:14 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #12 from Jonathan Druart --- Created attachment 19635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19635&action=edit Bug 10419: Add the branchcode parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 09:30:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 07:30:45 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart at biblibre.co |testopia at bugs.koha-communit |m |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 09:32:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 07:32:12 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 09:55:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 07:55:35 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18501|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart --- Created attachment 19636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19636&action=edit Bug 10124: Merge GetPendingOrders and SearchOrders routines Preliminary work: In the C4::Acquisition module, 2 routines do the same work. This patch merges these 2 routines. Test plan: test the acqui/orderreceive.pl, acqui/uncertainprice.pl and serials/acqui-search-result.pl scripts. acqui/parcel.pl will be tested with the others patches. Signed-off-by: Pierre Angot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 09:55:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 07:55:42 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18502|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 19637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19637&action=edit Bug 10124: Add basket group name in filters This patch adds a new filter "basket group name" for pending orders searches. Test plan: Try different filters and check that results are consistent. Signed-off-by: Pierre Angot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 09:55:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 07:55:46 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18503|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 19638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19638&action=edit Bug 10124: Add filters on the pending orders table Since the parcel.pl script get *all* pending orders, there is no reason not to display all of them. Like that, DataTable manages pagination and sorting correctly (on all data). This patch adds filters on the table header (using columnFilter). Test plan: Try filters on the left of the screen and filters on the table header. Signed-off-by: Pierre Angot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 09:55:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 07:55:52 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19309|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart --- Created attachment 19639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19639&action=edit Bug 10124: QA followup - Remame the t/.../GetPendingOrders.pm to t/.../SearchOrders.pm according to the package name. - Rename IndependantBranches with IndependentBranches - FIX levels in pod Note that 1 qa issue still exists (not introduced by this development): FAIL t/db_dependent/lib/KohaTest/Acquisition/SearchOrders.pm OK pod OK forbidden patterns FAIL valid Invalid CODE attribute: Test( 1 ) OK critic These tests are never used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 09:55:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 07:55:58 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #27 from Jonathan Druart --- Created attachment 19640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19640&action=edit Bug 10124: Fix a js error : YAHOO is not defined json.min.js is not used in this page. The js include is useless. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 09:57:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 07:57:11 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #28 from Jonathan Druart --- (In reply to Katrin Fischer from comment #22) > Patches no longer apply cleanly for a conflict in Acquisitions.pm. > Jonathan, could you double check those lines here, rebase and switch back to > signed off? > > - &NewOrder &DelOrder &ModOrder &GetPendingOrders &GetOrder > &GetOrders &GetOrdersByBiblionumber > + &NewOrder &DelOrder &ModOrder &GetOrder &GetOrders > &GetOrdersByBiblionumber > + &NewOrder &DelOrder &ModOrder &GetOrder &GetOrders Rebased. I added a little followup, I find a js error on reloading the page. Back to Signed Off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 10:06:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 08:06:23 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #52 from Jonathan Druart --- Created attachment 19641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19641&action=edit Bug 7180: The default quantity is 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 10:07:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 08:07:13 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #53 from Jonathan Druart --- (In reply to Katrin Fischer from comment #51) > Jonathan, I think Mathieu has some good points here for the duplicate check > and the quantity - could you take a look? If no quantity is defined, the default value is now 1. Back to Signed Off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 10:12:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 08:12:58 +0000 Subject: [Koha-bugs] [Bug 9328] File::Find::Rule should not be a mandatory dependency for installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #7 from Jonathan Druart --- (In reply to Katrin Fischer from comment #6) > This patch does no longer apply: This patch depends on bug 7167. Back to Signed Off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 10:13:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 08:13:49 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9328 Depends on|9328 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 10:13:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 08:13:49 +0000 Subject: [Koha-bugs] [Bug 9328] File::Find::Rule should not be a mandatory dependency for installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|7167 | Depends on| |7167 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 10:22:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 08:22:48 +0000 Subject: [Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 --- Comment #6 from Jonathan Druart --- Kyle, I cannot reproduce: $ git reset --hard origin/master $ git bz apply 10504 Bug 10504 - C4::Acquisition::ModOrderItem is unused 19537 - [SIGNED-OFF] Bug 10504: Remove the unused C4::Acq::ModOrderItem routine Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 10504: Remove the unused C4::Acq::ModOrderItem routine $ qa -c 1 -v 2 testing 1 commit(s) (applied to 275f405 'Bug 10514: improve visibility of Add ') OK C4/Acquisition.pm OK pod OK forbidden patterns OK valid OK critic OK cataloguing/moveitem.pl OK pod OK forbidden patterns OK valid OK critic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 11:32:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 09:32:03 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #24 from Jonathan Druart --- (In reply to Katrin Fischer from comment #22) Thanks for the review Katrin! > Created attachment 19633 [details] > Patron module start page > > Adding some notes about my findings here: > > 1) (Normal) Sorting: I think it would be nice if fines, circ notes and > checkouts would be sortable too. I know checkouts is a bit difficult, but if > it was sortable you could easily find those with checkouts at least. I will add the sort on the notes, but others are a little bit complicated. > 2) (Trivial) There is some wrong capitalization, that was already there > before and now appears in the filters too: Street Address > Street address Will be done. I did not find others wrong capitalization. > 3) (Major) Filters: I tried to limit the search to a specific patron > category and while it said "Processing" nothing happened and the page seemed > broken. I had to reload the page. Same happens when I search for a name > using the normal search. Not sure what's going wrong here. I checked the > logs, pasting some of the errors here: There is 1 missing space in the built query, will be fixed. > 4) (Trivial) There is something a little odd about the datatables CSS - the > first part of the controls is a darker grey than the second part starting > with "First". Maybe it is wanted by Owen? It is not added by these patchs. Bug 10558 already deals with datatable CSS. > 5) Wishlist: Could we rename the column Cat = Category? I remember all too > well when someone (probably me) translated it to "Katze" :) But not sure if > that takes up too much room or not. Cat => Category, done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 11:33:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 09:33:49 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 11:33:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 09:33:52 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19307|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 19642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19642&action=edit Bug 9811: QA followup - removes 2 tabs - removes mysqlisms - add sort on borrowernotes - fix wrong capitalization - cat => Category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 12:19:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 10:19:04 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #10 from Jonathan Druart --- (In reply to Katrin Fischer from comment #9) > Hm, as there is some progress on DBIX integration now, I think it might be > worth to put some more thought into this. Putting this "In Discussion" to > get some more opinions. Katrin, Even if someone uses DBIx for authorised values, I think this patch is useful, it refactores dirty code in admin/authorised_values.pl and adds unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 12:25:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 10:25:05 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #54 from mathieu saby --- Hello Jonathan, hello Katrin This is working better, but I think small improvements can still be made to improve usability : - Question for Jonathan : I suppose the value in () after the title is the isbn. I found strange to see "Titre01 (2845622201)", as the ISBN for my record is "9782845622203". Why do you "translate" my isbn13 in isbn 10 ? - This page needs a little text explaing to the average librarian how to use it, especially the use of the "Accounting detail bloc" : as the fund, and the 2 planning values can be defined either in each orders or in "Accounting detail bloc", the librarians needs to know what to do, and what behavior to expect if the value for a fund in an order is NOT the same as the one in "Accounting detail bloc". I have made a try with Planning value 1 : the value defined in the order seems to have a greater priority than the value defined in the precise order. If it is normal, we could add a text in the beggining of the page. The following remarks could be the core of further improvements AFTER this patch is pushed, so the page would be the more "librarian friendly" possible. Could you give me an opinion ? - When I click on "check all", my 19 orders are "unfolded", but if I use the "Acounting detail" block at the end of the page, I dont need to put information in each order, but only in the "Acounting detail" at the end of the page. So, maybe the simple fact of checking a order should not unfold the bloc for this order? Maybe we show the order informations in a compact way, in 1 line, just after "( Show MARC | Card )". So there would be no need to unfold the bloc, except if we want to change some of these informations. For example, we could have for each line : "Title01 (2845622201) ( Show MARC | Card ) Quantity: Price: Discount: Fund: Planning value1: Planning value2: " and a little button to change those values if we want Or maybe we could replace the folding/unfolding block with a table structure like that : Selected | Title (show marc) | Qty | Price | Discount | Fund | Planning 1 | Planning 2 With an INPUT in each cell of the table, so we could directly put information into the table I don't know if I am clear enough? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 12:34:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 10:34:55 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #7 from Jonathan Druart --- Created attachment 19643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19643&action=edit Bug 7802: Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 12:34:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 10:34:59 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #8 from Jonathan Druart --- Created attachment 19644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19644&action=edit Bug 7802: Followup Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 12:35:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 10:35:28 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8952|0 |1 is obsolete| | CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 12:35:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 10:35:37 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8953|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 12:35:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 10:35:57 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff QA Contact|koha.sekjal at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 12:42:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 10:42:51 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #55 from mathieu saby --- Created attachment 19645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19645&action=edit proposition of evolution M. Saby Here is a capture of a proposition (made with firebug). - explanation text - all the orders in a table (I kept the LABEL markup, but it could be deleted or just hidden if they are needed for accessibilty) Do you think it would be an UX improvement ? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 12:50:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 10:50:03 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 --- Comment #17 from David Cook --- Just noticed that I need to update the copyright on those new files to include at least a Parts Copyright for Prosentient Systems... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 12:50:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 10:50:24 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #56 from Katrin Fischer --- Hm, not sure a table layout without using datatables or similar would work well for bigger lists or smaller screens. The labels in each line might be a bit much in that case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 12:54:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 10:54:31 +0000 Subject: [Koha-bugs] [Bug 10588] New: opac-topissues first branch always selected in filters Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Bug ID: 10588 Summary: opac-topissues first branch always selected in filters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In OPAC most popular items page: With user is logged-in his branch should be selected. When a branch is manually selected and form is submitted, this branch should be selected in results page. When looking at HTML, you see that all options are selected in combobox o_O. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 12:57:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 10:57:56 +0000 Subject: [Koha-bugs] [Bug 10589] New: Override OpacHiddenItems based on Patron Category Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Bug ID: 10589 Summary: Override OpacHiddenItems based on Patron Category Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org This patch will: 1) Add two system preferences: PatronSingleBranch and PatronEveryBranch. 2) Items which would normally be hidden by OpacHiddenItems will be visible if: a) The patron's category code matches the PatronSingleBranch patron category code AND the home branch of the item is the same as the home branch of the patron. OR b) The patron's category code matches the PatronEveryBranch patron category code. The two system preferences default to PTSB and PTEB which are not added to the list of possible patron categories. This means OpacHiddenItems will continue to function as is normally. Having them as system preferences means the patron category code is not hard coded and can be changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 12:59:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 10:59:47 +0000 Subject: [Koha-bugs] [Bug 10590] New: in opac-topissues limit param is not protected Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 Bug ID: 10590 Summary: in opac-topissues limit param is not protected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In opac-topissues page, the limit URL argument is directly added to SQL query. This argument should be protected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 13:05:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 11:05:26 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 19646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19646&action=edit Proposed patch See commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 13:05:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 11:05:37 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 13:23:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 11:23:24 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #57 from mathieu saby --- that's just an idea. of course if we are to change the display, we would need to make a nicer table. But this could be done after this patch is pushed... What I would like to be checked before it is pushed is : - the isbn13 changed to isbn13 after the Title. need a little fix ? - adding a few lines explaining how to use the page (mainly, the "Accounting detail blocs" versus individual orders) - the disappearing of the individual duplicate check. I know some french libraries are using it (we don't). Maybe the fact that it is possible to avoid duplicates by defining an import rule is sufficient? I am not sure of that, because we don't use this feature for the moment here. Is it working well. Do you think all librarians will be fine with that? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 13:23:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 11:23:56 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #58 from mathieu saby --- READ : "- the isbn13 changed to isbn10 after the Title. need a little fix ?" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 13:28:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 11:28:29 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |mtompset at hotmail.com --- Comment #1 from M. Tompsett --- Created attachment 19647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19647&action=edit Provide two system preferences to flexibly override OpacHiddenItems Test ==== 1) Add PTSB and PTEB as patron categories. 2) Create a dummy user set as regular patron (PT). 3) Make sure you have a biblio that has at least a single item in two branches. (e.g. Lord of the Rings in Manila and Davao) 4) Modify OpacHiddenItems to hide one of the two branches. 5) Enable OPAC -> Features -> opacuserlogin 6) Do an anonymous OPAC search for the item. It should only list one of the two branches. 7) Log in to OPAC. Search for item. It should only list one of the two branches. 8) Apply patch 9) Change dummy user to match the branch of the hidden item. 10) Change dummy user patron category to PTSB. 11) Log in to OPAC. Search for item. It should list all the two branches items. 12) Change dummy user to not match the branch of the hidden item. 13) Log in to OPAC. Search for item. It should list only one of the two branches. 14) Change the dummy user patron category to PTEB. 15) Log in to OPAC. Search for item. It should list all the two branches items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 13:31:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 11:31:27 +0000 Subject: [Koha-bugs] [Bug 10591] New: Why do we allow holds on restricted items (952$5=Use restrictions)? Place a hold for reference? Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10591 Bug ID: 10591 Summary: Why do we allow holds on restricted items (952$5=Use restrictions)? Place a hold for reference? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently, it is possible to place a hold on an item marked as Restricted with 952 $5. And you can also confirm the hold, setting it to Waiting status. The code in Circulation.pm (CanBookBeIssued) checks before issuing if an item is restricted and will not permit checkout. So actually, the book is not for loan. It may be available for reference in the library? This may be just unintentional. But if we would have the intention to provide a mechanism to place holds for reference in the library, we probably should deal with the remaining workflow too. How do we registrate that the user received the book for reference, and when do we remove the waiting hold? Do we count these kind of references? Note also that we could have a library building workflow on this possibility, and another developer that some day makes it impossible to reserve restricted items not knowing that. What do you think? Setting this report to In Discussion, hoping for some more feedback. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 13:59:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 11:59:04 +0000 Subject: [Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19053|0 |1 is obsolete| | --- Comment #16 from M. de Rooy --- Created attachment 19648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19648&action=edit Bug 10258: fix permissions check for setting basket group for order basket Improve the code that displays and allows staff to set the basket group from the basket details page for a closed basket. Prior to this patch, a staff member who did not have the group_manage acquisition permission would still see a control to change the group that the basket belongs to; attempting to change the group would present with with a login page. This patch also does some tidying of how basket group details are passed to the template. To test: [1] Create an order basket and close it. Do not assign it to a basket group. [2] View the basket details while logged in as a staff user who has the order_manage acquisitions permission but not the group_manage. The displayed basket group should be "No group". [3] Switch to a staff user who also has the group_manage permission, then view the basket details again. The basket group field should now be a select input that allows you to change the basket group. [4] Change the basket group. Verify that the basket group you selected is now displayed as the current group for that order basket. The basket group delivery and billing place fields should also now be displayed. [5] Close the basket group set in the previous step, then view the basket details again. This time, the basket group name should be displayed with a suffix of " (closed)", and no input to change the group should be displayed. [6] Swith to a staff user who does not have the group_manage permission, view the basket details, and verify that the basket name is displayed with a suffix of " (closed)". Signed-off-by: Galen Charlton Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 13:59:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 11:59:09 +0000 Subject: [Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19054|0 |1 is obsolete| | --- Comment #17 from M. de Rooy --- Created attachment 19649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19649&action=edit Bug 10258: offer to create basket group only when staff user has correct permission If the staff user does not have the group_manage acquisition permission, do not offer to create a new basket group when closing an order basket. This avoids a situation where if a staff member without that permission tries to close a basket and chose the option to create a bakset group, they would be redirected to the login page. To test: [1] Log in as a staff user that does not have the acquisition/group_manage permission. [2] Create a new order basket, attach at least one order line to it, then close it. [3] Verify that the confirmation page does not offer to create a basket group with the same name as the order basket. [4] Log in as a staff user that has the acquisition/group_manage permission. [5] Create and close an order basket. [6] Verify that this time, the confirmation page *does* offer to create a basket group. Signed-off-by: Galen Charlton Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 13:59:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 11:59:41 +0000 Subject: [Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart at biblibre.co |m.de.rooy at rijksmuseum.nl |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 13:59:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 11:59:54 +0000 Subject: [Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:00:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:00:48 +0000 Subject: [Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #18 from M. de Rooy --- Looks good to me. Thanks for improvements, Galen. No complaints from koha-qa. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:14:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:14:30 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #59 from Jonathan Druart --- (In reply to mathieu saby from comment #47) > currently in master, when you choose to add each document individually, Koha > can alert you if there is a duplicate. Apparently we loose this function. Do > you think it is a problem ? The feature was introduced by bug 5782. The needed behavior is for adding a record from an external source. Modifications were made in neworderempty (where the current link "Add order" redirects), so I don't think the behavior was needed for the addorderiso2709.pl page. (In reply to mathieu saby from comment #54) > - Question for Jonathan : I suppose the value in () after the title is the > isbn. I found strange to see "Titre01 (2845622201)", as the ISBN for my > record is "9782845622203". Why do you "translate" my isbn13 in isbn 10 ? I confirm the issue. The biblioitems.isbn field is filled with an isbn 10 by the import tool. It is not in this scope, but it is worth to open a new report. > - This page needs a little text explaing to the average librarian how to use > it, especially the use of the "Accounting detail bloc" : as the fund, and > the 2 planning values can be defined either in each orders or in "Accounting > detail bloc", the librarians needs to know what to do, and what behavior to > expect if the value for a fund in an order is NOT the same as the one in > "Accounting detail bloc". > I have made a try with Planning value 1 : the value defined in the order > seems to have a greater priority than the value defined in the precise > order. If it is normal, we could add a text in the beggining of the page. It is the same behavior with or without these patchs: If a value is given for a biblio, it is kept. Else the "default value" (i.e. the value in the "Accounting detail bloc) is used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:26:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:26:12 +0000 Subject: [Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:26:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:26:16 +0000 Subject: [Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19537|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 19650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19650&action=edit Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Signed-off-by: Srdjan Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:27:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:27:56 +0000 Subject: [Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #8 from Kyle M Hall --- Confirmed, I have no idea how I got that error. However, the more important issue to me is the file_not_specified_in_diff you can see looking here: http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19650&action=diff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:29:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:29:29 +0000 Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19635|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 19651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19651&action=edit Bug 10419: Add the branchcode parameter. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:32:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:32:14 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #60 from mathieu saby --- > > It is the same behavior with or without these patchs: If a value is given > for a biblio, it is kept. Else the "default value" (i.e. the value in the > "Accounting detail bloc) is used. Ok, so it may be outside the scope of this patch, and fixed later with a followup, but I still think more explainations are needed, with or without your patch... This is not obvious at all that the Accounting details are "default value" and are not overriding specific values of each line. This kind of behavior can be explained in detail in online help, but some basic information must be provided in the page itself. That's my librarian-point-of-view ;-) IMO, that's the case in some other pages of staff interface, where the use of some parameters is not "obvious" for the average end-user and could deserve 1 or 2 lines of explanations (not to speak of the inventory tool...). If I have time enough I will propose patches. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:34:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:34:21 +0000 Subject: [Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19650|0 |1 is obsolete| | --- Comment #9 from M. de Rooy --- Created attachment 19652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19652&action=edit Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Signed-off-by: Srdjan Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:34:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:34:46 +0000 Subject: [Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19650|1 |0 is obsolete| | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:35:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:35:14 +0000 Subject: [Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19652|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:36:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:36:16 +0000 Subject: [Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 --- Comment #10 from M. de Rooy --- Created attachment 19653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19653&action=edit Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Signed-off-by: Srdjan Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:37:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:37:43 +0000 Subject: [Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 --- Comment #11 from M. de Rooy --- Kyle, I edited the lines with the commit id's in the commit message. Now this display problem is gone. But this seems to not to worry git itself, just bugzilla.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:37:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:37:54 +0000 Subject: [Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19650|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:38:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:38:35 +0000 Subject: [Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #12 from M. de Rooy --- Status back to Signed off ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:38:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:38:47 +0000 Subject: [Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Kyle M Hall --- Excellent! Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:39:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:39:33 +0000 Subject: [Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 --- Comment #14 from M. de Rooy --- I have no errors while running koha-qa. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:42:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:42:05 +0000 Subject: [Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #6 from M. de Rooy --- (In reply to Owen Leonard from comment #5) > I like Jared's suggestion from IRC, "OpacAdditionalStylesheet" +1 from me too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:42:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:42:33 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18964|0 |1 is obsolete| | --- Comment #42 from Kyle M Hall --- Created attachment 19654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19654&action=edit Bug 7639 - system preference to forgive fines on lost items Forgive fine when an item is set to lost status, fines are forgiven only when syspref ForgiveFineWhenLost is set to yes. Item can be set to lost status from: catalogue/moredetail.pl cataloguing/additem.pl tools/batchMod.pl misc/cronjobs/longoverdue.pl Changed sub C4::Circulation::LostItem to forgive fines on the item depending on the value of syspref ForgiveFineWhenLost. This sub is currently used to return an item and charge a replacement cost. Also added a new syspref in C4::Circulation::LostItem - ChargeReplFeeWhenLost. Replacement fee will now be charged only if this syspref is set to yes. Signed-off-by: Kyle M Hall Signed-off-by: Alex Hatley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:42:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:42:49 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18965|0 |1 is obsolete| | --- Comment #43 from Kyle M Hall --- Created attachment 19655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19655&action=edit Bug 7639 - system preference to forgive fines on lost items - QA Followup Test Plan: 1) Apply the patch 2) Run updatedatabase.pl 3) Set WhenLostForgiveFine to Forgive & WhenLostChargeReplacementFee to Charge 4) Issue an item to a borrower, then set to lost from catalogue/moredetail.pl 5) Observe the replacement fee has been charged 6) Return the item 7) Observe the charged fee has been forgiven 8) Set WhenLostForgiveFine to Don't Forgive 9) Repeat 4-6 10) Observe the charged fee has not been forgiven 11) Set WhenLostChargeReplacementFee to Don't Charge 12) Repeat 4 13) Observe that a fee was not charged Signed-off-by: Alex Hatley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:43:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:43:17 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18966|0 |1 is obsolete| | --- Comment #44 from Kyle M Hall --- Created attachment 19656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19656&action=edit Bug 7639 tiny QA follow-up no need to create a variable just to call to send it as parameter the line after Signed off by: Alex Hatley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:43:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:43:34 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:43:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:43:39 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 --- Comment #45 from Kyle M Hall --- Created attachment 19657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19657&action=edit Bug 7639 - system preference to forgive fines on lost items - QA Followup - Fix update description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 14:56:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 12:56:28 +0000 Subject: [Koha-bugs] [Bug 10585] Adding multiple items to cart in OPAC broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10585 --- Comment #3 from Owen Leonard --- I can't reproduce this problem in master using Firefox or Chrome on Windows -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 15:01:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 13:01:25 +0000 Subject: [Koha-bugs] [Bug 10591] Why do we allow holds on restricted items (952$5=Use restrictions)? Place a hold for reference? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10591 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 15:06:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 13:06:55 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #61 from Katrin Fischer --- Hm, I agree that we shoudl try to have interfaces as intuitive as possible, but I am not sure adding lots of text to the templates will help the case. I woud rather see something like a tooltip or reference to the help files. When you work in acquisitions every day you might get tired of the explanations and the space they take up pretty soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 15:08:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 13:08:17 +0000 Subject: [Koha-bugs] [Bug 10585] Adding multiple items to cart in OPAC broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10585 --- Comment #4 from Katrin Fischer --- Weird! I will try to do some more testing tonight - thx Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 15:27:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 13:27:23 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 15:27:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 13:27:28 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18622|0 |1 is obsolete| | --- Comment #54 from Kyle M Hall --- Created attachment 19658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19658&action=edit Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds two new system preferences: OpacLocationBranchToDisplay, which defines whether to display the holding library, the home library, or both for the opac details page. OpacLocationBranchToDisplayShelving, which defines where the shelving location should be displayed, under the home library, the holding library, or both. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described. Tested all variations. No koha-qa errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 15:28:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 13:28:53 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #62 from mathieu saby --- (In reply to Katrin Fischer from comment #61) > Hm, I agree that we shoudl try to have interfaces as intuitive as possible, > but I am not sure adding lots of text to the templates will help the case. I > woud rather see something like a tooltip I like the idea of tooltips. or reference to the help files. Maybe you are true for help files, but we don't use them in my library : they are not very well written (often very verbose), not very well translated in french (and not completely), not always up to date, and more important, sometime they don't fit our workflow, or our Marc flavor :( I know we can edit them. Maybe one day... > When you work in acquisitions every day you might get tired of the > explanations and the space they take up pretty soon. Some colleagues are working with some module everyday. Other colleagues only a few time a year. Some colleagues understand everything very quickly and don't like to see too much explanations, whereas other need a lot of explanations and still make big mistakes... My job as admin is to make it possible to prevent mistakes, improve speed of work, and reduce headaches. Not always easy, but I hope the evolution of Koha will be towards this goal! But that's a general discussion, whose scope is too large for this bug ;-) Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 15:40:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 13:40:40 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 15:59:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 13:59:15 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 --- Comment #2 from Robin Sheat --- I'm unable to reproduce this, anything following ';' is stripped off. However, if you replace ; with %3B, then it gets through. However, adding e.g. '%3Btruncate+test%3B' to the end of limit does give me a query that finishes like: GROUP BY biblio.biblionumber HAVING tot >0 ORDER BY tot DESC LIMIT 15;truncate test; which isn't ideal. Running this gives me: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'truncate test' at line 14 at /mnt/catalyst/koha/opac/opac-topissues.pl line 117. and I don't fully know why. This said, this shouldn't be possible. I don't think your patch goes far enough though: the $limit should be replaced by a '?' as well as being filtered. I'll test your patch and make a followup with that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:03:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:03:32 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 --- Comment #3 from Robin Sheat --- Created attachment 19659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19659&action=edit Bug 10590 - in opac-topissues limit param is not protected In opac-topissues page, the limit URL argument is directly added to SQL query. This patch adds protections : limit must only contain digits and must be lower than 100. Test plan : - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=10&branch=&itemtype=&timeLimit=999&do_it=1 => You get the results of 10 most cheched-out of all time - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=&branch=&itemtype=&timeLimit=999&do_it=1 => You get the results of 10 most cheched-out of all time - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=9999&branch=&itemtype=&timeLimit=999&do_it=1 => You get the results of 100 most cheched-out of all time - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=WHERE&branch=&itemtype=&timeLimit=999&do_it=1 => You get the results of 10 most cheched-out of all time Signed-off-by: Robin Sheat -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:09:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:09:10 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 --- Comment #4 from Robin Sheat --- Created attachment 19660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19660&action=edit Bug 10590 - parameterise the limit option The limit option was previously substituted directly into the query. The previous patch on bug 10590 filters it on input, but there's no reason not to have it made to work properly in the query for added safety. --- Comment #5 from Fridolyn SOMERS --- (In reply to Robin Sheat from comment #2) I did not took the time to hack the system with that but nevertheless it is dangerous to keep it as it is. > I don't think your patch goes far enough though: the $limit should be replaced by a '?' as well as being filtered You mean ending query with "limit ?" and using execute($limit) ? I thought it would not work because limit will be a string : "limit '10'". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:09:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:09:10 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 --- Comment #4 from Robin Sheat --- Created attachment 19660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19660&action=edit Bug 10590 - parameterise the limit option The limit option was previously substituted directly into the query. The previous patch on bug 10590 filters it on input, but there's no reason not to have it made to work properly in the query for added safety. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:11:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:11:20 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Robin Sheat --- (In reply to Fridolyn SOMERS from comment #5) > (In reply to Robin Sheat from comment #2) > I did not took the time to hack the system with that but nevertheless it is > dangerous to keep it as it is. It is. > > I don't think your patch goes far enough though: the $limit should be replaced by a '?' as well as being filtered > You mean ending query with "limit ?" and using execute($limit) ? > I thought it would not work because limit will be a string : "limit '10'". It works fine, SQL doesn't really care about the difference between strings and numbers when working with parameters. I'm marking this signed off as it's /vital/ that one of these patches goes in, it'd be best if they both did. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:11:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:11:46 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- (In reply to Robin Sheat from comment #2) > Running this gives me: > DBD::mysql::st execute failed: You have an error in your SQL syntax; check > the manual that corresponds to your MySQL server version for the right > syntax to use near 'truncate test' at line 14 at > /mnt/catalyst/koha/opac/opac-topissues.pl line 117. > > and I don't fully know why. Looks like one might have to enable multiple statement execution support [1] to get the canonical exploit to work. [1] http://dev.mysql.com/doc/refman/5.0/en/c-api-multiple-queries.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:12:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:12:24 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 --- Comment #8 from Galen Charlton --- I'm testing and doing a second signoff now, after which I've enlisted Katrin's help to QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:16:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:16:35 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19646|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:17:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:17:25 +0000 Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #11 from Jonathan Druart --- I cannot reproduce with Plack 1.0016 and Starman 0.3006. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:17:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:17:46 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 --- Comment #9 from Galen Charlton --- Created attachment 19661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19661&action=edit Bug 10590 - parameterise the limit option The limit option was previously substituted directly into the query. The previous patch on bug 10590 filters it on input, but there's no reason not to have it made to work properly in the query for added safety. To test: [1] Go to the top checkouts report (http://OPAC/cgi-bin/koha/opac-topissues.pl) [2] Run the report several times, varying the filters on number of results and item type. [3] Verify the the list of top checkouts appears to be correct. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:18:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:18:04 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 --- Comment #10 from Galen Charlton --- Created attachment 19662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19662&action=edit Bug 10590 - parameterise the limit option The limit option was previously substituted directly into the query. The previous patch on bug 10590 filters it on input, but there's no reason not to have it made to work properly in the query for added safety. To test: [1] Go to the top checkouts report (http://OPAC/cgi-bin/koha/opac-topissues.pl) [2] Run the report several times, varying the filters on number of results and item type. [3] Verify the the list of top checkouts appears to be correct. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:18:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:18:23 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 --- Comment #11 from Galen Charlton --- Created attachment 19663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19663&action=edit Bug 10590 - in opac-topissues limit param is not protected In opac-topissues page, the limit URL argument is directly added to SQL query. This patch adds protections : limit must only contain digits and must be lower than 100. Test plan : - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=10&branch=&itemtype=&timeLimit=999&do_it=1 => You get the results of 10 most cheched-out of all time - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=&branch=&itemtype=&timeLimit=999&do_it=1 => You get the results of 10 most cheched-out of all time - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=9999&branch=&itemtype=&timeLimit=999&do_it=1 => You get the results of 100 most cheched-out of all time - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=WHERE&branch=&itemtype=&timeLimit=999&do_it=1 => You get the results of 10 most cheched-out of all time Signed-off-by: Robin Sheat Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:18:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:18:34 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 --- Comment #12 from Galen Charlton --- Created attachment 19664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19664&action=edit Bug 10590 - parameterise the limit option The limit option was previously substituted directly into the query. The previous patch on bug 10590 filters it on input, but there's no reason not to have it made to work properly in the query for added safety. To test: [1] Go to the top checkouts report (http://OPAC/cgi-bin/koha/opac-topissues.pl) [2] Run the report several times, varying the filters on number of results and item type. [3] Verify the the list of top checkouts appears to be correct. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:19:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:19:01 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19659|0 |1 is obsolete| | Attachment #19660|0 |1 is obsolete| | Attachment #19661|0 |1 is obsolete| | Attachment #19662|0 |1 is obsolete| | Attachment #19663|0 |1 is obsolete| | Attachment #19664|0 |1 is obsolete| | --- Comment #13 from Galen Charlton --- Created attachment 19665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19665&action=edit Bug 10590 - in opac-topissues limit param is not protected In opac-topissues page, the limit URL argument is directly added to SQL query. This patch adds protections : limit must only contain digits and must be lower than 100. Test plan : - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=10&branch=&itemtype=&timeLimit=999&do_it=1 => You get the results of 10 most cheched-out of all time - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=&branch=&itemtype=&timeLimit=999&do_it=1 => You get the results of 10 most cheched-out of all time - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=9999&branch=&itemtype=&timeLimit=999&do_it=1 => You get the results of 100 most cheched-out of all time - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=WHERE&branch=&itemtype=&timeLimit=999&do_it=1 => You get the results of 10 most cheched-out of all time Signed-off-by: Robin Sheat Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:19:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:19:18 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 --- Comment #14 from Galen Charlton --- Created attachment 19666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19666&action=edit Bug 10590 - parameterise the limit option The limit option was previously substituted directly into the query. The previous patch on bug 10590 filters it on input, but there's no reason not to have it made to work properly in the query for added safety. To test: [1] Go to the top checkouts report (http://OPAC/cgi-bin/koha/opac-topissues.pl) [2] Run the report several times, varying the filters on number of results and item type. [3] Verify the the list of top checkouts appears to be correct. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:25:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:25:01 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:30:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:30:48 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:30:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:30:53 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19666|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 19667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19667&action=edit Bug 10590 - parameterise the limit option The limit option was previously substituted directly into the query. The previous patch on bug 10590 filters it on input, but there's no reason not to have it made to work properly in the query for added safety. To test: [1] Go to the top checkouts report (http://OPAC/cgi-bin/koha/opac-topissues.pl) [2] Run the report several times, varying the filters on number of results and item type. [3] Verify the the list of top checkouts appears to be correct. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:31:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:31:13 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19665|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 19668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19668&action=edit Bug 10590 - in opac-topissues limit param is not protected In opac-topissues page, the limit URL argument is directly added to SQL query. This patch adds protections : limit must only contain digits and must be lower than 100. Test plan : - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=10&branch=&itemtype=&timeLimit=999&do_it=1 => You get the results of 10 most cheched-out of all time - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=&branch=&itemtype=&timeLimit=999&do_it=1 => You get the results of 10 most cheched-out of all time - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=9999&branch=&itemtype=&timeLimit=999&do_it=1 => You get the results of 100 most cheched-out of all time - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=WHERE&branch=&itemtype=&timeLimit=999&do_it=1 => You get the results of 10 most cheched-out of all time Signed-off-by: Robin Sheat Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:31:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:31:20 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19667|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 19669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19669&action=edit Bug 10590 - parameterise the limit option The limit option was previously substituted directly into the query. The previous patch on bug 10590 filters it on input, but there's no reason not to have it made to work properly in the query for added safety. To test: [1] Go to the top checkouts report (http://OPAC/cgi-bin/koha/opac-topissues.pl) [2] Run the report several times, varying the filters on number of results and item type. [3] Verify the the list of top checkouts appears to be correct. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:32:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:32:53 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #18 from Jonathan Druart --- Fixes sound good to me. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:45:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:45:29 +0000 Subject: [Koha-bugs] [Bug 10592] New: Apache configuration is blocking fetch of certain icons and XML files Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10592 Bug ID: 10592 Summary: Apache configuration is blocking fetch of certain icons and XML files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org The commit for bug 9812 is causing certain files in {opac-tmpl,intranet-tmpl}/theme/lang/{modules,xslt,includes} from being fetched. From the Apache logs: [Mon Jul 15 14:28:21 2013] [error] [client 67.183.139.142] client denied by server configuration: /home/gmc/koha/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_field_008.xml, referer: http://staff.zadi.librarypolice.com/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=marc21_field_008.pl&index=tag_008_subfield_00_798112_205206&result=800919s1941%20%20%20%20nyu%20%20%20%20%20%20%20%20%20%20%20000%200%20eng [Mon Jul 15 14:16:17 2013] [error] [client 67.183.139.142] client denied by server configuration: /home/gmc/koha/koha-tmpl/opac-tmpl/prog/en/includes/favicon.ico [Mon Jul 15 14:43:52 2013] [error] [client 67.183.139.142] client denied by server configuration: /home/gmc/koha/koha-tmpl/intranet-tmpl/prog/en/includes/favicon.ico The effects I've seen so far: [1] favicons aren't displayed [2] The cataloging plugins for the 006 and 008 MARC21 fields can't fetch their XML data files, thus breaking them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:46:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:46:04 +0000 Subject: [Koha-bugs] [Bug 10592] Apache configuration is blocking fetch of certain icons and XML files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10592 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:55:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:55:51 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19668|0 |1 is obsolete| | Attachment #19669|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer --- Created attachment 19670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19670&action=edit [PASSED QA] Bug 10590 - in opac-topissues limit param is not protected In opac-topissues page, the limit URL argument is directly added to SQL query. This patch adds protections : limit must only contain digits and must be lower than 100. Test plan : - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=10&branch=&itemtype=&timeLimit=999&do_it=1 => You get the results of 10 most cheched-out of all time - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=&branch=&itemtype=&timeLimit=999&do_it=1 => You get the results of 10 most cheched-out of all time - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=9999&branch=&itemtype=&timeLimit=999&do_it=1 => You get the results of 100 most cheched-out of all time - Edit URL to : /cgi-bin/koha/opac-topissues.pl?limit=WHERE&branch=&itemtype=&timeLimit=999&do_it=1 => You get the results of 10 most cheched-out of all time Signed-off-by: Robin Sheat Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:56:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:56:45 +0000 Subject: [Koha-bugs] [Bug 10593] New: AuthoritiesLog should default to yes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10593 Bug ID: 10593 Summary: AuthoritiesLog should default to yes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:57:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:57:14 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 --- Comment #20 from Katrin Fischer --- Created attachment 19671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19671&action=edit [PASSED QA] Bug 10590 - parameterise the limit option The limit option was previously substituted directly into the query. The previous patch on bug 10590 filters it on input, but there's no reason not to have it made to work properly in the query for added safety. To test: [1] Go to the top checkouts report (http://OPAC/cgi-bin/koha/opac-topissues.pl) [2] Run the report several times, varying the filters on number of results and item type. [3] Verify the the list of top checkouts appears to be correct. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 16:58:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 14:58:41 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 17:19:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 15:19:16 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Galen Charlton --- Pushed to master. Thanks, everybody! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 17:30:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 15:30:10 +0000 Subject: [Koha-bugs] [Bug 9812] Several files shouldn't be exposed or browseable through a URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9812 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 17:30:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 15:30:21 +0000 Subject: [Koha-bugs] [Bug 9812] Several files shouldn't be exposed or browseable through a URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9812 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 17:30:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 15:30:29 +0000 Subject: [Koha-bugs] [Bug 9812] Several files shouldn't be exposed or browseable through a URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9812 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 17:30:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 15:30:36 +0000 Subject: [Koha-bugs] [Bug 9812] Several files shouldn't be exposed or browseable through a URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9812 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 17:30:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 15:30:42 +0000 Subject: [Koha-bugs] [Bug 9812] Several files shouldn't be exposed or browseable through a URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9812 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 17:30:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 15:30:45 +0000 Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18693|0 |1 is obsolete| | --- Comment #40 from Kyle M Hall --- Created attachment 19672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19672&action=edit Bug 8037 - Add holds and funds to items already received in parcel.pl - QA Followup 2 Adds the note "GST exc." for subtotals by fund. Signed-off-by: Pierre Angot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 17:31:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 15:31:48 +0000 Subject: [Koha-bugs] [Bug 9812] Several files shouldn't be exposed or browseable through a URL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9812 --- Comment #17 from Galen Charlton --- I just noticed that due to an apparent timing issue, this patch was never actually reverted from master. I'm going to run with leaving it in, as I have a patch series in progress in bug 10592 that fixes the value_builder and favicon issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 17:39:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 15:39:38 +0000 Subject: [Koha-bugs] [Bug 10593] AuthoritiesLog should default to yes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10593 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 17:39:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 15:39:59 +0000 Subject: [Koha-bugs] [Bug 10593] AuthoritiesLog should default to yes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10593 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 19673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19673&action=edit Bug 10593 - AuthoritiesLog should default to yes This trivial patch set the default to 'yes' for this system preference. To test, On a clean install - Navigate Home > Administration > Global System preferences > Logs - AuthoritiesLog is set to "Don't log" Apply the patch, install koha on a new DB. - Navigate Home > Administration > Global System preferences > Logs - AuthoritiesLog should be set to "Log" Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 17:42:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 15:42:10 +0000 Subject: [Koha-bugs] [Bug 10593] AuthoritiesLog should default to yes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10593 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 17:43:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 15:43:50 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19526|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 19674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19674&action=edit Bug 10558 - Convert records table in manage-marc-import.pl to ajax DataTable Some libraries would like to sort by columns for the records of an import batch. This seems like a good use of ajax DataTables. Test plan: 1) Apply this patch 2) Import a record batch into Koha a) Use some form of matching b) Have some records that will match and some that won't c) Have at least 30 records so you can test the pager 3) Verify the new table is functionally equivilent to the old static one Signed-off-by: Owen Leonard Tests fine and looks good with the exception of the corrections I put in a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 17:45:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 15:45:30 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19525|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 19675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19675&action=edit Bug 10558 [Follow-up] Convert records table in manage-marc-import.pl to ajax DataTable This patch makes improvements to the default DataTables CSS and corrects a couple of errors in the original patch. CSS for the "full numbers" type pagination, used by this and the quotes editor, has been cleaned up and made more visually consistent with the brief pagination style. Also changed: - removed some hard-coded paths containing "http://staff.kohadev..." - Added a column header to the column showing record match details. This provides both information and a clearer target for clicking to resort - Expanding the default table pager controls for this page and the quotes editor (for consistency) Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 17:45:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 15:45:50 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 17:47:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 15:47:52 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Kyle M Hall --- I can replicate Jonathan's issue. Owen, do you think you can take a look at that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 17:48:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 15:48:23 +0000 Subject: [Koha-bugs] [Bug 10592] Apache configuration is blocking fetch of certain icons and XML files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10592 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 17:48:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 15:48:26 +0000 Subject: [Koha-bugs] [Bug 10592] Apache configuration is blocking fetch of certain icons and XML files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10592 --- Comment #1 from Galen Charlton --- Created attachment 19676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19676&action=edit bug 10592: fix MARC21 006/008 cataloging plugins Move the XML and XSD data files so that access to them (particularly the XML files) is not blocked by the Apache configuration change introduced by the patch for bug 9812. To test, after applying the patch. [1] Open a MARC21 bibliographic record in the cataloging editor. [2] Click on the plugin link for the 008 field. Verify that that the form for all of the fixed field positions is displayed, and verify that you can change the type of material. [3] Repeat step 2 for the 006 field. [4] Verify that there are no entries in the Apache error log that contain client denied by server configuration: {...}/cataloguing/value_builder/marc21_field_008.xml or client denied by server configuration: {...}/cataloguing/value_builder/marc21_field_006.xml Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 17:48:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 15:48:32 +0000 Subject: [Koha-bugs] [Bug 10592] Apache configuration is blocking fetch of certain icons and XML files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10592 --- Comment #2 from Galen Charlton --- Created attachment 19677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19677&action=edit bug 10592: fix display of favicon Move the favicon files for OPAC and staff so that they are not blocked by the Apache configuration change introduced by the patch for bug 9812. Note that this patch makes the favicon customizable by theme, not both theme and language. To test, after applying the patch. [1] Open pages in the OPAC and staff client. Verify that the favicon is displayed in the usual place in your web browser. Specific pages to test include - circulation receipts and slips - help - lists view - web-based self-checkout [2] Verify that the Apache logs do not contain entries like this: client denied by server configuration: {...}/prog/en/includes/favicon.ico Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 17:58:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 15:58:36 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19558|0 |1 is obsolete| | --- Comment #61 from Kyle M Hall --- Created attachment 19678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19678&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 3 Installer fixes : - in kohastructure.sql, category.BlockExpiredPatronOpacActions default value is -1, sets the same in updatedatabase.pl - in syspref comment, replaces "opac actions such as placing a hold or reserve" by "opac actions such as placing holds or renrw books" - A 'YesNo' does not have 'yes' as value in database, it is '1'. - corrects small typo "categori" and syspref name case Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 17:58:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 15:58:53 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 17:58:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 15:58:56 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19560|0 |1 is obsolete| | --- Comment #62 from Kyle M Hall --- Created attachment 19679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19679&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 4 Some corrections : - opac-reserve.tt : opening

    instead of closing - opac-user.tt : warnexpired was in database format, adds the use of KohaDates template plugin - opac-user.tt : duplicated TT test : [% IF ( BORROWER_INF.warnexpired ) %] and [% ELSIF ( BORROWER_INF.warnexpired ) %], maybe a merge error - opac-user.tt : instead of , maybe for HTML 6 :-) - opac-user.pl : adding dateformat var to template is already done by Auth.pm Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 17:59:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 15:59:09 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #8 from Jesse Weaver --- Created attachment 19680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19680&action=edit Followup for bug 10486: Remove restriction on XSLT directory XSLT record processing is done client side in the OPAC external search, so the stylesheets must be fetchable. The restriction was also removed from the staff client, for consistency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 18:07:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 16:07:06 +0000 Subject: [Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #15 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 18:11:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 16:11:52 +0000 Subject: [Koha-bugs] [Bug 10447] Language definitions for 'ru' and 'uk' are not available during install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10447 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Tom?s! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 18:13:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 16:13:42 +0000 Subject: [Koha-bugs] [Bug 9770] C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9770 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Galen Charlton --- Pushed to master. Thanks, Jason! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 18:15:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 16:15:51 +0000 Subject: [Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 18:17:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 16:17:12 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 18:17:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 16:17:21 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19675|0 |1 is obsolete| | --- Comment #13 from Owen Leonard --- Created attachment 19681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19681&action=edit Bug 10558 [Follow-up] Convert records table in manage-marc-import.pl to ajax DataTable This patch makes improvements to the default DataTables CSS and corrects a couple of errors in the original patch. CSS for the "full numbers" type pagination, used by this and the quotes editor, has been cleaned up and made more visually consistent with the brief pagination style. Also changed: - removed some hard-coded paths containing "http://staff.kohadev..." - Added a column header to the column showing record match details. This provides both information and a clearer target for clicking to resort - Expanding the default table pager controls for this page and the quotes editor (for consistency) - Correction to quotes.css to fix pager display problem on wide screens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 18:19:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 16:19:16 +0000 Subject: [Koha-bugs] [Bug 10189] French values in cataloging plugins for unimarc 128b and 128c fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10189 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 18:22:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 16:22:59 +0000 Subject: [Koha-bugs] [Bug 10575] UT: GetOrdersByBiblionumber.t needs a database transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10575 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Kenza, and congratulations on having your first patch accepted into Koha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 18:42:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 16:42:27 +0000 Subject: [Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409 --- Comment #12 from Owen Leonard --- I think if changing the required fields is something that libraries want a new bug should be created. I don't think the discussion should hold up this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 18:42:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 16:42:50 +0000 Subject: [Koha-bugs] [Bug 7110] Renewal messages still displays in OPAC if OpacRenewalAllowed is disabled. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7110 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #15 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 18:43:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 16:43:58 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #22 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Fridolyn and Robin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 18:53:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 16:53:19 +0000 Subject: [Koha-bugs] [Bug 10594] New: ability to annotate lists Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10594 Bug ID: 10594 Summary: ability to annotate lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org It would be great if there was a way to annotate lists - kind of like a subject guide versus just a saved list of titles. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 19:03:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 17:03:14 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 --- Comment #29 from Nicole C. Engard --- What does the status of 'BLOCKED' mean? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 19:34:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 17:34:10 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 19:45:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 17:45:54 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #14 from Kyle M Hall --- Owen, the quote of the day table looks good in FireFox, but still looks like Jonathan's screen cap in Chrome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 19:58:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 17:58:45 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 --- Comment #30 from Katrin Fischer --- BLOCKED was added to help testers to notice dependencies. Like this bug couldn't be tested before 9995 was fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 20:02:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 18:02:06 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Chris Rohde changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crohde at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 20:04:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 18:04:43 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 20:04:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 18:04:45 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19681|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 19682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19682&action=edit Bug 10558 [Follow-up] Convert records table in manage-marc-import.pl to ajax DataTable This patch makes improvements to the default DataTables CSS and corrects a couple of errors in the original patch. CSS for the "full numbers" type pagination, used by this and the quotes editor, has been cleaned up and made more visually consistent with the brief pagination style. Also changed: - removed some hard-coded paths containing "http://staff.kohadev..." - Added a column header to the column showing record match details. This provides both information and a clearer target for clicking to resort - Expanding the default table pager controls for this page and the quotes editor (for consistency) - Correction to quotes.css to fix pager display problem on wide screens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 20:07:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 18:07:52 +0000 Subject: [Koha-bugs] [Bug 10495] t/db_dependent/HoldsQueue.t can fail unnecessarily In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10495 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Galen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 20:08:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 18:08:32 +0000 Subject: [Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #19 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 20:08:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 18:08:59 +0000 Subject: [Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 20:09:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 18:09:59 +0000 Subject: [Koha-bugs] [Bug 8884] opacheader is not in the header on CCSR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #20 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Jared! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 20:10:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 18:10:43 +0000 Subject: [Koha-bugs] [Bug 10494] KohaBranchName sends useless warnings to log if supplied library code is null or not present In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10494 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Galen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 20:11:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 18:11:12 +0000 Subject: [Koha-bugs] [Bug 10484] serials-edit.pl not checking for barcode field before checking for barcode subfield In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10484 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 21:13:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 19:13:57 +0000 Subject: [Koha-bugs] [Bug 6252] Patron import tool should let you set messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6252 --- Comment #2 from Nicole C. Engard --- This is still desired and came up in training today. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 21:18:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 19:18:59 +0000 Subject: [Koha-bugs] [Bug 5764] not for loan message in staff client repeated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5764 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hm, it might also make sense to keep the hardcoded "Not for loan" because it's translatable. So even when someone doesn't know that the text in () means, there will still be some useful information. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 21:26:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 19:26:08 +0000 Subject: [Koha-bugs] [Bug 7438] After attaching an item, clicking Cataloging breadcrumb results in 404 Error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7438 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Version|unspecified |master Resolution|--- |WORKSFORME --- Comment #1 from Katrin Fischer --- I can't reproduce this problem on current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 21:29:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 19:29:44 +0000 Subject: [Koha-bugs] [Bug 6286] Making classification indexes searchable in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6286 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.6 |master --- Comment #1 from Katrin Fischer --- Magnus, any news on that? :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 21:35:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 19:35:45 +0000 Subject: [Koha-bugs] [Bug 6793] imported and cleaned basket should be regularly deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6793 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m, katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Jonathan, maybe you know - is this bug still valid? What baskets are meant? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 21:42:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 19:42:57 +0000 Subject: [Koha-bugs] [Bug 6763] sorting for funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6763 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Version|master |unspecified Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- They seem to be alphabetical now :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 21:46:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 19:46:59 +0000 Subject: [Koha-bugs] [Bug 2454] Don't show credits on Pay Fines Tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6427 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 21:46:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 19:46:58 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2454 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 21:55:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 19:55:30 +0000 Subject: [Koha-bugs] [Bug 10585] Adding multiple items to cart in OPAC broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10585 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #5 from Katrin Fischer --- Again... Zebra has tricked me. Indexes were not current and a deleted record can't be put in the cart. The good news is - no evil bug :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 21:59:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 19:59:01 +0000 Subject: [Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #13 from Katrin Fischer --- Hm, still think it's a bit funny to have unrequired (by the system) fields required. I think the question here is if we push Owen's fix or remove the required attribute from the field? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 22:03:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 20:03:29 +0000 Subject: [Koha-bugs] [Bug 10594] ability to annotate lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10594 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Nicole, this reminded me of bug 813- maybe a duplicate? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 22:09:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 20:09:10 +0000 Subject: [Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409 --- Comment #14 from Kyle M Hall --- (In reply to Katrin Fischer from comment #13) > Hm, still think it's a bit funny to have unrequired (by the system) fields > required. I think the question here is if we push Owen's fix or remove the > required attribute from the field? Owen's fix does not change the functionality of the system, whereas removing the required attribute would. I would suggest we push this along, and if you'd like to see the option to make any of the given field values required/optional, we should file a separate bug for that. It really has no bearing on this particular bug. Both pre and post patch behaviors prohibit the creation of a course without a department, and only the presentation has changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 22:10:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 20:10:54 +0000 Subject: [Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19299|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 19683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19683&action=edit Bug 10409: Follow up - improving strings for easier translation Fixing this line: [% IF course_id %] Edit [% ELSE %] Create [% END %] course As grammar works different in different languages, having single strings like that in a predefined order makes having a nice translation unnecessarily hard. This will make it a little easier: [% IF course_id %]Edit course[% ELSE %]Create course[% END %] Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 22:11:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 20:11:35 +0000 Subject: [Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 22:12:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 20:12:05 +0000 Subject: [Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 15 23:31:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 21:31:03 +0000 Subject: [Koha-bugs] [Bug 6286] Making classification indexes searchable in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6286 --- Comment #2 from Magnus Enger --- Heh, guess I'm still waiting for comments... ;-) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 01:39:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 23:39:42 +0000 Subject: [Koha-bugs] [Bug 6553] Parentheses in corporate author break tracings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #19 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Liz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 01:40:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 23:40:37 +0000 Subject: [Koha-bugs] [Bug 10497] star ratings not showing right in ccsr detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 01:41:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 23:41:16 +0000 Subject: [Koha-bugs] [Bug 10510] OPAC's renew selected link has glitchy icon In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 01:42:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 23:42:42 +0000 Subject: [Koha-bugs] [Bug 10029] CAS authentication fails in OPAC reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10029 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 01:43:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 23:43:10 +0000 Subject: [Koha-bugs] [Bug 10428] undefined check in add additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10428 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 01:44:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 23:44:05 +0000 Subject: [Koha-bugs] [Bug 10346] "Add multiple copies" should be labelled "Add multiple items" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10346 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 01:45:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 23:45:29 +0000 Subject: [Koha-bugs] [Bug 5894] Adding multiple items from a cart to a list shows only the first title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5894 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Marc! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 01:45:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 23:45:56 +0000 Subject: [Koha-bugs] [Bug 9113] batch modification removes + In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9113 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 01:46:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 23:46:40 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #23 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 01:47:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 15 Jul 2013 23:47:09 +0000 Subject: [Koha-bugs] [Bug 10384] Software error when LDAP connexion fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10384 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 02:09:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 00:09:02 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 02:09:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 00:09:06 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19595|0 |1 is obsolete| | --- Comment #8 from Srdjan Jankovic --- Created attachment 19684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19684&action=edit [SIGNED-OFF] Bug 10556: The delivery time is not inserted on adding a supplier. Test plan: Add/edit a supplier and check that the delivery time is set in DB. Note: This patch cleans the code (sql query) in order to see easily if a problem occurred. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 02:14:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 00:14:11 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 --- Comment #12 from Srdjan Jankovic --- Fridolyn, The last one, shouldn't it be just CheckMandatorySubfields()? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 02:21:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 00:21:59 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #9 from Srdjan Jankovic --- prove t/db_dependent/Branches.t Cannot detect source of 't/db_dependent/Branches.t'! at /usr/share/perl/5.14/TAP/Parser/IteratorFactory.pm line 263 TAP::Parser::IteratorFactory::detect_source('TAP::Parser::IteratorFactory=HASH(0x26c2678)', 'TAP::Parser::Source=HASH(0x25e19c8)') called at /usr/share/perl/5.14/TAP/Parser/IteratorFactory.pm line 213 TAP::Parser::IteratorFactory::make_iterator('TAP::Parser::IteratorFactory=HASH(0x26c2678)', 'TAP::Parser::Source=HASH(0x25e19c8)') called at /usr/share/perl/5.14/TAP/Parser.pm line 469 TAP::Parser::_initialize('TAP::Parser=HASH(0x25e17d0)', 'HASH(0x2259ea0)') called at /usr/share/perl/5.14/TAP/Object.pm line 58 TAP::Object::new('TAP::Parser', 'HASH(0x2259ea0)') called at /usr/share/perl/5.14/TAP/Object.pm line 133 TAP::Object::_construct('TAP::Harness=HASH(0x245dcc0)', 'TAP::Parser', 'HASH(0x2259ea0)') called at /usr/share/perl/5.14/TAP/Harness.pm line 779 TAP::Harness::make_parser('TAP::Harness=HASH(0x245dcc0)', 'TAP::Parser::Scheduler::Job=HASH(0x25bbc68)') called at /usr/share/perl/5.14/TAP/Harness.pm line 578 TAP::Harness::_aggregate_single('TAP::Harness=HASH(0x245dcc0)', 'TAP::Parser::Aggregator=HASH(0x246c7b8)', 'TAP::Parser::Scheduler=HASH(0x25bbd70)') called at /usr/share/perl/5.14/TAP/Harness.pm line 670 TAP::Harness::aggregate_tests('TAP::Harness=HASH(0x245dcc0)', 'TAP::Parser::Aggregator=HASH(0x246c7b8)', 't/db_dependent/Branches.t') called at /usr/share/perl/5.14/TAP/Harness.pm line 485 TAP::Harness::__ANON__() called at /usr/share/perl/5.14/TAP/Harness.pm line 498 TAP::Harness::runtests('TAP::Harness=HASH(0x245dcc0)', 't/db_dependent/Branches.t') called at /usr/share/perl/5.14/App/Prove.pm line 553 App::Prove::_runtests('App::Prove=HASH(0x202edd8)', 'HASH(0x2430ee8)', 'TAP::Harness', 't/db_dependent/Branches.t') called at /usr/share/perl/5.14/App/Prove.pm line 511 App::Prove::run('App::Prove=HASH(0x202edd8)') called at /usr/bin/prove line 11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 02:26:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 00:26:56 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 --- Comment #17 from Srdjan Jankovic --- So what do I do here? Sign off just the first one? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 02:47:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 00:47:25 +0000 Subject: [Koha-bugs] [Bug 10197] add id tags to patron info list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10197 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 02:47:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 00:47:28 +0000 Subject: [Koha-bugs] [Bug 10197] add id tags to patron info list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10197 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18067|0 |1 is obsolete| | --- Comment #4 from Srdjan Jankovic --- Created attachment 19685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19685&action=edit [SIGNED-OFF] Bug 10197: Add classes to patron info list This patch adds classes to the patron info found on the top left of the circulation and patron related pages to allow for easy styling of the information displayed. To test: * Apply patch * View a patron detail page and view the source on the list to the left to see the styles * View a checkout screen and view the source on the list to the left with patron info to see the styles * You could also try to style things by customizing your CSS Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 04:49:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 02:49:08 +0000 Subject: [Koha-bugs] [Bug 10503] incorrect initialization parameters passed to Memoize::Memcached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10503 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #4 from Srdjan Jankovic --- I can see GetMarcStructure and getTranslatedLanguages, but not _get_columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 07:24:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 05:24:39 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #6 from Srdjan Jankovic --- prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t .. Use of uninitialized value in pattern match (m//) at C4/SQLHelper.pm line 407. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha`.`borrowers`, CONSTRAINT `borrowers_ibfk_1` FOREIGN KEY (`categorycode`) REFERENCES `categories` (`categorycode`)) at C4/SQLHelper.pm line 184. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 07:45:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 05:45:23 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #2 from Srdjan Jankovic --- There's something wrong with the patch: git am --reject ~/Bug-10528-C4Booksellers-needs-unit-tests.patch Applying: Bug 10528: C4::Booksellers needs unit tests Checking patch C4/Bookseller.pm... error: while searching for: sub ModBookseller { my ($data) = @_; my $dbh = C4::Context->dbh; my $query = q| UPDATE aqbooksellers SET name = ?, address1 = ?, address2 = ?, address3 = ?, address4 = ?, error: patch failed: C4/Bookseller.pm:226 error: while searching for: ,$data->{notes} ,$data->{deliverytime} ,$data->{id} ); return; } =head2 DelBookseller error: patch failed: C4/Bookseller.pm:254 Checking patch t/db_dependent/Bookseller.t... /home/srdjan/koha/dev/.git/rebase-apply/patch:786: new blank line at EOF. + -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 08:37:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 06:37:34 +0000 Subject: [Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 08:37:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 06:37:37 +0000 Subject: [Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19580|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 19686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19686&action=edit [SIGNED-OFF] Bug 7598 - Acquisitions JavaScript contains untranslatable English strings English strings in acq.js cannot be processed by the translation script. This patch moves the strings to the templates to be set as JS variables for use by the script. To test: - On the uncertain prices page, enter an invalid price and click save. You should see a JavaScript alert pointing this out. - When adding a fund to an existing budget, enter an amount which exceeds the amount in the parent budget. You should see a JavaScript alert pointing this out. There is a similar function which has been corrected, checkBudgetParent(), but I don't know how to trigger it for testing. The closebasketgroup function has been updated but as far as I can tell it's not actually in use. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 08:50:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 06:50:37 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 --- Comment #18 from Julian Maurice --- Only the syspref name change between the two patches. Maybe you can test only one and sign off both ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 09:17:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 07:17:24 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 --- Comment #13 from Fridolyn SOMERS --- (In reply to Srdjan Jankovic from comment #12) > Fridolyn, > The last one, shouldn't it be just CheckMandatorySubfields()? The last patch ? No, the CheckMandatorySubfields() has an argument which is the parent object to use for searching subfield lines. This is necessary for the serial edition where there are hidden subfield lines, one must not check all line of the form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 09:38:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 07:38:13 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 --- Comment #9 from Jonathan Druart --- Srdjan, Thanks for your signoff but this patch already passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 09:41:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 07:41:38 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19338|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 19687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19687&action=edit Bug 10508 : C4::Branch.pm needs unit tests. Unit tests are wrap in a transaction. NOTE: the field "issuing" isn't used in the database To test: prove t/db_dependent/Branch.t t/db_dependent/Branch.t .. ok All tests successful. Files=1, Tests=31, 0 wallclock secs ( 0.03 usr 0.00 sys + 0.13 cusr 0.00 csys = 0.16 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 09:41:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 07:41:43 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19546|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 19688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19688&action=edit Bug 10508: branchprinter will be a foreign key Bug 8034 will introduces a foreign key on branches.branchprinter. This patch set branchprinter values to undef. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 09:42:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 07:42:54 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #12 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #9) > prove t/db_dependent/Branches.t > Cannot detect source of 't/db_dependent/Branches.t'! at Yes, it is Branch.t, not Branches.t. I modified the commit message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 09:45:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 07:45:26 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #7 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #6) > prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t > t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t .. Use of uninitialized > value in pattern match (m//) at C4/SQLHelper.pm line 407. > DBD::mysql::st execute failed: Cannot add or update a child row: a foreign > key constraint fails (`koha`.`borrowers`, CONSTRAINT `borrowers_ibfk_1` > FOREIGN KEY (`categorycode`) REFERENCES `categories` (`categorycode`)) at > C4/SQLHelper.pm line 184. It seems you don't have the good category codes. You have to insert sample data before executing this unit tests file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 09:47:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 07:47:22 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 --- Comment #10 from Srdjan Jankovic --- Omg, how did I miss that? Sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 09:53:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 07:53:44 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #8 from Srdjan Jankovic --- installer/data/mysql/sample_only_param_tables.sql? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 10:15:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 08:15:39 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19684|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 10:15:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 08:15:53 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19595|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 10:16:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 08:16:00 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 10:16:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 08:16:21 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 10:18:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 08:18:49 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #9 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #8) > installer/data/mysql/sample_only_param_tables.sql? The patch for bug 10337 creates a DB with all sample data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 10:36:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 08:36:54 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #2) > There's something wrong with the patch: Did you applied dependent patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 11:27:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 09:27:09 +0000 Subject: [Koha-bugs] [Bug 10566] Improve OPAC course reserves pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10566 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19521|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 19689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19689&action=edit Bug 10566 - Improve OPAC course reserves pages This patch makes various improvements to the OPAC course reserve pages: - Descriptive page titles for both pages. - More compact display of course information on course detail page (a list instead of a table, consistent with other displays of similar information in Koha). - Correct capitalization. - Added label and fieldset to course reserve search form. - Added breadcrumb navigatio nto course reserve detail page as a path back to course reserves main page. To test, apply the patch and confirm that the changes haven't broken anything and are an improvement. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 11:27:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 09:27:07 +0000 Subject: [Koha-bugs] [Bug 10566] Improve OPAC course reserves pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10566 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 11:53:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 09:53:55 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 19690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19690&action=edit Bug 10588 - opac-topissues first branch always selected in filters See test plan in commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 11:54:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 09:54:02 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 11:54:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 09:54:59 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9928 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 11:54:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 09:54:59 +0000 Subject: [Koha-bugs] [Bug 9928] no way to see all purchase suggestions at all In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10588 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 11:55:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 09:55:40 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 --- Comment #2 from Fridolyn SOMERS --- Code inspired by Bug 9928 which introduced the code "__ANY__". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 12:32:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 10:32:45 +0000 Subject: [Koha-bugs] [Bug 10595] New: OpacTopissue page still accessible when system preference is turned off Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 Bug ID: 10595 Summary: OpacTopissue page still accessible when system preference is turned off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The page for most popular titles should not be accessible when the feature is turned off in the system preferences (OpacTopissues). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 12:42:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 10:42:41 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #12 from Kyle M Hall --- I don't think that is possible, at least not to my knowledge. What you are asking for is for one website ( the intranet ) to know the internal settings of another website ( the opac ). The only thing I can think of is to add an callable ajax function for the opac and intranet that can be passed each system preference and return true if it is overridden and false otherwise. We'd need to add a section to koha to list all the opacs and intranets in the system, and then for each system preference iterate though the list of opacs and intranets and check each one to see if the system preference is overridden. If it is, then we display some kind of not by the preference with the opac's url and new preference value. This seems terribly and overly complicated just to see which system preferences are overridden. Is there a simpler way I am not seeing? (In reply to M. de Rooy from comment #11) > Kyle: > Reading the comments now, we seem to reach consensus that this patch just > needs an additional change in the pref editor to make visible that the pref > is overridden. > > Changing status to reflect that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 13:08:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 11:08:40 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 --- Comment #13 from M. de Rooy --- > This seems terribly and overly complicated just to see which system > preferences are overridden. Is there a simpler way I am not seeing? When initializing the form, you could check %ENV for all OVERRIDE_SYSPREF keys and mark what you find in a special way? Would that be simpler? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 13:15:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 11:15:02 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 --- Comment #14 from M. de Rooy --- Too fast: yes too simple. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 13:40:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 11:40:05 +0000 Subject: [Koha-bugs] [Bug 10524] Dependency updates to account for liblibrary-callnumber-lc-perl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10524 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #5 from Bernardo Gonzalez Kriegel --- Puched to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 13:45:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 11:45:52 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #23 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 13:52:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 11:52:22 +0000 Subject: [Koha-bugs] [Bug 7110] Renewal messages still displays in OPAC if OpacRenewalAllowed is disabled. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7110 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #16 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 13:55:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 11:55:09 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 --- Comment #15 from Kyle M Hall --- (In reply to M. de Rooy from comment #13) > > This seems terribly and overly complicated just to see which system > > preferences are overridden. Is there a simpler way I am not seeing? > > When initializing the form, you could check %ENV for all OVERRIDE_SYSPREF > keys and mark what you find in a special way? Would that be simpler? Yes, the would unfortunately only work for staff intranet the preference editor is being used on. Since we have a minimum of two virtual hosts per koha installation ( one opac, one staff ) it won't work. I'm wondering if maybe a simpler/better solution would be to add a parameter to koha-conf.xml to control if this feature is enabled or not, and if it is enabled, display a nice big warning at the top of the system preferences edit along the lines of "Warning: You have the system preferences override feature enabled, please check your apache configuration files before assuming a change in a system preference will affect your installation." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 13:58:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 11:58:49 +0000 Subject: [Koha-bugs] [Bug 10495] t/db_dependent/HoldsQueue.t can fail unnecessarily In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10495 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 14:02:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 12:02:29 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Jonathan Druart --- QA comment: 1/ On tools/manage-marc-import.pl, I got a JS error: aoData.push( { "name": "import_batch_id", "value": } ); The table should not be displayed if there is no import_batch_id parameter. 2/ I got another JS error clicking on the title SyntaxError: syntax error: void() Prefer a href="#" 3/ The DT aLengthMenu parameter should contain an "All" entry (git grep "aLengthMenu.*All") 4/ Why do you comment lines in tools/manage-marc-import.pl instead of deleting them? 5/ Why do you add a show_marc JS function instead of using the "classic" way (link to showmarc.pl)? 6/ Permissions: manage-marc-import.pl needs the tools=>manage_staged_marc permission and the ajax script needs editcatalogue. Don't you think we should have the same one in both? Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 14:02:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 12:02:51 +0000 Subject: [Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #20 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 14:09:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 12:09:48 +0000 Subject: [Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195 --- Comment #1 from Mirko Tietgen --- Created attachment 19691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19691&action=edit Bug 10195 Records hidden with OpacSuppression can still be accessed Initial commit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 14:18:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 12:18:26 +0000 Subject: [Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #10 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 14:21:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 12:21:44 +0000 Subject: [Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 14:33:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 12:33:37 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 14:33:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 12:33:39 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #17 from Kyle M Hall --- Created attachment 19692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19692&action=edit Bug 10558 [QA Follow-up] Convert records table in manage-marc-import.pl to ajax DataTable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 14:37:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 12:37:05 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #18 from Kyle M Hall --- > 1/ On tools/manage-marc-import.pl, I got a JS error: > aoData.push( { "name": "import_batch_id", "value": } ); > The table should not be displayed if there is no import_batch_id parameter. Fixed! > 2/ I got another JS error clicking on the title > SyntaxError: syntax error: void() > Prefer a href="#" By bad, the call is supposed to be void(0). This appears to be the preferred practice these days. The problem with href="#" is that it causes the page to jump back to the top when clicked. This isn't a problem when the page does not scroll vertically, but in this case it often will. > 3/ The DT aLengthMenu parameter should contain an "All" entry (git grep > "aLengthMenu.*All") Fixed! > 4/ Why do you comment lines in tools/manage-marc-import.pl instead of > deleting them? Fixed! > 5/ Why do you add a show_marc JS function instead of using the "classic" way > (link to showmarc.pl)? The "classic" way uses greybox, which isn't compatible with DataTables built from an ajax source. On the plus side, I'm using jQuery UI instead, and if we switched all of them to jQuery UI, we could drop greybox as a dependency. > 6/ Permissions: manage-marc-import.pl needs the tools=>manage_staged_marc > permission and the ajax script needs editcatalogue. Don't you think we > should have the same one in both? Fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 14:39:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 12:39:38 +0000 Subject: [Koha-bugs] [Bug 6793] imported and cleaned basket should be regularly deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6793 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Jonathan Druart --- I suspect it is a duplicate of bug 7240. I think the idea was to clean the import table. *** This bug has been marked as a duplicate of bug 7240 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 14:39:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 12:39:38 +0000 Subject: [Koha-bugs] [Bug 7240] Cleaning up import tables and action_logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7240 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dev_patches at biblibre.com --- Comment #6 from Jonathan Druart --- *** Bug 6793 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 14:57:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 12:57:30 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #19 from Owen Leonard --- (In reply to Kyle M Hall from comment #18) > > 5/ Why do you add a show_marc JS function instead of using the "classic" way > > (link to showmarc.pl)? > > The "classic" way uses greybox, which isn't compatible with DataTables built > from an ajax source. On the plus side, I'm using jQuery UI instead, and if > we switched all of them to jQuery UI, we could drop greybox as a dependency. ...which is something I would like to be able to do if we could (See Bug 8290). I find that in this case the jQueryUI dialog works well. In other cases I have found that it isn't as easy to implement as Greybox, hence the lack of progress on that bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 15:20:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 13:20:58 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #20 from Owen Leonard --- (In reply to Kyle M Hall from comment #18) > My bad, the call is supposed to be void(0). This appears to be the preferred > practice these days. The problem with href="#" No, using "javascript:" is not the preferred practice. More frequently you'll see "return false" added to the onclick (at least in cases where "return false" is what you want). The ideal way to handle something like this is to design the inserted markup so that the click event can be moved into the main JavaScript block (even better, into a separate JavaScript file). Then the outcome of the click event can be handled by something like this: http://css-tricks.com/return-false-and-prevent-default/ This isn't an issue that should block QA, but is something to think about next time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 15:25:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 13:25:14 +0000 Subject: [Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #21 from Jonathan Druart --- (In reply to Kyle M Hall from comment #18) > > 1/ On tools/manage-marc-import.pl, I got a JS error: > > aoData.push( { "name": "import_batch_id", "value": } ); > > The table should not be displayed if there is no import_batch_id parameter. > > Fixed! Still got the JS error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 16:16:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 14:16:15 +0000 Subject: [Koha-bugs] [Bug 10499] UT: VirtualShelves.t needs a database transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10499 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #11 from Galen Charlton --- (In reply to kenza from comment #3) > The patch 10386 doesn't add the rollback, so i think these two patches are > complementary. As a general note, it is not necessary to explicitly call $dbh->rollback. When AutoCommit is off, DBD::mysql automatically issues a rollback when the script ends, and if the script gets killed, the transaction never gets committed either. That said, it doesn't hurt anything to have the explicit rollback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 16:19:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 14:19:48 +0000 Subject: [Koha-bugs] [Bug 10499] UT: VirtualShelves.t needs a database transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10499 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Galen Charlton --- Pushed to master. Thanks, Kenza! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 16:23:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 14:23:11 +0000 Subject: [Koha-bugs] [Bug 10275] UT: OrderFromSubscription.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10275 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 16:44:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 14:44:46 +0000 Subject: [Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #13 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 17:01:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 15:01:02 +0000 Subject: [Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19691|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Created attachment 19693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19693&action=edit Bug 10195 Records hidden with OpacSuppression can still be accessed Records hidden with OpacSuppression are filtered from the search results, but the opac-detail page is still visible if you know the biblio number. This patch hides the detail page for suppressed biblios by redirecting (controlled by the syspref OpacSuppressionRedirect) either to opac-blocked (default), explaining that the record is blocked (including optional explanatory text from the syspref OpacSuppressionMessage) or to Koha's 404 page, giving no hint that a biblio with that number exists in the system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 17:25:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 15:25:05 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Owen Leonard --- Does this depend on another patch? It doesn't apply on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 17:34:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 15:34:43 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Galen Charlton --- Thanks, Jonathan! I've pushed the part of the patch that changed AddBookSeller to master, along with a follow-up that adds a regression test. However, I have not pushed the part that updates ModBookSeller on the following grounds: [1] That routine is not actually related to the bug. [2] The proposed change to that routine is purely cosmetic. Cosmetic and source reformatting patches really ought to be separate from ones that change functionality or fix bugs. [3] The proposed reformatting has issues -- in particular, I simply do not see the point of the changes proposed to lines 240-254. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 17:43:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 15:43:16 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 --- Comment #16 from Galen Charlton --- My proposal, as I agree that it's impossible for one vhost to be 100% sure about the configuration of another one: - only check the environment passed to the staff interface virtual host to determine if a syspref is overridden - add a (commented-out) example to koha-httpd.conf that alerts the the sysadmin that they probably want to override any syspref in an OPAC vhost in the staff interface vhost as well. Since overriding sysprefs via the Apache configuration would be an "advanced" feature, having a couple rough edges is not a showstopper IMO as long as we document them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 17:46:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 15:46:25 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Galen Charlton --- Pushed to master. Thanks, Adrien! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 17:47:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 15:47:32 +0000 Subject: [Koha-bugs] [Bug 10127] Printoverdues.sh should tar only pdf files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10127 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Sophie! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 17:47:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 15:47:47 +0000 Subject: [Koha-bugs] [Bug 10127] Printoverdues.sh should tar only pdf files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10127 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 17:51:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 15:51:40 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19556|0 |1 is obsolete| | --- Comment #10 from Owen Leonard --- Created attachment 19694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19694&action=edit [SIGNED-OFF] Bug 10481: FIX No enrollment fee when changing patron category. When a patron changes to a category with enrollment fee, they are not generated. Test plan: - Choose a category without fee (e.g. Kid) - Add an enrollment fee for another category (e.g. Young adult) - Choose a kid and change his category to "Young adult". - Note the warning message "Fees & Charges: Patron has Outstanding fees & charges of XX" on the check out page. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 17:51:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 15:51:50 +0000 Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #11 from Galen Charlton --- There are two separate requests in this bug to have the default be per-patron category. Kyle, are you amenable to redoing the patch to have the default privacy value be an attribute of patron category? Consider this part of my "sometimes a global YASP is not the right level of configurability" hobbyhorse. Setting to in discussion. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 17:53:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 15:53:13 +0000 Subject: [Koha-bugs] [Bug 6254] can't set patron privacy by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 --- Comment #12 from Galen Charlton --- (In reply to Katrin Fischer from comment #10) > Functionality wise this works and passes QA, but I am not so happy about the > system preference description: > > NewPatronPrivacySetting: > New patrons should have a privacy setting of default|never|forever > > I don't thinks this explains what this setting will do to a librarian trying > to configure Koha and without deeper knowledge about the features and > terminology. Also "Privacy" is a pretty broad term and this only affects how > long we keep the reading history. I share Katrin's concerns about the description and feel that it could be expanded a bit. If we end up running with a syspref (but see my previous comment), I also think that DefaultPatronPrivacySetting would be a better name. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 18:23:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 16:23:57 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Owen Leonard --- Auto-merging C4/Bookseller.pm CONFLICT (content): Merge conflict in C4/Bookseller.pm Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 18:33:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 16:33:24 +0000 Subject: [Koha-bugs] [Bug 10573] French translation for printing a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 --- Comment #2 from Owen Leonard --- Shouldn't "pdfformat::layout3pagesfr" be added as a choice to the pref file? For that matter, shouldn't "pdfformat::layout2pages" and "pdfformat::layout3pages" also be built into the pref file for selection, or do I misunderstand how this preference works? Is there a reason why pdfformat isn't selectable at the time of printing? Why should it be a global preference? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 18:39:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 16:39:38 +0000 Subject: [Koha-bugs] [Bug 10563] Link to edit subscription from 'check expiraton' page is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10563 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 18:39:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 16:39:41 +0000 Subject: [Koha-bugs] [Bug 10563] Link to edit subscription from 'check expiraton' page is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10563 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19529|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 19695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19695&action=edit [SIGNED-OFF] Bug 10563: Fix broken 'Edit' link on check expiration page This fixes the broken 'Edit' (subscription) link on the check expiration page in serials. To test: - Add a subscription - Go to the check expiration page - Search for your subscription, use an expiration date in the far future - Verify the edit link on the result list doesn't work right before applying the patch, but works after Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 18:46:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 16:46:24 +0000 Subject: [Koha-bugs] [Bug 10596] New: make expiration date an option Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10596 Bug ID: 10596 Summary: make expiration date an option Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Right now on patron records you need an expiration date but not all libraries use that type of function and the expiration date actually gets in their way. It would be nice if you could choose if your library cares about expiration dates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 18:49:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 16:49:57 +0000 Subject: [Koha-bugs] [Bug 10597] New: Search to hold button broken on record details Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Bug ID: 10597 Summary: Search to hold button broken on record details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The holds button in cat-toolbar is broken for "search to hold". It is a split button rather than a dropdown button. Clicking the caret works fine, but clicked the button sends you to the marc editor! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 18:50:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 16:50:12 +0000 Subject: [Koha-bugs] [Bug 10597] Search to hold button broken on record details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 18:53:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 16:53:36 +0000 Subject: [Koha-bugs] [Bug 10597] Search to hold button broken on record details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 18:53:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 16:53:39 +0000 Subject: [Koha-bugs] [Bug 10597] Search to hold button broken on record details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 --- Comment #1 from Kyle M Hall --- Created attachment 19696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19696&action=edit Bug 10597 - Search to hold button broken on record details The holds button in cat-toolbar is broken for "search to hold". It is a split button rather than a dropdown button. Clicking the caret works fine, but clicked the button sends you to the marc editor! Test Plan: 1) View a patron's details page 2) Click 'search to hold' 3) Search for something 4) On the results page, click a result line's title link ( catalogue/detail.pl ) 5) Note the "Place hold" button is a split button, click the left half of the button, note it redirects you to the editor. 6) Apply this patch 7) Repeat steps 1-5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 19:22:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 17:22:46 +0000 Subject: [Koha-bugs] [Bug 4907] Suggestions "organize by" menu doesn't reflect current choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4907 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Katrin! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 19:24:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 17:24:46 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #46 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Bernardo and Marcel! Note: I added an entry in updatedatabase.pl for 3.12.x, that tells the user about this, just in case they want to apply it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 19:30:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 17:30:18 +0000 Subject: [Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #17 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 19:30:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 17:30:51 +0000 Subject: [Koha-bugs] [Bug 9519] Wrong language code for Italian in the advanced search language limitations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9519 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Sonia! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 19:40:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 17:40:50 +0000 Subject: [Koha-bugs] [Bug 8884] opacheader is not in the header on CCSR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #21 from Bernardo Gonzalez Kriegel --- First patch pushed to 3.10.x, will be in 3.10.8 Second does not apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 20:35:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 18:35:51 +0000 Subject: [Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19693|0 |1 is obsolete| | --- Comment #3 from Mirko Tietgen --- Created attachment 19697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19697&action=edit Bug 10195 Records hidden with OpacSuppression can still be accessed Records hidden with OpacSuppression are filtered from the search results, but the opac-detail page is still visible if you know the biblio number. This patch hides the detail page for suppressed biblios by redirecting (controlled by the syspref OpacSuppressionRedirect) either to opac-blocked (default), explaining that the record is blocked (including optional explanatory text from the syspref OpacSuppressionMessage) or to Koha's 404 page, giving no hint that a biblio with that number exists in the system. Test plan: Make sure you have at least one record with 942$n == 1. Set OpacSuppression to "Don't hide". Do an OPAC search that should bring up your hidden record and other records. Observe that your record is found. Open the detail page for the record. Observe that it is accessible. Copy the URL for later(!). Set OpacSuppression to "Hide". Leave OpacSuppressionByIPRange blank. Set OpacSuppressionRedirect to "an explanatory page ('This record is blocked')." Leave OpacSuppressionMessage blank for now. Disable queryparser(!) (because of bug 10542). Do a full zebra reindex. Do an OPAC search that should bring up your hidden record and other records. Observe that your record is not found. Open the opac-detail URL of the record (the one you copied before). Observe that you are redirected to opac-blocked and it displays a short standard message. Edit OpacSuppressionMessage and input some text. Open the opac-detail URL of the record again (the one you copied before). Observe that the text you entered in OpacSuppressionMessage is displayed under the standard text you have seen before. Set OpacSuppressionRedirect to "the 404 error page ('Not found')." Open the opac-detail URL of the record again (the one you copied before). Observe that you are redirected to Koha's 404 error page. Sign off the patch. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 20:39:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 18:39:21 +0000 Subject: [Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 21:01:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 19:01:17 +0000 Subject: [Koha-bugs] [Bug 10496] CCSR theme OPAC tabs to not show correct active state In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10496 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 21:02:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 19:02:05 +0000 Subject: [Koha-bugs] [Bug 10548] koha_perl_deps.pl miscounts dependencies displayed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10548 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 21:07:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 19:07:10 +0000 Subject: [Koha-bugs] [Bug 10535] by default sort funds by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- The first patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 21:09:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 19:09:40 +0000 Subject: [Koha-bugs] [Bug 10560] No way to disable english In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10560 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Robin! Note: i think the webinstaller didn't get fixed. After I push the latest patches to 3.12.x i'll try to re-test. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 21:10:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 19:10:19 +0000 Subject: [Koha-bugs] [Bug 10490] Overdue fines cap (amount) in circulation rules is saved incorrectly (rounded) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10490 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 21:59:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 19:59:08 +0000 Subject: [Koha-bugs] [Bug 10595] OpacTopissue page still accessible when system preference is turned off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 --- Comment #1 from Mirko Tietgen --- Created attachment 19698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19698&action=edit Bug 10595 - OpacTopissue page still accessible when system preference is turned off When the syspref is turned off, the link is hidden but the page is still accessible. This patch checks the syspref and redirects to 404 if it is disabled. Test plan: Before applying the patch Enable OpacTopissue Observe there is a link to opac-topissues.pl next to Advanced search etc. Follow that link, observe that opac-topissues.pl is loading Disable OpacTopissue Observe the link is gone Manually open /koha/opac-topissues.pl and check that it is loading even though the feature is disabled Apply patch (OpacTopissue still diabled) Manually open /koha/opac-topissues.pl and observe that you are being redirected to the 404 page. Enable OpacTopissue Follow the link or manuall open opac-topissues.pl and check that it is working Signoff the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 22:01:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 20:01:07 +0000 Subject: [Koha-bugs] [Bug 10595] OpacTopissue page still accessible when system preference is turned off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |mirko at abunchofthings.net Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 22:02:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 20:02:28 +0000 Subject: [Koha-bugs] [Bug 10529] Dollar sign hardcoded in patron message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10529 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 22:02:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 20:02:53 +0000 Subject: [Koha-bugs] [Bug 10475] Item form in acquisition not hiding subfields properly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10475 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Owen! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 22:03:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 20:03:26 +0000 Subject: [Koha-bugs] [Bug 10507] Typo when warning about creating duplicate patron attribute In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10507 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 23:08:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 21:08:07 +0000 Subject: [Koha-bugs] [Bug 10447] Language definitions for 'ru' and 'uk' are not available during install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10447 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 16 23:57:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 21:57:04 +0000 Subject: [Koha-bugs] [Bug 10598] New: self check shouldn't link out to catalog Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10598 Bug ID: 10598 Summary: self check shouldn't link out to catalog Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org When you use self check the titles you check out are linked to the opac, the problem here is that most libraries set their self check machines to not allow visiting pages outside of the self check. If you click a title and get in to the opac then you might not be able to get back to the self check if those safeguards are in place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 01:03:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 23:03:18 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #11 from Srdjan Jankovic --- > The patch for bug 10337 creates a DB with all sample data. Sorry, did not know of that. It is in discussion, what is the instruction for using it atm? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 01:11:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 23:11:08 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 --- Comment #4 from Srdjan Jankovic --- Yes. 10556 should not be applied any more I guess, it has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 01:19:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 23:19:32 +0000 Subject: [Koha-bugs] [Bug 10557] GetBooksellersWithLateOrders has an unused branch parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10557 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 01:19:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 23:19:36 +0000 Subject: [Koha-bugs] [Bug 10557] GetBooksellersWithLateOrders has an unused branch parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10557 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19499|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 19699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19699&action=edit [SIGNED-OFF] Bug 10557: GetBooksellersWithLateOrders has an unused branch parameter C4::Booksellers::GetBooksellersWithLateOrders has an unused parameter. The $branch variable is never used in the routine. Test plan: Check that no behavior changes on the late orders page. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 01:31:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 16 Jul 2013 23:31:23 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #13 from Srdjan Jankovic --- Same result (same 2 failed tests). Do you think I should try on an empty database, or you'd rather make it work on any database. I can see merits in the latter, but if there's consensus that tests should run against some initial data, I'm fine with that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 02:01:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 00:01:43 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 02:01:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 00:01:47 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19544|0 |1 is obsolete| | --- Comment #19 from Srdjan Jankovic --- Created attachment 19700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19700&action=edit [SIGNED-OFF] Bug 2394: Use syspref canreservefromotherbranches in CanItemBeReserved Signed-off-by: Srdjan -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 02:11:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 00:11:03 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19545|0 |1 is obsolete| | --- Comment #20 from Srdjan Jankovic --- Created attachment 19701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19701&action=edit [SIGNED-OFF] Bug 2394: Use syspref canreservefromotherbranches in CanItemBeReserved Signed-off-by: Srdjan -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 02:20:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 00:20:11 +0000 Subject: [Koha-bugs] [Bug 10597] Search to hold button broken on record details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 02:20:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 00:20:15 +0000 Subject: [Koha-bugs] [Bug 10597] Search to hold button broken on record details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19696|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 19702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19702&action=edit [SIGNED-OFF] Bug 10597 - Search to hold button broken on record details The holds button in cat-toolbar is broken for "search to hold". It is a split button rather than a dropdown button. Clicking the caret works fine, but clicked the button sends you to the marc editor! Test Plan: 1) View a patron's details page 2) Click 'search to hold' 3) Search for something 4) On the results page, click a result line's title link ( catalogue/detail.pl ) 5) Note the "Place hold" button is a split button, click the left half of the button, note it redirects you to the editor. 6) Apply this patch 7) Repeat steps 1-5 Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 02:59:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 00:59:25 +0000 Subject: [Koha-bugs] [Bug 10358] add a syspref to allow BLOCKED patrons to return items, via the SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10358 Bob Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10554 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 02:59:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 00:59:25 +0000 Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns' syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554 Bob Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10358 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 03:31:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 01:31:07 +0000 Subject: [Koha-bugs] [Bug 10595] OpacTopissue page still accessible when system preference is turned off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 03:31:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 01:31:10 +0000 Subject: [Koha-bugs] [Bug 10595] OpacTopissue page still accessible when system preference is turned off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19698|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 19703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19703&action=edit [SIGNED-OFF] Bug 10595 - OpacTopissue page still accessible when system preference is turned off When the syspref is turned off, the link is hidden but the page is still accessible. This patch checks the syspref and redirects to 404 if it is disabled. Test plan: Before applying the patch Enable OpacTopissue Observe there is a link to opac-topissues.pl next to Advanced search etc. Follow that link, observe that opac-topissues.pl is loading Disable OpacTopissue Observe the link is gone Manually open /koha/opac-topissues.pl and check that it is loading even though the feature is disabled Apply patch (OpacTopissue still diabled) Manually open /koha/opac-topissues.pl and observe that you are being redirected to the 404 page. Enable OpacTopissue Follow the link or manuall open opac-topissues.pl and check that it is working Signoff the patch. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 03:52:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 01:52:53 +0000 Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns' syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554 Bob Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob at calyx.net.au --- Comment #3 from Bob Birchall --- Attempting sign-off against a biblibre sandbox (#8). The patch hasn't applied. I can't tell if the problem is the sandbox or the patch. Will check with Mason. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 04:36:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 02:36:22 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 04:36:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 02:36:25 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19572|0 |1 is obsolete| | --- Comment #14 from Srdjan Jankovic --- Created attachment 19704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19704&action=edit [SIGNED-OFF] Bug 10543 - false mandatory warning in additem When editing a item, you get a popup warning : "1 mandatory fields empty (highlighted)". But all mandatory fields are filled. This is because there is a field with a huge content (more than 100 characters), it it displayed in a textarea instead of input. This patch corrects javascript form check by using siblings(). Also adds a more precise filter to find mandatory inputs because looking in full page may bring unwanted results. Test plan : - In a framework, make sure you have in item field : An optionnal subfield (without authorised value) then a mandatory subfield then an optional subfield next to mandatory subfield For example : $i (optional), $r (mandatory) and $s (optional) - Open a biblio record and create a new item - Enter more than 100 characters in $i, fill $r and $s - Click "Add item" - Edit this item => You get a textarea for $i - Empty $s and Save => Without patch, you get a warning and form is not saved and you see that $s is yellow while it should be $r => With patch, form is saved - Re-edit this item - Empty $r and save => You get a warning and form is not saved Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 04:38:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 02:38:08 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19576|0 |1 is obsolete| | --- Comment #15 from Srdjan Jankovic --- Created attachment 19705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19705&action=edit [SIGNED-OFF] Bug 10543 - Unify item mandatory subfields check Use of CheckMandatorySubfields from cataloging.js everywhere an item cataloging form is checked for mandatories Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 04:38:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 02:38:52 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 --- Comment #16 from Srdjan Jankovic --- Created attachment 19706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19706&action=edit [SIGNED-OFF] Bug 10543 - add mandatory subfield check to addorderiso2709.pl When adding orders from staged file, you can create one order per record using item form in the bottom of addorderiso2709.pl. This form was missing check. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 04:39:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 02:39:52 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19574|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 05:04:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 03:04:47 +0000 Subject: [Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 05:04:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 03:04:51 +0000 Subject: [Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19549|0 |1 is obsolete| | --- Comment #17 from Srdjan Jankovic --- Created attachment 19707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19707&action=edit [SIGNED-OFF] Bug 7019: Circulation History Sort Order Wrong (in datatable) The "return date" column sort is not using the date sort algorithm because it is confused by the combination of date data and text data ("Checked out"). This patch adds the use of datatable "title-string" sort type. With that, the date in ISO format are used for sorting and because letters are before numbers, "Checked out" rows are more recent than any date. Test plan : - set dateformat syspref to "dd/mm/yyyy" - Go to members/readingrec.pl for a borrower having a old issues and checked out issues => Check that sort of "Return date" is correct. For example : With patch : 20/01/2011 06/03/2011 20/03/2011 Checked Out Without patch : 06/03/2011 20/01/2011 20/03/2011 Checked Out - Test also with dateformat syspref "mm/dd/yyyy" Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 05:13:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 03:13:25 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19647|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 19708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19708&action=edit Based on patron category unhide items hidden with OpacHiddenItems Ran into a test case that blew up, corrected for this case. Paste in a opac-detail url for a hidden item in a fresh browser. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 05:18:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 03:18:52 +0000 Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #17 from Srdjan Jankovic --- I don't think adding a flag warrants changing CountItemsIssued() interface that much, ie I believe in this case CountItemsIssued($biblionumbe, $include_on_order) is a better solution. A test would be nice to have too, but not that fussed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 05:39:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 03:39:10 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #3 from Srdjan Jankovic --- 1. +my $sth = $dbh->prepare("SELECT * FROM items WHERE biblionumber=?;"); +$sth->execute($biblionumber); + +my @itemsmatchingbiblionumber; +my $matchingitem = $sth->fetchrow_hashref; +while ($matchingitem) { + push @itemsmatchingbiblionumber,$matchingitem; + $matchingitem = $sth->fetchrow_hashref; +} is perhaps better written as my $itemsmatchingbiblionumber = $dbh->selectall_arrayref($sql, { Slice => {}}, $biblionumber) 2. Database queries should all be placed in modules (probably C4/Items.pm for this one, maybe theres even something similar already there) so they can be tested 3. There should be a check if ($biblionumber) { get the items etc } so we do not make database calls in vain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 05:43:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 03:43:03 +0000 Subject: [Koha-bugs] [Bug 10578] Escaping CGI breaks results sort feature (librarian's interface) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10578 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #2 from Srdjan Jankovic --- Why not my @operators = map uri_unescape($_), $cgi->param('op'); etc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 05:59:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 03:59:27 +0000 Subject: [Koha-bugs] [Bug 10559] noisy statement handle still active warnings when generating notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10559 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 05:59:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 03:59:30 +0000 Subject: [Koha-bugs] [Bug 10559] noisy statement handle still active warnings when generating notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10559 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19508|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 19709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19709&action=edit [SIGNED-OFF] bug 10559: remove spurious "statement handle still active" warnings Generating (e.g.) overdue notices can result in spurious warnings in the cronjob logs: $ ./misc/cronjobs/overdue_notices.pl -t -library CPL prepare_cached(SELECT * FROM issues WHERE itemnumber = ?) statement handle DBI::st=HASH(0x54a7828) still Active at C4/Letters.pm line 589 This patch removes the warning by making sure that the relevant statement handle is finished after fetching its first row of results. To test: [1] Set up an overdue loan such that running overdue_notices.pl will trigger the generation of a notice. [2] Run overdue_notices.pl -t and note the warning message. [3] Apply the patch. [4] Run overdue_notices.pl -t again and note that the warning message is no longer displayed. [5] Check the message_queue table and verify that the overdue notices generated in steps 2 and 4 have the same text. Signed-off-by: Galen Charlton Signed-off-by: Srdjan -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 06:09:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 04:09:00 +0000 Subject: [Koha-bugs] [Bug 6435] False "no items" in search results [intranet] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Doug Kingston changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19267|0 |1 is obsolete| | --- Comment #16 from Doug Kingston --- Created attachment 19710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19710&action=edit Improved patch to add daemon mode to rebuild_zebra.pl This improved patch adds a variable to set the sleep time between checks for new records to index. The check is very cheap and not dependent on the size of the catalog so we make it every 5 seconds. Any records found (probably just one), are indexed by zebra incrementally. This will make new records nearly instantly available for search. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 06:12:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 04:12:15 +0000 Subject: [Koha-bugs] [Bug 10463] Quote of the day feature not selecting random quotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10463 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 06:12:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 04:12:18 +0000 Subject: [Koha-bugs] [Bug 10463] Quote of the day feature not selecting random quotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10463 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18940|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 19711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19711&action=edit [SIGNED-OFF] Bug 10463 - Quote of the day feature not selecting random quotes When the Quote of the Day tool selects a new new quote, it updates the timestamp and does not take the timezone into account. Thus the time is set to +4 hours (e.g. 2013-06-11 13:33:48 when the time is 2013-06-11 09:33:48). It then repeats the same quote every day. To replicate: set Administration >> System preferences >> OPAC preferences >> Features >> QuoteOfTheDay to Enable In Home >> Tools >> Quote Editor, add several quotes. In the opac, refresh the home page. You should get a quote of the day at the top. mysql> select * from quotes; note the timestamp of the quote selected by the tool. It will not match the date on the machine. If you change the date to the previous date and refresh the opac, the tool wlill select another quote, which will not change unless forced. Test Plan: 1) Remove all your quotes and import a fresh set 2) Enable the quote of the day and view the opac 3) Look at your quotes table and note the timestamp is incorrect 4) Repeat steps 1 and 2 5) Look at your quotes table and note the timestamp is now correct Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 06:44:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 04:44:44 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19614|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 19712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19712&action=edit If there is at least one item and every item is hidden, hide the biblio entry. Applied Srdjan Jankovic's suggestions, and came up with a cleaner patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 06:48:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 04:48:28 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #5 from M. Tompsett --- Oops! Biblioitemnumber != Biblionumber. Back to square one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 08:15:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 06:15:08 +0000 Subject: [Koha-bugs] [Bug 10578] Escaping CGI breaks results sort feature (librarian's interface) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10578 --- Comment #3 from Janusz Kaczmarek --- (In reply to Srdjan Jankovic from comment #2) > Why not > my @operators = map uri_unescape($_), $cgi->param('op'); > > etc Just to be consistent with how it looks like in analogous spots in opac/opac-search.pl... But feel free to modify if you think it is worth of. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 08:15:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 06:15:26 +0000 Subject: [Koha-bugs] [Bug 10573] French translation for printing a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Owen, you have raised some very good points! I think that having an option to choose the template before generating it would be great. Also as the values are kind of hardcoded now we could have a pull down instead of having people to know the exact name to put in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 09:27:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 07:27:11 +0000 Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns' syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554 Bob Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Bob Birchall --- The earlier error was mine. I have now tested against all three conditions and have observed the expected behaviour. The overdue item can be returned when the sys pref is 'Allow all' but cannot be returned when the sys pref is 'Allow Non-Blocked' (as expected). I was not able to test this aspect: the patch correctly 'upgrades' existing 'allow' selection to the new 'Allow non-blocked' value. so, any existing 'allow' selection works as before Maybe that needs a separate sign-off? Signing off that the test plan executes correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 09:31:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 07:31:51 +0000 Subject: [Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19701|[SIGNED-OFF] Bug 2394: Use |[SIGNED-OFF] [3.12.x] Bug description|syspref |2394: Use syspref |canreservefromotherbranches |canreservefromotherbranches |in CanItemBeReserved |in CanItemBeReserved -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 09:40:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 07:40:13 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #12 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #11) > > The patch for bug 10337 creates a DB with all sample data. > > Sorry, did not know of that. It is in discussion, what is the instruction > for using it atm? There is no instruction atm. I sent an email to the mailing list, but I did not get an answer. The patch allows to create a new DB with sample data only. These sample data are required for some unit tests (indeed, it is really boring to create *all* data for each unit tests). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 09:41:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 07:41:29 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #13 from Jonathan Druart --- (In reply to Owen Leonard from comment #10) > Created attachment 19694 [details] [review] > [...] > Signed-off-by: Owen Leonard Owen, did you forgot to change the status to Signed Off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 09:42:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 07:42:41 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #14 from Jonathan Druart --- (In reply to Jonathan Druart from comment #13) > (In reply to Owen Leonard from comment #10) > > Created attachment 19694 [details] [review] [review] > > [...] > > Signed-off-by: Owen Leonard > > Owen, did you forgot to change the status to Signed Off? Ok, I understood after sending the comment, only 1 patch is signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 09:52:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 07:52:31 +0000 Subject: [Koha-bugs] [Bug 6281] Bug in LCC sort routine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6281 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #21 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.15 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 09:56:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 07:56:40 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #14 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #2) > t/db_dependent/Branch.t .. 1/31 > # Failed test 'CAT1 details are right' > # at t/db_dependent/Branch.t line 170. > # Structures begin differing at: > # $got = ARRAY(0x28b3028) > # $expected = HASH(0x28b2c80) I don't understand how it is possible, GetBranchCategory returns an hashref (if you applied patch for bug 10515). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 10:15:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 08:15:10 +0000 Subject: [Koha-bugs] [Bug 9370] use Library::CallNumber::LC when splitting LC call numbers for spine labels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #17 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 10:18:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 08:18:26 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19566|0 |1 is obsolete| | --- Comment #5 from kenza --- Created attachment 19713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19713&action=edit Bug 10528: C4::Booksellers needs unit tests Unit tests are wrap in a database transaction. GetBooksellerWithLateOrders has been modify in order to pass the tests. Now it considers the field $estimateddeliverydateto and it replaces it by now() only if it is undef. More it doesn't test if $aqbookseller.deliverytime is not Null anymore but if $deliverytime = null or undef, it replaces it by 0. It also verifies if $delay is >= 0. ModBookseller has been modify in order to be more explicit: before it always returned undef. Now it returns : 1 -> If a modification has been done 0E0 -> If the given id doesn't exist undef -> If no id given DelBookSeller has been modify in order to be more explicit: Before it returned undef, now it returns $sth->execute($id), so we can verify how many bookSellers have been deleted. Test Plan : prove t/db_dependant/Booksellers.t t/db_dependent/Bookseller.t .. 2/67 [Some warnings about uninitialized values] WARNING: GetBooksellerWithLateOrders is called with a negative value at /home/kenza/workspace/kohaclone/C4/Bookseller.pm line 137. t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=67, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.43 cusr 0.03 csys = 0.49 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 11:58:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 09:58:17 +0000 Subject: [Koha-bugs] [Bug 8757] Longer size text for authorized values description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8757 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED Assignee|adrien.saurat at biblibre.com |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 14:10:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 12:10:02 +0000 Subject: [Koha-bugs] [Bug 10573] French translation for printing a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 --- Comment #4 from Christophe Croullebois --- Hello Owen and Katrin, thx for your comments, in fact as often, I have made a little patch for a customer who is waiting a quick and efficient result. But I agree with you, the things are not very good in the present state. I am not sure to well understand what do you mean Owen, first about the syspref ' OrderPdfFormat', in his actual state you have to put the right string in it, do you mean it would be better to have a drop down list with 3 (with my french patch) choices in it ? Well, this would be more ergonomic, yes. In an older version of koha we had a second syspref to choose the pdf template or maybe it was a specific dev. made by us, anyway I agree, it would be better to have the opportunity to change the pdf template. In the present state, the call of the pdf template is hard-coded in the layoutXpages.pm, but I think it would be better to have the hand on the choice. In fact the matter is that we have a .pm with text in it (the reason why I have created a new one) and this .pm is pointing on a pdf template with some text too. In the .pm you have also all the format for placing the text and the numbers. It is the reason why you have layout2pages.pm and layout3pages.pm, both in English, in fact these .pm are kind of templates and need to be adapted, for instance if the name or address of the library is too long, and over that layer, you add the pdf file, and in the same way each library can change the text in it or the place of a column, a frame... So for a translation we have two files to create. To resume, it would be better to have a ddl for the syspref and maybe an other in the basketgroup.pl to choose the pdf template. More, it would be better to have all the text in the pdf, the translation would be easier. But the purpose of my patch is just to have the printing in French with the existing code, it does no more. Maybe, Katrin and Owen, we should create a new bug report for these improvements ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 14:28:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 12:28:19 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 14:28:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 12:28:07 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19690|0 |1 is obsolete| | --- Comment #4 from Fridolyn SOMERS --- Created attachment 19714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19714&action=edit Bug 10588 - opac-topissues first branch always selected in filters I rebased on master. There was a conflict with Bug 10590 patch. I should apply on a today fresh master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 14:44:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 12:44:37 +0000 Subject: [Koha-bugs] [Bug 10599] New: Uncheck on loan items on the batch item modification tool Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10599 Bug ID: 10599 Summary: Uncheck on loan items on the batch item modification tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 14:44:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 12:44:44 +0000 Subject: [Koha-bugs] [Bug 10599] Uncheck on loan items on the batch item modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10599 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 14:46:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 12:46:00 +0000 Subject: [Koha-bugs] [Bug 10599] Uncheck on loan items on the batch item modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10599 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 14:46:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 12:46:03 +0000 Subject: [Koha-bugs] [Bug 10599] Uncheck on loan items on the batch item modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10599 --- Comment #1 from Jonathan Druart --- Created attachment 19715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19715&action=edit Bug 10599: Clear on loan items on the batch item modification tool Sometimes when using the batch item modification tool, we would like to automatically uncheck on loan items. Test plan: 1/ Go to tools/batchMod.pl. 2/ Enter some barcode (at least 1 should be on loan). 3/ Click on the Continue button. 4/ Click on the "Clear on loan" link. 5/ Check that on loan items are unchecked. Launch the unit test file: prove t/db_dependent/Circulation/IsItemIssued.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 14:47:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 12:47:34 +0000 Subject: [Koha-bugs] [Bug 10600] New: Duplicate authority Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10600 Bug ID: 10600 Summary: Duplicate authority Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 14:47:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 12:47:41 +0000 Subject: [Koha-bugs] [Bug 10600] Duplicate authority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 14:48:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 12:48:51 +0000 Subject: [Koha-bugs] [Bug 10600] Duplicate authority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 14:48:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 12:48:55 +0000 Subject: [Koha-bugs] [Bug 10600] Duplicate authority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10600 --- Comment #1 from Jonathan Druart --- Created attachment 19716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19716&action=edit Bug 10600: Duplicate an authority A simple link allows to duplicate an existing authority. Test plan: 1/ Go to a detail authority page 2/ Click to the "Duplicate" button 3/ Edit some fields 4/ Save 5/ The new authority is created from the existing one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 14:49:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 12:49:47 +0000 Subject: [Koha-bugs] [Bug 10601] New: Add a counter on batch items modifications Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10601 Bug ID: 10601 Summary: Add a counter on batch items modifications Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 14:49:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 12:49:54 +0000 Subject: [Koha-bugs] [Bug 10601] Add a counter on batch items modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10601 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 14:50:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 12:50:59 +0000 Subject: [Koha-bugs] [Bug 10601] Add a counter on batch items modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10601 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 14:51:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 12:51:03 +0000 Subject: [Koha-bugs] [Bug 10601] Add a counter on batch items modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10601 --- Comment #1 from Jonathan Druart --- Created attachment 19717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19717&action=edit Bug 10601: Add a counter on batch items modifications After executing a batch items modifications, a dialog is displayed above the result table. It contains the number of items (and total fields) which has been modified. Test plan: 1/ Go to tools/batchMod.pl 2/ Enter a barcodes list 3/ Check/uncheck items and fill some values to apply 4/ Save 5/ The table summary will be displayed with a dialog box on top: XX item(s) modified (with YY fields modified) Check that XX and YY correspond with what you expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 14:52:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 12:52:30 +0000 Subject: [Koha-bugs] [Bug 10602] New: Set a default value for authorities Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602 Bug ID: 10602 Summary: Set a default value for authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 14:52:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 12:52:37 +0000 Subject: [Koha-bugs] [Bug 10602] Set a default value for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 14:53:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 12:53:34 +0000 Subject: [Koha-bugs] [Bug 10602] Set a default value for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 14:53:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 12:53:37 +0000 Subject: [Koha-bugs] [Bug 10602] Set a default value for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602 --- Comment #1 from Jonathan Druart --- Created attachment 19718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19718&action=edit Bug 10602: Set a default value for authorities Some code already exist but the feature does not work. This patch allows to define default values in the authorities framework. Test plan: 1/ Choose a framework, field and subfields. 2/ Define a default value. 3/ Create a new authority and check that the subfield is automatically filled with the default value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 14:54:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 12:54:34 +0000 Subject: [Koha-bugs] [Bug 4887] "Default value" option missing for Authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4887 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |DUPLICATE --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 10602 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 14:54:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 12:54:34 +0000 Subject: [Koha-bugs] [Bug 10602] Set a default value for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolelligallevi at gmail.com --- Comment #2 from Jonathan Druart --- *** Bug 4887 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 15:06:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 13:06:56 +0000 Subject: [Koha-bugs] [Bug 10038] Doubled 'default' entry when creating a new authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10038 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 15:07:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 13:07:00 +0000 Subject: [Koha-bugs] [Bug 10038] Doubled 'default' entry when creating a new authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10038 --- Comment #1 from Jonathan Druart --- Created attachment 19719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19719&action=edit Bug 10038: Doubled 'default' entry when creating a new authority type Test plan: - Create a new authority type - Click MARC structure - Verify the pull down has only 1 entry for Default - Go on the authority type home (admin/authtypes.pl) - Click on the "MARC structure" link for the default type - Verify the pull down has only 1 entry for Default This patch adds a sort (on the authtypecode) for these 2 lists. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 15:08:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 13:08:31 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19712|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 19720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19720&action=edit If there is at least one item and every item is hidden, hide the biblio entry. There's a sufficient functional call: GetItemsInfo. Nicely revised patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 15:08:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 13:08:40 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 15:09:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 13:09:37 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 --- Comment #17 from M. de Rooy --- Yes, I think that checking all possible opac and staff vhosts is overkill. Parsing the apache conf is also not really what you want to do in Koha. We could just introduce e.g. an environment var for the staff vhost like OVERRIDE_SYSPREF_NAMES. This could just be a comma separated list of all sysprefs that are overridden in one or more of the corresponding opac vhosts. (As a variant of what Galen also suggests.) No further checking; using this feature wisely requires skills. Note that seeing a few overridden prefs should trigger the Koha admin to expect one more too.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 15:26:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 13:26:05 +0000 Subject: [Koha-bugs] [Bug 7706] AuthorisedValueImages not displaying all images on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 --- Comment #3 from Fridolyn SOMERS --- AuthorisedValueImages syspref description is missing some details. Fist of all, this syspref applies only if XSLT is off (Looks like DisplayOPACiconsXSLT syspref manages the case with XSLT). Looking at code, it appears that this syspref only manages the fields of biblio using authorized values, not the fields of item. This is logical because images are shown with other biblio informations, not with items. So ccode image is displayed only if defined at biblio level. In OPAC details page, items table can show an image for lost status. But there is a little bug. Adding an image for location would be an enhancement and I think it should use a new Template Toolkit plugin. Note that itemtype image is managed by noItemTypeImages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 15:35:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 13:35:30 +0000 Subject: [Koha-bugs] [Bug 7706] AuthorisedValueImages not displaying all images on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 --- Comment #4 from Fridolyn SOMERS --- > Fist of all, this syspref applies only if XSLT is off (Looks like DisplayOPACiconsXSLT syspref manages the case with XSLT). Correction : it does not depend on XSLT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 15:39:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 13:39:07 +0000 Subject: [Koha-bugs] [Bug 9740] using XSLT modifies record authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9740 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7706 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 15:39:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 13:39:07 +0000 Subject: [Koha-bugs] [Bug 7706] AuthorisedValueImages not displaying all images on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9740 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 15:46:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 13:46:06 +0000 Subject: [Koha-bugs] [Bug 7706] AuthorisedValueImages not displaying all images on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 --- Comment #5 from Fridolyn SOMERS --- I found a bug on detail pages : When XSLT is on, the images are not displayed ; it works when XSLT is off. The cause of this bug is corrected by Bug 9740 : when XSLT is on, the authorized value codes are replaced by there description in all page, this affects the authorized value images. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 15:46:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 13:46:42 +0000 Subject: [Koha-bugs] [Bug 9740] using XSLT modifies record authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9740 --- Comment #17 from Fridolyn SOMERS --- I found a side effect of this bug : Bug 7706 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 15:53:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 13:53:54 +0000 Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131 --- Comment #41 from Katrin Fischer --- Hi Kyle, could you please also add the new option to the command line tool for staging marc records (/misc/stage_file.pl)? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 15:57:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 13:57:09 +0000 Subject: [Koha-bugs] [Bug 10499] UT: VirtualShelves.t needs a database transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10499 --- Comment #13 from M. de Rooy --- Although this patch is already pushed, I want to add some remarks: The code deletes the following lines: -for(my $i=0; $i<10;$i++){ - my $shelfnumber = $shelves[$i]->{number}; - if($shelfnumber<0) { - ok(1, 'Skip DelShelf for shelf -1'); - next; - } - my $status = DelShelf($shelfnumber); - ok(1 == $status, "deleted shelf $shelfnumber and its contents"); -} I do not agree with deleting those lines. Testing the DelShelf function should be done! Scrutiny :) I do agree with deleting this line: -DelBiblio($_) for @biblionumbers; I do not suggest to revert the patch however or send a followup. Why not? I am rebasing my patch on report 10441 that needs 9032 which is in Signed Off state. In this patch I will restore the DelShelf code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 15:58:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 13:58:47 +0000 Subject: [Koha-bugs] [Bug 10441] UT: Testing AddShare in VirtualShelves.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 --- Comment #4 from M. de Rooy --- See also report 10499. This patch removed the DelShelf code. Will include it again in rebasing this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 16:06:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 14:06:12 +0000 Subject: [Koha-bugs] [Bug 10441] UT: Testing AddShare in VirtualShelves.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18822|0 |1 is obsolete| | --- Comment #5 from M. de Rooy --- Created attachment 19721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19721&action=edit Bug 10441: Testing AddShare in VirtualShelves.t Builds upon 10386 and 9032. Adds a unit test for routine AddShare. This patch also restores the inadvertently deleted DelShelf tests in bug 10499. Test plan: Run the test. All passed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 16:08:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 14:08:03 +0000 Subject: [Koha-bugs] [Bug 7706] AuthorisedValueImages not displaying all images on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 --- Comment #6 from Fridolyn SOMERS --- Created attachment 19722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19722&action=edit Bug 7706 - use AuthorisedValueImages in opac-detail.pl AuthorisedValueImages syspref was missing from opac-details. See commit comment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 16:09:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 14:09:37 +0000 Subject: [Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #18 from Jonathan Druart --- QA comment: The last patch works great. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 16:09:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 14:09:56 +0000 Subject: [Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19707|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 19723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19723&action=edit Bug 7019: Circulation History Sort Order Wrong (in datatable) The "return date" column sort is not using the date sort algorithm because it is confused by the combination of date data and text data ("Checked out"). This patch adds the use of datatable "title-string" sort type. With that, the date in ISO format are used for sorting and because letters are before numbers, "Checked out" rows are more recent than any date. Test plan : - set dateformat syspref to "dd/mm/yyyy" - Go to members/readingrec.pl for a borrower having a old issues and checked out issues => Check that sort of "Return date" is correct. For example : With patch : 20/01/2011 06/03/2011 20/03/2011 Checked Out Without patch : 06/03/2011 20/01/2011 20/03/2011 Checked Out - Test also with dateformat syspref "mm/dd/yyyy" Signed-off-by: Srdjan Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 16:10:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 14:10:35 +0000 Subject: [Koha-bugs] [Bug 7706] AuthorisedValueImages not displaying all images on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 --- Comment #7 from Fridolyn SOMERS --- Created attachment 19724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19724&action=edit Bug 7706 - Do not display authorized value image if url is empty Small bug : if authorized value image url is empty (not undefined) the image was shows but without src the alt was shown. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 16:11:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 14:11:34 +0000 Subject: [Koha-bugs] [Bug 7706] AuthorisedValueImages not displaying all images on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 --- Comment #8 from Fridolyn SOMERS --- Created attachment 19725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19725&action=edit Bug 7706 - Show image in item lost status Small bug on lost image in detail page : See commit message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 16:11:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 14:11:40 +0000 Subject: [Koha-bugs] [Bug 7706] AuthorisedValueImages not displaying all images on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 16:13:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 14:13:12 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 16:13:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 14:13:14 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #1 from Kyle M Hall --- Created attachment 19726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19726&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons The patron lists feature is somewhat similar to the record lists feature in that it allows a librarian to create a list of patrons for later retrieval and manipluation. These lists can then be used with the batch patron modification tool. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Access the patron lists feature from the "More" pulldown on the main menu. 4) Create a new list via the "New patron list" button. 5) For this list, click the "Edit" button, and change the list name. 6) For this list, click the "Add patrons" button, and search for and add some patrons to your list. 7) For this list select some patrons to remove them. 8) Try both adding some new patrons, and removing some old patrons as a single action. 9) Click the "Patrons" link on the Koha toolbar 10) Search the patrons, or browse by letter to get patron results 11) Check the checkboxes next to one or more patrons, and add the selected patrons to your existing list. 12) Change the "Selected patrons" pulldown to "All resultant patrons" and add them to your list. 13) Check the checkboxes next to one or more patrons, and add the selected patrons to a new list. 14) Go back to the Patron Lists feature and delete your lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 16:20:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 14:20:41 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19726|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 19727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19727&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons The patron lists feature is somewhat similar to the record lists feature in that it allows a librarian to create a list of patrons for later retrieval and manipluation. These lists can then be used with the batch patron modification tool. Test Plan: 0) Apply the patch for Bug 8798 1) Apply this patch 2) Run updatedatabase.pl 3) Access the patron lists feature from Koha's Tools menu. 4) Create a new list via the "New patron list" button. 5) For this list, click the "Edit" button, and change the list name. 6) For this list, click the "Add patrons" button, and search for and add some patrons to your list. 7) For this list select some patrons to remove them. 8) Try both adding some new patrons, and removing some old patrons as a single action. 9) Click the "Patrons" link on the Koha toolbar 10) Search the patrons, or browse by letter to get patron results 11) Check the checkboxes next to one or more patrons, and add the selected patrons to your existing list. 12) Change the "Selected patrons" pulldown to "All resultant patrons" and add them to your list. 13) Check the checkboxes next to one or more patrons, and add the selected patrons to a new list. 14) Go back to the Patron Lists feature and delete your lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 16:24:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 14:24:42 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19727|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 19728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19728&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons The patron lists feature is somewhat similar to the record lists feature in that it allows a librarian to create a list of patrons for later retrieval and manipluation. These lists can then be used with the batch patron modification tool. Test Plan: 0) Apply the patch for Bug 8798 1) Apply this patch 2) Run updatedatabase.pl 3) Access the patron lists feature from Koha's Tools menu. 4) Create a new list via the "New patron list" button. 5) For this list, click the "Edit" button, and change the list name. 6) For this list, click the "Add patrons" button, and search for and add some patrons to your list. 7) For this list select some patrons to remove them. 8) Try both adding some new patrons, and removing some old patrons as a single action. 9) Click the "Patrons" link on the Koha toolbar 10) Search the patrons, or browse by letter to get patron results 11) Check the checkboxes next to one or more patrons, and add the selected patrons to your existing list. 12) Change the "Selected patrons" pulldown to "All resultant patrons" and add them to your list. 13) Check the checkboxes next to one or more patrons, and add the selected patrons to a new list. 14) Try manipulating a list of patrons using the batch patron modification tool. 15) Go back to the Patron Lists feature and delete your lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 16:26:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 14:26:35 +0000 Subject: [Koha-bugs] [Bug 10603] New: required fields in the courses table should be not null Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10603 Bug ID: 10603 Summary: required fields in the courses table should be not null Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org There are three fields in the courses table that the UI marks as required: - department - course number - course name However, the corresponding columns in all three of these tables are nullable. If these must be required for reasons of business logic, the columns should be not null. Of course, it's not quite clear if all three of these columns are actually required. Making course name required makes sense, but I'm not sure if making the department and course number required is baking in an assumption about how all academic institutions organize their course lists. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 16:26:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 14:26:57 +0000 Subject: [Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Galen Charlton --- (In reply to Katrin Fischer from comment #13) > Hm, still think it's a bit funny to have unrequired (by the system) fields > required. I think the question here is if we push Owen's fix or remove the > required attribute from the field? I've gone ahead and pushed Owen's patch (thanks, Owen!) and your follow-up (thanks, Katrin!), but from my POV, the question of what fields should be required remains open, so I've opened bug 10603. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 16:28:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 14:28:51 +0000 Subject: [Koha-bugs] [Bug 10604] New: two columns in the courses table aren't wide enough Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10604 Bug ID: 10604 Summary: two columns in the courses table aren't wide enough Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org Both courses.department and courses.term refer to authorized values, and consequently should be varchar(80) to match authorised_values.authorised_value. They're currently varchar(20). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 16:33:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 14:33:18 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #4 from Kyle M Hall --- Unit tests will be forthcoming, qa fyi ; ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 16:39:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 14:39:57 +0000 Subject: [Koha-bugs] [Bug 10605] New: Problems with translated cart email sent from OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605 Bug ID: 10605 Summary: Problems with translated cart email sent from OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org I spotted some problems with sending cart emails from the OPAC: There is a problem with encoding, as the umlauts in the translated German message are broken. The first paragraph is repeated and the list of items is completely missing. I have seen this happening on 3.12.1 - would be glad if someone could test and confirm on their installation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 16:40:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 14:40:13 +0000 Subject: [Koha-bugs] [Bug 10604] two columns in the courses table aren't wide enough In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10604 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 16:40:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 14:40:16 +0000 Subject: [Koha-bugs] [Bug 10604] two columns in the courses table aren't wide enough In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10604 --- Comment #1 from Galen Charlton --- Created attachment 19729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19729&action=edit Bug 10604: increase width of two columns in the courses table The department and term columns in the courses table started as varchar(20), but since they refer to authorized values, need to be varchar(80) to match authorised_values.authorised_value. This patch increases the width of those columns. To test: [1] Create two DEPARTMENT authorised values, one whose code is shorter than 20 characters and one whose code is longer than 20 characters. [2] Create two courses; give one course the short department and the other the long department. [3] Go to the courses list. Observe that the department column is displays the department name only for the short course. [4] Apply the patch. [5] Edit the course with the long department and assign that long department to it again. [6] Go back to the courses list. Observe that both of the courses now display their assigned department. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 16:48:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 14:48:18 +0000 Subject: [Koha-bugs] [Bug 10563] Link to edit subscription from 'check expiraton' page is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10563 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 16:48:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 14:48:20 +0000 Subject: [Koha-bugs] [Bug 10563] Link to edit subscription from 'check expiraton' page is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10563 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19695|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 19730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19730&action=edit Bug 10563: Fix broken 'Edit' link on check expiration page This fixes the broken 'Edit' (subscription) link on the check expiration page in serials. To test: - Add a subscription - Go to the check expiration page - Search for your subscription, use an expiration date in the far future - Verify the edit link on the result list doesn't work right before applying the patch, but works after Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 17:01:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 15:01:32 +0000 Subject: [Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #20 from Galen Charlton --- Pushed to master. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 17:03:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 15:03:52 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard --- A template file seems to be missing: patron_lists/list.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 17:05:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 15:05:08 +0000 Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 --- Comment #12 from Paul Poulain --- still investigating : error still here in SAN-OP (3.10.7), they have biblibre at deb2571:~$ pmvers Plack 1.0023 biblibre at deb2571:~$ pmvers Starman 0.3011 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 17:05:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 15:05:10 +0000 Subject: [Koha-bugs] [Bug 10563] Link to edit subscription from 'check expiraton' page is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10563 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 17:23:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 15:23:51 +0000 Subject: [Koha-bugs] [Bug 7484] Keeping typed values when searching for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7484 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m Assignee|adrien.saurat at biblibre.com |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 17:30:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 15:30:30 +0000 Subject: [Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 17:33:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 15:33:45 +0000 Subject: [Koha-bugs] [Bug 7484] Keeping typed values when searching for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7484 --- Comment #2 from Fridolyn SOMERS --- Created attachment 19731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19731&action=edit Bug 7484 - Keeping typed values when searching for authorities See commit message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 17:33:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 15:33:55 +0000 Subject: [Koha-bugs] [Bug 7484] Keeping typed values when searching for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7484 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 17:34:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 15:34:06 +0000 Subject: [Koha-bugs] [Bug 7484] Keeping typed values when searching for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7484 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 17:55:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 15:55:03 +0000 Subject: [Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Galen Charlton --- Pushed to master. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 17:56:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 15:56:01 +0000 Subject: [Koha-bugs] [Bug 10606] New: query in GetUpcomingDueIssues Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Bug ID: 10606 Summary: query in GetUpcomingDueIssues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org The patch for bug 9362 (which I did accept into master) introduces a MySQLism: Using HAVING without GROUP BY is a MySQLism, so at some point the query will have to become: SELECT issues.*, items.itype as itemtype, items.homebranch, TO_DAYS( date_due )-TO_DAYS( NOW() ) as days_until_due, branches.branchemail FROM issues LEFT JOIN items USING (itemnumber) LEFT OUTER JOIN branches USING (branchcode) WHERE returndate is NULL AND (TO_DAYS( date_due )-TO_DAYS( NOW() )) > 0 AND (TO_DAYS( date_due )-TO_DAYS( NOW() )) < ?; This is a pity, as it would be nice to be able to use "days_until_due" as an alias to make the query more readable, but it simply isn't portable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 18:10:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 16:10:09 +0000 Subject: [Koha-bugs] [Bug 10607] New: JavaScript indexOf function not supported by IE 7 and 8 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10607 Bug ID: 10607 Summary: JavaScript indexOf function not supported by IE 7 and 8 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Browser compatibility Assignee: oleonard at myacpl.org Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org The indexOf JavaScript function is not supported by IE 7 and 8. This bug is a omnibus for replacing it in Koha JavaScript code. Grepping indicates that the following files may be affected: gmc at zadi:~/koha$ grep -rl indexOf koha-tmpl/intranet-tmpl/prog/en/{includes,modules,js} koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt koha-tmpl/intranet-tmpl/prog/en/js/additem.js koha-tmpl/intranet-tmpl/prog/en/js/xmlControlfield.js koha-tmpl/intranet-tmpl/prog/en/js/acq.js koha-tmpl/intranet-tmpl/prog/en/js/basket.js koha-tmpl/intranet-tmpl/prog/en/js/datatables.js gmc at zadi:~/koha$ grep -rl indexOf koha-tmpl/opac-tmpl/prog/en/{includes,modules,js} koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt koha-tmpl/opac-tmpl/prog/en/modules/opac-full-serial-issues.tt koha-tmpl/opac-tmpl/prog/en/js/browserid_include.js koha-tmpl/opac-tmpl/prog/en/js/amazonimages.js koha-tmpl/opac-tmpl/prog/en/js/basket.js koha-tmpl/opac-tmpl/prog/en/js/datatables.js koha-tmpl/opac-tmpl/prog/en/js/bakertaylorimages.js The following external JavaScript library files may use it as well, but that isn't necessarily a problem, as they may be doing so in a cross-browser way: gmc at zadi:~/koha$ grep -rl indexOf koha-tmpl/opac-tmpl/prog/en/lib koha-tmpl/opac-tmpl/prog/en/lib/greybox/GreyBox_v5_5/greybox_source/auto_deco.js koha-tmpl/opac-tmpl/prog/en/lib/greybox/GreyBox_v5_5/greybox_source/base/base.js koha-tmpl/opac-tmpl/prog/en/lib/greybox/GreyBox_v5_5/greybox_source/base/AJS.js koha-tmpl/opac-tmpl/prog/en/lib/greybox/AJS.js koha-tmpl/opac-tmpl/prog/en/lib/greybox/gb_scripts.js koha-tmpl/opac-tmpl/prog/en/lib/jquery/jquery.js koha-tmpl/opac-tmpl/prog/en/lib/jquery/jquery-ui.js koha-tmpl/opac-tmpl/prog/en/lib/jquery/plugins/jquery.metadata.min.js koha-tmpl/opac-tmpl/prog/en/lib/jquery/plugins/jquery.highlight-3.js koha-tmpl/opac-tmpl/prog/en/lib/jquery/plugins/jquery.dataTables.min.js gmc at zadi:~/koha$ grep -rl indexOf koha-tmpl/intranet-tmpl/prog/en/lib koha-tmpl/intranet-tmpl/prog/en/lib/yui/container/container_core-debug.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/container/container_core.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/container/container-min.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/container/container.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/container/container-debug.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/container/container_core-min.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/yahoo-dom-event/yahoo-dom-event.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/utilities/utilities.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/menu/menu-min.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/menu/menu-debug.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/menu/menu.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/plugins/bubbling-min.js koha-tmpl/intranet-tmpl/prog/en/lib/greybox/GreyBox_v5_5/greybox_source/auto_deco.js koha-tmpl/intranet-tmpl/prog/en/lib/greybox/GreyBox_v5_5/greybox_source/base/base.js koha-tmpl/intranet-tmpl/prog/en/lib/greybox/GreyBox_v5_5/greybox_source/base/AJS.js koha-tmpl/intranet-tmpl/prog/en/lib/greybox/AJS.js koha-tmpl/intranet-tmpl/prog/en/lib/greybox/gb_scripts.js koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.uitablefilter.js koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery-ui-timepicker-addon.js koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.dataTables.min.js koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.dataTables.columnFilter.js [1] http://kangax.github.io/es5-compat-table/#Array.prototype.indexOf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 18:10:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 16:10:29 +0000 Subject: [Koha-bugs] [Bug 10541] Enable cross-browser AJAX in additem.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10541 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10607 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 18:10:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 16:10:29 +0000 Subject: [Koha-bugs] [Bug 10607] JavaScript indexOf function not supported by IE 7 and 8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10607 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10541 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 18:11:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 16:11:02 +0000 Subject: [Koha-bugs] [Bug 10541] Enable cross-browser AJAX in additem.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10541 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- (In reply to Katrin Fischer from comment #4) > I have run into this in training as well and glad to see a patch for it as > this has been quite a blocker bug for the library. There are also IE > problems in serials and other modules - maybe we shold fix all IndexOf > appearances? Indeed. I have opened bug 10607 for tracking this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 18:21:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 16:21:20 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 18:21:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 16:21:23 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19728|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 19732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19732&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons The patron lists feature is somewhat similar to the record lists feature in that it allows a librarian to create a list of patrons for later retrieval and manipluation. These lists can then be used with the batch patron modification tool. Test Plan: 0) Apply the patch for Bug 8798 1) Apply this patch 2) Run updatedatabase.pl 3) Access the patron lists feature from Koha's Tools menu. 4) Create a new list via the "New patron list" button. 5) For this list, click the "Edit" button, and change the list name. 6) For this list, click the "Add patrons" button, and search for and add some patrons to your list. 7) For this list select some patrons to remove them. 8) Try both adding some new patrons, and removing some old patrons as a single action. 9) Click the "Patrons" link on the Koha toolbar 10) Search the patrons, or browse by letter to get patron results 11) Check the checkboxes next to one or more patrons, and add the selected patrons to your existing list. 12) Change the "Selected patrons" pulldown to "All resultant patrons" and add them to your list. 13) Check the checkboxes next to one or more patrons, and add the selected patrons to a new list. 14) Try manipulating a list of patrons using the batch patron modification tool. 15) Go back to the Patron Lists feature and delete your lists. 16) Run 'prove t/db_dependent/PatronLists.t' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 18:22:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 16:22:32 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19732|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 19733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19733&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons The patron lists feature is somewhat similar to the record lists feature in that it allows a librarian to create a list of patrons for later retrieval and manipluation. These lists can then be used with the batch patron modification tool. Test Plan: 0) Apply the patch for Bug 8798 1) Apply this patch 2) Run updatedatabase.pl 3) Access the patron lists feature from Koha's Tools menu. 4) Create a new list via the "New patron list" button. 5) For this list, click the "Edit" button, and change the list name. 6) For this list, click the "Add patrons" button, and search for and add some patrons to your list. 7) For this list select some patrons to remove them. 8) Try both adding some new patrons, and removing some old patrons as a single action. 9) Click the "Patrons" link on the Koha toolbar 10) Search the patrons, or browse by letter to get patron results 11) Check the checkboxes next to one or more patrons, and add the selected patrons to your existing list. 12) Change the "Selected patrons" pulldown to "All resultant patrons" and add them to your list. 13) Check the checkboxes next to one or more patrons, and add the selected patrons to a new list. 14) Try manipulating a list of patrons using the batch patron modification tool. 15) Go back to the Patron Lists feature and delete your lists. 16) Run 'prove t/db_dependent/PatronLists.t' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 18:23:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 16:23:10 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #8 from Kyle M Hall --- Good catch, fixed! (In reply to Owen Leonard from comment #5) > A template file seems to be missing: patron_lists/list.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 18:34:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 16:34:51 +0000 Subject: [Koha-bugs] [Bug 10607] JavaScript indexOf function not supported by IE 7 and 8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10607 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I think one of the problems possibly related to the use of IndexOf is the inability to select irregularities when creating subscriptions in serials. I can't test it here as I don't have an old IE, so that's from my training notes. koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 18:34:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 16:34:54 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19733|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 19734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19734&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons The patron lists feature is somewhat similar to the record lists feature in that it allows a librarian to create a list of patrons for later retrieval and manipluation. These lists can then be used with the batch patron modification tool. Test Plan: 0) Apply the patch for Bug 8798 1) Apply this patch 2) Run updatedatabase.pl 3) Access the patron lists feature from Koha's Tools menu. 4) Create a new list via the "New patron list" button. 5) For this list, click the "Edit" button, and change the list name. 6) For this list, click the "Add patrons" button, and search for and add some patrons to your list. 7) For this list select some patrons to remove them. 8) Try both adding some new patrons, and removing some old patrons as a single action. 9) Click the "Patrons" link on the Koha toolbar 10) Search the patrons, or browse by letter to get patron results 11) Check the checkboxes next to one or more patrons, and add the selected patrons to your existing list. 12) Change the "Selected patrons" pulldown to "All resultant patrons" and add them to your list. 13) Check the checkboxes next to one or more patrons, and add the selected patrons to a new list. 14) Try manipulating a list of patrons using the batch patron modification tool. 15) Go back to the Patron Lists feature and delete your lists. 16) Run 'prove t/db_dependent/PatronLists.t' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 18:39:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 16:39:09 +0000 Subject: [Koha-bugs] [Bug 10541] Enable cross-browser AJAX in additem.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10541 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 18:49:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 16:49:00 +0000 Subject: [Koha-bugs] [Bug 10607] JavaScript indexOf function not supported by IE 7 and 8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10607 --- Comment #2 from Galen Charlton --- (In reply to Katrin Fischer from comment #1) > I think one of the problems possibly related to the use of IndexOf is the > inability to select irregularities when creating subscriptions in serials. I > can't test it here as I don't have an old IE, so that's from my training > notes. > koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt Based on my (and others) testing of the patch for bug 10541, this sort of thing can be tested in IE 9 or 10 by using "F12 developer tools" to set the browser mode to IE 7 or IE 8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 18:53:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 16:53:15 +0000 Subject: [Koha-bugs] [Bug 10607] JavaScript indexOf function not supported by IE 7 and 8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10607 --- Comment #3 from Katrin Fischer --- Cool, thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 20:04:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 18:04:55 +0000 Subject: [Koha-bugs] [Bug 10515] The prototype for GetBranchCategory and GetBranchCategories is not consistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10515 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master, along with two follow-ups to add a regression test and to fix the call to GetBranchCategories in C4/Auth.pm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 20:46:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 18:46:05 +0000 Subject: [Koha-bugs] [Bug 10503] incorrect initialization parameters passed to Memoize::Memcached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10503 --- Comment #5 from Galen Charlton --- (In reply to Srdjan Jankovic from comment #4) > I can see GetMarcStructure and getTranslatedLanguages, but not _get_columns I tried again and it works for me: $ memcdump --servers localhost:11211 KOHAismemcached KOHAmemoize-getTranslatedLanguages-scalar-intranet KOHAmemoize-getTranslatedLanguages-list-intranet KOHAkohaconf KOHAmemoize-_get_columns-scalar-borrowers Could you try again, and if it doesn't work, provide more details about your test environment? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 21:15:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 19:15:53 +0000 Subject: [Koha-bugs] [Bug 10549] ILS-DI should not use ISO-8851-9 encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10549 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- Pushed to master, along with a follow-up to ensure that the output of the GetAvailability service is actually encoded as UTF-8. Thanks, Mirko! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 17 21:28:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 19:28:59 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #10 from Owen Leonard --- After you create a new list, it would be nice if it redirected you to the page for adding patrons to that list. That's how it works with book lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 01:07:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 23:07:20 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #15 from Srdjan Jankovic --- Well 10515 is in master now. I'll put some debugging and get more details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 01:41:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 23:41:20 +0000 Subject: [Koha-bugs] [Bug 10503] incorrect initialization parameters passed to Memoize::Memcached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10503 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 01:41:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 23:41:23 +0000 Subject: [Koha-bugs] [Bug 10503] incorrect initialization parameters passed to Memoize::Memcached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10503 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19236|0 |1 is obsolete| | --- Comment #6 from Srdjan Jankovic --- Created attachment 19735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19735&action=edit [SIGNED-OFF] bug 10503: fix various issues with use of Memoize::Memcached Memoize::Memcached expects to be passed a hashref of connection parameters, which it in turn uses to initialize a Cache::Memcached object. However, commit 52afe06ddd started passing a Cache::Memcached object directly, not the required hashref. This happened to work by coincidence, but no longer works with recent versions of Memoize::Memcached packaged for Debian. This patch introduces a new C4::Context function, memcached_params(), that returns a hashref of connection parameters suitable for passing to the Cache::Memcached constructor. It also introduces a UNITCHECK block to C4::Context so that memcached_params() can be used during intialization of the module. This patch also corrects SQLHelper so that it no longer tries to use the deprecated (and removed) memcached_servers setting in koha-conf.xml; it now gets the memcached connection parameters from C4::Context->memcached_params(). To test: [1] This patch is most easily tested on Debian Wheezy, as version 0.03-2 of the libmemoize-memcached-perl package includes the fix for Debian bug 614868 that causes Koha's use of Memoize::Memcached to break. If you don't want to go so far as to install/upgrade to Wheezy, you can apply the following Debian patch to your copy of Memoize::Memcached to get the effect: http://patch-tracker.debian.org/patch/series/view/libmemoize-memcached-perl/0.03-2/universal.patch [2] Set up your Koha Apache configuration to point to a memcached server. [3] Restart memcached to start with a clear cache. [4] Do the following steps: - Create a new bib record. Note that it is sufficient to just open the editor; you don't need to save the bib. - Search for a patron record. [5] Use the memcdump command-line to get a list of keys in your memcached cache. You should *not* see keys that contain the strings GetMarcStructure, getTranslatedLanguages, or _get_columns. [6] Apply the patch, then go through step 4 again. [7] Use memcdump again. This time, you *should* see the keys mentioned in step 5. [8] Set the SessionStorage system preference to memcached. After logging in again, verify that your staff interface and OPAC sessions work without requiring that you log in for each and every page load. Signed-off-by: Galen Charlton Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 01:42:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 23:42:55 +0000 Subject: [Koha-bugs] [Bug 10503] incorrect initialization parameters passed to Memoize::Memcached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10503 --- Comment #7 from Srdjan Jankovic --- Sorry, it is there. I'm going to see my optometrist today, that should help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 01:52:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 23:52:43 +0000 Subject: [Koha-bugs] [Bug 10441] UT: Testing AddShare in VirtualShelves.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 01:52:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 23:52:46 +0000 Subject: [Koha-bugs] [Bug 10441] UT: Testing AddShare in VirtualShelves.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19721|0 |1 is obsolete| | --- Comment #6 from Srdjan Jankovic --- Created attachment 19736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19736&action=edit [SIGNED-OFF] Bug 10441: Testing AddShare in VirtualShelves.t Builds upon 10386 and 9032. Adds a unit test for routine AddShare. This patch also restores the inadvertently deleted DelShelf tests in bug 10499. Test plan: Run the test. All passed? Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 01:53:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 17 Jul 2013 23:53:51 +0000 Subject: [Koha-bugs] [Bug 10441] UT: Testing AddShare in VirtualShelves.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 --- Comment #7 from Srdjan Jankovic --- Just an idea, maybe use SKIP block rather than if(). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 02:53:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 00:53:55 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 02:53:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 00:53:58 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19720|0 |1 is obsolete| | --- Comment #7 from Srdjan Jankovic --- Created attachment 19737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19737&action=edit [SIGNED-OFF] Bug 10584 - Hide OPAC biblio details if all items are hidden If there are items for a given biblio number, and they are all hidden, then biblio needs to be hidden. If the biblio needs to be hidden, this is done by setting the biblionumber to 0, which triggers the same output as if the biblionumber does not exist. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 02:55:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 00:55:43 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 --- Comment #8 from Srdjan Jankovic --- Not quite sure how useful this is, if all items are hidden there will be no entry on the search results anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 03:01:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 01:01:57 +0000 Subject: [Koha-bugs] [Bug 10608] New: Add accessioning date information to catalogue report Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10608 Bug ID: 10608 Summary: Add accessioning date information to catalogue report Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: vanoudt at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 19738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19738&action=edit template changes to add accession date to the catalgoue report The following patches add the ability to limit the catalogue report according to the date an item was accessioned. For our academic accreditation, we are required to produce a report showing the number of books added to our library in the last year in a particular subject area (call numbers are used to limit to this area). This patch makes that possible. Not sure how this patch relates to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 03:02:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 01:02:30 +0000 Subject: [Koha-bugs] [Bug 10608] Add accessioning date information to catalogue report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10608 --- Comment #1 from Nicholas van Oudtshoorn --- Created attachment 19739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19739&action=edit perl changes to add accession date to the catalgoue report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 03:02:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 01:02:42 +0000 Subject: [Koha-bugs] [Bug 10608] Add accessioning date information to catalogue report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10608 Nicholas van Oudtshoorn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vanoudt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 03:03:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 01:03:08 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 --- Comment #9 from M. Tompsett --- In reply to your inquiry about the usefulness, this prevents data mining on private collections of items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 03:06:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 01:06:36 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 --- Comment #6 from Srdjan Jankovic --- prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. 1/67 # Failed test 'Returns right fields of Supplier1 and Supllier2' # at t/db_dependent/Bookseller.t line 128. # Structures begin differing at: # $got->[0]{listincgst} = '0' # $expected->[0]{listincgst} = '1' Use of uninitialized value $calculated in substitution (s///) at C4/Serials.pm line 988. Use of uninitialized value $pattern in numeric eq (==) at C4/Serials.pm line 991. Use of uninitialized value $calculated in substitution (s///) at C4/Serials.pm line 1000. Use of uninitialized value $calculated in substitution (s///) at C4/Serials.pm line 1003. Use of uninitialized value $serialseq in string at C4/Serials.pm line 1391. Use of uninitialized value $calculated in substitution (s///) at C4/Serials.pm line 988. Use of uninitialized value $pattern in numeric eq (==) at C4/Serials.pm line 991. Use of uninitialized value $calculated in substitution (s///) at C4/Serials.pm line 1000. Use of uninitialized value $calculated in substitution (s///) at C4/Serials.pm line 1003. Use of uninitialized value $serialseq in string at C4/Serials.pm line 1391. Use of uninitialized value $calculated in substitution (s///) at C4/Serials.pm line 988. Use of uninitialized value $pattern in numeric eq (==) at C4/Serials.pm line 991. Use of uninitialized value $calculated in substitution (s///) at C4/Serials.pm line 1000. Use of uninitialized value $calculated in substitution (s///) at C4/Serials.pm line 1003. Use of uninitialized value $serialseq in string at C4/Serials.pm line 1391. WARNING: GetBooksellerWithLateOrders is called with a negative value at C4/Bookseller.pm line 137. # Looks like you failed 1 test of 67. Do I need 10337 for this one too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 03:09:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 01:09:37 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 --- Comment #10 from Srdjan Jankovic --- So much evil in this world... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 03:16:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 01:16:26 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 03:16:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 01:16:29 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19326|0 |1 is obsolete| | Attachment #19494|0 |1 is obsolete| | --- Comment #5 from Liz Rea --- Created attachment 19740 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19740&action=edit Followup to bug 8133 - fix JS escaping in data literals There was some unescaped data being put into JS literals, which could cause the calendar interface to fail to load. Note for testing: Template::Plugin::JavaScript must be installed, either from CPAN or libtemplate-plugin-javascript-perl. Signed-off-by: Liz Rea Interface seems to work, I don't note any regressions. I tested the following: Normal, non holiday circulation with no hours set - due dates seem correct and consistent. Holiday set for today, library opens at 9am, closes at 10:30am. Item checked out at 10am, due 10:30am - seems right! UseDaysMode was set to "calendar" Holiday set for today, library opens at 9am, closes at 10:30am. Item checked out at 10am, due tomorrow at 9:30 - seems right! UseDaysMode was set to "days" Interface looks nice, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 03:25:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 01:25:19 +0000 Subject: [Koha-bugs] [Bug 10601] Add a counter on batch items modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10601 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 03:25:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 01:25:22 +0000 Subject: [Koha-bugs] [Bug 10601] Add a counter on batch items modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10601 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19717|0 |1 is obsolete| | --- Comment #2 from Liz Rea --- Created attachment 19741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19741&action=edit Bug 10601: Add a counter on batch items modifications After executing a batch items modifications, a dialog is displayed above the result table. It contains the number of items (and total fields) which has been modified. Test plan: 1/ Go to tools/batchMod.pl 2/ Enter a barcodes list 3/ Check/uncheck items and fill some values to apply 4/ Save 5/ The table summary will be displayed with a dialog box on top: XX item(s) modified (with YY fields modified) Check that XX and YY correspond with what you expected. Signed-off-by: Liz Rea batch modification still seems to work correctly, with the helpful addition of the counter. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 04:01:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 02:01:50 +0000 Subject: [Koha-bugs] [Bug 10599] Uncheck on loan items on the batch item modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10599 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 04:01:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 02:01:53 +0000 Subject: [Koha-bugs] [Bug 10599] Uncheck on loan items on the batch item modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10599 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19715|0 |1 is obsolete| | --- Comment #2 from Liz Rea --- Created attachment 19742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19742&action=edit Bug 10599: Clear on loan items on the batch item modification tool Sometimes when using the batch item modification tool, we would like to automatically uncheck on loan items. Test plan: 1/ Go to tools/batchMod.pl. 2/ Enter some barcode (at least 1 should be on loan). 3/ Click on the Continue button. 4/ Click on the "Clear on loan" link. 5/ Check that on loan items are unchecked. Launch the unit test file: prove t/db_dependent/Circulation/IsItemIssued.t http://bugs.koha-community.org/show_bug.cgi?id=10572 Signed-off-by: Liz Rea Works as expected, only modifies items that are checked (still). No regression noted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 04:54:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 02:54:07 +0000 Subject: [Koha-bugs] [Bug 10574] Remove the message about upgrading to 3.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #3 from Liz Rea --- This test plan makes me happy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 05:01:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 03:01:18 +0000 Subject: [Koha-bugs] [Bug 10553] Public lists not available from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 05:01:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 03:01:21 +0000 Subject: [Koha-bugs] [Bug 10553] Public lists not available from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19491|0 |1 is obsolete| | --- Comment #5 from Liz Rea --- Created attachment 19743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19743&action=edit Bug 10553 - Public lists not available from OPAC login page If you are not logged in to the OPAC, looking at the login page, and you click the Lists button to see public lists it says there are none. This patch corrects Auth.pm so that it loads the list of public lists in this situation. To test you must have at least one public list. Make sure you are logged out of the OPAC and visit the login page (/cgi-bin/koha/opac-user.pl). Clicking the "Lists" button should show you a list of public shelves. Signed-off-by: Liz Rea works as described, and list button is not shown when opacpublic is disabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 05:27:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 03:27:00 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 05:27:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 03:27:03 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19714|0 |1 is obsolete| | --- Comment #5 from Liz Rea --- Created attachment 19744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19744&action=edit Bug 10588 - opac-topissues first branch always selected in filters In OPAC most popular items page: With user is logged-in his branch should be selected. When a branch is manually selected and form is submitted, this branch should be selected in results page. When looking at HTML, you see that all options are selected in combobox. This patch corrects by using the code "__ANY__" to distinguish form display and no branch filter selected. Test plan : - Make sure there are issues on records created in the past 3 month - Go to OPAC not logged-in - Click on "Most popular" => You get to page with results, "All libraries" is selected - Select a branch and submit => You get to page with results, the branch is selected [testing opac-topissues.inc from] - Select a branch and perform a search that does not have results (for example an item type never issued) => You get to page without results, the branch is selected [testing opac-topissues.tt form] - Log-in with a user - Click on "Most popular" => You get to page with results, user's branch is selected - Select "All libraries" and submit => You get to page with results, "All libraries" is selected [testing opac-topissues.inc from] - Select "All libraries" and perform a search that does not have results (for example an item type never issued) => You get to page without results, "All libraries" is selected [testing opac-topissues.tt form] Signed-off-by: Liz Rea Tests work as described - much improved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 05:54:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 03:54:59 +0000 Subject: [Koha-bugs] [Bug 8402] generate 'install_misc/debian.packages' file from debian/control file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 --- Comment #11 from Mason James --- (In reply to M. Tompsett from comment #10) > Given that there is the ability to: > $ sudo apt-get install koha-deps koha-perldeps > > Are > - install_misc/debian.packages > - install_misc/ubuntu.packages > - install_misc/ubuntu.12.04.packages > - install_misc/ubuntu.10.04.packages > - install_misc/ubuntu-packages.sh > - this script suggestion > even necessary? no, i don't think they are necessary i would be happy with a patch that removed these files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 05:55:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 03:55:22 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |liz at catalyst.net.nz --- Comment #11 from Liz Rea --- I like this a lot. Like, a LOT. As in, I squeed when I was playing with it. However, there is something really strange about the hover state of the buttons - see http://img844.imageshack.us/img844/6169/iq7r.png That's Firefox 22 on Ubuntu Precise. Also, the unit test seems to fail: devlibrary-koha at wingardium-leviosa:/home/liz/koha-src/koha$ prove t/db_dependent/PatronLists.t t/db_dependent/PatronLists.t .. 1/9 DBIx::Class::Carp::__ANON__(): "might_have/has_one" must not be on columns with is_nullable set to true (Koha::Schema::Result::Borrower/cardnumber). This might indicate an incorrect use of those relationship helpers instead of belongs_to. at /usr/share/perl5/DBIx/Class/Relationship/HasOne.pm line 96 t/db_dependent/PatronLists.t .. 5/9 # Failed test 'AddPatronsToList works for cardnumbers' # at t/db_dependent/PatronLists.t line 38. # Looks like you failed 1 test of 9. t/db_dependent/PatronLists.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/9 subtests Test Summary Report ------------------- t/db_dependent/PatronLists.t (Wstat: 256 Tests: 9 Failed: 1) Failed test: 5 Non-zero exit status: 1 Files=1, Tests=9, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.70 cusr 0.04 csys = 0.76 CPU) Result: FAIL Functional tests pass though... and I mean it when I say this is really fantastic. People will throw confetti. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 06:07:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 04:07:22 +0000 Subject: [Koha-bugs] [Bug 10552] Several preferences missing from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10552 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #3 from Liz Rea --- It seems that you have to have both reviewson and showrecentcomments on to see the bit in the bar about that. Just in case that trips anyone else up. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 06:09:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 04:09:57 +0000 Subject: [Koha-bugs] [Bug 10552] Several preferences missing from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10552 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 06:10:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 04:10:00 +0000 Subject: [Koha-bugs] [Bug 10552] Several preferences missing from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10552 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19479|0 |1 is obsolete| | --- Comment #4 from Liz Rea --- Created attachment 19745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19745&action=edit Bug 10552 - Several preferences missing from OPAC login page Several system preference variables are unavailable to the OPAC login template because they are not explicitly enabled for that page. Instead of adding them to Auth.pm using the old method this patch uses the new system preference check syntax using the Koha TT plugin. The following preferences are now checked using this syntax in masthead.inc: OpacAddMastheadLibraryPulldown UseCourseReserves reviewson OpacShowRecentComments In order for the call in masthead.inc to the new plugin to work on all OPAC pages "[% USE Koha %]" must be added to any template which includes it (most of them). Also in this patch: A change to Auth.pm to enable correct display of the LibraryName in the title of the OPAC login page. To test, turn on the above system preferences and confirm that the relevant links appear under the OPAC's main search bar on all pages including the login page. Confirm that the text specified in the LibraryName system preference is shown as the title of the login page. Confirm that course reserves and comments are displayed correctly on the biblio detail page. Signed-off-by: Liz Rea I checked both prog and ccsr - all seems well and the links are appearing and disappearing in accordance with the appropriate sysprefs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 06:21:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 04:21:25 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #15 from Srdjan Jankovic --- I still got the same result after applying 10337 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 06:45:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 04:45:46 +0000 Subject: [Koha-bugs] [Bug 10578] Escaping CGI breaks results sort feature (librarian's interface) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10578 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 06:45:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 04:45:50 +0000 Subject: [Koha-bugs] [Bug 10578] Escaping CGI breaks results sort feature (librarian's interface) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10578 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19581|0 |1 is obsolete| | --- Comment #4 from Srdjan Jankovic --- Created attachment 19746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19746&action=edit [SIGNED-OFF] Bug 10578 - Escaping CGI breaks results sort feature (librarian's interface) To test (in librarian's interface): 1. Have some biblio records to get a list when searching. 2. Make an advanced search with 'as phrase' modifier (title -- ti,phr: or author -- au,phr: , etc.) 3. Having the result list try to change the sort order. 4. You should get no results with a message like: "No results match your search for 'au%2Cphr: " etc. 5. Apply the patch 6. Repeat steps 2. & 3. 7. You should get the list sorted according to your choice. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 06:46:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 04:46:50 +0000 Subject: [Koha-bugs] [Bug 10578] Escaping CGI breaks results sort feature (librarian's interface) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10578 --- Comment #5 from Srdjan Jankovic --- It is. I hate wasted CPU cycles. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 08:28:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 06:28:08 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 08:29:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 06:29:28 +0000 Subject: [Koha-bugs] [Bug 10535] by default sort funds by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #9 from David Cook --- (In reply to Galen Charlton from comment #7) > I've attached a follow-up patch that adds a test case for the change to the > default sort order. I very much prefer that *all* changes to routines in C4 > and Koha be accompanied by test cases. > > Note that in order for this patch to apply cleanly, the patch for bug 10577 > must be applied first. I applied 10577, then 10535, ran the test, and all looked good. Since 10577 has failed QA, what's the proper process now? Wait until 10577 passes QA or is pushed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 08:46:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 06:46:28 +0000 Subject: [Koha-bugs] [Bug 10429] branch filter not working in serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18745|0 |1 is obsolete| | CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- Created attachment 19747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19747&action=edit [SIGNED OFF -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 08:51:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 06:51:36 +0000 Subject: [Koha-bugs] [Bug 10609] New: Use branch name rather than branch code in serials-collection.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609 Bug ID: 10609 Summary: Use branch name rather than branch code in serials-collection.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, the branch code is being used in the DataTables of serials-collection.pl. Bug 10429 fixed this in claims.pl, so I'm sure a similar method could be used to correct that here as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 08:52:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 06:52:27 +0000 Subject: [Koha-bugs] [Bug 10429] branch filter not working in serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19747|0 |1 is obsolete| | --- Comment #3 from David Cook --- Created attachment 19748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19748&action=edit [SIGNED OFF] Bug 10429 - branch filter not working in serial claims Patch works pretty much as described. Makes the branch filter look nicer and uses the branch names rather than codes. It's worth mentioning that the branch code is still used in the DataTables in "serials-collection.pl". I've opened the follow Bug 10609 in regards to that. (P.S. This patch replaces the one I goofed by accidentally hitting Enter. I miss git bz...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 08:52:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 06:52:44 +0000 Subject: [Koha-bugs] [Bug 10429] branch filter not working in serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 08:57:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 06:57:32 +0000 Subject: [Koha-bugs] [Bug 10441] UT: Testing AddShare in VirtualShelves.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 --- Comment #8 from M. de Rooy --- (In reply to Srdjan Jankovic from comment #7) > Just an idea, maybe use SKIP block rather than if(). Thanks for testing, Srdjan. Yes, could have used skip here too. Can imagine cases where skip would really be a better choice. In this case fairly arbitrary.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 09:03:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 07:03:41 +0000 Subject: [Koha-bugs] [Bug 8609] Add an URL validation plugin for authority and biblio frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8609 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- Sounds like a good idea Fr?d?rick! Can you provide a test plan, so I know what to expect before and after for testing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 09:07:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 07:07:44 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 09:09:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 07:09:50 +0000 Subject: [Koha-bugs] [Bug 10553] Public lists not available from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 09:09:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 07:09:52 +0000 Subject: [Koha-bugs] [Bug 10553] Public lists not available from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19743|0 |1 is obsolete| | --- Comment #6 from M. de Rooy --- Created attachment 19749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19749&action=edit Bug 10553 - Public lists not available from OPAC login page If you are not logged in to the OPAC, looking at the login page, and you click the Lists button to see public lists it says there are none. This patch corrects Auth.pm so that it loads the list of public lists in this situation. To test you must have at least one public list. Make sure you are logged out of the OPAC and visit the login page (/cgi-bin/koha/opac-user.pl). Clicking the "Lists" button should show you a list of public shelves. Signed-off-by: Liz Rea works as described, and list button is not shown when opacpublic is disabled. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 09:09:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 07:09:57 +0000 Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #7 from David Cook --- (In reply to Jonathan Druart from comment #6) > Kyle, this patch depends on bug 5336. Tested, it applies correctly. > Switch back to NSO. Do we need to wait for bug 5336 to be pushed before testing/signing off this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 09:10:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 07:10:07 +0000 Subject: [Koha-bugs] [Bug 10553] Public lists not available from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 09:13:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 07:13:59 +0000 Subject: [Koha-bugs] [Bug 10187] precision needed in serials-collection.tt (1/quarter) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #4 from David Cook --- (In reply to M. de Rooy from comment #3) > Would it be more clear to make the scope of this report little bit wider? > > 1/season (spring, summer, etc.) [do not mention quarter anymore] > 1/quarter (three months) [if quarter is harder, we could also eliminate it] > > BTW I am curious: Why not let every 3 months just cover both? > > Extending this report with: > 1/week= weekly > 1/month = monthly > 1/2 weeks is not completely clear (0,5 or 2?): 1/two weeks > idem: 1/three weeks, 1/two three four months, 1/two years > BTW: What do you think of every instead of 1/ > So: every 2 weeks, every 3 months etc. > > each year or annually instead of 1/year > 2/year: every 6 months, semiannual (?) > 2/day= twice a day > > Another step: We could also just say the frequency is two weeks etc. instead > of prefix 75% of the list with 'every'. > So list: daily, 1 week, 2 weeks, 1 month, .., 4 months, 6 months, 1 year, 2 > years > > What do you think? I might be wrong, but I think it might be important to have separate periodicities, as they might be linked to different number patterns/formulas? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 09:19:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 07:19:09 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #9 from David Cook --- (In reply to Jonathan Druart from comment #7) > Created attachment 19643 [details] [review] > Bug 7802: Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by > CAST(now() AS date). > > Signed-off-by: Jonathan Druart Jonathan: Is this still waiting for Sign Off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 09:23:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 07:23:00 +0000 Subject: [Koha-bugs] [Bug 10553] Public lists not available from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from M. de Rooy --- QA Comment: Works as advertised. Small change. Looks good to me. No complaints from koha-qa, no new warnings in log. Redefinition of $pubshelves in checkauth is not on same scope level. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 09:23:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 07:23:30 +0000 Subject: [Koha-bugs] [Bug 10553] Public lists not available from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 09:25:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 07:25:07 +0000 Subject: [Koha-bugs] [Bug 10187] precision needed in serials-collection.tt (1/quarter) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 --- Comment #5 from mathieu saby --- Hello So for the moment, this patch uses the same description for equivalent values in subscription-add.tt and serials-collection.tt. Maybe it could be improved later.... I am not a serials expert, but I think these 2 types of "quarter" periodicity are defined in unimarc and marc21. So we may keep both, even if the difference is not ovbious ;-) Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 09:38:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 07:38:35 +0000 Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 --- Comment #8 from Jonathan Druart --- (In reply to David Cook from comment #7) > (In reply to Jonathan Druart from comment #6) > > Kyle, this patch depends on bug 5336. Tested, it applies correctly. > > Switch back to NSO. > > Do we need to wait for bug 5336 to be pushed before testing/signing off this > one? No, but you must apply patches for bug 5336 before applying this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 09:44:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 07:44:17 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #10 from Jonathan Druart --- (In reply to David Cook from comment #9) > Jonathan: Is this still waiting for Sign Off? David, Yes, the followup needs a signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 09:52:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 07:52:20 +0000 Subject: [Koha-bugs] [Bug 10187] precision needed in serials-collection.tt (1/quarter) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 --- Comment #6 from M. de Rooy --- Interesting point. You mention that there should be two quarterly periodicity definitions in marc. I checked MARC21 853-855 $w in this respect: Values are: a - Annual b - Bimonthly c - Semiweekly d - Daily e - Biweekly f - Semiannual g - Biennial h - Triennial i - Three times a week j - Three times a month k - Continuously updated m - Monthly q - Quarterly s - Semimonthly t - Three times a year w - Weekly x - Completely irregular In this case there is no distinction between season and quarter: both map to q. This would be some kind of argument to use only one 3 months periodicity. But note that we are talking about Koha serial fields here that are not directly related to MARC tags. David refers to the numbering formula. Currently, the code makes frequency jump to Season when choosing Seasonal only as numbering formula. Good to keep in mind indeed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 09:54:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 07:54:14 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #16 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #15) > I still got the same result after applying 10337 the sql file installer/data/mysql/en/optional/patron_categories.sql inserts needed categories (K, J, YA). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 10:11:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 08:11:23 +0000 Subject: [Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #21 from M. de Rooy --- QA: Looking at this one now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 10:11:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 08:11:30 +0000 Subject: [Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 10:30:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 08:30:10 +0000 Subject: [Koha-bugs] [Bug 10411] Add cache control headers to static resources in the apache config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- QA comment: Looks good to me, works as expected. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 10:30:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 08:30:22 +0000 Subject: [Koha-bugs] [Bug 10411] Add cache control headers to static resources in the apache config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19088|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 19750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19750&action=edit Bug 10411: add cache control headers for static resources (Debian package) This adds caching directives to the static resources so that the browser doesn't ask about them all the time. By default, Debian apache doesn't have the required module (mod_expires) enabled, and so this patch will have no effect. In order to enable this function, run: a2enmod expires and restart apache. Test Plan: * Using firebug or equivalent, load a page. * Note that none of the images, css, or js files have a Cache-Control or Expires header set. * Add this patch, redeploy the package with it (or overwrite the apache-share.conf file) enable the 'expires' module, restart apache. * Force-reload the page * Note that the images, css, js now have Cache-Control and Expires set for 12 hours into the future. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 10:35:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 08:35:42 +0000 Subject: [Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #22 from M. de Rooy --- QA Comment: I have two comments. The first having more weight than the second. If I am hiding descriptions, I am not sure what the purpose is of Hide tags in that case. If both tag and description is gone, a user cannot know what he is doing. Note that this is possible too in current master also but only via setting both prefs to disabled (which is less likely). IMO We should not offer to hide both labels; we are only supporting cataloging errors here ;) I suggest to only offer Hide tags if the description is visible. Furtermore, I have some doubts about keeping the pref while adding the checkbox. Maybe we actually want some "staff patron cataloging preference" instead, allowing some users to have the tags and others not.. Setting this report to In Discussion. Hoping for some feedback from all involved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 10:41:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 08:41:04 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 --- Comment #50 from Jonathan Druart --- Kyle, Don't you think it is more consistent to add a new circulation rule instead of create a new syspref (we already have a issuingrules.reservesallowed field)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 10:43:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 08:43:07 +0000 Subject: [Koha-bugs] [Bug 10297] categorycode and branchcode should be required when adding patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10297 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #9 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 10:53:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 08:53:41 +0000 Subject: [Koha-bugs] [Bug 10458] Remove obsolete Z3950 module and test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10458 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #9 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 10:53:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 08:53:46 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18338|0 |1 is obsolete| | Attachment #18339|0 |1 is obsolete| | Attachment #18340|0 |1 is obsolete| | --- Comment #40 from M. de Rooy --- Created attachment 19751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19751&action=edit Bug 7295: More granular permissions for baskets Add branch info to baskets Add a list of borrowers that are allowed to manage a basket (one list for each basket). Add a new subpermission: acquisition => order_manage_all If user is superlibrarian, or if he has permission acquisition = 1 (GranularPermissions = OFF), or subpermission acquisition => order_manage_all (GranularPermissions = ON). He's authorised to manage all baskets. Depending on syspref AcqViewBaskets: 'all': user can manage all baskets 'branch': user can manage baskets of his branch (the basket branch is taken into account, not the branch of the basket's creator). If basket branch is not defined, all user can manage this basket. 'user': user can manage baskets he created, and baskets he's in their user list There are unit tests in t/Acquisition/CanUserManageBasket.t, which require Test::MockModule You can edit basket's branch and users list in basket modification page (acqui/basket.pl) Signed-off-by: Sonia Bouis Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 10:53:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 08:53:51 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 --- Comment #41 from M. de Rooy --- Created attachment 19752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19752&action=edit Bug 7295: Follow-up: Several fixes - List of libraries in basket.pl is now sorted by branch name, not code - When IndependantBranches is ON, user has only the possibility to set basket branch to its own branch, or to no branch at all. - When basket do not belong to any branch, selected branch by default is connection branch (was 'no branch') - added id attributes to both added li elements - change description of 'order_manage_all' permission to make it clearer. - remove Test::MockModule dependency Signed-off-by: Sonia Bouis Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 10:53:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 08:53:55 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 --- Comment #42 from M. de Rooy --- Created attachment 19753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19753&action=edit Bug 7295 [follow-up] More granular permissions for baskets - updatedatabase.pl now fills the new aqbasket.branch with branchcode of basket owner (aqbasket.authorisedby). So the behavior is unchanged if you have set your syspref AcqViewBaskets to 'branch' - If AcqViewBaskets='branch', prevent librarian to add users that are not from the same branch than the basket. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 10:55:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 08:55:50 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #43 from M. de Rooy --- Rebased first patch for trivial updatedatabase conflict. This was already mentioned before (from koha-qa): FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt FAIL forbidden patterns forbidden pattern: simple-quote string (line 138) Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 10:57:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 08:57:19 +0000 Subject: [Koha-bugs] [Bug 10425] Help page missing for Local Use preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10425 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #13 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 10:58:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 08:58:01 +0000 Subject: [Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #23 from Jonathan Druart --- (In reply to M. de Rooy from comment #22) > QA Comment: > I have two comments. The first having more weight than the second. > > If I am hiding descriptions, I am not sure what the purpose is of Hide tags > in that case. If both tag and description is gone, a user cannot know what > he is doing. > Note that this is possible too in current master also but only via setting > both prefs to disabled (which is less likely). > IMO We should not offer to hide both labels; we are only supporting > cataloging errors here ;) > I suggest to only offer Hide tags if the description is visible. I preferred to keep existing choices instead of restricting them. But maybe you are right, it could be improved. > Furtermore, I have some doubts about keeping the pref while adding the > checkbox. Maybe we actually want some "staff patron cataloging preference" > instead, allowing some users to have the tags and others not.. The pref is the default behavior, if we remove it, catalogers will have to check/uncheck the checkbox each time. Currently, Koha does not offer the possibility to have this kind of preference per patron. Waiting for others points of view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 10:59:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 08:59:10 +0000 Subject: [Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #24 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 11:01:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 09:01:00 +0000 Subject: [Koha-bugs] [Bug 10466] Lists: Use "size" as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10466 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #9 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 11:02:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 09:02:07 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #11 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.15 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 11:02:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 09:02:53 +0000 Subject: [Koha-bugs] [Bug 10464] Patron search on placing a hold doesn't use jqueryui.autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #10 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 11:05:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 09:05:21 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19753|0 |1 is obsolete| | --- Comment #44 from Julian Maurice --- Created attachment 19754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19754&action=edit Bug 7295 [follow-up] More granular permissions for baskets Replace simple-quoted string by double-quoted string -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 11:05:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 09:05:40 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 11:13:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 09:13:56 +0000 Subject: [Koha-bugs] [Bug 10439] Cannot modify the notice's library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10439 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #8 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 11:15:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 09:15:10 +0000 Subject: [Koha-bugs] [Bug 9541] Opac-user doesn't load correct CSS for multiple branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9541 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #10 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 11:16:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 09:16:54 +0000 Subject: [Koha-bugs] [Bug 5544] All Notices from Branch Email Address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Jonathan Druart --- (In reply to Katrin Fischer from comment #14) > (In reply to Chris Cormack from comment #12) > > This works as advertised, however, it may introduce a warning in the case > > where $member is not defined. > > Bit worried about this comment - we tend to forget that we have a message > that goes to the library and therefore has no borrowernumber in > message_queue - overdues digest for patrons without email address. I agree with that, the undefined borrowernumber case should be take into account. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 11:17:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 09:17:31 +0000 Subject: [Koha-bugs] [Bug 10379] koha-rebuild-zebra gets noisy if no instances are defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10379 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #10 from Chris Hall --- Pushed to 3.8.x, will be in 3.8.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 11:26:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 09:26:08 +0000 Subject: [Koha-bugs] [Bug 10187] precision needed in serials-collection.tt (1/quarter) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 --- Comment #7 from mathieu saby --- (In reply to M. de Rooy from comment #6) > Interesting point. You mention that there should be two quarterly > periodicity definitions in marc. > I checked MARC21 853-855 $w in this respect: > Values are: > a - Annual > b - Bimonthly > c - Semiweekly > d - Daily > e - Biweekly > f - Semiannual > g - Biennial > h - Triennial > i - Three times a week > j - Three times a month > k - Continuously updated > m - Monthly > q - Quarterly > s - Semimonthly > t - Three times a year > w - Weekly > x - Completely irregular > > In this case there is no distinction between season and quarter: both map to > q. Sorry, you are right, I was wrong for the last point. And this is the same in unimarc I will take a closer look to template files (and help files) and give my analysis later. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 11:26:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 09:26:56 +0000 Subject: [Koha-bugs] [Bug 9730] The sub 'AnonymiseIssueHistory' fails quietly if 'AnonymousPatron' is not a valid entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9730 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Christophe Croullebois --- I don't see comments about the failed QA status ? An error ? So I move in need ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 11:33:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 09:33:55 +0000 Subject: [Koha-bugs] [Bug 9730] The sub 'AnonymiseIssueHistory' fails quietly if 'AnonymousPatron' is not a valid entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9730 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Christophe Croullebois --- oups sry Kyle, hum, you suggest to hide the tab in this case ... Ok I'll do a new patch in this way thx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 11:43:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 09:43:51 +0000 Subject: [Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #24 from M. de Rooy --- (In reply to Jonathan Druart from comment #23) > The pref is the default behavior, if we remove it, catalogers will have to > check/uncheck the checkbox each time. Currently, Koha does not offer the > possibility to have this kind of preference per patron. For completeness: I do not suggest to remove it on its own. I am thinking about having a patron preference controlling it, because it seems that we need something more than current functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 11:45:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 09:45:20 +0000 Subject: [Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #25 from M. de Rooy --- Note that we already have patron messaging preferences. You could easily have patron cataloging preferences too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 12:03:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 10:03:12 +0000 Subject: [Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #9 from M. de Rooy --- Hi Mirko, You seem to mix up 653 [uncontrolled] and 655 [genre] here: @@ -587,6 +587,13 @@ definition file (probably something like {biblio,authority}-koha-indexdefs.xml) + + + + + + + Also a question: You modify both files for DOM. But is that how it should be done? Or is the change you submit a result of generating the other file again with the script? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 12:05:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 10:05:31 +0000 Subject: [Koha-bugs] [Bug 10593] AuthoritiesLog should default to yes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10593 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 12:06:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 10:06:48 +0000 Subject: [Koha-bugs] [Bug 10038] Doubled 'default' entry when creating a new authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10038 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 12:07:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 10:07:56 +0000 Subject: [Koha-bugs] [Bug 9326] New database update system suggests running duplicate updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 12:08:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 10:08:41 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master Assignee|koha-bugs at lists.koha-commun |koha at univ-lyon3.fr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 12:09:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 10:09:14 +0000 Subject: [Koha-bugs] [Bug 9084] Dates in notices should be formatted according to dateformat system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 12:09:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 10:09:48 +0000 Subject: [Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged MARC records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |amit.gupta at osslabs.biz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 12:10:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 10:10:31 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #30 from Jonathan Druart --- QA comment: 1/ The unit tests should be improved: you suppose a borrower exists in the DB (and no borrower is added by sample data). Sql queries should be executed into a transaction. 2/ Step 8: The message concats 2 messages: Restricted: Patron's account is restricted until 04/08/2013 with the comment "im restricted im restricted2" View restrictions message 1 is "im restricted" and message 2 is "im restricted2" 3/ Minor: double quote around sql queries 4/ There is no comment for suspension in the borrower_debarments table. 5/ Why don't you remove the debarred and debarredcomment field in the borrowers table? I will provide a followup for unit tests Marked as Failed QA for 2 and needs clarification for others points. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 12:10:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 10:10:41 +0000 Subject: [Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pelletiermaxime at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 12:11:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 10:11:16 +0000 Subject: [Koha-bugs] [Bug 10538] Improve importation of .CSV framework files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 12:11:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 10:11:39 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 --- Comment #31 from Jonathan Druart --- Created attachment 19755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19755&action=edit Bug 2720: Unit tests improvements Create the patron. Use a transaction. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 12:11:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 10:11:47 +0000 Subject: [Koha-bugs] [Bug 10604] two columns in the courses table aren't wide enough In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10604 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |gmcharlt at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 12:13:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 10:13:21 +0000 Subject: [Koha-bugs] [Bug 10559] noisy statement handle still active warnings when generating notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10559 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |gmcharlt at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 12:13:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 10:13:25 +0000 Subject: [Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #26 from Jonathan Druart --- (In reply to M. de Rooy from comment #25) > Note that we already have patron messaging preferences. You could easily > have patron cataloging preferences too? Yes, but it is completely out of the scope of this bug :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 12:13:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 10:13:46 +0000 Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns' syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 12:25:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 10:25:14 +0000 Subject: [Koha-bugs] [Bug 10211] Remove deprecated Z39.50.pm code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10211 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from M. de Rooy --- *** This bug has been marked as a duplicate of bug 10458 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 12:25:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 10:25:14 +0000 Subject: [Koha-bugs] [Bug 10458] Remove obsolete Z3950 module and test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10458 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #10 from M. de Rooy --- *** Bug 10211 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 13:46:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 11:46:56 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19713|0 |1 is obsolete| | --- Comment #7 from kenza --- Created attachment 19756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19756&action=edit Bug 10528: C4::Booksellers needs unit tests Unit tests are wrap in a database transaction. GetBooksellerWithLateOrders has been modify in order to pass the tests. Now it considers the field $estimateddeliverydateto and it replaces it by now() only if it is undef. More it doesn't test if $aqbookseller.deliverytime is not Null anymore but if $deliverytime = null or undef, it replaces it by 0. It also verifies if $delay is >= 0. ModBookseller has been modify in order to be more explicit: before it always returned undef. Now it returns : 1 -> If a modification has been done 0E0 -> If the given id doesn't exist undef -> If no id given DelBookSeller has been modify in order to be more explicit: Before it returned undef, now it returns $sth->execute($id), so we can verify how many bookSellers have been deleted. Test Plan : prove t/db_dependant/Booksellers.t t/db_dependent/Bookseller.t .. 2/67 [Some warnings about uninitialized values] WARNING: GetBooksellerWithLateOrders is called with a negative value at /home/kenza/workspace/kohaclone/C4/Bookseller.pm line 137. t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=67, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.43 cusr 0.03 csys = 0.49 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 13:52:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 11:52:04 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 13:52:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 11:52:07 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19734|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 19757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19757&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons The patron lists feature is somewhat similar to the record lists feature in that it allows a librarian to create a list of patrons for later retrieval and manipluation. These lists can then be used with the batch patron modification tool. Test Plan: 0) Apply the patch for Bug 8798 1) Apply this patch 2) Run updatedatabase.pl 3) Access the patron lists feature from Koha's Tools menu. 4) Create a new list via the "New patron list" button. 5) For this list, click the "Edit" button, and change the list name. 6) For this list, click the "Add patrons" button, and search for and add some patrons to your list. 7) For this list select some patrons to remove them. 8) Try both adding some new patrons, and removing some old patrons as a single action. 9) Click the "Patrons" link on the Koha toolbar 10) Search the patrons, or browse by letter to get patron results 11) Check the checkboxes next to one or more patrons, and add the selected patrons to your existing list. 12) Change the "Selected patrons" pulldown to "All resultant patrons" and add them to your list. 13) Check the checkboxes next to one or more patrons, and add the selected patrons to a new list. 14) Try manipulating a list of patrons using the batch patron modification tool. 15) Go back to the Patron Lists feature and delete your lists. 16) Run 'prove t/db_dependent/PatronLists.t' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 13:52:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 11:52:18 +0000 Subject: [Koha-bugs] [Bug 10595] OpacTopissue page still accessible when system preference is turned off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m --- Comment #3 from Jonathan Druart --- QA comment: Simple patch, works as expected. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 13:52:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 11:52:34 +0000 Subject: [Koha-bugs] [Bug 10595] OpacTopissue page still accessible when system preference is turned off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19703|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 19758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19758&action=edit Bug 10595 - OpacTopissue page still accessible when system preference is turned off When the syspref is turned off, the link is hidden but the page is still accessible. This patch checks the syspref and redirects to 404 if it is disabled. Test plan: Before applying the patch Enable OpacTopissue Observe there is a link to opac-topissues.pl next to Advanced search etc. Follow that link, observe that opac-topissues.pl is loading Disable OpacTopissue Observe the link is gone Manually open /koha/opac-topissues.pl and check that it is loading even though the feature is disabled Apply patch (OpacTopissue still diabled) Manually open /koha/opac-topissues.pl and observe that you are being redirected to the 404 page. Enable OpacTopissue Follow the link or manuall open opac-topissues.pl and check that it is working Signoff the patch. Signed-off-by: Srdjan Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 13:52:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 11:52:44 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #13 from Kyle M Hall --- Created attachment 19759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19759&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons - Followup - Fix DBIx::Class error Fixes this error: DBIx::Class::Relationship::HasOne::might_have(): "might_have/has_one" must not be on columns with is_nullable set to true (Koha::Schema::Result::Borrower/cardnumber). This might indicate an incorrect use of those relationship helpers instead of belongs_to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 13:53:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 11:53:08 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 --- Comment #8 from kenza --- t/db_dependent/Bookseller.t has been modify. Now, it deletes all the booksellers of the database at the beginning of the transaction in order to be sure the tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 13:56:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 11:56:38 +0000 Subject: [Koha-bugs] [Bug 10597] Search to hold button broken on record details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m --- Comment #3 from Jonathan Druart --- QA comment: Simple patch, works as expected. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 13:56:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 11:56:51 +0000 Subject: [Koha-bugs] [Bug 10597] Search to hold button broken on record details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19702|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 19760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19760&action=edit Bug 10597 - Search to hold button broken on record details The holds button in cat-toolbar is broken for "search to hold". It is a split button rather than a dropdown button. Clicking the caret works fine, but clicked the button sends you to the marc editor! Test Plan: 1) View a patron's details page 2) Click 'search to hold' 3) Search for something 4) On the results page, click a result line's title link ( catalogue/detail.pl ) 5) Note the "Place hold" button is a split button, click the left half of the button, note it redirects you to the editor. 6) Apply this patch 7) Repeat steps 1-5 Signed-off-by: Srdjan Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 14:01:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 12:01:59 +0000 Subject: [Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Owen, I suspect you did not see the difference between these 2 lines: - return _("- Budget total exceeds parent allocation\n"); + return MSG_BUDGET_PARENT_ALLOCATION; } else if (result == '2') { - return _("- Budget total exceeds period allocation\n"); + return MSG_BUDGET_PARENT_ALLOCATION; => parent vs period. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 14:05:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 12:05:47 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19757|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 19761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19761&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons The patron lists feature is somewhat similar to the record lists feature in that it allows a librarian to create a list of patrons for later retrieval and manipluation. These lists can then be used with the batch patron modification tool. Test Plan: 0) Apply the patch for Bug 8798 1) Apply this patch 2) Run updatedatabase.pl 3) Access the patron lists feature from Koha's Tools menu. 4) Create a new list via the "New patron list" button. 5) For this list, click the "Edit" button, and change the list name. 6) For this list, click the "Add patrons" button, and search for and add some patrons to your list. 7) For this list select some patrons to remove them. 8) Try both adding some new patrons, and removing some old patrons as a single action. 9) Click the "Patrons" link on the Koha toolbar 10) Search the patrons, or browse by letter to get patron results 11) Check the checkboxes next to one or more patrons, and add the selected patrons to your existing list. 12) Change the "Selected patrons" pulldown to "All resultant patrons" and add them to your list. 13) Check the checkboxes next to one or more patrons, and add the selected patrons to a new list. 14) Try manipulating a list of patrons using the batch patron modification tool. 15) Go back to the Patron Lists feature and delete your lists. 16) Run 'prove t/db_dependent/PatronLists.t' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 14:05:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 12:05:57 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19759|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 19762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19762&action=edit Bug 10565 - Add a "Patron List" feature for storing and manipulating collections of patrons - Followup - Fix DBIx::Class error Fixes this error: DBIx::Class::Relationship::HasOne::might_have(): "might_have/has_one" must not be on columns with is_nullable set to true (Koha::Schema::Result::Borrower/cardnumber). This might indicate an incorrect use of those relationship helpers instead of belongs_to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 14:10:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 12:10:18 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #16 from Kyle M Hall --- (In reply to Liz Rea from comment #11) > I like this a lot. Like, a LOT. As in, I squeed when I was playing with it. > However, there is something really strange about the hover state of the > buttons - see http://img844.imageshack.us/img844/6169/iq7r.png > > That's Firefox 22 on Ubuntu Precise. It looks like the bootstrap css isn't playing well with Koha's css somewhere. I have it fixed in this new edition of the patch. > > Also, the unit test seems to fail: > > devlibrary-koha at wingardium-leviosa:/home/liz/koha-src/koha$ prove > t/db_dependent/PatronLists.t > t/db_dependent/PatronLists.t .. 1/9 DBIx::Class::Carp::__ANON__(): > "might_have/has_one" must not be on columns with is_nullable set to true > (Koha::Schema::Result::Borrower/cardnumber). This might indicate an > incorrect use of those relationship helpers instead of belongs_to. at > /usr/share/perl5/DBIx/Class/Relationship/HasOne.pm line 96 > t/db_dependent/PatronLists.t .. 5/9 > # Failed test 'AddPatronsToList works for cardnumbers' > # at t/db_dependent/PatronLists.t line 38. > # Looks like you failed 1 test of 9. > t/db_dependent/PatronLists.t .. Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/9 subtests > > Test Summary Report > ------------------- > t/db_dependent/PatronLists.t (Wstat: 256 Tests: 9 Failed: 1) > Failed test: 5 > Non-zero exit status: 1 > Files=1, Tests=9, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.70 cusr 0.04 > csys = 0.76 CPU) > Result: FAIL That's odd, I've run the test with multiple databases without an issue. Please try again with this followup patch. > Functional tests pass though... and I mean it when I say this is really > fantastic. People will throw confetti. Excellent! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 14:10:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 12:10:50 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #17 from Kyle M Hall --- Done! (In reply to Owen Leonard from comment #10) > After you create a new list, it would be nice if it redirected you to the > page for adding patrons to that list. That's how it works with book lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 14:25:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 12:25:58 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #55 from Jonathan Druart --- QA comment: Kyle, could you provide a version of this patch using the branches template plugin? Like that, I think you could delete the sql query in C4::Items::GetItemsInfo. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 14:28:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 12:28:00 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #11 from Jonathan Druart --- Galen, could you give your opinion on this patch please (see comment 9 and comment 10)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 15:47:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 13:47:32 +0000 Subject: [Koha-bugs] [Bug 10610] New: sysprefs.sql is really boring to rebase Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 Bug ID: 10610 Summary: sysprefs.sql is really boring to rebase Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Each time a developer adds a new syspref, he must fill installer/data/mysql/sysprefs.sql. When a patch modifying this file is pushed, the patch does not apply anymore and the developer has to rebase his patch and resubmit it. If this file is sorted by syspref names, conflicts will appear less often. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 15:47:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 13:47:39 +0000 Subject: [Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 15:47:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 13:47:46 +0000 Subject: [Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972 --- Comment #10 from Mirko Tietgen --- Marcel, thanks a lot for spotting the mix-up! You are right of course! I will provide a revised patch. About the DOM files, it was my understanding that they should both be changed to have the indexes as part of the standard setup and in case someone rebuilds the DOM indexes later. I just asked Jared to be on the safe side and the correct way is to change one file, generate the other and have both changes in the patch. http://irc.koha-community.org/koha/2013-07-18#i_1349220 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 15:48:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 13:48:26 +0000 Subject: [Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 15:48:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 13:48:29 +0000 Subject: [Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 --- Comment #1 from Jonathan Druart --- Created attachment 19763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19763&action=edit Bug XXXXX: sysprefs.sql should be sorted by syspref names By sorting the sql syspref file, the developpers will be happy to avoid conflicts on this file each time a patch modifying it is pushed. Test plan: - create a new DB with a new table named systempreferences (with the same structure as the one you know). - insert the current sysprefs.sql file into this table. - note the number of rows in the systempreferences table. - apply this patch. - delete all rows of the systempreferences table. - insert the new sysprefs.sql file. - verify the number of rows is the same as the previous. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 15:48:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 13:48:54 +0000 Subject: [Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19763|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 19764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19764&action=edit Bug 10610: sysprefs.sql should be sorted by syspref names By sorting the sql syspref file, the developpers will be happy to avoid conflicts on this file each time a patch modifying it is pushed. Test plan: - create a new DB with a new table named systempreferences (with the same structure as the one you know). - insert the current sysprefs.sql file into this table. - note the number of rows in the systempreferences table. - apply this patch. - delete all rows of the systempreferences table. - insert the new sysprefs.sql file. - verify the number of rows is the same as the previous. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 15:51:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 13:51:35 +0000 Subject: [Koha-bugs] [Bug 10411] Add cache control headers to static resources in the apache config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Robin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 15:54:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 13:54:04 +0000 Subject: [Koha-bugs] [Bug 10611] New: C4::Context->dbh checks if the DB is still running Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 Bug ID: 10611 Summary: C4::Context->dbh checks if the DB is still running Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Given that mysql is the only DBMS available for Koha, it seems that it is not necessary to do a ping before returning the handler. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 15:54:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 13:54:29 +0000 Subject: [Koha-bugs] [Bug 10595] OpacTopissue page still accessible when system preference is turned off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Mirko! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 15:57:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 13:57:00 +0000 Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 15:57:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 13:57:03 +0000 Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 --- Comment #1 from Jonathan Druart --- Created attachment 19765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19765&action=edit Bug 10611: Use mysql_auto_reconnect instead of ping DBD::Mysql provides a mysql_auto_reconnect flag. Using it avoid to do a ping. Benchmarks: use Modern::Perl; use C4::Context; for ( 1 .. 1000 ) { $dbh = C4::Context->dbh; } * without this patch on a local DB: perl t.pl 0,49s user 0,02s system 98% cpu 0,525 total * without this patch on a remote DB: perl t.pl 0,52s user 0,05s system 1% cpu 37,358 total * with this patch on a local DB: perl t.pl 0,46s user 0,04s system 99% cpu 0,509 total * with this patch on a remote DB: perl t.pl 0,49s user 0,02s system 56% cpu 0,892 total Testing the auto reconnect: use Modern::Perl; use C4::Context; my $ping = $dbh->ping; say $ping; $dbh->disconnect; $ping = $dbh->ping; say $ping; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 15:58:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 13:58:06 +0000 Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 15:59:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 13:59:51 +0000 Subject: [Koha-bugs] [Bug 10612] New: Add ability to delete patrons with batch patron modification tool Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Bug ID: 10612 Summary: Add ability to delete patrons with batch patron modification tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The batch patron deletion/anonymization does not allow for batch deletion of arbitrary lists of patrons. The batch patron modification tool allows for modification of arbitrary lists of patrons, but not deletion. If would be highly beneficial to add patron deletion to the batch patron modification tool. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 16:00:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 14:00:00 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 16:00:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 14:00:21 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10565 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 16:00:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 14:00:21 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10612 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 16:02:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 14:02:41 +0000 Subject: [Koha-bugs] [Bug 10597] Search to hold button broken on record details In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Kyle! I note that there are two other staff templates that contain the text 'place hold for': ./modules/catalogue/results.tt ./modules/virtualshelves/shelves.tt Making a parameterized template to implement the widget would be a Good Thing for consistency's sake. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 16:06:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 14:06:10 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 16:06:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 14:06:12 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #1 from Kyle M Hall --- Created attachment 19766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19766&action=edit Bug 10612 - Add ability to delete patrons with batch patron modification tool The batch patron deletion/anonymization does not allow for batch deletion of arbitrary lists of patrons. The batch patron modification tool allows for modification of arbitrary lists of patrons, but not deletion. If would be highly beneficial to add patron deletion to the batch patron modification tool. Test Plan: 1) Apply all dependencies for this patch 2) Apply this patch 3) Create a list of patrons with the new Patron Lists feature a) Include at least one patron owing fines b) Include at least one patron with items currently checked out c) Include at least one patron not falling into a) or b) 4) Browse to the batch patron modifications tool 5) Select your list from the pulldown, and submit 6) Check the "Delete patrons" checkbox, the click the submit button 7) You should a list of errors for the patrons with fines or issues and a table of patrons that were deleted successfully. 8) Click the link for a deleted patron, you should get a "patron not found" message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 16:10:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 14:10:07 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19766|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 19767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19767&action=edit Bug 10612 - Add ability to delete patrons with batch patron modification tool The batch patron deletion/anonymization does not allow for batch deletion of arbitrary lists of patrons. The batch patron modification tool allows for modification of arbitrary lists of patrons, but not deletion. If would be highly beneficial to add patron deletion to the batch patron modification tool. Test Plan: 1) Apply all dependencies for this patch 2) Apply this patch 3) Create a list of patrons with the new Patron Lists feature a) Include at least one patron owing fines b) Include at least one patron with items currently checked out c) Include at least one patron not falling into a) or b) 4) Browse to the batch patron modifications tool 5) Select your list from the pulldown, and submit 6) Check the "Delete patrons" checkbox, the click the submit button 7) You should a list of errors for the patrons with fines or issues and a table of patrons that were deleted successfully. 8) Click the link for a deleted patron, you should get a "patron not found" message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 16:19:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 14:19:30 +0000 Subject: [Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972 --- Comment #11 from Mirko Tietgen --- Created attachment 19768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19768&action=edit Bug 9972 Follow-up Follow-up to correct the mix-up of 653 and 655 in the DOM configuration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 16:19:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 14:19:41 +0000 Subject: [Koha-bugs] [Bug 10559] noisy statement handle still active warnings when generating notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10559 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- QA comment: This patch removes the warnings. Koha uses many bad uses of $sth->finish(). Maybe it would be great to add a comment for this one. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 16:20:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 14:20:05 +0000 Subject: [Koha-bugs] [Bug 10559] noisy statement handle still active warnings when generating notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10559 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19709|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 19769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19769&action=edit bug 10559: remove spurious "statement handle still active" warnings Generating (e.g.) overdue notices can result in spurious warnings in the cronjob logs: $ ./misc/cronjobs/overdue_notices.pl -t -library CPL prepare_cached(SELECT * FROM issues WHERE itemnumber = ?) statement handle DBI::st=HASH(0x54a7828) still Active at C4/Letters.pm line 589 This patch removes the warning by making sure that the relevant statement handle is finished after fetching its first row of results. To test: [1] Set up an overdue loan such that running overdue_notices.pl will trigger the generation of a notice. [2] Run overdue_notices.pl -t and note the warning message. [3] Apply the patch. [4] Run overdue_notices.pl -t again and note that the warning message is no longer displayed. [5] Check the message_queue table and verify that the overdue notices generated in steps 2 and 4 have the same text. Signed-off-by: Galen Charlton Signed-off-by: Srdjan Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 16:22:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 14:22:25 +0000 Subject: [Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Mirko Tietgen --- I added a follow-up for easier testing. I can squash the patches if that is preferred. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 16:34:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 14:34:00 +0000 Subject: [Koha-bugs] [Bug 10441] UT: Testing AddShare in VirtualShelves.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #9 from Jonathan Druart --- Quick review: Please prefer "is" instead of "ok": ok(1 == $status, "deleted shelf $shelfnumber and its contents"); is( $status, 1, "deleted shelf $shelfnumber and its contents"); and for my $i ( 0 .. 9 ) { instead of for(my $i=0; $i<10;$i++){ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 16:36:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 14:36:32 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #18 from Owen Leonard --- Created attachment 19770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19770&action=edit Bug 10565 [Follow-up] Add a "Patron List" feature for storing and manipulating collections of patrons This patch makes the following changes: On the list add/edit page: - Improvements to breadcrumbs and titles on the add/edit page. - Removal of custom validation JavaScript in favor of built-in validation plugin. On the list view page: - Corrected title on list page: Showing list name instead of "New list" - Added "select all" and "clear all" to a toolbar like on the biblio list page. Moved the "remove selected" button to this toolbar like it is on the biblio list page. - Added more standard DataTables configuration with default sort, correctly ignored columns, and pager count options. - Display patron names as "surname, firstname." - Improve JavaScript for removing entries from the list of patrons to add (to avoid "javascript:" pseudo-protocol). - Move "add patrons" controls so that they are only shown after patrons have been added. - Add toolbar to patron list view page with button for "Edit list" and "Batch modify." The "Batch modify" button takes you directly to a batch modification operation on your list. - Added zipcode to displayed information. - Added message to be displayed when there are no items on the list (instead of showing empty table). On the list of lists page: - Added more standard DataTables configuration with default sort, correctly ignored columns, and pager count options. - Wrapped "new list" button in standard toolbar div. - Show message instead of empty table if there are no lists. - Style in-table buttons with "btn-mini" for more compact look. On scripts: - Changed "authnotrequired" from 1 to 0, added 'borrowers' permission requirement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 16:38:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 14:38:18 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #13 from Owen Leonard --- I got this error after doing a search: overdrive_proxy: Can't call method "set_in_cache" on an undefined value at /home/oleonard/kohaclone/C4/External/OverDrive.pm line 125 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 16:43:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 14:43:11 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19687|0 |1 is obsolete| | --- Comment #16 from kenza --- Created attachment 19771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19771&action=edit Bug 10508 : C4::Branch.pm needs unit tests. Unit tests are wrap in a transaction. NOTE: the field "issuing" isn't used in the database To test: prove t/db_dependent/Branch.t t/db_dependent/Branch.t .. ok All tests successful. Files=1, Tests=31, 0 wallclock secs ( 0.03 usr 0.00 sys + 0.13 cusr 0.00 csys = 0.16 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 16:45:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 14:45:15 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #17 from kenza --- The patch now considers the tests which already exist with the patch 10515. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 16:50:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 14:50:13 +0000 Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 --- Comment #19 from Owen Leonard --- By the way, I removed the Bootstrap styling from the primary submit buttons because I'd rather change that standard interface element in a more deliberate way. I think if we want to start using different styling on submit buttons we should choose a style which is at least somewhat different than toolbar buttons, perhaps a different color of a more subtle style difference. On the other hand, I think Bootstrap's "btn-mini" style is good for controls inside tables, and is something we should start expanding our use of. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 17:17:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 15:17:10 +0000 Subject: [Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 17:29:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 15:29:49 +0000 Subject: [Koha-bugs] [Bug 10559] noisy statement handle still active warnings when generating notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10559 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 17:33:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 15:33:17 +0000 Subject: [Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 17:33:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 15:33:19 +0000 Subject: [Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598 --- Comment #4 from Owen Leonard --- Created attachment 19772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19772&action=edit Bug 7598 [Follow-up] Acquisitions JavaScript contains untranslatable English strings This follow-up addresses QA comments and moves punctuation and line breaks out of the string to be translated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 17:51:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 15:51:10 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19493|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 17:51:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 15:51:28 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #14 from Jesse Weaver --- Created attachment 19773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19773&action=edit Followup for bug 10320: minor bugfixes and style improvements Switch to the new method of showing star ratings. Also, fix some translation bugs, an error that occurred when caching was disabled and add a stub unit test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 18:07:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 16:07:06 +0000 Subject: [Koha-bugs] [Bug 8502] OPAC Borrower Self Registration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8502 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 18:07:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 16:07:59 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 18:10:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 16:10:31 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 18:15:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 16:15:20 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #15 from Owen Leonard --- The first patch has a typical updatedatabase conflict. The second fails with this error: fatal: sha1 information is lacking or useless (C4/External/OverDrive.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Followup for bug 10320: minor bugfixes and style improvements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 18:28:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 16:28:10 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19225|0 |1 is obsolete| | --- Comment #16 from Jesse Weaver --- Created attachment 19774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19774&action=edit Bug 10320 - Integrate OverDrive search into OPAC This show results from the OverDrive ebook/audiobook service in the OPAC. Added the sysprefs and copied the relevant JS to CCSR. Signed-off-by: Srdjan Signed-off-by: Henry Bankhead Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 18:28:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 16:28:21 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19773|0 |1 is obsolete| | --- Comment #17 from Jesse Weaver --- Created attachment 19775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19775&action=edit Followup for bug 10320: minor bugfixes and style improvements Switch to the new method of showing star ratings. Also, fix some translation bugs, an error that occurred when caching was disabled and add a stub unit test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 18:29:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 16:29:40 +0000 Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x or 200$y In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9410|0 |1 is obsolete| | --- Comment #10 from Fridolyn SOMERS --- Created attachment 19776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19776&action=edit Bug 7442 - Crash when selecting an authority with 200$x or 200$y I worked on a way to correct this bug and keeping the " -- " possible in authority summary. I've chosen to use " | " as multiple headings separator. If this must be configurable, I'll do so. See commit message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 18:30:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 16:30:24 +0000 Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x or 200$y In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 --- Comment #11 from Fridolyn SOMERS --- Created attachment 19777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19777&action=edit Bug 7442 - Follow up : Authorities search on all types does not show summary Followup for a small correcting in authorities search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 18:30:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 16:30:49 +0000 Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x or 200$y In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 18:31:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 16:31:12 +0000 Subject: [Koha-bugs] [Bug 10553] Public lists not available from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 18:31:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 16:31:14 +0000 Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x or 200$y In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 18:47:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 16:47:25 +0000 Subject: [Koha-bugs] [Bug 10457] Export selected items data doesn't work when using checkall checkbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10457 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 18:54:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 16:54:14 +0000 Subject: [Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #23 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 20:23:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 18:23:39 +0000 Subject: [Koha-bugs] [Bug 8042] Batch numbers aren't committed as used until an item is added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8042 gabrielle.dusseault at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gabrielle.dusseault at gmail.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 20:25:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 18:25:57 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 gabrielle.dusseault at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger at foundations.ed | |u, | |elibris.helpdesk at gmail.com, | |gabrielle.dusseault at gmail.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 20:29:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 18:29:43 +0000 Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x or 200$y In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19776|0 |1 is obsolete| | --- Comment #12 from Fr?d?ric Demians --- Created attachment 19778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19778&action=edit [SIGNED-OFF] Bug 7442 - Crash when selecting an authority with 200$x or 200$y I can confirm the problem and the solution. I have tested the patch on a large DB with authorities having multiples headings. There is no regression on bug 4838 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 20:30:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 18:30:15 +0000 Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x or 200$y In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19777|0 |1 is obsolete| | --- Comment #13 from Fr?d?ric Demians --- Created attachment 19779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19779&action=edit [SIGNED-OFF] Bug 7442 - Follow up : Authorities search on all types does not show summary -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 20:30:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 18:30:32 +0000 Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x or 200$y In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 20:50:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 18:50:49 +0000 Subject: [Koha-bugs] [Bug 9396] Saved reports listed twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9396 --- Comment #1 from Owen Leonard --- Sorry, it's not the type that causes the problem for me, it's the report_group. Reports which have report_group set appear twice under the "all" tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 21:00:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 19:00:08 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- CC|cnighswonger at foundations.ed | |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 21:02:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 19:02:07 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #1 from Chris Nighswonger --- Removing myself from the CC since I am the default assignee. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 21:30:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 19:30:26 +0000 Subject: [Koha-bugs] [Bug 9396] Saved reports listed twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9396 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Owen Leonard --- It's a data problem on my end. All my "report_group" authorised_values were duplicated in my database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 18 21:33:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 18 Jul 2013 19:33:46 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 02:32:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 00:32:09 +0000 Subject: [Koha-bugs] [Bug 9801] location facet shows even if no locations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9801 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 03:56:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 01:56:28 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 03:56:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 01:56:32 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19688|0 |1 is obsolete| | Attachment #19771|0 |1 is obsolete| | --- Comment #18 from Srdjan Jankovic --- Created attachment 19780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19780&action=edit Bug 10508 : C4::Branch.pm needs unit tests. Unit tests are wrap in a transaction. NOTE: the field "issuing" isn't used in the database To test: prove t/db_dependent/Branch.t t/db_dependent/Branch.t .. ok All tests successful. Files=1, Tests=31, 0 wallclock secs ( 0.03 usr 0.00 sys + 0.13 cusr 0.00 csys = 0.16 CPU) Result: PASS Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 03:58:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 01:58:00 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19780|0 |1 is obsolete| | --- Comment #19 from Srdjan Jankovic --- Created attachment 19781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19781&action=edit [SIGNED-OFF] Bug 10508 : C4::Branch.pm needs unit tests. Unit tests are wrap in a transaction. NOTE: the field "issuing" isn't used in the database To test: prove t/db_dependent/Branch.t t/db_dependent/Branch.t .. ok All tests successful. Files=1, Tests=31, 0 wallclock secs ( 0.03 usr 0.00 sys + 0.13 cusr 0.00 csys = 0.16 CPU) Result: PASS Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 04:55:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 02:55:02 +0000 Subject: [Koha-bugs] [Bug 10311] Holds queue ignores item-level holds where only one items exists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10311 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Liz Rea --- *** Bug 9950 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 04:55:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 02:55:02 +0000 Subject: [Koha-bugs] [Bug 9950] Some holds not showing up in holds queue - even though they are supposed to In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9950 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Liz Rea --- *** This bug has been marked as a duplicate of bug 10311 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 05:34:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 03:34:53 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 05:34:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 03:34:57 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19756|0 |1 is obsolete| | --- Comment #9 from Srdjan Jankovic --- Created attachment 19782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19782&action=edit [SIGNED-OFF] Bug 10528: C4::Booksellers needs unit tests Unit tests are wrap in a database transaction. GetBooksellerWithLateOrders has been modify in order to pass the tests. Now it considers the field $estimateddeliverydateto and it replaces it by now() only if it is undef. More it doesn't test if $aqbookseller.deliverytime is not Null anymore but if $deliverytime = null or undef, it replaces it by 0. It also verifies if $delay is >= 0. ModBookseller has been modify in order to be more explicit: before it always returned undef. Now it returns : 1 -> If a modification has been done 0E0 -> If the given id doesn't exist undef -> If no id given DelBookSeller has been modify in order to be more explicit: Before it returned undef, now it returns $sth->execute($id), so we can verify how many bookSellers have been deleted. Test Plan : prove t/db_dependant/Booksellers.t t/db_dependent/Bookseller.t .. 2/67 [Some warnings about uninitialized values] WARNING: GetBooksellerWithLateOrders is called with a negative value at /home/kenza/workspace/kohaclone/C4/Bookseller.pm line 137. t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=67, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.43 cusr 0.03 csys = 0.49 CPU) Result: PASS Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 05:45:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 03:45:15 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #17 from Srdjan Jankovic --- prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t .. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha`.`borrowers`, CONSTRAINT `borrowers_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) at C4/SQLHelper.pm line 184. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha`.`accountlines`, CONSTRAINT `accountlines_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE) at C4/Accounts.pm line 474. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha`.`accountlines`, CONSTRAINT `accountlines_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE) at C4/Accounts.pm line 474. # Looks like your test exited with 255 before it could output anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 05:57:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 03:57:39 +0000 Subject: [Koha-bugs] [Bug 10511] Odd behavior for messaging preferences with Talking Tech enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10511 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 05:57:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 03:57:42 +0000 Subject: [Koha-bugs] [Bug 10511] Odd behavior for messaging preferences with Talking Tech enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10511 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19252|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 19783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19783&action=edit [SIGNED-OFF] Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled An error in the onclick for phone notices causes the "Do not notify" checkbox to be checked when the phone checkbox is checked. Also, checking "Do not notify" does not uncheck the phone checkbox. Test plan: 1) Enable TalkingTechItivaPhoneNotification 2) Browse to the new patron screen ( memberentry.pl ) 3) In the patron messaging preferences check the Phone checkbox 4) Not the "do not notify" checkbox is then checked 5) Uncheck the "do not notify" checkbox, and check the Email checkbox as well 6) Now check the "do not notify" checkbox, note the Phone checkbox remains checked 7) Apply this patch 8) Repeat steps 3-6, noting the odd behavior is no longer present Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 07:06:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 05:06:19 +0000 Subject: [Koha-bugs] [Bug 10452] AllowHoldsOnDamagedItems should control using damaged items to fulfill holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10452 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 07:06:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 05:06:22 +0000 Subject: [Koha-bugs] [Bug 10452] AllowHoldsOnDamagedItems should control using damaged items to fulfill holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10452 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18899|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 19784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19784&action=edit [SIGNED-OFF] Bug 10452 - AllowHoldsOnDamagedItems should control using damaged items to fulfill holds AllowHoldsOnDamagedItems will stop item-specific holds from being placed on damaged items, but does not stop Koha from using damaged items to fill holds. This seems like incorrect behavior. Test Plan: 1) Set 'AllowHoldsOnDamagedItems' to "Don't Allow" 2) Pick an item, set it to damaged 3) Place a bib-level hold on this item's record 4) Scan the item though the returns system 5) Koha will ask to use this item to fill the hold, click "ignore" 6) Apply this patch 7) Repeat step 4 8) Koha will not ask to use this item to fill the hold Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 09:27:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 07:27:52 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #18 from Jonathan Druart --- The branchcode "CPL" does not exist in your DB (added by installer/data/mysql/en/optional/sample_libraries.sql). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 09:37:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 07:37:55 +0000 Subject: [Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Jonathan Druart --- QA comment: Works as expected, all strings are in the po file. It is a pity not to have js file translatable. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 09:38:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 07:38:22 +0000 Subject: [Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 09:38:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 07:38:16 +0000 Subject: [Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Jonathan Druart --- second patch does not need a signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 09:38:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 07:38:57 +0000 Subject: [Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19686|0 |1 is obsolete| | Attachment #19772|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 19785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19785&action=edit Bug 7598 - Acquisitions JavaScript contains untranslatable English strings English strings in acq.js cannot be processed by the translation script. This patch moves the strings to the templates to be set as JS variables for use by the script. To test: - On the uncertain prices page, enter an invalid price and click save. You should see a JavaScript alert pointing this out. - When adding a fund to an existing budget, enter an amount which exceeds the amount in the parent budget. You should see a JavaScript alert pointing this out. There is a similar function which has been corrected, checkBudgetParent(), but I don't know how to trigger it for testing. The closebasketgroup function has been updated but as far as I can tell it's not actually in use. Signed-off-by: Srdjan Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 09:39:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 07:39:05 +0000 Subject: [Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598 --- Comment #8 from Jonathan Druart --- Created attachment 19786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19786&action=edit Bug 7598 [Follow-up] Acquisitions JavaScript contains untranslatable English strings This follow-up addresses QA comments and moves punctuation and line breaks out of the string to be translated. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 09:52:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 07:52:20 +0000 Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #23 from Srdjan Jankovic --- opendir RECDIR, $recursive_dir is much better written as opendir my $recdir, $recursive_dir That way no close is needed, it closes itself when goes out of scope (globs are passe :) If you choose to stick with globs, I'll sign it off as is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 09:55:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 07:55:16 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 09:55:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 07:55:19 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19557|0 |1 is obsolete| | --- Comment #19 from Srdjan Jankovic --- Created attachment 19787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19787&action=edit [SIGNED-OFF] Bug 10337: Unit tests is based on an existing database This patchs adds a new unit tests file which will launched before all others db_dependent tests. It will drop and recreate the database with sample data. Prerequisite: The database 'koha_ut' have to be created with CREATE DATABASE $dbname CHARACTER SET utf8 COLLATE utf8_bin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 10:06:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 08:06:29 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #20 from Jonathan Druart --- Srdjan, Thanks for signing off this patch! But you did not sent the good one :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 10:21:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 08:21:37 +0000 Subject: [Koha-bugs] [Bug 6965] Tax and dicount rate should be formatted the same In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6965 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Jonathan Druart --- On the current master, I get: Discount: 0.0 % Tax rate: 5.0 % -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 10:23:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 08:23:13 +0000 Subject: [Koha-bugs] [Bug 7495] Tax calculations problem for new orders. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7495 --- Comment #4 from Jonathan Druart --- Fr?d?rick, could you check if the issue still exists on master please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 10:41:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 08:41:20 +0000 Subject: [Koha-bugs] [Bug 2865] Acquisitions: GST not calculating correctly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2865 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #8 from Jonathan Druart --- This issue is certainly fixed by bug 5335. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 10:42:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 08:42:52 +0000 Subject: [Koha-bugs] [Bug 8286] Enhancing tax and shipping calculation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8286 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- Ther is an option now to add a shipping fee on the order receive page and taxes can be modified on order line level. I am closing this bug as we seem to have implemented what is asked for here. If you are still missing functionality, please open a new bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 10:44:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 08:44:52 +0000 Subject: [Koha-bugs] [Bug 6965] Tax and dicount rate should be formatted the same In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6965 --- Comment #3 from Katrin Fischer --- There is another bug about the inconsistency of display for discount rates and tax rates - probably a bigger project: bug 10253, bug 9410 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 11:43:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 09:43:09 +0000 Subject: [Koha-bugs] [Bug 10613] New: Gst is not calculated correctly on the invoice page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Bug ID: 10613 Summary: Gst is not calculated correctly on the invoice page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org The gst used is the gst defined at the supplier level. We should use the gst defined at the order level (if exists). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 11:43:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 09:43:52 +0000 Subject: [Koha-bugs] [Bug 5335] define VAT/taxes at orderline level, with default value for supplier and list of valid tax rates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10613 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 11:43:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 09:43:52 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5335, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5339 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 11:43:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 09:43:52 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10613 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 11:48:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 09:48:24 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 11:48:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 09:48:27 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #1 from Jonathan Druart --- Created attachment 19788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19788&action=edit Bug 10613: The gst rate is not correctly calculated on the invoice page. Test plan: Defined a gst rate on creating an order, receive it and check that all prices are correctly calculated. /!\ Behavior change function of supplier parameters (Include/Don't include tax for list prices and invoice prices) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 12:07:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 10:07:08 +0000 Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|paul.poulain at biblibre.com |jonathan.druart at biblibre.co | |m --- Comment #41 from Jonathan Druart --- QA comment: Looks good to me. minor: - a css class named font-weight-normal is not well chosen. - unit test inserts manually an order instead of calling C4::Acq::AddOrder Inconsistent things still exist on this page but this patch does not introduce regression neither add another inconsistency. I validated this patch with Sonia (from the Koha Team Lyon 3), thanks to her! Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 12:12:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 10:12:00 +0000 Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18021|0 |1 is obsolete| | --- Comment #42 from Jonathan Druart --- Created attachment 19789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19789&action=edit Bug 8037 - Add holds and funds to items already received in parcel.pl Adds a column to indicate holds on recieved items, as well as adding a new column for fund and showing the subtotals per fund above the total subtotal. Signed-off-by: Pierre Angot Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 12:12:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 10:12:07 +0000 Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18022|0 |1 is obsolete| | --- Comment #43 from Jonathan Druart --- Created attachment 19790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19790&action=edit Bug 8037 - Add holds and funds to items already received in parcel.pl - QA Followup Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 12:12:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 10:12:13 +0000 Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19672|0 |1 is obsolete| | --- Comment #44 from Jonathan Druart --- Created attachment 19791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19791&action=edit Bug 8037 - Add holds and funds to items already received in parcel.pl - QA Followup 2 Adds the note "GST exc." for subtotals by fund. Signed-off-by: Pierre Angot Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 12:52:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 10:52:29 +0000 Subject: [Koha-bugs] [Bug 9410] Formatting of the discount field when doing a new order from new empty record is not correct In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 --- Comment #9 from Jonathan Druart --- Created attachment 19792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19792&action=edit Bug 9410: Draft: TT Plugin for formatting prices, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 12:52:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 10:52:48 +0000 Subject: [Koha-bugs] [Bug 9410] Formatting of the discount field when doing a new order from new empty record is not correct In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19792|Bug 9410: Draft: TT Plugin |[ALT] Bug 9410: Draft: TT description|for formatting prices, etc. |Plugin for formatting | |prices, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 12:53:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 10:53:24 +0000 Subject: [Koha-bugs] [Bug 9410] Formatting of the discount field when doing a new order from new empty record is not correct In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 --- Comment #10 from Jonathan Druart --- I think template plugin is much more appropriate in this case. What do you think about this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 13:46:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 11:46:00 +0000 Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #24 from Fridolyn SOMERS --- (In reply to Srdjan Jankovic from comment #23) > opendir RECDIR, $recursive_dir > > is much better written as > > opendir my $recdir, $recursive_dir > Ok, I thought is was not possible. Ok to use vars with those names. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 13:52:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 11:52:28 +0000 Subject: [Koha-bugs] [Bug 10511] Odd behavior for messaging preferences with Talking Tech enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10511 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- QA comment: removeAttr takes only 1 parameter. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 14:53:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 12:53:53 +0000 Subject: [Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 15:11:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 13:11:15 +0000 Subject: [Koha-bugs] [Bug 8821] Receive shipment page should hide inactive funds like new order form does In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 15:11:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 13:11:18 +0000 Subject: [Koha-bugs] [Bug 8821] Receive shipment page should hide inactive funds like new order form does In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821 --- Comment #4 from Owen Leonard --- Created attachment 19793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19793&action=edit Bug 8821 - Receive shipment page should hide inactive funds like new order form This patch adapts the fund-handling code from neworderempty.pl in order to limit the display of funds by default to active ones, with the option to check a box to display all funds. This patch also adds "(inactive)" to the display of funds on this and the neworderempty.tt template because it seemed like that was useful information. To test, make sure you have both active and inactive funds. Start the process of receiving a shipment. The "fund" option in the receive shipment form should show only active funds. Checking the "show all" checkbox should allow you to choose from both active and inactive funds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 15:18:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 13:18:58 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18258|0 |1 is obsolete| | --- Comment #31 from Tom?s Cohen Arazi --- Created attachment 19794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19794&action=edit Bug 8773 - Start per-instance koha-index-daemon in .deb setup Short: Launch a koha-index-daemon (from Koha::Contrib::tamil) process for each enabled instance. Enabling/disabling the use of the indexer is handled using a new(ly introduced) /etc/default/koha-common config file that can be used for other stuff too, and is the Debian way of handling init scripts control variables[1]. Also provide command line tools to manage the running indexer daemons for your instances. Long: Using an indexing daemon avoids launching a new interpreter each time the cron triggers the indexing, and also allows sub-minute incremental reindexing, a requirement from our librarians.[2] Using the indexer daemon should remain "experimental" so is disabled by default. To enable the use of the indexer the user has to tweak the /etc/default/koha-common config file (introduced by this patch). Specifically the USE_INDEXER_DAEMON variable, which is clearly explained in the file. Update frecquency defaults to 30 sec, and can be changed by tweaking the /etc/default/koha-common config file too. This patch relies on Koha::Contrib::Tamil's koha-index-daemon script [3], but could be easily adjusted to use another if we got a new one (SolR?). As Robin proposed it checks for availability of the relevant files before trying to spawn the daemon. If there's something I could change to make this patches better just let me know. Note: there was a problem Robin found regarding the spawned processes forgetting the PERL5LIB and/or KOHA_CONF env variables, this is fixed in this version with the inclusion of the 'export' keyword for the relevant variables. Regards To+ [1] Section 9.3.2 of http://www.debian.org/doc/debian-policy/ch-opersys.html [2] This is the .deb version of http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519 [3] The default cronjob that is set using the debian/koha-common.cron.d file is being disbaled by this patch to avoid collision. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 15:24:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 13:24:12 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 --- Comment #32 from Tom?s Cohen Arazi --- Now we're going live with 3.12 deb packages at UNC, I found a few glitches on the scripts, fixed them. Also unified the scripts into one with action switches after an IRC poll. Thanks Galen and Mark :-D If anyone is willing to give this patches a ride, feel free to contact me. Also, I've set a repository for 3.12 with this patches applied for our internal usage, but it is public, and everything is explained here http://blogs.unc.edu.ar/koha/lang/es/2013/07/18/llega-koha-3-12-a-la-unc-nuestro-propio-repositorio-deb-tambienkoha-3-12-arrives-to-unc-our-own-deb-repo-too/ Thanks for any input on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 16:04:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 14:04:23 +0000 Subject: [Koha-bugs] [Bug 2969] Report Name should be mandatory for saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2969 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 16:04:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 14:04:27 +0000 Subject: [Koha-bugs] [Bug 2969] Report Name should be mandatory for saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2969 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2366|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 19795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19795&action=edit Bug 2969 - Report Name should be mandatory for saved reports This patch re-implements the database changes from the original patch and adds an update for existing reports. It also reimplements the client-side validation using the new built-in validation plugin and adds coverage for SQL reports. I have also added the "required" attribute to the SQL report textarea since saving a report with no SQL triggers an error. To test: - Create a new guided report. Confirm that you cannot save your guided report without a report name. - Create or edit a saved SQL report. Confirm that you cannot save your report without a name or without SQL. - Confirm that the saved_sql table structure has been updated. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 16:13:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 14:13:23 +0000 Subject: [Koha-bugs] [Bug 10576] Untranslatable strings in additem.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10576 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 16:13:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 14:13:25 +0000 Subject: [Koha-bugs] [Bug 10576] Untranslatable strings in additem.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10576 --- Comment #1 from Owen Leonard --- Created attachment 19796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19796&action=edit Bug 10576 - Untranslatable strings in additem.js There are a couple of untranslatable strings in additem.js. This patch moves the strings out of the script and into the include file which has been created for this purpose. To test, apply the patch and test the process for adding an item to an existing or new basket (with AcqCreateItem set to "when placing an order." The add item form should be correctly labeled "Add item." After adding an item, click to edit it again. The form should now be labeled "Update item." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 17:18:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 15:18:58 +0000 Subject: [Koha-bugs] [Bug 10614] New: have add order form at top and bottom Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10614 Bug ID: 10614 Summary: have add order form at top and bottom Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org When in a basket and you're ordering if you have a lot of items you have to scroll to the bottom each time to add more - it would be nice if there were an add option at the top of your list of titles as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 17:19:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 15:19:56 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19787|0 |1 is obsolete| | --- Comment #21 from Srdjan Jankovic --- Created attachment 19797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19797&action=edit [SIGNED-OFF] Bug 10481: Unit tests for C4::Members::AddEnrolmentFeeIfNeeded prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t .. ok All tests successful. Files=1, Tests=3, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.38 cusr 0.01 csys = 0.41 CPU) Result: PASS Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 17:20:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 15:20:46 +0000 Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #22 from Srdjan Jankovic --- Oh what a mess... Terribly sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 17:23:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 15:23:07 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19794|0 |1 is obsolete| | --- Comment #33 from Tom?s Cohen Arazi --- Created attachment 19798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19798&action=edit Bug 8773 - Start per-instance koha-index-daemon in .deb setup Short: Launch a koha-index-daemon (from Koha::Contrib::tamil) process for each enabled instance. Enabling/disabling the use of the indexer is handled using a new(ly introduced) /etc/default/koha-common config file that can be used for other stuff too, and is the Debian way of handling init scripts control variables. Also provide command line tools to manage the running indexer daemons for your instances. Edit: fixed koha-create to call the koha-indexer script instead, and added -q to make koha-inxeder quiet (useful for the init script). Regards To+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 17:28:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 15:28:29 +0000 Subject: [Koha-bugs] [Bug 10615] New: Move saved reports action items into dropdown menu Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10615 Bug ID: 10615 Summary: Move saved reports action items into dropdown menu Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/reports/guided_reports.pl?phase=Use saved OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Reports Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Created attachment 19799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19799&action=edit Proposed menu on saved reports page The table of saved reports has five or six "actions" which can be performed on each report. These links are jammed together in two columns at the right of the table, often forcing the user to scroll to reach the links. I propose to move all these links into a dropdown menu triggered by clicking on the report name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 17:32:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 15:32:23 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19798|0 |1 is obsolete| | --- Comment #34 from Tom?s Cohen Arazi --- Created attachment 19800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19800&action=edit Bug 8773 - Start per-instance koha-index-daemon in .deb setup Short: Launch a koha-index-daemon (from Koha::Contrib::tamil) process for each enabled instance. Enabling/disabling the use of the indexer is handled using a new(ly introduced) /etc/default/koha-common config file that can be used for other stuff too, and is the Debian way of handling init scripts control variables[1]. Also provide command line tools to manage the running indexer daemons for your instances. Long: Using an indexing daemon avoids launching a new interpreter each time the cron triggers the indexing, and also allows sub-minute incremental reindexing, a requirement from our librarians.[2] Using the indexer daemon should remain "experimental" so is disabled by default. To enable the use of the indexer the user has to tweak the /etc/default/koha-common config file (introduced by this patch). Specifically the USE_INDEXER_DAEMON variable, which is clearly explained in the file. Update frecquency defaults to 30 sec, and can be changed by tweaking the /etc/default/koha-common config file too. This patch relies on Koha::Contrib::Tamil's koha-index-daemon script [3], but could be easily adjusted to use another if we got a new one (SolR?). As Robin proposed it checks for availability of the relevant files before trying to spawn the daemon. If there's something I could change to make this patches better just let me know. Note: there was a problem Robin found regarding the spawned processes forgetting the PERL5LIB and/or KOHA_CONF env variables, this is fixed in this version with the inclusion of the 'export' keyword for the relevant variables. Edit: fixed koha-create to call the koha-indexer script instead, and added -q to make koha-inxeder quiet (useful for the init script). Regards To+ [1] Section 9.3.2 of http://www.debian.org/doc/debian-policy/ch-opersys.html [2] This is the .deb version of http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519 [3] The default cronjob that is set using the debian/koha-common.cron.d file is being disbaled by this patch to avoid collision. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 17:37:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 15:37:22 +0000 Subject: [Koha-bugs] [Bug 10615] Move saved reports action items into dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10615 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 17:37:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 15:37:26 +0000 Subject: [Koha-bugs] [Bug 10615] Move saved reports action items into dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10615 --- Comment #1 from Owen Leonard --- Created attachment 19801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19801&action=edit Bug 10615 - Move saved reports action items into dropdown menu This patch moves saved reports "action" links (view, edit, run, etc) into a dropdown menu triggered by clicking the name of the report. To test you must have saved reports. View the saved reports page and click the name of a saved report. This should trigger a menu. All options in the menu should work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 18:28:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 16:28:07 +0000 Subject: [Koha-bugs] [Bug 10586] Printing cart from Firefox seems to be missing CSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10586 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 18:28:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 16:28:10 +0000 Subject: [Koha-bugs] [Bug 10586] Printing cart from Firefox seems to be missing CSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10586 --- Comment #1 from Owen Leonard --- Created attachment 19802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19802&action=edit Bug 10586 - Printing cart from Firefox seems to be missing CSS When printing the Cart from Firefox the styling is off even though it looks correct in preview. I think this may be because the preview is including stylesheets designated for screen. This patch removes special handling of JS and CSS assets for the Cart's print view, letting the page handle print styling like other pages in the OPAC. To test, put items in your Cart in the OPAC. Open your Cart and click the "print" link. Your printout should be correctly styled and match the preview. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 18:44:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 16:44:49 +0000 Subject: [Koha-bugs] [Bug 10609] Use branch name rather than branch code in serials-collection.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 18:44:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 16:44:53 +0000 Subject: [Koha-bugs] [Bug 10609] Use branch name rather than branch code in serials-collection.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609 --- Comment #1 from Owen Leonard --- Created attachment 19803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19803&action=edit Bug 10609 - Use branch name rather than branch code in serials-collection.pl The serials collection page displays branchcode instead of library name. This patch uses the Branches template plugin to display the library name instead. Also corrected: Added missing datatables config include to prevent a JavaScript error. To test, view the serials collection page for a subsciption with existing issues. Library names should be displayed instead of branchcodes. There should be no JavaScript errors reported by the browser. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 19:13:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 17:13:10 +0000 Subject: [Koha-bugs] [Bug 10616] New: hold warning needs design work Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10616 Bug ID: 10616 Summary: hold warning needs design work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 19804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19804&action=edit holds warning The attached image is confusing. The radio buttons only apply if you click the 'yes' button. But if you click the 'no' button the radio buttons are ignored. The functionality is good! But it's confusing to the user because it makes it look like the radio buttons apply no matter what button you choose and both buttons end up messing with the hold so users don't want to choose anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 19:52:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 17:52:59 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19800|0 |1 is obsolete| | --- Comment #35 from Tom?s Cohen Arazi --- Created attachment 19805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19805&action=edit Bug 8773 - Start per-instance koha-index-daemon in .deb setup Short: Launch a koha-index-daemon (from Koha::Contrib::tamil) process for each enabled instance. Enabling/disabling the use of the indexer is handled using a new(ly introduced) /etc/default/koha-common config file that can be used for other stuff too, and is the Debian way of handling init scripts control variables[1]. Also provide command line tools to manage the running indexer daemons for your instances. Edit: fixed koha-create to call the koha-indexer script instead, and added -q to make koha-inxeder quiet (useful for the init script). Added references to /etc/default/koha-common at koha-create to test for the indexer daemon configuration. Regards To+ [1] Section 9.3.2 of http://www.debian.org/doc/debian-policy/ch-opersys.html [2] This is the .deb version of http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519 [3] The default cronjob that is set using the debian/koha-common.cron.d file is being disbaled by this patch to avoid collision. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 21:36:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 19:36:41 +0000 Subject: [Koha-bugs] [Bug 8694] Show accurate subscription renewal warning for expired subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8694 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 21:36:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 19:36:52 +0000 Subject: [Koha-bugs] [Bug 8694] Show accurate subscription renewal warning for expired subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8694 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11871|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 21:37:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 19:37:03 +0000 Subject: [Koha-bugs] [Bug 8694] Show accurate subscription renewal warning for expired subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8694 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11907|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 21:37:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 19:37:18 +0000 Subject: [Koha-bugs] [Bug 8694] Show accurate subscription renewal warning for expired subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8694 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 21:50:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 19:50:06 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to selelct multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 21:50:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 19:50:10 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to selelct multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 --- Comment #7 from Owen Leonard --- Created attachment 19806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19806&action=edit Bug 3134 - Ability to selelct multiple reports to delete at once This patch adds the option to select multiple saved reports for deletion. To test you must have two or more saved reports to delete. Deletion should work properly when: - Selecting one report for deletion by checking the box. - Selecting more than one report for deletion by checking boxes. - Clicking the old "Delete" link Clicking the delete button should prompt you to confirm. Clicking cancel should cancel. Clicking the delete button when no boxes are checked should trigger an alert asking you to select reports for deletion. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 22:14:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 20:14:52 +0000 Subject: [Koha-bugs] [Bug 10516] Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 22:14:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 20:14:54 +0000 Subject: [Koha-bugs] [Bug 10516] Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 --- Comment #1 from Owen Leonard --- Created attachment 19807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19807&action=edit Bug 10516 - Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates The template for adding/editing Z39.50 servers shows the same title, breadcrumbs, etc. for add and edit operations. This patch creates separate text for each case. To test, try both adding and editing a Z39.50 server. The page title, breadcrumb, and heading should correctly reflect the operation you perform. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 22:36:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 20:36:45 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19233|0 |1 is obsolete| | --- Comment #12 from Jared Camins-Esakov --- Created attachment 19808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19808&action=edit Bug 10402: Use an object for contacts In preparation for adding the ability to handle multiple contacts, this patch moves booksellers' contacts into their own class, C4::Bookseller::Contact. To test: 1) Apply patch. 2) Run database update. 3) Edit a bookseller, making sure to add a contact. 4) View the bookseller's information, making sure the contact information is there. 5) Run the unit test: > prove t/db_dependent/Bookseller.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 22:36:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 20:36:56 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19603|0 |1 is obsolete| | --- Comment #13 from Jared Camins-Esakov --- Created attachment 19809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19809&action=edit Bug 10402: Move contacts to separate table This patch normalizes the data structures used for bookseller contacts. To test: 1) Repeat tests described on previous patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 22:37:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 20:37:12 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 22:37:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 20:37:14 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19604|0 |1 is obsolete| | --- Comment #14 from Jared Camins-Esakov --- Created attachment 19810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19810&action=edit Bug 10402: Add ability to enter multiple contacts Some vendors may have more than one contact. For example, a technical contact and a billing contact, or a contact for journals and a contact for monographs. Rather than require that each contact be either made into a separate vendor or recorded somewhere outside of Koha, it would be really useful of Koha had the ability to add multiple additional contacts to vendors in the Acquisitions module. To test: 1) Apply patch. 2) Edit a bookseller, making sure to add a contact. 3) View the bookseller's information, making sure the contact information is there. 4) Run the unit test: > prove t/db_dependent/Bookseller.t 5) Add multiple contacts to a vendor, see that they show up. 6) Delete one contact from a vendor with multiple contacts, see that the result is correct. 7) Sign off. Note: This test plan can supersede that on the previous two patches, as all functionality of the previous two patches is required by this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 22:53:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 20:53:43 +0000 Subject: [Koha-bugs] [Bug 10617] New: Init script cleanup Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10617 Bug ID: 10617 Summary: Init script cleanup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz The debian/koha-common.init file needs some cleanup. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 22:59:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 20:59:37 +0000 Subject: [Koha-bugs] [Bug 10617] Init script cleanup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10617 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 22:59:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 20:59:41 +0000 Subject: [Koha-bugs] [Bug 10617] Init script cleanup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10617 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 19811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19811&action=edit Bug 10617 - koha-common tnit script cleanup Removed unused stuff, added a new config file /etc/default/koha-common to control the init script behaviour. Currently is only a stub. The config file could be put on /etc/sysconfig on RedHat and friends. The init script should work them too. To test: - Apply the patch on master, build your own packages and install. - The init script should continue to work as expected. (it can be tested replacing the /etc/init.d/koha-common file with debian/koha-common.init on a packages install). - The absence of the /etc/default/koha-common file should not prevent the init script from working. Regards To+ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 23:19:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 21:19:44 +0000 Subject: [Koha-bugs] [Bug 10516] Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 23:19:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 21:19:47 +0000 Subject: [Koha-bugs] [Bug 10516] Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19807|0 |1 is obsolete| | --- Comment #2 from Liz Rea --- Created attachment 19812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19812&action=edit Bug 10516 - Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates The template for adding/editing Z39.50 servers shows the same title, breadcrumbs, etc. for add and edit operations. This patch creates separate text for each case. To test, try both adding and editing a Z39.50 server. The page title, breadcrumb, and heading should correctly reflect the operation you perform. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 23:22:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 21:22:28 +0000 Subject: [Koha-bugs] [Bug 10616] hold warning needs design work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10616 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #1 from Liz Rea --- How do you think this should work instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 19 23:56:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 21:56:38 +0000 Subject: [Koha-bugs] [Bug 10615] Move saved reports action items into dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10615 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |liz at catalyst.net.nz --- Comment #2 from Liz Rea --- Hi Owen, I like where your head is at here, but I think the actions might be a bit too hidden for my taste. A compromise might be a column with the dropdown in it, with table header "actions?" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 00:09:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 22:09:32 +0000 Subject: [Koha-bugs] [Bug 10586] Printing cart from Firefox seems to be missing CSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10586 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 00:09:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 22:09:36 +0000 Subject: [Koha-bugs] [Bug 10586] Printing cart from Firefox seems to be missing CSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10586 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19802|0 |1 is obsolete| | --- Comment #2 from Liz Rea --- Created attachment 19813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19813&action=edit Bug 10586 - Printing cart from Firefox seems to be missing CSS When printing the Cart from Firefox the styling is off even though it looks correct in preview. I think this may be because the preview is including stylesheets designated for screen. This patch removes special handling of JS and CSS assets for the Cart's print view, letting the page handle print styling like other pages in the OPAC. To test, put items in your Cart in the OPAC. Open your Cart and click the "print" link. Your printout should be correctly styled and match the preview. Signed-off-by: Liz Rea Tested both fail condition and condition with patch - display is much improved. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 00:26:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 22:26:24 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #68 from Katrin Fischer --- Hi Kyle - there are some conflicts, can you please rebase and answer Jonathan's question? I wonder if we should offer an option to show only the items of one selected branch in the list of items? But couldn't take a look at how this effects the display of items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 01:02:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 23:02:27 +0000 Subject: [Koha-bugs] [Bug 2969] Report Name should be mandatory for saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2969 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 01:02:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 23:02:32 +0000 Subject: [Koha-bugs] [Bug 2969] Report Name should be mandatory for saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2969 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19795|0 |1 is obsolete| | --- Comment #4 from Liz Rea --- Created attachment 19814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19814&action=edit Bug 2969 - Report Name should be mandatory for saved reports This patch re-implements the database changes from the original patch and adds an update for existing reports. It also reimplements the client-side validation using the new built-in validation plugin and adds coverage for SQL reports. I have also added the "required" attribute to the SQL report textarea since saving a report with no SQL triggers an error. To test: - Create a new guided report. Confirm that you cannot save your guided report without a report name. - Create or edit a saved SQL report. Confirm that you cannot save your report without a name or without SQL. - Confirm that the saved_sql table structure has been updated. Signed-off-by: Liz Rea Functional tests pass, database tables look correct to me. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 01:04:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 23:04:13 +0000 Subject: [Koha-bugs] [Bug 10615] Move saved reports action items into dropdown menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10615 --- Comment #3 from Liz Rea --- Probably towards the end of the table where the links used to be, would be my preference I think. I found it a bit disorienting to find them the first time I used it, I can imagine a lot of librarians would find it to be so too. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 01:07:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 19 Jul 2013 23:07:08 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 05:45:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 03:45:05 +0000 Subject: [Koha-bugs] [Bug 10592] Apache configuration is blocking fetch of certain icons and XML files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10592 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 05:45:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 03:45:11 +0000 Subject: [Koha-bugs] [Bug 10592] Apache configuration is blocking fetch of certain icons and XML files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10592 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19676|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 19815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19815&action=edit bug 10592: fix MARC21 006/008 cataloging plugins Move the XML and XSD data files so that access to them (particularly the XML files) is not blocked by the Apache configuration change introduced by the patch for bug 9812. To test, after applying the patch. [1] Open a MARC21 bibliographic record in the cataloging editor. [2] Click on the plugin link for the 008 field. Verify that that the form for all of the fixed field positions is displayed, and verify that you can change the type of material. [3] Repeat step 2 for the 006 field. [4] Verify that there are no entries in the Apache error log that contain client denied by server configuration: {...}/cataloguing/value_builder/marc21_field_008.xml or client denied by server configuration: {...}/cataloguing/value_builder/marc21_field_006.xml Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 05:45:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 03:45:26 +0000 Subject: [Koha-bugs] [Bug 10592] Apache configuration is blocking fetch of certain icons and XML files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10592 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19677|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 19816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19816&action=edit bug 10592: fix display of favicon Move the favicon files for OPAC and staff so that they are not blocked by the Apache configuration change introduced by the patch for bug 9812. Note that this patch makes the favicon customizable by theme, not both theme and language. To test, after applying the patch. [1] Open pages in the OPAC and staff client. Verify that the favicon is displayed in the usual place in your web browser. Specific pages to test include - circulation receipts and slips - help - lists view - web-based self-checkout [2] Verify that the Apache logs do not contain entries like this: client denied by server configuration: {...}/prog/en/includes/favicon.ico Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 05:47:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 03:47:44 +0000 Subject: [Koha-bugs] [Bug 10604] two columns in the courses table aren't wide enough In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10604 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 05:47:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 03:47:49 +0000 Subject: [Koha-bugs] [Bug 10604] two columns in the courses table aren't wide enough In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10604 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19729|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 19817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19817&action=edit Bug 10604: increase width of two columns in the courses table The department and term columns in the courses table started as varchar(20), but since they refer to authorized values, need to be varchar(80) to match authorised_values.authorised_value. This patch increases the width of those columns. To test: [1] Create two DEPARTMENT authorised values, one whose code is shorter than 20 characters and one whose code is longer than 20 characters. [2] Create two courses; give one course the short department and the other the long department. [3] Go to the courses list. Observe that the department column is displays the department name only for the short course. [4] Apply the patch. [5] Edit the course with the long department and assign that long department to it again. [6] Go back to the courses list. Observe that both of the courses now display their assigned department. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 05:50:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 03:50:39 +0000 Subject: [Koha-bugs] [Bug 10576] Untranslatable strings in additem.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10576 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 05:50:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 03:50:43 +0000 Subject: [Koha-bugs] [Bug 10576] Untranslatable strings in additem.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10576 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19796|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 19818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19818&action=edit Bug 10576 - Untranslatable strings in additem.js There are a couple of untranslatable strings in additem.js. This patch moves the strings out of the script and into the include file which has been created for this purpose. To test, apply the patch and test the process for adding an item to an existing or new basket (with AcqCreateItem set to "when placing an order." The add item form should be correctly labeled "Add item." After adding an item, click to edit it again. The form should now be labeled "Update item." Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 19:54:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 17:54:17 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #49 from Katrin Fischer --- Created attachment 19819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19819&action=edit Bug 7298: Follow-up fixing capitalization and moving supplier id Fixes a few capitalization errors on the late orders page like - Claim orders - filter - Search results Also moves the supplierid from the order date column to the vendor column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 19:57:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 17:57:34 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #50 from Katrin Fischer --- Hi Jonathan, I have tested this and it works fine. I have fixed some things in a follow up patch, but I think I can't pass this as it is. The CSV has lots of untranslatable strings while it seems we have found some solution for that problem for the CSV export of baskets and basket groups. Could you take a look there if if this can be adapted? Also I think it would be nicer to have the author and publisher in separate columns in the CSV, which would also remove some more translation problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 20:02:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 18:02:54 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #51 from Katrin Fischer --- There is also a bug in how the checkboxed get blocked so you can only select titles from one vendor. I have more than 10 late orders, when I load the late orders page, the checkboxes don't lock. When I change the number of late orders shown in the table, it starts to work - hope you can reproduce this. Also the late order emails are broken... filing a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 20:12:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 18:12:41 +0000 Subject: [Koha-bugs] [Bug 10618] New: Acq claim email not formatting correctly and missing information Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10618 Bug ID: 10618 Summary: Acq claim email not formatting correctly and missing information Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The sample notice for Acquisition claims looks like this: Ordernumber <> (<>) (<> ordered) ($<> each) has not been received. But this will give you the following output in an email: Ordernumber 928 (Learning Perl (1 ordered) ($EUR each) has not been received. Ordernumber 1690 (FIZ Technik) (1 ordered) ($EUR each) has not been received. The listprice is missing and the tags are printed into the email. lisprice was empty in the database for ordernumber 928, but 10.00 for 1690. Note: The notice still works when you remove the from the template. Tested with text emails, not HTML. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 20:13:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 18:13:58 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10618 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 20:13:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 18:13:58 +0000 Subject: [Koha-bugs] [Bug 10618] Acq claim email not formatting correctly and missing information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10618 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7298 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 20:19:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 18:19:32 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #19 from Mirko Tietgen --- Created attachment 19820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19820&action=edit Bug 8897 [ENH] GPG Mail encryption -- New version Koha should offer patrons the option to receive their emails encrypted. This patch adds a dialog to the user interface (OPAC side) for patrons to add or delete a GPG public key. The key is directly added to or deleted from gpg (gnupg needs to be installed, binary expected at /usr/bin/gpg). This feature does not require sysadmins/librarians to do anything as long as the gpg binary if found. So far, mails are encrypted if a key for the recipient is avaliable - when sending lists or carts (encryption of email text + attachment) - when mails are sent through the message queue - ? Missing so far: - hide public key interface from OPAC/userdetails when no binary is found - de-hardcode path to gpg (syspref) - deal with BCC mails (send message explaining that an encrypted email has been send to the patron instead of a BCC) - ? Maybe later: - library-side key management: secret key for signing - encryption of emails from library to vendors - ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 20:20:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 18:20:09 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 20:20:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 18:20:11 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13954|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 20:20:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 18:20:15 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 22:00:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 20:00:55 +0000 Subject: [Koha-bugs] [Bug 10573] French translation for printing a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #5 from mathieu saby --- Hello Could you take a look at this patch I made some months ago? I think it is related : http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10135 It is not good, according to Jonathan, but maybe the idea could be improved. My idea was to give the ability to each Library to define its own Template (we did it in Rennes 2, but we had to alter the perl code because currently only the 2 values "pdf2pages" and "pdf3pages" are accepted"). I probably tried to make up a too complex solution. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 23:25:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 21:25:25 +0000 Subject: [Koha-bugs] [Bug 2969] Report Name should be mandatory for saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2969 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 23:25:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 21:25:28 +0000 Subject: [Koha-bugs] [Bug 2969] Report Name should be mandatory for saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2969 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19814|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 19821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19821&action=edit Bug 2969 - Report Name should be mandatory for saved reports This patch re-implements the database changes from the original patch and adds an update for existing reports. It also reimplements the client-side validation using the new built-in validation plugin and adds coverage for SQL reports. I have also added the "required" attribute to the SQL report textarea since saving a report with no SQL triggers an error. To test: - Create a new guided report. Confirm that you cannot save your guided report without a report name. - Create or edit a saved SQL report. Confirm that you cannot save your report without a name or without SQL. - Confirm that the saved_sql table structure has been updated. Signed-off-by: Liz Rea Functional tests pass, database tables look correct to me. Signed-off-by: Chris Cormack Even with JS disabled, the form can not be submitted without the report name filled in. However we are not checking this server side .. if this was the public interface that would be a fail. I will leave this up to the RM to decided if client side checks are ok for this. Bearing in mind we weren't handling any sql errors properly server side before this. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 23:30:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 21:30:18 +0000 Subject: [Koha-bugs] [Bug 10586] Printing cart from Firefox seems to be missing CSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10586 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 23:30:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 21:30:21 +0000 Subject: [Koha-bugs] [Bug 10586] Printing cart from Firefox seems to be missing CSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10586 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19813|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 19822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19822&action=edit Bug 10586 - Printing cart from Firefox seems to be missing CSS When printing the Cart from Firefox the styling is off even though it looks correct in preview. I think this may be because the preview is including stylesheets designated for screen. This patch removes special handling of JS and CSS assets for the Cart's print view, letting the page handle print styling like other pages in the OPAC. To test, put items in your Cart in the OPAC. Open your Cart and click the "print" link. Your printout should be correctly styled and match the preview. Signed-off-by: Liz Rea Tested both fail condition and condition with patch - display is much improved. Thanks, Owen! Signed-off-by: Chris Cormack Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 23:32:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 21:32:58 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19820|0 |1 is obsolete| | --- Comment #20 from Mirko Tietgen --- Created attachment 19823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19823&action=edit Bug 8897 [ENH] GPG Mail encryption -- New version Koha should offer patrons the option to receive their emails encrypted. This patch adds a dialog to the user interface (OPAC side) for patrons to add or delete a GPG public key. The key is directly added to or deleted from gpg (gnupg needs to be installed, binary expected at /usr/bin/gpg). This feature does not require sysadmins/librarians to do anything as long as the gpg binary if found. So far, mails are encrypted if a key for the recipient is avaliable - when sending lists or carts (encryption of email text + attachment) - when mails are sent through the message queue - ? Missing so far: - hide public key interface from OPAC/userdetails when no binary is found - de-hardcode path to gpg (syspref) - deal with BCC mails (send message explaining that an encrypted email has been send to the patron instead of a BCC) - ? Maybe later: - library-side key management: secret key for signing - encryption of emails from library to vendors - ? Bug 8897 [ENH] Follow-up: missing files I missed to add the opac-gnupg.pl and .tt files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 23:33:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 21:33:20 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19823|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 20 23:41:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 20 Jul 2013 21:41:49 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19823|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 10:27:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 08:27:35 +0000 Subject: [Koha-bugs] [Bug 7308] new column in admin/aqbudgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 --- Comment #21 from Katrin Fischer --- Created attachment 19824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19824&action=edit [PASSED QA] Bug 7308: Show ordered amount in aqbudgets.pl Signed-off-by: C?dric Vita Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 10:27:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 08:27:46 +0000 Subject: [Koha-bugs] [Bug 7308] new column in admin/aqbudgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 --- Comment #22 from Katrin Fischer --- Created attachment 19825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19825&action=edit [PASSED QA] Bug 7308: rework aqbudgets.pl table admin/aqbudgets.pl should have the following columns: Base-level allocated (or just Allocated) Base-level ordered Total sub-levels ordered Base-level spent Total sub-levels spent Base-level available Total sub-levels available Base-level is always calculated for one level, without children. Total sub-levels should include child funds. Available is calculated as "allocated - (ordered + spent)". Signed-off-by: Cedric Vita Signed-off-by: Katrin Fischer Seems to work alright for me. Passes QA script and tests, after I fixed 2 tabs in admin/aqbudgets.pl. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 10:28:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 08:28:11 +0000 Subject: [Koha-bugs] [Bug 7308] new column in admin/aqbudgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 10:28:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 08:28:15 +0000 Subject: [Koha-bugs] [Bug 7308] new column in admin/aqbudgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16394|0 |1 is obsolete| | Attachment #16395|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer --- Created attachment 19826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19826&action=edit Bug 7308 - Follow up: removing line breaks for better translatability Because of the lines breaks in the table headings the strings were separated in translation. Example: Base-level allocated - Base-level - allocated If you look at a smaller screen the table headings will still break without the additional
    . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 10:54:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 08:54:04 +0000 Subject: [Koha-bugs] [Bug 8911] docs/history.txt file missing for about.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 10:54:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 08:54:07 +0000 Subject: [Koha-bugs] [Bug 8911] docs/history.txt file missing for about.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19452|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 19827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19827&action=edit [PASSED QA] Bug 8911 - history.txt file missing for about.pl This patch makes Makefile.PL put the history.txt file in the right places depending on the chosen setup layout, adds a reference to that place in koha-conf.xml (and debian template version), and finally tweaks about.pl to use it. To test, apply the patch and verify that perl Makefile.PL runs fine, and installing in - dev - single - standard layouts works as expected. Then go to the about.pl page and see if Koha's history shows there. Then, build your packages and test on your newly created instances. Regards To+ Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 11:02:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 09:02:04 +0000 Subject: [Koha-bugs] [Bug 10604] two columns in the courses table aren't wide enough In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10604 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 11:02:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 09:02:09 +0000 Subject: [Koha-bugs] [Bug 10604] two columns in the courses table aren't wide enough In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10604 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19817|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 19828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19828&action=edit [PASSED QA] Bug 10604: increase width of two columns in the courses table The department and term columns in the courses table started as varchar(20), but since they refer to authorized values, need to be varchar(80) to match authorised_values.authorised_value. This patch increases the width of those columns. To test: [1] Create two DEPARTMENT authorised values, one whose code is shorter than 20 characters and one whose code is longer than 20 characters. [2] Create two courses; give one course the short department and the other the long department. [3] Go to the courses list. Observe that the department column is displays the department name only for the short course. [4] Apply the patch. [5] Edit the course with the long department and assign that long department to it again. [6] Go back to the courses list. Observe that both of the courses now display their assigned department. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Verified changes are consistent for new installations and updated installations. Passes all tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 11:10:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 09:10:11 +0000 Subject: [Koha-bugs] [Bug 10576] Untranslatable strings in additem.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10576 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 11:10:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 09:10:15 +0000 Subject: [Koha-bugs] [Bug 10576] Untranslatable strings in additem.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10576 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19818|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 19829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19829&action=edit [PASSED QA] Bug 10576 - Untranslatable strings in additem.js There are a couple of untranslatable strings in additem.js. This patch moves the strings out of the script and into the include file which has been created for this purpose. To test, apply the patch and test the process for adding an item to an existing or new basket (with AcqCreateItem set to "when placing an order." The add item form should be correctly labeled "Add item." After adding an item, click to edit it again. The form should now be labeled "Update item." Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works nicely and passes all tests. Made sure strings can be translated testing with German templates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 11:24:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 09:24:51 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #21 from Robin Sheat --- The path shouldn't be a syspref, it doesn't make sense. Library staff shouldn't be touching it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 11:36:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 09:36:43 +0000 Subject: [Koha-bugs] [Bug 10619] New: sco.css missing for CCSR OPAC templates Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 Bug ID: 10619 Summary: sco.css missing for CCSR OPAC templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org To test: - Activate prog OPAC theme and web based self check - Open the web based self check page in OPAC - Verify it displays ok - Switch OPAC theme to CCSR - Verify the pages changes: On the left appears some information that should not be there. In the logs following error message should only appear when using CCSR templates: [Sun Jul 21 11:32:57 2013] [error] [client 127.0.0.1] File does not exist: /home/katrin/kohaclone/koha-tmpl/opac-tmpl/ccsr/famfamfam, referer: http://localhost/opac-tmpl/ccsr/en/css/sco.css -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 11:38:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 09:38:29 +0000 Subject: [Koha-bugs] [Bug 10619] sco.css missing for CCSR OPAC templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 --- Comment #1 from Katrin Fischer --- Also: System preference OpacFavicon is not used for web based self check pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 11:41:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 09:41:40 +0000 Subject: [Koha-bugs] [Bug 10592] Apache configuration is blocking fetch of certain icons and XML files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10592 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 11:41:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 09:41:45 +0000 Subject: [Koha-bugs] [Bug 10592] Apache configuration is blocking fetch of certain icons and XML files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10592 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19815|0 |1 is obsolete| | Attachment #19816|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 19830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19830&action=edit [PASSED QA] Bug 10592: fix MARC21 006/008 cataloging plugins Move the XML and XSD data files so that access to them (particularly the XML files) is not blocked by the Apache configuration change introduced by the patch for bug 9812. To test, after applying the patch. [1] Open a MARC21 bibliographic record in the cataloging editor. [2] Click on the plugin link for the 008 field. Verify that that the form for all of the fixed field positions is displayed, and verify that you can change the type of material. [3] Repeat step 2 for the 006 field. [4] Verify that there are no entries in the Apache error log that contain client denied by server configuration: {...}/cataloguing/value_builder/marc21_field_008.xml or client denied by server configuration: {...}/cataloguing/value_builder/marc21_field_006.xml Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Also verified translation of those plugins still works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 11:42:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 09:42:02 +0000 Subject: [Koha-bugs] [Bug 10592] Apache configuration is blocking fetch of certain icons and XML files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10592 --- Comment #6 from Katrin Fischer --- Created attachment 19831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19831&action=edit [PASSED QA] Bug 10592: fix display of favicon Move the favicon files for OPAC and staff so that they are not blocked by the Apache configuration change introduced by the patch for bug 9812. Note that this patch makes the favicon customizable by theme, not both theme and language. To test, after applying the patch. [1] Open pages in the OPAC and staff client. Verify that the favicon is displayed in the usual place in your web browser. Specific pages to test include - circulation receipts and slips - help - lists view - web-based self-checkout [2] Verify that the Apache logs do not contain entries like this: client denied by server configuration: {...}/prog/en/includes/favicon.ico Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Verified that the favicon displays correctly. Also tried changing favicons for staff and OPAC using the system preferences for those. This still works, where the system preferences are correctly supported in the templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 11:46:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 09:46:00 +0000 Subject: [Koha-bugs] [Bug 10620] New: Z39.50 page should highlight required fields Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10620 Bug ID: 10620 Summary: Z39.50 page should highlight required fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com There is no hint in the Z39.50 form in administration which fields are required. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 11:52:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 09:52:28 +0000 Subject: [Koha-bugs] [Bug 10516] Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 11:52:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 09:52:31 +0000 Subject: [Koha-bugs] [Bug 10516] Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19812|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 19832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19832&action=edit [PASSED QA] Bug 10516 - Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates The template for adding/editing Z39.50 servers shows the same title, breadcrumbs, etc. for add and edit operations. This patch creates separate text for each case. To test, try both adding and editing a Z39.50 server. The page title, breadcrumb, and heading should correctly reflect the operation you perform. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Works nicely and all strings are translatable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 11:52:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 09:52:48 +0000 Subject: [Koha-bugs] [Bug 10516] Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 --- Comment #4 from Katrin Fischer --- Created attachment 19833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19833&action=edit Bug 10516 - Follow up - Fixing capitalization Fix capitalization on submit buttons when deleting a Z39.50 server. - Delete this Server - Do Not Delete I think the "Do not delete" should maybe even be a cancel link to be more consistent with how Koha displays this kind of dialog in other places. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 11:55:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 09:55:06 +0000 Subject: [Koha-bugs] [Bug 10578] Escaping CGI breaks results sort feature (librarian's interface) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10578 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 13:01:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 11:01:40 +0000 Subject: [Koha-bugs] [Bug 10578] Escaping CGI breaks results sort feature (librarian's interface) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10578 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 13:01:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 11:01:44 +0000 Subject: [Koha-bugs] [Bug 10578] Escaping CGI breaks results sort feature (librarian's interface) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10578 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19746|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 19834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19834&action=edit [PASSED QA] Bug 10578 - Escaping CGI breaks results sort feature (librarian's interface) To test (in librarian's interface): 1. Have some biblio records to get a list when searching. 2. Make an advanced search with 'as phrase' modifier (title -- ti,phr: or author -- au,phr: , etc.) 3. Having the result list try to change the sort order. 4. You should get no results with a message like: "No results match your search for 'au%2Cphr: " etc. 5. Apply the patch 6. Repeat steps 2. & 3. 7. You should get the list sorted according to your choice. Signed-off-by: Srdjan Signed-off-by: Katrin Fischer Works nicely, passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 13:10:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 11:10:08 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19823|0 |1 is obsolete| | --- Comment #22 from Mirko Tietgen --- Created attachment 19835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19835&action=edit Bug 8897 [ENH] GPG Mail encryption -- New version Koha should offer patrons the option to receive their emails encrypted. This patch adds a dialog to the user interface (OPAC side) for patrons to add or delete a GPG public key. The key is directly added to or deleted from gpg (gnupg needs to be installed, binary expected at /usr/bin/gpg). This feature does not require sysadmins/librarians to do anything as long as the gpg binary if found. So far, mails are encrypted if a key for the recipient is avaliable - when sending lists or carts (encryption of email text + attachment) - when mails are sent through the message queue - ? Missing so far: - hide public key interface from OPAC/userdetails when no binary is found - de-hardcode path to gpg (syspref) - deal with BCC mails (send message explaining that an encrypted email has been send to the patron instead of a BCC) - ? Maybe later: - library-side key management: secret key for signing - encryption of emails from library to vendors - ? Test plan: -apply patch * Add/delete key: - in OPAC, log in as a user you got GPG kes for (primary email needs to match the key) - go to user details, email encryption - paste your public key into the form, save. when the page reloads, your key should be displayed in the form and a delete button at the bottom. in the terminal (as the koha-user!), do 'gpg --list-keys' and verify the key you just added is present - press the delete button under the form. on reload the form should be empty and your key gone. verify with (as the koha user) 'gpg --list-keys' in the terminal. - paste your key into the form again and save to do the following tests. * Encrypted cart emails - do a search, save a record in the the cart. open the cart, send it to the adress you added the key for. - check if the mail you receive has encrypted text and an encrypted attachment - decrypt both the text and the attachment, check if they are what you would expect * Encrypted list emails - if you do not have any lists, set up one with one record. - open the list from the opac, send it to you. enter the address you just added the key for - check that the mail you receive has encrypted text and an encrypted attachment. - decrypt both the text and the attachment, check if they are what you would expect * Encrypted message queue emails - check some items in and out for the patron you added the key for - wait for the message queue cronjob to run or run it manually - check if the email(s) you receive are encrypted and after decryption contain what you would expect Check all this again with another patron (without a gpg key) or use the same but delete the key before. Check that all mails and attachments are unencrypted and contain what you would expect (nothing is broken). If all that works for you, sign off the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 13:18:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 11:18:09 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #23 from Mirko Tietgen --- Robin: I was thinking of a case where the binary is in another place for some reasons. I agree that staff should not interfere with it. What other options are there? Make the Sysadmin put a symlink? Found the problem I had (needed to allow encryption with untrusted keys) and fixed some other small errors, I think it is ready for the first tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 13:24:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 11:24:16 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19835|0 |1 is obsolete| | --- Comment #24 from Mirko Tietgen --- Created attachment 19836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19836&action=edit Bug 8897 [ENH] GPG Mail encryption -- New version Koha should offer patrons the option to receive their emails encrypted. This patch adds a dialog to the user interface (OPAC side) for patrons to add or delete a GPG public key. The key is directly added to or deleted from gpg (gnupg needs to be installed, binary expected at /usr/bin/gpg). This feature does not require sysadmins/librarians to do anything as long as the gpg binary if found. So far, mails are encrypted if a key for the recipient is avaliable - when sending lists or carts (encryption of email text + attachment) - when mails are sent through the message queue - ? Missing so far: - hide public key interface from OPAC/userdetails when no binary is found - de-hardcode path to gpg (syspref) - deal with BCC mails (send message explaining that an encrypted email has been send to the patron instead of a BCC) - ? Maybe later: - library-side key management: secret key for signing - encryption of emails from library to vendors - ? Test plan: -apply patch * Add/delete key: - in OPAC, log in as a user you got GPG kes for (primary email needs to match the key) - go to user details, email encryption - paste your public key into the form, save. when the page reloads, your key should be displayed in the form and a delete button at the bottom. in the terminal (as the koha-user!), do 'gpg --list-keys' and verify the key you just added is present - press the delete button under the form. on reload the form should be empty and your key gone. verify with (as the koha user) 'gpg --list-keys' in the terminal. - paste your key into the form again and save to do the following tests. * Encrypted cart emails - do a search, save a record in the the cart. open the cart, send it to the adress you added the key for. - check if the mail you receive has encrypted text and an encrypted attachment - decrypt both the text and the attachment, check if they are what you would expect * Encrypted list emails - if you do not have any lists, set up one with one record. - open the list from the opac, send it to you. enter the address you just added the key for - check that the mail you receive has encrypted text and an encrypted attachment. - decrypt both the text and the attachment, check if they are what you would expect * Encrypted message queue emails - check some items in and out for the patron you added the key for - wait for the message queue cronjob to run or run it manually - check if the email(s) you receive are encrypted and after decryption contain what you would expect Check all this again with another patron (without a gpg key) or use the same but delete the key before. Check that all mails and attachments are unencrypted and contain what you would expect (nothing is broken). If all that works for you, sign off the patch. Bug 8897 Follow-up - fix file header fixes the copyright header for opac-gnupg.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 13:46:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 11:46:43 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 13:46:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 11:46:47 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19744|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 19837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19837&action=edit [PASSED QA] Bug 10588 - opac-topissues first branch always selected in filters In OPAC most popular items page: With user is logged-in his branch should be selected. When a branch is manually selected and form is submitted, this branch should be selected in results page. When looking at HTML, you see that all options are selected in combobox. This patch corrects by using the code "__ANY__" to distinguish form display and no branch filter selected. Test plan : - Make sure there are issues on records created in the past 3 month - Go to OPAC not logged-in - Click on "Most popular" => You get to page with results, "All libraries" is selected - Select a branch and submit => You get to page with results, the branch is selected [testing opac-topissues.inc from] - Select a branch and perform a search that does not have results (for example an item type never issued) => You get to page without results, the branch is selected [testing opac-topissues.tt form] - Log-in with a user - Click on "Most popular" => You get to page with results, user's branch is selected - Select "All libraries" and submit => You get to page with results, "All libraries" is selected [testing opac-topissues.inc from] - Select "All libraries" and perform a search that does not have results (for example an item type never issued) => You get to page without results, "All libraries" is selected [testing opac-topissues.tt form] Signed-off-by: Liz Rea Tests work as described - much improved! Signed-off-by: Katrin Fischer I am not sure about the use of "__ANY__" but the behaviour of the page is improved by the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 14:00:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 12:00:33 +0000 Subject: [Koha-bugs] [Bug 10552] Several preferences missing from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10552 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 14:00:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 12:00:36 +0000 Subject: [Koha-bugs] [Bug 10552] Several preferences missing from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10552 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19745|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 19838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19838&action=edit [PASSED QA] Bug 10552 - Several preferences missing from OPAC login page Several system preference variables are unavailable to the OPAC login template because they are not explicitly enabled for that page. Instead of adding them to Auth.pm using the old method this patch uses the new system preference check syntax using the Koha TT plugin. The following preferences are now checked using this syntax in masthead.inc: OpacAddMastheadLibraryPulldown UseCourseReserves reviewson OpacShowRecentComments In order for the call in masthead.inc to the new plugin to work on all OPAC pages "[% USE Koha %]" must be added to any template which includes it (most of them). Also in this patch: A change to Auth.pm to enable correct display of the LibraryName in the title of the OPAC login page. To test, turn on the above system preferences and confirm that the relevant links appear under the OPAC's main search bar on all pages including the login page. Confirm that the text specified in the LibraryName system preference is shown as the title of the login page. Confirm that course reserves and comments are displayed correctly on the biblio detail page. Signed-off-by: Liz Rea I checked both prog and ccsr - all seems well and the links are appearing and disappearing in accordance with the appropriate sysprefs. Signed-off-by: Katrin Fischer Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 14:11:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 12:11:06 +0000 Subject: [Koha-bugs] [Bug 10429] branch filter not working in serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Created attachment 19839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19839&action=edit screenshot of wrong result list Dependig on the sequence in which you change select the filters it's still possible that the result list does not match the selected filters. Could you take another look please? Here is my step by step for the result shown on the screenshot: 1) Open claims page 2) Select "Demo Library" - filters work correctly, 1 result is shown 3) Switch status to "Expected" - 2 results are shown, including the one from Centerville -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 14:11:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 12:11:22 +0000 Subject: [Koha-bugs] [Bug 10429] branch filter not working in serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 14:15:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 12:15:36 +0000 Subject: [Koha-bugs] [Bug 10197] Add CSS classes to patron info list in patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10197 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|add id tags to patron info |Add CSS classes to patron |list |info list in patron account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 15:13:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 13:13:03 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #25 from Mirko Tietgen --- Created attachment 19840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19840&action=edit Bug 8897 Follow-up: add Crypt:GPG dependency this patch adds the perl module Crypt::GPG and the resp. package libcrypt-gpg-perl to PerlDependences.pm, debian/control and the debian and ubuntu package files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 16:47:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 14:47:26 +0000 Subject: [Koha-bugs] [Bug 10197] Add CSS classes to patron info list in patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10197 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 16:47:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 14:47:29 +0000 Subject: [Koha-bugs] [Bug 10197] Add CSS classes to patron info list in patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10197 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19685|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 19841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19841&action=edit [PASSED QA] Bug 10197: Add classes to patron info list This patch adds classes to the patron info found on the top left of the circulation and patron related pages to allow for easy styling of the information displayed. To test: * Apply patch * View a patron detail page and view the source on the list to the left to see the styles * View a checkout screen and view the source on the list to the left with patron info to see the styles * You could also try to style things by customizing your CSS Signed-off-by: Srdjan Signed-off-by: Katrin Fischer Template only changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 21 17:14:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 15:14:57 +0000 Subject: [Koha-bugs] [Bug 10621] New: Subscription alert emails have wrong from-address Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10621 Bug ID: 10621 Summary: Subscription alert emails have wrong from-address Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com The email addresses for 'to' and 'from' are the same for subscription alerts. They both contain the patron's mail address (which is the actual to-adress). Depending on you MTA/SMTP settings, this will cause errors instead of sending emails. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 01:09:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 23:09:08 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #26 from Robin Sheat --- The best option would probably be to search $PATH. For dependencies, don't forget debian/control.in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 01:19:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 23:19:21 +0000 Subject: [Koha-bugs] [Bug 10516] Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 01:19:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 21 Jul 2013 23:19:25 +0000 Subject: [Koha-bugs] [Bug 10516] Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19833|0 |1 is obsolete| | --- Comment #5 from Liz Rea --- Created attachment 19842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19842&action=edit Bug 10516 - Follow up - Fixing capitalization Fix capitalization on submit buttons when deleting a Z39.50 server. - Delete this Server - Do Not Delete I think the "Do not delete" should maybe even be a cancel link to be more consistent with how Koha displays this kind of dialog in other places. Signed-off-by: Liz Rea fixes capitalisation, tool stil works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 02:07:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 00:07:17 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to selelct multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 02:07:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 00:07:34 +0000 Subject: [Koha-bugs] [Bug 3134] Ability to selelct multiple reports to delete at once In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19806|0 |1 is obsolete| | --- Comment #8 from Liz Rea --- Created attachment 19843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19843&action=edit Bug 3134 - Ability to selelct multiple reports to delete at once This patch adds the option to select multiple saved reports for deletion. To test you must have two or more saved reports to delete. Deletion should work properly when: - Selecting one report for deletion by checking the box. - Selecting more than one report for deletion by checking boxes. - Clicking the old "Delete" link Clicking the delete button should prompt you to confirm. Clicking cancel should cancel. Clicking the delete button when no boxes are checked should trigger an alert asking you to select reports for deletion. Signed-off-by: Liz Rea Functional tests pass, template tests pass. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 10:55:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 08:55:55 +0000 Subject: [Koha-bugs] [Bug 10573] French translation for printing a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 --- Comment #6 from Christophe Croullebois --- Hello Mathieu, yes your patch is related with the discussion between Owen and Katrin. And amha it would be better to have a drop down list for this syspref, to avoid the risk of mistyping. I disagree with Jonathan, because your solution is more oriented user, and I think it is not user friendly to have such a string to type "pdfformat::layout3pages" But, the purpose of my patch is to add a french translation in the actual state of the code. Your patch is not conflicting with mine. Ok for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 13:17:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 11:17:06 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 --- Comment #6 from Magnus Enger --- Thanks for catching these, Katrin! I'm not sure I understand the second point, though. I have this in updatedatabase.pl: $DBversion = "3.13.00.XXX"; if ( CheckVersion($DBversion) ) { $dbh->do("ALTER TABLE itemtypes ADD COLUMN checkinmsg VARCHAR(255);"); print "Upgrade to $DBversion done (Bug 10513 - Light up a warning/message when returning a chosen item type)\n"; SetVersion($DBversion); } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 13:43:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 11:43:56 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19123|0 |1 is obsolete| | --- Comment #69 from Kyle M Hall --- Created attachment 19844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19844&action=edit Bug 9456 - Add callnumber column to the cart This patch adds call-number sorting to the staff client cart. Sortining is enabled on the 'Items' column which uses a custom sorting routine to sort the callnumbers. If the sort is ascending, each column will be sorted by the highest ordered callnumber for that row. Likewise, if the sort is descending the table will be sorted by the lowest valued callnumber for that row. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 13:44:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 11:44:13 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19124|0 |1 is obsolete| | --- Comment #70 from Kyle M Hall --- Created attachment 19845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19845&action=edit Bug 9456 - Add callnumber column to the cart - add tooltip Signed-off-by: Cedric Vita -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 13:44:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 11:44:27 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19125|0 |1 is obsolete| | --- Comment #71 from Kyle M Hall --- Created attachment 19846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19846&action=edit Bug 9456 - Add callnumber column to the cart - Followup - Move sort filters to datatables.js Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 13:44:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 11:44:39 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19126|0 |1 is obsolete| | --- Comment #72 from Kyle M Hall --- Created attachment 19847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19847&action=edit Bug 9456 - Add callnumber column to the cart - QA Followup - Remove useless CSS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 13:44:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 11:44:59 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 13:45:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 11:45:03 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #73 from Kyle M Hall --- Created attachment 19848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19848&action=edit Bug 9456 - Add callnumber column to the cart - QA Followup 2 - Sort on callnumber only -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 13:47:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 11:47:29 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19848|0 |1 is obsolete| | --- Comment #74 from Kyle M Hall --- Created attachment 19849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19849&action=edit Bug 9456 - Add callnumber column to the cart - QA Followup 2 - Sort on callnumber only -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 13:51:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 11:51:53 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 --- Comment #7 from Katrin Fischer --- In your updatedatabase SQL statement you don't specify where the new column should be added within the table - so it is theoretically possible that the sequence of columns ends up being different from the one in kohastructure.sql. To avoid this you can tell it specifically to add the new column after summary :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 13:54:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 11:54:53 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #75 from Kyle M Hall --- (In reply to Katrin Fischer from comment #68) > Hi Kyle - there are some conflicts, can you please rebase and answer > Jonathan's question? Rebased and fixed! This latest followup parses the sorted strings down to callnumbers and only callnumbers. > I wonder if we should offer an option to show only the items of one selected > branch in the list of items? But couldn't take a look at how this effects > the display of items. That is an interesting idea, but I think it would belong in it's own separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 14:33:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 12:33:03 +0000 Subject: [Koha-bugs] [Bug 10511] Odd behavior for messaging preferences with Talking Tech enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10511 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 14:33:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 12:33:08 +0000 Subject: [Koha-bugs] [Bug 10511] Odd behavior for messaging preferences with Talking Tech enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10511 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19783|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 19850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19850&action=edit Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 14:33:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 12:33:37 +0000 Subject: [Koha-bugs] [Bug 10511] Odd behavior for messaging preferences with Talking Tech enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10511 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19783|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 16:00:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 14:00:54 +0000 Subject: [Koha-bugs] [Bug 10592] Apache configuration is blocking fetch of certain icons and XML files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10592 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 16:38:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 14:38:21 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19482|0 |1 is obsolete| | --- Comment #99 from Galen Charlton --- Comment on attachment 19482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19482 Bug 7143 - Updating history and about page Pushed latest history.txt change to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 16:44:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 14:44:19 +0000 Subject: [Koha-bugs] [Bug 8911] docs/history.txt file missing for about.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8911 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Tom?s! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 16:47:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 14:47:22 +0000 Subject: [Koha-bugs] [Bug 10604] two columns in the courses table aren't wide enough In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10604 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 16:51:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 14:51:35 +0000 Subject: [Koha-bugs] [Bug 10197] Add CSS classes to patron info list in patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10197 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Nicole! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 16:59:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 14:59:29 +0000 Subject: [Koha-bugs] [Bug 10552] Several preferences missing from OPAC login page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10552 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 17:03:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 15:03:29 +0000 Subject: [Koha-bugs] [Bug 10411] Add cache control headers to static resources in the apache config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Robin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 17:05:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 15:05:31 +0000 Subject: [Koha-bugs] [Bug 8911] docs/history.txt file missing for about.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8911 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.2. Added a followup that advertises the change for people updating to add the line to koha-conf.xml manually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 17:37:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 15:37:34 +0000 Subject: [Koha-bugs] [Bug 2969] Report Name should be mandatory for saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2969 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- (In reply to Chris Cormack from comment #5) > However we are not checking this server side .. if this was the public > interface that would be a fail. I will leave this up to the RM to > decided if client side checks are ok for this. Bearing in mind we > weren't handling any sql errors properly server side before this. Yes, I'm willing to push it, in particular because the column is changing to not null default '', not just a plain 'not null', and because the consequences of somebody actively trying to save a report with a blank name are ... they now have a report with a blank name. I suppose that raises one question: would it be better to tighten the screws a bit more and have it just be plain 'not null'? Another question: any objections to have the database update set the report name to something like concat('report ', id) for reports where the name is blank or null? Setting to in discussion, but I've no particular objection if Owen's response is simply to set it back to passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 17:44:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 15:44:12 +0000 Subject: [Koha-bugs] [Bug 10576] Untranslatable strings in additem.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10576 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 17:50:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 15:50:09 +0000 Subject: [Koha-bugs] [Bug 10617] Init script cleanup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10617 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19811|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 19851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19851&action=edit Bug 10617 - koha-common init script cleanup Removed unused stuff, added a new config file /etc/default/koha-common to control the init script behaviour. Currently is only a stub. The config file could be put on /etc/sysconfig on RedHat and friends. The init script should work them too. Added a TODO comment regarding the 'status' switch. To test: - Apply the patch on master, build your own packages and install. - The init script should continue to work as expected. (it can be tested replacing the /etc/init.d/koha-common file with debian/koha-common.init on a packages install). - The absence of the /etc/default/koha-common file should not prevent the init script from working. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 17:53:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 15:53:41 +0000 Subject: [Koha-bugs] [Bug 10578] Escaping CGI breaks results sort feature (librarian's interface) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10578 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Janusz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 17:57:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 15:57:26 +0000 Subject: [Koha-bugs] [Bug 10622] New: Add --sip and --nosip switches to koha-list Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Bug ID: 10622 Summary: Add --sip and --nosip switches to koha-list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz It might be useful for batch calls, and also for use in koha-common.init. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 18:02:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 16:02:36 +0000 Subject: [Koha-bugs] [Bug 10622] Add --sip and --nosip switches to koha-list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 18:02:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 16:02:41 +0000 Subject: [Koha-bugs] [Bug 10622] Add --sip and --nosip switches to koha-list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 19852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19852&action=edit Bug 10622: add --sip and --nosip switches to koha-list Just added those switches. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 18:13:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 16:13:57 +0000 Subject: [Koha-bugs] [Bug 10586] Printing cart from Firefox seems to be missing CSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10586 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 18:44:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 16:44:03 +0000 Subject: [Koha-bugs] [Bug 10516] Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Thx Liz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 18:47:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 16:47:53 +0000 Subject: [Koha-bugs] [Bug 10516] Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Katrin Fischer --- Switching back to passed QA after checking with Galen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 19:02:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 17:02:08 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #20 from Katrin Fischer --- 12 has no description, but apart from that tests look good :) ok 11 - A branch has been modified, no new branch added ok 12 ok 13 - Two categories added -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 19:09:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 17:09:44 +0000 Subject: [Koha-bugs] [Bug 10622] Add --sip and --nosip switches to koha-list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 --- Comment #2 from Tom?s Cohen Arazi --- To test: - pick the koha-list script from this patch, and - test ./koha-list --help, ./koha-list -h for usage options - All switches should work as expected (--noemail --email --sip --nosip). That's it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 19:11:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 17:11:50 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 19:11:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 17:11:55 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19781|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer --- Created attachment 19853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19853&action=edit [PASSED QA] Bug 10508 : C4::Branch.pm needs unit tests. Unit tests are wrap in a transaction. NOTE: the field "issuing" isn't used in the database To test: prove t/db_dependent/Branch.t t/db_dependent/Branch.t .. ok All tests successful. Files=1, Tests=31, 0 wallclock secs ( 0.03 usr 0.00 sys + 0.13 cusr 0.00 csys = 0.16 CPU) Result: PASS Signed-off-by: Srdjan Signed-off-by: Katrin Fischer Passes all tests :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 19:14:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 17:14:58 +0000 Subject: [Koha-bugs] [Bug 10623] New: item lost says 'checked out' Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10623 Bug ID: 10623 Summary: item lost says 'checked out' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If you have an item that is marked 'lost' but still 'checked out' on the patron's record (like many libraries do) it shows as 'checked out' in the status in the OPAC. It would be better if it said 'Lost' in this case so that the patrons viewing it in the OPAC don't think that it might one day come back. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 19:16:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 17:16:18 +0000 Subject: [Koha-bugs] [Bug 4503] Javascript files in js directory are not translated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4503 --- Comment #1 from Katrin Fischer --- Lots of Javascript has moved out of the templates by now and we don't want to start copying them to the language specific directories again. Galen pointed out that something like https://code.google.com/p/jquery-i18n-properties/ could be a possible solution. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 19:25:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 17:25:09 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 19:25:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 17:25:23 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19444|0 |1 is obsolete| | --- Comment #8 from Magnus Enger --- Created attachment 19854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19854&action=edit Bug 10513 - Light up a warning/message when returning a chosen item type This patch adds a new column to item types. Text in this column is displayed as a warning when an item of the given type is checked in. Use case: Items that are on inter-library loan can have a separate item type, and when items of this type are checked in a message saying something like "ILL! Remember to return it to the owning library!" can be displayed. To test: - Apply the patch - Go to Home > Administration > Item types administration - Check that there is a new column, called "Check in message" - Edit an item type and add a check in message - Check that the check in message you added is displayed in the table - Check in an item with an item type that has a check in message - Check that the message is displayed - Check in an item with an item type that does *not* have a check in message, and make sure no false messages are displayed - Create a new item type from scratch and check that it works the way it is supposed to - Run the tests in t/ItemType.t, which are updated by this patch This patch also removes backticks around column names in the itemtypes table in installer/data/mysql/kohastructure.sql UPDATE 2013-07-22 - Rebased on current master (no changes) - Added "AFTER summary" to the SQL statement in updatedatabase.pl - Added another placeholder on line 170 of admin/itemtypes.pl Thanks Katrin! Sponsored-by: Kultur i Halland - Regionbibliotek -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 19:33:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 17:33:59 +0000 Subject: [Koha-bugs] [Bug 10624] New: koha-common.init should implement the 'status' option switch Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10624 Bug ID: 10624 Summary: koha-common.init should implement the 'status' option switch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz There's a status option on the script that is currently commented out. An implementation of it is needed. Trying to capture what Robin said on IRC, it should: - Know what should be running - Check if everything is running correctly - Return a warning otherwise -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 19:34:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 17:34:35 +0000 Subject: [Koha-bugs] [Bug 10624] koha-common.init should implement the 'status' option switch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10624 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10617 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 19:34:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 17:34:35 +0000 Subject: [Koha-bugs] [Bug 10617] Init script cleanup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10617 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10624 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 19:35:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 17:35:21 +0000 Subject: [Koha-bugs] [Bug 10624] koha-common.init should implement the 'status' option switch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10624 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10622 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 19:35:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 17:35:21 +0000 Subject: [Koha-bugs] [Bug 10622] Add --sip and --nosip switches to koha-list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10624 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 19:35:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 17:35:38 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 19:35:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 17:35:42 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19782|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 19855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19855&action=edit [PASSED QA] Bug 10528: C4::Booksellers needs unit tests Unit tests are wrap in a database transaction. GetBooksellerWithLateOrders has been modify in order to pass the tests. Now it considers the field $estimateddeliverydateto and it replaces it by now() only if it is undef. More it doesn't test if $aqbookseller.deliverytime is not Null anymore but if $deliverytime = null or undef, it replaces it by 0. It also verifies if $delay is >= 0. ModBookseller has been modify in order to be more explicit: before it always returned undef. Now it returns : 1 -> If a modification has been done 0E0 -> If the given id doesn't exist undef -> If no id given DelBookSeller has been modify in order to be more explicit: Before it returned undef, now it returns $sth->execute($id), so we can verify how many bookSellers have been deleted. Test Plan : prove t/db_dependant/Booksellers.t t/db_dependent/Bookseller.t .. 2/67 [Some warnings about uninitialized values] WARNING: GetBooksellerWithLateOrders is called with a negative value at /home/kenza/workspace/kohaclone/C4/Bookseller.pm line 137. t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=67, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.43 cusr 0.03 csys = 0.49 CPU) Result: PASS Signed-off-by: Srdjan Signed-off-by: Katrin Fischer Works nicely, when patch for 10557 is also applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 19:36:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 17:36:10 +0000 Subject: [Koha-bugs] [Bug 10557] GetBooksellersWithLateOrders has an unused branch parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10557 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 19:36:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 17:36:12 +0000 Subject: [Koha-bugs] [Bug 10557] GetBooksellersWithLateOrders has an unused branch parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10557 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19699|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 19856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19856&action=edit [PASSED QA] Bug 10557: GetBooksellersWithLateOrders has an unused branch parameter C4::Booksellers::GetBooksellersWithLateOrders has an unused parameter. The $branch variable is never used in the routine. Test plan: Check that no behavior changes on the late orders page. Signed-off-by: Srdjan Signed-off-by: Katrin Fischer I couldn't find any use of the branch parameter apart from the one corrected by this patch. Also tested late orders, couldn't find any problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 20:24:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 18:24:31 +0000 Subject: [Koha-bugs] [Bug 10625] New: Inventory/Stocktaking tool cannot handle windows file uploads Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 Bug ID: 10625 Summary: Inventory/Stocktaking tool cannot handle windows file uploads Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The inventory/stocktaking tool interprets windows text editor file as a single large barcode because the text editor only uses carriage returns for line breaks, rather than a carriage return and line break combination. This tools should be able to handle \r, \n, and/or \r\n. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 20:25:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 18:25:16 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com --- Comment #1 from Kyle M Hall --- Created attachment 19857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19857&action=edit Sample file of barcodes for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 20:28:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 18:28:58 +0000 Subject: [Koha-bugs] [Bug 10626] New: Remove doubled up TT plugins Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Bug ID: 10626 Summary: Remove doubled up TT plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: kyle at bywatersolutions.com Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaAuthorisedValues.pm AuthorisedValues.pm KohaBranchName.pm Branches.pm Also, it would be nice to add a usage example as documentation to the surviving plugins. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 20:29:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 18:29:04 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 20:33:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 18:33:09 +0000 Subject: [Koha-bugs] [Bug 10627] New: history of reports run/results Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10627 Bug ID: 10627 Summary: history of reports run/results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org >From a library: We would like to see a list of "Finished" results of running a report (i.e., generating a list of records) or using a tool (to make changes to records or settings)? In each instance, it would be possible to go back to a list of "Finished reports", to view both the results as well as the parameters that were set to generate the list or make whatever desired change... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 20:34:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 18:34:18 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 --- Comment #2 from Kyle M Hall --- Created attachment 19858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19858&action=edit Bug 10625 - Inventory/Stocktaking tool cannot handle windows file uploads The inventory/stocktaking tool interprets windows text editor file as a single large barcode because the text editor only uses carriage returns for line breaks, rather than a carriage return and line break combination. This tools should be able to handle \r, \n, and/or \r\n. Test Plan: 1) Download the attached sample file of barcodes 2) Upload this file to the inventory/stocktaking tool. For this test, it doesn't matter that these barcodes aren't cataloged in your system. 3) Note that the "barcode not found" is a single extremely long barcode 4) Apply this patch 5) Repeat step 2 6) Note that you now get a "barcode not found" error for each barcode individually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 20:34:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 18:34:16 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 20:47:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 18:47:55 +0000 Subject: [Koha-bugs] [Bug 10516] Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- (In reply to Liz Rea from comment #5) > I think the "Do not delete" should maybe even be a cancel > link to be more consistent with how Koha displays this > kind of dialog in other places. I agree, but I'm content to leave that to a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 20:48:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 18:48:20 +0000 Subject: [Koha-bugs] [Bug 10516] Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 20:54:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 18:54:14 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |gmcharlt at gmail.com --- Comment #11 from Galen Charlton --- I have reservations about this patch. Adding more unit tests is a good thing, obviously, and the proposed changes to functions in C4::Booksellers may be good things. However, they don't belong squashed together in a single patch, particularly since the patch description provides no test plan for the staff interfaces -- and if you change core routines, there ought to be such a test plan included in the patch, even if the only thing it does is identify the interfaces whose visible behavior is not changed. Please break it up, for example like this: [1] A patch for this bug that *only* adds additional unit tests. [2] An additional bug for each change you propose to routines in C4::Booksellers, along with any changes to the test script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 20:54:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 18:54:36 +0000 Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #9 from Katrin Fischer --- I am sorry, but this patch does no longer apply. Please rebase and switch back to Signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 20:56:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 18:56:03 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #22 from Galen Charlton --- Comment on attachment 19853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19853 [PASSED QA] Bug 10508 : C4::Branch.pm needs unit tests. Review of attachment 19853: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10508&attachment=19853) ----------------------------------------------------------------- ::: t/db_dependent/Branch.t @@ +21,4 @@ > use C4::Context; > use Data::Dumper; > > +use Test::More ;#tests => 6; There is nothing in this test script that makes the number of tests unpredictable. Consequently, I strongly prefer that the number of tests be declared explicitly, and that done_testing() be used only in cases where it is legitimately uncertain how many tests will be run. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 20:56:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 18:56:56 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |gmcharlt at gmail.com --- Comment #23 from Galen Charlton --- Similar to the concerns I expressed in bug 10528, I have reservations about a patch that both changes a bunch of core routines and adds tests. Please split it up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 21:02:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 19:02:37 +0000 Subject: [Koha-bugs] [Bug 10557] GetBooksellersWithLateOrders has an unused branch parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10557 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 21:12:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 19:12:41 +0000 Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- (In reply to Katrin Fischer from comment #6) > I am not sure about the use of "__ANY__" but the behaviour of the > page is improved by the patch. I'm not sure about the "__ANY__" either. Why not use the empty string as the value for the select, like the library selector on the masthead or the library selector on advanced search? I know that C4/Suggestions.pm uses __ANY__, but that's the only place in the code that does, and I think that should be taken out as well. Setting to in discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 21:37:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 19:37:20 +0000 Subject: [Koha-bugs] [Bug 7308] new column in admin/aqbudgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #24 from Galen Charlton --- Created attachment 19859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19859&action=edit potential source of confusion if parent and child funds both have orders Overall, I think the patch looks good, but there's a case where I think it leads to a confusing display. In the screenshot, fund abc has $10.45 ordered against it, but it also has a child fund, def, that has $14.97 ordered against it. The base-level ordered and total-ordered make sense, individually, but when you look at the whole picture, a librarian could be excused for asking why the total of the "total ordered" column is $33.97, not $48.94 (= $25.42 + 14.97 + $8.55). Does anybody have any suggestions on how this could be made more clear? Setting to in discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 22 21:37:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 19:37:30 +0000 Subject: [Koha-bugs] [Bug 7308] new column in admin/aqbudgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 00:55:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 22:55:31 +0000 Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |gmcharlt at gmail.com --- Comment #2 from Galen Charlton --- This patch breaks test cases that mock C4::Context->_new_dbh(): t/db_dependent/Circulation_issuingrules.t .. 1..7 ok 1 - use C4::Circulation; not ok 2 - first matches # Failed test 'first matches' # at t/db_dependent/Circulation_issuingrules.t line 55. # Structures begin differing at: # $got->{issuelength} = '21' # $expected->{issuelength} = '10' ok 3 - none matches ok 4 - date expiry ok 5 - date expiry not ok 6 - date expiry ( 9 + 10 ) # Failed test 'date expiry ( 9 + 10 )' # at t/db_dependent/Circulation_issuingrules.t line 119. # got: '2013-03-02T23:59:00' # expected: '2013-02-19T23:59:00' not ok 7 - date expiry ( 9 + 5 ) # Failed test 'date expiry ( 9 + 5 )' # at t/db_dependent/Circulation_issuingrules.t line 123. # got: '2013-03-02T23:59:00' # expected: '2013-02-14T23:59:00' # Looks like you failed 3 tests of 7. Dubious, test returned 3 (wstat 768, 0x300) Failed 3/7 subtests Test Summary Report ------------------- t/db_dependent/Circulation_issuingrules.t (Wstat: 768 Tests: 7 Failed: 3) Failed tests: 2, 6-7 Non-zero exit status: 3 Files=1, Tests=7, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.78 cusr 0.08 csys = 0.90 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 01:10:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 23:10:23 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #24 from Srdjan Jankovic --- (In reply to Galen Charlton from comment #23) > Similar to the concerns I expressed in bug 10528, I have reservations about > a patch that both changes a bunch of core routines and adds tests. Please > split it up. Why? I think it is a good thing to add tests that support the change. Makes it kind of complete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 01:28:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 23:28:45 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #3 from Galen Charlton --- (In reply to Katrin Fischer from comment #2) > Galen, I think I found a problem with this - you said it's never used, but > from the description I thought about the funds page and spotted a problem > there: > > - Apply the patch > - Go to the funds page > - The heading is missing the budget information now - it shows: > Funds for '' > > I think this is a design issue of the funds page really. Maybe we just > should add a budget column to the table and reword the heading so it can > deal with funds from multiple budgets? But not sure how that would affect > other functionality on that page. Good catch. The funds page appears to still partially reflect an (old?) assumption that there would be only one active budget at a time. That assumption is nonsense nowadays, so I still believe that I'm on the right track with the change I made to GetBudgetPeriod(). Of course, it does need to be accompanied by a follow-up so that we don't have the Funds for '' situation. My proposal: - add a column for the parent budget (should it always be displayed, or only when no specific budget_period_id is passed?) - adjust the code that generates the hover to make sure that the parent budget is supplied. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 01:32:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 22 Jul 2013 23:32:17 +0000 Subject: [Koha-bugs] [Bug 10622] Add --sip and --nosip switches to koha-list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 --- Comment #3 from Robin Sheat --- It might not be a while before I can test this, but I do approve of the idea and at a read the code looks good. So if someone else looks at it first, that's great. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 02:03:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 00:03:23 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #25 from Galen Charlton --- (In reply to Srdjan Jankovic from comment #24) > (In reply to Galen Charlton from comment #23) > > Similar to the concerns I expressed in bug 10528, I have reservations about > > a patch that both changes a bunch of core routines and adds tests. Please > > split it up. > > Why? I think it is a good thing to add tests that support the change. Makes > it kind of complete My statement, taken out of the context of this bug, was indeed ill-worded. Of course I want tests to accompany patches that change core routines (although I would prefer that the tests, including regression tests, be in a separate patch from the one that changes the routines). But consider it in the context of this bug, which advertises itself as "UT: C4::Branch.pm needs unit tests", not "there are inappropriate uses of $sth->finish() in C4::Branches". In other words, this is part of the ongoing process to improve test coverage, and it's mixing up *that* with changes to core routines that I object to. Sure, in the process of writing tests for a module, it's quite likely that one will run into cases where a routine ought to be improved -- but those should be handled separately, either via separate bugs or at least separate patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 02:48:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 00:48:46 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #26 from Srdjan Jankovic --- > (although I would prefer that the tests, including regression tests, be in a > separate patch from the one that changes the routines). That is exactly what I'm trying to figure out - why do you find it easier that way. I would always want them together. Not arguing at all, as a QA you absolutely have right to ask for it to be delivered in a way that it suits you (it will get merged all together in the end anyway), just finding it interesting. > > But consider it in the context of this bug, which advertises itself as "UT: > C4::Branch.pm needs unit tests", not "there are inappropriate uses of > $sth->finish() in C4::Branches". In other words, this is part of the > ongoing process to improve test coverage, and it's mixing up *that* with > changes to core routines that I object to. I agree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 02:55:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 00:55:41 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #27 from Galen Charlton --- (In reply to Srdjan Jankovic from comment #26) > That is exactly what I'm trying to figure out - why do you find it easier > that way. I would always want them together. Not arguing at all, as a QA you > absolutely have right to ask for it to be delivered in a way that it suits > you (it will get merged all together in the end anyway), just finding it > interesting. In part, it's a consequence of following the TDD notion of writing the tests first. Depending on the nature of the bug, having the first patch contain the test cases allows one to apply just that patch, then run the tests, then see from the (presumptive) test failures the essence of the bug being fixed and/or the contract of the new routines being added or the changes to the contract of the routines being changed. Now that the stage of the little story that the patch series is telling is set and effective *documented* by the first patch, the subsequent patches round it out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 03:20:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 01:20:00 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #28 from Srdjan Jankovic --- Ok, I get it, you want to see the test(s) failing first, and then coming up fine. Maybe we should put it on the wiki then? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 03:24:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 01:24:51 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19137|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 03:25:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 01:25:24 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19138|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 03:25:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 01:25:52 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19139|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 03:26:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 01:26:28 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19140|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 03:26:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 01:26:57 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19141|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 08:45:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 06:45:11 +0000 Subject: [Koha-bugs] [Bug 7308] new column in admin/aqbudgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 --- Comment #25 from Paul Poulain --- (In reply to Galen Charlton from comment #24) > Does anybody have any suggestions on how this could be made more clear? > Setting to in discussion. Pushed or in discussion ? status mistaken ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 09:25:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 07:25:54 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 --- Comment #12 from kenza --- (In reply to Galen Charlton from comment #11) > I have reservations about this patch. Adding more unit tests is a good > thing, obviously, and the proposed changes to functions in C4::Booksellers > may be good things. However, they don't belong squashed together in a > single patch, particularly since the patch description provides no test plan > for the staff interfaces -- and if you change core routines, there ought to > be such a test plan included in the patch, even if the only thing it does is > identify the interfaces whose visible behavior is not changed. > > Please break it up, for example like this: > > [1] A patch for this bug that *only* adds additional unit tests. > [2] An additional bug for each change you propose to routines in > C4::Booksellers, along with any changes to the test script. Ok I will do that. Thanks for the advices. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 09:45:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 07:45:47 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #29 from kenza --- Ok, I completely understand your point of view. So , I will follow your advices and create new bugs to separate the different parts of this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 09:46:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 07:46:38 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #44 from Julian Maurice --- Created attachment 19860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19860&action=edit Bug 8296: Don't fill text field automatically + minor fixes: * Add bug number to updatedatabase * Fix colspan in serials-edit.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 09:48:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 07:48:20 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #45 from Julian Maurice --- Hi Katrin, thank you for the review. This patch fixes 1) 2) and 3) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 10:06:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 08:06:14 +0000 Subject: [Koha-bugs] [Bug 9299] for loop in Auth_with_ldap.pm requires an extended patron attribute to be set or LDAP logins fail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9299 Nu?o L?pez Ans?tegui changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18652|0 |1 is obsolete| | Status|Needs Signoff |Signed Off CC| |nunyo at masmedios.com Assignee|srdjan at catalyst.net.nz |nunyo at masmedios.com --- Comment #4 from Nu?o L?pez Ans?tegui --- Created attachment 19861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19861&action=edit [SIGNED-OFF] bug_9299: rework unique attributes check on ldap login Works fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 10:06:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 08:06:41 +0000 Subject: [Koha-bugs] [Bug 9299] for loop in Auth_with_ldap.pm requires an extended patron attribute to be set or LDAP logins fail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9299 Nu?o L?pez Ans?tegui changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 13:33:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 11:33:16 +0000 Subject: [Koha-bugs] [Bug 9253] If an item is reserved, at the opac it is marked as available In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mirko at abunchofthings.net |oleonard at myacpl.org --- Comment #9 from Mirko Tietgen --- Not sure why this bug was assigned to me, I am not working on this so I reset it to default -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 13:58:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 11:58:13 +0000 Subject: [Koha-bugs] [Bug 10628] New: AutomaticItemReturn prevents holds queue from filling local holds with local items Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 Bug ID: 10628 Summary: AutomaticItemReturn prevents holds queue from filling local holds with local items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com For some reason, C4::HoldsQueue::MapItemsToHoldRequests uses the system preference AutomaticItemReturn to decide if an attempt to fill local holds with local items. No explanation of this behavior is provided. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 13:58:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 11:58:31 +0000 Subject: [Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 14:28:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 12:28:11 +0000 Subject: [Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 14:28:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 12:28:13 +0000 Subject: [Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 --- Comment #1 from Kyle M Hall --- Created attachment 19862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19862&action=edit Bug 10628 - AutomaticItemReturn prevents holds queue from filling local holds with local items For some reason, C4::HoldsQueue::MapItemsToHoldRequests uses the system preference AutomaticItemReturn to decide if an attempt to fill local holds with local items. No explanation of this behavior is provided. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 14:35:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 12:35:44 +0000 Subject: [Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 --- Comment #2 from Kyle M Hall --- I could not come up with a reliable test plan for this bug. However, inspection of the code should be extremely simple. The patch actually contains two changes, either of which solves the problem, but I see no reason not to include both. The first is is the removal of the use of AutomaticItemReturn to control if we should try filling local holds with local items. The second is the rather strange situation where the least_cost_branch subroutine completely ignores the fact that the pickup branch might be in the list of branches that can be pulled from. I suggest both be implemented, the former for the fact that I cannot find any reason for this behavior, and the latter ( though obviated by the former ) because in the future someone may again modify the holds queue system and not realize that some code in MapItemsToHoldRequests would make this addition to least_cost_branch unnecessary. It seems to me that a unit test for least_cost_branch should fail immediately in it's current state. However, there is, for some reason, no unit test for least_cost_branch itself in HoldsQueue.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 14:47:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 12:47:54 +0000 Subject: [Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 --- Comment #3 from Kyle M Hall --- Created attachment 19863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19863&action=edit Bug 10628 - AutomaticItemReturn prevents holds queue from filling local holds with local items - Add unit test from least_cost_branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 14:51:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 12:51:03 +0000 Subject: [Koha-bugs] [Bug 2969] Report Name should be mandatory for saved reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2969 --- Comment #7 from Owen Leonard --- I picked up this patch because it looked useful and wasn't getting a follow-up from the original author. I think Galen's suggestions would make this better, but someone else would have to take it from here. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:02:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:02:27 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:02:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:02:30 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #30 from kenza --- Created attachment 19864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19864&action=edit C4::Branch.pm needs unit tests Unit tests are wrap in a transaction. To test: prove t/db_dependent/Branch.t t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at t/db_dependent/Branch.t line 207. t/db_dependent/Branch.t .. ok All tests successful. Files=1, Tests=36, 1 wallclock secs ( 0.02 usr 0.02 sys + 0.13 cusr 0.01 csys = 0.18 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:04:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:04:12 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #31 from kenza --- (In reply to kenza from comment #30) > Created attachment 19864 [details] [review] > C4::Branch.pm needs unit tests > > Unit tests are wrap in a transaction. > > To test: > prove t/db_dependent/Branch.t > t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at > t/db_dependent/Branch.t line 207. > t/db_dependent/Branch.t .. ok > All tests successful. > Files=1, Tests=36, 1 wallclock secs ( 0.02 usr 0.02 sys + 0.13 cusr 0.01 > csys = 0.18 CPU) > Result: PASS Now, the patch only does the tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:14:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:14:02 +0000 Subject: [Koha-bugs] [Bug 10629] New: Inappropriate uses of $sth->finish() in C4::Branches Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10629 Bug ID: 10629 Summary: Inappropriate uses of $sth->finish() in C4::Branches Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kenza.zaki at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:14:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:14:51 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10629 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:14:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:14:51 +0000 Subject: [Koha-bugs] [Bug 10629] Inappropriate uses of $sth->finish() in C4::Branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10629 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kenza.zaki at biblibre.com Depends on| |10508 Assignee|gmcharlt at gmail.com |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:17:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:17:59 +0000 Subject: [Koha-bugs] [Bug 10629] Inappropriate uses of $sth->finish() in C4::Branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10629 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10508 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:17:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:17:59 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10629 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:21:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:21:38 +0000 Subject: [Koha-bugs] [Bug 10401] Add ability to merge invoices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10401 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19523|0 |1 is obsolete| | --- Comment #2 from Jared Camins-Esakov --- Created attachment 19865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19865&action=edit Bug 10401: Add ability to merge invoices Given how easy it is to accidentally receive items from one invoice on multiple invoices, the ability to merge invoices can be quite handy. This patch adds that ability to Koha's Acquisitions module. To test: 1) Apply patch. 2) Run unit test: > prove t/db_dependent/Acquisition/Invoices.t 3) Create two invoices from the same vendor for merging, and receive at least one order on each. 4) Do a search on the Invoices page that brings up both the invoices you created. 5) Check the boxes next to the two invoices. 6) Click "Merge selected invoices." 7) Choose which invoice you want to keep (the default will be the first). 8) Click "Merge." 9) Confirm that the resulting invoice has all the orders you received listed on it. 10) Sign off. Rebased on latest master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:23:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:23:03 +0000 Subject: [Koha-bugs] [Bug 10629] Inappropriate uses of $sth->finish() in C4::Branch.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10629 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Inappropriate uses of |Inappropriate uses of |$sth->finish() in |$sth->finish() in |C4::Branches |C4::Branch.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:23:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:23:56 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:23:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:23:58 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #1 from Kyle M Hall --- Created attachment 19866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19866&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaAuthorisedValues.pm AuthorisedValues.pm Test Plan: 1) Apply this patch 2) View the pages that this patch has modified, make sure the branch name is still visible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:24:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:24:05 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10629 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:24:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:24:05 +0000 Subject: [Koha-bugs] [Bug 10629] Inappropriate uses of $sth->finish() in C4::Branch.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10629 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10508 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:24:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:24:08 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:25:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:25:39 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19866|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 19867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19867&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and AuthorisedValues Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaAuthorisedValues.pm AuthorisedValues.pm Test Plan: 1) Apply this patch 2) View the pages that this patch has modified, make sure the branch name is still visible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:33:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:33:09 +0000 Subject: [Koha-bugs] [Bug 10629] Inappropriate uses of $sth->finish() in C4::Branch.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10629 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:33:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:33:12 +0000 Subject: [Koha-bugs] [Bug 10629] Inappropriate uses of $sth->finish() in C4::Branch.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10629 --- Comment #1 from kenza --- Created attachment 19868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19868&action=edit Inappropriate uses of $sth->finish() in C4::Branch.pm Test plan : Check if the regression tests still works prove t/db_dependent/Branch.t t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at t/db_dependent/Branch.t line 207. t/db_dependent/Branch.t .. ok All tests successful. Files=1, Tests=36, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.12 cusr 0.00 csys = 0.16 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:45:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:45:57 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:46:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:46:10 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #103 from Jared Camins-Esakov --- Patch tested and signoff automatically uploaded by Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:49:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:49:22 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:56:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:56:08 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #3 from Kyle M Hall --- Created attachment 19869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19869&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaBranchName.pm Branches.pm Test Plan: 1) Apply this patch 2) View a basket group, note the branch name is displayed 3) View a subscription's details, note the branch name is displayed 4) View suggestions, note the branch names are displayed 5) Return an item that needs transfered, note the branch name is displayed 6) Run 'prove t/db_dependent/Koha_template_plugin_Branches.t' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:57:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:57:09 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19869|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 19870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19870&action=edit Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches Looking at the TT plugin directory I notice we have some plugins that seem to do the same thing: KohaBranchName.pm Branches.pm Test Plan: 1) Apply this patch 2) View a basket group, note the branch name is displayed 3) View a subscription's details, note the branch name is displayed 4) View suggestions, note the branch names are displayed 5) Return an item that needs transfered, note the branch name is displayed 6) Run 'prove t/db_dependent/Koha_template_plugin_Branches.t' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:57:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:57:49 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #104 from Jared Camins-Esakov --- Patch tested and signoff automatically uploaded by Jared Camins-Esakov Testing upload again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:59:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:59:21 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 15:59:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 13:59:48 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #105 from Jared Camins-Esakov --- Patch tested and signoff automatically uploaded by Jared Camins-Esakov Testing uploading again, this time with git-bz actually installed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 16:02:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 14:02:25 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #106 from Jared Camins-Esakov --- Patch tested and signoff automatically uploaded by Jared Camins-Esakov Let's try this once more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 16:04:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 14:04:43 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 16:05:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 14:05:21 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #107 from Jared Camins-Esakov --- Patch tested and signoff automatically uploaded by Jared Camins-Esakov Argh! Why does it hate me?!? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 16:06:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 14:06:05 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 --- Comment #9 from Owen Leonard --- When I tested this I found that I did not see the custom message if the item was on hold (prompting a hold message) or required a transfer (prompting a transfer message). Is this a bug, or is it by design? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 16:06:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 14:06:45 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 16:08:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 14:08:04 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #108 from Jared Camins-Esakov --- Patch tested and signoff automatically uploaded by Jared Camins-Esakov The problem was git-bz wasn't fully configured, I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 16:09:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 14:09:04 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 16:09:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 14:09:58 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #109 from Jared Camins-Esakov --- Patch tested and signoff automatically uploaded by Jared Camins-Esakov Unfortunately, configuring git-bz is harder than it looks. Maybe. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 16:10:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 14:10:34 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #110 from Jared Camins-Esakov --- Created attachment 19871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19871&action=edit Bug 10403: add ability to change fund on receipt Right now there is no way to change the budget or fund when receiving an item, which is annoying, particularly at the end of the fiscal year when every item not already received has to be switched to the following year's budget. This patch adds the ability to change the budget and fund when receiving. To test: 1) Apply patch. 2) Create an order for a vendor, choosing a fund to use for that order. 3) Receive the order, leaving the fund unchanged. Make sure the fund did not change. 4) Create another order for a vendor, choosing a fund to use for that order. 5) Receive the order, this time changing the fund. Make sure the fund is changed. 6) Run the unit test: > prove t/db_dependent/Acquisition.t 7) Sign off. (Notes: this patch depends on the Acquisitions.t unit test improvements in bug 10274; the seemingly-unrelated change in SQLHelper quiets an irritating warning caused by the NewOrder call in ModReceiveOrder) Signed-off-by: Jared Camins-Esakov Signed-off-by: Jared Camins-Esakov Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 16:11:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 14:11:49 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 16:12:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 14:12:57 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19871|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 16:16:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 14:16:03 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #111 from Jared Camins-Esakov --- Patch tested and signoff automatically uploaded by Jared Camins-Esakov Ah-ha! When using koha-gitify, git-bz has to work for *TWO* users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 16:21:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 14:21:07 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 16:22:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 14:22:34 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #112 from Jared Camins-Esakov --- Patch tested and signoff automatically uploaded by Jared Camins-Esakov Actually, it looks like Apache just massacres the environment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 16:37:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 14:37:30 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19836|0 |1 is obsolete| | --- Comment #27 from Mirko Tietgen --- Created attachment 19872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19872&action=edit Bug 8897 [ENH] GPG Mail encryption -- New version Koha should offer patrons the option to receive their emails encrypted. This patch adds a dialog to the user interface (OPAC side) for patrons to add or delete a GPG public key. The key is directly added to or deleted from gpg (gnupg needs to be installed, binary expected at /usr/bin/gpg). This feature does not require sysadmins/librarians to do anything as long as the gpg binary if found. So far, mails are encrypted if a key for the recipient is avaliable - when sending lists or carts (encryption of email text + attachment) - when mails are sent through the message queue - ? Missing so far: - hide public key interface from OPAC/userdetails when no binary is found - de-hardcode path to gpg (syspref) - deal with BCC mails (send message explaining that an encrypted email has been send to the patron instead of a BCC) - ? Maybe later: - library-side key management: secret key for signing - encryption of emails from library to vendors - ? Test plan: -apply patch * Add/delete key: - in OPAC, log in as a user you got GPG kes for (primary email needs to match the key) - go to user details, email encryption - paste your public key into the form, save. when the page reloads, your key should be displayed in the form and a delete button at the bottom. in the terminal (as the koha-user!), do 'gpg --list-keys' and verify the key you just added is present - press the delete button under the form. on reload the form should be empty and your key gone. verify with (as the koha user) 'gpg --list-keys' in the terminal. - paste your key into the form again and save to do the following tests. * Encrypted cart emails - do a search, save a record in the the cart. open the cart, send it to the adress you added the key for. - check if the mail you receive has encrypted text and an encrypted attachment - decrypt both the text and the attachment, check if they are what you would expect * Encrypted list emails - if you do not have any lists, set up one with one record. - open the list from the opac, send it to you. enter the address you just added the key for - check that the mail you receive has encrypted text and an encrypted attachment. - decrypt both the text and the attachment, check if they are what you would expect * Encrypted message queue emails - check some items in and out for the patron you added the key for - wait for the message queue cronjob to run or run it manually - check if the email(s) you receive are encrypted and after decryption contain what you would expect Check all this again with another patron (without a gpg key) or use the same but delete the key before. Check that all mails and attachments are unencrypted and contain what you would expect (nothing is broken). If all that works for you, sign off the patch. Squashed a few minor changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 16:38:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 14:38:05 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19840|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 16:44:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 14:44:42 +0000 Subject: [Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 16:44:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 14:44:44 +0000 Subject: [Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19697|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 19873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19873&action=edit [SIGNED-OFF] Bug 10195 Records hidden with OpacSuppression can still be accessed Records hidden with OpacSuppression are filtered from the search results, but the opac-detail page is still visible if you know the biblio number. This patch hides the detail page for suppressed biblios by redirecting (controlled by the syspref OpacSuppressionRedirect) either to opac-blocked (default), explaining that the record is blocked (including optional explanatory text from the syspref OpacSuppressionMessage) or to Koha's 404 page, giving no hint that a biblio with that number exists in the system. Test plan: Make sure you have at least one record with 942$n == 1. Set OpacSuppression to "Don't hide". Do an OPAC search that should bring up your hidden record and other records. Observe that your record is found. Open the detail page for the record. Observe that it is accessible. Copy the URL for later(!). Set OpacSuppression to "Hide". Leave OpacSuppressionByIPRange blank. Set OpacSuppressionRedirect to "an explanatory page ('This record is blocked')." Leave OpacSuppressionMessage blank for now. Disable queryparser(!) (because of bug 10542). Do a full zebra reindex. Do an OPAC search that should bring up your hidden record and other records. Observe that your record is not found. Open the opac-detail URL of the record (the one you copied before). Observe that you are redirected to opac-blocked and it displays a short standard message. Edit OpacSuppressionMessage and input some text. Open the opac-detail URL of the record again (the one you copied before). Observe that the text you entered in OpacSuppressionMessage is displayed under the standard text you have seen before. Set OpacSuppressionRedirect to "the 404 error page ('Not found')." Open the opac-detail URL of the record again (the one you copied before). Observe that you are redirected to Koha's 404 error page. Sign off the patch. :) Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 16:51:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 14:51:02 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #158 from Kyle M Hall --- RFC: http://wiki.koha-community.org/wiki/Online_Borrower_Registration_RFC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 17:00:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 15:00:07 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 17:00:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 15:00:11 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 --- Comment #13 from kenza --- Created attachment 19874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19874&action=edit C4::Bookseller.pm need unit tests The tests are wrap in a transaction. NOTE: some tests should pass but doesn't because of incoherences in the code. These tests are in comments and preceded by FIXME Test plan: prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. 15/53 [Some warnings about uninitialised values] t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=53, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.46 cusr 0.03 csys = 0.51 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 17:05:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 15:05:03 +0000 Subject: [Koha-bugs] [Bug 10630] New: DelBookseller's return value needs to be more explicit in C4::Bookseller.pm Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 Bug ID: 10630 Summary: DelBookseller's return value needs to be more explicit in C4::Bookseller.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kenza.zaki at biblibre.com QA Contact: testopia at bugs.koha-community.org DelBookSeller always returns undef, even if nothing has been deleted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 17:05:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 15:05:46 +0000 Subject: [Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10630 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 17:05:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 15:05:46 +0000 Subject: [Koha-bugs] [Bug 10630] DelBookseller's return value needs to be more explicit in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10628 Assignee|koha-bugs at lists.koha-commun |kenza.zaki at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 17:06:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 15:06:06 +0000 Subject: [Koha-bugs] [Bug 10630] DelBookseller's return value needs to be more explicit in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 17:06:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 15:06:51 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #23 from Owen Leonard --- Applying: Bug 9044: Provide item selection in record detail page (staff client) Applying: Bug 9044 [Follow-up] Add a blank option + add missing 'for' attributes Applying: Bug 9044: QA followup fatal: sha1 information is lacking or useless (installer/data/mysql/sysprefs.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9044: QA followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 17:07:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 15:07:17 +0000 Subject: [Koha-bugs] [Bug 10630] DelBookseller's return value needs to be more explicit in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10628 |10528 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 17:07:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 15:07:17 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10630 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 17:07:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 15:07:17 +0000 Subject: [Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10630 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 17:33:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 15:33:37 +0000 Subject: [Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 17:33:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 15:33:40 +0000 Subject: [Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19359|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 19875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19875&action=edit [SIGNED-OFF] Bug 10533: basketgroup js functions should in a separated js file This patch moves js functions used for managing basketgroup into a separated js file. Test plan: - Try all actions for basketgroup ( drag/drop, add, delete, close, print, reopen, edit, export as csv). - Check that there is no regression on others acquisition pages: * acqui/neworderempty.tt * acqui/uncertainprice.tt * acqui/addorderiso2709.tt * acqui/basketheader.tt * admin/aqbudgets.tt * admin/aqcontract.tt * admin/aqbudgetperiods.tt * admin/aqplan.tt * suggestion/suggestion.tt Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 17:42:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 15:42:14 +0000 Subject: [Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |gmcharlt at gmail.com --- Comment #11 from Galen Charlton --- This patch changes what gets returned as the LCCN. The acronym "LCCN" is ambiguous, unfortunately, as it can refer to LC Control Number or LC Call Number. The current behavior of the Z39.50 search is to return the former (i.e., the control number or LC-assigned identification number). Here is a diff (before and after applying the patch) of the output of a little test script I wrote that searches LC's Z39.50 server for ISBN 9780415964845. 'total_pages' => 1, 'breeding_loop' => [ { - 'lccn' => ' 2008005439', - 'breedingid' => '91', - 'date' => '2008', - 'author' => undef, + 'lccn' => 'PR6068.O93', + 'date' => '2008.', + 'breedingid' => '92', + 'author' => '', 'biblionumber' => undef, 'edition' => '2nd ed.', 'server' => 'LIBRARY OF CONGRESS', I'm marking this as failed QA for the change in visible behavior, but this issue speaks to a broader concern I have with this patch: why replace the call to TransformMarcToKoha, which uses the installed default bibliographic framework to extract strings from the MARC record, with hardcoding the tags and subfields for each MARC flavor? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 17:53:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 15:53:09 +0000 Subject: [Koha-bugs] [Bug 10631] New: Table alert should have a FK on borrowernumber and entries be deleted with the referenced borrower Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10631 Bug ID: 10631 Summary: Table alert should have a FK on borrowernumber and entries be deleted with the referenced borrower Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The table alert is currently used to store information about email subscriptons for new serial issues. The current table defnition is: 2682 DROP TABLE IF EXISTS `alert`; 2683 CREATE TABLE `alert` ( 2684 `alertid` int(11) NOT NULL auto_increment, 2685 `borrowernumber` int(11) NOT NULL default 0, 2686 `type` varchar(10) NOT NULL default '', 2687 `externalid` varchar(20) NOT NULL default '', 2688 PRIMARY KEY (`alertid`), 2689 KEY `borrowernumber` (`borrowernumber`), 2690 KEY `type` (`type`,`externalid`) 2691 ) ENGINE=InnoDB DEFAULT CHARSET=utf8; 2692 As I see it borrowernumber should be a FK and we are missing some cascades to make sure the table is cleaned up when a borrower is deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 17:57:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 15:57:13 +0000 Subject: [Koha-bugs] [Bug 10631] Table alert should have a FK on borrowernumber and entries be deleted with the referenced borrower In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10631 --- Comment #1 from Galen Charlton --- Some relevant commentary from #koha: hm wondering... we delete all that, but that will make it impossible to do an 'undelete' bringing borrowers back from deletedborrowers we already delete a lot - that would make it more consistent, but I coudl imagine that might be the eaosn it was not done in the first place? i am working on a 'concept for deletion of personal data' so that's where those questions come from :) I'd rather have the FKs i will file a bug and note it for manual deletion for now... *meh* :) and if there's a desire for a more complete patron undelete, add new tables as needed e.g., deleted_borrower_alerts, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 18:13:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 16:13:51 +0000 Subject: [Koha-bugs] [Bug 10632] New: Enable datatables for courses and course details in the OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 Bug ID: 10632 Summary: Enable datatables for courses and course details in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org We should use datatables for the courses and course items tables. This will make the tables sortable and searchable from the client side. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 18:14:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 16:14:01 +0000 Subject: [Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10566 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 18:14:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 16:14:01 +0000 Subject: [Koha-bugs] [Bug 10566] Improve OPAC course reserves pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10566 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10632 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 18:17:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 16:17:27 +0000 Subject: [Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 18:17:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 16:17:29 +0000 Subject: [Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 --- Comment #1 from Kyle M Hall --- Created attachment 19876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19876&action=edit Bug 10632 - Enable datatables for courses and course details in the OPAC We should use datatables for the courses and course items tables. This will make the tables sortable and searchable from the client side. Test Plan: 1) Apply this patch 2) View the courses in the OPAC, try sorting and searching 3) View the course details for a course, try sorting and searching the items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 18:23:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 16:23:39 +0000 Subject: [Koha-bugs] [Bug 10633] New: Table suggestions needs some work Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10633 Bug ID: 10633 Summary: Table suggestions needs some work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The table suggestions is missing FK constraints and cascades to ensure a suggestion is anonymized when the borrower who suggested it gets deleted. The current table definition is: 2077 DROP TABLE IF EXISTS `suggestions`; 2078 CREATE TABLE `suggestions` ( -- purchase suggestions 2079 `suggestionid` int(8) NOT NULL auto_increment, -- unique identifier assigned automatically by Koha 2080 `suggestedby` int(11) NOT NULL default 0, -- borrowernumber for the person making the suggestion, foreign key linking to the borrowers table 2081 `suggesteddate` date NOT NULL default 0, -- date the suggestion was submitted 2082 `managedby` int(11) default NULL, -- borrowernumber for the librarian managing the suggestion, foreign key linking to the borrowers table 2083 `manageddate` date default NULL, -- date the suggestion was updated 2084 acceptedby INT(11) default NULL, -- borrowernumber for the librarian who accepted the suggestion, foreign key linking to the borrowers table 2085 accepteddate date default NULL, -- date the suggestion was marked as accepted 2086 rejectedby INT(11) default NULL, -- borrowernumber for the librarian who rejected the suggestion, foreign key linking to the borrowers table 2087 rejecteddate date default NULL, -- date the suggestion was marked as rejected 2088 `STATUS` varchar(10) NOT NULL default '', -- suggestion status (ASKED, CHECKED, ACCEPTED, or REJECTED) 2089 `note` mediumtext, -- note entered on the suggestion 2090 `author` varchar(80) default NULL, -- author of the suggested item 2091 `title` varchar(255) default NULL, -- title of the suggested item 2092 `copyrightdate` smallint(6) default NULL, -- copyright date of the suggested item 2093 `publishercode` varchar(255) default NULL, -- publisher of the suggested item 2094 `date` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP, -- date and time the suggestion was updated 2095 `volumedesc` varchar(255) default NULL, 2096 `publicationyear` smallint(6) default 0, 2097 `place` varchar(255) default NULL, -- publication place of the suggested item 2098 `isbn` varchar(30) default NULL, -- isbn of the suggested item 2099 `mailoverseeing` smallint(1) default 0, 2100 `biblionumber` int(11) default NULL, -- foreign key linking the suggestion to the biblio table after the suggestion has been ordered 2101 `reason` text, -- reason for accepting or rejecting the suggestion 2102 `patronreason` text, -- reason for making the suggestion 2103 budgetid INT(11), -- foreign key linking the suggested budget to the aqbudgets table 2104 branchcode VARCHAR(10) default NULL, -- foreign key linking the suggested branch to the branches table 2105 collectiontitle text default NULL, -- collection name for the suggested item 2106 itemtype VARCHAR(30) default NULL, -- suggested item type 2107 quantity SMALLINT(6) default NULL, -- suggested quantity to be purchased 2108 currency VARCHAR(3) default NULL, -- suggested currency for the suggested price 2109 price DECIMAL(28,6) default NULL, -- suggested price 2110 total DECIMAL(28,6) default NULL, -- suggested total cost (price*quantity updated for currency) 2111 PRIMARY KEY (`suggestionid`), 2112 KEY `suggestedby` (`suggestedby`), 2113 KEY `managedby` (`managedby`) 2114 ) ENGINE=InnoDB DEFAULT CHARSET=utf8; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 18:25:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 16:25:31 +0000 Subject: [Koha-bugs] [Bug 10505] Add a separator between title and subtitle for OPAC without XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10505 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- In our case (MARC21) titles (245 $a) have the colon included. If this patch were added we would end up with double colons. As far as I know our data is correct according to the MARC21 rules, so I don't know how you could accomplish this for UNIMARC without causing problems for MARC21 libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 18:38:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 16:38:16 +0000 Subject: [Koha-bugs] [Bug 10634] New: Use datatables for course details items table Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10634 Bug ID: 10634 Summary: Use datatables for course details items table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org We should make the course items table in the course details a datatable to enable searching or sorting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 18:38:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 16:38:42 +0000 Subject: [Koha-bugs] [Bug 10634] Use datatables for course details items table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10634 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 18:38:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 16:38:45 +0000 Subject: [Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 18:40:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 16:40:20 +0000 Subject: [Koha-bugs] [Bug 10634] Use datatables for course details items table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10634 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 18:40:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 16:40:22 +0000 Subject: [Koha-bugs] [Bug 10634] Use datatables for course details items table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10634 --- Comment #1 from Kyle M Hall --- Created attachment 19877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19877&action=edit Bug 10634 - Use datatables for course details items table We should make the course items table in the course details a datatable to enable searching or sorting. Test Plan: 1) Apply this patch 2) View the details page for a course with items 3) Verify the table displays and is now a datatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 18:42:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 16:42:07 +0000 Subject: [Koha-bugs] [Bug 10634] Use datatables for course details items table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10634 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19877|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 19878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19878&action=edit Bug 10634 - Use datatables for course details items table We should make the course items table in the course details a datatable to enable searching or sorting. Test Plan: 1) Apply this patch 2) View the details page for a course with items 3) Verify the table displays and is now a datatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 19:40:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 17:40:04 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 19:40:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 17:40:20 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #113 from Jared Camins-Esakov --- Created attachment 19879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19879&action=edit Signed off 0001-Bug-10402-Add-ability-to-enter-multiple-contacts.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 19:50:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 17:50:00 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19879|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 19:50:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 17:50:05 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #114 from Jared Camins-Esakov --- Created attachment 19880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19880&action=edit Signed off 0001-Bug-10402-Add-ability-to-enter-multiple-contacts.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 19:55:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 17:55:59 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19880|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 19:56:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 17:56:04 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #115 from Jared Camins-Esakov --- Created attachment 19881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19881&action=edit Signed off 0001-Bug-10402-Use-an-object-for-contacts.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 19:58:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 17:58:36 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19881|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 19:58:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 17:58:40 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #116 from Jared Camins-Esakov --- Created attachment 19882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19882&action=edit Signed off 0001-Bug-10402-Move-contacts-to-separate-table.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 19:58:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 17:58:48 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #117 from Jared Camins-Esakov --- Patch tested and signoff automatically uploaded by Jared Camins-Esakov And now we've lost my snarky comments? Oh no! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 20:14:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 18:14:00 +0000 Subject: [Koha-bugs] [Bug 10634] Use datatables for course details items table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10634 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 20:14:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 18:14:03 +0000 Subject: [Koha-bugs] [Bug 10634] Use datatables for course details items table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10634 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19878|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 19883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19883&action=edit [SIGNED-OFF] Bug 10634 - Use datatables for course details items table We should make the course items table in the course details a datatable to enable searching or sorting. Test Plan: 1) Apply this patch 2) View the details page for a course with items 3) Verify the table displays and is now a datatable Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 20:21:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 18:21:08 +0000 Subject: [Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- DataTables won't be styled correctly without changes to the CSS and the addition of DataTables-related images. That needs to be taken care of before this patch goes in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 20:31:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 18:31:32 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 20:31:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 18:31:37 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19774|0 |1 is obsolete| | --- Comment #18 from Owen Leonard --- Created attachment 19884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19884&action=edit [SIGNED-OFF] Bug 10320 - Integrate OverDrive search into OPAC This show results from the OverDrive ebook/audiobook service in the OPAC. Added the sysprefs and copied the relevant JS to CCSR. Signed-off-by: Srdjan Signed-off-by: Henry Bankhead Signed-off-by: Chris Cormack Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 20:33:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 18:33:44 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 20:33:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 18:33:48 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19775|0 |1 is obsolete| | --- Comment #19 from Owen Leonard --- Created attachment 19885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19885&action=edit [SIGNED-OFF] Followup for bug 10320: minor bugfixes and style improvements Switch to the new method of showing star ratings. Also, fix some translation bugs, an error that occurred when caching was disabled and add a stub unit test. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 20:34:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 18:34:51 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master --- Comment #20 from Owen Leonard --- These patches work well in my tests. One minor thing needs a follow-up: Some of the copyright statements on the new scripts appear to be copypasta. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 21:25:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 19:25:46 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #21 from Katrin Fischer --- This looks nice and works well afaikt :) I am adding my passed QA to these patches, but we need a follow up: Please run the QA script and fix following problems and also the copyright statements Owen pointed out: FAIL C4/External/OverDrive.pm FAIL pod *** ERROR: =item without previous =over in file C4/External/OverDrive.pm FAIL koha-tmpl/opac-tmpl/prog/en/modules/opac-overdrive-search.tt FAIL forbidden patterns forbidden pattern: tab char (line 143) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 34) forbidden pattern: tab char (line 148) Also I'd think it would be nice to have a non-Javascript fall back. For example you could prodie a simple search link in case Javascript is disabled in the browser. Please switch back to signed off when the follow up is ready and I will take a final look (or someone else who beats me to it :) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 21:27:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 19:27:14 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19884|0 |1 is obsolete| | Attachment #19885|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer --- Created attachment 19886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19886&action=edit [PASSED QA] Bug 10320 - Integrate OverDrive search into OPAC This show results from the OverDrive ebook/audiobook service in the OPAC. Added the sysprefs and copied the relevant JS to CCSR. Signed-off-by: Srdjan Signed-off-by: Henry Bankhead Signed-off-by: Chris Cormack Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 21:31:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 19:31:10 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #23 from Katrin Fischer --- Created attachment 19887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19887&action=edit [PASSED QA] Followup for bug 10320: minor bugfixes and style improvements Switch to the new method of showing star ratings. Also, fix some translation bugs, an error that occurred when caching was disabled and add a stub unit test. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 22:03:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 20:03:32 +0000 Subject: [Koha-bugs] [Bug 10635] New: can't query for create in action_logs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10635 Bug ID: 10635 Summary: can't query for create in action_logs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 19888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19888&action=edit error I wrote this report: SELECT p.cardnumber, p.surname, p.firstname, p.streetnumber, p.address, p.address2, p.city, p.state, p.zipcode, p.email, p.phone, p.dateenrolled, p.smsalertnumber, l.action, l.timestamp as 'action taken' FROM borrowers p left join action_logs l on (p.borrowernumber=l.object) where l.module='MEMBERS' and date(l.timestamp) between date_sub(curdate(), interval 1 week) and curdate() and l.action in ('MODIFY','CREATE') And get the attached error which says I can't use the word 'CREATE' but that's the word in the table ... so maybe we need to remove this restriction or change the wording in the table so that it can be queried. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 22:03:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 20:03:59 +0000 Subject: [Koha-bugs] [Bug 9979] convert ./C4/Installer/PerlDependencies.pm into a YAML file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9979 --- Comment #4 from Galen Charlton --- (In reply to Mason James from comment #0) > the current file in Koha with perl module data is not too user friendly > > this bug aims to replace it with a friendlier YAML version Can you expand on why you find this so unfriendly? Or why other developers would find it unfriendly, to well, write Perl code? Or provide use cases? Putting aside the current inability of the patch to apply, at the moment this seems to me to be a change purely for the sake of making a change. That's not to say that I have any particular attachment to the status quo in this case -- it would have been quite reasonable for Chris Nighswonger to have chosen YAML or JSON back in 2010 -- but the current state of affairs is also reasonable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 23:16:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 21:16:03 +0000 Subject: [Koha-bugs] [Bug 10616] hold warning needs design work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10616 --- Comment #2 from Nicole C. Engard --- Maybe 3 buttons - no radio buttons. So : Revert waiting status & Check out Cancel hold & Check out No, don't check out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 23:26:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 21:26:39 +0000 Subject: [Koha-bugs] [Bug 10621] Subscription alert emails have wrong from-address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10621 --- Comment #1 from Mirko Tietgen --- Created attachment 19889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19889&action=edit Bug 10621 Subscription alert emails have wrong from-address From-address and to-address were the same (patron's email) for subscription alerts. This patch changes 'from' the branch or kohaadminemailaddress -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 23:37:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 21:37:37 +0000 Subject: [Koha-bugs] [Bug 10621] Subscription alert emails have wrong from-address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10621 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19889|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Created attachment 19890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19890&action=edit Bug 10621 Subscription alert emails have wrong from-address From-address and to-address were the same (patron's email) for subscription alerts. This patch changes 'from' the branch or kohaadminemailaddress To test - add a subscription in staff/serials in case you don't have any - enable patron notifications or the subscription - in the OPAC, subscribe to the serial - in staff/serial, receive an issue of the serial Before applying the patch, the email that is supposed to be sent has the patron's email as 'from' and 'to' (and is likely to fail). If you follow the steps after applying the patch, the email alert should have the 'from' address of the patron's branch or kohaadminemiladdress -- which should also work fine with the MTA/SMTP you have set up for messaging. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 23 23:38:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 21:38:24 +0000 Subject: [Koha-bugs] [Bug 10621] Subscription alert emails have wrong from-address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10621 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 00:08:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 22:08:38 +0000 Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #28 from Mirko Tietgen --- You can also test the encryption of subscription alerts if you apply bug 10621 before this patch. See description there to trigger a subscription alert. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 00:13:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 22:13:39 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19436|0 |1 is obsolete| | --- Comment #10 from Jared Camins-Esakov --- Created attachment 19891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19891&action=edit Bug 5202: merge authorities from the authority file and reservoir This patch gives Koha the ability to merge authority records using the same interface used by bibliographic records, though slightly different methods for selecting which records to merge. The two ways to select records are as follows: 1) Records can be selected from authority search results by clicking the "Merge" link for two records. 2) Authority records can be merged from the reservoir by clicking the merge-related links in the Manage staged MARC batch screen. To test: 1) Apply patch. 2) Do a search for an authority record that will turn up multiple identical records (or at least two records that you don't mind merging). 3) Click the "Merge" link for the first record. 4) Click the "Merge" link for the second record. 5) Choose which fields from which record you want to appear in the resulting record. 6) Confirm that those are the fields that exist in the resulting record. 7) Stage an authority record (for example, an authority record you saved from your catalog. 8) Search for a record to merge with it using the "Search for a record to merge in a new window" link. 9) Merge these records, confirming that the resulting record (after going through the entire merging process) matches your expectations. 10) Set up a matching rule for authorities, and export an authority from your catalog that will match based on that rule. For MARC21, the following is a good choice for a rule: Matching rule code: AUTHPER Description: Personal name main entry Match threshold: 999 Record type: Authority record [Match point 1:] Search index: mainmainentry Score: 1000 Tag: 100 Subfields: a 11) Stage the record you just exported, choosing the matching rule you just created. 12) Merge the record using the "Merge" link, confirming that the resulting record (after going through the entire merging process) matches your expectations. 13) Sign off. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 00:13:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 22:13:49 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19634|0 |1 is obsolete| | --- Comment #11 from Jared Camins-Esakov --- Created attachment 19892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19892&action=edit Bug 5202 QA follow-up: quiet warnings Due to massively incorrect data in the default authority frameworks, we were getting warnings about undefined values and spaces from checking which tab subfields/fields were displayed in. This patch eliminates those warnings. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 00:21:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 22:21:50 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 00:21:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 22:21:54 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18465|0 |1 is obsolete| | Attachment #18621|0 |1 is obsolete| | --- Comment #40 from Galen Charlton --- Created attachment 19893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19893&action=edit Bug 9394: Use reserve_id where possible This patch switches from using a combination of biblionumber/borrowernumber to using reserve_id where possible. Test Plan: 1) Apply patch 2) Run t/db_dependent/Holds.t Signed-off-by: Maxime Pelletier Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 00:22:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 22:22:02 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 --- Comment #41 from Galen Charlton --- Created attachment 19894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19894&action=edit Bug 9394: QA Followup * C4::Reserves::_FixPriority - The previous code checked the cancellationdate. If think you never pass in it with bad parameters, but in order to be sure I added the check on this value. - The reservedates array was never used. * circ/circulation.tt There was a bug: it was not possible to remove an hold from the circulation page. Passing reserve_id fixes the issue. * C4::Reserves::GetReserveId This subroutine did not have a unit test. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 00:22:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 22:22:08 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 --- Comment #42 from Galen Charlton --- Created attachment 19895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19895&action=edit Bug 9394: (follow-up) modernize test cases - wrap in a transaction - create the patron records needed for the test To test: [1] Run prove -v t/db_dependent/Holds.t [2] Verify that all tests have passed. [3] Verify that the additional patron records created by the test no longer exist in the database. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 00:22:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 22:22:17 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 --- Comment #43 from Galen Charlton --- Created attachment 19896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19896&action=edit Bug 9394: (follow-up) silence spurious warns One just needed parentheses, but the one on line 219 reflects a slightly deeper problem -- it's running patron checks when a patron hasn't actually been supplied. To test: [1] From the staff interface, bring up a biblio that has no holds on it, then go to the holds tab. [2] Verify that the Apache log has no new warnings containing: request.pl: Use of uninitialized value in string eq at /home/gmc/koha/reserve/request.pl line 219 or request.pl: Use of uninitialized value in string eq at /home/gmc/koha/reserve/request.pl line 488 Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 00:22:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 22:22:25 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 --- Comment #44 from Galen Charlton --- Created attachment 19897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19897&action=edit Bug 9394: (follow-up) restore ability to cancel holds from the patron summary To test: - Place a hold request for a patron - From the patron details page, navigate to the holds table, then cancel (delete) it. - Verify that the hold request is gone. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 00:22:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 22:22:31 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 --- Comment #45 from Galen Charlton --- Created attachment 19898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19898&action=edit Bug 9394: (follow-up) fix query column alias A change-and-replace went a tick too far. This patch adjusts the column alias in the query run in MergeHolds() to reflect that the value being returned is the number of hold requests, not an ID. To test: [1] This patch should have no visible changes to behavior. To verify, pick to bib records that have hold requests on them, then merge them together. Verify that the merged bib contains sll of the hold requests on it. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 00:22:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 22:22:37 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 --- Comment #46 from Galen Charlton --- Created attachment 19899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19899&action=edit Bug 9394: (follow-up) stylistic tidying - fix identation in one line - remove a commented-out warn Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 00:23:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 22:23:25 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 --- Comment #47 from Galen Charlton --- This is about ready to go. I've attached the patches along with several follows; setting status to signed-off for a final QA pass, particularly of the follow-ups. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 01:12:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 23:12:29 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #40 from Galen Charlton --- Pushed to master, along with a follow-up to quell a warning that shows up now that the merge hash code is in a module that uses the warnings stricture. Thanks, Jared! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 01:17:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 23:17:09 +0000 Subject: [Koha-bugs] [Bug 10633] Table suggestions needs some work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10633 --- Comment #1 from Galen Charlton --- At first glance, I think the desired action for the FK constraints is "on delete set null, on update cascade". That raises a question for the suggestedby column: should it be made nullable? My gut feeling is yes -- I could see wanting to be able to report on suggestions over time, even in cases where the patron who originally made the suggestion has gone away. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 01:21:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 23:21:45 +0000 Subject: [Koha-bugs] [Bug 10627] history of reports run/results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10627 --- Comment #1 from Galen Charlton --- To flesh this out a bit: - Are we talking about guided/SQL reports? - Should report results be kept forever? For a specific length of time (or until purged)? How long? - Should results be retained for all reports? Or should this be decided per report? Or per each run of the report? - Does there need to be a permission for seeing finished saved report results? - Does there need to be a permission for deleting/purging saved report results? - Should there be constraints on which staff members should be able to see saved report results? - Should saved report results be stored in the database? In the filesystem? Is there a size limit we should enforce? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 01:39:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 23 Jul 2013 23:39:51 +0000 Subject: [Koha-bugs] [Bug 10635] can't query for create in action_logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10635 --- Comment #1 from Galen Charlton --- The restriction as a whole should not be removed to avoid the risk of a staff user inadvertently creating new tables in the database, but clearly it needs to be made a bit smarter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 02:30:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 00:30:50 +0000 Subject: [Koha-bugs] [Bug 10636] New: patronimage should have borrowernumber as PK, not cardnumber Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Bug ID: 10636 Summary: patronimage should have borrowernumber as PK, not cardnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org The patronimage table currently has cardnumber as its primary key rather than borrowernumber. patronimage.cardnumber in turn has a FK constraint referencing borrowers.cardnumber. This is less than ideal for a couple reasons: [1] DBIX::Class (see bug 8798) complains about it. In particular, any code that loads Koha::Database would litter the Apache logs with the following: DBIx::Class::Carp::__ANON__(): "might_have/has_one" must not be on columns with is_nullable set to true (Koha::Schema::Result::Borrower/cardnumber). This might indicate an incorrect use of those relationship helpers instead of belongs_to. at /usr/share/perl5/DBIx/Class/Relationship/HasOne.pm line 96 [2] Every other table that has an FK to borrowers uses borrowernumber as the referent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 02:30:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 00:30:58 +0000 Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8798 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 02:30:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 00:30:58 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10636 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 02:31:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 00:31:04 +0000 Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 02:43:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 00:43:31 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #72 from David Cook --- Hey Julian, Could you rebase this patch? (see my error message below) I'm really keen to see this get into Koha (and hopefully 3.8.x), so I'm willing to test this as much as necessary :). GIT ERROR MESSAGE: Applying: Bug 5349: Order line transfers Using index info to reconstruct a base tree... :256: new blank line at EOF. + warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Acquisition.pm CONFLICT (content): Merge conflict in C4/Acquisition.pm Failed to merge in the changes. Patch failed at 0001 Bug 5349: Order line transfers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 03:49:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 01:49:57 +0000 Subject: [Koha-bugs] [Bug 10637] New: Unexpected item creation in Acquisitions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10637 Bug ID: 10637 Summary: Unexpected item creation in Acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, when you have "AcqCreateItem" set to "receiving an order" and you receive only 1 item out of a multiple item order, 2 item records will be generated. One of those records will be the one for which you supplied details. The other will be a "blank" item record, which I assume is somehow being created via "TransformHtmlToXml", although I'm not sure how. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 05:03:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 03:03:00 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 --- Comment #14 from Srdjan Jankovic --- This won't work. Since the first patch is PASSED QA, I suggest the unit test patch is rebased to the first patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 05:12:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 03:12:31 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 05:12:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 03:12:34 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19864|0 |1 is obsolete| | --- Comment #32 from Srdjan Jankovic --- Created attachment 19900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19900&action=edit [SIGNED-OFF] C4::Branch.pm needs unit tests Unit tests are wrap in a transaction. To test: prove t/db_dependent/Branch.t t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at t/db_dependent/Branch.t line 207. t/db_dependent/Branch.t .. ok All tests successful. Files=1, Tests=36, 1 wallclock secs ( 0.02 usr 0.02 sys + 0.13 cusr 0.01 csys = 0.18 CPU) Result: PASS http://bugs.koha-community.org/show_bug.cgi?id=10508 Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 05:44:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 03:44:59 +0000 Subject: [Koha-bugs] [Bug 10638] New: Show alert when receiving an order with holds/reserves Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 Bug ID: 10638 Summary: Show alert when receiving an order with holds/reserves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org When orders are received, there should be a message saying whether there are any holds/reserves tied to that order's bib record or item records. If AcqCreateItem is set to "receiving an order" or "placing an order", you might want to know if the item you're receiving can fill a bib-level hold (i.e. "the next available item"). If AcqCreateItem is set to "placing an order", you might want to know if the physical item you're receiving already has a item-level hold on it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 06:11:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 04:11:55 +0000 Subject: [Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #2 from Srdjan Jankovic --- Got fatal: sha1 information is lacking or useless (C4/SIP/ILS/Patron.pm). Repository lacks necessary blobs to fall back on 3-way merge. when applying -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 06:35:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 04:35:30 +0000 Subject: [Koha-bugs] [Bug 7785] MySQL-specific syntax in C4::Members columns() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7785 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 06:35:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 04:35:33 +0000 Subject: [Koha-bugs] [Bug 7785] MySQL-specific syntax in C4::Members columns() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7785 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19575|0 |1 is obsolete| | --- Comment #18 from Srdjan Jankovic --- Created attachment 19901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19901&action=edit [SIGNED-OFF] Bug 7785 - MySQL-specific syntax in C4::Members columns() The initial thought was to remove this function. However, tools/import_borrowers.pl uses it. So rather than remove it to solve the problem, it was reworked to a more generic solution which runs faster. By accessing $sth->{NAME} directly, the driver becomes responsible for filling it correctly. This happens when a SELECT is done on the borrowers table. It does not even have to have data in the result set! The columns method could be more generic and used elsewhere too. Comparison between the old method and the STH method showed a significant time difference. The old method took 35 seconds for 40k iterations versus 19 seconds for the same amount of iterations with the STH method regardless of the size of the borrowers table. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 06:44:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 04:44:54 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19893|0 |1 is obsolete| | --- Comment #48 from Chris Cormack --- Created attachment 19902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19902&action=edit Bug 9394: Use reserve_id where possible This patch switches from using a combination of biblionumber/borrowernumber to using reserve_id where possible. Test Plan: 1) Apply patch 2) Run t/db_dependent/Holds.t Signed-off-by: Maxime Pelletier Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 06:46:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 04:46:38 +0000 Subject: [Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 06:46:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 04:46:41 +0000 Subject: [Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18846|0 |1 is obsolete| | --- Comment #3 from Srdjan Jankovic --- Created attachment 19903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19903&action=edit [SIGNED-OFF] Bug 10446 - System preference maxoutstanding is poorly named The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds, but the name does not describe its behavior very well. String changes only, no functional changes made. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify the new system preference FeesBlockHoldsAmount's value matches the previous value of maxoutstanding. 4) Set FeesBlockHoldsAmount to $10 5) Attempt to place an OPAC hold for a patron owing less than $10 This attempt should succeed. 6) Attempt to place an OPAC hold for a patron owing more than $10 This attempt should fail Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 06:47:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 04:47:58 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19894|0 |1 is obsolete| | --- Comment #49 from Chris Cormack --- Created attachment 19904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19904&action=edit Bug 9394: QA Followup * C4::Reserves::_FixPriority - The previous code checked the cancellationdate. If think you never pass in it with bad parameters, but in order to be sure I added the check on this value. - The reservedates array was never used. * circ/circulation.tt There was a bug: it was not possible to remove an hold from the circulation page. Passing reserve_id fixes the issue. * C4::Reserves::GetReserveId This subroutine did not have a unit test. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 06:48:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 04:48:18 +0000 Subject: [Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 --- Comment #4 from Srdjan Jankovic --- I'm ashamed to admit that I do not know how .po files get generated, so I assume nothing needs to be done there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 06:50:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 04:50:10 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19895|0 |1 is obsolete| | --- Comment #50 from Chris Cormack --- Created attachment 19905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19905&action=edit Bug 9394: (follow-up) modernize test cases - wrap in a transaction - create the patron records needed for the test To test: [1] Run prove -v t/db_dependent/Holds.t [2] Verify that all tests have passed. [3] Verify that the additional patron records created by the test no longer exist in the database. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 06:51:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 04:51:20 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19896|0 |1 is obsolete| | --- Comment #51 from Chris Cormack --- Created attachment 19906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19906&action=edit Bug 9394: (follow-up) silence spurious warns One just needed parentheses, but the one on line 219 reflects a slightly deeper problem -- it's running patron checks when a patron hasn't actually been supplied. To test: [1] From the staff interface, bring up a biblio that has no holds on it, then go to the holds tab. [2] Verify that the Apache log has no new warnings containing: request.pl: Use of uninitialized value in string eq at /home/gmc/koha/reserve/request.pl line 219 or request.pl: Use of uninitialized value in string eq at /home/gmc/koha/reserve/request.pl line 488 Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 06:57:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 04:57:08 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19897|0 |1 is obsolete| | --- Comment #52 from Chris Cormack --- Created attachment 19907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19907&action=edit Bug 9394: (follow-up) restore ability to cancel holds from the patron summary To test: - Place a hold request for a patron - From the patron details page, navigate to the holds table, then cancel (delete) it. - Verify that the hold request is gone. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 06:58:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 04:58:16 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19898|0 |1 is obsolete| | --- Comment #53 from Chris Cormack --- Created attachment 19908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19908&action=edit Bug 9394: (follow-up) fix query column alias A change-and-replace went a tick too far. This patch adjusts the column alias in the query run in MergeHolds() to reflect that the value being returned is the number of hold requests, not an ID. To test: [1] This patch should have no visible changes to behavior. To verify, pick to bib records that have hold requests on them, then merge them together. Verify that the merged bib contains sll of the hold requests on it. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 07:01:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 05:01:35 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 07:01:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 05:01:39 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19899|0 |1 is obsolete| | --- Comment #54 from Chris Cormack --- Created attachment 19909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19909&action=edit Bug 9394: (follow-up) stylistic tidying - fix identation in one line - remove a commented-out warn Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 07:05:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 05:05:43 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #55 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 07:14:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 05:14:57 +0000 Subject: [Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Hi Srdjan, po files are generated by running the translate script in misc/translator. For system preferences nothing much has to be done - you just have to make sure description in the .pref file makes sense. The scripts will make the file translatable :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 07:55:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 05:55:53 +0000 Subject: [Koha-bugs] [Bug 10629] Inappropriate uses of $sth->finish() in C4::Branch.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10629 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 07:55:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 05:55:56 +0000 Subject: [Koha-bugs] [Bug 10629] Inappropriate uses of $sth->finish() in C4::Branch.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10629 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19868|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 19910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19910&action=edit Bug 10629 : Inappropriate uses of $sth->finish() in C4::Branch.pm Test plan : Check if the regression tests still works prove t/db_dependent/Branch.t t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at t/db_dependent/Branch.t line 207. t/db_dependent/Branch.t .. ok All tests successful. Files=1, Tests=36, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.12 cusr 0.00 csys = 0.16 CPU) Result: PASS Signed-off-by: Chris Cormack >From the man page finsh() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 07:57:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 05:57:25 +0000 Subject: [Koha-bugs] [Bug 10629] Inappropriate uses of $sth->finish() in C4::Branch.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10629 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #3 from Chris Cormack --- Signed off, Kenza please don't forget to add the Bug number to your commit message, but otherwise this was a great patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 07:59:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 05:59:38 +0000 Subject: [Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |dcook at prosentient.com.au Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | --- Comment #1 from David Cook --- Created attachment 19911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19911&action=edit Bug 10638 - Show alert when receiving an order with holds/reserves This patch adds an alert message in Acquisitions when receiving new orders. If there are bib-level holds for the bib record attached to that order, it gives a count of the bib-level holds. If there are item-level holds for items attached to that order, it shows a count of the items as well as displaying the barcodes for the items that have holds/reserves on them. If there are item-level holds for items not attached to that order and there are no bib-level holds, the message will just say that there are pending reserves for that bib record. TEST PLAN 1) Set AcqCreateItem to "placing an order" 2) Place an order in Acquisitions 3) Create three or four items when placing that order 4) In the OPAC or staff client, place a hold on one item 5) Receive the order 6) Note that there is no alert message about the hold/reserve 7) Apply the patch 8) Receive another item for that order 9) Note that there should now be a yellow alert message at the top of the parcel.pl screen. 10) The message text will vary depending on the reserve/hold situation. If there are bib-level holds, it will display a count of bib-level holds. If there are item-level holds for items attached to that order, it will show a count of those holds and print out their barcodes. (N.B. if you are receiving part of an order, your order number will change, so it will only print information for the received items that are attached to this new order, rather than all items including the original order.) If there are item-level holds for items attached to a different order or no order at all, no specific information will be printed. It will just say that there are pending reserves for that record (or that there are bib-level holds, if there are bib-level holds). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 08:26:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 06:26:20 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #5 from Chris Cormack --- Comment on attachment 19870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19870 Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches Review of attachment 19870: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10626&attachment=19870) ----------------------------------------------------------------- ::: Koha/Template/Plugin/Branches.pm @@ +32,4 @@ > my $sth = C4::Context->dbh->prepare($query); > $sth->execute($branchcode); > my $b = $sth->fetchrow_hashref(); > + return $b ? encode( 'UTF-8', $b->{'branchname'} ) : q{}; By switching our templates to use this plugin, instead of KohaBranchName.pm we have changed the behaviour. We are now not using the GetBranchName subroutine, but instead doing a db query ourselves (which is probably better we shouldnt be using C4:: modules in the Koha:: space) but we are also doing this encode. And I am not convinced encode is what we should be doing here. Could you please explain why we are doing the encode? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 08:32:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 06:32:36 +0000 Subject: [Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19911|0 |1 is obsolete| | --- Comment #2 from David Cook --- Created attachment 19912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19912&action=edit Bug 10638 - Show alert when receiving an order with holds/reserves Bug 10638 - Show alert when receiving an order with holds/reserves This patch adds an alert message in Acquisitions when receiving new orders. If there are bib-level holds for the bib record attached to that order, it gives a count of the bib-level holds. If there are item-level holds for items attached to that order, it shows a count of the items as well as displaying the barcodes for the items that have holds/reserves on them. If there are item-level holds for items not attached to that order and there are no bib-level holds, the message will just say that there are pending reserves for that bib record. TEST PLAN 1) Set AcqCreateItem to "placing an order" 2) Place an order in Acquisitions 3) Create three or four items when placing that order 4) In the OPAC or staff client, place a hold on one item 5) Receive the order 6) Note that there is no alert message about the hold/reserve 7) Apply the patch 8) Receive another item for that order 9) Note that there should now be a yellow alert message at the top of the parcel.pl screen. 10) The message text will vary depending on the reserve/hold situation. If there are bib-level holds, it will display a count of bib-level holds. If there are item-level holds for items attached to that order, it will show a count of those holds and print out their barcodes. (N.B. if you are receiving part of an order, your order number will change, so it will only print information for the received items that are attached to this new order, rather than all items including the original order.) If there are item-level holds for items attached to a different order or no order at all, no specific information will be printed. It will just say that there are pending reserves for that record (or that there are bib-level holds, if there are bib-level holds). [dac2013: This patch obsoletes one that had the wrong commit title...] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 08:41:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 06:41:16 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16707|0 |1 is obsolete| | --- Comment #24 from Julian Maurice --- Created attachment 19913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19913&action=edit [SIGNED-OFF] Bug 9044: Provide item selection in record detail page (staff client) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 08:41:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 06:41:29 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16711|0 |1 is obsolete| | --- Comment #25 from Julian Maurice --- Created attachment 19914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19914&action=edit [SIGNED-OFF] Bug 9044 [Follow-up] Add a blank option + add missing 'for' attributes Signed-off-by: Pierre Angot et Leila Arkab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 08:41:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 06:41:44 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19060|0 |1 is obsolete| | --- Comment #26 from Julian Maurice --- Created attachment 19915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19915&action=edit [SIGNED-OFF] Bug 9044: QA followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 08:41:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 06:41:55 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19344|0 |1 is obsolete| | --- Comment #27 from Julian Maurice --- Created attachment 19916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19916&action=edit [SIGNED-OFF] Bug 9044: Change dropdown list into links list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 08:42:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 06:42:22 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19916|[SIGNED-OFF] Bug 9044: |Bug 9044: Change dropdown description|Change dropdown list into |list into links list |links list | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 08:42:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 06:42:41 +0000 Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #28 from Julian Maurice --- All patches rebased on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 08:53:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 06:53:21 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18931|0 |1 is obsolete| | --- Comment #73 from Julian Maurice --- Created attachment 19917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19917&action=edit [SIGNED-OFF] Bug 5349: Order line transfers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 08:53:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 06:53:34 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18933|0 |1 is obsolete| | --- Comment #74 from Julian Maurice --- Created attachment 19918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19918&action=edit [SIGNED-OFF] Bug 5349 follow-up: run transferorder.pl in a popup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 08:53:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 06:53:47 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18934|0 |1 is obsolete| | --- Comment #75 from Julian Maurice --- Created attachment 19919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19919&action=edit [SIGNED-OFF] Bug 5349: Fix a logical test in TransferOrder -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 08:53:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 06:53:57 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18935|0 |1 is obsolete| | --- Comment #76 from Julian Maurice --- Created attachment 19920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19920&action=edit Bug 5349: Add unit tests for TransferOrder -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 08:54:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 06:54:05 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19332|0 |1 is obsolete| | --- Comment #77 from Julian Maurice --- Created attachment 19921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19921&action=edit Bug 5349: Use DB transaction/rollback in unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 08:54:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 06:54:18 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19336|0 |1 is obsolete| | --- Comment #78 from Julian Maurice --- Created attachment 19922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19922&action=edit Bug 5349: Create a table for order line transfers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 08:54:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 06:54:51 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #79 from Julian Maurice --- All patches rebased on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 09:22:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 07:22:05 +0000 Subject: [Koha-bugs] [Bug 10621] Subscription alert emails have wrong from-address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10621 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 09:22:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 07:22:09 +0000 Subject: [Koha-bugs] [Bug 10621] Subscription alert emails have wrong from-address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10621 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19890|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 19923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19923&action=edit Bug 10621 Subscription alert emails have wrong from-address From-address and to-address were the same (patron's email) for subscription alerts. This patch changes 'from' the branch or kohaadminemailaddress To test - add a subscription in staff/serials in case you don't have any - enable patron notifications or the subscription - in the OPAC, subscribe to the serial - in staff/serial, receive an issue of the serial Before applying the patch, the email that is supposed to be sent has the patron's email as 'from' and 'to' (and is likely to fail). If you follow the steps after applying the patch, the email alert should have the 'from' address of the patron's branch or kohaadminemiladdress -- which should also work fine with the MTA/SMTP you have set up for messaging. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 11:41:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 09:41:53 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 --- Comment #15 from kenza --- (In reply to Srdjan Jankovic from comment #14) > This won't work. Since the first patch is PASSED QA, I suggest the unit test > patch is rebased to the first patch. But the first patch is FAILED QA... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 11:47:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 09:47:06 +0000 Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 --- Comment #6 from Kyle M Hall --- The use of encode is to make diacritics display correctly. This issue came up during the development of the Course Reserves ( Bug 10626 ) feature. You can see the patch where Paul added the encode to solve the issue here: http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18283&action=diff (In reply to Chris Cormack from comment #5) > Comment on attachment 19870 [details] [review] > Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches > > Review of attachment 19870 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/Template/Plugin/Branches.pm > @@ +32,4 @@ > > my $sth = C4::Context->dbh->prepare($query); > > $sth->execute($branchcode); > > my $b = $sth->fetchrow_hashref(); > > + return $b ? encode( 'UTF-8', $b->{'branchname'} ) : q{}; > > By switching our templates to use this plugin, instead of KohaBranchName.pm > we have changed the behaviour. > > We are now not using the GetBranchName subroutine, but instead doing a db > query ourselves (which is probably better we shouldnt be using C4:: modules > in the Koha:: space) but we are also doing this encode. > > And I am not convinced encode is what we should be doing here. Could you > please explain why we are doing the encode? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 12:59:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 10:59:18 +0000 Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 --- Comment #4 from Fridolyn SOMERS --- Created attachment 19924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19924&action=edit Bug 10544 - add Number-local-acquisition in known indexes Adding Number-local-acquisition in C4::Search known indexes allows to search without using "ccl=" prefix. Also corrects in ccl.properties : inv must be an alias of Number-local-acquisition. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 13:04:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 11:04:09 +0000 Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 --- Comment #5 from Fridolyn SOMERS --- > Adding Number-local-acquisition in C4::Search known indexes allows to search without using "ccl=" prefix. @Katrin : I think this solves your problem. If not, can you give your ccl.properties and record.abs ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 13:06:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 11:06:07 +0000 Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 --- Comment #6 from Fridolyn SOMERS --- Created attachment 19925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19925&action=edit Bug 10544 - add Number-local-acquisition in QueryParser config This patch adds the Number-local-acquisition in QueryParser config to behave like in ccl.properties. See commit message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 13:14:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 11:14:51 +0000 Subject: [Koha-bugs] [Bug 10505] Add a separator between title and subtitle for OPAC without XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10505 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |INVALID --- Comment #3 from Fridolyn SOMERS --- (In reply to Owen Leonard from comment #2) > In our case (MARC21) titles (245 $a) have the colon included. If this patch > were added we would end up with double colons. As far as I know our data is > correct according to the MARC21 rules, so I don't know how you could > accomplish this for UNIMARC without causing problems for MARC21 libraries. Ok. I also notices in all templates the title and subtitle are concatenated without separator. So if something must be done for subtitle that does not contain a separator, this patch is not the good method. Setting as invalid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 13:27:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 11:27:30 +0000 Subject: [Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 --- Comment #12 from M. de Rooy --- Created attachment 19926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19926&action=edit Bug 10462: QA Followup for LCCN in Breeding.pm Subroutine for Z3950 search in C4/Breeding.pmxxx interpreted LCCN as LC call number (tag 050), but should be control number (tag 010). Test plan: Check LCCN output on z3950_search.pl results table with and without patch. Search e.g. on ISBN 9780415964845. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 13:41:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 11:41:44 +0000 Subject: [Koha-bugs] [Bug 10573] French translation for printing a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 --- Comment #7 from mathieu saby --- I did not test yours, but as you said, it is probably not conflicting. That being said, in the long term, the current way Koha is dealing with template models of basket groups is not realy compatible with a "clean" way of doing internationalization in every languages... And it is not properly supporting non latin scripts. I think a long time solution would be to generate a HTML file and to convert it into pdf, rather than creating directly a pdf. And we could imagine a customized CSS so that some libraries could change easily some elements of the display. What do you think of that? Maybe it would need a lot of work, and could be done only for 3.14 or 3.16 (?), while your patch could be easily backported to 3.12/10/8/6. So I think your patch deserved to be tested. But it is holidays for me, so I will take a look next month ;-) Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 13:53:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 11:53:19 +0000 Subject: [Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 --- Comment #13 from M. de Rooy --- > This patch changes what gets returned as the LCCN. The acronym "LCCN" is > ambiguous, unfortunately, as it can refer to LC Control Number or LC Call > Number. The current behavior of the Z39.50 search is to return the former > (i.e., the control number or LC-assigned identification number). Good catch. Apparently mixed up these two tags with same acronym. The small followup corrects that. > Why replace the call to TransformMarcToKoha, which uses the installed default > bibliographic framework to extract strings from the MARC record, with > hardcoding the tags and subfields for each MARC flavor? Good question. The main reason was just optimization. I saw that we needed only six fields from the MARC record for a simple display, and TransformMarcToKoha is doing a transformation of the whole MARC record. The original code contains a call to TransformMarcToKoha followed by a call to ImportBreeding that again calls TransformMarcToKoha. Both calls have been optimized. 'Downside' is indeed a few lines hardcoding tags in the sub _add_rowdata. Let me still see a moment if we can still improve some there in order to gain more confidence :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 14:24:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 12:24:32 +0000 Subject: [Koha-bugs] [Bug 10429] branch filter not working in serial claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 --- Comment #5 from Fridolyn SOMERS --- (In reply to Katrin Fischer from comment #4) > Dependig on the sequence in which you change select the filters it's still > possible that the result list does not match the selected filters. > Indeed, the filters are not cumulative. But i think this is another bug. Maybe claims page needs a JQuery datatable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 15:42:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 13:42:37 +0000 Subject: [Koha-bugs] [Bug 10630] DelBookseller's return value needs to be more explicit in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 15:42:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 13:42:40 +0000 Subject: [Koha-bugs] [Bug 10630] DelBookseller's return value needs to be more explicit in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 --- Comment #1 from kenza --- Created attachment 19927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19927&action=edit Bug 10630: DelBookseller's always returns undef in C4::Bookseller.pm This patch makes DelBookseller returns the number of supplier it has deleted or undef if nothing has been deleted. It also adds some regression tests. To test: prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=7, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.40 cusr 0.03 csys = 0.45 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 15:42:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 13:42:59 +0000 Subject: [Koha-bugs] [Bug 10630] DelBookseller's return value needs to be more explicit in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 16:10:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 14:10:50 +0000 Subject: [Koha-bugs] [Bug 10627] history of reports run/results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10627 Claire Elliott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |celliott at dawsoncollege.qc.c | |a --- Comment #2 from Claire Elliott --- (In reply to Galen Charlton from comment #1) > To flesh this out a bit: > > - Are we talking about guided/SQL reports? > - Should report results be kept forever? For a specific length of time (or > until purged)? How long? > - Should results be retained for all reports? Or should this be decided per > report? Or per each run of the report? > - Does there need to be a permission for seeing finished saved report > results? > - Does there need to be a permission for deleting/purging saved report > results? > - Should there be constraints on which staff members should be able to see > saved report results? > - Should saved report results be stored in the database? In the filesystem? > Is there a size limit we should enforce? Just to clarify where we are coming from... Our college library has just migrated to Koha from SirsiDynix's Symphony ILS. In Symphony, "Reports" are pre-formatted/pre-loaded in the "WorkFlows" staff client, so you cannot create new ones at will. Also, as Nicole pointed out to us, Symphony's single "Reports" utility lumps together different functions which are, in Koha, divided between "Reports" and "Tools". (1) "Reports" are used to generate a list, or count, of bibliographic or item records, based on a specific set of limits/criteria; while (2) "Tools" are used carry out specific actions on the system, such as: staging/importing a batch of MARC records; generating notices/slips; batch modifying items... What Symphony provides, which Koha does not (yet), is a "Finished Reports" list that a staff member can always revisit to view the results/products of running a specific "Report" or "Tool", at a specific point in time. Each "Finished Report" is formatted/stored as a simple .txt file, and each record contains both: (a) a description of the specific criteria/action taken, at a specific time, to produce the particular listing of item/bib records ("reports") or desired changes to the system ("tool"), and (b) the actual list of records or outcomes that resulted from running a "report" or "tool" at that point in time. I hope this helps others understand what we are aiming for, but to answer your specific questions... - Are we talking about guided/SQL reports? Yes, we are talking about Koha's "Guided/SQL reports" (those "saved" within our local installation), but we are also talking about logging/recording the outcomes of using Koha's various "Tools"... Whether these "Finished Reports" appear in a single list is not important, but we would like to be able to go back and see what specific results/outcomes were achieved by running "x" Report or Tool, at "y" point in time. - Should report results be kept forever? For a specific length of time (or until purged)? How long? The proposed records should be kept indefinitely, until purged by a staff member. - Should results be retained for all reports? Or should this be decided per report? Or per each run of the report? These option should be flexible and ever-presnt. The default selected option ( presented at the moment the command is sent to 'run') should be to retain the result of any/all runs of an established report/tool. However, it would be good to have the option, with each run of each report/tool, to not automatically store the result in the system. (A staff member would, of course, always have the option, when viewing the record of any just-run report/tool, of saving the file to a personal computer/network directory of their choice, outside of the Koha system/server.) - Does there need to be a permission for seeing finished saved report results? Staff permissions to view these finished/saved reports would correspond with existing access privileges. If a staff member's profile has permission to generate reports or to use a specific tool, they will be able to view any finished/saved report in any corresponding list. - Does there need to be a permission for deleting/purging saved report results? As above, if a staff member is permitted to run and to view outcomes of reports/tools, they should have the option to delete/purge records from corresponding lists. - Should there be constraints on which staff members should be able to see saved report results? As above. - Should saved report results be stored in the database? In the filesystem? Without any clear/expert grasp of how and where Koha currently stores all of the different data elements in the system, my instinct is to say these records should not be stored in the database, but elsewhere within the file system: perhaps in the same general area where existing "logs" are kept. - Is there a size limit we should enforce? A size limit probably should be enforced, but should be generous without being ludicrous. Perhaps a prompt could be developed that would inform the staff when 90% of the allocated space has been used, and that it is time to purge some content to make room for new reports (and/or to save/archive selected records to an external directory, e.g., on personal computers/networks outside of the Koha system/server)? This option to view/save a finished report to a personal/shared directory should always be available, as should the option to purge. This is my first submission/reply on the system, and I imagine much lengthier than anyone expected, but I hope it is clear and will be happy to answer any other questions that may arise. Thank you Nicole for opening this thread on our behalf, and thank you Galen for your interest. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 16:31:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 14:31:06 +0000 Subject: [Koha-bugs] [Bug 10627] history of reports run/results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10627 --- Comment #3 from Galen Charlton --- (In reply to Claire Elliott from comment #2) > This is my first submission/reply on the system, and I imagine much > lengthier than anyone expected, but I hope it is clear and will be happy to > answer any other questions that may arise. Thank you for your reply -- this sort of detail is very helpful. A general follow-up question I have is this: could you describe a workflow or two that you would like involving saved report output? The obvious one is simply the ability to go back and view or save the results of a past report run, but I'd like to suss out whether there are other things that you are used to doing with saved reports. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 16:38:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 14:38:39 +0000 Subject: [Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 --- Comment #14 from Galen Charlton --- (In reply to M. de Rooy from comment #13) > Good question. The main reason was just optimization. I saw that we needed > only six fields from the MARC record for a simple display, and > TransformMarcToKoha is doing a transformation of the whole MARC record. > The original code contains a call to TransformMarcToKoha followed by a call > to ImportBreeding that again calls TransformMarcToKoha. Both calls have been > optimized. 'Downside' is indeed a few lines hardcoding tags in the sub > _add_rowdata. > Let me still see a moment if we can still improve some there in order to > gain more confidence :) I suspected it would be something like that. Arguably that's at the level of micro-optimization that could be dispensed with in the interests of keeping the code general, but a possible middle ground that might speed things up would be writing a routine like this: $hashref = ExtractFieldsPerFrameWork($marcrecord, $arrayref_of_fields, $frameworkcode); e.g. ExtractFieldsPerFrameWork($marcrecord, ['biblio.title', 'bibliitems.issn' ], ''); returning { 'biblio.title' => 'Journal of irreproducible results', 'biblioitems.issn' => '0022-2038', } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 16:52:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 14:52:11 +0000 Subject: [Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19926|0 |1 is obsolete| | --- Comment #15 from M. de Rooy --- Created attachment 19928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19928&action=edit Bug 10462: QA Followup to resolve LCCN mixup and remove hardcoded marc tags This patch corrects the mixup for LC call number and control number. Further, as suggested by Galen, it would be better to not introduce hardcoded tags in the Z3950Search subs in Breeding.pm. This patch resolves that by calling TransformMarcToKohaOneField. Note that this only involves changes to _addrowdata and _isbn_show. These subs are only used in building the displayed results table. Additionally, for French UNIMARC installs publicationyear is used to fill the Date column (copyrightdate is not used in those installs). The edition statement is only used in unimarc_lecture_pub not in unimarc_complet. Test plan: Do some Z3950 searches and look for values in all result columns. For MARC21 on LOC (and/or others): Look for isbn 9780415964845 (check LCCN). Look for author Rowling. For UNIMARC on BNF2 (and/or others): On BNF2 look for isbn 2070518426: result contains date and multiple isbn's. Look for title: Guide des candidats aux emplois de commissaire de police. Third result show edition statement (if you use 205$a with pub install). Note that there are no results with LCCN here (just as before). Signed-off-by: Marcel de Rooy Tested for MARC21 and UNIMARC (French lecture_pub install). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 16:55:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 14:55:03 +0000 Subject: [Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #6 from Fridolyn SOMERS --- Created attachment 19929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19929&action=edit Bug 10449 - Count suggestions without branch also See commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 16:55:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 14:55:31 +0000 Subject: [Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 16:55:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 14:55:40 +0000 Subject: [Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 --- Comment #16 from M. de Rooy --- Galen, Saw your comment just after uploading the latest followup that hopefully covers your suggestions as well. Resetting the status. If you need additional signoff, please let me know. In that case Kyle or Jonathan may be willing to repeat it.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 16:55:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 14:55:51 +0000 Subject: [Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 17:10:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 15:10:54 +0000 Subject: [Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Fridolyn SOMERS --- (In reply to Katrin Fischer from comment #5) > Failing QA for 1). Does the follow-up need signoff ? I'd say no because it is very small. I set to signed-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 17:13:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 15:13:43 +0000 Subject: [Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #8 from Fridolyn SOMERS --- (In reply to Katrin Fischer from comment #5) > The code used in the database for those seems to be _ANY_ - which is a bit confusing as I would have expected the branchcode column to be empty in this case. I think this is indeed a bug. You should open a new one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 17:14:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 15:14:35 +0000 Subject: [Koha-bugs] [Bug 7494] Use partial barcode or callnumber as a fallback for the barcode search in checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7494 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Galen Charlton --- Pushed to master. Thanks, MJ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 17:59:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 15:59:12 +0000 Subject: [Koha-bugs] [Bug 8274] count of suggestions on main page wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8274 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 10449 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 17:59:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 15:59:12 +0000 Subject: [Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #9 from Owen Leonard --- *** Bug 8274 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 18:57:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 16:57:49 +0000 Subject: [Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Galen Charlton --- Pushed to master, along with a follow-up to get rid of some undefined variable warnings. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 19:20:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 17:20:13 +0000 Subject: [Koha-bugs] [Bug 8169] No LCCN field on Z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8169 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9852|0 |1 is obsolete| | --- Comment #1 from Galen Charlton --- Comment on attachment 9852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9852 Zip folder holding patch Obsoleting; will be posting new patch shortly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 19:22:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 17:22:56 +0000 Subject: [Koha-bugs] [Bug 8169] No LCCN field on Z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8169 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 19:22:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 17:22:59 +0000 Subject: [Koha-bugs] [Bug 8169] No LCCN field on Z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8169 --- Comment #2 from Galen Charlton --- Created attachment 19930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19930&action=edit bug 8169: add LC Control Number to Z39.50 search form To test: [1] Bring up the Z39.50 search form. You should see that "LC Control Number" is now listed as a search option. [2] Enter '98046370' as the LCCN and search the Library of Congress Z39.50 server. [3] You should get back one hit for "Harry Potter and the Chamber of Secrets". [4] Search for other LCCNs, if desired. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 19:23:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 17:23:23 +0000 Subject: [Koha-bugs] [Bug 8169] No LCCN field on Z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8169 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 19:36:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 17:36:08 +0000 Subject: [Koha-bugs] [Bug 7518] searches with quotation marks don't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7518 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #36 from Galen Charlton --- I'm having difficulty reproducing this bug. For those who can, perchance are there any ZOOM error messages associated with it showing up in the Apache error log? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 19:52:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 17:52:04 +0000 Subject: [Koha-bugs] [Bug 8824] use of windows 7, Firefox V15 and wireless level dns 10.58.2.X versus wired 192.168.x.x In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8824 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 24 20:23:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 24 Jul 2013 18:23:25 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19708|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 19931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19931&action=edit Uses patron category to keep visible some things hidden by OPACHiddenItems This patch will: 1) Add two system preferences: PatronSingleBranch and PatronEveryBranch. 2) Items which would normally be hidden by OpacHiddenItems will be visible if: a) The patron's category code matches the PatronSingleBranch patron category code AND the home branch of the item is the same as the home branch of the patron. OR b) The patron's category code matches the PatronEveryBranch patron category code. The two system preferences default to PTSB and PTEB which are not added to the list of possible patron categories. This means OpacHiddenItems will continue to function as is normally. Having them as system preferences means the patron category code is not hard coded and can be changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 02:48:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 00:48:35 +0000 Subject: [Koha-bugs] [Bug 10639] New: Circular dependencies cause inventory.pl to fail when returning items Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10639 Bug ID: 10639 Summary: Circular dependencies cause inventory.pl to fail when returning items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently, when you're running an inventory, inventory.pl will die if any of the items need to be returned (i.e. Koha says they're checked out, but they were found on the shelf, so we do an "AddReturn"). After chatting to Chris Cormack and Jared Camins-Esakov on IRC, it appears the cause is due to "circular dependencies". That is, C4::Circulation::AddReturn is failing, because Perl thinks certain subs used in AddReturn from C4::Items actually belong to C4::Circulation (or rather it's just plain confused about where they're supposed to come from). This is because C4::Items and C4::Circulation depend on each other. C4::Circulation directly loads C4::Items, while C4::Items loads C4::Search which loads C4::Reserves which loads C4::Circulation. So...when inventory.pl loads C4::Items and C4::Circulation...we run into problems calling a sub from C4::Items within C4::Circulation, because there are conflicts/collisions in the namespace for subs from C4::Items (i.e. they've been loaded twice, so Perl has a hissy fit). Chris mentioned that the model for new Koha modules will be to have no circular dependencies, but for now...I'm thinking that we fully qualify calls to imported subs... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 04:35:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 02:35:26 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 --- Comment #16 from Srdjan Jankovic --- Ok, then it the first patch is FAILED QA, it should be replaced with something? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 04:49:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 02:49:08 +0000 Subject: [Koha-bugs] [Bug 10639] Circular dependencies cause inventory.pl to fail when returning items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10639 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from David Cook --- Nevermind...I thought that I had tested this in the master branch, but apparently I had not. Apparently, I had actually just eyeballed the master code that I expected to be different (in Circulation.pm) and seeing it was the same...decided that was enough. In fact, Jared Camins-Esakov removed this particular circular dependency back in 3.08.01 with Bug 7847: OPAC search dies with Plackthis (commit c97e0c76739b0624359feb47ee0573ebc46b8409). In order to do so, he removed the "use C4::Search" declaration at the top of C4::Items and instead used "require C4::Search" in the subs that needed it, and then used fully qualified sub names (since they are required when using "require" rather than "use"). Yay, Jared! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 04:49:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 02:49:50 +0000 Subject: [Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #4 from Srdjan Jankovic --- my ($self) = grep( /$to/, @$from ); looks a bit inefficient. Would you consider replacing with my $self; foreach (@$from) { if ($_ eq $to) { $self = $to; last; } } or maybe even better List::MoreUtils::any() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 05:04:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 03:04:34 +0000 Subject: [Koha-bugs] [Bug 8821] Receive shipment page should hide inactive funds like new order form does In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #5 from Srdjan Jankovic --- Hi Owen, Can I assume that the first patch is obsolete? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 05:13:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 03:13:17 +0000 Subject: [Koha-bugs] [Bug 10639] Circular dependencies cause inventory.pl to fail when returning items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10639 --- Comment #2 from David Cook --- That said, I think this is something that developers should keep in mind going forward... Chris Cormack said that the ideal method should be as follows: 1) Export subs using the EXPORT_OK array 2) Import subs using "use C4::Module qw (sub1 sub2)" Jared Camins-Esakov also mentioned: 1) In addition to the above, ff there is going to be any confusion, fully qualify the name (e.g. Add the C4::Module:: notation to the front of your imported sub when you're calling it). 2) "A require and fully-qualified call will at least make it easy to recognize problems." My two cents: I wonder if we should decide on the best method and put it in the Coding Guidelines? Should we always fully qualify subroutine names? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 05:16:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 03:16:31 +0000 Subject: [Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #3 from Srdjan Jankovic --- & is a reserved character in urls, and should not be replaced with & -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 06:28:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 04:28:13 +0000 Subject: [Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #3 from Srdjan Jankovic --- Applying: Bug 10610: sysprefs.sql should be sorted by syspref names fatal: sha1 information is lacking or useless (installer/data/mysql/sysprefs.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 10610: sysprefs.sql should be sorted by syspref names -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 06:38:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 04:38:36 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #4 from Srdjan Jankovic --- my $categorycode = C4::Members::GetBorrowerCategorycode()... should go in the if() block above, and be conditioned on the $borrowernumber as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 06:53:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 04:53:29 +0000 Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #4 from Srdjan Jankovic --- Is this just "I don't want to see other branches reports, I cannot find mine" case, or "We don't want you to see what other people are doing" kind of thing? Cause if it is former, it should really be a select drop down, rather than a syspref. Maybe. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 07:55:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 05:55:54 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #5 from M. Tompsett --- Conditioning on the borrowernumber seems reasonable, but it doesn't belong in the C4::Content->userenv check, because it looks it up in the DB. Revised and improved patch coming. Wizzyrea requested pipe delimited category codes, so that Teachers and Librarians could both seen hidden items, without having to group them into the same patron category code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 08:01:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 06:01:17 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19931|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 19932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19932&action=edit Using list of category codes OPACHiddenItems can be overridden This patch improvement overrides OPACHiddenItems based on potentially multiple patron category codes in the PatronSingleBranch and PatronEveryBranch system preferences which get added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 08:13:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 06:13:51 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19932|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 19933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19933&action=edit Using list of category codes OPACHiddenItems can be overridden Oops. Need to remember to test before posting patches. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 09:12:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 07:12:21 +0000 Subject: [Koha-bugs] [Bug 8169] No LCCN field on Z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8169 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from M. de Rooy --- Welcome addition! But could you please add the following: 1) Allow the same LCCN search on Acquisition Z3950 search? koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt 2) Rename LC Control Number to LC control number to use same uc/lc convention. 3) Why not add Raw (any) and Standard ID to Acquisition too in the same run? And move these 11 fields into an include file, shared between those two templates? Thanks.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 09:20:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 07:20:30 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19855|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 09:24:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 07:24:08 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #8 from Srdjan Jankovic --- Sorry, now another one: grep( /^$categorycode$/, @SingleBranchCodes ) should be replaced with any() (and @EveryBranchCodes too) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 09:28:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 07:28:00 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 --- Comment #17 from kenza --- (In reply to Srdjan Jankovic from comment #16) > Ok, then it the first patch is FAILED QA, it should be replaced with > something? Yes, by the last patch. I put the first on as obsolete. Now it should work... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 09:29:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 07:29:16 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19379|0 |1 is obsolete| | Attachment #19394|0 |1 is obsolete| | --- Comment #23 from M. de Rooy --- Created attachment 19934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19934&action=edit Bug 9032: Share a list (part 1: send the invitation) Adds a Share button for OPAC private lists. Allows you to send an invitation to share a list. Checks on validity of email addresses (with Email::Valid). NOTE: This patch adds a routine to VirtualShelves.pm but does not add a test in VirtualShelves.t. This is intentional: I will still add a test, but saw report 10290 and came across a few other problems in this unit test. Will add a patch under report 10386. Test plan: 1) Sharing depends on syspref and login. Toggle the pref OpacAllowSharingPrivateList. If enabled, you should see the Share button in OPAC/Private lists. Click on the Share button. You should get Share a list. Logout and try to go back to opac/opac-shareshelf.pl It should now present you the login form. 2) Try to share a public list or a list you do not own. Find a security hole in the interface. Or hack the shareshelf URL and replace the shelfnumber with a public list number. 3) Enter no email address or invalid ones (no domain, forbidden chars). If you enter no address, submit should not work. If you enter only wrong addresses (separated by: ,:; ), you get a message. 4) Test if sending the invitation works. Share one of your private lists. Enter your own email address. After your proc_message_queue cronjob ran, you should have an email. Check also if you see a new record in the virtualshelfshares table. Note that the followup patch handles the second part of accepting this share. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 09:29:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 07:29:24 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #24 from M. de Rooy --- Created attachment 19935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19935&action=edit Bug 9032 [Template follow-up] Share a list (part 1: send the invitation) This patch makes a few changes to the "share a list" template: - We don't use tables for layout of forms. This patch corrects the display of the share form to use Koha standard form markup. - Revise the confirmation message displayed after a list is shared to be more readable. - Add a link back to private lists to the confirmation message. - Add T:T markup to make this page display the left-hand navigation which is shown on other patron-related pages when a user is logged in. To test, apply this patch on top of other patches pending for Bug 9032 and confirm that the list share form looks correct and works correctly. Confirm that share confirmation page reads well. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 09:30:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 07:30:20 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #25 from M. de Rooy --- Rebased the last two patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 09:31:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 07:31:23 +0000 Subject: [Koha-bugs] [Bug 10441] UT: Testing AddShare in VirtualShelves.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10386 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 09:31:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 07:31:23 +0000 Subject: [Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10441 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 09:35:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 07:35:04 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 --- Comment #18 from Srdjan Jankovic --- Tests passed, however I got Use of uninitialized value $calculated in substitution (s///) at C4/Serials.pm line 988. Use of uninitialized value $pattern in numeric eq (==) at C4/Serials.pm line 991. Use of uninitialized value $calculated in substitution (s///) at C4/Serials.pm line 1000. Use of uninitialized value $calculated in substitution (s///) at C4/Serials.pm line 1003. Use of uninitialized value $serialseq in string at C4/Serials.pm line 1391. Do I need any data from that infamous patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 09:43:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 07:43:29 +0000 Subject: [Koha-bugs] [Bug 10441] UT: Testing AddShare in VirtualShelves.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441 --- Comment #10 from M. de Rooy --- Created attachment 19936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19936&action=edit Bug 10441: QA Followup for Virtualshelves.t As requested by Jonathan: Replace a i++ construct by 0..9; added a space to similar constructs. Change ok-calls by is-calls where applicable. Signed-off-by: Marcel de Rooy 83 tests still pass, no complaints from koha-qa. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 09:43:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 07:43:49 +0000 Subject: [Koha-bugs] [Bug 10630] DelBookseller's return value needs to be more explicit in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19927|0 |1 is obsolete| | --- Comment #2 from kenza --- Created attachment 19937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19937&action=edit Bug 10630: DelBookseller's always returns undef in C4::Bookseller.pm This patch makes DelBookseller returns the number of supplier it has deleted or undef if nothing has been deleted. It also fixes a test which doesn't pass before in t/db_dependent/Bookseller.t To test: prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. 1/54 All tests successful. Files=1, Tests=54, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.48 cusr 0.02 csys = 0.52 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 09:49:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 07:49:55 +0000 Subject: [Koha-bugs] [Bug 10640] New: ModBookseller needs more explicit return values in C4::Bookseller.pm Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10640 Bug ID: 10640 Summary: ModBookseller needs more explicit return values in C4::Bookseller.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kenza.zaki at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 09:50:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 07:50:41 +0000 Subject: [Koha-bugs] [Bug 10640] ModBookseller needs more explicit return values in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10640 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kenza.zaki at biblibre.com Depends on| |10528 Assignee|koha-bugs at lists.koha-commun |kenza.zaki at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 09:50:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 07:50:41 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10640 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 09:52:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 07:52:06 +0000 Subject: [Koha-bugs] [Bug 10630] DelBookseller's return value needs to be more explicit in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10640 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 09:52:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 07:52:06 +0000 Subject: [Koha-bugs] [Bug 10640] ModBookseller needs more explicit return values in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10640 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10630 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 10:07:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 08:07:41 +0000 Subject: [Koha-bugs] [Bug 10640] ModBookseller needs more explicit return values in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10640 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 10:07:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 08:07:44 +0000 Subject: [Koha-bugs] [Bug 10640] ModBookseller needs more explicit return values in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10640 --- Comment #1 from kenza --- Created attachment 19938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19938&action=edit ModBookseller needs more explicit return values in C4::Bookseller.pm Before, ModBookseller always returns undef. This patch modifies it in order to be more explicit. Now it returns : 1 -> If a modification has been done 0E0 -> If the given id doesn't exist undef -> If no id given It also fix one of the tests which didn't pass before in t/db_dependent/Bookseller.t To Test: prove db_dependent/Bookseller. Bookseller.t .. 1/55 [Some warnings about uninitialized values] t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=55, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.46 cusr 0.04 csys = 0.53 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 10:13:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 08:13:01 +0000 Subject: [Koha-bugs] [Bug 10640] ModBookseller needs more explicit return values in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10640 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10630 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 10:13:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 08:13:01 +0000 Subject: [Koha-bugs] [Bug 10630] DelBookseller's return value needs to be more explicit in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10640 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 10:20:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 08:20:43 +0000 Subject: [Koha-bugs] [Bug 10640] ModBookseller needs more explicit return values in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10640 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19938|0 |1 is obsolete| | --- Comment #2 from kenza --- Created attachment 19939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19939&action=edit ModBookseller needs more explicit return values in C4::Bookseller.pm Before, ModBookseller always returns undef. This patch modifies it in order to be more explicit. Now it returns : 1 -> If a modification has been done 0E0 -> If the given id doesn't exist undef -> If no id given It also fix one of the tests which didn't pass before in t/db_dependent/Bookseller.t To Test: prove db_dependent/Bookseller. Bookseller.t .. 1/54 [Some warnings about uninitialized values] t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=54, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.46 cusr 0.04 csys = 0.53 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 10:22:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 08:22:33 +0000 Subject: [Koha-bugs] [Bug 10641] New: GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherence Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641 Bug ID: 10641 Summary: GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherence Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kenza.zaki at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 10:23:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 08:23:15 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10641 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 10:23:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 08:23:15 +0000 Subject: [Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherence In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kenza.zaki at biblibre.com Depends on| |10528 Assignee|koha-bugs at lists.koha-commun |kenza.zaki at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 10:51:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 08:51:34 +0000 Subject: [Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|GetBooksellerWithLateOrders |GetBooksellerWithLateOrders |in C4::Bookseller.pm has |in C4::Bookseller.pm has |some incoherence |some incoherences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 10:56:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 08:56:08 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19193|0 |1 is obsolete| | --- Comment #13 from M. de Rooy --- Created attachment 19940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19940&action=edit Bug 9788: Improvements when calling GetReservesFromItemnumber Description: GetReservesFromItemnumber also returns waiting date. Simplifies some code. Improves item status display on catalogue detail, when placing a hold at opac-reserve and in staff, and on transfers to receive form. This patch builds on work from reports 9367 and 9761. Test plan: Place a future next-av. hold (enable future holds prefs), say 2 days ahead. Check item status on catalogue detail. Nothing to see. Enable ConfirmFutureHolds by inserting a number of days, say 2. Confirm earlier hold by checking it in. Look at item status again on detail. Switch to other opac user. Try to place a hold again. Check item status with item level hold info. Try to place hold in staff, check item level status. Make a transfer for that item. Switch branch. Look at transfers to receive. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 10:56:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 08:56:15 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19194|0 |1 is obsolete| | --- Comment #14 from M. de Rooy --- Created attachment 19941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19941&action=edit Bug 9788: Followup for expirationdate in Letter.pm Pasting comment from the Bugzilla report: Looking bit longer at this code, it is kind of strange to find it there in the first place. Adding maxpickupdelay in Letters.pm should not be there, but it is.. Also this date is not used normally in the default HOLD Available for Pickup notice (that we are generating in this case). And if it would be undef, the expiration date should imo be empty instead of today+0. (before adding maxreservespickupdelay, you should test the allowexpire pref first) So it is an (invisible) bug on its own. Test plan: See former patch. Kyle just discovered this bug, apparently by deleting the maxpickupdelay pref.. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 11:00:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 09:00:09 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #15 from M. de Rooy --- Rebased both patches (for changes from bug 9394). Tested them again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 11:02:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 09:02:59 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 11:03:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 09:03:07 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19940|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 11:03:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 09:03:12 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19941|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 11:03:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 09:03:56 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #16 from M. de Rooy --- Still see something. Will submit again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 11:13:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 09:13:47 +0000 Subject: [Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641 --- Comment #1 from kenza --- Created attachment 19942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19942&action=edit Bug 10641 - GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences This patch fixes some incoherences of the routine GetBooksellerWithOrders. Now it considers the field $estimateddeliverydateto and it replaces it by now() only if it is undef. More it doesn't test if $aqbookseller.deliverytime is not Null anymore but if $deliverytime = null or undef, it replaces it by 0. It also verifies if $delay is >= 0 and return undef if it is a negative value. To Test: prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. [Some warnings about uninitialized values] WARNING: GetBooksellerWithLateOrders is called with a negative value at C4/Bookseller.pm line 135. t/db_dependent/Bookseller.t .. ok All tests successful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 11:13:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 09:13:45 +0000 Subject: [Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 11:38:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 09:38:17 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19941|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 11:49:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 09:49:40 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 --- Comment #19 from kenza --- (In reply to Srdjan Jankovic from comment #18) > Tests passed, however I got > Use of uninitialized value $calculated in substitution (s///) at > C4/Serials.pm line 988. > Use of uninitialized value $pattern in numeric eq (==) at C4/Serials.pm line > 991. > Use of uninitialized value $calculated in substitution (s///) at > C4/Serials.pm line 1000. > Use of uninitialized value $calculated in substitution (s///) at > C4/Serials.pm line 1003. > Use of uninitialized value $serialseq in string at C4/Serials.pm line 1391. > > Do I need any data from that infamous patch? No , these warnings are normal, the initialization of these values is useless for this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 11:52:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 09:52:10 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #17 from M. de Rooy --- Created attachment 19943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19943&action=edit Bug 9788: Improvements when calling GetReservesFromItemnumber Description: GetReservesFromItemnumber also returns waiting date. Simplifies some code. Improves item status display on catalogue detail, when placing a hold at opac-reserve and in staff, and on transfers to receive form. This patch builds on work from reports 9367 and 9761. Test plan: Place a future next-av. hold (enable future holds prefs), say 2 days ahead. Check item status on catalogue detail. Nothing to see. Enable ConfirmFutureHolds by inserting a number of days, say 2. Confirm earlier hold by checking it in. Look at item status again on detail. Switch to other opac user. Try to place a hold again. Check item status with item level hold info. Try to place hold in staff, check item level status. Make a transfer for that item. Switch branch. Look at transfers to receive. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 11:52:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 09:52:43 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19941|0 |1 is obsolete| | --- Comment #18 from M. de Rooy --- Created attachment 19944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19944&action=edit Bug 9788: Followup for expirationdate in Letter.pm Pasting comment from the Bugzilla report: Looking bit longer at this code, it is kind of strange to find it there in the first place. Adding maxpickupdelay in Letters.pm should not be there, but it is.. Also this date is not used normally in the default HOLD Available for Pickup notice (that we are generating in this case). And if it would be undef, the expiration date should imo be empty instead of today+0. (before adding maxreservespickupdelay, you should test the allowexpire pref first) So it is an (invisible) bug on its own. Test plan: See former patch. Kyle just discovered this bug, apparently by deleting the maxpickupdelay pref.. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 11:53:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 09:53:39 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #19 from M. de Rooy --- Ready for QA again. Note that they depend on bug 9761. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 13:27:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 11:27:46 +0000 Subject: [Koha-bugs] [Bug 10621] Subscription alert emails have wrong from-address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10621 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from M. de Rooy --- I was following your test plan, but it looks like there is some bug in sending alerts that makes your test plan fail (although it is (far) outside the scope of your report). Just following the code, I note the following: Serials/ModSerialStatus calls Letters/SendAlerts Letters/SendAlerts calls getalert to get a list of email addresses for that subscription. Sub getalert does however look in table alert (it is empty in my case), and does not send anything. Note that the routing list is found in table subscriptionroutinglist (that was not empty for me). So I cannot fail this patch, but the test plan does not work out for me. So I would like to ask patch author and signer: How did you manage to test this? Because we stumble over another bug.. How is it possible that existing code here looks for email addresses in the wrong table?? Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 13:30:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 11:30:35 +0000 Subject: [Koha-bugs] [Bug 10621] Subscription alert emails have wrong from-address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10621 --- Comment #5 from M. de Rooy --- I realize now that I was not subscribing via opac but via staff. Will have another try :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 13:34:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 11:34:59 +0000 Subject: [Koha-bugs] [Bug 10621] Subscription alert emails have wrong from-address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10621 --- Comment #6 from M. de Rooy --- (In reply to M. de Rooy from comment #5) > I realize now that I was not subscribing via opac but via staff. Will have > another try :) And of course, that works fine ;) Well, at least learned something more about the code here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 13:39:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 11:39:03 +0000 Subject: [Koha-bugs] [Bug 10621] Subscription alert emails have wrong from-address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10621 --- Comment #7 from M. de Rooy --- QA Comment: Simple patch. Have been testing this very well :) with lots of arriving issues, and debugging statements.. Looks good to me now. No complaints from koha-qa. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 13:39:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 11:39:23 +0000 Subject: [Koha-bugs] [Bug 10621] Subscription alert emails have wrong from-address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10621 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 13:39:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 11:39:25 +0000 Subject: [Koha-bugs] [Bug 10621] Subscription alert emails have wrong from-address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10621 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19923|0 |1 is obsolete| | --- Comment #8 from M. de Rooy --- Created attachment 19945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19945&action=edit Bug 10621 Subscription alert emails have wrong from-address From-address and to-address were the same (patron's email) for subscription alerts. This patch changes 'from' the branch or kohaadminemailaddress To test - add a subscription in staff/serials in case you don't have any - enable patron notifications or the subscription - in the OPAC, subscribe to the serial - in staff/serial, receive an issue of the serial Before applying the patch, the email that is supposed to be sent has the patron's email as 'from' and 'to' (and is likely to fail). If you follow the steps after applying the patch, the email alert should have the 'from' address of the patron's branch or kohaadminemiladdress -- which should also work fine with the MTA/SMTP you have set up for messaging. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 13:39:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 11:39:39 +0000 Subject: [Koha-bugs] [Bug 10621] Subscription alert emails have wrong from-address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10621 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 13:39:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 11:39:49 +0000 Subject: [Koha-bugs] [Bug 10621] Subscription alert emails have wrong from-address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10621 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 13:41:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 11:41:17 +0000 Subject: [Koha-bugs] [Bug 10642] New: Inappropriate uses of $sth->finish() in C4::RotatingCollections.pm Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10642 Bug ID: 10642 Summary: Inappropriate uses of $sth->finish() in C4::RotatingCollections.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kenza.zaki at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 13:41:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 11:41:38 +0000 Subject: [Koha-bugs] [Bug 10642] Inappropriate uses of $sth->finish() in C4::RotatingCollections.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10642 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kenza.zaki at biblibre.com Assignee|gmcharlt at gmail.com |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 13:51:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 11:51:42 +0000 Subject: [Koha-bugs] [Bug 10642] Inappropriate uses of $sth->finish() in C4::RotatingCollections.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10642 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 13:51:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 11:51:45 +0000 Subject: [Koha-bugs] [Bug 10642] Inappropriate uses of $sth->finish() in C4::RotatingCollections.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10642 --- Comment #1 from kenza --- Created attachment 19946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19946&action=edit Bug 10642 : Inappropriate uses of $sth->finish() in C4::RotatingCollections.pm >From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 13:54:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 11:54:58 +0000 Subject: [Koha-bugs] [Bug 10643] New: Inappropriate uses of $sth->finish() in C4::ClassSource.pm Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643 Bug ID: 10643 Summary: Inappropriate uses of $sth->finish() in C4::ClassSource.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kenza.zaki at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 13:55:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 11:55:43 +0000 Subject: [Koha-bugs] [Bug 10643] Inappropriate uses of $sth->finish() in C4::ClassSource.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kenza.zaki at biblibre.com Assignee|gmcharlt at gmail.com |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 14:04:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 12:04:00 +0000 Subject: [Koha-bugs] [Bug 10463] Quote of the day feature not selecting random quotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10463 --- Comment #3 from M. de Rooy --- Created attachment 19947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19947&action=edit Bug 10463 - Quote of the day feature not selecting random quotes When the Quote of the Day tool selects a new new quote, it updates the timestamp and does not take the timezone into account. Thus the time is set to +4 hours (e.g. 2013-06-11 13:33:48 when the time is 2013-06-11 09:33:48). It then repeats the same quote every day. To replicate: set Administration >> System preferences >> OPAC preferences >> Features >> QuoteOfTheDay to Enable In Home >> Tools >> Quote Editor, add several quotes. In the opac, refresh the home page. You should get a quote of the day at the top. mysql> select * from quotes; note the timestamp of the quote selected by the tool. It will not match the date on the machine. If you change the date to the previous date and refresh the opac, the tool wlill select another quote, which will not change unless forced. Test Plan: 1) Remove all your quotes and import a fresh set 2) Enable the quote of the day and view the opac 3) Look at your quotes table and note the timestamp is incorrect 4) Repeat steps 1 and 2 5) Look at your quotes table and note the timestamp is now correct Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 14:04:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 12:04:33 +0000 Subject: [Koha-bugs] [Bug 10463] Quote of the day feature not selecting random quotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10463 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 14:04:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 12:04:35 +0000 Subject: [Koha-bugs] [Bug 10463] Quote of the day feature not selecting random quotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10463 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19711|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 14:04:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 12:04:45 +0000 Subject: [Koha-bugs] [Bug 10463] Quote of the day feature not selecting random quotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10463 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 14:05:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 12:05:14 +0000 Subject: [Koha-bugs] [Bug 10463] Quote of the day feature not selecting random quotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10463 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 14:05:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 12:05:27 +0000 Subject: [Koha-bugs] [Bug 10463] Quote of the day feature not selecting random quotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10463 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 14:06:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 12:06:52 +0000 Subject: [Koha-bugs] [Bug 10643] Inappropriate uses of $sth->finish() in C4::ClassSource.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 14:06:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 12:06:55 +0000 Subject: [Koha-bugs] [Bug 10643] Inappropriate uses of $sth->finish() in C4::ClassSource.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643 --- Comment #1 from kenza --- Created attachment 19948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19948&action=edit Bug 10643: Inappropriate uses of $sth->finish() in C4::ClassSource.pm >From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to "finish" after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 14:08:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 12:08:32 +0000 Subject: [Koha-bugs] [Bug 10463] Quote of the day feature not selecting random quotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10463 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from M. de Rooy --- QA Comment: Looks good to me. No koha-qa complaints.. Not blocking this patch, but just wondering why we are continuously updating the timestamp of the selected quote for everyone hitting the opac. We do not need a timestamp here, but just a date. And only the first user of the day should trigger a table update. After that no updates are needed for the rest of the day.. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 14:16:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 12:16:06 +0000 Subject: [Koha-bugs] [Bug 10463] Quote of the day feature not selecting random quotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10463 --- Comment #5 from M. de Rooy --- (In reply to M. de Rooy from comment #4) > Not blocking this patch, but just wondering why we are continuously updating > the timestamp of the selected quote for everyone hitting the opac. We do not > need a timestamp here, but just a date. And only the first user of the day > should trigger a table update. After that no updates are needed for the rest > of the day.. This is not a correct observation however. So just ignore it.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 14:35:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 12:35:30 +0000 Subject: [Koha-bugs] [Bug 10644] New: C4::ClassSource.pm needs unit tests Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10644 Bug ID: 10644 Summary: C4::ClassSource.pm needs unit tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: kenza.zaki at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 14:35:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 12:35:46 +0000 Subject: [Koha-bugs] [Bug 10644] C4::ClassSource.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10644 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kenza.zaki at biblibre.com Assignee|gmcharlt at gmail.com |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 15:28:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 13:28:18 +0000 Subject: [Koha-bugs] [Bug 10644] C4::ClassSource.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10644 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 15:56:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 13:56:08 +0000 Subject: [Koha-bugs] [Bug 10621] Subscription alert emails have wrong from-address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10621 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Mirko! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 17:05:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 15:05:34 +0000 Subject: [Koha-bugs] [Bug 10463] Quote of the day feature not selecting random quotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10463 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 17:12:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 15:12:32 +0000 Subject: [Koha-bugs] [Bug 10189] French values in cataloging plugins for unimarc 128b and 128c fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10189 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 17:13:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 15:13:10 +0000 Subject: [Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #20 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks Galen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 17:14:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 15:14:53 +0000 Subject: [Koha-bugs] [Bug 9770] C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9770 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com Version|unspecified |master --- Comment #13 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks Jason! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 17:15:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 15:15:44 +0000 Subject: [Koha-bugs] [Bug 10356] adding date published to catalogue detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10356 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks Chris! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 17:16:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 15:16:55 +0000 Subject: [Koha-bugs] [Bug 10448] Changing framework when cataloguing clears all fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10448 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 17:18:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 15:18:36 +0000 Subject: [Koha-bugs] [Bug 10514] Add item link on acquisitions add item is too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10514 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks everyone involved! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 17:56:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 15:56:57 +0000 Subject: [Koha-bugs] [Bug 10070] History of anonymous searches is not kept In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #20 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 19:07:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 17:07:48 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks Adrien! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 19:09:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 17:09:52 +0000 Subject: [Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 19:12:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 17:12:25 +0000 Subject: [Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 19:13:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 17:13:22 +0000 Subject: [Koha-bugs] [Bug 10275] UT: OrderFromSubscription.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10275 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 19:14:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 17:14:48 +0000 Subject: [Koha-bugs] [Bug 10499] UT: VirtualShelves.t needs a database transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10499 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks Kenza! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 19:15:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 17:15:23 +0000 Subject: [Koha-bugs] [Bug 10575] UT: GetOrdersByBiblionumber.t needs a database transaction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10575 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks Kenza! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 19:16:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 17:16:33 +0000 Subject: [Koha-bugs] [Bug 10504] C4::Acquisition::ModOrderItem is unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #16 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 19:17:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 17:17:07 +0000 Subject: [Koha-bugs] [Bug 10527] C4::Branch::get_branch_code_from_name is useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10527 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 19:18:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 17:18:07 +0000 Subject: [Koha-bugs] [Bug 10422] Remove references to unused and non-existent wizard.css In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10422 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 19:19:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 17:19:51 +0000 Subject: [Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #52 from Tom?s Cohen Arazi --- Follow up has been pushed to 3.12.x, will be in 3.12.3. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 20:19:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 18:19:33 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19933|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 19949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19949&action=edit Provide two system preferences to flexibly override OpacHiddenItems As per Srdjan Jankovic's suggestion to use any instead of grep. The patch has been tweaked accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 20:25:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 18:25:30 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 20:25:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 18:25:30 +0000 Subject: [Koha-bugs] [Bug 10627] history of reports run/results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10627 --- Comment #4 from Claire Elliott --- (In reply to Galen Charlton from comment #3) > ...could you describe a workflow or two that you would like involving saved > report output? The obvious one is simply the ability to go back and view or > save the results of a past report run, but I'd like to suss out whether there > are other things that you are used to doing with saved reports. Sorry for the delayed response, but I wanted to confer with my colleague in cataloguing before getting back to you. >From my discussion with her, I am confident in saying that the main reason we appreciate these reports is that they allow us to compare results from one run to the next. To be precise, they are useful because they tell us (a) exactly how/what we searched to get a particular list of results or how we approached a certain system task/modification (meaning we can duplicate the same search/process to produce comparable results), and (b) they preserve the actual results of a search or action carried out at a specific point in time. In brief, we don?t run/save a report with the intent to manipulate/re-format the content for some further purpose, so can?t claim that there is any other ?workflow? that depends on these already-run ?Reports?/?Tools?? They are really just there to consult, and to provide us with a valuable record of what we have done on the system and how the collection is evolving. That said, having now opened this thread, I feel I should confess that, as newcomers to Koha, we still need and fully intend to do a bit more homework to determine whether we can achieve most of our needs by using, or building new Reports and querying existing log(s) data. At first glance, this option did not appear sufficient to us, but we can't claim to have investigated it thoroughly. Thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 21:09:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 19:09:34 +0000 Subject: [Koha-bugs] [Bug 10645] New: Missing zebra languages in koha-create manpage Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10645 Bug ID: 10645 Summary: Missing zebra languages in koha-create manpage Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 21:11:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 19:11:31 +0000 Subject: [Koha-bugs] [Bug 10645] Missing zebra languages in koha-create manpage In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10645 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 21:11:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 19:11:35 +0000 Subject: [Koha-bugs] [Bug 10645] Missing zebra languages in koha-create manpage In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10645 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 19950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19950&action=edit Bug 10645: Missing zebra languages in koha-create manpage There where some missing zebra language options in the man page for koha-create. Trivial string change. To+ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 21:42:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 19:42:02 +0000 Subject: [Koha-bugs] [Bug 9916] Use DataTables in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9916 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 21:42:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 19:42:06 +0000 Subject: [Koha-bugs] [Bug 9916] Use DataTables in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9916 --- Comment #1 from Owen Leonard --- Created attachment 19951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19951&action=edit Bug 9916 - Use DataTables in the OPAC The OPAC still uses the old tablesorter plugin which isn't being actively maintained. We use DataTables in the staff client and should in the OPAC too. The plugin was added a while ago but never implemented on any pages. This patch upgrades the plugin to the latest version and places it in opac-tmpl/lib for cross-theme access. The patch implements DataTables on all pages which previously used the tablesorter plugin. The old tablesorter plugin is removed. The customized DataTable configuration script, datatables.js, has been trimmed-down from the staff client version in order to limit it to only that functionality required in the OPAC. Sorting based on date is done based on the data's enclosing title attribute as it is in the staff client: [% date | $KohaDates %] Slight modifications to Serials.pm and opac-search-history.pl have been made to accommodate this change. To test, view each page in the OPAC which uses JS-based table sorting: - The bibliographic detail page - The cart - The search history page - The suggestions page - The tags page (logged in as a user who has entered tags) - The "most popular" page (opac-topissues.pl) - The logged in user summary page (opac-user.pl) - The subscription "full history" page (opac-serial-issues.pl?selectview=full) - The self-checkout main page (with existing checkouts) Table sorting should work correctly on all pages in both the prog and ccsr themes. Sorting should work for dates whatever your dateformat system preference setting. Tables listing titles should exclude articles ("a," "an," and "the" in English) when sorting. Also test the serial collection page in the staff client, which is affected by the change to Serials.pm. Confirm that dates are displayed and sorted correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 21:56:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 19:56:16 +0000 Subject: [Koha-bugs] [Bug 10646] New: mod_rewrite should be enabled by the postinst script Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 Bug ID: 10646 Summary: mod_rewrite should be enabled by the postinst script Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 22:23:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 20:23:11 +0000 Subject: [Koha-bugs] [Bug 10646] mod_rewrite should be enabled by the postinst script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 22:23:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 20:23:17 +0000 Subject: [Koha-bugs] [Bug 10646] mod_rewrite should be enabled by the postinst script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 19952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19952&action=edit Bug 10646: mod_rewrite should be enabled by the postinst script This patch makes the post install scripts used by the .deb packages enable the mod_rewrite module (which is mandatory if you want to run Koha). It tests the module isn't already enabled, and enables if necesary, and reloads Apache configuration. To test: - Install current koha-common packages on a fresh setup. Make sure you have mod_rewrite disabled (its the default if you didn't have apache and it was just pulled by koha-common at least on Ubuntu 12.04). Run $ a2dismod rewrite to make sure it is disabled on your test box. Create a new koha instance like this: $ koha-create --create-db name You'll get an error like this: Syntax error on line 76 of /etc/koha/apache-shared.conf: Invalid command 'RewriteEngine', perhaps misspelled or defined by a module not included in the server configuration Action 'configtest' failed. The Apache error log may have more information. ...fail! , build your own packages, make sure you have mod_rewrite disabled (which is the default on Ubuntu 12.04 at least), and install the package. Create a new instance issuing: - Apply the patch, build your packages, repeat: No apache warning about the rewrite module. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 25 23:01:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 21:01:55 +0000 Subject: [Koha-bugs] [Bug 10210] how to checkout an item without barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10210 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |liz at catalyst.net.nz Resolution|--- |WONTFIX --- Comment #1 from Liz Rea --- The easiest way to do this would be to put the accession number in the item's barcode field, and simply type in the number when you want to issue an item. As this is not a bug, I am closing this as resolved (wontfix). Cheers, Liz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 00:50:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 22:50:42 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 00:50:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 22:50:47 +0000 Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19874|0 |1 is obsolete| | --- Comment #20 from Srdjan Jankovic --- Created attachment 19953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19953&action=edit [SIGNED-OFF] C4::Bookseller.pm need unit tests The tests are wrap in a transaction. NOTE: some tests should pass but doesn't because of incoherences in the code. These tests are in comments and preceded by FIXME Test plan: prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. 15/53 [Some warnings about uninitialised values] t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=53, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.46 cusr 0.03 csys = 0.51 CPU) Result: PASS http://bugs.koha-community.org/show_bug.cgi?id=10528 Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 01:11:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 25 Jul 2013 23:11:32 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #10 from Srdjan Jankovic --- IT works and I will sign it of, however I need to raise two things (should have done earlier, but occurred to me when testing): 1. Not sure if it is appropriate to put default values for those sysprefs 2. This should really go to issuing rules. OpacHiddenItems is just horrible. I understand the grief, maybe create another bug request for moving those sysprefs to issuingrules. If done properly, it should obsolete OpacHiddenItems in most cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 02:06:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 00:06:26 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 02:06:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 00:06:28 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 --- Comment #11 from Srdjan Jankovic --- Created attachment 19954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19954&action=edit [SIGNED-OFF] Bug 10589 - Override OpacHiddenItems based on Patron Category Two system preferences, PatronSingleBranch and PatronEveryBranch, have been added to facilitate some granularity on the override. If the home branch of the item and the patron match and the catgegory code of the patron matches one of the pipe delimited values in the PatronSingleBranch patron category code, then an item which would normally be hidden will be visible. If the patron category matches one of the pipe delimited values in the PatronEveryBranch patron category, then every item hidden by OpacHiddenItems will be visible. Since the patron category codes used by default for these two system preferences are not added, OpacHiddenItems will continue function as expected until individual patrons and system preferences are configured. There is no need to provide this functionality to staff, as they have access to the staff client. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 03:57:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 01:57:09 +0000 Subject: [Koha-bugs] [Bug 10498] Place Hold on Order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10498 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #5 from Srdjan Jankovic --- CONFLICT (content): Merge conflict in reserve/request.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 05:47:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 03:47:26 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19949|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Comment on attachment 19949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19949 Provide two system preferences to flexibly override OpacHiddenItems Obsoleted the patch which is not signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 05:50:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 03:50:54 +0000 Subject: [Koha-bugs] [Bug 10472] Receipt by line or invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10472 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #2 from Srdjan Jankovic --- Amit, Would you consider moving the query to C4::Acquisition please? Also, it is slightly nicer to say my $count = $dbh->selectrow_array("SELECT COUNT(*) FROM aqorders_items ...") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 05:55:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 03:55:02 +0000 Subject: [Koha-bugs] [Bug 10451] Firefox prints only first page of table with shrink to fit option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10451 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #5 from Srdjan Jankovic --- Do we need to test this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 05:56:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 03:56:30 +0000 Subject: [Koha-bugs] [Bug 10440] During receipting for any holds attached to items being receipted, to be identified during the receipting process. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10440 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #2 from Srdjan Jankovic --- Patch says Bug 10472? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 06:05:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 04:05:57 +0000 Subject: [Koha-bugs] [Bug 10424] Search against order numbers and pull up the related invoice to see when the item was receipted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10424 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 06:06:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 04:06:00 +0000 Subject: [Koha-bugs] [Bug 10424] Search against order numbers and pull up the related invoice to see when the item was receipted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10424 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19209|0 |1 is obsolete| | --- Comment #8 from Srdjan Jankovic --- Created attachment 19955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19955&action=edit [SIGNED-OFF] Bug 10424 - Search received orders Search against order numbers and pull up the related invoice to see when the item was received. This allows users to see details of received orders, including the details against which invoice the order is received. Test Plan: 1) Create a basket. 2) Create a orders under basket and close the basket. 3) Click on Receive shipment button and enter the invoice no and shipment date. 4) Click on Receive link to receive the items. 5) Click on Received orders link on the left hand side. 6) This allow user to search by orderline, basket, title, author, ISBN, vendor and date received. 7) Users will be able to see details of received orders. Sponsored-by: Staffordshire University/Halton Borough Council/PTFS Europe Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 06:13:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 04:13:33 +0000 Subject: [Koha-bugs] [Bug 10393] To add some shortcuts to acquisitions main screen e.g. RECEIVE SHIPMENT and the FILTER BOX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10393 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 06:13:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 04:13:37 +0000 Subject: [Koha-bugs] [Bug 10393] To add some shortcuts to acquisitions main screen e.g. RECEIVE SHIPMENT and the FILTER BOX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10393 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19207|0 |1 is obsolete| | --- Comment #3 from Srdjan Jankovic --- Created attachment 19956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19956&action=edit [SIGNED-OFF] Bug 10393 - Receive shipment link in acquisitions main page To add some shortcuts to acquisitions main screen e.g. RECEIVE SHIPMENT and the FILTER BOX Test plan: 1) Click on Receive shipment link on the left hand side. 2) It will give all the vendor list click on recieve shipment link to receive items. 3) For creating new basket click on "New Basket" link. Sponsored-by: Staffordshire University/Halton Borough Council/PTFS Europe Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 07:59:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 05:59:24 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18790|0 |1 is obsolete| | --- Comment #18 from David Cook --- Created attachment 19957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19957&action=edit Bug 10096 [FOLLOW-UP] - Add a z39.50 interface for authority searching This patch adds the "recordtype" column to the "z3950servers" table. The value in this column (biblio or authority) then controls whether the z3950 server shows up in a bibliographic search (through the Acq and Cataloguing modules) or in an authority search (through the Authorities module). I also edited the z3950 management console to show this value and allow users to edit it. The default value is "biblio", since the vast majority of z3950 targets will be bibliographic. However, there is an option to add/edit a z3950 target as a source of authority records. Test Plan: 1) Apply both patches 2) Run updatedatabase.pl (after setting your KOHA_CONF and PERL5 environmental variables) 3) Use the test plan from the 1st patch N.B. Make sure that your Z39.50 client target has a Record Type of Authority, otherwise it won't display when you're doing a Z3950 search for authorities. Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 08:01:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 06:01:22 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18789|0 |1 is obsolete| | --- Comment #19 from David Cook --- Created attachment 19958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19958&action=edit Bug 10096 - Add a Z39.50 interface for authority searching This patch introduces a new Z39.50 interface for searching z39.50 compliant databases for MARC authority records. These databases aren't as common as their bibliographic equivalents, but they're out there and very useful. I have included info at the bottom of this messsage for sample authority databases you can try. To test this patch: 1) Set up Z39.50 client targets for authority databases. (I've included information at the bottom of this message for LibrariesAustralia's test server for authorities as well as instructions on how to use your Koha's z39.50 authority server as well. The Library of Congress also has authority databases available (unsure if these are test or prod), and you might have access to others through OCLC or RLIN. OCLC provides login credentials for their test databases. 2) Go to the Authorities module 3) Click on the new "Z39.50 search button" 4) Select your authoriy search targets from the list (N.B. bibliographic targets will also display. These are of no use to you.) 5) Do a search for an authority you would like using either the "Raw" input box or the more specific input boxes for names, subjects, subject sub divisions, or titles. (I like searching Name (personal): Eric on the LibrariesAustralia test DB.) 6) You should see a table listing the server, heading, authority type, and two other columns (MARC and a nameless column). "Authority type" is the type of authority it will become when imported in to Koha. In the Eric example, "PERSO_NAME". 7) Click on "MARC" next to the results of interest to review the MARC authority record. 8) When you're satisfied with a record, click on "Import". 9) The pop-up window will close and your original Koha window will change to the "Adding authority Personal Name" screen (in the Eric example). 10) All the relevant fields should be filled out for the record. Review them and make any changes as necessary. (N.B. The 001 will be cleared when saved, so if you have a use for the imported control number, move it to the 010, 016, or 035 as appropriate. If you have a default value for the 003, this will also likely be overwritten. Move it if necessary. The 005 will also be updated when saved, so do not worry about that.) 11) When you're satisfied, click save. 12) Presto! You've imported your first authority record via Z39.50! -- Here is the info for the LibrariesAustralia test Z39.50 authority database: Z39.50 server: LibrariesAustralia Authorities Hostname: z3950-test.librariesaustralia.nla.gov.au Port: 210 Database: AuthTraining Userid: ANLEZ Password: z39.50 Syntax: MARC21/USMARC Encoding: utf8 - The U.S.A. Library of Congress also provides Z39.50 access to its Name and Subject Authorities (http://www.loc.gov/z3950/lcserver.html). Name Authority: Z39.50 server: Library of Congress Name Authority File Hostname: lx2.loc.gov Port: 210 Database: NAF Syntax: MARC21/USMARC Encoding: utf8 Subject Authority: Z39.50 server: Library of Congress Subject Authority File Hostname: lx2.loc.gov Port: 210 Database: SAF Syntax: MARC21/USMARC Encoding: utf8 (N.B. Both of these databases also include title authorities.) - For testing purposes, you can also set up a Z39.50 client target, which points at your own Koha instance's Z39.50 authority server. To find the hostname, go to /etc/koha-conf.xml and find the value for the element. Depending on your configuration, this could be something like the following: unix:/zebra/koha/var/run/zebradb/authoritysocket (N.B. You might be using a different scheme than unix sockets...) To find the database, scroll down to the bottom of koha-conf.xml until you reach the element. Within this, look for the value of the element . It should probably be "authorities". To set up this Z39.50 client target in Koha... Z39.50 server: my koha authorities Hostname: unix:/zebra/koha/var/run/zebradb/authoritysocket Port: Database: authorities Userid: Password: Syntax: MARC21/USMARC (or whichever flavour you need) Encoding: utf8 Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 08:01:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 06:01:35 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19957|0 |1 is obsolete| | --- Comment #20 from David Cook --- Created attachment 19959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19959&action=edit Bug 10096 [FOLLOW-UP] - Add a z39.50 interface for authority searching This patch adds the "recordtype" column to the "z3950servers" table. The value in this column (biblio or authority) then controls whether the z3950 server shows up in a bibliographic search (through the Acq and Cataloguing modules) or in an authority search (through the Authorities module). I also edited the z3950 management console to show this value and allow users to edit it. The default value is "biblio", since the vast majority of z3950 targets will be bibliographic. However, there is an option to add/edit a z3950 target as a source of authority records. Test Plan: 1) Apply both patches 2) Run updatedatabase.pl (after setting your KOHA_CONF and PERL5 environmental variables) 3) Use the test plan from the 1st patch N.B. Make sure that your Z39.50 client target has a Record Type of Authority, otherwise it won't display when you're doing a Z3950 search for authorities. Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 08:01:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 06:01:46 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18791|0 |1 is obsolete| | --- Comment #21 from David Cook --- Created attachment 19960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19960&action=edit Bug 10096 [FOLLOW-UP] - fix tabs/whitespace errors to pass QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 08:18:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 06:18:23 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #22 from David Cook --- Hey Katrin! I've finally rebased these patches! (I feel like I've levelled up my vim and git skills...also this git bz interactive is wild!) Here is a more up-to-date test plan: 0) Run updatedatabase.pl (to add "recordtype" to the z3950servers table. 1) Set up Z39.50 client targets for authority databases. (I've included information at the bottom of this message for LibrariesAustralia's test server for authorities as well as instructions on how to use your Koha's z39.50 authority server as well. The Library of Congress also has authority databases available (unsure if these are test or prod), and you might have access to others through OCLC or RLIN. OCLC provides login credentials for their test databases. N.B. Make sure that your Z39.50 client target has a Record Type of Authority, otherwise it won't display when you're doing a Z3950 search for authorities. 2) Go to the Authorities module 3) Click on the new "Z39.50 search button" 4) Select your authority search targets from the list 5) Do a search for an authority you would like using either the "Keyword" input box or the more specific input boxes for names, subjects, subject sub divisions, or titles. (I like searching Author (personal): Eric on the LibrariesAustralia test DB.) 6) You should see a table listing the server, heading, authority type, and two other columns (MARC and a nameless column). "Authority type" is the type of authority it will become when imported in to Koha. In the Eric example, "PERSO_NAME". 7) Click on "MARC" next to the results of interest to review the MARC authority record. 8) When you're satisfied with a record, click on "Import". 9) The pop-up window will close and your original Koha window will change to the "Adding authority Personal Name" screen (in the Eric example). 10) All the relevant fields should be filled out for the record. Review them and make any changes as necessary. (N.B. The 001 will be cleared when saved, so if you have a use for the imported control number, move it to the 010, 016, or 035 as appropriate. If you have a default value for the 003, this will also likely be overwritten. Move it if necessary. The 005 will also be updated when saved, so do not worry about that.) 11) When you're satisfied, click save. 12) Presto! You've imported your first authority record via Z39.50! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 08:38:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 06:38:35 +0000 Subject: [Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 --- Comment #4 from David Cook --- (In reply to Srdjan Jankovic from comment #3) > & is a reserved character in urls, and should not be replaced with & Do you have a source for that Srdjan? It's not that I doubt you, but it's a subject that I've pondered and tried researching many times. If you look elsewhere in Koha, you'll notice query strings that use the & entity instead of &. In terms of XHTML validation, I've seen/heard of issues with validation when there are links that use & instead of &. Browsers seem to handle & just fine instead of &. Examples of & over &: admin/z3950servers.tt opac-detail.tt opac-results.tt etc... Even if that is the case though, I'm sure that could be added in a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 12:09:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 10:09:07 +0000 Subject: [Koha-bugs] [Bug 10647] New: OPAC MARC plain view only working for MARC21 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Bug ID: 10647 Summary: OPAC MARC plain view only working for MARC21 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 9570 introduced the MARC flavor for OPAC MARC plain view, which was using MARC21slim2OPACMARCdetail.xsl. The bug is that there are no files for UNIMARC and NORMARC flavors in actual sources. Seems like MARC21slim2OPACMARCdetail.xsl has nothing specific to MARC21 flavor. Should there be copies of MARC21slim2OPACMARCdetail.xsl named UNIMARCslim2OPACMARCdetail.xsl and NORMARCslim2OPACMARCdetail.xsl ? Or should this XSLT not depend on MARC flavor like before ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 12:09:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 10:09:36 +0000 Subject: [Koha-bugs] [Bug 9570] view plain not working in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9570 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10647 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 12:09:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 10:09:36 +0000 Subject: [Koha-bugs] [Bug 10647] OPAC MARC plain view only working for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9570 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 13:55:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 11:55:39 +0000 Subject: [Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 --- Comment #5 from Srdjan Jankovic --- It's a hairy issue HTML an HTTP stepping on each other's toes, and browsers trying to be "helpful" does not help at all. Re links, google for "html escape ampersand" or similar. However, in this case, I believe we are talking Redirect header, which is not HTML, so no escaping applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 14:43:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 12:43:36 +0000 Subject: [Koha-bugs] [Bug 10644] C4::ClassSource.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10644 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 14:43:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 12:43:38 +0000 Subject: [Koha-bugs] [Bug 10644] C4::ClassSource.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10644 --- Comment #1 from kenza --- Created attachment 19961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19961&action=edit Bug 10644: ClassSource.pm needs unit tests The tests are wrap in a database transaction. To test: prove t/db_dependent/ClassSource.t t/db_dependent/ClassSource.t .. 1/24 prepare_cached(SELECT * FROM `class_sort_rules` WHERE `class_sort_rule` = ?) statement handle DBI::st=HASH(0x92dbedc) still Active at C4/ClassSource.pm line 249 prepare_cached(SELECT * FROM `class_sources` WHERE cn_source = ?) statement handle DBI::st=HASH(0x926876c) still Active at C4/ClassSource.pm line 137 attempting to use non-existent class sorting routine routine1 prepare_cached(SELECT * FROM `class_sort_rules` WHERE `class_sort_rule` = ?) statement handle DBI::st=HASH(0x92dbedc) still Active at C4/ClassSource.pm line 249 prepare_cached(SELECT * FROM `class_sources` WHERE cn_source = ?) statement handle DBI::st=HASH(0x926876c) still Active at C4/ClassSource.pm line 137 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.12 cusr 0.01 csys = 0.15 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 14:55:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 12:55:44 +0000 Subject: [Koha-bugs] [Bug 10648] New: In records merge greatest field can not be added Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648 Bug ID: 10648 Summary: In records merge greatest field can not be added Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When merging 2 records (/cgi-bin/koha/cataloguing/merge.pl), the destination record is build using the fields and subfields checked in source records. When a field is checked, the javascript code searches in destination record a field with a greater tag number to insert new field before. When the new field tag number is greater than all existing field tag numbers, the field is not added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 15:01:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 13:01:23 +0000 Subject: [Koha-bugs] [Bug 10649] New: Upgrade DataTables and move scripts out of theme directory Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 Bug ID: 10649 Summary: Upgrade DataTables and move scripts out of theme directory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org There is a new version of DataTables. I propose to incrementally replace references to the old plugin in intranet-tmpl/prog/en/lib/jquery/plugins to an upgraded version in intranet-tmpl/lib/jquery/plugins. I also propose that templates load DataTables assets via an include file which will contain our customized configuration file (intranet-tmpl/prog/en/js/datatables.js), the translatable strings contained now in datatables-strings.inc, and the main DataTables library file. This change affects a lot of files, so I plan to do this in batches, starting with Acquisitions-related templates. Once all templates have been corrected I'll remove the scripts in intranet-tmpl/prog/en/lib/jquery/plugins which are no longer needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 15:53:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 13:53:55 +0000 Subject: [Koha-bugs] [Bug 10650] New: export merge-record.inc javascript into a file Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10650 Bug ID: 10650 Summary: export merge-record.inc javascript into a file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 9755 added a refactoring of records merge adding the include merge-record.inc. This include contains a block "mergejs" containing all JavaScript code that was in merge.tt. I propose to export this code into a js file. These are some reasons : a js file is cached by browser and development is better because editors uses the JavaScript syntax coloring. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 15:54:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 13:54:05 +0000 Subject: [Koha-bugs] [Bug 10650] export merge-record.inc javascript into a file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10650 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9755 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 15:54:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 13:54:05 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10650 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 16:36:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 14:36:22 +0000 Subject: [Koha-bugs] [Bug 10650] export merge-record.inc javascript into a file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10650 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 19962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19962&action=edit Bug 10650 - export merge-record.inc javascript into a file See commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 16:36:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 14:36:35 +0000 Subject: [Koha-bugs] [Bug 10650] export merge-record.inc javascript into a file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10650 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 16:59:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 14:59:49 +0000 Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10650 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 16:59:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 14:59:49 +0000 Subject: [Koha-bugs] [Bug 10650] export merge-record.inc javascript into a file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10650 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10648 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 17:16:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 15:16:16 +0000 Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 19963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19963&action=edit Bug 10648 - In records merge greatest field can not be added See commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 17:16:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 15:16:23 +0000 Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 17:16:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 15:16:51 +0000 Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 17:17:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 15:17:45 +0000 Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648 --- Comment #2 from Fridolyn SOMERS --- (In reply to Fridolyn SOMERS from comment #1) > Created attachment 19963 [details] [review] > Bug 10648 - In records merge greatest field can not be added This patch is based on master + Bug 10650 because this bug moves impacted code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 17:20:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 15:20:51 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 17:20:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 15:20:55 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 --- Comment #1 from Owen Leonard --- Created attachment 19964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19964&action=edit Bug 10649 - Upgrade DataTables and move scripts out of theme directory This patch adds an upgraded copy of the DataTables plugin to the jQuery plugin directory outside the theme directories. Copies of the old DataTables plugin scripts have been left in the old location while templates are incrementally updated. To test, visit each affected page in Acquisitions and confirm that table sorting still words correctly: - Acquisitions home - Acquisitions -> Late orders - Acquisitions -> Order search - Acquisitions -> Ordered (from table of available funds) - Acquisitions -> Spent (from table of available funds) - Acquisitions -> Vendor search - Acquisitions -> Vendor detail - Acquisitions -> Vendor -> Basket - Acquisitions -> Vendor -> Basket -> Add order from existing record -> Add order from suggestion -> Add order from subscription -> Add order from external source -> Add order from staged file - Acquisitions -> Vendor -> Basket groups - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Vendor -> Invoices - Acquisitions -> Vendor -> Invoices -> Invoice - Acquisitions -> Vendor -> Receive shipments - Acquisitions -> Vendor -> Receive shipments -> Receipt summary (click invoice number) Also test one or more pages which have not been modified to confirm that old DataTables assets are still in place and working (ex: Circulation, Quotes editor, Saved reports, etc.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 17:23:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 15:23:13 +0000 Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648 --- Comment #3 from Fridolyn SOMERS --- Created attachment 19965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19965&action=edit [3.12.x] Bug 10648 - In records merge greatest field can not be added Same patch for 3.12.x and lower. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 17:29:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 15:29:31 +0000 Subject: [Koha-bugs] [Bug 10651] New: Use new DataTables include in administration templates Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10651 Bug ID: 10651 Summary: Use new DataTables include in administration templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 10649 Administration templates which use the DataTables plugin should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 17:29:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 15:29:31 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10651 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 18:15:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 16:15:49 +0000 Subject: [Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 26 19:04:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 17:04:47 +0000 Subject: [Koha-bugs] [Bug 10647] OPAC MARC plain view only working for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10647 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #1 from Galen Charlton --- (In reply to Fridolyn SOMERS from comment #0) > Seems like MARC21slim2OPACMARCdetail.xsl has nothing specific to MARC21 > flavor. I agree. > Should there be copies of MARC21slim2OPACMARCdetail.xsl named > UNIMARCslim2OPACMARCdetail.xsl and NORMARCslim2OPACMARCdetail.xsl ? > Or should this XSLT not depend on MARC flavor like before ? I think for this one the XSLT should not depend on the MARC flavor, unless somebody can point to examples where the convention for display plain tagged views of a MARC record are different for the UNIMARC community. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 27 01:13:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 26 Jul 2013 23:13:18 +0000 Subject: [Koha-bugs] [Bug 9195] nav overlaps lists in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9195 bondiurbano changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc at gmail.com --- Comment #4 from bondiurbano --- Also needs to fit cloud-tags page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 27 20:31:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Jul 2013 18:31:29 +0000 Subject: [Koha-bugs] [Bug 10609] Use branch name rather than branch code in serials-collection.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19803|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Created attachment 19966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19966&action=edit Bug 10609 - Use branch name rather than branch code in serials-collection.pl The serials collection page displays branchcode instead of library name. This patch uses the Branches template plugin to display the library name instead. Also corrected: Added missing datatables config include to prevent a JavaScript error. To test, view the serials collection page for a subsciption with existing issues. Library names should be displayed instead of branchcodes. There should be no JavaScript errors reported by the browser. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 27 20:31:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Jul 2013 18:31:49 +0000 Subject: [Koha-bugs] [Bug 10609] Use branch name rather than branch code in serials-collection.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 27 20:57:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Jul 2013 18:57:07 +0000 Subject: [Koha-bugs] [Bug 10349] Don't show empty Descriptions/Title notes tabs in OPAC and staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10349 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18553|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Created attachment 19967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19967&action=edit Bug 10349 - Don't show empty Descriptions/Title notes tabs in OPAC and staff The descriptions/title notes tab appears on the detail page in both staff client and OPAC even if there are no notes. This is probably a relic of the pre-T:T days when it wasn't possible to use || in an IF. This patch adds a check for the various variables which might trigger the display of the tab. To test, apply the patch and view records in the OPAC and staff client which do and do not have title notes attached (whether that be in the MARC reocrd or in the biblio.notes column). In the OPAC Syndetics content should also be tested if possible. The descriptions/title notes tab should only appear if there is content. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 27 20:57:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Jul 2013 18:57:26 +0000 Subject: [Koha-bugs] [Bug 10349] Don't show empty Descriptions/Title notes tabs in OPAC and staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10349 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 27 21:34:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Jul 2013 19:34:35 +0000 Subject: [Koha-bugs] [Bug 10330] Rename system preference authoritysep to AuthoritySeperator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 27 23:34:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Jul 2013 21:34:15 +0000 Subject: [Koha-bugs] [Bug 10574] Remove the message about upgrading to 3.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19570|0 |1 is obsolete| | --- Comment #4 from Mirko Tietgen --- Created attachment 19968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19968&action=edit Bug 10574 - mute the "upgrading from 3.2" message New installs get the message about running a script if upgrading from 3.2. They shouldn't. This silences this message in all cases except when you actually are upgrading from 3.2. Test plan: There are three scenarios to test: 1) A fresh install should not cause the prompt. 2) An upgrade with or without the debconf entry set should not cause the prompt. 3) An upgrade from a 3.2 release to this should cause the prompt. To remove the debconf entry that says the prompt has been seen: echo 'unregister koha-common/3.2-3.4-upgrade-notice' | sudo debconf-communicate koha-common This should be run before every test to make debconf forget that it's shown the prompt. To get its current state: sudo debconf-show koha-common To test against the 3.2 version, an empty package that claims to be Koha 3.2.2 is attached to the bug. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 27 23:40:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Jul 2013 21:40:36 +0000 Subject: [Koha-bugs] [Bug 10574] Remove the message about upgrading to 3.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net Severity|enhancement |minor --- Comment #5 from Mirko Tietgen --- Galen approved my change from enhancement to bug for this one. Patch works nicely for me. Thanks for fixing this, it is very confusing to people installing Koha for the first time. I hope to see it in 3.12 and 3.10 too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 28 01:02:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Jul 2013 23:02:15 +0000 Subject: [Koha-bugs] [Bug 10646] mod_rewrite should be enabled by the postinst script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19952|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Created attachment 19969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19969&action=edit Bug 10646: mod_rewrite should be enabled by the postinst script This patch makes the post install scripts used by the .deb packages enable the mod_rewrite module (which is mandatory if you want to run Koha). It tests the module isn't already enabled, and enables if necesary, and reloads Apache configuration. To test: - Install current koha-common packages on a fresh setup. Make sure you have mod_rewrite disabled (its the default if you didn't have apache and it was just pulled by koha-common at least on Ubuntu 12.04). Run $ a2dismod rewrite to make sure it is disabled on your test box. Create a new koha instance like this: $ koha-create --create-db name You'll get an error like this: Syntax error on line 76 of /etc/koha/apache-shared.conf: Invalid command 'RewriteEngine', perhaps misspelled or defined by a module not included in the server configuration Action 'configtest' failed. The Apache error log may have more information. ...fail! , build your own packages, make sure you have mod_rewrite disabled (which is the default on Ubuntu 12.04 at least), and install the package. Create a new instance issuing: - Apply the patch, build your packages, repeat: No apache warning about the rewrite module. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 28 01:03:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Jul 2013 23:03:38 +0000 Subject: [Koha-bugs] [Bug 10646] mod_rewrite should be enabled by the postinst script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 28 01:12:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Jul 2013 23:12:20 +0000 Subject: [Koha-bugs] [Bug 10304] Add avanced search filter for "not for loan" items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement --- Comment #7 from Mirko Tietgen --- After reading the comments I am changing this to enhancement as it does not seem to be considered a bug fix anymore but a new option. Please change it back if that is incorrect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 28 01:22:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Jul 2013 23:22:05 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19858|0 |1 is obsolete| | --- Comment #3 from Mirko Tietgen --- Created attachment 19970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19970&action=edit Bug 10625 - Inventory/Stocktaking tool cannot handle windows file uploads The inventory/stocktaking tool interprets windows text editor file as a single large barcode because the text editor only uses carriage returns for line breaks, rather than a carriage return and line break combination. This tools should be able to handle \r, \n, and/or \r\n. Test Plan: 1) Download the attached sample file of barcodes 2) Upload this file to the inventory/stocktaking tool. For this test, it doesn't matter that these barcodes aren't cataloged in your system. 3) Note that the "barcode not found" is a single extremely long barcode 4) Apply this patch 5) Repeat step 2 6) Note that you now get a "barcode not found" error for each barcode individually. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 28 01:22:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Jul 2013 23:22:33 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 28 01:28:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Jul 2013 23:28:31 +0000 Subject: [Koha-bugs] [Bug 10646] mod_rewrite should be enabled by the postinst script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #3 from Robin Sheat --- I don't think that we should change system configuration like this. What happens if it breaks something else on the system? I'd rather koha-create aborts with an error, or something like that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 28 01:42:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 27 Jul 2013 23:42:36 +0000 Subject: [Koha-bugs] [Bug 10646] mod_rewrite should be enabled by the postinst script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 --- Comment #4 from Jared Camins-Esakov --- (In reply to Robin Sheat from comment #3) > I don't think that we should change system configuration like this. What > happens if it breaks something else on the system? > > I'd rather koha-create aborts with an error, or something like that. I disagree. I think we'll have already broken whatever else could be broken by an Apache configuration change. We've already clobbered the heck out of whatever Apache configuration the user had before by uninstalling the user's existing Apache MPM (probably prefork or worker with Apache 2.2 and I guess event with Apache 2.4) and installing itk in its place, so we might as well just make Koha work at that point. That said, I don't have a particularly strong feeling that this is necessary, since the error message it pretty self-explanatory, I just think the horse has already left the barn. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 28 14:45:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Jul 2013 12:45:11 +0000 Subject: [Koha-bugs] [Bug 10646] mod_rewrite should be enabled by the postinst script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 28 14:45:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Jul 2013 12:45:33 +0000 Subject: [Koha-bugs] [Bug 10645] Missing zebra languages in koha-create manpage In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10645 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 28 14:45:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Jul 2013 12:45:59 +0000 Subject: [Koha-bugs] [Bug 10622] Add --sip and --nosip switches to koha-list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 28 14:46:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Jul 2013 12:46:21 +0000 Subject: [Koha-bugs] [Bug 10617] Init script cleanup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10617 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 28 14:46:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Jul 2013 12:46:55 +0000 Subject: [Koha-bugs] [Bug 10205] koha-create error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10205 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 28 14:47:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Jul 2013 12:47:29 +0000 Subject: [Koha-bugs] [Bug 8779] .deb upgrade fails on incomplete instance setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8779 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 28 15:53:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 28 Jul 2013 13:53:51 +0000 Subject: [Koha-bugs] [Bug 10646] mod_rewrite should be enabled by the postinst script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 --- Comment #5 from Robin Sheat --- (In reply to Jared Camins-Esakov from comment #4) > I disagree. I think we'll have already broken whatever else could be broken > by an Apache configuration change. We've already clobbered the heck out of > whatever Apache configuration the user had before by uninstalling the user's > existing Apache MPM (probably prefork or worker with Apache 2.2 and I guess That's all voluntary however, warnings are given. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 03:41:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 01:41:00 +0000 Subject: [Koha-bugs] [Bug 10450] Editing serials predicts wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10450 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #1 from Liz Rea --- I think I've seen this too, very very strange behaviour. Liz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 05:00:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 03:00:42 +0000 Subject: [Koha-bugs] [Bug 10652] New: Ajaxfileupload.js failing in IE9 for local image upload Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10652 Bug ID: 10652 Summary: Ajaxfileupload.js failing in IE9 for local image upload Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, when you try to upload a local cover image in IE9, Koha throws a Javascript error and reloads the "upload-cover-image.pl" page without uploading the image. This appears to be the result of a change in the arguments available to the "createElement" Javascript function in IE9 (and probably IE9+). I imagine this has implications in other parts of Koha as well, including the MARC upload, which was the original motivator for the creation of ajaxfileupload.js, I believe. (The code was added by Galen in 2007 according to git blame, so he might know.) In any case, I'm just going to introduce a try/catch which will cover all scenarios. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 05:08:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 03:08:25 +0000 Subject: [Koha-bugs] [Bug 10652] Ajaxfileupload.js failing in IE9 for local image upload In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10652 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |dcook at prosentient.com.au Assignee|gmcharlt at gmail.com |dcook at prosentient.com.au --- Comment #1 from David Cook --- Created attachment 19971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19971&action=edit Bug 10653 - Ajaxfileupload.js failing in IE9 for local image upload This patch adds a try/catch to the Javascript for adding the iframe element. The try will work for IE8 and older versions, while newer versions and other browsers will be covered by the check. Test Plan: 1) Try uploading a local cover image in IE9 2) Notice that your page is reloaded with no result (except the pop-up of a Javascript error, if you have error reporting on in your browser). 3) Apply the patch 4) Trying uploading a local cover image again 5) Notice that it uploads correctly 6) Repeat steps 4 and 5 for IE8, IE7, and/or other modern browsers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 05:27:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 03:27:05 +0000 Subject: [Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #2 from Srdjan Jankovic --- There are some things that would be nice to address: 1. if ( defined $delay && $delay >= 0 ), elsif ( defined $delay && $delay < 0 ) is too much, if ( $delay >= 0 ), elsif ( $delay < 0 ) should do 2. Around line 137 - closing { for elsif ( defined $delay && $delay < 0 ) - identation becomes broken (probably tabs need replacing with blank spaces) 3. if ( defined $estimateddeliverydateto ) {} elsif ( !defined $estimateddeliverydateto ) {} should probably be if ( defined $estimateddeliverydateto ) {} else {} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 05:44:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 03:44:14 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |liz at catalyst.net.nz --- Comment #3 from Liz Rea --- Hi, Tried to test this, got the following: Falling back to patching base and 3-way merge... Auto-merging tools/modborrowers.pl CONFLICT (content): Merge conflict in tools/modborrowers.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt Failed to merge in the changes. Patch failed at 0001 Bug 10612 - Add ability to delete patrons with batch patron modification tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 05:44:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 03:44:54 +0000 Subject: [Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 05:54:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 03:54:09 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 05:54:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 03:54:13 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19964|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 19972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19972&action=edit [SIGNED-OFF] Bug 10649 - Upgrade DataTables and move scripts out of theme directory This patch adds an upgraded copy of the DataTables plugin to the jQuery plugin directory outside the theme directories. Copies of the old DataTables plugin scripts have been left in the old location while templates are incrementally updated. To test, visit each affected page in Acquisitions and confirm that table sorting still words correctly: - Acquisitions home - Acquisitions -> Late orders - Acquisitions -> Order search - Acquisitions -> Ordered (from table of available funds) - Acquisitions -> Spent (from table of available funds) - Acquisitions -> Vendor search - Acquisitions -> Vendor detail - Acquisitions -> Vendor -> Basket - Acquisitions -> Vendor -> Basket -> Add order from existing record -> Add order from suggestion -> Add order from subscription -> Add order from external source -> Add order from staged file - Acquisitions -> Vendor -> Basket groups - Acquisitions -> Vendor -> Uncertain prices - Acquisitions -> Vendor -> Invoices - Acquisitions -> Vendor -> Invoices -> Invoice - Acquisitions -> Vendor -> Receive shipments - Acquisitions -> Vendor -> Receive shipments -> Receipt summary (click invoice number) Also test one or more pages which have not been modified to confirm that old DataTables assets are still in place and working (ex: Circulation, Quotes editor, Saved reports, etc.) Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 05:55:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 03:55:54 +0000 Subject: [Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #3 from Srdjan Jankovic --- I got "YAHOO not defined" on the Receipt summary, but that's got nothing to do with this change I presume. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 05:59:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 03:59:12 +0000 Subject: [Koha-bugs] [Bug 10644] C4::ClassSource.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10644 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 05:59:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 03:59:16 +0000 Subject: [Koha-bugs] [Bug 10644] C4::ClassSource.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10644 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19961|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 19973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19973&action=edit [SIGNED-OFF] Bug 10644: ClassSource.pm needs unit tests The tests are wrap in a database transaction. To test: prove t/db_dependent/ClassSource.t t/db_dependent/ClassSource.t .. 1/24 prepare_cached(SELECT * FROM `class_sort_rules` WHERE `class_sort_rule` = ?) statement handle DBI::st=HASH(0x92dbedc) still Active at C4/ClassSource.pm line 249 prepare_cached(SELECT * FROM `class_sources` WHERE cn_source = ?) statement handle DBI::st=HASH(0x926876c) still Active at C4/ClassSource.pm line 137 attempting to use non-existent class sorting routine routine1 prepare_cached(SELECT * FROM `class_sort_rules` WHERE `class_sort_rule` = ?) statement handle DBI::st=HASH(0x92dbedc) still Active at C4/ClassSource.pm line 249 prepare_cached(SELECT * FROM `class_sources` WHERE cn_source = ?) statement handle DBI::st=HASH(0x926876c) still Active at C4/ClassSource.pm line 137 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.12 cusr 0.01 csys = 0.15 CPU) Result: PASS Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 06:05:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 04:05:09 +0000 Subject: [Koha-bugs] [Bug 6301] super librarians can't export bib records from all libraries if indybranches on In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6301 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |liz at catalyst.net.nz Resolution|--- |DUPLICATE --- Comment #1 from Liz Rea --- *** This bug has been marked as a duplicate of bug 7505 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 06:05:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 04:05:09 +0000 Subject: [Koha-bugs] [Bug 7505] Superlibrarian can't export all biblios when IndependantBranches is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7505 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #6 from Liz Rea --- *** Bug 6301 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 07:10:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 05:10:48 +0000 Subject: [Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 --- Comment #6 from David Cook --- (In reply to Srdjan Jankovic from comment #5) > It's a hairy issue HTML an HTTP stepping on each other's toes, and browsers > trying to be "helpful" does not help at all. Re links, google for "html > escape ampersand" or similar. > However, in this case, I believe we are talking Redirect header, which is > not HTML, so no escaping applies. Ahhh, I understand now. Thanks for the clarification :). I'll send a new patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 07:14:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 05:14:20 +0000 Subject: [Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19912|0 |1 is obsolete| | --- Comment #7 from David Cook --- Created attachment 19974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19974&action=edit Bug 10638 - Show alert when receiving an order with holds/reserves This patch adds an alert message in Acquisitions when receiving new orders. If there are bib-level holds for the bib record attached to that order, it gives a count of the bib-level holds. If there are item-level holds for items attached to that order, it shows a count of the items as well as displaying the barcodes for the items that have holds/reserves on them. If there are item-level holds for items not attached to that order and there are no bib-level holds, the message will just say that there are pending reserves for that bib record. TEST PLAN 1) Set AcqCreateItem to "placing an order" 2) Place an order in Acquisitions 3) Create three or four items when placing that order 4) In the OPAC or staff client, place a hold on one item 5) Receive the order 6) Note that there is no alert message about the hold/reserve 7) Apply the patch 8) Receive another item for that order 9) Note that there should now be a yellow alert message at the top of the parcel.pl screen. 10) The message text will vary depending on the reserve/hold situation. If there are bib-level holds, it will display a count of bib-level holds. If there are item-level holds for items attached to that order, it will show a count of those holds and print out their barcodes. (N.B. if you are receiving part of an order, your order number will change, so it will only print information for the received items that are attached to this new order, rather than all items including the original order.) If there are item-level holds for items attached to a different order or no order at all, no specific information will be printed. It will just say that there are pending reserves for that record (or that there are bib-level holds, if there are bib-level holds). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 09:28:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 07:28:30 +0000 Subject: [Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19942|0 |1 is obsolete| | --- Comment #3 from kenza --- Created attachment 19975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19975&action=edit Bug 10641 - GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences This patch fixes some incoherences of the routine GetBooksellerWithOrders. Now it considers the field $estimateddeliverydateto and it replaces it by now() only if it is undef. More it doesn't test if $aqbookseller.deliverytime is not Null anymore but if $deliverytime = null or undef, it replaces it by 0. It also verifies if $delay is >= 0 and return undef if it is a negative value. To Test: prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. [Some warnings about uninitialized values] WARNING: GetBooksellerWithLateOrders is called with a negative value at C4/Bookseller.pm line 135. t/db_dependent/Bookseller.t .. ok All tests successful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 09:34:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 07:34:03 +0000 Subject: [Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641 --- Comment #4 from kenza --- I have modified the patch in accordance with your advices. "if ( defined $delay && $delay >= 0 )" is usefull, if we use only "if ( $delay >= 0 )" it breaks the tests. More,"elsif ( $delay < 0 )" adds some warnings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 09:45:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 07:45:19 +0000 Subject: [Koha-bugs] [Bug 10653] New: UT : C4::RotatingCollections.pm needs unit tests. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 Bug ID: 10653 Summary: UT : C4::RotatingCollections.pm needs unit tests. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: kenza.zaki at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 09:45:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 07:45:46 +0000 Subject: [Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kenza.zaki at biblibre.com Assignee|gmcharlt at gmail.com |kenza.zaki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 11:34:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 09:34:41 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Magnus Enger --- (In reply to Owen Leonard from comment #9) > When I tested this I found that I did not see the custom message if the item > was on hold (prompting a hold message) or required a transfer (prompting a > transfer message). Is this a bug, or is it by design? Sounds like a bug to me. Corrected patch coming shortly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 12:50:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 10:50:05 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 --- Comment #24 from Katrin Fischer --- Ok, I can confirm this bug in 3.12.1+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 12:52:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 10:52:58 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 --- Comment #25 from Katrin Fischer --- Kyle, could you take a look at my comments? I would really like to see this moving forward. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 13:17:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 11:17:55 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 13:17:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 11:17:59 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19854|0 |1 is obsolete| | --- Comment #11 from Magnus Enger --- Created attachment 19976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19976&action=edit Bug 10513 - Light up a warning/message when returning a chosen item type This patch adds a new column to item types. Text in this column is displayed as a warning when an item of the given type is checked in. The type of message can also be chosen, affecting how the message is displayed. Use case: Items that are on inter-library loan can have a separate item type, and when items of this type are checked in a message saying something like "ILL! Remember to return it to the owning library!" can be displayed. To test: - Apply the patch - Go to Home > Administration > Item types administration - Check that there is a new column, called "Check in message" - Edit an item type and add a check in message - Check that the check in message you added is displayed in the table - Check in an item with an item type that has a check in message - Check that the message is displayed - Repeat the steps above, but select "Alert" instead of the default "Message" as the "Check in message type". Check that the message is displayed in a yellow alert box, not a blue message box. - Check in an item with an item type that does *not* have a check in message, and make sure no false messages are displayed - Create a new item type from scratch and check that it works the way it is supposed to - Run the tests in t/ItemType.t, which are updated by this patch This patch also removes backticks around column names in the itemtypes table in installer/data/mysql/kohastructure.sql UPDATE 2013-07-22 - Rebased on current master (no changes) - Added "AFTER summary" to the SQL statement in updatedatabase.pl - Added another placeholder on line 170 of admin/itemtypes.pl Thanks Katrin! UPDATE 2013-07-29 - Make this message independent of all other messages - thanks Owen! - Make it possible to choose the type of message ("alert" or "message") Sponsored-by: Kultur i Halland - Regionbibliotek -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 13:20:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 11:20:34 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 --- Comment #12 from Magnus Enger --- I added another enhancement to this patch: the ability to choose if the check in message should be displayed as an alert or a message. The check in messages are displayed without a heading, but if libraries want one, they can include HTML along these lines in the check in message it self:

    Warning!

    This is an ILL item, please return it to the owning library!

    -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 13:46:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 11:46:32 +0000 Subject: [Koha-bugs] [Bug 8612] System preference to have custom fields in exort csv basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 13:53:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 11:53:49 +0000 Subject: [Koha-bugs] [Bug 10654] New: Add featute: export basket in CSV, list of custom formats for various vendors Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10654 Bug ID: 10654 Summary: Add featute: export basket in CSV, list of custom formats for various vendors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P3 Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: black23 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 19977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19977&action=edit screenshot of menu Hello, in Koha we can set custom format of CSV for basket export from OPAC. I think that very useful feature can be same option for export from basket in module acquisition. Our vendors accept import of orders in CSV in their e-shops but formats are various. Is possible to add into button "Export this basket as CSV" some pull-down list of vendors and export order in specific CSV format? Thank You. Mike -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 13:54:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 11:54:02 +0000 Subject: [Koha-bugs] [Bug 10654] Add feature: export basket in CSV, list of custom formats for various vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10654 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add featute: export basket |Add feature: export basket |in CSV, list of custom |in CSV, list of custom |formats for various vendors |formats for various vendors -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 14:31:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 12:31:26 +0000 Subject: [Koha-bugs] [Bug 10502] Add independent branches option for sql reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502 --- Comment #5 from Kyle M Hall --- It is a case of the latter. The idea is to create "walled gardens" for each library or group of libraries. We could definitely add a dropdown filter as a separate bug/patch, but that alone wouldn't satisfy the requirements for this bug. The intent of all these new independent branches patches is to make Koha more consortia friendly. Some consortia are rabid about not being able to see each others data, including even seeing each others reports! (In reply to Srdjan Jankovic from comment #4) > Is this just "I don't want to see other branches reports, I cannot find > mine" case, or "We don't want you to see what other people are doing" kind > of thing? Cause if it is former, it should really be a select drop down, > rather than a syspref. Maybe. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 14:39:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 12:39:44 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 --- Comment #26 from Katrin Fischer --- Kyle, as I see it the second follow up is unrelated to this bug report and should probably go on a different bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 14:56:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 12:56:36 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18200|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 15:06:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 13:06:41 +0000 Subject: [Koha-bugs] [Bug 9936] SIP2 should use C4/Auth.pm for user authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10372 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 15:06:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 13:06:41 +0000 Subject: [Koha-bugs] [Bug 10372] SIP2- Ability to use both userid and cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10372 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9936 --- Comment #1 from Katrin Fischer --- Hi Amit, maybe take a look at bug 9936 in this context? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 15:09:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 13:09:54 +0000 Subject: [Koha-bugs] [Bug 10622] Add --sip and --nosip switches to koha-list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10622 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 15:40:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 13:40:09 +0000 Subject: [Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641 --- Comment #5 from Srdjan Jankovic --- Sure, sorry, I was doing two things at the time, never a good idea. I wan ted to say to have a if (defined $delay) wrapper, just a bit easier to read, but that's ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 16:18:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 14:18:46 +0000 Subject: [Koha-bugs] [Bug 10655] New: Include list of holds on circ slip or offer separate printing option Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10655 Bug ID: 10655 Summary: Include list of holds on circ slip or offer separate printing option Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com One of our libraries asked for an option to print a list of open holds for the patron. As far as I can tell it's currently not possible to include a list of holds on the available circulation slips and there is no separate option. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 16:22:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 14:22:26 +0000 Subject: [Koha-bugs] [Bug 10656] New: shelving locations not alpha on search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 Bug ID: 10656 Summary: shelving locations not alpha on search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org On the advanced search page the shelving locations don't seem to be in alphabetical order by description as they should be to match the other tabs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 16:22:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 14:22:45 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 --- Comment #1 from Nicole C. Engard --- Created attachment 19978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19978&action=edit one example -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 16:22:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 14:22:59 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 --- Comment #2 from Nicole C. Engard --- Created attachment 19979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19979&action=edit another example -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 16:23:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 14:23:13 +0000 Subject: [Koha-bugs] [Bug 10656] shelving locations not alpha on search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 --- Comment #3 from Nicole C. Engard --- Tested in 3.10.6 and master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 16:55:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 14:55:37 +0000 Subject: [Koha-bugs] [Bug 10415] Add course reserves to staff client home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10415 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #2 from Nicole C. Engard --- I vote : http://thenounproject.com/noun/stack-of-books/#icon-No11494 or http://thenounproject.com/noun/stack-of-books/#icon-No3700 And I agree that we need a module link for it on the home page. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 17:07:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 15:07:54 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 17:08:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 15:08:03 +0000 Subject: [Koha-bugs] [Bug 10121] unhighlight doesn't carry over to other pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10121 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 17:10:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 15:10:31 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #3 from Kyle M Hall --- I believe this is still a valid bug. The highlighter needs to be more intelligent about what it highlights. Perhaps we can just tell it to never highlight the boolean operators, or pass the keywords only to it? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 17:10:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 15:10:48 +0000 Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 18:06:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 16:06:45 +0000 Subject: [Koha-bugs] [Bug 10657] New: placeholder bug -- Galen will be filling this in shortly Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10657 Bug ID: 10657 Summary: placeholder bug -- Galen will be filling this in shortly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org placeholder -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 18:18:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 16:18:22 +0000 Subject: [Koha-bugs] [Bug 10658] New: test pattern showing wrong data on advanced predictions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10658 Bug ID: 10658 Summary: test pattern showing wrong data on advanced predictions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com When using the advanced prediction pattern the test shows you wrong results - this is very confusing to libraries. I have confirm that the advanced patterns do work (by receiving and testing) but the pattern it shows when you click 'test' (which is required) is almost always wrong if you are using an advanced pattern. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 18:30:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 16:30:23 +0000 Subject: [Koha-bugs] [Bug 10659] New: Upgrade jQuery star ratings plugin Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Bug ID: 10659 Summary: Upgrade jQuery star ratings plugin Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The version of the jQuery star ratings plugin that Koha uses is not compatible with the latest version of jQuery. If we want to be able to upgrade jQuery we need to also upgrade the star ratings plugin, which is now at version 4.11 (we have v3.14). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 20:18:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 18:18:38 +0000 Subject: [Koha-bugs] [Bug 10660] New: make offline circulation tool handle holds Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10660 Bug ID: 10660 Summary: make offline circulation tool handle holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: melia at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently, when you upload a .koc file from offline circulation, there is nothing to tell you whether any of the items that were checked in needed to trigger a hold. It would great if the offline circulation tool somehow had the ability to handle holds as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 22:14:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 20:14:59 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #63 from Katrin Fischer --- I am sorry, I know this has gone rounds for a while, but I can't get follow up 3 to apply after fixing the merge conflict in the first patch. Can someone please provide rebased patches? Thx! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 22:15:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 20:15:27 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #64 from Katrin Fischer --- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 6739 - expired patrons not blocked from opac actions - Followup 3 fatal: sha1 information is lacking or useless (installer/data/mysql/kohastructure.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 23:09:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 21:09:47 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 23:09:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 21:09:51 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19704|0 |1 is obsolete| | Attachment #19705|0 |1 is obsolete| | Attachment #19706|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 19980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19980&action=edit [PASSED QA] Bug 10543 - false mandatory warning in additem When editing a item, you get a popup warning : "1 mandatory fields empty (highlighted)". But all mandatory fields are filled. This is because there is a field with a huge content (more than 100 characters), it it displayed in a textarea instead of input. This patch corrects javascript form check by using siblings(). Also adds a more precise filter to find mandatory inputs because looking in full page may bring unwanted results. Test plan : - In a framework, make sure you have in item field : An optionnal subfield (without authorised value) then a mandatory subfield then an optional subfield next to mandatory subfield For example : $i (optional), $r (mandatory) and $s (optional) - Open a biblio record and create a new item - Enter more than 100 characters in $i, fill $r and $s - Click "Add item" - Edit this item => You get a textarea for $i - Empty $s and Save => Without patch, you get a warning and form is not saved and you see that $s is yellow while it should be $r => With patch, form is saved - Re-edit this item - Empty $r and save => You get a warning and form is not saved Signed-off-by: Srdjan Signed-off-by: Katrin Fischer Notes on last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 23:10:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 21:10:06 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 --- Comment #18 from Katrin Fischer --- Created attachment 19981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19981&action=edit [PASSED QA] Bug 10543 - Unify item mandatory subfields check Use of CheckMandatorySubfields from cataloging.js everywhere an item cataloging form is checked for mandatories Signed-off-by: Srdjan Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 23:10:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 21:10:30 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 --- Comment #19 from Katrin Fischer --- Created attachment 19982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19982&action=edit [PASSED QA] Bug 10543 - add mandatory subfield check to addorderiso2709.pl When adding orders from staged file, you can create one order per record using item form in the bottom of addorderiso2709.pl. This form was missing check. Signed-off-by: Srdjan Signed-off-by: Katrin Fischer All 3 patches pass tests and QA script. Some additional notes on the test plan from the first patch: It took me a while to figure out a combination of subfields that would trigger the bug. I am not sure about the condition that transforms the input field into a textbox as it does not seem to happen for every field. What worked in the end was (MARC21): - $g cost, normal purchase price = mandatory - $h serial enumeration/chronolgy = optional, filled with text over 100 characters Checked for: - Adding items in cataloguing Was able to reproduce the problem, mandatory check works as expected. - Adding items from staged file in acq Was not able to trigger the problem, because we don't edit the item here, but mandatory check works as expected. - Addings items for serial subscriptions Was not able to trigger the problem, because we don't edit the items here, but mandatory check works better as before as missing mandatory fields are now highlighted and weren't before. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 23:12:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 21:12:45 +0000 Subject: [Koha-bugs] [Bug 10661] New: Mandatory item fields should be formatted the same on all forms Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10661 Bug ID: 10661 Summary: Mandatory item fields should be formatted the same on all forms Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org While we mark the mandatory fields with red font color in cataloguing, the item forms in serials and acquisitions (order from staged file, item form on order entry) are still using an asterisk * to indicate mandatory fields. We should use the same formatting on all forms for more consistency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 29 23:22:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 21:22:53 +0000 Subject: [Koha-bugs] [Bug 10657] placeholder bug -- Galen will be filling this in shortly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10657 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 00:50:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 22:50:15 +0000 Subject: [Koha-bugs] [Bug 10657] placeholder bug -- Galen will be filling this in shortly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10657 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch complexity|--- |Small patch Severity|enhancement |blocker --- Comment #1 from Galen Charlton --- When EnableOpacSearchHistory system preference is enabled, Koha stores recent search history for anonymous OPAC sessions in a cookie called KohaOpacRecentSearches. In particular, it used to use the Storable Perl module to serialize the array of hashrefs representing the recent searches. However, the documentation for Storable strongly recommends [1] that data to be deserialized *not* come from untrusted sources -- and cookies cannot be considered trustworthy, as most web browsers (to say nothing of curl) allow the user to modify them. There is a theoretical possibility that a modification to the KohaOpacRecentSearches cookie could result in the execution of unauthorized code with the privileges of the Apache backend process. The 29 July 2013 security update resolves the security issuing by replacing use of the Storable module with the JSON, which doesn't by default serialize blessed references and does not attempt to deserialize and execute coderefs. The payload of the cookie is checked for JSON-correctness and is ignored if it doesn't contain a valid (double-URI-encoded) JSON object. In particularly, any old Storable-based cookies are silently ignored. [1] http://perldoc.perl.org/Storable.html#SECURITY-WARNING -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 00:50:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 22:50:34 +0000 Subject: [Koha-bugs] [Bug 10657] use of Storable for OPAC search history cookie dangerous In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10657 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|placeholder bug -- Galen |use of Storable for OPAC |will be filling this in |search history cookie |shortly |dangerous -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 00:50:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 22:50:44 +0000 Subject: [Koha-bugs] [Bug 10657] use of Storable for OPAC search history cookie dangerous In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10657 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 00:50:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 22:50:51 +0000 Subject: [Koha-bugs] [Bug 10657] use of Storable for OPAC search history cookie dangerous In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10657 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 00:50:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 22:50:58 +0000 Subject: [Koha-bugs] [Bug 10657] use of Storable for OPAC search history cookie dangerous In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10657 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 00:51:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 22:51:04 +0000 Subject: [Koha-bugs] [Bug 10657] use of Storable for OPAC search history cookie dangerous In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10657 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 00:51:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 22:51:28 +0000 Subject: [Koha-bugs] [Bug 10657] use of Storable for OPAC search history cookie dangerous In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10657 --- Comment #2 from Galen Charlton --- Fix released: http://koha-community.org/security-release-july-2013/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 01:52:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 23:52:03 +0000 Subject: [Koha-bugs] [Bug 10657] use of Storable for OPAC search history cookie dangerous In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10657 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10338 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 01:52:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 23:52:03 +0000 Subject: [Koha-bugs] [Bug 10338] Search history can cause "Out of memory" errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10338 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com Depends on| |10657 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 01:53:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Jul 2013 23:53:36 +0000 Subject: [Koha-bugs] [Bug 10338] Search history can cause "Out of memory" errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10338 --- Comment #1 from Galen Charlton --- This should be fixed by the patch to bug 10657, which replaces Storable with JSON for serializing the search history. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 05:54:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 03:54:29 +0000 Subject: [Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 05:54:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 03:54:33 +0000 Subject: [Koha-bugs] [Bug 10638] Show alert when receiving an order with holds/reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10638 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19974|0 |1 is obsolete| | --- Comment #8 from Srdjan Jankovic --- Created attachment 19983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19983&action=edit [SIGNED-OFF] Bug 10638 - Show alert when receiving an order with holds/reserves This patch adds an alert message in Acquisitions when receiving new orders. If there are bib-level holds for the bib record attached to that order, it gives a count of the bib-level holds. If there are item-level holds for items attached to that order, it shows a count of the items as well as displaying the barcodes for the items that have holds/reserves on them. If there are item-level holds for items not attached to that order and there are no bib-level holds, the message will just say that there are pending reserves for that bib record. TEST PLAN 1) Set AcqCreateItem to "placing an order" 2) Place an order in Acquisitions 3) Create three or four items when placing that order 4) In the OPAC or staff client, place a hold on one item 5) Receive the order 6) Note that there is no alert message about the hold/reserve 7) Apply the patch 8) Receive another item for that order 9) Note that there should now be a yellow alert message at the top of the parcel.pl screen. 10) The message text will vary depending on the reserve/hold situation. If there are bib-level holds, it will display a count of bib-level holds. If there are item-level holds for items attached to that order, it will show a count of those holds and print out their barcodes. (N.B. if you are receiving part of an order, your order number will change, so it will only print information for the received items that are attached to this new order, rather than all items including the original order.) If there are item-level holds for items attached to a different order or no order at all, no specific information will be printed. It will just say that there are pending reserves for that record (or that there are bib-level holds, if there are bib-level holds). Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 06:18:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 04:18:54 +0000 Subject: [Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 06:18:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 04:18:57 +0000 Subject: [Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19975|0 |1 is obsolete| | --- Comment #6 from Srdjan Jankovic --- Created attachment 19984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19984&action=edit [SIGNED-OFF] Bug 10641 - GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences This patch fixes some incoherences of the routine GetBooksellerWithOrders. Now it considers the field $estimateddeliverydateto and it replaces it by now() only if it is undef. More it doesn't test if $aqbookseller.deliverytime is not Null anymore but if $deliverytime = null or undef, it replaces it by 0. It also verifies if $delay is >= 0 and return undef if it is a negative value. To Test: prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. [Some warnings about uninitialized values] WARNING: GetBooksellerWithLateOrders is called with a negative value at C4/Bookseller.pm line 135. t/db_dependent/Bookseller.t .. ok All tests successful. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 06:56:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 04:56:56 +0000 Subject: [Koha-bugs] [Bug 10643] Inappropriate uses of $sth->finish() in C4::ClassSource.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #2 from Srdjan Jankovic --- I propose something even better then - get rid of prepare() all together. For example: * GetClassSources(): return $dbh->selectall_hashref("SELECT...", undef, 'cn_source'); * AddClassSource() return $dbh->do("INSERT...", undef, @params) etc. How often are those used to get advantage of prepare_cached()? Good databases (tm) cache queries anyway, however not sure that MySQL does. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 08:53:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 06:53:48 +0000 Subject: [Koha-bugs] [Bug 9295] Introduce operator equal/ notequal to OAI set mapping instead of hardcoded 'equal' value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9295 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 08:54:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 06:54:49 +0000 Subject: [Koha-bugs] [Bug 9295] Introduce operator equal/ notequal to OAI set mapping instead of hardcoded 'equal' value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9295 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 09:36:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 07:36:20 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 Derryn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |derrynj at gmail.com --- Comment #37 from Derryn --- We're running into the exact same issues here on AD 2008. We've tried with/without bind. Is there a way to get this working in the meantime? We're running the tarball version so reverting patches aren't as simple as with Git installs. I updated to 3.12.1 and after a bit of testing it all seemed fine because we didn't have any new users. But once we did, we started getting failed logins everywhere. I would request this be marked as a blocker and that it be removed from all future versions until this is fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 09:39:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 07:39:02 +0000 Subject: [Koha-bugs] [Bug 10662] New: Build OAI-PMH Harvesting Client Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Bug ID: 10662 Summary: Build OAI-PMH Harvesting Client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Currently, Koha only acts as a OAI-PMH server, I propose to add a harvesting client as well (likely using the HTTP::OAI::Harvester module), so that Koha can ingest records from other data sources (such as digital repositories like Dspace). I've only started reading about it but despite initial reservations about resumption tokens, I think the hardest part will not be with the retrieval of records so much as the parsing of those records into MARC. The Library of Congress does provide some crosswalks (http://www.loc.gov/standards/marcxml/) for converting other metadata formats into MARC21. However, the DC to MARC crosswalk (which is the obvious choice for Dspace) does not produce records of a high quality. So, as part of this new feature, I will also be working on a more complete DC to MARC crosswalk. Their DCMI terms (http://dublincore.org/documents/2012/06/14/dcmi-terms/?v=elements#type) have been mapped reasonably well to the MARC21 LEADER 6th and 7th positions, which improves the quality of the record and helps to produce a "best guess" 008. I'll be looking at adding more datafields and providing better fixed field transformation. Of course, some OAI-PMH repositories serve MARC so this crosswalk might not always be necessary. However, I've looked at Dspace's DC=>MARC crosswalk and it's similar to the LoC one, so I think this will be a valuable addition (both to Koha and to anyone wanting to transform DC to MARC21). As I mentioned, I'm just starting out with OAI-PMH, but I imagine having Koha as a OAI-PMH harvester might be useful in union catalogue situations where other servers might send quality MARC records. -- My plan: 1) Set up a script that is able to continuously harvest records from a OAI-PMH server (likely Dspace or Koha itself for my trials) 2) Set up a database table to handle harvester configuration (such as baseurl, sets, (possibly dates), metadata format, and any pointers to XSLTs. 3) Set up a solid (yet likely basic) DC => MARC XSLT. If anyone has comments or advice, I'd love to hear it. Hopefully, I'll be able to focus on this over the next little while... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 09:39:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 07:39:12 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 09:41:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 07:41:21 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 09:43:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 07:43:34 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 09:52:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 07:52:19 +0000 Subject: [Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 09:52:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 07:52:26 +0000 Subject: [Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 --- Comment #1 from kenza --- Created attachment 19985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19985&action=edit Bug 10653: C4::RotatingCollections.pm needs unit tests The tests are wrap in a database transaction. Test plan: prove t/db_dependent/RotatingCollections.pm t/db_dependent/RotatingCollections.pm .. 1/41 attempting to use non-existent class sorting routine Use of uninitialized value $cn_class in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. Use of uninitialized value $cn_item in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. Use of uninitialized value $cn_class in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. Use of uninitialized value $cn_item in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. t/db_dependent/RotatingCollections.pm .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.04 usr 0.02 sys + 0.99 cusr 0.08 csys = 1.13 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 10:30:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 08:30:52 +0000 Subject: [Koha-bugs] [Bug 10663] New: Holds don't block renewal in OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 Bug ID: 10663 Summary: Holds don't block renewal in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We had a library with 3.12.1 reporting this issue and I confirmed testing on the current master branch: 0) Allow OPAC renewals (OpacRenewalAllowed) Create a new record with one item. 1) Check out the item to patron A. 2) Place an item level hold for patron B. 3) Try to renew the item in the OPAC for patron A. Problem: You can renew the item, the renewal is not blocked by the hold. The same happens, when you have a title level hold instead of item level. I couldn't find any system preference affecting this behaviour. A quick test on an older 3.6.x installation shows, that renewals are blocked there. Instead of the renewal checkbox we show a message: Not renewable (On hold) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 10:35:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 08:35:27 +0000 Subject: [Koha-bugs] [Bug 10663] Holds don't block renewal in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #1 from Katrin Fischer --- The logs are clean for renewing the item and accessing the 'my summary' tab. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 10:42:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 08:42:29 +0000 Subject: [Koha-bugs] [Bug 10663] Holds don't block renewal in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #2 from Chris Cormack --- fad1f44d42600f440ac88c8df767cfc81c51dea9 is the commit that broke it Bug 9367: Code optimization: CheckReserves is too often called -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 12:10:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 10:10:30 +0000 Subject: [Koha-bugs] [Bug 10663] Holds don't block renewal in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical --- Comment #3 from Katrin Fischer --- I tried reverting the commit, but ran into problems with conflicts. Further tests show that the hold is also not displayed when trying to renew in staff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 13:39:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 11:39:55 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Enhancements: SRU targets, MARC conversion, additional XSLT processing (umbrella report) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10662 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 13:39:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 11:39:55 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6536 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 13:45:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 11:45:43 +0000 Subject: [Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19985|0 |1 is obsolete| | --- Comment #2 from kenza --- Created attachment 19986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19986&action=edit Bug 10653: C4::RotatingCollections.pm needs unit tests The tests are wrap in a database transaction. Test plan: prove t/db_dependent/RotatingCollections.t t/db_dependent/RotatingCollections.t .. 1/41 attempting to use non-existent class sorting routine Use of uninitialized value $cn_class in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. Use of uninitialized value $cn_item in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. Use of uninitialized value $cn_class in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. Use of uninitialized value $cn_item in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. t/db_dependent/RotatingCollections.t .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.04 usr 0.02 sys + 0.99 cusr 0.08 csys = 1.13 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 13:52:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 11:52:43 +0000 Subject: [Koha-bugs] [Bug 10663] Holds don't block renewal in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #4 from Katrin Fischer --- After reverting gave me trouble... I kept looking for the problem, and I think I found it... doing some more tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 14:29:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 12:29:43 +0000 Subject: [Koha-bugs] [Bug 10663] Holds don't block renewal in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #5 from Katrin Fischer --- This change seems to improve things quite a bit: if(defined $found) { return 'Waiting' if $found eq 'W' and $priority == 0; return 'Finished' if $found eq 'F'; - return 'Reserved' if $priority > 0; } + if (defined $priority) { + return 'Reserved' if $priority > 0; + } return ''; When there is a hold, but the item is not W or F priority is NULL, so those cases were never caught here. More tests in 3.6 show that we used to not allow renewals, when one item of many items or of course all items of many items from a record where checked out and a title level hold was placed. This is no longer the case and I think related to the fact that we check by itemnumber - for title level holds the itemnumber is not set in reserves. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 14:45:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 12:45:26 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #38 from acowell at daviscollege.edu --- (In reply to Derryn from comment #37) > We're running into the exact same issues here on AD 2008. We've tried > with/without bind. Is there a way to get this working in the meantime? > We're running the tarball version so reverting patches aren't as simple as > with Git installs. I updated to 3.12.1 and after a bit of testing it all > seemed fine because we didn't have any new users. But once we did, we > started getting failed logins everywhere. I would request this be marked as > a blocker and that it be removed from all future versions until this is > fixed. Derryn, I looked at the patch diff above and reversed the lines of codes that was changed by copying & pasting the old code back in. I'm emailing you our Auth_with_ldap.pm file, I'm note sure if there were any changes between 3.12 and 3.12.1. I do know that there is some other people out there working on changing the LDAP authentication, was trying to find the link but no luck so far. But it appeared at the time that it was a complete re-write of the LDAP authentication in Koha. Maybe slated for 3.14 release. Aaron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 15:19:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 13:19:23 +0000 Subject: [Koha-bugs] [Bug 10663] Holds don't block renewal in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #6 from Katrin Fischer --- Ok, if I understand this correctly, GetReserveStatus is always only called with itemnumber, so we completely ignore the possibility of a title level hold. The new GetReserveStatus was introduced in lots of places - like CanItemBeRenewed and the formerly used CheckReserves. I think I can't fix this and would say we need to revert the changes made by bug 9367. I am not sure how to do that and if it's the best solution. I would appreciate if someone else could take a look and try to untangle this. I am going to attach a patch for the change noted below in case someone wants to use it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 15:23:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 13:23:36 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Holds don't block renewal |Holds never block renewals |in OPAC | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 15:30:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 13:30:16 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #7 from Katrin Fischer --- Created attachment 19987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19987&action=edit Bug 10663 - Partial fix - blocking renewal for item level holds Item level holds should prevent renewal of the item in the OPAC and in staff. For item level holds that are not yet W (=Waiting) GetReserveStatus didn't return the item as reserved, because reserves.found is NULL in this case. To test: - Add a record with an item - Check the item out - Check that you can renew the issue in OPAC and staff - Place an item level hold on the item - Check that you can no longer renew in OPAC and staff This is probably only a partial fix to a bigger problem, see notes on Bug 10663. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 15:46:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 13:46:16 +0000 Subject: [Koha-bugs] [Bug 9247] Add two more usage examples to the manpage for koha-mysql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9247 --- Comment #1 from Magnus Enger --- Created attachment 19988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19988&action=edit Bug 9247 - Add two more usage examples to the manpage for koha-mysql It might not be immediately obvious that it is possible to send SQL queries "directly" to the koha-mysql command, or that files from mysqldump can be loaded with it. This patch adds these as "example usage" to the man page for koha-mysql. To test: Run these commands and look at the formatted man page: $?xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \ debian/docs/koha-mysql.xml $?man -l koha-mysql.8 Make sure this test passes: $?prove -v xt/verify-debian-docbook.t This patch also corrects a couple places where "Koha" was written as "koha". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 15:46:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 13:46:57 +0000 Subject: [Koha-bugs] [Bug 9247] Add two more usage examples to the manpage for koha-mysql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9247 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 16:54:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 14:54:06 +0000 Subject: [Koha-bugs] [Bug 10543] false mandatory warning in additem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #20 from Galen Charlton --- Pushed to master. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 17:09:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 15:09:47 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #8 from Galen Charlton --- (In reply to Katrin Fischer from comment #6) > I think I can't fix this and would say we need to revert the changes made by > bug 9367. I am not sure how to do that and if it's the best solution. I > would appreciate if someone else could take a look and try to untangle this. The code has moved to the point where it doesn't look like a revert of the patch series for bug 9367 is nontrivial. I'll look at this bug further. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 18:59:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 16:59:47 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #24 from Jesse Weaver --- Created attachment 19989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19989&action=edit QA followup for bug 10320 - Fix copyright and style errors This patch fixes a copypasta'd copyright statement, and some incorrect POD and indentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 19:01:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 17:01:54 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #25 from Jesse Weaver --- There's still a QA error, but talking with Owen, I believe that it's specious. The test is intended to remove /prog/ hardcoding, but the lines mentioned use the generic /opac-tmpl/lib directory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 30 19:11:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Jul 2013 17:11:22 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19326|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 02:12:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 00:12:23 +0000 Subject: [Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 02:12:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 00:12:46 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Enhancements: SRU targets, MARC conversion, additional XSLT processing (umbrella report) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 04:15:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 02:15:41 +0000 Subject: [Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #3 from Srdjan Jankovic --- t/db_dependent/RotatingCollections.t .. 1/41 DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE) at t/db_dependent/RotatingCollections.t line 41. DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE) at t/db_dependent/RotatingCollections.t line 41. Is my db out of sync? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 04:24:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 02:24:58 +0000 Subject: [Koha-bugs] [Bug 10640] ModBookseller needs more explicit return values in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10640 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 04:25:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 02:25:02 +0000 Subject: [Koha-bugs] [Bug 10640] ModBookseller needs more explicit return values in C4::Bookseller.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10640 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19939|0 |1 is obsolete| | --- Comment #3 from Srdjan Jankovic --- Created attachment 19990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19990&action=edit [SIGNED-OFF] ModBookseller needs more explicit return values in C4::Bookseller.pm Before, ModBookseller always returns undef. This patch modifies it in order to be more explicit. Now it returns : 1 -> If a modification has been done 0E0 -> If the given id doesn't exist undef -> If no id given It also fix one of the tests which didn't pass before in t/db_dependent/Bookseller.t To Test: prove t/db_dependent/Bookseller.t Bookseller.t .. 1/54 [Some warnings about uninitialized values] t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=54, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.46 cusr 0.04 csys = 0.53 CPU) Result: PASS http://bugs.koha-community.org/show_bug.cgi?id=10640 Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 08:00:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 06:00:48 +0000 Subject: [Koha-bugs] [Bug 10664] New: Software error in overdue_notices.pl if there is no active currency Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Bug ID: 10664 Summary: Software error in overdue_notices.pl if there is no active currency Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: sophie.meynieux at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug introduced by http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378 If there is no active currency, when running overdue_notices.pl you get a sofware error "Can't use an undefined value as a HASH reference" on GetCurrency() function call -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 08:09:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 06:09:50 +0000 Subject: [Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 --- Comment #1 from Sophie MEYNIEUX --- Created attachment 19991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19991&action=edit Bug 10664 : Software error in overdue_notices.pl if there is no active currency If there is no active currency, when running overdue_notices.pl you get a sofware error "Can't use an undefined value as a HASH reference" on GetCurrency() function call With this patch, if there is no active currency, fines are formated by default 0,00 and notices are correctly generated. Test plan : - have at least one borrower with overdue that should trigger a notice - verify that there is no active currency (Adminitration > Currency & Exchange rates) - run misc/cronjobs/overdue_notices.pl -v -n (to get the notice directly on output) => without the patch you get the software error => with the patch, notices are correctly generated If an active currency is defined, the script overdue_notices.pl runs the same with or without patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 08:10:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 06:10:57 +0000 Subject: [Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 08:11:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 06:11:54 +0000 Subject: [Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8378 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 08:11:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 06:11:54 +0000 Subject: [Koha-bugs] [Bug 8378] syntax not working on overdues anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10664 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 08:14:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 06:14:00 +0000 Subject: [Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 08:14:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 06:14:12 +0000 Subject: [Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if there is no active currency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |sophie.meynieux at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 09:06:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 07:06:07 +0000 Subject: [Koha-bugs] [Bug 9916] Use DataTables in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9916 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #2 from Srdjan Jankovic --- On opac-serial-issues.pl?selectview=full I got "currentYear is not defined". Is that just my setup? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 09:13:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 07:13:57 +0000 Subject: [Koha-bugs] [Bug 10004] Delay batch record count updates until the end of the z39.50 search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10004 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED --- Comment #10 from M. de Rooy --- Bug 10462 has resolved the issue of the unused batch record counts for Z3950 search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 09:24:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 07:24:38 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Derryn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |derrynj at gmail.com --- Comment #62 from Derryn --- I would like to voice my annoyance at this bug. We have no printer, no need or want for receipts. Why should our users be forced to get out the mouse/keyboard and hit no every time they log out? This should be an option in the preferences and not forced upon everyone. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 09:27:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 07:27:47 +0000 Subject: [Koha-bugs] [Bug 10663] Holds never block renewals In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 --- Comment #9 from Katrin Fischer --- The more I look into this the more I think that GetReserveStatus is not suitable to determine if something is "Reserved" on title level. For item level holds we have the itemnumer and all is fine, given the patch I wrote is applied. To determine if an item can fill a title level hold is much more complicated. I don't think CheckReserves is perfect for this job either - but it might be worth reverting to using this in CanBookBeRenewed and try to improve after restoring the old behaviour. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 09:32:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 07:32:30 +0000 Subject: [Koha-bugs] [Bug 10642] Inappropriate uses of $sth->finish() in C4::RotatingCollections.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10642 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10653 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 09:32:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 07:32:30 +0000 Subject: [Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 kenza changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10642 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 09:55:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 07:55:34 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #63 from Chris Cormack --- (In reply to Derryn from comment #62) > I would like to voice my annoyance at this bug. > > We have no printer, no need or want for receipts. > Why should our users be forced to get out the mouse/keyboard and hit no > every time they log out? > This should be an option in the preferences and not forced upon everyone. Awesome, I look forward to your patch implementing this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 10:07:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 08:07:57 +0000 Subject: [Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 --- Comment #4 from kenza --- (In reply to Srdjan Jankovic from comment #3) > t/db_dependent/RotatingCollections.t .. 1/41 DBD::mysql::db do failed: > Cannot delete or update a parent row: a foreign key constraint fails > (`koha`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY (`borrowernumber`) > REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE) at > t/db_dependent/RotatingCollections.t line 41. > DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign > key constraint fails (`koha`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN > KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE > CASCADE) at t/db_dependent/RotatingCollections.t line 41. > > Is my db out of sync? I just try and indeed if i just do prove t/db_dependent/RotatingCollections.t , i have the same errors. But if i'm in root or if i do sudo prove t/db_dependent/RotatingCollections.t, it works! I really don't understand why. I'll try to fix this problem... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 10:20:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 08:20:51 +0000 Subject: [Koha-bugs] [Bug 10665] New: koha-index-daemon-ctl.sh needs mysql dependency Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10665 Bug ID: 10665 Summary: koha-index-daemon-ctl.sh needs mysql dependency Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org koha-index-daemon-ctl.sh is a init script for koha-index-daemon from Koha::Contrib::Tamil::IndexerDaemon. When starting system, this script needs to be started after the MySQL server because it uses it to access to Koha database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 10:29:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 08:29:25 +0000 Subject: [Koha-bugs] [Bug 10665] koha-index-daemon-ctl.sh needs mysql dependency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10665 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 10:32:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 08:32:20 +0000 Subject: [Koha-bugs] [Bug 10665] koha-index-daemon-ctl.sh needs mysql dependency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10665 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 19992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19992&action=edit Bug 10665 - koha-index-daemon-ctl.sh needs mysql dependency Proposed patch. Without this patch, the log file show on startup : DBD::mysql::st execute failed: MySQL server has gone away at /usr/local/share/perl/5.14.2/Koha/Contrib/Tamil/IndexerDaemon.pm line 71. DBD::mysql::st fetchrow failed: fetch() without execute() at /usr/local/share/perl/5.14.2/Koha/Contrib/Tamil/IndexerDaemon.pm line 73. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 11:26:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 09:26:15 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19553|0 |1 is obsolete| | --- Comment #65 from Fridolyn SOMERS --- Created attachment 19993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19993&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 11:26:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 09:26:54 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19554|0 |1 is obsolete| | --- Comment #66 from Fridolyn SOMERS --- Created attachment 19994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19994&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 1 Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 11:27:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 09:27:30 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19555|0 |1 is obsolete| | --- Comment #67 from Fridolyn SOMERS --- Created attachment 19995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19995&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 2 Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 11:28:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 09:28:59 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19678|0 |1 is obsolete| | --- Comment #68 from Fridolyn SOMERS --- Created attachment 19996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19996&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 3 Rebased master. I recreated this patch manually. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 11:29:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 09:29:45 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19679|0 |1 is obsolete| | --- Comment #69 from Fridolyn SOMERS --- Created attachment 19997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19997&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 4 Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 11:30:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 09:30:13 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 11:39:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 09:39:22 +0000 Subject: [Koha-bugs] [Bug 10666] New: Daily quotes tests are failing Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10666 Bug ID: 10666 Summary: Daily quotes tests are failing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In t/db_dependent/Koha.t, the test "Got a quote based on today's date" is failing : $prove t/db_dependent/Koha.t : t/db_dependent/Koha.t .. 1/6 # Failed test 'Got a quote based on today's date.' # at t/db_dependent/Koha.t line 126. # Compared $data->{"source"} # got : 'Herbert Hoover' # expect : 'Abraham Lincoln' # Be sure to run this test on a clean install of sample data. # Looks like you failed 1 test of 4. # Failed test 'Daily Quotes Test' # at t/db_dependent/Koha.t line 129. Looks like the wrong quote is returned by GetDailyQuote(). I'm using a databased created with the English sample SQL datas. I think I found the cause : The test "Got a random quote." calls GetDailyQuote('random'=>1) which changes the quote timestamp to now. When then testing GetDailyQuote(), this quote (which may not be the one created by test) is the most recent quote. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 11:41:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 09:41:40 +0000 Subject: [Koha-bugs] [Bug 10666] Daily quotes tests are failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10666 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 19998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19998&action=edit Bug 10666 - Daily quotes tests are failing See commit message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 11:43:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 09:43:14 +0000 Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15248|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 19999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19999&action=edit Bug 8769 - Allow SIP2 return backdating Currently Koha's SIP server ignores the return date part of an 09 ( aka CHECKIN ) message. Koha should backdate a return, and remove fines accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 11:47:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 09:47:31 +0000 Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19999|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 20000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20000&action=edit Bug 8769 - Allow SIP2 return backdating Currently Koha's SIP server ignores the return date part of an 09 ( aka CHECKIN ) message. Koha should backdate a return, and remove fines accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 13:11:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 11:11:57 +0000 Subject: [Koha-bugs] [Bug 10666] Daily quotes tests are failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10666 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 13:11:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 11:11:59 +0000 Subject: [Koha-bugs] [Bug 10666] Daily quotes tests are failing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10666 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19998|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 20001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20001&action=edit Bug 10666 - Daily quotes tests are failing In t/db_dependent/Koha.t, the test "Got a quote based on today's date" is failing : $prove t/db_dependent/Koha.t : t/db_dependent/Koha.t .. 1/6 # Failed test 'Got a quote based on today's date.' # at t/db_dependent/Koha.t line 126. # Compared $data->{"source"} # got : 'Herbert Hoover' # expect : 'Abraham Lincoln' # Be sure to run this test on a clean install of sample data. # Looks like you failed 1 test of 4. Looks like the wrong quote is returned by GetDailyQuote(). I'm using a databased created with the English sample SQL datas. I think I found the cause : The test "Got a random quote." calls GetDailyQuote('random'=>1) which changes the quote timestamp to now. When then testing GetDailyQuote(), this quote (which may not be the one created by test) is the most recent quote. This patch moves the "Got a random quote." test after "Got a quote based on today's date" to solve the problem. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 13:47:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 11:47:52 +0000 Subject: [Koha-bugs] [Bug 10667] New: ILS-DI: AuthenticatePatron should also work with cardnumber Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10667 Bug ID: 10667 Summary: ILS-DI: AuthenticatePatron should also work with cardnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: katrin.fischer at bsz-bw.de Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org .../cgi-bin/koha/ilsdi.pl?service=Describe&verb=AuthenticatePatron Currently only username + password is supported. Authentication should also be possible with cardnumber + password to match OPAC authentication. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 13:54:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 11:54:43 +0000 Subject: [Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16602|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 20002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20002&action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons This patch adds a new tab to the patron side menu for purchase suggestions. >From this new tab, a librarian can view the patron's existing purchase suggestios and also create new suggestions in the name of that patron. Test Plan: 1) Apply patch 2) Ensure the system preference 'suggestions' is enabled 3) View the details for a patron 4) Click the new 'Purchase suggestions' tab 5) Click the 'New purchase suggestion' button 6) Add the new purchase suggestions 7) You should now end up back at the borrowers purchase suggetions 8) Verify the new purchase suggestion was added Signed-off-by: Corey Fuimaono Step though the test plan. All OK. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 13:55:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 11:55:06 +0000 Subject: [Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16603|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 20003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20003&action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 14:03:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 12:03:14 +0000 Subject: [Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 15:06:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 13:06:29 +0000 Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of Number-local-acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Fridolyn SOMERS --- Two last patches need signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 15:14:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 13:14:01 +0000 Subject: [Koha-bugs] [Bug 9916] Use DataTables in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9916 --- Comment #3 from Owen Leonard --- (In reply to Srdjan Jankovic from comment #2) > On opac-serial-issues.pl?selectview=full I got "currentYear is not defined". Thanks for testing Srdjan. Where did you see that error? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 15:26:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 13:26:08 +0000 Subject: [Koha-bugs] [Bug 9916] Use DataTables in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9916 --- Comment #4 from Owen Leonard --- Oh I see: If you navigate directly to "/cgi-bin/koha/opac-serial-issues.pl?selectview=full" without coming to it from an existing subscription you do get that error. You have to search for a biblio with a subscription and click the "subscriptions" tab. Click "more details" at the bottom, then the "full history" tab. There should be a biblionumber parameter: /cgi-bin/koha/opac-serial-issues.pl?selectview=full&biblionumber=XXX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 15:52:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 13:52:04 +0000 Subject: [Koha-bugs] [Bug 10304] Add avanced search filter for "not for loan" items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Owen Leonard --- This patch appears to break the "only available" option, whether it is used on its own or in conjunction with the new "only for loan" option. I get no results for a search which should return available items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 16:14:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 14:14:30 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18194|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall --- Created attachment 20004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20004&action=edit Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books Add checks in C4::ILS::Patron and C4::ILS::Transaction::Renew to make sure the patron is below the noissuescharge system pref for issues and OPACFineNoRenewals for renewals. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 16:14:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 14:14:44 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18195|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall --- Created attachment 20005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20005&action=edit Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 16:18:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 14:18:04 +0000 Subject: [Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #15 from Owen Leonard --- A couple of issues: - The template tries to build an old YUI-style button instead of the current Bootstrap version. - The table of suggestions should link to the suggestions detail page for that entry if the user has the correct permissions. (/cgi-bin/koha/suggestion/suggestion.pl?suggestionid=X&op=show I assume, a page which should probably be made more useful somehow). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 16:27:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 14:27:16 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 --- Comment #29 from Kyle M Hall --- Created attachment 20006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20006&action=edit Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books - Unit Test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 16:29:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 14:29:53 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 16:54:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 14:54:40 +0000 Subject: [Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 16:54:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 14:54:44 +0000 Subject: [Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 --- Comment #16 from Kyle M Hall --- Created attachment 20007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20007&action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons - QA Followup 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 16:56:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 14:56:39 +0000 Subject: [Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20007|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 20008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20008&action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons - QA Followup 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 16:58:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 14:58:16 +0000 Subject: [Koha-bugs] [Bug 10665] koha-index-daemon-ctl.sh needs mysql dependency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10665 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19992|0 |1 is obsolete| | --- Comment #2 from Fridolyn SOMERS --- Created attachment 20009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20009&action=edit Bug 10665 - koha-index-daemon-ctl.sh dependency I revised patch because indexer may use a remote MySQL server and so the dependency on $mysql may not be possible. I changed for $all as dependency at startup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 16:58:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 14:58:35 +0000 Subject: [Koha-bugs] [Bug 10665] koha-index-daemon-ctl.sh dependency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10665 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|koha-index-daemon-ctl.sh |koha-index-daemon-ctl.sh |needs mysql dependency |dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 17:07:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 15:07:20 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Kyle M Hall --- (In reply to Liz Rea from comment #3) > Hi, > > Tried to test this, got the following: > > Falling back to patching base and 3-way merge... > Auto-merging tools/modborrowers.pl > CONFLICT (content): Merge conflict in tools/modborrowers.pl > Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt > Failed to merge in the changes. > Patch failed at 0001 Bug 10612 - Add ability to delete patrons with batch > patron modification tool It applied fine for me. Did you apply all the dependencies? First you need to apply 8798, then 10565, then finally this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 17:19:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 15:19:32 +0000 Subject: [Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628 --- Comment #5 from Kyle M Hall --- Created attachment 20010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20010&action=edit Bug 10628 - AutomaticItemReturn prevents holds queue from filling local holds with local items - Switch grep to any -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 17:50:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 15:50:37 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19882|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 17:50:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 15:50:42 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #118 from Jared Camins-Esakov --- Created attachment 20011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20011&action=edit Signed off 0001-Bug-10402-Move-contacts-to-separate-table.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 17:50:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 15:50:53 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #119 from Jared Camins-Esakov --- Patch tested and signoff automatically uploaded by Jared Camins-Esakov Clever commentary on the patch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 18:49:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 16:49:14 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #120 from Owen Leonard --- Created attachment 20012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20012&action=edit Bug 9223: Multiple values of AdvancedSearchTypes in suggestions Suggestion form uses C4::Koha::GetSupportList to get a list of supports that can come from itemtypes or authoritized values LOC or CCODE. C4::Koha::GetSupportList uses AdvancedSearchTypes syspref like it has only one value. But this syspref can contain several values separated by a pipe. This patch introduces a new syspref SupportsAuthorizedValues to select wich authorized values category that represents the physical support (itemtypes by default, loc or ccode). These authorized values will be used in suggestion management, known as 'document type'. (Note that database field is still 'itemtype'). Test plan : ----------- - Set SupportsAuthorizedValues with itemtypes or loc or ccode - Get to suggestion form (OPAC or intranet) - Look at "Document type" combobox, it must contains descriptions of selected authorized values - Save the suggestion - Get to intranet suggestions management - Organize suggestions by document type => your suggestion must appear in a tab with its document type description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 18:49:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 16:49:24 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #121 from Owen Leonard --- Created attachment 20013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20013&action=edit Bug 9223: Add SupportsAuthorizedValues syspref (followup 1) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 18:49:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 16:49:34 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #122 from Owen Leonard --- Created attachment 20014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20014&action=edit Bug 9223 [Follow-up] Multiple values of AdvancedSearchTypes in suggestions This follow-up implements some things I think will improve on the previous patches: - Change the system preference name to "SuggestionsUseValues" - Change the description of the preference to "Suggestions can be submitted using the following authorized values:" - Move the new preference to the OPAC tab so that it is grouped with other suggestions-related preferences. - Add the option offer no itemtype/collection code chooser on the submission form. - Display the correct label on the submission form depending on the value of the SuggestionsUseValues preference. To test, apply this patch on top of the previous ones. Test submission of purchase suggestions through the OPAC and staff client with the SuggestionsUseValues preference set to all the various choices: item type, collection code, shelving location, and 'none.' The suggestion forms should look correct and work correctly. HOwEVER, neither the previous patches nor mine address the problem of the suggestions management page's "organize by" option, which is hard-coded to work with item types. Whether or not my patch is acceptable this issue will need to be addressed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 18:50:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 16:50:45 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20012|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 18:50:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 16:50:48 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20013|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 18:50:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 16:50:51 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20014|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 18:52:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 16:52:02 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14427|0 |1 is obsolete| | --- Comment #17 from Owen Leonard --- Created attachment 20015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20015&action=edit Bug 9223: Multiple values of AdvancedSearchTypes in suggestions Suggestion form uses C4::Koha::GetSupportList to get a list of supports that can come from itemtypes or authoritized values LOC or CCODE. C4::Koha::GetSupportList uses AdvancedSearchTypes syspref like it has only one value. But this syspref can contain several values separated by a pipe. This patch introduces a new syspref SupportsAuthorizedValues to select wich authorized values category that represents the physical support (itemtypes by default, loc or ccode). These authorized values will be used in suggestion management, known as 'document type'. (Note that database field is still 'itemtype'). Test plan : ----------- - Set SupportsAuthorizedValues with itemtypes or loc or ccode - Get to suggestion form (OPAC or intranet) - Look at "Document type" combobox, it must contains descriptions of selected authorized values - Save the suggestion - Get to intranet suggestions management - Organize suggestions by document type => your suggestion must appear in a tab with its document type description http://bugs.koha-community.org/show_bug.cgi?id=6473 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 18:52:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 16:52:17 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14428|0 |1 is obsolete| | --- Comment #18 from Owen Leonard --- Created attachment 20016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20016&action=edit Bug 9223: Add SupportsAuthorizedValues syspref (followup 1) http://bugs.koha-community.org/show_bug.cgi?id=6473 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 18:53:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 16:53:15 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 --- Comment #19 from Owen Leonard --- Created attachment 20017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20017&action=edit Bug 9223 [Follow-up] Multiple values of AdvancedSearchTypes in suggestions This follow-up implements some things I think will improve on the previous patches: - Change the system preference name to "SuggestionsUseValues" - Change the description of the preference to "Suggestions can be submitted using the following authorized values:" - Move the new preference to the OPAC tab so that it is grouped with other suggestions-related preferences. - Add the option offer no itemtype/collection code chooser on the submission form. - Display the correct label on the submission form depending on the value of the SuggestionsUseValues preference. To test, apply this patch on top of the previous ones. Test submission of purchase suggestions through the OPAC and staff client with the SuggestionsUseValues preference set to all the various choices: item type, collection code, shelving location, and 'none.' The suggestion forms should look correct and work correctly. HOWEVER, neither the previous patches nor mine address the problem of the suggestions management page's "organize by" option, which is hard-coded to work with item types. Whether or not my patch is acceptable this issue will need to be addressed. http://bugs.koha-community.org/show_bug.cgi?id=6473 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 18:55:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 16:55:00 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #20 from Owen Leonard --- I've attached rebased versions of the original patches along with mine. I'm setting back to "needs signoff" although I don't think this can go to QA without an additional followup for the issue I describe in comment 19. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 19:19:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 17:19:55 +0000 Subject: [Koha-bugs] [Bug 7518] searches with quotation marks don't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7518 --- Comment #37 from Fridolyn SOMERS --- (In reply to Galen Charlton from comment #36) > I'm having difficulty reproducing this bug. For those who can, perchance > are there any ZOOM error messages associated with it showing up in the > Apache error log? The best way is to look at Zebra server output. - launch Zebra server manually : zebrasrv -f /home/koha/etc/koha-conf.xml - Set syspref QueryWeightFields on - Perform a search on two words. For example : centre ville : - Look at zebrasrv log : 19:15:18-31/07 zebrasrv(4) [request] Search biblios OK 0 1 1+0 RPN @attrset Bib-1 @or @or @or @attr 1=36 @attr 4=1 @attr 6=3 @attr 9=32 @attr 2=102 "centre ville" @attr 1=4 @attr 4=1 @attr 6=3 @attr 9=28 @attr 2=102 "centre ville" @attr 1=36 @attr 4=1 @attr 9=26 @attr 2=102 "centre ville" @attr 4=6 @attr 9=14 @attr 2=102 "centre ville" - Perform a search with a double quote. For example : centre "ville : - Look at zebrasrv log : 19:15:13-31/07 zebrasrv(3) [request] Search biblios OK 0 1 1+0 RPN @attrset Bib-1 @or @attr 1=36 @attr 4=1 @attr 6=3 @attr 9=32 @attr 2=102 "centre ville or ti,ext,r2=centre ville" @attr 1=36 @attr 4=1 @attr 9=26 @attr 2=102 "centre ville or wrdl,r9=centre ville" => You see that with double quote, there is some unconverted CCL into PQF query : or wrdl,r9= -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 20:32:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 18:32:09 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #1 from Galen Charlton --- (In reply to David Cook from comment #0) > Currently, Koha only acts as a OAI-PMH server, I propose to add a harvesting > client as well (likely using the HTTP::OAI::Harvester module), so that Koha > can ingest records from other data sources (such as digital repositories > like Dspace). Interesting idea. > I've only started reading about it but despite initial reservations about > resumption tokens, I think the hardest part will not be with the retrieval > of records so much as the parsing of those records into MARC. This may be less of a problem in the long run with my plans to allow Koha to support multiple metadata formats (although even once that's available, you may still want the harvester to be able to convert the source metadata into something else). One thing I'd suggest is that the harvester keep a copy of the original metadata record in a database table; that would be more flexible than immediately converting it to MARC and discarding the source data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 21:36:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 19:36:12 +0000 Subject: [Koha-bugs] [Bug 10668] New: Improve suggestion detail page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668 Bug ID: 10668 Summary: Improve suggestion detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The suggestion detail page, shown if you click the title of a suggestion on the suggestion management page, could be more useful. I propose adding 'edit' and 'delete' buttons so that there are other options besides simply going back. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 21:47:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 19:47:24 +0000 Subject: [Koha-bugs] [Bug 10668] Improve suggestion detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 21:47:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 19:47:28 +0000 Subject: [Koha-bugs] [Bug 10668] Improve suggestion detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668 --- Comment #1 from Owen Leonard --- Created attachment 20018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20018&action=edit Bug 10668 - Improve suggestion detail page This patch makes several improvements to the suggestions template: - Improved breadcrumbs and page title. - Fixed a JavaScript error which appeared when viewing or editing a suggestion. - Added an 'Edit' and a 'Delete' button to the suggestion detail page. - Corrected capitalization. To test: - Perform various operations with suggestions management and confirm that page titles and breadcrumbs are correct. - View the detail page for an individual suggestion and confirm that the edit and delete buttons work correctly. - Confirm that there are no JavaScript errors when viewing or editing a suggestion, in particular when changing Acquisition information (quantity, currency, price). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 21:52:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 19:52:57 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19808|0 |1 is obsolete| | --- Comment #15 from Jared Camins-Esakov --- Created attachment 20019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20019&action=edit Bug 10402: Use an object for contacts In preparation for adding the ability to handle multiple contacts, this patch moves booksellers' contacts into their own class, C4::Bookseller::Contact. To test: 1) Apply patch. 2) Run database update. 3) Edit a bookseller, making sure to add a contact. 4) View the bookseller's information, making sure the contact information is there. 5) Run the unit test: > prove t/db_dependent/Bookseller.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 21:53:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 19:53:07 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19809|0 |1 is obsolete| | --- Comment #16 from Jared Camins-Esakov --- Created attachment 20020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20020&action=edit Bug 10402: Move contacts to separate table This patch normalizes the data structures used for bookseller contacts. To test: 1) Repeat tests described on previous patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 21:53:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 19:53:14 +0000 Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19810|0 |1 is obsolete| | --- Comment #17 from Jared Camins-Esakov --- Created attachment 20021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20021&action=edit Bug 10402: Add ability to enter multiple contacts Some vendors may have more than one contact. For example, a technical contact and a billing contact, or a contact for journals and a contact for monographs. Rather than require that each contact be either made into a separate vendor or recorded somewhere outside of Koha, it would be really useful of Koha had the ability to add multiple additional contacts to vendors in the Acquisitions module. To test: 1) Apply patch. 2) Edit a bookseller, making sure to add a contact. 3) View the bookseller's information, making sure the contact information is there. 4) Run the unit test: > prove t/db_dependent/Bookseller.t 5) Add multiple contacts to a vendor, see that they show up. 6) Delete one contact from a vendor with multiple contacts, see that the result is correct. 7) Sign off. Note: This test plan can supersede that on the previous two patches, as all functionality of the previous two patches is required by this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 21:59:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 19:59:01 +0000 Subject: [Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #18 from Owen Leonard --- This latest patch doesn't remove the YUI JavaScript, so even though the button looks correct there is still a JS error on the page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 22:37:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 20:37:51 +0000 Subject: [Koha-bugs] [Bug 10669] New: LiveDVD manager for 3.12 missing in about page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10669 Bug ID: 10669 Summary: LiveDVD manager for 3.12 missing in about page Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: About Assignee: nengard at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 22:41:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 20:41:36 +0000 Subject: [Koha-bugs] [Bug 10669] LiveDVD manager for 3.12 missing in about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10669 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 22:41:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 20:41:40 +0000 Subject: [Koha-bugs] [Bug 10669] LiveDVD manager for 3.12 missing in about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10669 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 20022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20022&action=edit Bug 10669 - LiveDVD manager for 3.12 missing in about page This fixes the error. Regards To+ Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 22:42:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 20:42:11 +0000 Subject: [Koha-bugs] [Bug 10669] LiveDVD manager for 3.12 missing in about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10669 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 22:44:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 20:44:15 +0000 Subject: [Koha-bugs] [Bug 10669] LiveDVD manager for 3.12 missing in about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10669 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 22:48:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 20:48:59 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19853|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 22:52:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 20:52:42 +0000 Subject: [Koha-bugs] [Bug 10669] LiveDVD manager for 3.12 missing in about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10669 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 22:52:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 20:52:52 +0000 Subject: [Koha-bugs] [Bug 10669] LiveDVD manager for 3.12 missing in about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10669 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 22:54:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 20:54:39 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19864|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 22:58:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 20:58:09 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19900|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 22:59:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 20:59:02 +0000 Subject: [Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #33 from Katrin Fischer --- Srdjan, could you confirm the patch works? There were 2 attachements, the second one contained changes that it seems were already part of the first patch, but only the second had your sign-off... *confused* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 23:11:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 21:11:11 +0000 Subject: [Koha-bugs] [Bug 10609] Use branch name rather than branch code in serials-collection.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 23:11:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 21:11:14 +0000 Subject: [Koha-bugs] [Bug 10609] Use branch name rather than branch code in serials-collection.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19966|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20023&action=edit [PASSED QA] Bug 10609 - Use branch name rather than branch code in serials-collection.pl The serials collection page displays branchcode instead of library name. This patch uses the Branches template plugin to display the library name instead. Also corrected: Added missing datatables config include to prevent a JavaScript error. To test, view the serials collection page for a subsciption with existing issues. Library names should be displayed instead of branchcodes. There should be no JavaScript errors reported by the browser. Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer Works well and uses the new TT plugin for displaying the branch name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 23:11:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 21:11:52 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 23:16:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 21:16:44 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 23:16:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 21:16:48 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19989|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer --- Created attachment 20024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20024&action=edit [PASSED QA] QA followup for bug 10320 - Fix copyright and style errors This patch fixes a copypasta'd copyright statement, and some incorrect POD and indentation. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 23:22:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 21:22:03 +0000 Subject: [Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 23:22:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 21:22:06 +0000 Subject: [Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 --- Comment #1 from Jared Camins-Esakov --- Created attachment 20025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20025&action=edit Bug 10404: add previous/next browsing to staff client Although previous/next browsing was added for searches in the OPAC in 2011, the staff client has been without any sort of search browsing. Until now. This patch is an all-singing, all-dancing, all-compatible implementation of search browsing that will work across multiple browser tabs and on any browser since IE7 (though the staff client layout is broken on IE7). To test: 1) Perform a search that will bring up multiple results. 2) View one of the results. 3) Use the Previous and Next links to browse along the search results. 4) Use the "Return to results" button to check that you end up at the correct page of results, even if you page through more than 20 records. 5) Sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 23:25:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 21:25:34 +0000 Subject: [Koha-bugs] [Bug 10644] C4::ClassSource.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10644 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 23:25:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 21:25:37 +0000 Subject: [Koha-bugs] [Bug 10644] C4::ClassSource.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10644 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19973|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 20026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20026&action=edit [PASSED QA] Bug 10644: ClassSource.pm needs unit tests The tests are wrap in a database transaction. To test: prove t/db_dependent/ClassSource.t t/db_dependent/ClassSource.t .. 1/24 prepare_cached(SELECT * FROM `class_sort_rules` WHERE `class_sort_rule` = ?) statement handle DBI::st=HASH(0x92dbedc) still Active at C4/ClassSource.pm line 249 prepare_cached(SELECT * FROM `class_sources` WHERE cn_source = ?) statement handle DBI::st=HASH(0x926876c) still Active at C4/ClassSource.pm line 137 attempting to use non-existent class sorting routine routine1 prepare_cached(SELECT * FROM `class_sort_rules` WHERE `class_sort_rule` = ?) statement handle DBI::st=HASH(0x92dbedc) still Active at C4/ClassSource.pm line 249 prepare_cached(SELECT * FROM `class_sources` WHERE cn_source = ?) statement handle DBI::st=HASH(0x926876c) still Active at C4/ClassSource.pm line 137 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.12 cusr 0.01 csys = 0.15 CPU) Result: PASS Signed-off-by: Srdjan Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 23:27:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 21:27:06 +0000 Subject: [Koha-bugs] [Bug 10644] C4::ClassSource.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10644 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20026|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 20027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20027&action=edit [PASSED QA] Bug 10644: ClassSource.pm needs unit tests The tests are wrap in a database transaction. To test: prove t/db_dependent/ClassSource.t t/db_dependent/ClassSource.t .. 1/24 prepare_cached(SELECT * FROM `class_sort_rules` WHERE `class_sort_rule` = ?) statement handle DBI::st=HASH(0x92dbedc) still Active at C4/ClassSource.pm line 249 prepare_cached(SELECT * FROM `class_sources` WHERE cn_source = ?) statement handle DBI::st=HASH(0x926876c) still Active at C4/ClassSource.pm line 137 attempting to use non-existent class sorting routine routine1 prepare_cached(SELECT * FROM `class_sort_rules` WHERE `class_sort_rule` = ?) statement handle DBI::st=HASH(0x92dbedc) still Active at C4/ClassSource.pm line 249 prepare_cached(SELECT * FROM `class_sources` WHERE cn_source = ?) statement handle DBI::st=HASH(0x926876c) still Active at C4/ClassSource.pm line 137 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.12 cusr 0.01 csys = 0.15 CPU) Result: PASS Signed-off-by: Srdjan Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 23:29:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 21:29:31 +0000 Subject: [Koha-bugs] [Bug 10644] C4::ClassSource.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10644 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20027|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 20028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20028&action=edit [PASSED QA] Bug 10644: ClassSource.pm needs unit tests The tests are wrap in a database transaction. To test: prove t/db_dependent/ClassSource.t t/db_dependent/ClassSource.t .. 1/24 prepare_cached(SELECT * FROM `class_sort_rules` WHERE `class_sort_rule` = ?) statement handle DBI::st=HASH(0x92dbedc) still Active at C4/ClassSource.pm line 249 prepare_cached(SELECT * FROM `class_sources` WHERE cn_source = ?) statement handle DBI::st=HASH(0x926876c) still Active at C4/ClassSource.pm line 137 attempting to use non-existent class sorting routine routine1 prepare_cached(SELECT * FROM `class_sort_rules` WHERE `class_sort_rule` = ?) statement handle DBI::st=HASH(0x92dbedc) still Active at C4/ClassSource.pm line 249 prepare_cached(SELECT * FROM `class_sources` WHERE cn_source = ?) statement handle DBI::st=HASH(0x926876c) still Active at C4/ClassSource.pm line 137 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.12 cusr 0.01 csys = 0.15 CPU) Result: PASS Signed-off-by: Srdjan Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 31 23:31:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 Jul 2013 21:31:57 +0000 Subject: [Koha-bugs] [Bug 10644] C4::ClassSource.pm needs unit tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10644 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Hi Kenza, I have fixed(?) your name and email address to what it was in your last patch going in - could you check if I did it right? You may also want to change your git configuration to have the email address of your choice and your full name in the patches. -- You are receiving this mail because: You are watching all bug changes.