[Koha-bugs] [Bug 5336] Acq history search

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |

--- Comment #52 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan,

I really like the idea of this. Starting with a code review and running the
automated tests on the codes I found a few things:

1) The updatedatabase states:
+    print "Upgrade to $DBversion done (Add category ORDRSTATUS values in
authorised_values table)\n";
But it does not actually add an authorised value? And it looks like we don't
need one and can have the values in the template, so it might just be enough to
correct the line. Please also add the bug number :)

2) Hm not sure about this line, does it maybe belong to 5394?
order.internalnotes ) %][% order.internalnotes %]<br />[% END %][% order.isbn
%]</td>

3) Capitalization:
<legend>Search Orders</legend>
+            <label for="orderstatus">Order Status: </label>

4) Patches fail the QA script:
 FAIL    t/db_dependent/Acquisition/close_reopen_basket.t
   OK      pod
   OK      forbidden patterns
   FAIL      valid
        Use of qw(...) as parentheses is deprecated 
   OK      critic


5) Checking my database and comparing it to kohacstructure in your patch, the
order of subscriptionid and parent_ordernumber are reversed. Not really sure
how to explain that right now, so just noting.

Will continue to test as nothing is severe so far, but can you please provide a
follow-up?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.