[Koha-bugs] [Bug 7180] Order from staged file improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #38 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #36)

Thanks Katrin for this helpful feedback!

> 1) The green color for selected lines seems debatable given the overall look
> and feel of the Koha GUI. Can you please reconsider?

I removed the green color.

> 2) The form has a few design issues - the labels and fields are not properly
> aligned in a smaller window, making it hard to figure out what goes where.
> It might fit a bit better into 2 columns and smaller fields for quantity,
> price and discount.

Done, now I use the fieldset with the "rows" css class.

> Also required fields should be highlighted and the
> input should be validated. Like there is no complaint if you don't input the
> quantity.

The quantity label now use the "required" css class. I added a javascript check
too.

> 3) The label budget is wrong and should be fund instead.
Fixed.

> Also the list shows funds from inactive budgets.
Yes but since the record select a value in the dropdown list, the fix is not
quite easy. I prefer to do it later.

> 4) In comparison to the normal form we are missing the option to set the
> currency in the form. I think it might be safe to assume that all records in
> that list will be one and the same currency, but it's not clear how to
> indicate the currency to be used.

The currency used, for all records, is the default currency. Which is the one
selected in the "Accounting details" block. I don't know how to make that much
clearer.

> 5) When you select a fund that is connected to an authorised value list and
> then undo the selection, you end up with the string "undefined" in the input
> field.

Fixed.


> Some ideas:
> 
> - I think instead of having the full form on each entry it would save a lot
> of space if we could only display it for selected records and keep the
> smaller layout for when now records are selected.

Hum, I tried something, but I am not a great ergonomist...

> - There is no option to see more about the record and we are only displaying
> 245$a it seems, which is not really helpful if you have lots of similar
> records. Showing a link to the ISBD/MARC preview might help that.

Done.


> - Instead of no_match we should be displaying a nicer text for the librarian.

Done.

> - It might be worth adding an option to pick the right tax rate.

Mathieu Saby already asked for that (comment 10), but it is not planned for
now.


Note: This patch is impacted by the bug 10522, it introduces side-effects with
this feature.

-- 
You are receiving this mail because:
You are watching all bug changes.