[Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation)

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18619|0                           |1
        is obsolete|                            |

--- Comment #19 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 19379
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19379&action=edit
[SIGNED-OFF] Bug 9032: Share a list (part 1: send the invitation)

Adds a Share button for OPAC private lists.
Allows you to send an invitation to share a list.
Checks on validity of email addresses (with Email::Valid).

NOTE: This patch adds a routine to VirtualShelves.pm but does not add a test
in VirtualShelves.t. This is intentional: I will still add a test, but saw
report 10290 and came across a few other problems in this unit test. Will
add a patch under report 10386.

Test plan:

1) Sharing depends on syspref and login.
Toggle the pref OpacAllowSharingPrivateList.
If enabled, you should see the Share button in OPAC/Private lists.
Click on the Share button. You should get Share a list.
Logout and try to go back to opac/opac-shareshelf.pl
It should now present you the login form.

2) Try to share a public list or a list you do not own.
Find a security hole in the interface. Or hack the shareshelf URL and replace
the shelfnumber with a public list number.

3) Enter no email address or invalid ones (no domain, forbidden chars).
If you enter no address, submit should not work.
If you enter only wrong addresses (separated by: ,:; ), you get a message.

4) Test if sending the invitation works.
Share one of your private lists. Enter your own email address.
After your proc_message_queue cronjob ran, you should have an email.
Check also if you see a new record in the virtualshelfshares table.
Note that the followup patch handles the second part of accepting this share.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.