[Koha-bugs] [Bug 5336] Acq history search

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #63 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 19317
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19317
Bug 5336:Order search (search and UI enhancements)

Review of attachment 19317:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5336&attachment=19317)
-----------------------------------------------------------------

::: C4/Acquisition.pm
@@ +2134,2 @@
>  
> +    $query .= " AND (datecancellationprinted is NULL or datecancellationprinted='0000-00-00') " if $orderstatus ne '4';

Checking for status 4 here...

@@ +2697,5 @@
> +    my $query        = "
> +        SELECT COUNT( DISTINCT( biblionumber ) )
> +        FROM   aqorders
> +        WHERE  basketno = ?
> +            AND (datecancellationprinted IS NULL OR datecancellationprinted='0000-00-00')

... but not checking for status 4 here?

::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt
@@ +57,5 @@
> +                <option value="0">New</option>
> +                <option value="1">Ordered</option>
> +                <option value="2">Partial</option>
> +                <option value="3">Complete</option>
> +                <option value="4">Deleted</option>

Maybe instead of Deleted we should be using Cancelled. For easier and better
translation we could also go a bit further and say:

New orders/?
Open orders/Pending orders
Partially received orders
Received orders
Cancelled orders

Only an idea, native speakers should check before implementing any change :)

New/ordered could lead to misunderstandings. I think new are not send to the
vendor (basket still open) and ordered are supposed to have been sent out. But
I am not sure how to reflect that better.

-- 
You are receiving this mail because:
You are watching all bug changes.