[Koha-bugs] [Bug 9282] authorities auto-completion in mainmainentry

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9282

Jared Camins-Esakov <jcamins at cpbibliography.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |In Discussion

--- Comment #11 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
(In reply to M. de Rooy from comment #10)
> Looks quite good to me, but I am wondering about this now:
> 
>             } elsif ($tag eq '180') {
>                 $subfields_to_report = 'vxyz';
> [etc. etc. etc.]
>             if ($subfields_to_report) {
>                 push @authorized, {
>                     heading => $field->as_string($subfields_to_report),
>                     hemain  => $field->subfield(
> substr($subfields_to_report, 0, 1) ),
> 
> If you use the first char here, you will take $v into hemain. But I think
> that you should take $x for the 18X fields.
> I would like to see a response from Jared here, as I assume that he was
> responsible for quite some changes in this module. Could you please attract
> his attention? Thanks.

As hemain is used for mainmainentry, the search does not make sense for 18x
authorities anyway, as there is no Main Entry for 18x authorities. However,
since 18x authorities are not supported in any useful way by Koha, and probably
never will be, I see no problem with pushing the code as-is.

-- 
You are receiving this mail because:
You are watching all bug changes.