[Koha-bugs] [Bug 10584] New: Hide OPAC bibilo details if all items are hidden or there are no items.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584

            Bug ID: 10584
           Summary: Hide OPAC bibilo details if all items are hidden or
                    there are no items.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: mtompset at hotmail.com

Using the OpacHiddenItems systempreference, items can be hidden. However, it
looks strange to have a biblio entry in the OPAC if all the items are hidden or
there are no items. In this case, hide the biblio too.

Test
====
1) Find a biblio with multiple item records across multiple branches.
2) View it in OPAC.
3) In the staff client hide one of the branches using OpacHiddenItems.
4) Refresh the OPAC details. There should be less, because of the hidden
branch.
5) In the staff client hide all of the branches (e.g. homebranch: [BR01,BR02])
6) Refresh the OPAC details. A biblio entry with no items will be displayed.
7) In the staff client enter a dummy biblio record, with no items.
8) View the OPAC details for that biblio. A biblio entry with no items will be
displayed.

NOTE: There is a tiny scope creep, in that a silent warning hazard for the
biblionumber was also corrected. (forgive me)

9) Go to .../cgi-bin/koha/opac-detail.pl?biblionumber= with no number entered. 
There should be a 404 output page.
10) Check the opac error log file. There should be a warning related to the
int(undef)
11) Apply the patch.
12) Go to .../cgi-bin/koha/opac-detail.pl?biblionumber= with no number entered.
 There should be a 404 output page.
13) There should be no new warning.
14) Go to the dummy biblio that you entered
(.../cgi-bin/koha/opac-detail.pl?biblionumber=#####). There should be a 404
output page.
15) Go back to the initial biblionumber
(.../cgi-bin/koha/opac-detail.pl?biblionumber=#####).  There should be a 404
output page.

Displaying 404.pl is not the best or correct solution (see bug 2318's comment
discussion), but it is sufficient, until that gets corrected.

-- 
You are receiving this mail because:
You are watching all bug changes.