[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639

--- Comment #41 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 18964
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18964
[Signed off] Bug 7639 - system preference to forgive fines on lost items

Review of attachment 18964:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7639&attachment=18964)
-----------------------------------------------------------------

::: C4/Circulation.pm
@@ +3281,3 @@
>  
>  
>  sub LostItem{

LostItem seems a bit undertested. Could you throw in some regression tests?

::: cataloguing/additem.pl
@@ +607,5 @@
>          $itemnumber="";
>      }
> +  my $item = GetItem( $itemnumber );
> +    my $olditemlost =  $item->{'itemlost'};
> +    my $newitemlost = $itemtosave->subfield('952','1');

(Major) This won't work for UNIMARC, please check which field is linked to
items.lost instead.

::: installer/data/mysql/updatedatabase.pl
@@ +6993,5 @@
> +$DBversion = "3.13.00.XXX";
> +if (C4::Context->preference("Version") < TransformToNum($DBversion)) {
> +    $dbh->do("INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES('WhenLostForgiveFine','0',NULL,'If ON, Forgives the fines on an item when it is lost.','YesNo')");
> +    $dbh->do("INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES('WhenLostChargeReplacementFee','1',NULL,'If ON, Charge the replacement price when a patron loses an item.','YesNo')");
> +    print "Upgrade to $DBversion done (Added sysprefs WhenLostForgiveFine and WhenLostChargeReplacementFee)\n";

(Trivial) - Please add the bug number here for reference.

-- 
You are receiving this mail because:
You are watching all bug changes.