[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #16 from Jonathan Druart <jonathan.druart at biblibre.com> ---
QA comment:

1/ On tools/manage-marc-import.pl, I got a JS error: 
  aoData.push( { "name": "import_batch_id", "value":  } );
The table should not be displayed if there is no import_batch_id parameter.

2/ I got another JS error clicking on the title
  SyntaxError: syntax error: void()
Prefer a href="#"

3/ The DT aLengthMenu parameter should contain an "All" entry (git grep
"aLengthMenu.*All")

4/ Why do you comment lines in tools/manage-marc-import.pl instead of deleting
them?

5/ Why do you add a show_marc JS function instead of using the "classic" way
(link to showmarc.pl)?

6/ Permissions: manage-marc-import.pl needs the tools=>manage_staged_marc
permission and the ajax script needs editcatalogue. Don't you think we should
have the same one in both?

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.