[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
> 1/ On tools/manage-marc-import.pl, I got a JS error: 
>   aoData.push( { "name": "import_batch_id", "value":  } );
> The table should not be displayed if there is no import_batch_id parameter.

Fixed!

> 2/ I got another JS error clicking on the title
>   SyntaxError: syntax error: void()
> Prefer a href="#"

By bad, the call is supposed to be void(0). This appears to be the preferred
practice these days. The problem with href="#" is that it causes the page to
jump back to the top when clicked. This isn't a problem when the page does not
scroll vertically, but in this case it often will.

> 3/ The DT aLengthMenu parameter should contain an "All" entry (git grep
> "aLengthMenu.*All")

Fixed!

> 4/ Why do you comment lines in tools/manage-marc-import.pl instead of
> deleting them?

Fixed!

> 5/ Why do you add a show_marc JS function instead of using the "classic" way
> (link to showmarc.pl)?

The "classic" way uses greybox, which isn't compatible with DataTables built
from an ajax source. On the plus side, I'm using jQuery UI instead, and if we
switched all of them to jQuery UI, we could drop greybox as a dependency.

> 6/ Permissions: manage-marc-import.pl needs the tools=>manage_staged_marc
> permission and the ajax script needs editcatalogue. Don't you think we
> should have the same one in both?

Fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.