[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #20 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Kyle M Hall from comment #18)
> My bad, the call is supposed to be void(0). This appears to be the preferred
> practice these days. The problem with href="#"

No, using "javascript:" is not the preferred practice. More frequently you'll
see "return false" added to the onclick (at least in cases where "return false"
is what you want).

The ideal way to handle something like this is to design the inserted markup so
that the click event can be moved into the main JavaScript block (even better,
into a separate JavaScript file). Then the outcome of the click event can be
handled by something like this:

http://css-tricks.com/return-false-and-prevent-default/

This isn't an issue that should block QA, but is something to think about next
time.

-- 
You are receiving this mail because:
You are watching all bug changes.