[Koha-bugs] [Bug 10499] UT: VirtualShelves.t needs a database transaction

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jul 16 16:16:15 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10499

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gmcharlt at gmail.com

--- Comment #11 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to kenza from comment #3)
> The patch 10386 doesn't add the rollback, so i think these two patches are
> complementary.

As a general note, it is not necessary to explicitly call $dbh->rollback.  When
AutoCommit is off, DBD::mysql automatically issues a rollback when the script
ends, and if the script gets killed, the transaction never gets committed
either.

That said, it doesn't hurt anything to have the explicit rollback.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list