[Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue Jul 16 17:34:43 CEST 2013
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556
Galen Charlton <gmcharlt at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #11 from Galen Charlton <gmcharlt at gmail.com> ---
Thanks, Jonathan!
I've pushed the part of the patch that changed AddBookSeller to master, along
with a follow-up that adds a regression test.
However, I have not pushed the part that updates ModBookSeller on the following
grounds:
[1] That routine is not actually related to the bug.
[2] The proposed change to that routine is purely cosmetic. Cosmetic and
source reformatting patches really ought to be separate from ones that change
functionality or fix bugs.
[3] The proposed reformatting has issues -- in particular, I simply do not see
the point of the changes proposed to lines 240-254.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list