[Koha-bugs] [Bug 10573] French translation for printing a basketgroup

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573

--- Comment #4 from Christophe Croullebois <christophe.croullebois at biblibre.com> ---
Hello Owen and Katrin,
thx for your comments, in fact as often, I have made a little patch for a
customer who is waiting a quick and efficient result.
But I agree with you, the things are not very good in the present state.
I am not sure to well understand  what do you mean Owen, first about the
syspref '
OrderPdfFormat', in his actual state you have to put the right string in it, do
you mean it would be better to have a drop down list with 3 (with my french
patch) choices in it ? Well, this would be more ergonomic, yes.
In an older version of koha we had a second syspref to choose the pdf template
or maybe it was a specific dev. made by us, anyway I agree, it would be better
to have the opportunity to change the pdf template.
In the present state, the call of the pdf template is hard-coded in the
layoutXpages.pm, but I think it would be better to have the hand on the choice.
In fact the matter is that we have a .pm with text in it (the reason why I have
created a new one) and this .pm is pointing on a pdf template with some text
too. In the .pm you have also all the format for placing the text and the
numbers.
It is the reason why you have layout2pages.pm and layout3pages.pm, both in
English, in fact these .pm are kind of templates and need to be adapted, for
instance if the name or address of the library is too long, and over that
layer, you add the pdf file, and in the same way each library can change the
text in it or the place of a column, a frame...
So for a translation we have two files to create.
To resume, it would be better to have a ddl for the syspref and maybe an other
in the basketgroup.pl to choose the pdf template.
More, it would be better to have all the text in the pdf, the translation would
be easier.
But the purpose of my patch is just to have the printing in French with the
existing code, it does no more.
Maybe, Katrin and Owen, we  should create a new bug report for these
improvements ?

-- 
You are receiving this mail because:
You are watching all bug changes.