[Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |liz at catalyst.net.nz

--- Comment #11 from Liz Rea <liz at catalyst.net.nz> ---
I like this a lot. Like, a LOT. As in, I squeed when I was playing with it.
However, there is something really strange about the hover state of the buttons
- see http://img844.imageshack.us/img844/6169/iq7r.png  

That's Firefox 22 on Ubuntu Precise.

Also, the unit test seems to fail:

devlibrary-koha at wingardium-leviosa:/home/liz/koha-src/koha$ prove
t/db_dependent/PatronLists.t 
t/db_dependent/PatronLists.t .. 1/9 DBIx::Class::Carp::__ANON__():
"might_have/has_one" must not be on columns with is_nullable set to true
(Koha::Schema::Result::Borrower/cardnumber). This might indicate an incorrect
use of those relationship helpers instead of belongs_to. at
/usr/share/perl5/DBIx/Class/Relationship/HasOne.pm line 96
t/db_dependent/PatronLists.t .. 5/9 
#   Failed test 'AddPatronsToList works for cardnumbers'
#   at t/db_dependent/PatronLists.t line 38.
# Looks like you failed 1 test of 9.
t/db_dependent/PatronLists.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/9 subtests 

Test Summary Report
-------------------
t/db_dependent/PatronLists.t (Wstat: 256 Tests: 9 Failed: 1)
  Failed test:  5
  Non-zero exit status: 1
Files=1, Tests=9,  1 wallclock secs ( 0.02 usr  0.00 sys +  0.70 cusr  0.04
csys =  0.76 CPU)
Result: FAIL


Functional tests pass though... and I mean it when I say this is really
fantastic. People will throw confetti.

-- 
You are receiving this mail because:
You are watching all bug changes.