[Koha-bugs] [Bug 10441] UT: Testing AddShare in VirtualShelves.t

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Jul 18 16:34:00 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10441

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Quick review:

Please prefer "is" instead of "ok":

  ok(1 == $status, "deleted shelf $shelfnumber and its contents");
  is( $status, 1, "deleted shelf $shelfnumber and its contents");

and
  for my $i ( 0 .. 9 ) {
instead of
  for(my $i=0; $i<10;$i++){

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list