[Koha-bugs] [Bug 2969] Report Name should be mandatory for saved reports

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sat Jul 20 01:02:32 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2969

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19795|0                           |1
        is obsolete|                            |

--- Comment #4 from Liz Rea <wizzyrea at gmail.com> ---
Created attachment 19814
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19814&action=edit
Bug 2969 - Report Name should be mandatory for saved reports

This patch re-implements the database changes from the original patch
and adds an update for existing reports. It also reimplements the
client-side validation using the new built-in validation plugin and adds
coverage for SQL reports.

I have also added the "required" attribute to the SQL report textarea
since saving a report with no SQL triggers an error.

To test:

- Create a new guided report. Confirm that you cannot save your guided
  report without a report name.
- Create or edit a saved SQL report. Confirm that you cannot save your
  report without a name or without SQL.
- Confirm that the saved_sql table structure has been updated.

Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Functional tests pass, database tables look correct to me.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list