[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508

--- Comment #26 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---

> (although I would prefer that the tests, including regression tests, be in a
> separate patch from the one that changes the routines).

That is exactly what I'm trying to figure out - why do you find it easier that
way. I would always want them together. Not arguing at all, as a QA you
absolutely have right to ask for it to be delivered in a way that it suits you
(it will get merged all together in the end anyway), just finding it
interesting. 

> 
> But consider it in the context of this bug, which advertises itself as "UT:
> C4::Branch.pm needs unit tests", not "there are inappropriate uses of
> $sth->finish() in C4::Branches".  In other words, this is part of the
> ongoing process to improve test coverage, and it's mixing up *that* with
> changes to core routines that I object to.

I agree.

-- 
You are receiving this mail because:
You are watching all bug changes.