[Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528

--- Comment #12 from kenza <kenza.zaki at biblibre.com> ---
(In reply to Galen Charlton from comment #11)
> I have reservations about this patch.  Adding more unit tests is a good
> thing, obviously, and the proposed changes to functions in C4::Booksellers
> may be good things.  However, they don't belong squashed together in a
> single patch, particularly since the patch description provides no test plan
> for the staff interfaces -- and if you change core routines, there ought to
> be such a test plan included in the patch, even if the only thing it does is
> identify the interfaces whose visible behavior is not changed.
> 
> Please break it up, for example like this:
> 
> [1] A patch for this bug that *only* adds additional unit tests.
> [2] An additional bug for each change you propose to routines in
> C4::Booksellers, along with any changes to the test script.

Ok I will do that. Thanks for the advices.

-- 
You are receiving this mail because:
You are watching all bug changes.