[Koha-bugs] [Bug 10628] AutomaticItemReturn prevents holds queue from filling local holds with local items

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10628

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
I could not come up with a reliable test plan for this bug. However, inspection
of the code should be extremely simple. The patch actually contains two
changes, either of which solves the problem, but I see no reason not to include
both.

The first is is the removal of the use of AutomaticItemReturn to control if we
should try filling local holds with local items.

The second is the rather strange situation where the least_cost_branch
subroutine completely ignores the fact that the pickup branch might be in the
list of branches that can be pulled from.

I suggest both be implemented, the former for the fact that I cannot find any
reason for this behavior, and the latter ( though obviated by the former )
because in the future someone may again modify the holds queue system and not
realize that some code in MapItemsToHoldRequests would make this addition to
least_cost_branch unnecessary. It seems to me that a unit test for
least_cost_branch should fail immediately in it's current state. However, there
is, for some reason, no unit test for least_cost_branch itself in HoldsQueue.t

-- 
You are receiving this mail because:
You are watching all bug changes.