[Koha-bugs] [Bug 10629] Inappropriate uses of $sth->finish() in C4::Branch.pm

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10629

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19868|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 19910
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19910&action=edit
Bug 10629 : Inappropriate uses of $sth->finish() in C4::Branch.pm

Test plan :
Check if the regression tests still works
prove t/db_dependent/Branch.t
t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at
t/db_dependent/Branch.t line 207.
t/db_dependent/Branch.t .. ok
All tests successful.
Files=1, Tests=36,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.12 cusr  0.00
csys =  0.16 CPU)
Result: PASS

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

>From the man page

finsh()
Indicate that no more data will be fetched from this statement handle
before it is either executed again or destroyed.
You almost certainly do not need to call this method.

Adding calls to "finish" after loop that fetches all rows is a common
mistake, don't do it, it can mask genuine problems like uncaught fetch errors.

-- 
You are receiving this mail because:
You are watching all bug changes.