[Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462

--- Comment #13 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
> This patch changes what gets returned as the LCCN.  The acronym "LCCN" is 
> ambiguous, unfortunately, as it can refer to LC Control Number or LC Call 
> Number.  The current behavior of the Z39.50 search is to return the former 
> (i.e., the control number or LC-assigned identification number).

Good catch. Apparently mixed up these two tags with same acronym. The small
followup corrects that.

> Why replace the call to TransformMarcToKoha, which uses the installed default
> bibliographic framework to extract strings from the MARC record, with 
> hardcoding the tags and subfields for each MARC flavor?

Good question. The main reason was just optimization. I saw that we needed only
six fields from the MARC record for a simple display, and TransformMarcToKoha
is doing a transformation of the whole MARC record.
The original code contains a call to TransformMarcToKoha followed by a call to
ImportBreeding that again calls TransformMarcToKoha. Both calls have been
optimized. 'Downside' is indeed a few lines hardcoding tags in the sub
_add_rowdata.
Let me still see a moment if we can still improve some there in order to gain
more confidence :)

-- 
You are receiving this mail because:
You are watching all bug changes.