[Koha-bugs] [Bug 10640] ModBookseller needs more explicit return values in C4::Bookseller.pm

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Jul 25 10:07:44 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10640

--- Comment #1 from kenza <kenza.zaki at biblibre.com> ---
Created attachment 19938
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19938&action=edit
ModBookseller needs more explicit return values in C4::Bookseller.pm

Before, ModBookseller always returns undef. This patch modifies it in order to
be more explicit.
Now it returns :
1 -> If a modification has been done
0E0 -> If the given id doesn't exist
undef -> If no id given

It also fix one of the tests which didn't pass before in
t/db_dependent/Bookseller.t

To Test:
prove db_dependent/Bookseller.
Bookseller.t .. 1/55
[Some warnings about uninitialized values]
t/db_dependent/Bookseller.t .. ok
All tests successful.
Files=1, Tests=55,  1 wallclock secs ( 0.03 usr  0.00 sys +  0.46 cusr  0.04
csys =  0.53 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list