[Koha-bugs] [Bug 10643] Inappropriate uses of $sth->finish() in C4::ClassSource.pm

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jul 30 06:56:56 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |srdjan at catalyst.net.nz

--- Comment #2 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
I propose something even better then - get rid of prepare() all together. For
example:

* GetClassSources():
return $dbh->selectall_hashref("SELECT...", undef, 'cn_source');

* AddClassSource()
return $dbh->do("INSERT...", undef, @params)

etc. How often are those used to get advantage of prepare_cached()?
Good databases (tm) cache queries anyway, however not sure that MySQL does.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list