[Koha-bugs] [Bug 10666] Daily quotes tests are failing

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10666

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19998|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 20001
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20001&action=edit
Bug 10666 - Daily quotes tests are failing

In t/db_dependent/Koha.t, the test "Got a quote based on today's date" is
failing :
$prove t/db_dependent/Koha.t :
t/db_dependent/Koha.t .. 1/6
    #   Failed test 'Got a quote based on today's date.'
    #   at t/db_dependent/Koha.t line 126.
    # Compared $data->{"source"}
    #    got : 'Herbert Hoover'
    # expect : 'Abraham Lincoln'
    # Be sure to run this test on a clean install of sample data.
    # Looks like you failed 1 test of 4.

Looks like the wrong quote is returned by GetDailyQuote().
I'm using a databased created with the English sample SQL datas.

I think I found the cause :
The test "Got a random quote." calls GetDailyQuote('random'=>1) which changes
the quote timestamp to now. When then testing GetDailyQuote(), this quote
(which may not be the one created by test) is the most recent quote.

This patch moves the "Got a random quote." test after "Got a quote based on
today's date" to solve the problem.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.