[Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #7 from Chris Cormack <chris at bigballofwax.co.nz> ---
This seems to work well, 

1/ but could you please do a follow up fixing the text in the
ilsdi.pl?service=Describe&verb=CancelHold page

2/ Also we introduce 2 new subroutines, so could we get a unit test for each
one.

3/ Finally we do this

$query = qq{
            INSERT INTO old_reserves
            SELECT * FROM reserves
            WHERE reserve_id = ?
        };
        $sth = $dbh->prepare($query);
        $sth->execute($reserve_id);

        $query = qq{
            DELETE FROM reserves
            WHERE reserve_id = ?
        };
        $sth = $dbh->prepare($query);
        $sth->execute($reserve_id);

It would be safer/nicer to check the result of our execute into the
old_reserves before we delete it from reserves, if that insert fails we do the
delete anyway at the moment

Failing QA for 1 and 2, bonus points if you fix 3 also

-- 
You are receiving this mail because:
You are watching all bug changes.